回复: [PATCH 3/3] arch: unicore32: ksyms: export '__cpuc_coherent_kern_range' to avoid compiling failure

2014-05-26 Thread
- Chen Gang 写道: > flush_icache_range() is '__cpuc_coherent_kern_range' under unicore32, > and lkdtm.ko needs it. At present, '__cpuc_coherent_kern_range' is > still used by unicore32, so export it to avoid compiling failure. > > The related error (with allmodconfig under unicore32): > > E

回复: [PATCH 2/3] arch: unicore32: ksyms: export 'pm_power_off' to avoid compiling failure.

2014-05-26 Thread
- Chen Gang 写道: > Two driver modules need 'pm_power_off', so export it. > > The related error (with allmodconfig under unicore32): > > MODPOST 4039 modules > ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined! > ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undef

回复: [PATCH 1/3] arch: unicore32: ksyms: export additional find_first_*() to avoid compiling failure

2014-05-26 Thread
- Chen Gang 写道: > Some modules need find_first_bit() and find_first_zero_bit(), so export > them. > > The related error (with allmodconfig under unicore32): > > MODPOST 4039 modules > ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined! > ERROR: "find_first_zero_

回复: [PATCH 0/3] arch: unicore32: ksyms: export several implemeted symbols to avoid compiling failure

2014-05-26 Thread
- Chen Gang 写道: > unicore32 has implemented 'find_first_bit', 'find_first_zero_bit', > 'pm_power_off', and '__cpuc_coherent_kern_range', need export them to > avoid compiling failure. > > The related error (with allmodconfig under unicore32): > > MODPOST 4039 modules > ERROR: "find_fir

回复: Re: [PATCH linux-next] net/dccp/timer.c: use 'u64' instead of 's64' to avoid compiler's warning

2014-05-22 Thread
- David Miller 写道: > From: Chen Gang > Date: Wed, 21 May 2014 08:19:34 +0800 > > > 'dccp_timestamp_seed' is initialized once by ktime_get_real() in > > dccp_timestamping_init(). It is always less than ktime_get_real() > > in dccp_timestamp(). > > > > Then, ktime_us_delta() in dccp_timestam

回复: Re: 回复: [PATCH linux-next] net/dccp/timer.c: use 'u64' instead of 's64' to avoid compiler's warning

2014-05-21 Thread
- Chen Gang 写道: > On 05/22/2014 08:26 AM, 管雪涛 wrote: > > > > - Chen Gang 写道: > >> 'dccp_timestamp_seed' is initialized once by ktime_get_real() in > >> dccp_timestamping_init(). It is always less than ktime_get_real() > >> in d

回复: [PATCH] arch: unicore32: ksyms: export several implemeted symbols to avoid compiling failure

2014-05-21 Thread
This log is so big and tedious. I prefer to have three separated commits, and for find_first_*, only two line ERRORs are enough. Thanks. Xuetao - Chen Gang 写道: > unicore32 has implemented 'find_first_bit', 'find_first_zero_bit', > 'pm_power_off', and '__cpuc_coherent_kern_range', need expor

回复: [PATCH linux-next] net/dccp/timer.c: use 'u64' instead of 's64' to avoid compiler's warning

2014-05-21 Thread
- Chen Gang 写道: > 'dccp_timestamp_seed' is initialized once by ktime_get_real() in > dccp_timestamping_init(). It is always less than ktime_get_real() > in dccp_timestamp(). > > Then, ktime_us_delta() in dccp_timestamp() will always return positive > number. So can use manual type cast to le

回复: Re: 回复: Re: 回复: Re: 回复: [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure

2014-05-21 Thread
- Chen Gang 写道: > On 05/22/2014 07:59 AM, 管雪涛 wrote: > > - Chen Gang 写道: > >>>> - the other for additional 'clk_*' which are needed when HAVE_CLK. > >>>>I guess, just "copy/past" the other platforms' implementation

回复: Re: 回复: Re: 回复: [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure

2014-05-21 Thread
- Chen Gang 写道: > > > On 05/21/2014 05:23 PM, 管雪涛 wrote: > > > > - Chen Gang 写道: > >> > >> Yeah, I shall send patch v2 for it (within this week). And also thank > >> you for your review the other patches. > >> > >> BTW

回复: [PATCH v2] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure

2014-05-21 Thread
Acked-by: Xuetao Guan - Chen Gang 写道: > Add generic 'screen_info' just like another architectures have done > (e.g. tile, sh, score, ia64, hexagon, and cris). > > The related error (with allmodconfig under unicore32): > > LD init/built-in.o > drivers/built-in.o: In function `vga

回复: [PATCH v2] [PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for "enum pci_interrupt_cause"

2014-05-21 Thread
I checked these two files, and this patch looks good. And, I'll put it into unicore32 repo. Reviewed-by: Xuetao Guan - Chen Gang 写道: > The direct cause is IRQ_SPI is already defined as a macro in unicore32 > architecture (also, blackfin and mips architectures define it). The > related erro

回复: [PATCH 25/27] unicore32: Use common bits from generic tlb.h

2014-05-21 Thread
Great. Btw, please cc first email in this patch series to everyone. Acked-by: Xuetao Guan - Richard Weinberger 写道: > It is no longer needed to define them on our own. > > Cc: Guan Xuetao > Cc: Richard Weinberger > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Richard Weinberger > -

回复: Re: 回复: [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure

2014-05-21 Thread
- Chen Gang 写道: > > Yeah, I shall send patch v2 for it (within this week). And also thank > you for your review the other patches. > > BTW: I guess, it only leaves 2 kernel related issues for allmodconfig: > > - one for 'find_first*', 'cpuc_coherent_kern_range' and 'pm_power_off'. >I

回复: [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure

2014-05-21 Thread
- Chen Gang 写道: > Add generic 'screen_info' just like another architectures have done > (e.g. tile, sh, score, ia64, hexagon, and cris). > > The related error (with allmodconfig under unicore32): > > LD init/built-in.o > drivers/built-in.o: In function `vgacon_save_screen': > p

回复: [PATCH] arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure

2014-05-21 Thread
Thanks. For __muldi3, it is no longer used by gcc, so I think that's ok. For __bswapsi2, maybe it's because I copied it from arm. Acked-by: Xuetao Guan - Chen Gang 写道: > After check the code, 'bswapsi2' and 'muldi3' are useless for > unicore32, so can remove them to avoid compiling failure

Re: [PATCH v2] arch/unicore32/kernel/ksyms.c: remove 2 export symbols to avoid compiling failure

2014-05-21 Thread
Thanks, and this is a common error in most architectures. Acked-by: Xuetao Guan - Chen Gang 写道: > 'csum_partial' and 'csum_partial_copy_from_user' have already been > exported in "lib/", so need not export them again, or it will cause > compiling error. > > The related error (with allmodco

Re: [PATCH] drivers/video/fbdev/fb-puv3.c: Add header files for function unifb_mmap

2014-05-21 Thread
Thanks. Acked-by: Xuetao Guan - sunzc...@gmail.com 写道: > From: Zhichuang SUN > > Function unifb_mmap calls functions which are defined in linux/mm.h > and asm/pgtable.h > > The related error (for unicore32 with unicore32_defconfig): > CC drivers/video/fbdev/fb-puv3.o > dr

回复: Re: [PATCH 1/1] arch/unicore32/mm/ioremap.c: convert printk/warn_on to warn(1

2014-05-12 Thread
- Andrew Morton 写道: > On Tue, 6 May 2014 19:07:34 +0200 Fabian Frederick wrote: > > > +coalesce formats > > > > (This is untested) > > > > Cc: Guan Xuetao > > Cc: Andrew Morton > > Signed-off-by: Fabian Frederick > > --- > > arch/unicore32/mm/ioremap.c | 9 ++--- > > 1 file change

回复: [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0

2014-05-12 Thread
Acked-by: Xuetao Guan - Chen Gang 写道: > It is only a typo issue, the related commit: > > "1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()" > > The related error (for unicore32 with allmodconfig): > > CC [M] drivers/rtc/rtc-puv3.o > drivers/rtc/rtc-puv3.c: In f

回复: [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue

2014-05-12 Thread
Acked-by: Xuetao Guan - Chen Gang 写道: > It is only a typo issue, the related commit: > > "1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()" > > The related error (unicore32 with allmodconfig): > > CC [M] drivers/rtc/rtc-puv3.o > drivers/rtc/rtc-puv3.c: In funct

回复: [PATCH] arch/unicore32/include/asm/io.h: add readl_relaxed() generic definition

2014-05-12 Thread
Thanks. Acked-by: Xuetao Guan - Chen Gang 写道: > Need generic definition for readl_relaxed(), like other architectures > have done. Or can not pass compiling with allmodconfig, the related > error: > > CC [M] drivers/message/fusion/mptbase.o > drivers/message/fusion/mptbase.c: In fun

Re: [Suggestion] unicore32: About toolchain issues and source code.

2014-05-07 Thread
Cc: Greg Kroah-Hartman > On 05/01/2014 02:48 AM, Guenter Roeck wrote: > > Build results are at http://server.roeck-us.net:8010/builders. > > I'll fix it in this month. Also, Cc greg Thanks. Xuetao Guan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

回复: [PATCH] unicore32: include: asm: add missing ')' for PAGE_* macros in pgtable.h

2014-04-15 Thread
This problem has been fixed, but I didn't submit. Anyway, I can apply your version. Acked-by: Xuetao Guan - Chen Gang 写道: > Missing related ')', the related compiling error: > > CC [M] drivers/gpu/drm/udl/udl_fb.o > drivers/gpu/drm/udl/udl_fb.c: In function ‘udl_fb_mmap’: > driver

回复: [PATCH v3] arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM

2014-04-15 Thread
Acked-by: Xuetao Guan - Chen Gang 写道: > unicore32 supports STRICT_DEVMEM, so it needs devmem_is_allowed(), like > some of other architectures have done (e.g. arm, powerpc, x86 ...). > > The related error with allmodconfig: > > CC drivers/char/mem.o > drivers/char/mem.c: In funct

回复: [PATCH] arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM

2014-04-07 Thread
I'd like to put the code into asm/io.h, and make it static. > +#ifdef CONFIG_STRICT_DEVMEM > +/* > + * devmem_is_allowed() checks to see if /dev/mem access to a certain > + * address is valid. The argument is a physical page number. > + * We mimic x86 here by disallowing access to system RAM as we

回复: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk'

2014-04-07 Thread
Thanks, Acked-by: Xuetao Guan - Chen Gang 写道: > Need use 'clk' instead of 'mclk', which is the original removed local > variable. > > The related original commit: > > "652ed95 cpufreq: introduce cpufreq_generic_get() routine" > > The related error with allmodconfig for unicore32: > >

回复: [PATCH] arch/unicore32/include/asm/ptrace.h: add generic definition for profile_pc()

2014-03-24 Thread
Thanks Acked-by: Xuetao Guan - Chen Gang 写道: > Add generic definition just like another architectures have done, or > can not pass compiling with allmodconfig, the related error: > > CC kernel/profile.o > kernel/profile.c: In function ‘profile_tick’: > kernel/profile.c:419: er

回复: [PATCH] arch/unicore32/mm/alignment.c: include "asm/pgtable.h" to avoid compiling error

2014-03-24 Thread
Thanks, Acked-by: Xuetao Guan - Chen Gang 写道: > Need include "asm/pgtable.h" to include "asm-generic/pgtable-nopmd.h", > so can let 'pmd_t' defined. The related error with allmodconfig: > > CC arch/unicore32/mm/alignment.o > In file included from arch/unicore32/mm/alignment.c:24

回复: [PATCH] arch/unicore32/kernel/clock.c: add readl() and writel() for 'PM_' macros

2014-03-22 Thread
Thanks Chen. Cc: Zhichuang Sun Tested-by: Zhichuang Sun Acked-by: Xuetao Guan - Chen Gang 写道: > Add readl() and writel() for 'PM_' macros, just like another areas have > done within unicored32, or will cause compiling issue. > > The related error (allmodconfig for unicored32): > >

回复: [PATCH] arch/unicore32/kernel/module.c: use __vmalloc_node_range() instead of __vmalloc_area()

2014-03-22 Thread
Thanks Chen. Cc: Zhichuang Sun Tested-by: Zhichuang Sun Acked-by: Xuetao Guan - Chen Gang 写道: > __vmalloc_area() has already been removed from upstream kernel, need > use __vmalloc_node_range() instead of. > > The related commit: "d0a2126 mm: unify module_alloc code for vmalloc". > > T

Re: [PATCH] arch/unicore32/kernel/ksyms.c: remove several undefined exported symbols

2014-03-22 Thread
Thanks Chen. Need I add these patches to unicore32 repo? Cc: Zhichuang Sun Tested-by: Zhichuang Sun Acked-by: Xuetao Guan - Chen Gang 写道: > For 'csum_partial_copy_nocheck()', it has default definition in > 'asm-generic'. > > For '__raw_reads?()' and '__raw_writes?()' are used by the driv

回复: [Consult] unicore32: Is unicore32 still alive?

2014-03-17 Thread
Sorry for replying so late. I'd like to ack the patch after testing it. Maybe before this weekend. Thanks Chen. Xuetao Guan - Chen Gang 写道: > Hello all: > > As far as I know, unicore32 is still alive. If it will be obsoleted, > please let me know, so we can avoid the related spam about uni

回复: Re: [PATCH 1/1] __init setup_early_printk: missing initialization

2014-01-28 Thread
Thanks. Acked-by: Xuetao Guan - Andrew Morton 写道: > On Mon, 27 Jan 2014 19:10:24 +0100 xypron.g...@gmx.de wrote: > > > From: Heinrich Schuchardt > > > > If is based on uninitialized value keep_early. > > This leads to unpredictable result. > > > > ... > > > > --- a/arch/unicore32/kernel

回复: [PATCH 08/10] unicore32: select ARCH_MIGHT_HAVE_PC_SERIO

2013-12-15 Thread
It's ok to unicore32. Acked-by: Guan Xuetao - Mark Salter 写道: > Architectures which might use an i8042 for serial IO to keyboard, > mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO. > > Signed-off-by: Mark Salter > CC: Guan Xuetao > --- > arch/unicore32/Kconfig | 1 + > 1 file changed,

Re: converting unicore32 to gate_vma as done for arm (was Re: [PATCH] mm: cache largest vma)

2013-11-04 Thread
The patch is ok for unicore32. Thanks Al. While testing this patch, a bug is found in arch/unicore32/include/asm/pgtable.h: @@ -96,7 +96,7 @@ extern pgprot_t pgprot_kernel; | PTE_EXEC) #define PAGE_READONLY __pgprot(pgprot