Re:Re: linux-next: ERROR: build error for arm64

2020-12-06 Thread
At 2020-12-06 16:25:19, "Björn Töpel" wrote: Ok, thanks.

Re:Re: [PATCH] mm/memcontrol: replace '== root_mem_cgroup' with mem_cgroup_is_root

2020-11-04 Thread
At 2020-11-05 06:46:22, "Roman Gushchin" wrote: >On Wed, Nov 04, 2020 at 11:14:57PM +0800, Hui Su wrote: >> We have supplied the inline func: mem_cgroup_is_root(). >> So we may use mem_cgroup_is_root() instead of using >> 'memcg == root_mem_cgroup' or 'memcg != root_mem_cgroup' >> directly,

Re:Re: [PATCH] sched/rt.c: use list_is_singular() instead of '->prev != ->next'

2020-10-26 Thread
>Perhaps there should be a list_has_more_than_one() API, as list_is_singular >requires two checks, and the "more_than_one" only requires a single check. > >list_is_singular() is: > > return !list_empty(list) && (list->next == list->prev); > > >which is more work than what you are

Re:Re: [PATCH] blk: use REQ_OP_WRITE instead of hard code

2020-10-19 Thread
Yeah, you are right, thanks for your explanationMaybe we should define a MASK to do this? At 2020-10-19 22:09:40, "Johannes Thumshirn" wrote: >On 19/10/2020 16:06, Hui Su wrote: >> use REQ_OP_WRITE instead of hard code in >> op_is_write(). >> >> Signed-off-by: Hui Su >> --- >>

Re:Re:Re: [PATCH] mm: remove the redundancy code

2020-06-29 Thread
I did not find bug here, and i was just confused when I saw the code.Thanks. At 2020-06-30 10:06:55, "David Rientjes" wrote: >On Tue, 30 Jun 2020, 苏辉 wrote: > >> I am sorry that i did not consider the memory hotplug case, >> and i think we should add a new param