Re: Re: [PATCH v15 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-12-07 Thread
Hi Johan, Yes, I will post NFC code to Uboot,but it may take a while to modify the code for Uboot. -- yifeng >Hi Yifeng, > >Meanwhile, could you post a RFC version for Uboot based on this version >plus comments, so people can test the whole process from programming, >booting and

Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-11-03 Thread
Hi Johan, On 2020/10/31 19:58, Johan Jonker wrote: >Hi Yifeng, ... >> + >> +static int rk_nfc_read_page_hwecc(struct nand_chip *chip, u8 *buf, int >> oob_on, >> +  int page) >> +{ >> +struct mtd_info *mtd = nand_to_mtd(chip); >> +struct rk_nfc *nfc = nand_get_controller_data(chip);

Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-11-03 Thread
On 2020/11/3 1:11, Johan Jonker wrote: >On 11/2/20 6:00 PM, Miquel Raynal wrote: >> Hi Johan, >> >> Johan Jonker wrote on Mon, 2 Nov 2020 17:31:18 >> +0100: >> >>> On 11/2/20 2:11 PM, Johan Jonker wrote: Hi, On 11/2/20 2:07 PM, Miquel Raynal wrote: > Hi Johan, Yifeng >

Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-11-02 Thread
nks, Yifeng >Hello, > >赵仪峰 wrote on Mon, 2 Nov 2020 11:46:04 >+0800: > >> Hi Johan, >> >> void nand_deselect_target(struct nand_chip *chip) >> { >> if (chip->legacy.select_chip) >> chip->legacy.select_chip(chip, -1); >> >

Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-11-01 Thread
Hi Johan, void nand_deselect_target(struct nand_chip *chip) { if (chip->legacy.select_chip) chip->legacy.select_chip(chip, -1); chip->cur_cs = -1; } I need add the code below and it work.    chip->legacy.select_chip = rk_nfc_select_chip; But I found almost all

Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-10-30 Thread
Hi Miquel, >Hi Yifeng, > >A few more comments below, but overall looks better. > >Yifeng Zhao wrote on Wed, 28 Oct 2020 >17:53:24 +0800: > >> This driver supports Rockchip NFC (NAND Flash Controller) found on RK3308, >> RK2928, RKPX30, RV1108 and other SOCs. The driver has been tested using >>

Re: Re: [PATCH v12 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-10-23 Thread
Hi  Miquèl and Johan, I've fixed some comments, but there are still a few points I can`t understand. >Hi Yifeng, Miquèl and others, > >I've copied some comments from Miquèl from version 8 to this one here >and added some more. ;) > > >On 10/20/20 5:17 AM, Yifeng Zhao wrote: >> This driver

Re: Re: [PATCH v7 1/8] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller【请注意,邮件由robherri...@gmail.com代发】

2020-07-15 Thread
Hi Rob, >On Wed, 15 Jul 2020 17:03:39 +0800, Yifeng Zhao wrote: >> Documentation support for Rockchip RK3xxx NAND flash controllers >> >> Signed-off-by: Yifeng Zhao >> --- >> >> Changes in v7: >> - Fix some wrong define >> >> Changes in v6: >> - Fix some wrong define >> - Modified the definition

Re: Re: [PATCH v6 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others

2020-06-15 Thread
Hi Johan, Johan Jonker wrote on Sat, 13 Jun 2020 15:31:52 +0200: >Hi Yifeng, Miquel, > >Some more comments about swap(); > >On 6/9/20 9:40 AM, Yifeng Zhao wrote: > >[..] > >> +static int rk_nfc_ooblayout_free(struct mtd_info *mtd, int section, >> +struct mtd_oob_region *oob_region) >> +{ >>