Re: linux-next: manual merge of the scsi tree with Linus' tree

Thanks Stephen's help. Ching Huang Stephen Rothwell 於 2019年1月14日 週一 上午10:48寫道： > > Hi all, > > Today's linux-next merge of the scsi tree got a conflict in: > > drivers/scsi/arcmsr/arcmsr_hba.c > > between commit: > > 750afb08ca71 ("cross-tree: phase out dma_zalloc_coherent()") > > from

Re: [PATCH][next] scsi: arcmsr: remove redundant check for secs < 0

Colin, You are right. That's checking is redundant. secs is never be negative. Thanks for your correction and patch. Regards, Ching 2017-12-09 8:34 GMT+08:00 Colin King : > From: Colin Ian King > > The check for secs being less than zero is

Re: [PATCH][next] scsi: arcmsr: remove redundant check for secs < 0

Colin, You are right. That's checking is redundant. secs is never be negative. Thanks for your correction and patch. Regards, Ching 2017-12-09 8:34 GMT+08:00 Colin King : > From: Colin Ian King > > The check for secs being less than zero is redundant for two reasons. > Firstly, secs is

Re: [PATCH 0/3] scsi: arcmsr: add driver module parameter - msi_enable, msix_enable

Dan, There is our user feedback said that they have some system have MSI interrupt issue.(but some system are working) Those have MSI issue system all are old system, even if MSI interrupt enable and request are successful, there is not any hardware interrupt for scsi command. Cause each scsi

Re: [PATCH 0/3] scsi: arcmsr: add driver module parameter - msi_enable, msix_enable

Dan, There is our user feedback said that they have some system have MSI interrupt issue.(but some system are working) Those have MSI issue system all are old system, even if MSI interrupt enable and request are successful, there is not any hardware interrupt for scsi command. Cause each scsi

Re: [PATCH 1.1 1/1] arcmsr: Notify has sense data report

There is no this case. We always have auto request sense to device in case of CHECK_CONDITION status. 2014-11-28 18:14 GMT+08:00 Hannes Reinecke : > On 11/28/2014 11:07 AM, Ching Huang wrote: >> From: Ching Huang >> >> Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we >>

Re: [PATCH 1.1 1/1] arcmsr: Notify has sense data report

There is no this case. We always have auto request sense to device in case of CHECK_CONDITION status. 2014-11-28 18:14 GMT+08:00 Hannes Reinecke h...@suse.de: On 11/28/2014 11:07 AM, Ching Huang wrote: From: Ching Huang ching2...@areca.com.tw Setting command status with 'DRIVER_SENSE' except

Re: [PATCH v1.1 2/16] arcmsr: Adding code to support MSI-X interrupt

Hi Dan, Thanks for correcting this bug. Regards, Ching 2014-05-05 18:28 GMT+08:00 Dan Carpenter : > On Mon, May 05, 2014 at 04:47:11PM +0800, ching wrote: >> +static int >> +arcmsr_request_irq(struct pci_dev *pdev, struct AdapterControlBlock *acb) >> +{ >> + int i, j, r; >> + struct

Re: [PATCH v1.1 2/16] arcmsr: Adding code to support MSI-X interrupt

Hi Dan, Thanks for correcting this bug. Regards, Ching 2014-05-05 18:28 GMT+08:00 Dan Carpenter dan.carpen...@oracle.com: On Mon, May 05, 2014 at 04:47:11PM +0800, ching wrote: +static int +arcmsr_request_irq(struct pci_dev *pdev, struct AdapterControlBlock *acb) +{ + int i, j, r;

Re: [PATCH v1.0 12/16] arcmsr: revise alloction of second dma_coherent_handle for type B adapter

Hi Dan, This patch is not a bugfix. It is a simplification and consistency of coding for both adapter type B and D. Regards, Ching 2014-05-02 16:57 GMT+08:00 Dan Carpenter : > On Wed, Apr 30, 2014 at 07:30:29PM +0800, ching wrote: >> From: Ching >> >> Revise allocation of second

Re: [PATCH v1.0 14/16] arcmsr: fix sparse checking error

Hi Dan, In this patch, there are several replace of call readl() or writel() by direct access to memory. Because in main memory, we allocated a block of memory for post_qbuffer and done_qbuffer. These memory are access by both of CPU and IOP, they are not hardware registers. This change will not

Re: [PATCH v1.0 14/16] arcmsr: fix sparse checking error

Hi Dan, In this patch, there are several replace of call readl() or writel() by direct access to memory. Because in main memory, we allocated a block of memory for post_qbuffer and done_qbuffer. These memory are access by both of CPU and IOP, they are not hardware registers. This change will not

Re: [PATCH v1.0 12/16] arcmsr: revise alloction of second dma_coherent_handle for type B adapter

Hi Dan, This patch is not a bugfix. It is a simplification and consistency of coding for both adapter type B and D. Regards, Ching 2014-05-02 16:57 GMT+08:00 Dan Carpenter dan.carpen...@oracle.com: On Wed, Apr 30, 2014 at 07:30:29PM +0800, ching wrote: From: Chingching2...@areca.com.tw

Re: [PATCH v1.0 1/11] arcmsr: Revise interrupt service routine relate function

Hi James, Indeed, it makes you confusion that I mistake typing the subject. It should be [PATCH v1.0 1/16] , but not [PATCH v1.0 1/11]. Why I use v1.0 other than v1.4? Changing from 11 patches to 16 patches. Because I spend a long time to simplify each patch, so patch number is increase. It is

Re: [PATCH v1.0 1/11] arcmsr: Revise interrupt service routine relate function

Hi James, Indeed, it makes you confusion that I mistake typing the subject. It should be [PATCH v1.0 1/16] , but not [PATCH v1.0 1/11]. Why I use v1.0 other than v1.4? Changing from 11 patches to 16 patches. Because I spend a long time to simplify each patch, so patch number is increase. It is

[PATCH v1.3 11/11] arcmsr: Adding support Areca ARC1214/1224/1264/1284 SATA 6Gb raid controllers

From: Ching Adding support Areca ARC1214/1224/1264/1284 SATA 6Gb raid controllers. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-02-20 20:14:42.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1.3 9/11] arcmsr: Fixed sparse warning or errors

From: Ching Fixed sparse warning or errors. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-02-18 01:30:16.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-02-20 23:23:30.0 +0800

[PATCH v1.3 8/11] arcmsr: Modify ioctl relate functions to fix update firmware error

From: Ching Modify ioctl relate functions to fix update firmware error. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi/arcmsr/arcmsr_attr.c 2014-01-10 20:28:48.0 +0800 +++

[PATCH v1.3 7/11] arcmsr: Notify sense data report

From: Ching Notify sense data report Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:03:28.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:04:10.0

[PATCH v1.3 6/11] arcmsr: Rewrite arcmsr_message_isr_bh_fn function

From: Ching Rewrite arcmsr_message_isr_bh_fn function Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:02:34.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21

[PATCH v1.3 5/11] arcmsr: Rename function name and variables for readability

From: Ching Rename function name and variables for readability. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-13 23:21:56.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-01-14

[PATCH v1.3 4/11] arcmsr: Revise xxx_get_config functions

From: Ching Revise xxx_get_config functions. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-11 03:14:14.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-01-13 23:21:56.0

[PATCH v1.3 3/11] arcmsr: Support hibernation

From: Ching Supporting hibernation. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 01:59:56.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:00:16.0 +0800

[PATCH v1.3 2/11] arcmsr: Support MSI and MSI-X interrupt service

From: Ching Supporting MSI and MSI-X interrupt service. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-11 02:53:22.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-01-11

[PATCH v1.3 1/11] arcmsr: Revise interrupt service routine to fix command timeout

From: Ching Rewrite interrupt service routine to fix command timeout on controller too heavy loading. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi/arcmsr/arcmsr_attr.c 2014-02-07 01:47:24.0 +0800 +++

[PATCH v1.3 1/11] arcmsr: Revise interrupt service routine to fix command timeout

From: Ching ching2...@areca.com.tw Rewrite interrupt service routine to fix command timeout on controller too heavy loading. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi/arcmsr/arcmsr_attr.c

[PATCH v1.3 2/11] arcmsr: Support MSI and MSI-X interrupt service

From: Ching ching2...@areca.com.tw Supporting MSI and MSI-X interrupt service. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-11 02:53:22.0 +0800 +++

[PATCH v1.3 3/11] arcmsr: Support hibernation

From: Ching ching2...@areca.com.tw Supporting hibernation. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 01:59:56.0 +0800 +++

[PATCH v1.3 4/11] arcmsr: Revise xxx_get_config functions

From: Ching ching2...@areca.com.tw Revise xxx_get_config functions. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-11 03:14:14.0 +0800 +++

[PATCH v1.3 5/11] arcmsr: Rename function name and variables for readability

From: Ching ching2...@areca.com.tw Rename function name and variables for readability. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-13 23:21:56.0 +0800 +++

[PATCH v1.3 6/11] arcmsr: Rewrite arcmsr_message_isr_bh_fn function

From: Ching ching2...@areca.com.tw Rewrite arcmsr_message_isr_bh_fn function Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:02:34.0 +0800 +++

[PATCH v1.3 7/11] arcmsr: Notify sense data report

From: Ching ching2...@areca.com.tw Notify sense data report Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:03:28.0 +0800 +++

[PATCH v1.3 8/11] arcmsr: Modify ioctl relate functions to fix update firmware error

From: Ching ching2...@areca.com.tw Modify ioctl relate functions to fix update firmware error. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi/arcmsr/arcmsr_attr.c 2014-01-10 20:28:48.0

[PATCH v1.3 9/11] arcmsr: Fixed sparse warning or errors

From: Ching ching2...@areca.com.tw Fixed sparse warning or errors. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-02-18 01:30:16.0 +0800 +++

[PATCH v1.3 11/11] arcmsr: Adding support Areca ARC1214/1224/1264/1284 SATA 6Gb raid controllers

From: Ching ching2...@areca.com.tw Adding support Areca ARC1214/1224/1264/1284 SATA 6Gb raid controllers. Singed-off-by: Ching ching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-02-20

[PATCH 3/3] arcmsr: Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface

From: Ching Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface. Signed-off-by: Ching --- patch3 Description: Binary data

[PATCH 2/3] arcmsr: Fix command throttling for ARC188x series

From: Ching Fix command throttling for ARC188x series adapter. Signed-off-by: Ching --- patch2 Description: Binary data

[PATCH 1/3] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284

From: Ching Support Areca new SATA Raid adapter ARC1214/1224/1264/1284. Modify maximum outstanding command number, notify command complete with auto request sense Signed-off-by: Ching -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH 1/3] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284

From: Ching ching2...@areca.com.tw Support Areca new SATA Raid adapter ARC1214/1224/1264/1284. Modify maximum outstanding command number, notify command complete with auto request sense Signed-off-by: Ching ching2...@areca.com.tw -- To unsubscribe from this list: send the line unsubscribe

[PATCH 2/3] arcmsr: Fix command throttling for ARC188x series

From: Ching ching2...@areca.com.tw Fix command throttling for ARC188x series adapter. Signed-off-by: Ching ching2...@areca.com.tw --- patch2 Description: Binary data

[PATCH 3/3] arcmsr: Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface

From: Ching ching2...@areca.com.tw Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface. Signed-off-by: Ching ching2...@areca.com.tw --- patch3 Description: Binary data

[PATCH 3/3] arcmsr: Fix bug of updating ARECA Raid adapter firmware through ioctl(ARCHTTP) interface

From: chingching2...@areca.com.tw Fix bug of updating ARECA Raid adapter firmware through ioctl(ARCHTTP) interface Signed-off-by: chingching2...@areca.com.tw --- patch3 Description: Binary data

[PATCH 2/3] arcmsr: Fix command throttling for ARC188x series adapters

From: chingching2...@areca.com.tw Fix command throttling for ARC188x series adapters. Signed-off-by: chingching2...@areca.com.tw --- patch2 Description: Binary data

[PATCH 1/3] arcmsr: Modify maxium outstanding command

From: Ching Modify maximum outstanding command number, notify command complete with auto request sense, reassign ARC12x4 series to SATA type adapter Signed-off-by: chingching2...@areca.com.tw --- patch1 Description: Binary data

[PATCH 1/3] arcmsr: Modify maxium outstanding command

From: Chingching2...@areca.com.tw Modify maximum outstanding command number, notify command complete with auto request sense, reassign ARC12x4 series to SATA type adapter Signed-off-by: chingching2...@areca.com.tw --- patch1 Description: Binary data

[PATCH 2/3] arcmsr: Fix command throttling for ARC188x series adapters

From: chingching2...@areca.com.tw Fix command throttling for ARC188x series adapters. Signed-off-by: chingching2...@areca.com.tw --- patch2 Description: Binary data

[PATCH 3/3] arcmsr: Fix bug of updating ARECA Raid adapter firmware through ioctl(ARCHTTP) interface

From: chingching2...@areca.com.tw Fix bug of updating ARECA Raid adapter firmware through ioctl(ARCHTTP) interface Signed-off-by: chingching2...@areca.com.tw --- patch3 Description: Binary data