Re: [PATCH v2 0/5] uprobes: misc cleanups/simplifications

2024-07-30 Thread Jiri Olsa
On Mon, Jul 29, 2024 at 03:44:44PM +0200, Oleg Nesterov wrote: > Peter, I don't think these changes can really complicate your ongoing work. > But again, if you are going to send the next version "soon" I can rebase > these cleanups on top of it. > > Andrii, I dared to preserve your acks, all the

Re: [PATCH] pwm: Make info in traces about affected pwm more useful

2024-07-30 Thread Uwe Kleine-König
Hello, On Fri, Jul 05, 2024 at 11:14:51PM +0200, Uwe Kleine-König wrote: > The hashed pointer isn't useful to identify the pwm device. Instead > store and emit chipid and hwpwm. > > Signed-off-by: Uwe Kleine-König > --- > include/trace/events/pwm.h | 10 ++ > 1 file changed, 6

[PATCH bpf-next v2] bpf: kprobe: remove unused declaring of bpf_kprobe_override

2024-07-29 Thread Menglong Dong
After the commit 5ad2f102 ("tracing/kprobe: bpf: Compare instruction pointer with original one"), "bpf_kprobe_override" is not used anywhere anymore, and we can remove it now. Fixes: 5ad2f102 ("tracing/kprobe: bpf: Compare instruction pointer with original one") Signed-off-by: Menglong

Re: [PATCH 0/3] Fix kallsyms with CONFIG_LTO_CLANG

2024-07-29 Thread Song Liu
On Mon, Jul 29, 2024 at 5:54 PM Song Liu wrote: > > With CONFIG_LTO_CLANG, the compiler/linker adds .llvm. suffix to > local symbols to avoid duplications. Existing scripts/kallsyms sorts > symbols without .llvm. suffix. However, this causes quite some > issues later on. Some users of kallsyms,

Re: [PATCH v7 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-29 Thread Cindy Lu
On Tue, 30 Jul 2024 at 03:16, Andrew Lunn wrote: > > > +static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v_mdev, struct > > vdpa_device *dev, > > + const struct vdpa_dev_set_config *add_config) > > +{ > > + struct virtio_net_config *config; > > + struct

Re: [PATCH v7 2/3] vdpa_sim_net: Add the support of set mac address

2024-07-29 Thread Cindy Lu
On Tue, 30 Jul 2024 at 03:15, Andrew Lunn wrote: > > > +static int vdpasim_net_set_attr(struct vdpa_mgmt_dev *mdev, struct > > vdpa_device *dev, > > + const struct vdpa_dev_set_config *config) > > +{ > > + struct vdpasim *vdpasim = container_of(dev, struct

Re: [PATCH v7 1/3] vdpa: support set mac address from vdpa tool

2024-07-29 Thread Cindy Lu
On Tue, 30 Jul 2024 at 03:13, Andrew Lunn wrote: > > > +static int vdpa_dev_net_device_attr_set(struct vdpa_device *vdev, > > + struct genl_info *info) > > +{ > > + struct vdpa_dev_set_config set_config = {}; > > + struct vdpa_mgmt_dev *mdev =

Re: [PATCH v4] x86/paravirt: Disable virt spinlock on bare metal

2024-07-29 Thread maobibo
Chenyu, Sorry to bother you, I am porting pv spinlock to LoongArch platform, I do not know the history about function virt_spin_lock(). When CONFIG_PARAVIRT_SPINLOCKS is enabled, there is pv_enabled() before virt_spin_lock(), it seems that virt_spin_lock is never called in this condition.

Re: [PATCH] tools/virtio:Fix the wrong format specifier

2024-07-29 Thread Xuan Zhuo
On Wed, 24 Jul 2024 00:41:08 -0700, Zhu Jun wrote: > The unsigned int should use "%u" instead of "%d". > > Signed-off-by: Zhu Jun Reviewed-by: Xuan Zhuo > --- > tools/virtio/ringtest/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH 3/3] tracing/kprobes: Use APIs that matches symbols with .llvm. suffix

2024-07-29 Thread Song Liu
Use the new kallsyms APIs that matches symbols name with .llvm. suffix. This allows userspace tools to get kprobes on the expected function name, while the actual symbol has a .llvm. suffix. This only effects kernel compared with CONFIG_LTO_CLANG. Signed-off-by: Song Liu ---

[PATCH 2/3] kallsyms: Add APIs to match symbol without .llmv. suffix.

2024-07-29 Thread Song Liu
With CONFIG_LTO_CLANG=y, the compiler may add suffix to function names to avoid duplication. This causes confusion with users of kallsyms. On one hand, users like livepatch are required to match the symbols exactly. On the other hand, users like kprobe would like to match to original function

[PATCH 1/3] kallsyms: Do not cleanup .llvm. suffix before sorting symbols

2024-07-29 Thread Song Liu
Cleaning up the symbols causes various issues afterwards. Let's sort the list based on original name and handle suffix later during the symbol lookup. Signed-off-by: Song Liu --- scripts/kallsyms.c | 31 ++- scripts/link-vmlinux.sh | 4 2 files changed, 2

[PATCH 0/3] Fix kallsyms with CONFIG_LTO_CLANG

2024-07-29 Thread Song Liu
With CONFIG_LTO_CLANG, the compiler/linker adds .llvm. suffix to local symbols to avoid duplications. Existing scripts/kallsyms sorts symbols without .llvm. suffix. However, this causes quite some issues later on. Some users of kallsyms, such as livepatch, have to match symbols exactly; while

Re: [PATCH] tracing: Use refcount for trace_event_file reference counter

2024-07-29 Thread Google
On Mon, 29 Jul 2024 19:02:41 -0400 Steven Rostedt wrote: > On Mon, 29 Jul 2024 23:49:24 +0900 > Masami Hiramatsu (Google) wrote: > > > On Fri, 26 Jul 2024 14:42:08 -0400 > > Steven Rostedt wrote: > > > > > From: Steven Rostedt > > > > > > Instead of using an atomic counter for the

Re: [PATCH] tracing: Use refcount for trace_event_file reference counter

2024-07-29 Thread Steven Rostedt
On Mon, 29 Jul 2024 23:49:24 +0900 Masami Hiramatsu (Google) wrote: > On Fri, 26 Jul 2024 14:42:08 -0400 > Steven Rostedt wrote: > > > From: Steven Rostedt > > > > Instead of using an atomic counter for the trace_event_file reference > > counter, use the refcount interface. It has various

Re: [GIT PULL] virtio: fixes for rc1

2024-07-29 Thread pr-tracker-bot
The pull request you sent on Sun, 28 Jul 2024 19:19:56 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/10826505f52357c7c9e12358db97a3acbe82e958 Thank you! -- Deet-doot-dot, I am a

[PATCH v2 5/5] arm64: dts: qcom: add generic compat string to RPM glink channels

2024-07-29 Thread Dmitry Baryshkov
Add the generic qcom,smd-rpm / qcom,glink-smd-rpm compatible to RPM nodes to follow the schema. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-

[PATCH v2 4/5] ARM: dts: qcom: add generic compat string to RPM glink channels

2024-07-29 Thread Dmitry Baryshkov
Add the generic qcom,smd-rpm compatible to RPM nodes to follow the schema. Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom/qcom-apq8084.dtsi | 2 +- arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 2 +- arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 2 +- 3 files changed, 3 insertions(+), 3

[PATCH v2 3/5] soc: qcom: smd-rpm: add qcom,smd-rpm compatible

2024-07-29 Thread Dmitry Baryshkov
Add the generic qcom,smd-rpm and qcom,glink-smd-rpm compatibles so that there is no need to add further compat strings to the list. Existing strings are intact to keep compatibility with existing DTS. Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/smd-rpm.c | 6 ++ 1 file changed, 6

[PATCH v2 2/5] dt-bindings: soc: qcom: smd-rpm: add generic compatibles

2024-07-29 Thread Dmitry Baryshkov
Add two generic compatibles to all smd-rpm devices, they follow the same RPMSG protocol and are either accessed through the smd-edge or through the glink-edge. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/clock/qcom,rpmcc.yaml | 2 +-

[PATCH v2 0/5] soc: qcom: fix rpm_requests module probing

2024-07-29 Thread Dmitry Baryshkov
The GLINK RPMSG channels get modalias based on the compatible string rather than the channel type, however the smd-rpm module uses rpmsg ID instead. Thus if the smd-rpm is built as a module, it doesn't get automatically loaded. Add generic compatible to such devices and fix module's ID table.

[PATCH v2 1/5] Revert "soc: qcom: smd-rpm: Match rpmsg channel instead of compatible"

2024-07-29 Thread Dmitry Baryshkov
The rpm_requests device nodes have the compatible node. As such the rpmsg core uses OF modalias instead of a native rpmsg modalias. Thus if smd-rpm is built as a module, it doesn't get autoloaded for the device. Revert the commit bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel instead of

Re: [PATCH v7 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-29 Thread Andrew Lunn
> +static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v_mdev, struct > vdpa_device *dev, > + const struct vdpa_dev_set_config *add_config) > +{ > + struct virtio_net_config *config; > + struct mlx5_core_dev *pfmdev; > + struct mlx5_vdpa_dev *mvdev; > +

Re: [PATCH v7 2/3] vdpa_sim_net: Add the support of set mac address

2024-07-29 Thread Andrew Lunn
> +static int vdpasim_net_set_attr(struct vdpa_mgmt_dev *mdev, struct > vdpa_device *dev, > + const struct vdpa_dev_set_config *config) > +{ > + struct vdpasim *vdpasim = container_of(dev, struct vdpasim, vdpa); > + struct virtio_net_config *vio_config =

Re: [PATCH v7 1/3] vdpa: support set mac address from vdpa tool

2024-07-29 Thread Andrew Lunn
> +static int vdpa_dev_net_device_attr_set(struct vdpa_device *vdev, > + struct genl_info *info) > +{ > + struct vdpa_dev_set_config set_config = {}; > + struct vdpa_mgmt_dev *mdev = vdev->mdev; > + struct nlattr **nl_attrs = info->attrs; > +

Re: [PATCH v4] x86/paravirt: Disable virt spinlock on bare metal

2024-07-29 Thread Chen Yu
Hi Thomas, On 2024-07-29 at 14:43:37 +0200, Thomas Gleixner wrote: > On Mon, Jul 29 2024 at 14:52, Chen Yu wrote: > > #ifdef CONFIG_PARAVIRT > > /* > > - * virt_spin_lock_key - enables (by default) the virt_spin_lock() hijack. > > + * virt_spin_lock_key - disables (by default) the

[PATCH RESEND v5] perf,x86: avoid missing caller address in stack traces captured in uprobe

2024-07-29 Thread Andrii Nakryiko
When tracing user functions with uprobe functionality, it's common to install the probe (e.g., a BPF program) at the first instruction of the function. This is often going to be `push %rbp` instruction in function preamble, which means that within that function frame pointer hasn't been

Re: [PATCH] rust: add `module_params` macro

2024-07-29 Thread Benno Lossin
On 05.07.24 13:15, Andreas Hindborg wrote: > From: Andreas Hindborg > > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types without `sysfs` support. > > This code is a reduced and updated version

[PATCH] rpmsg: char: Export alias for RPMSG ID rpmsg-raw from table

2024-07-29 Thread Andrew Davis
Module aliases are used by userspace to identify the correct module to load for a detected hardware. The currently supported RPMSG device IDs for this module include "rpmsg-raw", but the module alias is "rpmsg_chrdev". Use the helper macro MODULE_DEVICE_TABLE(rpmsg) to export the correct

Re: [PATCH v3] ptp: Add vDSO-style vmclock support

2024-07-29 Thread David Woodhouse
On Mon, 2024-07-29 at 11:33 -0400, Michael S. Tsirkin wrote: > you said you will use __le here? I hadn't intended to bother until we add the virtio discovery and negotiation paths; it would basically be cosmetic for now. Although I *will* do so with the QEMU side before posting the latest

Re: [PATCH] tracing: Have format file honor EVENT_FILE_FL_FREED

2024-07-29 Thread Steven Rostedt
On Mon, 29 Jul 2024 18:29:49 +0530 Ajay Kaher wrote: > Following is not related to this bug: > event_release callback executed once 'dir' closed (no more ref), any > specific reason to register with 'dir'/'enable' file. If not, could we > register with the 'dir' instead of 'enable'. I tried

Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-07-29 Thread Mathieu Poirier
On Fri, Jul 19, 2024 at 04:49:04PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux > poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 > firmware. Then Cortex-A7 could poweroff or restart by

Re: [PATCH v3] ptp: Add vDSO-style vmclock support

2024-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2024 at 11:42:22AM +0100, David Woodhouse wrote: > +struct vmclock_abi { > + /* CONSTANT FIELDS */ > + uint32_t magic; > +#define VMCLOCK_MAGIC0x4b4c4356 /* "VCLK" */ > + uint32_t size; /* Size of region containing this structure */ > + uint16_t

Re: [PATCH v2 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button

2024-07-29 Thread Krzysztof Kozlowski
On 25/07/2024 03:42, Dang Huynh wrote: > The Pro1X has a flip keyboard and a single-state camera button. > > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 34 > +++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > It does not

Re: [PATCH v2 0/4] remoteproc: imx_rproc: various patches for misc

2024-07-29 Thread Mathieu Poirier
On Fri, Jul 19, 2024 at 04:36:10PM +0800, Peng Fan (OSS) wrote: > This patchset is to upstream a few patches that in NXP downstream for > quite sometime. For patches directly cherry-picked from NXP downstream, > I keep the R-b tags. > > Patch 1 is a minor fix to DDR alias. > Patch 2 was sent out

Re: [PATCH] tracing: Use refcount for trace_event_file reference counter

2024-07-29 Thread Google
On Fri, 26 Jul 2024 14:42:08 -0400 Steven Rostedt wrote: > From: Steven Rostedt > > Instead of using an atomic counter for the trace_event_file reference > counter, use the refcount interface. It has various checks to make sure > the reference counting is correct, and will warn if it detects

Re: [PATCH] tracing: Have format file honor EVENT_FILE_FL_FREED

2024-07-29 Thread Google
On Thu, 25 Jul 2024 20:15:17 -0400 Steven Rostedt wrote: > From: Steven Rostedt > > When eventfs was introduced, special care had to be done to coordinate the > freeing of the file meta data with the files that are exposed to user > space. The file meta data would have a ref count that is set

[PATCH v3 0/8] pwm: New abstraction and userspace API

2024-07-29 Thread Uwe Kleine-König
Hello, here comes v3 of the series to add support for duty offset in PWM waveforms. For a single PWM output there is no gain, but if you have a chip with two (or more) outputs and both operate with the same period, you can generate an output like: __ __

[PATCH v3 6/8] pwm: Add tracing for waveform callbacks

2024-07-29 Thread Uwe Kleine-König
This adds trace events for the recently introduced waveform callbacks. With the introduction of some helper macros consistency among the different events is ensured. Signed-off-by: Uwe Kleine-König --- drivers/pwm/core.c | 24 +-- include/trace/events/pwm.h | 134

[PATCH v2 5/5] uprobes: make uprobe_register() return struct uprobe *

2024-07-29 Thread Oleg Nesterov
This way uprobe_unregister() and uprobe_apply() can use "struct uprobe *" rather than inode + offset. This simplifies the code and allows to avoid the unnecessary find_uprobe() + put_uprobe() in these functions. TODO: uprobe_unregister() still needs get_uprobe/put_uprobe to ensure that this

[PATCH v2 4/5] uprobes: kill uprobe_register_refctr()

2024-07-29 Thread Oleg Nesterov
It doesn't make any sense to have 2 versions of _register(). Note that trace_uprobe_enable(), the only user of uprobe_register(), doesn't need to check tu->ref_ctr_offset to decide which one should be used, it could safely pass ref_ctr_offset == 0 to uprobe_register_refctr(). Add this argument to

[PATCH v2 3/5] uprobes: simplify error handling for alloc_uprobe()

2024-07-29 Thread Oleg Nesterov
From: Andrii Nakryiko Return -ENOMEM instead of NULL, which makes caller's error handling just a touch simpler. Signed-off-by: Andrii Nakryiko Signed-off-by: Oleg Nesterov --- kernel/events/uprobes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v2 2/5] uprobes: is_trap_at_addr: don't use get_user_pages_remote()

2024-07-29 Thread Oleg Nesterov
get_user_pages_remote() and the comment above it make no sense. There is no task_struct passed into get_user_pages_remote() anymore, and nowadays mm_account_fault() increments the current->min/maj_flt counters regardless of FAULT_FLAG_REMOTE. Reported-by: Andrii Nakryiko Acked-by: Andrii

[PATCH v2 1/5] uprobes: document the usage of mm->mmap_lock

2024-07-29 Thread Oleg Nesterov
The comment above uprobe_write_opcode() is wrong, unapply_uprobe() calls it under mmap_read_lock() and this is correct. And it is completely unclear why register_for_each_vma() takes mmap_lock for writing, add a comment to explain that mmap_write_lock() is needed to avoid the following race:

[PATCH v2 0/5] uprobes: misc cleanups/simplifications

2024-07-29 Thread Oleg Nesterov
Peter, I don't think these changes can really complicate your ongoing work. But again, if you are going to send the next version "soon" I can rebase these cleanups on top of it. Andrii, I dared to preserve your acks, all the changes are simple. Changes since v1: - update the comment in

Re: [PATCH] tracing: Have format file honor EVENT_FILE_FL_FREED

2024-07-29 Thread Ajay Kaher
On Fri, Jul 26, 2024 at 9:33 PM Steven Rostedt wrote: > > On Fri, 26 Jul 2024 18:00:18 +0530 > Ajay Kaher wrote: > > > Some doubt: > > Because of the same race condition, it may happen that kmem_cache_free(file) > > was executed while f_start() is waiting to get event_mutex. Once > > f_start()

Re: [RFC] Printk deadlock in bpf trace called from scheduler context

2024-07-29 Thread Marco Elver
On Mon, 29 Jul 2024 at 14:27, Peter Zijlstra wrote: > > On Mon, Jul 29, 2024 at 01:46:09PM +0200, Radoslaw Zielonek wrote: > > I am currently working on a syzbot-reported bug where bpf > > is called from trace_sched_switch. In this scenario, we are still within > > the scheduler context, and

Re: [PATCH v1] MAINTAINERS: add me as reviewer of AF_VSOCK and virtio-vsock

2024-07-29 Thread Stefano Garzarella
On Sun, Jul 28, 2024 at 09:33:25PM GMT, Arseniy Krasnov wrote: I'm working on AF_VSOCK and virtio-vsock. Yeah, thanks for the help! Signed-off-by: Arseniy Krasnov --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Stefano Garzarella diff --git a/MAINTAINERS

Re: [PATCH v4] x86/paravirt: Disable virt spinlock on bare metal

2024-07-29 Thread Thomas Gleixner
On Mon, Jul 29 2024 at 14:52, Chen Yu wrote: > #ifdef CONFIG_PARAVIRT > /* > - * virt_spin_lock_key - enables (by default) the virt_spin_lock() hijack. > + * virt_spin_lock_key - disables (by default) the virt_spin_lock() hijack. > * > * Native (and PV wanting native due to vCPU pinning)

Re: [PATCH] arm64: dts: exynos: exynos7885-jackpotlte: Correct RAM amount to 4GB

2024-07-29 Thread Krzysztof Kozlowski
On Sat, 13 Jul 2024 19:58:32 +0200, David Virag wrote: > All known jackpotlte variants have 4GB of RAM, let's use it all. > RAM was set to 3GB from a mistake in the vendor provided DTS file. > > Applied, thanks! [1/1] arm64: dts: exynos: exynos7885-jackpotlte: Correct RAM amount to 4GB

Re: [RFC] Printk deadlock in bpf trace called from scheduler context

2024-07-29 Thread Peter Zijlstra
On Mon, Jul 29, 2024 at 01:46:09PM +0200, Radoslaw Zielonek wrote: > I am currently working on a syzbot-reported bug where bpf > is called from trace_sched_switch. In this scenario, we are still within > the scheduler context, and calling printk can create a deadlock. > > I am uncertain about the

Re: [PATCH v2 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button

2024-07-29 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > The Pro1X has a flip keyboard and a single-state camera button. > > Signed-off-by: Dang Huynh > --- [...] > > { > gpio-reserved-ranges = <0 4>, <14 4>; > + > + hall_sensor_n: hall-sensor-n { These must end in -state to pass binding

[RFC] Printk deadlock in bpf trace called from scheduler context

2024-07-29 Thread Radoslaw Zielonek
I am currently working on a syzbot-reported bug where bpf is called from trace_sched_switch. In this scenario, we are still within the scheduler context, and calling printk can create a deadlock. I am uncertain about the best approach to fix this issue. Should we simply forbid such calls, or

[PATCH v3] ptp: Add vDSO-style vmclock support

2024-07-29 Thread David Woodhouse
From: David Woodhouse The vmclock "device" provides a shared memory region with precision clock information. By using shared memory, it is safe across Live Migration. Like the KVM PTP clock, this can convert TSC-based cross timestamps into KVM clock values. Unlike the KVM PTP clock, it does so

[PATCH v4] x86/paravirt: Disable virt spinlock on bare metal

2024-07-29 Thread Chen Yu
The kernel can change spinlock behavior when running as a guest. But this guest-friendly behavior causes performance problems on bare metal. So there's a 'virt_spin_lock_key' static key to switch between the two modes. In current code, the static key is always enabled by default when running in

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-29 Thread David Woodhouse
On 28 July 2024 16:23:49 BST, "Michael S. Tsirkin" wrote: >On Sun, Jul 28, 2024 at 02:07:01PM +0100, David Woodhouse wrote: >> On 28 July 2024 11:37:04 BST, "Michael S. Tsirkin" wrote: >> >Glad you asked :) >> >> Heh, I'm not sure I'm so glad. Did I mention I hate ACPI? Perhaps it's still >>

[PATCH v7 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-28 Thread Cindy Lu
Add the function to support setting the MAC address. For vdpa/mlx5, the function will use mlx5_mpfs_add_mac to set the mac address Tested in ConnectX-6 Dx device Signed-off-by: Cindy Lu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 28 1 file changed, 28 insertions(+)

[PATCH v7 2/3] vdpa_sim_net: Add the support of set mac address

2024-07-28 Thread Cindy Lu
Add the function to support setting the MAC address. For vdpa_sim_net, the driver will write the MAC address to the config space, and other devices can implement their own functions to support this. Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 21 - 1

[PATCH v7 1/3] vdpa: support set mac address from vdpa tool

2024-07-28 Thread Cindy Lu
Add new UAPI to support the mac address from vdpa tool Function vdpa_nl_cmd_dev_attr_set_doit() will get the new MAC address from the vdpa tool and then set it to the device. The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:** Here is example: root@L1# vdpa -jp dev config show vdpa0

[PATCH v7 0/3] vdpa: support set mac address from vdpa tool

2024-07-28 Thread Cindy Lu
Add support for setting the MAC address using the VDPA tool. This feature will allow setting the MAC address using the VDPA tool. For example, in vdpa_sim_net, the implementation sets the MAC address to the config space. However, for other drivers, they can implement their own function, not

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-rossa: Add touchscreen

2024-07-28 Thread Bjorn Andersson
On Tue, 23 Jul 2024 13:15:09 +, Raymond Hackley wrote: > Core Prime uses an Imagis IST3038 touchscreen that is connected to > blsp_i2c5. Add it to the device tree. > > Applied, thanks! [1/1] arm64: dts: qcom: msm8916-samsung-rossa: Add touchscreen commit:

Re: [PATCH v4 0/2] Use of devname for interrupt descriptions and tracepoint support for smp2p

2024-07-28 Thread Bjorn Andersson
On Tue, 16 Jul 2024 23:08:32 +0530, Sudeepgoud Patil wrote: > This commit enhances the smp2p driver by adding support for using the device > name in interrupt descriptions and introducing tracepoint functionality. > These improvements facilitate more effective debugging of smp2p-related >

Re: [PATCH v2] arm64: dts: qcom: msm8916-samsung-grandmax: Add touchscreen

2024-07-28 Thread Bjorn Andersson
On Thu, 18 Jul 2024 11:28:57 +, Lin, Meng-Bo wrote: > Grand Max uses an Imagis IST3038 touchscreen that is connected to > blsp_i2c5. Add it to the device tree. > > Applied, thanks! [1/1] arm64: dts: qcom: msm8916-samsung-grandmax: Add touchscreen commit:

Re: [PATCH v2 1/2] nvdimm: Fix devs leaks in scan_labels()

2024-07-28 Thread Zhijian Li (Fujitsu)
On 26/07/2024 21:37, Ira Weiny wrote: > Li Zhijian wrote: >> The leakage would happend when create_namespace_pmem() meets an invalid >> label which gets failure in validating isetcookie. >> >> Try to resuse the devs that may have already been allocated with size >> (2 * sizeof(dev)) previously.

Re: [PATCH net-next v3 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-07-28 Thread Jason Wang
On Fri, Jul 26, 2024 at 3:24 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:03:42AM +0800, Jason Wang wrote: > > On Tue, Jul 9, 2024 at 9:28 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jul 09, 2024 at 04:02:14PM +0800, Jason Wang wrote: > > > > This patch synchronize operstate

[GIT PULL] virtio: fixes for rc1

2024-07-28 Thread Michael S. Tsirkin
The biggest thing here is the adminq change - but it looks like the only way to avoid headq blocking causing indefinite stalls. The following changes since commit 6c85d6b653caeba2ef982925703cbb4f2b3b3163: virtio: rename virtio_find_vqs_info() to virtio_find_vqs() (2024-07-17 05:20:58

[PATCH v1] MAINTAINERS: add me as reviewer of AF_VSOCK and virtio-vsock

2024-07-28 Thread Arseniy Krasnov
I'm working on AF_VSOCK and virtio-vsock. Signed-off-by: Arseniy Krasnov --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c0a3d9e93689..2bf0987d87ed 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -24131,6 +24131,7 @@ F: virt/lib/ VIRTIO

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2024 at 02:07:01PM +0100, David Woodhouse wrote: > On 28 July 2024 11:37:04 BST, "Michael S. Tsirkin" wrote: > >Glad you asked :) > > Heh, I'm not sure I'm so glad. Did I mention I hate ACPI? Perhaps it's still > not too late for me just to define a DT binding and use PRP0001

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-28 Thread David Woodhouse
On 28 July 2024 11:37:04 BST, "Michael S. Tsirkin" wrote: >Glad you asked :) Heh, I'm not sure I'm so glad. Did I mention I hate ACPI? Perhaps it's still not too late for me just to define a DT binding and use PRP0001 for it :) >Long story short, QEMUVGID is indeed out of spec, but it works

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-28 Thread Michael S. Tsirkin
On Fri, Jul 26, 2024 at 07:28:28PM +0100, David Woodhouse wrote: > On 26 July 2024 17:49:58 BST, Jonathan Cameron > wrote: > >On Thu, 25 Jul 2024 14:50:50 +0100 > >David Woodhouse wrote: > > > >> On Thu, 2024-07-25 at 08:33 -0400, Michael S. Tsirkin wrote: > >> > On Thu, Jul 25, 2024 at

Re: [PATCH 1/2] module: Split modules_install compression and in-kernel decompression

2024-07-28 Thread Masahiro Yamada
On Thu, Jul 25, 2024 at 9:59 PM Petr Pavlu wrote: > > On 7/22/24 12:23, Masahiro Yamada wrote: > > On Mon, Jul 22, 2024 at 6:07 PM Petr Pavlu wrote: > >> > >> The kernel configuration allows specifying a module compression mode. If > >> one is selected then each module gets compressed during >

Re: [PATCH v2 3/4] ASoC: dt-bindings: apq8016-sbc: Add msm8953/msm8976-qdsp6-sndcard

2024-07-28 Thread Krzysztof Kozlowski
On 27/07/2024 20:20, Adam Skladowski wrote: > Document MSM8953/MSM8976 QDSP6 cards. > > Signed-off-by: Adam Skladowski > --- Your cover letter must ALWAYS clearly document the dependency. > .../sound/qcom,apq8016-sbc-sndcard.yaml | 51 --- > 1 file changed, 45

Re: [PATCH v2 4/4] ASoC: qcom: apq8016_sbc: Add support for msm8953/msm8976 SoC

2024-07-27 Thread Dmitry Baryshkov
On Sat, Jul 27, 2024 at 08:20:27PM GMT, Adam Skladowski wrote: > From: Vladimir Lypak > > Introduce support for audio card on MSM8953/MSM8976 platform. > Main difference between those two is Q6AFE CLK API supported by firmware > which influence way we enable digital codec clock. > Either inside

Re: [PATCH v2 3/4] ASoC: dt-bindings: apq8016-sbc: Add msm8953/msm8976-qdsp6-sndcard

2024-07-27 Thread Dmitry Baryshkov
On Sat, Jul 27, 2024 at 08:20:26PM GMT, Adam Skladowski wrote: > Document MSM8953/MSM8976 QDSP6 cards. > > Signed-off-by: Adam Skladowski > --- > .../sound/qcom,apq8016-sbc-sndcard.yaml | 51 --- > 1 file changed, 45 insertions(+), 6 deletions(-) > > diff --git >

Re: [PATCH v2 2/4] ASoC: msm8916-wcd-analog: add cajon and cajon v2 support

2024-07-27 Thread Dmitry Baryshkov
On Sat, Jul 27, 2024 at 08:20:25PM GMT, Adam Skladowski wrote: > From: Vladimir Lypak > > Add regs overrides for Cajon(PM8952) and Cajon v2(PM8953) codecs. > > Signed-off-by: Vladimir Lypak > [Adam: Add Cajon support,add msg] > Co-developed-by: Adam Skladowski > Signed-off-by: Adam Skladowski

Re: [PATCH v2 1/4] ASoC: qcom: apq8016_sbc.c: Add Quinary support

2024-07-27 Thread Dmitry Baryshkov
On Sat, Jul 27, 2024 at 08:20:24PM GMT, Adam Skladowski wrote: > From: Vladimir Lypak > > Add support for configuring Quinary Mi2S interface > it will be used on MSM8953 and MSM8976 platform. > > Signed-off-by: Vladimir Lypak > [Adam: Split from MSM8953 support patch,add msg] > Signed-off-by:

[PATCH v2 4/4] ASoC: qcom: apq8016_sbc: Add support for msm8953/msm8976 SoC

2024-07-27 Thread Adam Skladowski
From: Vladimir Lypak Introduce support for audio card on MSM8953/MSM8976 platform. Main difference between those two is Q6AFE CLK API supported by firmware which influence way we enable digital codec clock. Either inside machine driver or outside via q6afe-clocks driver. Signed-off-by: Vladimir

[PATCH v2 3/4] ASoC: dt-bindings: apq8016-sbc: Add msm8953/msm8976-qdsp6-sndcard

2024-07-27 Thread Adam Skladowski
Document MSM8953/MSM8976 QDSP6 cards. Signed-off-by: Adam Skladowski --- .../sound/qcom,apq8016-sbc-sndcard.yaml | 51 --- 1 file changed, 45 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8016-sbc-sndcard.yaml

[PATCH v2 2/4] ASoC: msm8916-wcd-analog: add cajon and cajon v2 support

2024-07-27 Thread Adam Skladowski
From: Vladimir Lypak Add regs overrides for Cajon(PM8952) and Cajon v2(PM8953) codecs. Signed-off-by: Vladimir Lypak [Adam: Add Cajon support,add msg] Co-developed-by: Adam Skladowski Signed-off-by: Adam Skladowski --- sound/soc/codecs/msm8916-wcd-analog.c | 63 +--

[PATCH v2 1/4] ASoC: qcom: apq8016_sbc.c: Add Quinary support

2024-07-27 Thread Adam Skladowski
From: Vladimir Lypak Add support for configuring Quinary Mi2S interface it will be used on MSM8953 and MSM8976 platform. Signed-off-by: Vladimir Lypak [Adam: Split from MSM8953 support patch,add msg] Signed-off-by: Adam Skladowski --- sound/soc/qcom/apq8016_sbc.c | 16 +++- 1

[PATCH v2 0/4] MSM8953/MSM8976 ASoC support

2024-07-27 Thread Adam Skladowski
Introduce support for basic sound card setup on MSM8953/MSM8976 platforms, document new compatibles and introduce support for more dais. Most of code is sourced from msm8953-mainline fork over github with some changes implemented by me,some basic changes are mentioned in each patch. [1] -

Re: [PATCH v2 1/2] Add prctl to allow userlevel TDX hypercalls

2024-07-27 Thread kernel test robot
Hi Tim, kernel test robot noticed the following build errors: [auto build test ERROR on tip/x86/vmware] [also build test ERROR on tip/x86/tdx linus/master v6.10 next-20240726] [cannot apply to tip/x86/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v2 1/2] Add prctl to allow userlevel TDX hypercalls

2024-07-27 Thread kernel test robot
Hi Tim, kernel test robot noticed the following build errors: [auto build test ERROR on tip/x86/vmware] [also build test ERROR on tip/x86/tdx linus/master v6.10 next-20240726] [cannot apply to tip/x86/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v2 00/11] perf/uprobe: Optimize uprobes

2024-07-26 Thread Andrii Nakryiko
On Fri, Jul 19, 2024 at 11:42 AM Andrii Nakryiko wrote: > > On Mon, Jul 15, 2024 at 11:10 AM Andrii Nakryiko > wrote: > > > > On Mon, Jul 15, 2024 at 10:10 AM Andrii Nakryiko > > wrote: > > > > > > On Mon, Jul 15, 2024 at 7:45 AM Peter Zijlstra > > > wrote: > > > > > > > > On Thu, Jul 11,

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-07-26 Thread Sami Tolvanen
Hi Petr, On Mon, Jul 22, 2024 at 8:20 AM Petr Pavlu wrote: > > From my perspective, I'm okay if gendwarfksyms doesn't provide > functionality to compare a new object file with its reference symtypes > file. > > As mentioned, genksyms has this functionality but I actually think the > way it works

Re: [PATCH] tracing: Have format file honor EVENT_FILE_FL_FREED

2024-07-26 Thread Steven Rostedt
On Fri, 26 Jul 2024 21:58:30 +0200 Mathias Krause wrote: > >> > >> IMHO, this needs at least the following additional fixes tags to ensure > >> all stable kernels get covered: > >> > >> Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use > >> eventfs_inode") > >> Fixes: 27152bceea1d

Re: [PATCH] tracing: Have format file honor EVENT_FILE_FL_FREED

2024-07-26 Thread Mathias Krause
On 26.07.24 16:52, Steven Rostedt wrote: > On Fri, 26 Jul 2024 12:16:16 +0200 > Mathias Krause wrote: > >>> >>> With KASAN memory checking, it would trigger a use-after-free bug. This was >>> >> >> The UAF bug is there even without KASAN. It's just that KASAN makes it >> much easier to detect

[PATCH v2 2/2] x86/vmware: VMware support for TDX userspace hypercalls

2024-07-26 Thread Tim Merrifield
This change adds a handler for tdx_hcall in the x86_hyper_runtime type for VMware hypervisors which will ultimately invoke __tdx_hypercall. The handler (vmware_tdx_user_hcall) does not reuse the existing vmware_tdx_hypercall for a couple of reasons. First, while the few hypercalls that are

[PATCH v2 1/2] Add prctl to allow userlevel TDX hypercalls

2024-07-26 Thread Tim Merrifield
Add a new process-level prctl option to enable/disable user-level hypercalls when running in a confidential VM. Add support for checking this flag on VMCALL #VE for TDX and transfer control to a hypervisor vendor-specific handler. Signed-off-by: Tim Merrifield --- arch/x86/coco/tdx/tdx.c

[PATCH v2 0/2] Support userspace hypercalls for TDX

2024-07-26 Thread Tim Merrifield
Hypercall instructions like VMCALL and VMMCALL are not restricted to CPL 0. This allows userspace software like open-vm-tools to communicate directly with the VMM. For TDX VMs, this communication may violate the security model. Today, VMCALLs are not forwarded to the host VMM, which breaks

[PATCH] tracing: Use refcount for trace_event_file reference counter

2024-07-26 Thread Steven Rostedt
From: Steven Rostedt Instead of using an atomic counter for the trace_event_file reference counter, use the refcount interface. It has various checks to make sure the reference counting is correct, and will warn if it detects an error (like refcount_inc() on '0'). Signed-off-by: Steven Rostedt

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-26 Thread David Woodhouse
On 26 July 2024 17:49:58 BST, Jonathan Cameron wrote: >On Thu, 25 Jul 2024 14:50:50 +0100 >David Woodhouse wrote: > >> On Thu, 2024-07-25 at 08:33 -0400, Michael S. Tsirkin wrote: >> > On Thu, Jul 25, 2024 at 01:31:19PM +0100, David Woodhouse wrote: >> > > On Thu, 2024-07-25 at 08:29 -0400,

[PATCH v2] tracing: Have format file honor EVENT_FILE_FL_FREED

2024-07-26 Thread Steven Rostedt
From: Steven Rostedt When eventfs was introduced, special care had to be done to coordinate the freeing of the file meta data with the files that are exposed to user space. The file meta data would have a ref count that is set when the file is created and would be decremented and freed after the

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-26 Thread Jonathan Cameron
On Thu, 25 Jul 2024 14:50:50 +0100 David Woodhouse wrote: > On Thu, 2024-07-25 at 08:33 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 01:31:19PM +0100, David Woodhouse wrote: > > > On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > > > > On Thu, Jul 25, 2024 at

Re: [PATCH v2] ptp: Add vDSO-style vmclock support

2024-07-26 Thread David Woodhouse
On 26 July 2024 15:57:34 BST, Jakub Kicinski wrote: >On Fri, 26 Jul 2024 13:28:17 +0100 David Woodhouse wrote: >> +` status = acpi_walk_resources(adev->handle, METHOD_NAME__CRS, > > ^ watch out for ticks! Oops, that last minute space->tab fix after I'd already left home for the weekend

Re: [PATCH] tracing: Have format file honor EVENT_FILE_FL_FREED

2024-07-26 Thread Steven Rostedt
On Fri, 26 Jul 2024 18:00:18 +0530 Ajay Kaher wrote: > Some doubt: > Because of the same race condition, it may happen that kmem_cache_free(file) > was executed while f_start() is waiting to get event_mutex. Once > f_start() acquires > event_mutex, it will access the *file which points to the

Re: [PATCH v2] ptp: Add vDSO-style vmclock support

2024-07-26 Thread Jakub Kicinski
On Fri, 26 Jul 2024 13:28:17 +0100 David Woodhouse wrote: > +` status = acpi_walk_resources(adev->handle, METHOD_NAME__CRS, ^ watch out for ticks!

Re: [PATCH] tracing: Have format file honor EVENT_FILE_FL_FREED

2024-07-26 Thread Steven Rostedt
On Fri, 26 Jul 2024 12:16:16 +0200 Mathias Krause wrote: > > > > With KASAN memory checking, it would trigger a use-after-free bug. This was > > > > The UAF bug is there even without KASAN. It's just that KASAN makes it > much easier to detect and catch early. Well the bug happens without

Re: [PATCH v2 1/2] nvdimm: Fix devs leaks in scan_labels()

2024-07-26 Thread Ira Weiny
Li Zhijian wrote: > The leakage would happend when create_namespace_pmem() meets an invalid > label which gets failure in validating isetcookie. > > Try to resuse the devs that may have already been allocated with size > (2 * sizeof(dev)) previously. > > A kmemleak reports: > unreferenced object

Re: [PATH v6 3/3] vdpa/mlx5: Add the support of set mac address

2024-07-26 Thread Cindy Lu
On Fri, 26 Jul 2024 at 01:32, Joe Damato wrote: > > On Thu, Jul 25, 2024 at 09:31:04AM +0800, Cindy Lu wrote: > > Add the function to support setting the MAC address. > > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac > > to set the mac address > > > > Tested in ConnectX-6 Dx device > > >

<    1   2   3   4   5   6   7   8   9   10   >