On 2/11/21 8:50 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote:
On 9.2.2021 10.37, Greg Kroah-Hartman wrote:
On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote:
On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma wrote:
On 2/5/21 12:27 PM
On 2/5/21 12:27 PM, Kai-Heng Feng wrote:
Can you please test the following patch, which should address the root cause:
https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furq...@google.com/
It also helps another AMD laptop on S5:
power on and reboot.
Signed-off-by: Aaron Ma
---
drivers/usb/host/xhci-pci.c | 8
drivers/usb/host/xhci.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 84da8406d5b4..a31be1ba927f 100644
--- a/drivers/usb/host/xhci
BOE 2270 panel failed to control backlight brightness.
Add it in edid quirks to force using DPCD backlight control.
Then the brightness can be controlled.
Signed-off-by: Aaron Ma
---
drivers/gpu/drm/drm_dp_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm
BOE panel with ID 2270 claims both PWM_PIN_CAP and AUX_SET_CAP backlight
control bits, but default chip backlight failed to control brightness.
Check AUX_SET_CAP and proceed to check quirks or VBT backlight type.
DPCD can control the brightness of this pannel.
Signed-off-by: Aaron Ma
_BCL")
Signed-off-by: Aaron Ma
---
drivers/platform/x86/thinkpad_acpi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 9c4df41687a3..477d63c49c04 100644
--- a/drivers/platform/x86/thinkpad_ac
Evaluating acpi _BCL could be failed, then acpi buffer size will be set
to 0. When reuse this acpi buffer, AE_BUFFER_OVERFLOW will be triggered.
Re-initialize buffer size will make acpi evaluate successfully.
Signed-off-by: Aaron Ma
---
drivers/platform/x86/thinkpad_acpi.c | 4 +++-
1 file
When _BCL invalid, disable thinkpad_acpi backlight brightness control.
brightness_enable is already checked at the beginning.
Most new thinkpads are using GPU driver to control brightness now,
print notice when enabled brightness control even when brightness_enable = 1.
Signed-off-by: Aaron Ma
RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram,
it breaks backlight control.
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=208277
Signed-off-by: Aaron Ma
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
When _BCL invalid, disable thinkpad_acpi backlight brightness control.
brightness_enable is already checked at the beginning.
Most new thinkpads are using GPU driver to control brightness now,
print notice when enabled brightness control even when brightness_enable = 1.
Signed-off-by: Aaron Ma
On 7/2/20 5:30 PM, Andy Shevchenko wrote:
> On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma wrote:
>>
>> When _BCL invalid, disable thinkpad_acpi backlight brightness control.
>>
>> brightness_enable is already checked at the beginning,
>
>> Always print notice when
When _BCL invalid, disable thinkpad_acpi backlight brightness control.
brightness_enable is already checked at the beginning,
Always print notice when enabled brightness control.
Signed-off-by: Aaron Ma
---
drivers/platform/x86/thinkpad_acpi.c | 7 +--
1 file changed, 5 insertions(+), 2
test result good too.
Fixes: 0c80cdbf3320 ("e1000e: Warn if disabling ULP failed")
Signed-off-by: Aaron Ma
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c
b/drivers/net/ethernet/intel/e1000
test result good too.
Fixes: 0c80cdbf3320 ("e1000e: Warn if disabling ULP failed")
Signed-off-by: Aaron Ma
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c
b/drivers/net/ethernet/intel/e1000
ult good too.
Fixes: 0c80cdbf33 ("e1000e: Warn if disabling ULP failed")
Signed-off-by: Aaron Ma
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c
b/drivers/net/ethernet/intel/e1000
On 6/16/20 7:23 PM, Kai-Heng Feng wrote:
>
>
>> On Jun 16, 2020, at 18:05, Aaron Ma wrote:
>>
>> After commit "e1000e: disable s0ix entry and exit flows for ME systems",
>> some ThinkPads always failed to disable ulp by ME.
>> commit "e100
On 6/16/20 6:20 PM, Paul Menzel wrote:
> Dear Aaron,
>
>
> Thank you for your patch.
>
> (Rant: Some more fallout from the other patch, which nobody reverted.)
>
Would you like a revert?
Thanks,
Aaron
> Am 16.06.20 um 12:05 schrieb Aaron Ma:
>> After comm
rn to e_dbg, in case it confuses.
Signed-off-by: Aaron Ma
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c
b/drivers/net/ethernet/intel/e1000e/ich8lan.c
index f999cca37a8a..63405819eb83
New device ID 0xc82f found on Lenovo ThinkCenter.
Tested it with c822 driver, works good.
PCI id:
03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd.
Device [10ec:c82f]
Subsystem: Lenovo Device [17aa:c02f]
Signed-off-by: Aaron Ma
---
drivers/net/wireless/realtek/rtw88
On 10/23/19 4:44 PM, Kailang wrote:
>
>
>> -Original Message-
>> From: Takashi Iwai
>> Sent: Wednesday, October 23, 2019 12:08 AM
>> To: Aaron Ma
>> Cc: pe...@perex.cz; Kailang ;
>> hui.w...@canonical.com; alsa-de...@alsa-project.org;
>
be shown, and audio output works
fine.
Signed-off-by: Aaron Ma
---
sound/pci/hda/patch_realtek.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b000b36ac3c6..c34d8b435f58 100644
--- a/sound/pci/hda/patch_realtek.c
On 6/12/19 1:35 AM, Dmitry Torokhov wrote:
> On Tue, Jun 11, 2019 at 12:55:58AM +0800, Aaron Ma wrote:
>> On 6/10/19 12:55 AM, Dmitry Torokhov wrote:
>>> Hi Aaron,
>>>
>>> On Wed, Feb 20, 2019 at 05:41:59PM +0100, Aaron Ma wrote:
>>>> rmi4
On 6/10/19 12:55 AM, Dmitry Torokhov wrote:
> Hi Aaron,
>
> On Wed, Feb 20, 2019 at 05:41:59PM +0100, Aaron Ma wrote:
>> rmi4 got spam data after S3 resume on some ThinkPads.
>> Then TrackPoint lost when be detected by psmouse.
>> Clear irqs status before set irq
Hi Dmitry:
Will you apply them?
Thanks,
Aaron
On 6/4/19 1:19 PM, Christopher Heiny wrote:
> Given that, I'm willing to accept the patch as is.
>
> Cheers,
> Chris
Hi Christopher:
Have got time to review these 2 patches?
Users reported it works fine since I sent out this patch.
Thanks,
Aaron
On 4/3/19 9:58 PM, Aaron Ma wrote:
> Sure, take your time, if you have any questions let me know please.
>
> Thanks,
> Aaron
On 5/21/19 2:49 PM, Benjamin Tissoires wrote:
> A quick google image search showed that the X240 had 2 versions: one
> with the top software buttons, one without.
>
> And this definitively rings a bell. I am sure we asked Lenovo and
> Synaptics to change the PnPID when they would do such a
Adding 2 new touchpad PNPIDs to enable middle button support.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/input/mouse/elantech.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index a7f8b1614559
Lenovo ThinkPad X240 does not have the top software button.
When this wrong ID in top button list, smbus mode will fail to probe,
so keep it working at PS2 mode.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/input/mouse/synaptics.c | 1 -
1 file changed, 1 deletion(-)
diff
On 4/25/19 10:39 PM, Christoph Hellwig wrote:
> Honestly, unless this is a device shiping in a max market consumer
> product already I don't think we should work around this crap at all,
> given that this device has obviously never been tested at all. It
> really needs a firmware fix instead of
On 4/18/19 9:48 PM, Keith Busch wrote:
> It does change the default behavior. If I have a degraded controller that
> can't do IO in a machine with 1000's of CPUs, I have to iterate this
> non-standard behavior 1000's of times before the drive is servicable
> again. We currenlty figure that out
On 4/18/19 9:33 PM, Minwoo Im wrote:
> If the controller returns error for that command, how can we assure that
> the controller would support a single I/O queue ?
Make sense, I will keep *count = 0 in V2.
Thanks,
Aaron
On 4/18/19 8:13 PM, Minwoo Im wrote:
>> Yes the IO queues number is 0's based, but driver would return error and
>> remove the nvme device as dead.
>
> IMHO, if a controller indicates an error with this set_feature command,
> then
> we need to figure out why the controller was returning the
On 4/18/19 5:30 AM, Edmund Nadolski (Microsoft) wrote:
> On 4/17/19 7:12 AM, Aaron Ma wrote:
>> Some controllers support limited IO queues, when over set
>> the number, it will return invalid field error.
>> Then NVME will be removed by driver.
>>
>>
On 4/18/19 1:33 AM, Maxim Levitsky wrote:
> On Wed, 2019-04-17 at 20:32 +0300, Maxim Levitsky wrote:
>> On Wed, 2019-04-17 at 22:12 +0800, Aaron Ma wrote:
>>> Some controllers support limited IO queues, when over set
>>> the number, it will return invalid field error.
&g
-by: Aaron Ma
---
drivers/nvme/host/core.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 2c43e12b70af..fb7f05c310c8 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
On 4/3/19 12:16 AM, Christopher Heiny wrote:
> On Thu, 2019-03-28 at 14:02 +0800, Aaron Ma wrote:
>> Hi Dmitry and Chiristopher:
>>
>> Do you have any suggestion about these 2 patches?
>>
>> Many users confirmed that they fixed issues of Trackpoint/Touchpad
>
Hi Dmitry and Chiristopher:
Do you have any suggestion about these 2 patches?
Many users confirmed that they fixed issues of Trackpoint/Touchpad after S3.
Will you consider them be accepted?
Thanks,
Aaron
Add a non-NULL check to fix potential NULL pointer dereference
Cleanup code to call function once.
Signed-off-by: Aaron Ma
---
drivers/iommu/amd_iommu.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index
Hi,
On 3/9/19 7:13 AM, Christopher Heiny wrote:
> I'm not sure this is a safe action, due to a race condition with the
> actual IRQ handler (rmi_process_interrupt_requests from rmi_driver.c).
> Remember that reading the IRQ status register clears all the IRQ bits.
> So you're faced with this
rmi4 got spam data after S3 resume on some ThinkPads.
Then TrackPoint lost when be detected by psmouse.
Clear irqs status before set irqs will make TrackPoint back.
BugLink: https://bugs.launchpad.net/bugs/1791427
Cc:
Signed-off-by: Aaron Ma
---
drivers/input/rmi4/rmi_driver.c | 11
/1791427
Cc:
Signed-off-by: Aaron Ma
---
drivers/input/rmi4/rmi_f01.c | 45
1 file changed, 45 insertions(+)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index 4edaa14fe878..e41d1ec625d9 100644
--- a/drivers/input/rmi4/rmi_f01.c
+++ b
Adding 2 new touchpad IDs to support middle button support.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/input/mouse/elantech.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 44f57cf6675b
Adding 2 new touchpad IDs to support middle button support.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/input/mouse/elantech.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 44f57cf6675b
Like on X1C6, on X1Y3 EC interrupts constantly wake up system from
s2idle, the power consumption is extremely high.
So make ec_no_wakeup be true as default to keep system in s2idle mode
and reduce power consumption.
Power button works when ec_no_wakeup=true.
Signed-off-by: Aaron Ma
---
drivers
Like on X1C6, on X1Y3 EC interrupts constantly wake up system from
s2idle, the power consumption is extremely high.
So make ec_no_wakeup be true as default to keep system in s2idle mode
and reduce power consumption.
Power button works when ec_no_wakeup=true.
Signed-off-by: Aaron Ma
---
drivers
On 06/19/2018 08:21 PM, Benjamin Tissoires wrote:
> On Tue, Jun 12, 2018 at 9:10 AM Aaron Ma wrote:
>> PNPID is better way to identify the type of touchpads.
>> Enable middle button support on 2 types of touchpads on Lenovo P52.
>>
>> Cc: sta...@vger.kernel.org
&g
On 06/19/2018 08:21 PM, Benjamin Tissoires wrote:
> On Tue, Jun 12, 2018 at 9:10 AM Aaron Ma wrote:
>> PNPID is better way to identify the type of touchpads.
>> Enable middle button support on 2 types of touchpads on Lenovo P52.
>>
>> Cc: sta...@vger.kernel.org
&g
PNPID is better way to identify the type of touchpads.
Enable middle button support on 2 types of touchpads on Lenovo P52.
Cc: sta...@vger.kernel.org
Cc: KT Liao
Signed-off-by: Aaron Ma
---
drivers/input/mouse/elantech.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
PNPID is better way to identify the type of touchpads.
Enable middle button support on 2 types of touchpads on Lenovo P52.
Cc: sta...@vger.kernel.org
Cc: KT Liao
Signed-off-by: Aaron Ma
---
drivers/input/mouse/elantech.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
On 05/16/2018 03:09 PM, Teika Kazura wrote:
> From: Aaron Ma <aaron...@canonical.com>
> Date: Tue, 17 Apr 2018 19:42:27 +0800
>
>> Could you apply my patch too?
>>
>> It add LEN0096 that Benjamin's patch doesn't include.
>>
>> +"LEN0096&qu
On 05/16/2018 03:09 PM, Teika Kazura wrote:
> From: Aaron Ma
> Date: Tue, 17 Apr 2018 19:42:27 +0800
>
>> Could you apply my patch too?
>>
>> It add LEN0096 that Benjamin's patch doesn't include.
>>
>> +"LEN0096", /* X280 */
> Aaron, i
<dan.carpen...@oracle.com>
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/i2c-hid/i2c-hid.c | 13 +
2 files changed, 16 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5a3a7ead3012..
Signed-off-by: Aaron Ma
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/i2c-hid/i2c-hid.c | 13 +
2 files changed, 16 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5a3a7ead3012..0b5cc910f62e 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid
Hi Dmitry and Benjamin:
Could you apply my patch too?
It add LEN0096 that Benjamin's patch doesn't include.
+ "LEN0096", /* X280 */
Regards,
Aaron
Hi Dmitry and Benjamin:
Could you apply my patch too?
It add LEN0096 that Benjamin's patch doesn't include.
+ "LEN0096", /* X280 */
Regards,
Aaron
as a quirk.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/i2c-hid/i2c-hid.c | 13 +
2 files changed, 16 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5a3a7e
as a quirk.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/i2c-hid/i2c-hid.c | 13 +
2 files changed, 16 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5a3a7ead3012..0b5cc910f62e 100644
--- a/drivers
Hi Jiri:
Re-send this patch.
Thanks,
Aaron
On 01/03/2018 01:30 AM, Aaron Ma wrote:
> When Rayd touchscreen resumed from S3, it issues too many errors like:
> i2c_hid i2c-RAYD0001:00: i2c_hid_get_input: incomplete report (58/5442)
>
> And all the report data are corrupted,
Hi Jiri:
Re-send this patch.
Thanks,
Aaron
On 01/03/2018 01:30 AM, Aaron Ma wrote:
> When Rayd touchscreen resumed from S3, it issues too many errors like:
> i2c_hid i2c-RAYD0001:00: i2c_hid_get_input: incomplete report (58/5442)
>
> And all the report data are corrupted,
Hi Jiri:
This patch is pending for long time.
Could you merge this single patch to upstream?
Regards,
Aaron
Hi Jiri:
This patch is pending for long time.
Could you merge this single patch to upstream?
Regards,
Aaron
Lenovo E41-20 needs more time than 100ms to read VPC,
the funtion keys always failed responding.
Increase timeout to get the value from VPC, then
the funtion keys like mic mute key work well.
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/platform/x86/ideapad-laptop.c | 2
Lenovo E41-20 needs more time than 100ms to read VPC,
the funtion keys always failed responding.
Increase timeout to get the value from VPC, then
the funtion keys like mic mute key work well.
Signed-off-by: Aaron Ma
---
drivers/platform/x86/ideapad-laptop.c | 2 +-
1 file changed, 1 insertion
Follow the change of return type u32 of hid_report_len,
fix all the types of variables those get the return value of
hid_report_len to u32, and all other code already uses u32.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/hid/hid-input.c
Follow the change of return type u32 of hid_report_len,
fix all the types of variables those get the return value of
hid_report_len to u32, and all other code already uses u32.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/hid/hid-input.c | 3 ++-
drivers/hid/hid
On 02/03/2018 03:55 PM, Marcus Folkesson wrote:
> Hi Aaron,
>
> On Mon, Jan 08, 2018 at 10:41:41AM +0800, Aaron Ma wrote:
>> When size is negative, calling memset will make segment fault.
>> Declare the size as type u32 to keep memset safe.
>>
>> size in struct h
On 02/03/2018 03:55 PM, Marcus Folkesson wrote:
> Hi Aaron,
>
> On Mon, Jan 08, 2018 at 10:41:41AM +0800, Aaron Ma wrote:
>> When size is negative, calling memset will make segment fault.
>> Declare the size as type u32 to keep memset safe.
>>
>> size in struct h
Hi Marcus:
This patch is replaced by v2 patches you just reviewed.
Thanks,
Aaron
Hi Marcus:
This patch is replaced by v2 patches you just reviewed.
Thanks,
Aaron
Hi
Could anyone review an apply this single patch?
The 2nd patch had been sent as v2.
Regards,
Aaron
Hi
Could anyone review an apply this single patch?
The 2nd patch had been sent as v2.
Regards,
Aaron
Hi:
Could anyone review and apply these 2 patch?
Regards,
Aaron
Hi:
Could anyone review and apply these 2 patch?
Regards,
Aaron
Will your patch go to stable kernel?
If yes, that's fine.
Will your patch go to stable kernel?
If yes, that's fine.
Only this laptop had been confirmed is ALPS: 0102 – FF02 trackpoint, it
return 0 of extended button.
I saw the other device that returned 0, but don't have it now, so the ID
can not be checked.
ThinkPad always have 3 buttons installed, I suggest always set 0x33 for
button info when the button
Only this laptop had been confirmed is ALPS: 0102 – FF02 trackpoint, it
return 0 of extended button.
I saw the other device that returned 0, but don't have it now, so the ID
can not be checked.
ThinkPad always have 3 buttons installed, I suggest always set 0x33 for
button info when the button
Lenovo introduced trackpoint compatible sticks with minimum PS/2 commands.
Some of these sticks with 3 buttons always return 0 when reading
extended button info, set it as 3 buttons to enable middle button.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
d
Lenovo introduced trackpoint compatible sticks with minimum PS/2 commands.
Some of these sticks with 3 buttons always return 0 when reading
extended button info, set it as 3 buttons to enable middle button.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/input/mouse/trackpoint.c
When convert char array with signed int, if the inbuf[x] is negative then
upper bits will be set to 1. Fix this by using u8 instead of char.
ret_size has to be at least 3, hid_input_report use it after minus 2 bytes.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma <aaron...@canonical.
When size is negative, calling memset will make segment fault.
Declare the size as type u32 to keep memset safe.
size in struct hid_report is unsigned, fix return type of
hid_report_len to u32.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/h
When convert char array with signed int, if the inbuf[x] is negative then
upper bits will be set to 1. Fix this by using u8 instead of char.
ret_size has to be at least 3, hid_input_report use it after minus 2 bytes.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/hid/i2c-hid
When size is negative, calling memset will make segment fault.
Declare the size as type u32 to keep memset safe.
size in struct hid_report is unsigned, fix return type of
hid_report_len to u32.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/hid/hid-core.c | 10
I will follow your advice and send V2.
Thanks,
Aaron
I will follow your advice and send V2.
Thanks,
Aaron
Hi Benjamin:
Thanks for reviewing my patches.
This issue only happened on this RayD 2386:3118 touchscreen.
No other devices found, so I think it should be in quirk.
Hi Benjamin:
Thanks for reviewing my patches.
This issue only happened on this RayD 2386:3118 touchscreen.
No other devices found, so I think it should be in quirk.
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/hid/hid-core.c| 4 ++--
drivers/hid/i2c-hid/i2c-hid.c | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 0c3f608131cf..992547771d96
Signed-off-by: Aaron Ma
---
drivers/hid/hid-core.c| 4 ++--
drivers/hid/i2c-hid/i2c-hid.c | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 0c3f608131cf..992547771d96 100644
--- a/drivers/hid/hid-core.c
+++ b
as a quirk.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/i2c-hid/i2c-hid.c | 13 +
2 files changed, 16 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5da3d6
as a quirk.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/i2c-hid/i2c-hid.c | 13 +
2 files changed, 16 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5da3d6256d25..753cc10aa699 100644
--- a/drivers
Please add the patch version next time.
The patch make trackstick work on L570.
Tested-by: Aaron Ma <aaron...@canonical.com>
On 11/29/2017 04:33 PM, Masaki Ota wrote:
> From: Masaki Ota <masaki@jp.alps.com>
> - The issue is that Thinkpad L570 TrackStick does not work
Please add the patch version next time.
The patch make trackstick work on L570.
Tested-by: Aaron Ma
On 11/29/2017 04:33 PM, Masaki Ota wrote:
> From: Masaki Ota
> - The issue is that Thinkpad L570 TrackStick does not work. Because the main
> interface of Thinkpad L570 device is
Tested-by: Aaron Ma <aaron...@canonical.com>
On 11/20/2017 03:55 PM, Masaki Ota wrote:
> From: Masaki Ota <masaki@jp.alps.com>
> - The issue is that Thinkpad L570 TrackStick does not work. Because the main
> interface of Thinkpad L570 device is SMBus, so ALPS ove
Tested-by: Aaron Ma
On 11/20/2017 03:55 PM, Masaki Ota wrote:
> From: Masaki Ota
> - The issue is that Thinkpad L570 TrackStick does not work. Because the main
> interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface
> Firmware setting of TrackStick
The touchpad of Lenovo Thinkpad L480 reports it's version as 15.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/input/mouse/elantech.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input
The touchpad of Lenovo Thinkpad L480 reports it's version as 15.
Cc: sta...@vger.kernel.org
Signed-off-by: Aaron Ma
---
drivers/input/mouse/elantech.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index
jp.alps.com>
> Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org;
> dmitry.torok...@gmail.com; Aaron Ma <aaron...@canonical.com>
> Subject: Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices
>
> On Wednesday 15 November 2017 14:34:04 Aaron Ma wrote:
>&
er.kernel.org; linux-kernel@vger.kernel.org;
> dmitry.torok...@gmail.com; Aaron Ma
> Subject: Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices
>
> On Wednesday 15 November 2017 14:34:04 Aaron Ma wrote:
>> There is a regression of commit 4a646580f793 (&
0f793, after restore the OTP reading order,
it becomes to 0x10 as before and reports the right flag.
Fixes: 4a646580f793 ("Input: ALPS - fix two-finger scroll breakage")
Cc: <sta...@vger.kernel.org>
Signed-off-by: Aaron Ma <aaron...@canonical.com>
---
drivers/input/mouse/alp
1 - 100 of 117 matches
Mail list logo
