Re: [PATCH v4] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-08 Thread Abhishek Bhardwaj
On Wed, Jul 8, 2020 at 12:34 PM Randy Dunlap wrote: > > Hi again, > > On 7/8/20 12:25 PM, Abhishek Bhardwaj wrote: > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > > index b277a2db62676..1f85374a0b812 100644 > > --- a/arch/x86/kvm/Kconfig > > +++

[PATCH v5] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-08 Thread Abhishek Bhardwaj
time thing rather than adding extra code plus whatever miniscule time at runtime to pass an extra argument. - Finally, it doesn't preclude the runtime / kernel command line way. Users are free to use those as well. Signed-off-by: Abhishek Bhardwaj --- Changes in v5: - Fix indentation

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-08 Thread Abhishek Bhardwaj
On Mon, Jul 6, 2020 at 8:14 AM Waiman Long wrote: > > On 7/5/20 5:51 PM, Abhishek Bhardwaj wrote: > > That is why I said a comment will have to be added to highlight this > dependency. For instance, > > +/* > + * Three of the enums are explicitly assigned as the KVM_VMENTR

[PATCH v4] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-08 Thread Abhishek Bhardwaj
time thing rather than adding extra code plus whatever miniscule time at runtime to pass an extra argument. - Finally, it doesn't preclude the runtime / kernel command line way. Users are free to use those as well. Signed-off-by: Abhishek Bhardwaj --- Changes in v4: - Add motivation

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-05 Thread Abhishek Bhardwaj
On Sun, Jul 5, 2020 at 11:48 AM Waiman Long wrote: > > On 7/5/20 2:22 PM, Abhishek Bhardwaj wrote: > > On Sun, Jul 5, 2020 at 8:57 AM Waiman Long wrote: > >> On 7/5/20 11:23 AM, Mike Rapoport wrote: > >>>> Nothing prevents people from continuing to

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-05 Thread Abhishek Bhardwaj
On Sun, Jul 5, 2020 at 8:57 AM Waiman Long wrote: > > On 7/5/20 11:23 AM, Mike Rapoport wrote: > >> Nothing prevents people from continuing to use the command line > >> options if they want, right? This just allows a different default. > >> So if a distro is security focused and decided that it

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-03 Thread Abhishek Bhardwaj
We have tried to steer away from kernel command line args for a few reasons. I am paraphrasing my colleague Doug's argument here (CC'ed him as well) - - The command line args are getting unwieldy. Kernel command line parameters are not a scalable way to set kernel config. It's intended as a

Re: [PATCH v2] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-02 Thread Abhishek Bhardwaj
On Thu, Jul 2, 2020 at 3:01 PM Randy Dunlap wrote: > > Hi-- > > On 7/2/20 2:38 PM, Abhishek Bhardwaj wrote: > > This change adds a new kernel configuration that sets the l1d cache > > flush setting at compile time rather than at run time. > > > &

[PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-02 Thread Abhishek Bhardwaj
This change adds a new kernel configuration that sets the l1d cache flush setting at compile time rather than at run time. Signed-off-by: Abhishek Bhardwaj --- Changes in v3: - Change depends on to only x86_64. - Remove copy paste errors at the end of the KConfig. Changes in v2: - Fix typo

[PATCH v2] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-02 Thread Abhishek Bhardwaj
This change adds a new kernel configuration that sets the l1d cache flush setting at compile time rather than at run time. Signed-off-by: Abhishek Bhardwaj --- Changes in v2: - Fix typo in the help of the new KConfig. arch/x86/kernel/cpu/bugs.c | 8 arch/x86/kvm/Kconfig | 17

[PATCH] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-02 Thread Abhishek Bhardwaj
This change adds a new kernel configuration that sets the l1d cache flush setting at compile time rather than at run time. Signed-off-by: Abhishek Bhardwaj --- arch/x86/kernel/cpu/bugs.c | 8 arch/x86/kvm/Kconfig | 17 + 2 files changed, 25 insertions(+) diff