dev_info(dev, "Sony HELENE attached on addr=%x at I2C adapter %p\n",
> +priv->i2c_address, priv->i2c);
> +
> + return 0;
> +}
> +
> +static const struct i2c_device_id helene_id[] = {
> + { "helene", },
> + {}
> +};
Acked-by: Abylay Ospan
2018-05-16 4:41 GMT-04:00 Katsuhiro Suzuki :
> This patch fixes crystal frequency setting when power on this device.
>
> Signed-off-by: Katsuhiro Suzuki
> ---
> drivers/media/dvb-frontends/helene.c | 5 -
> 1 file changed, 4 insertions(+), 1 de
riv = fe->tuner_priv;
> - int frequencykHz = p->frequency;
> + int frequencykHz = p->frequency / 1000;
> uint32_t frequency4kHz = 0;
> u32 symbol_rate = p->symbol_rate/1000;
>
> --
> 2.17.0
>
--
Abylay Ospan,
NetUP Inc.
http://www.netup.tv
Dear Takiguchi,
Roger that.
Thanks for explanation !
2017-06-13 1:35 GMT-04:00 Takiguchi, Yasunari :
> Dear Abylay Ospan
>
> Thank you for your review and proposal.
>
> Unfortunately, we supposed it's difficult to cover CXD2841 functionality by
> CXD2880 driver.
>
atch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver
> on Apr/14.
> Are there any comments, advices and review results for them?
>
> I'd like to get better understanding of current review status for our codes.
>
> Regards,
> Takiguchi
--
Abylay Ospan,
NetUP Inc.
http://www.netup.tv
Yes, you right. Now it's clear.
Thanks !
2017-02-08 17:27 GMT-05:00 Bjorn Helgaas :
> On Wed, Feb 08, 2017 at 05:07:27PM -0500, Abylay Ospan wrote:
>> Hi Bjorn,
>>
>> I have checked first listed driver
>> (drivers/pci/host/pcie-designware.c). Seems like into
&g
hink it's necessary to keep the
> list_head in the struct iproc_pcie. It should be safe to use
> "LIST_HEAD(res)" on the stack like the other drivers do. Can you
> verify that and get an ack from Ray, Scott, or Jon?
if my investigation above is true then we need to keep 'res' all the
time we working with the driver (or find another way to fix this
issue).
--
Abylay Ospan,
NetUP Inc.
http://www.netup.tv
gt;>
>> this patch adds sanity check to prevent crash.
>
> Humm, how can it not be defined based on your earlier comment that you
> are using this on NSP which is Device Tree exclusively? I would agree if
> this was seen on e.g: MIPS/BCMA (47xx).
>
>>
>> Signed-off
Jui :
> Hi Abylay,
>
> On 1/12/2017 3:58 PM, Abylay Ospan wrote:
>> Resource allocated on stack was saved by 'devm_request_resource' to
>> global 'iomem_resource' but become invalid after 'iproc_pcie_bcma_probe'
>> exit.
>> So the glob
ode doesn't assigned.
Is some code missing in drivers/bcma/ which should assign of_node ?
I can suggest following "hacky" patch for this (works for me):
Author: Abylay Ospan
Date: Fri Jan 13 07:24:13 2017 +0300
bcma: force assign 'of_node' for devices on the b
pcie->dev->of_node not always defined (NULL) and can cause crash:
[ 19.053195] Unable to handle kernel NULL pointer dereference at
virtual address 0020
[] (of_n_addr_cells) from []
(iproc_pcie_setup+0x30c/0xce0)
this patch adds sanity check to prevent crash.
Signed-off-by: Abylay
n failure.
Tested on Broadcom NorthStar machine ('Edgecore ECW7220-L') with two PCIe wifi
adapters (b43 BCM4331 and ath10k QCA988X).
Signed-off-by: Abylay Ospan
---
drivers/pci/host/pcie-iproc-bcma.c | 18 --
drivers/pci/host/pcie-iproc.h | 2 ++
2 files changed, 10 in
Hi Colin,
It's really possible memory leak here. thanks for fix.
Acked-by: Abylay Ospan
2016-08-13 14:16 GMT-04:00 Colin King :
> From: Colin Ian King
>
> The error return path of failed calls to heleno_x_pon leak
> memory because priv is not kfree'd. Fix this by k
time.
> * Giving consistent and precise error messages
>
> This series is a first step of trying to move generic error messages
> from drivers to subsystem cores.
>
--
Abylay Ospan,
NetUP Inc.
http://www.netup.tv
yes, you right. If we remove this message there is no big problem. But
if we do not remove this it's also ok, right ? What the big deal to
remove this type of messages (i'm just interested) ?
For me it's ok to remove:
Acked-by: Abylay Ospan
2016-08-09 10:58 GMT-04:
Hello Arnd,
thanks for patch. it looks ok.
Acked-by: Abylay Ospan
2016-07-13 16:42 GMT-04:00 Arnd Bergmann :
> The addition of jump label support in dynamic_debug caused an unexpected
> warning in exactly one file in the kernel:
>
> drivers/media/dvb-frontends/cxd2841er.c:
Acked-by: Abylay Ospan
2016-06-24 14:00 GMT-04:00 Colin King :
> From: Colin Ian King
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King
> ---
> drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 2 +-
> 1 file changed, 1
Hello,
Acked-by: Abylay Ospan
2015-10-16 19:02 GMT+03:00 Andrey Ryabinin :
> When the kernel compiled with KASAN=y, GCC adds redzones
> for each variable on stack. This enlarges function's stack
> frame and causes:
> 'warning: the frame size of X bytes is larger
Hello,
Acked-by: Abylay Ospan
thanks !
2015-10-03 18:19 GMT+03:00 Christoph Hellwig :
> This ensures the dma mask that is supported by the driver is recorded
> in the device structure.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/media/pci/netup_unidvb/netup_unidvb_
x86_64:
>>>
>>>
>>
>> Compiles fine for me, and I enabled:
>>
>> CONFIG_PROFILE_ALL_BRANCHES=y
>> CONFIG_MEDIA_SUPPORT=y
>> CONFIG_MEDIA_ANALOG_TV_SUPPORT=y
>>
>> which looks like it should give the problem you have.
>>
>> What
20 matches
Mail list logo
