RE: [PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-21 Thread Adam Thomson
Hi Heikki, On 21 May 2018 14:20, Heikki Krogerus wrote: > On Wed, May 16, 2018 at 05:00:46PM +0100, Adam Thomson wrote: > > For supply registration, provide of_node pointer of the port device, > > via the power_supply_config structure, to allow other psy drivers > > to add u

RE: [PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-21 Thread Adam Thomson
Hi Heikki, On 21 May 2018 14:20, Heikki Krogerus wrote: > On Wed, May 16, 2018 at 05:00:46PM +0100, Adam Thomson wrote: > > For supply registration, provide of_node pointer of the port device, > > via the power_supply_config structure, to allow other psy drivers > > to add u

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 9:06 AM, Christoph Hellwig wrote: > Looks fine, although I'd split it into a aio and block_dev patch. > > Also please wire this up for the fs/iomap.c direct I/O code, it should > be essentially the same sniplet as in the block_dev.c code. > Will do.

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 9:06 AM, Christoph Hellwig wrote: > Looks fine, although I'd split it into a aio and block_dev patch. > > Also please wire this up for the fs/iomap.c direct I/O code, it should > be essentially the same sniplet as in the block_dev.c code. > Will do.

Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-18 Thread Adam Manzanares
On 5/18/18 9:05 AM, Christoph Hellwig wrote: >> +/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */ > > I don't think this comment is very useful. > >> +static inline u16 ki_hint_valid(enum rw_hint hint) > > I'd call this ki_hint_validate. > >> +{ >> +if (hint >

Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-18 Thread Adam Manzanares
On 5/18/18 9:05 AM, Christoph Hellwig wrote: >> +/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */ > > I don't think this comment is very useful. > >> +static inline u16 ki_hint_valid(enum rw_hint hint) > > I'd call this ki_hint_validate. > >> +{ >> +if (hint >

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 8:14 AM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IOPRIO is set o

Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-18 Thread Adam Manzanares
On 5/18/18 8:14 AM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set t

Re: [PATCH v4 0/3] AIO add per-command iopriority

2018-05-18 Thread Adam Manzanares
On 5/17/18 7:41 PM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> See the following link for performance imp

Re: [PATCH v4 0/3] AIO add per-command iopriority

2018-05-18 Thread Adam Manzanares
On 5/17/18 7:41 PM, Jens Axboe wrote: > On 5/17/18 2:38 PM, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> See the following link for performance implications on a SATA HDD: >> ht

[PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-17 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for

[PATCH v4 3/3] fs: Add aio iopriority support for block_dev

2018-05-17 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for an aio request by the block dev

[PATCH v4 0/3] AIO add per-command iopriority

2018-05-17 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call t

[PATCH v4 0/3] AIO add per-command iopriority

2018-05-17 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call to also be used by the aio

[PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-17 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- include/lin

[PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-17 Thread adam . manzanares
From: Adam Manzanares In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares --- include/linux/fs.h | 15 +-- 1 file changed, 13 insertions(+), 2 deletions

[PATCH v4 1/3] block: add ioprio_check_cap function

2018-05-17 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to

[PATCH v4 1/3] block: add ioprio_check_cap function

2018-05-17 Thread adam . manzanares
From: Adam Manzanares Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to submit IOPRIO_RT commands. This patch

Re: [PATCH v10 00/27] ARM: davinci: convert to common clock framework​

2018-05-16 Thread Adam Ford
vice tree clock support to the one SoC that > supports it. > > This series has been tested on TI OMAP-L138 LCDK (both device tree and legacy > board file). > I am find. I don't know what I did wrong, but it's working fine. If you want to add my 'tested-by' go ahead. Tested-by: Adam

Re: [PATCH v10 00/27] ARM: davinci: convert to common clock framework​

2018-05-16 Thread Adam Ford
he one SoC that > supports it. > > This series has been tested on TI OMAP-L138 LCDK (both device tree and legacy > board file). > I am find. I don't know what I did wrong, but it's working fine. If you want to add my 'tested-by' go ahead. Tested-by: Adam Ford #da850-evm, ether

[PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-16 Thread Adam Thomson
For supply registration, provide of_node pointer of the port device, via the power_supply_config structure, to allow other psy drivers to add us as a supplier using the 'power-supplies' DT property. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/usb/typec/

[PATCH] typec: tcpm: Provide of_node pointer as part of psy_cfg

2018-05-16 Thread Adam Thomson
For supply registration, provide of_node pointer of the port device, via the power_supply_config structure, to allow other psy drivers to add us as a supplier using the 'power-supplies' DT property. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 1 + 1 file changed, 1 insertion

RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-16 Thread Adam Thomson
On 07 May 2018 05:50, Agrawal, Akshu wrote: Apologies for the delay in response. Please see comments below. > On 5/4/2018 2:45 PM, Adam Thomson wrote: > > On 03 May 2018 08:59, Akshu Agrawal wrote: > > > >> Non-dts based systems can use ACPI DSDT to pass on

RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-16 Thread Adam Thomson
On 07 May 2018 05:50, Agrawal, Akshu wrote: Apologies for the delay in response. Please see comments below. > On 5/4/2018 2:45 PM, Adam Thomson wrote: > > On 03 May 2018 08:59, Akshu Agrawal wrote: > > > >> Non-dts based systems can use ACPI DSDT to pass on

Re: [PATCH v10 00/27] ARM: davinci: convert to common clock framework​

2018-05-15 Thread Adam Ford
On Tue, May 15, 2018 at 4:25 AM, Bartosz Golaszewski <b...@bgdev.pl> wrote: > 2018-05-14 2:40 GMT+02:00 Adam Ford <aford...@gmail.com>: >> On Wed, May 9, 2018 at 12:25 PM, David Lechner <da...@lechnology.com> wrote: >>> This series converts mach-davin

Re: [PATCH v10 00/27] ARM: davinci: convert to common clock framework​

2018-05-15 Thread Adam Ford
On Tue, May 15, 2018 at 4:25 AM, Bartosz Golaszewski wrote: > 2018-05-14 2:40 GMT+02:00 Adam Ford : >> On Wed, May 9, 2018 at 12:25 PM, David Lechner wrote: >>> This series converts mach-davinci to use the common clock framework. >>> >>> The series works lik

Re: [PATCH v10 00/27] ARM: davinci: convert to common clock framework​

2018-05-13 Thread Adam Ford
fdt blob at 0xc060 Loading Device Tree to c7e57000, end c7e5ef80 ... OK Starting kernel ... Uncompressing Linux... done, booting the kernel. (and hang) If you have some suggestions, I am try them as I get time. adam > > Changes: > > v10 changes (also see individual pa

Re: [PATCH v10 00/27] ARM: davinci: convert to common clock framework​

2018-05-13 Thread Adam Ford
0xc060 Loading Device Tree to c7e57000, end c7e5ef80 ... OK Starting kernel ... Uncompressing Linux... done, booting the kernel. (and hang) If you have some suggestions, I am try them as I get time. adam > > Changes: > > v10 changes (also see individual patches for details): > - Reworke

Re: [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes

2018-05-10 Thread Adam Ford
On Thu, May 10, 2018 at 10:19 AM, Sekhar Nori <nsek...@ti.com> wrote: > On Thursday 10 May 2018 08:38 PM, Adam Ford wrote: >> On Thu, May 10, 2018 at 4:10 AM, Sekhar Nori <nsek...@ti.com> wrote: >>> On Monday 07 May 2018 06:07 PM, Adam Ford wrote: >>>>

Re: [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes

2018-05-10 Thread Adam Ford
On Thu, May 10, 2018 at 10:19 AM, Sekhar Nori wrote: > On Thursday 10 May 2018 08:38 PM, Adam Ford wrote: >> On Thu, May 10, 2018 at 4:10 AM, Sekhar Nori wrote: >>> On Monday 07 May 2018 06:07 PM, Adam Ford wrote: >>>> Many node labels in the device tree (like se

Re: [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes

2018-05-10 Thread Adam Ford
On Thu, May 10, 2018 at 4:10 AM, Sekhar Nori <nsek...@ti.com> wrote: > On Monday 07 May 2018 06:07 PM, Adam Ford wrote: >> Many node labels in the device tree (like serial0, serial1, etc) are being >> redefined, so let's modernize the device tree by using phandles to >>

Re: [PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes

2018-05-10 Thread Adam Ford
On Thu, May 10, 2018 at 4:10 AM, Sekhar Nori wrote: > On Monday 07 May 2018 06:07 PM, Adam Ford wrote: >> Many node labels in the device tree (like serial0, serial1, etc) are being >> redefined, so let's modernize the device tree by using phandles to >> extend the existi

Re: [PATCH v3 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-09 Thread Adam Manzanares
ave other things than just write life time hints. >> >> Since Adam wants to do priorities, he'd either need to pack into the >> existing ki_hint, or do this patch does, which is make it smaller and >> add a new member. I think the latter is cleaner. > > Fair enough;

Re: [PATCH v3 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-09 Thread Adam Manzanares
ave other things than just write life time hints. >> >> Since Adam wants to do priorities, he'd either need to pack into the >> existing ki_hint, or do this patch does, which is make it smaller and >> add a new member. I think the latter is cleaner. > > Fair enough;

[PATCH v3 0/3] AIO add per-command iopriority

2018-05-08 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set syste

[PATCH v3 0/3] AIO add per-command iopriority

2018-05-08 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. See the following link for performance implications on a SATA HDD: https://lkml.org/lkml/2016/12/6/495 First patch factors ioprio_check_cap function out of ioprio_set system call to also be used by the aio

[PATCH v3 3/3] fs: Add aio iopriority support for block_dev

2018-05-08 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for an aio request by the block dev we set the priority value of t

[PATCH v3 3/3] fs: Add aio iopriority support for block_dev

2018-05-08 Thread adam . manzanares
From: Adam Manzanares When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for an aio request by the block dev we set the priority value of the bio to the user supplied value

[PATCH v3 1/3] block: add ioprio_check_cap function

2018-05-08 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to

[PATCH v3 1/3] block: add ioprio_check_cap function

2018-05-08 Thread adam . manzanares
From: Adam Manzanares Aio per command iopriority support introduces a second interface between userland and the kernel capable of passing iopriority. The aio interface also needs the ability to verify that the submitting context has sufficient priviledges to submit IOPRIO_RT commands. This patch

[PATCH v3 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-08 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares <adam.manzana...@wdc.com> --- include/lin

[PATCH v3 2/3] fs: Convert kiocb rw_hint from enum to u16

2018-05-08 Thread adam . manzanares
From: Adam Manzanares In order to avoid kiocb bloat for per command iopriority support, rw_hint is converted from enum to a u16. Added a guard around ki_hint assigment. Signed-off-by: Adam Manzanares --- include/linux/fs.h | 15 +-- 1 file changed, 13 insertions(+), 2 deletions

Re: [PATCH v2] scsi: 3w-xxxx: fix a missing-check bug

2018-05-07 Thread adam radford
ile) > > dprintk(KERN_WARNING "3w-: tw_ioctl_open()\n"); > > + if (!capable(CAP_SYS_ADMIN)) > + return -EACCES; > + > minor_number = iminor(inode); > if (minor_number >= tw_device_extension_count) > return -ENODEV; > -- > 2.7.4 > Acked-by: Adam Radford <aradf...@gmail.com>

Re: [PATCH v2] scsi: 3w-xxxx: fix a missing-check bug

2018-05-07 Thread adam radford
intk(KERN_WARNING "3w-: tw_ioctl_open()\n"); > > + if (!capable(CAP_SYS_ADMIN)) > + return -EACCES; > + > minor_number = iminor(inode); > if (minor_number >= tw_device_extension_count) > return -ENODEV; > -- > 2.7.4 > Acked-by: Adam Radford

Re: [PATCH v2] scsi: 3w-9xxx: fix a missing-check bug

2018-05-07 Thread adam radford
mber; > int retval = TW_IOCTL_ERROR_OS_ENODEV; > > + if (!capable(CAP_SYS_ADMIN)) { > + retval = -EACCES; > + goto out; > + } > + > minor_number = iminor(inode); > if (minor_number >= twa_device_extension_count) > goto out; > -- > 2.7.4 > Acked-by: Adam Radford <aradf...@gmail.com>

Re: [PATCH v2] scsi: 3w-9xxx: fix a missing-check bug

2018-05-07 Thread adam radford
NODEV; > > + if (!capable(CAP_SYS_ADMIN)) { > + retval = -EACCES; > + goto out; > + } > + > minor_number = iminor(inode); > if (minor_number >= twa_device_extension_count) > goto out; > -- > 2.7.4 > Acked-by: Adam Radford

Re: [PATCH] scsi: 3w-xxxx: fix a missing-check bug

2018-05-07 Thread adam radford
tl->data_buffer_length != data_buffer_length) { > + retval = -EINVAL; > + goto out2; > + } > > passthru = (TW_Passthru *)_ioctl->firmware_command; > > -- > 2.7.4 > I would drop this patch and check for !capable(CAP_SYS_ADMIN) in tw_chrdev_open() instead. -Adam

Re: [PATCH] scsi: 3w-xxxx: fix a missing-check bug

2018-05-07 Thread adam radford
h) { > + retval = -EINVAL; > + goto out2; > + } > > passthru = (TW_Passthru *)_ioctl->firmware_command; > > -- > 2.7.4 > I would drop this patch and check for !capable(CAP_SYS_ADMIN) in tw_chrdev_open() instead. -Adam

Re: [PATCH] scsi: 3w-9xxx: fix a missing-check bug

2018-05-07 Thread adam radford
= driver_command.buffer_length) { > + retval = TW_IOCTL_ERROR_OS_EINVAL; > + goto out3; > + } > + > /* See which ioctl we are doing */ > switch (cmd) { > case TW_IOCTL_FIRMWARE_PASS_THROUGH: > -- > 2.7.4 > Drop this patch and create a new one that checks for: if !capable(CAP_SYS_ADMIN) in twa_chrdev_ioctl() (like 3w-sas.c does) and I'll ack it. -Adam

Re: [PATCH] scsi: 3w-9xxx: fix a missing-check bug

2018-05-07 Thread adam radford
= TW_IOCTL_ERROR_OS_EINVAL; > + goto out3; > + } > + > /* See which ioctl we are doing */ > switch (cmd) { > case TW_IOCTL_FIRMWARE_PASS_THROUGH: > -- > 2.7.4 > Drop this patch and create a new one that checks for: if !capable(CAP_SYS_ADMIN) in twa_chrdev_ioctl() (like 3w-sas.c does) and I'll ack it. -Adam

Re: [PATCH] scsi: 3ware: fix a missing-check bug

2018-05-07 Thread adam radford
vent any invalid copy down to kernel mode from happening. 2. twl_chrdev_open() checks for capable(CAP_SYS_ADMIN): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/scsi/3w-sas.c#n834 I don't see the point in this patch. -Adam

Re: [PATCH] scsi: 3ware: fix a missing-check bug

2018-05-07 Thread adam radford
from happening. 2. twl_chrdev_open() checks for capable(CAP_SYS_ADMIN): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/scsi/3w-sas.c#n834 I don't see the point in this patch. -Adam

[PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes

2018-05-07 Thread Adam Ford
Many node labels in the device tree (like serial0, serial1, etc) are being redefined, so let's modernize the device tree by using phandles to extend the existing nodes. This helps reduce the whitespace. Signed-off-by: Adam Ford <aford...@gmail.com> --- V3: Rebase against 4.18/dt and fix s

[PATCH V3] ARM: dts: da850-evm: use phandles to extend nodes

2018-05-07 Thread Adam Ford
Many node labels in the device tree (like serial0, serial1, etc) are being redefined, so let's modernize the device tree by using phandles to extend the existing nodes. This helps reduce the whitespace. Signed-off-by: Adam Ford --- V3: Rebase against 4.18/dt and fix subject. V2: Rename

RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-04 Thread Adam Thomson
On 03 May 2018 08:59, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling of

RE: [PATCH v3] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-04 Thread Adam Thomson
On 03 May 2018 08:59, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling of

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 1:24 PM, Jens Axboe wrote: > On 5/3/18 2:15 PM, Adam Manzanares wrote: >> >> >> On 5/3/18 11:33 AM, Matthew Wilcox wrote: >>> On Thu, May 03, 2018 at 11:21:14AM -0700, adam.manzana...@wdc.com wrote: >>>> If we want to avoid bloating s

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 1:24 PM, Jens Axboe wrote: > On 5/3/18 2:15 PM, Adam Manzanares wrote: >> >> >> On 5/3/18 11:33 AM, Matthew Wilcox wrote: >>> On Thu, May 03, 2018 at 11:21:14AM -0700, adam.manzana...@wdc.com wrote: >>>> If we want to avoid bloating s

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 11:36 AM, Jeff Moyer wrote: > Hi, Adam, Hello Jeff, > > adam.manzana...@wdc.com writes: > >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IO

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 11:36 AM, Jeff Moyer wrote: > Hi, Adam, Hello Jeff, > > adam.manzana...@wdc.com writes: > >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When IOCB_FLAG_IOPRIO is set on the iocb aio_f

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 11:33 AM, Matthew Wilcox wrote: > On Thu, May 03, 2018 at 11:21:14AM -0700, adam.manzana...@wdc.com wrote: >> If we want to avoid bloating struct kiocb, I suggest we turn the private >> field >> into a union of the private and ki_ioprio field. It seems like the users of >> the private

Re: [PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread Adam Manzanares
On 5/3/18 11:33 AM, Matthew Wilcox wrote: > On Thu, May 03, 2018 at 11:21:14AM -0700, adam.manzana...@wdc.com wrote: >> If we want to avoid bloating struct kiocb, I suggest we turn the private >> field >> into a union of the private and ki_ioprio field. It seems like the users of >> the private

[PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for

[PATCH v2] fs: Add aio iopriority support for block_dev

2018-05-03 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When IOCB_FLAG_IOPRIO is set on the iocb aio_flags field, then we set the newly added kiocb ki_ioprio field to the value in the iocb aio_reqprio field. When a bio is created for an aio request by the block dev

RE: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-03 Thread Adam Thomson
On 03 May 2018 02:39, Mark Brown wrote: > On Wed, May 02, 2018 at 10:13:55AM +0000, Adam Thomson wrote: > > On 01 May 2018 21:50, Mark Brown wrote: > > > > There's a lot of things that ACPI *should* do but doesn't - it's a bit > > > of a shambles how ACPI st

RE: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-03 Thread Adam Thomson
On 03 May 2018 02:39, Mark Brown wrote: > On Wed, May 02, 2018 at 10:13:55AM +0000, Adam Thomson wrote: > > On 01 May 2018 21:50, Mark Brown wrote: > > > > There's a lot of things that ACPI *should* do but doesn't - it's a bit > > > of a shambles how ACPI st

Re: [PATCH 2/2] fs: Add aio priority support for block_dev

2018-05-02 Thread Adam Manzanares
only other thing I am a bit worried about is bloating struct kiocb > with a field for a relatively uncommon feature, but I can't really > see any much better way to pass it. > I'll look more closely at reusing existing fields for the next patch submission. I am hoping that the feature will be used more often given that WRR for NVME should be coming soon. Thanks, Adam

Re: [PATCH 2/2] fs: Add aio priority support for block_dev

2018-05-02 Thread Adam Manzanares
only other thing I am a bit worried about is bloating struct kiocb > with a field for a relatively uncommon feature, but I can't really > see any much better way to pass it. > I'll look more closely at reusing existing fields for the next patch submission. I am hoping that the feature will be used more often given that WRR for NVME should be coming soon. Thanks, Adam

Re: [PATCH 1/2] fs: add RWF_IOPRIO

2018-05-02 Thread Adam Manzanares
On 5/2/18 10:32 AM, Christoph Hellwig wrote: > On Mon, Apr 30, 2018 at 09:57:39AM -0700, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares <adam.manzana...@wdc.com> >> >> This is the per-I/O equivalent of the ioprio_set system call. >> &

Re: [PATCH 1/2] fs: add RWF_IOPRIO

2018-05-02 Thread Adam Manzanares
On 5/2/18 10:32 AM, Christoph Hellwig wrote: > On Mon, Apr 30, 2018 at 09:57:39AM -0700, adam.manzana...@wdc.com wrote: >> From: Adam Manzanares >> >> This is the per-I/O equivalent of the ioprio_set system call. >> >> When the RWF_IOPRIO flag is set then

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-02 Thread Adam Thomson
On 01 May 2018 21:50, Mark Brown wrote: > On Mon, Apr 30, 2018 at 07:05:19PM +0000, Adam Thomson wrote: > > > There is already a means via DT to specify the MCLK for a device using the > > generic clock DT bindings, and this driver already uses that. Should ACPI > >

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-02 Thread Adam Thomson
On 01 May 2018 21:50, Mark Brown wrote: > On Mon, Apr 30, 2018 at 07:05:19PM +0000, Adam Thomson wrote: > > > There is already a means via DT to specify the MCLK for a device using the > > generic clock DT bindings, and this driver already uses that. Should ACPI > >

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Adam Thomson
On 30 April 2018 10:23, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Adam Thomson
On 30 April 2018 10:23, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling

[PATCH 0/2] AIO add per-command iopriority

2018-04-30 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This patchset interprets the aio_reqprio field of an iocb as a per-command value iff the RWF_IOPRIO flag is set on the iocb. This feature is implemented for a block device, but could also be leveraged by any consumers of the iocb

[PATCH 1/2] fs: add RWF_IOPRIO

2018-04-30 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> This is the per-I/O equivalent of the ioprio_set system call. When the RWF_IOPRIO flag is set then the aio_reqprio field of the iocb is interpreted as an I/O scheduling class and priority. Signed-off-by: Adam Manzanares <adam.manzana..

[PATCH 0/2] AIO add per-command iopriority

2018-04-30 Thread adam . manzanares
From: Adam Manzanares This patchset interprets the aio_reqprio field of an iocb as a per-command value iff the RWF_IOPRIO flag is set on the iocb. This feature is implemented for a block device, but could also be leveraged by any consumers of the iocb. See the following link for performance

[PATCH 1/2] fs: add RWF_IOPRIO

2018-04-30 Thread adam . manzanares
From: Adam Manzanares This is the per-I/O equivalent of the ioprio_set system call. When the RWF_IOPRIO flag is set then the aio_reqprio field of the iocb is interpreted as an I/O scheduling class and priority. Signed-off-by: Adam Manzanares --- include/linux/fs.h | 4 include/uapi

[PATCH 2/2] fs: Add aio priority support for block_dev

2018-04-30 Thread adam . manzanares
From: Adam Manzanares <adam.manzana...@wdc.com> When the IOCB_IOPRIO flag is set because the user supplied iocb has the RWF_IOPRIO flag is set then we set the priority value of the kiocb from the iocb. When a bio is created for an aio request by the block dev we set the priority value of t

[PATCH 2/2] fs: Add aio priority support for block_dev

2018-04-30 Thread adam . manzanares
From: Adam Manzanares When the IOCB_IOPRIO flag is set because the user supplied iocb has the RWF_IOPRIO flag is set then we set the priority value of the kiocb from the iocb. When a bio is created for an aio request by the block dev we set the priority value of the bio to the user supplied

RE: [PATCH] typec: tcpm: Fix incorrect 'and' operator

2018-04-30 Thread Adam Thomson
typec: tcpm: Add support for sink PPS related > messages") > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> > --- Good spot. :( Acked-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> > drivers/usb/typec/tcpm.c | 2 +- > 1 file changed, 1 inserti

RE: [PATCH] typec: tcpm: Fix incorrect 'and' operator

2018-04-30 Thread Adam Thomson
typec: tcpm: Add support for sink PPS related > messages") > Signed-off-by: Gustavo A. R. Silva > --- Good spot. :( Acked-by: Adam Thomson > drivers/usb/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm.c

RE: [PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-25 Thread Adam Thomson
On 25 April 2018 13:31, Greg Kroah-Hartman wrote: > On Wed, Apr 25, 2018 at 01:26:33AM +0200, Sebastian Reichel wrote: > > Hi Greg, > > > > On Tue, Apr 24, 2018 at 03:57:49PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 23, 2018 at 03:10:55PM +0100, Adam Tho

RE: [PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-25 Thread Adam Thomson
On 25 April 2018 13:31, Greg Kroah-Hartman wrote: > On Wed, Apr 25, 2018 at 01:26:33AM +0200, Sebastian Reichel wrote: > > Hi Greg, > > > > On Tue, Apr 24, 2018 at 03:57:49PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 23, 2018 at 03:10:55PM +0100, Adam Tho

On Tue, Apr 24, 2018 at 11:08:34AM +0200, Paul Menzel wrote:

2018-04-24 Thread Adam Borowski
0886e965e7aeae8d3729c4bacf614a19e103cea Mon Sep 17 00:00:00 2001 From: Adam Borowski <kilob...@angband.pl> Date: Wed, 25 Apr 2018 02:29:18 +0200 Subject: [PATCH] scripts: teach extract-vmlinux about LZ4 and ZSTD Note that the LZ4 signature is different than that of modern LZ4 as we us

On Tue, Apr 24, 2018 at 11:08:34AM +0200, Paul Menzel wrote:

2018-04-24 Thread Adam Borowski
0886e965e7aeae8d3729c4bacf614a19e103cea Mon Sep 17 00:00:00 2001 From: Adam Borowski Date: Wed, 25 Apr 2018 02:29:18 +0200 Subject: [PATCH] scripts: teach extract-vmlinux about LZ4 and ZSTD Note that the LZ4 signature is different than that of modern LZ4 as we use the "legacy" format

Re: How to disable Linux kernel self-extraction (KERNEL_GZIP, KERNEL_BZIP2, …)?

2018-04-24 Thread Adam Borowski
On Tue, Apr 24, 2018 at 11:08:34AM +0200, Paul Menzel wrote: > On 04/24/18 04:08, Adam Borowski wrote: > > On Mon, Apr 23, 2018 at 07:02:30PM +0200, Pavel Machek wrote: > > > > > > > I try to decrease boot time, and my system has an SSD and enough > > > >

Re: How to disable Linux kernel self-extraction (KERNEL_GZIP, KERNEL_BZIP2, …)?

2018-04-24 Thread Adam Borowski
On Tue, Apr 24, 2018 at 11:08:34AM +0200, Paul Menzel wrote: > On 04/24/18 04:08, Adam Borowski wrote: > > On Mon, Apr 23, 2018 at 07:02:30PM +0200, Pavel Machek wrote: > > > > > > > I try to decrease boot time, and my system has an SSD and enough > > > >

Re: How to disable Linux kernel self-extraction (KERNEL_GZIP, KERNEL_BZIP2, …)?

2018-04-23 Thread Adam Borowski
On Mon, Apr 23, 2018 at 07:02:30PM +0200, Pavel Machek wrote: > > > >>I try to decrease boot time, and my system has an SSD and enough space, > > > >>so > > > >>loading 18 instead of 12 MB doesn’t make a difference, but the > > > >>self-extraction is noticeable. So, I like to disable it. > > > >

Re: How to disable Linux kernel self-extraction (KERNEL_GZIP, KERNEL_BZIP2, …)?

2018-04-23 Thread Adam Borowski
On Mon, Apr 23, 2018 at 07:02:30PM +0200, Pavel Machek wrote: > > > >>I try to decrease boot time, and my system has an SSD and enough space, > > > >>so > > > >>loading 18 instead of 12 MB doesn’t make a difference, but the > > > >>self-extraction is noticeable. So, I like to disable it. > > > >

[PATCH v8 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Acked-by:

[PATCH v8 1/6] typec: tcpm: Add core support for sink side PPS

2018-04-23 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson Acked-by: Heikki Krogerus Reviewed-by: Guenter Roeck

[PATCH v8 3/6] power: supply: Add error checking of psy desc during registration

2018-04-23 Thread Adam Thomson
the registration code to add some basic checks on the desc pointer validity, name, and presence of properties. Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> --- drivers/power/supply/power_supply_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/

[PATCH v8 3/6] power: supply: Add error checking of psy desc during registration

2018-04-23 Thread Adam Thomson
the registration code to add some basic checks on the desc pointer validity, name, and presence of properties. Signed-off-by: Adam Thomson --- drivers/power/supply/power_supply_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power

[PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-23 Thread Adam Thomson
t multiple connected types (e.g. USB), as discussed with Heikki. Changes in v2: - Use USB_PD and usb_pd prefixes for macros and inline functions in headers. - Negotiate spec revision of PD headers during initial contract agreement. - New headers now use SPDX tags for referencing correct lice

[PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-23 Thread Adam Thomson
t multiple connected types (e.g. USB), as discussed with Heikki. Changes in v2: - Use USB_PD and usb_pd prefixes for macros and inline functions in headers. - Negotiate spec revision of PD headers during initial contract agreement. - New headers now use SPDX tags for referencing correct lice

[PATCH v8 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-04-23 Thread Adam Thomson
This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v8 2/6] Documentation: power: Initial effort to document power_supply ABI

2018-04-23 Thread Adam Thomson
This commit adds generic ABI information regarding power_supply properties. This is an initial attempt to try and align the usage of these properties between drivers. As part of this commit, common Battery and USB related properties have been listed. Signed-off-by: Adam Thomson

[PATCH v8 5/6] typec: tcpm: Represent source supply through power_supply

2018-04-23 Thread Adam Thomson
' Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 + drivers/usb/

[PATCH v8 5/6] typec: tcpm: Represent source supply through power_supply

2018-04-23 Thread Adam Thomson
' Signed-off-by: Adam Thomson Reviewed-by: Guenter Roeck --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 + drivers/usb/typec/tcpm.c| 251 +++- 4 files

<    5   6   7   8   9   10   11   12   13   14   >