On 15/4/21 12:55 am, Aditya Srivastava wrote:
> Currently kernel-doc does not identify some cases of probable kernel
> doc comments, for e.g. pointer used as declaration type for identifier,
> space separated identifier, etc.
>
> Some example of these cases in files can be:
>
write
kernel-doc comment.
Suggested-by: Jonathan Corbet
Link: https://lore.kernel.org/lkml/87mtujktl2@meer.lwn.net
Signed-off-by: Aditya Srivastava
---
scripts/kernel-doc | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/scripts/kernel-doc b/scripts/ker
Endpoint ConfigFS header file().
Prototype was for __LINUX_PCI_EP_CFS_H() instead"
Similarly for other files too.
Provide a simple fix by replacing such occurrences with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivast
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 0d6c8e1e246586b81cb4e6ab1a93a6d4a08a0cf9
Gitweb:
https://git.kernel.org/tip/0d6c8e1e246586b81cb4e6ab1a93a6d4a08a0cf9
Author:Aditya Srivastava
AuthorDate:Wed, 31 Mar 2021 03:00:22 +05:30
On 1/4/21 1:02 am, Jonathan Corbet wrote:
> Aditya Srivastava writes:
>
>> On 29/3/21 7:26 pm, Jonathan Corbet wrote:
>>> Aditya Srivastava writes:
>>>
>>>> Currently, kernel-doc start parsing the comment as a kernel-doc comment if
>>>> it st
ent
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210326
arch/x86/platform/intel-quark/imr.c | 2 +-
arch/x86/platform/intel-quark/imr_selftest.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
2016(). Prototype was for _X86_ENCL_H()
instead"
Similarly for arch/x86/kernel/cpu/sgx/arch.h too.
Provide a simple fix by replacing these occurrences with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perf
comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210326
arch/arm/mach-omap2/omap_twl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/
comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210326
arch/arm/mach-omap1/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap1/timer.c b/arch/arm/mach-omap1/
Prototype was for DEFINE_SPINLOCK()
instead"
Provide a simple fix by replacing this occurrence with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210326
arch/arm/mach-sa1100/jornad
On 29/3/21 7:26 pm, Jonathan Corbet wrote:
> Aditya Srivastava writes:
>
>> Currently, kernel-doc start parsing the comment as a kernel-doc comment if
>> it starts with '/**', but does not take into account if the content inside
>> the comment too, adheres
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210326
drivers/usb/dwc3/dwc3-imx8mp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-i
comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210326
drivers/usb/dwc3/dwc3-exynos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/u
or h(). Prototype was for
__DRIVERS_USB_DWC3_IO_H() instead"
Similarly for other files too.
Provide a simple fix by replacing such occurrences with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-2021032
e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210326
drivers/usb/dwc3/dwc3-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index b06b709
ion prototype: 'const U32 g_searchStrength =
8; '"
Similarly for other files too.
Provide a simple fix by replacing such occurrences with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20
g this occurrence with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
drivers/crypto/chelsio/chcr_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/chelsio/chcr_core.c
b/drivers/crypt
e next lines, and as a result causing
this warning.
Provide a clearer warning message to the users regarding the same, if the
content inside the comment does not follow the kernel-doc expected format.
Signed-off-by: Aditya Srivastava
---
scripts/kernel-doc | 17 +
1 file changed,
le fix by replacing such occurrences with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Also fix enum documentation format at "ntfs_compression_constants", in
fs/ntfs/compress.c, by prefixing 'enum' keyword to the comment
description.
Signed-off-b
ent
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210319
drivers/crypto/nx/nx-aes-cbc.c | 2 +-
drivers/crypto/nx/nx-aes-ccm.c | 2 +-
drivers/crypto/nx/nx-aes-ctr.c | 2 +-
drivers/crypto/nx/nx-aes-ecb.c |
otype for ST(). Prototype was for _CRYP_H_() instead"
Similarly for other files too.
Provide a simple fix by replacing such occurrences with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
drivers/crypto/ux500/cryp/c
es with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
drivers/crypto/amcc/crypto4xx_alg.c | 12 ++--
drivers/crypto/amcc/crypto4xx_core.c| 18 +-
drivers/crypto/amcc/crypto4xx_core.h|
r Routines supporting VMX instructions on the
Power 8(). Prototype was for p8_init() instead"
Similarly for other files too.
Provide a simple fix by replacing such occurrences with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Sri
p_runlist_nolock'"
"warning: Function parameter or member 'ctx' not described in
'ntfs_map_runlist_nolock'"
"warning: expecting prototype for c(). Prototype was for
ntfs_map_runlist_nolock() instead"
Similarly for other files too.
Provide a simple fix b
On 20/3/21 6:51 pm, Lukas Bulwahn wrote:
> On Sat, Mar 20, 2021 at 1:45 PM Aditya Srivastava
> wrote:
>>
>> On 20/3/21 12:23 pm, Aditya wrote:
>>> On 18/3/21 11:48 pm, Jonathan Corbet wrote:
>>>> Lukas Bulwahn writes:
>>>>
>>>&g
On 20/3/21 12:23 pm, Aditya wrote:
> On 18/3/21 11:48 pm, Jonathan Corbet wrote:
>> Lukas Bulwahn writes:
>>
>>> Yeah, and as this line-counting is really just a poor man's
>>> heuristics, we might just be better to really turn this heuristics
>>> into a dedicated cleanup warning script, then we c
ptfs_d_revalidate() instead"
Similarly for other files too.
Provide a simple fix by replacing such occurrences with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210312
fs/ecryptfs/crypto
nning scripts/kernel-doc -none on block/partitions/ldm.h
causes this warning:
"warning: expecting prototype for ldm(). Prototype was for _FS_PT_LDM_H_()
instead"
Provide a simple fix by replacing such occurrences with general comment
format, i.e., "/*", to prevent kernel-doc
ent syntax with
general format, i.e. "/*", to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
sound/pci/ctxfi/ct20k1reg.h | 2 +-
sound/pci/ctxfi/ct20k2reg.h | 2 +-
sound/pci/ctxfi/ctamixer.c | 2 +-
sound/pci/ctxfi/ctamixer.h | 2 +-
sound/pci/ctxfi/ctat
g scripts/kernel-doc -none on sound/pci/asihpi/hpidspcd.h
causes this warning:
"warning: Cannot understand
on line 4 - I thought it was a doc line"
Provide a simple fix by replacing the kernel-doc like comment syntax with
general format, i.e. "/*", to prevent kernel-doc
comment
format, i.e., "/*", to prevent kernel-doc from parsing it.
Signed-off-by: Aditya Srivastava
---
- Applies perfectly on next-20210312
Changes in v2:
- Convert the patch series to a single patch as suggested by Lukas and Kalle
drivers/net/wireless/rsi/rsi_boot_params.h | 2
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: Cannot understand * @section LICENSE
on line 2 - I thought it was a doc line"
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: Cannot understand * @section LICENSE
on line 2 - I thought it was a doc line"
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: wrong kernel-doc identifier on line:
* Copyright (c) 2014 Redpine Signals Inc."
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: wrong kernel-doc identifier on line:
* Copyright (c) 2014 Redpine Signals Inc."
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: wrong kernel-doc identifier on line:
* Copyright (c) 2017 Redpine Signals Inc."
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: wrong kernel-doc identifier on line:
* Copyright (c) 2014 Redpine Signals Inc."
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: wrong kernel-doc identifier on line:
* Copyright (c) 2014 Redpine Signals Inc."
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: wrong kernel-doc identifier on line:
* Copyright (c) 2017 Redpine Signals Inc."
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
specifications (i.e.,
function, struct, etc).
This causes unwelcomed warning from kernel-doc:
"warning: wrong kernel-doc identifier on line:
* Copyright (c) 2018 Redpine Signals Inc."
Replace this comment syntax with general comment format, i.e. '/*' to
prevent kernel-doc
el-doc from parsing these
Signed-off-by: Aditya Srivastava
---
drivers/net/wireless/rsi/rsi_boot_params.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rsi/rsi_boot_params.h
b/drivers/net/wireless/rsi/rsi_boot_params.h
index c1cf19d1e376..30e03aa6a5
yntax with
general format, i.e. "/*", to prevent kernel-doc from parsing it.
* The patch series applies perfectly on next-20210312
Aditya Srivastava (10):
rsi: rsi_boot_params: fix file header comment syntax
rsi: rsi_coex: fix file header comment syntax
rsi: rsi_ps: fix file header co
). Prototype was for __FSL_GUTS_H__() instead"
Replace all such comment occurrences with general comment format,
i.e. '/*' to pervent kernel-doc from parsing these.
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210312
include/linux/fsl/guts.h | 4 ++--
1 file chan
results in ineffective warnings by
kernel-doc, related to these.
Provide a simple fix by skipping first three lines in a file for checking
kernel-doc comments.
Suggested-by: Lukas Bulwahn
Signed-off-by: Aditya Srivastava
---
scripts/kernel-doc | 6 +-
1 file changed, 5 insertions(+), 1 deletion
rt for "__attribute_const__" and "__flatten" attributes.
A quick evaluation by running 'kernel-doc -none' on kernel-tree reveals
that no additional warning or error has been added or removed by the fix.
Suggested-by: Lukas Bulwahn
Signed-off-by: Aditya Srivastava
---
unning 'kernel-doc -none' on kernel-tree reveals
that no additional warning or error has been added or removed by the fix.
Suggested-by: Lukas Bulwahn
Signed-off-by: Aditya Srivastava
---
scripts/kernel-doc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/
ruct/union syntax and a preceding kernel-doc; all other
occurrences have no preceding kernel-doc.
Add support for parsing struct/union following this syntax.
Signed-off-by: Aditya Srivastava
---
Changes in v3:
- Modify commit message
Changes in v2:
- Split recurring regex into multiple variable
nux/zstd.h emits:
"error: Cannot parse struct or union!"
Add support for parsing struct/union following this syntax.
Signed-off-by: Aditya Srivastava
---
Changes in v2:
- Split recurring regex into multiple variables
- Modify commit message
scripts/kernel-doc | 17 ++---
td.h emits:
"error: Cannot parse struct or union!"
Add support for parsing it.
Signed-off-by: Aditya Srivastava
---
scripts/kernel-doc | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/scripts/kernel-doc b/scripts/kernel-doc
index 8b5bc7bf4bb8..46e90
y adding square brackets in the regex, responsible
for capturing $param.
A quick evaluation, by running 'kernel-doc -none' on entire kernel-tree,
reveals that no additional warning or error has been added or removed by
the fix.
Suggested-by: Lukas Bulwahn
Signed-off-by: Aditya Sriv
/20210112210154.gi4...@sirena.org.uk
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210122
Changes in v3:
- Modify regex for SYM_*_START/END pair
- remove check for arch/x86/entry/* and arch/x86/lib/*
- change 'Link:' in commit message to lkml
- Modify commit description
own
Link: https://groups.google.com/g/clang-built-linux/c/-drkmLgu-cU/m/4staOlf-CgAJ
Signed-off-by: Aditya Srivastava
---
* Applies perfectly on next-20210122
Changes in v2:
- Reduce the check to only SYM_*_START/END lines
- Reduce the check for only .S files in arch/x86/entry/* and arch/x86/li
new check to emit a warning on finding the usage of '.L' symbols
in '.S' files, if it lies within SYM_*_START/END annotation pair.
Suggested-by: Mark Brown
Link: https://lore.kernel.org/lkml/20210112210154.gi4...@sirena.org.uk/
Signed-off-by: Aditya Srivastava
---
scripts
19-January/144761.html
Avoid giving users warning for character limit for such cases, instead
suggest them to prefix the URLs with "Link:"
Signed-off-by: Aditya Srivastava
---
scripts/checkpatch.pl | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/scripts/che
19-January/144761.html
Provide a simple fix option by prefixing the first non-whitespace
character of the line with "Link:"
Signed-off-by: Aditya Srivastava
---
scripts/checkpatch.pl | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts
regex with /^\s*[a-z][\w\.\+\-]*:\/\/\S+/i (earlier:
/^\s*\b[a-z][\w\.\+\-]*:\/\/\S+/i)
Aditya Srivastava (2):
checkpatch: fix false positive for COMMIT_LOG_LONG_LINE with URLs
checkpatch: add fix option for COMMIT_LOG_LONG_LINE with URLs
scripts/checkpatch.pl | 14 +++---
1 file ch
condition, rather than comparing with true/false
E.g., in drivers/net/wireless/realtek/rtlwifi/ps.c,
"if (find_p2p_ie == true)" can be replaced with "if (find_p2p_ie)"
Replace all such expressions with the bool variables appropriately
Signed-off-by: Aditya Srivastava
---
propriately
Signed-off-by: Aditya Srivastava
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 372d6f8
(mac->act_scanning)"
Fix all such expressions with the bool variables appropriately for all
the drivers in rtlwifi
* The changes made are compile tested.
* The patches apply perfectly on next-20210108
Aditya Srivastava (5):
rtlwifi: rtl_pci: fix bool comparison in expressions
rtlwifi:
condition, rather than comparing with true/false
E.g., in drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c,
"if (mac->act_scanning == true)" can be replaced with
"if (mac->act_scanning)"
Replace all such expressions with the bool variables appropriately
Signed
condition, rather than comparing with true/false
Replace all such expressions with the bool variables appropriately
Signed-off-by: Aditya Srivastava
---
drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless
the condition, rather than comparing with true/false
E.g., in drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c,
"else if (initialized == false) {" can be replaced with
"else if (!initialized) {"
Replace all such expressions with the bool variables appropriately
S
condition, rather than comparing with true/false
E.g., in drivers/net/wireless/realtek/rtlwifi/ps.c,
"if (find_p2p_ie == true)" can be replaced with "if (find_p2p_ie)"
Replace all such expressions with the bool variables appropriately
Signed-off-by: Aditya Srivastava
---
-
condition, rather than comparing with true/false
E.g. in drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c,
"if (Type == true)" can be replaced with: "if (Type)"
Replace all such expressions with the bool variables appropriately
Signed-off-by: Aditya Srivastava
---
- the chan
st them to prefix the URLs with "Link:"
Signed-off-by: Aditya Srivastava
---
changes in v2:
- Fix coding style ('} else {')
- Make the URL check follow RFC 3986 style
- Give warning only if the URL is first non-whitespace of the line
- Set $commit_log_long_line only for else cas
prefix the URLs with "Link:"
Signed-off-by: Aditya Srivastava
---
scripts/checkpatch.pl | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index abd5a3d2e913..23da1f50fe6a 100755
--- a/scripts/checkpatch.pl
+++ b/s
condition, rather than comparing with true/false
E.g. in drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c,
"if (Type == true)" can be replaced with: "if (Type)"
Replace all such expressions with the bool variables appropriately
Signed-off-by: Aditya Srivastava
---
- the chan
e standard signature equivalent for 'Co-authored-by' is
'Co-developed-by'.
Provide a fix by suggesting users with this signature alternative and
replacing.
Signed-off-by: Aditya Srivastava
---
applies perfectly on the latest next-20201204 branch
changes in v2: replace comm
e standard signature equivalent for 'Co-authored-by' is
'Co-developed-by'.
Provide a fix by suggesting users with this signature alternative and
replacing.
Signed-off-by: Aditya Srivastava
---
scripts/checkpatch.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/s
signature equivalent for 'Co-authored-by' is
'Co-developed-by'.
Provide a fix by suggesting users with this signature alternative and
replacing.
Signed-off-by: Aditya Srivastava
---
scripts/checkpatch.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/checkpa
=> Suggested-by
Provide a fix by replacing the non-standard signature with its standard
equivalent.
Also, improve warning messages correspondingly, providing suitable
rationale to the user for the suggestion made.
Signed-off-by: Aditya Srivastava
---
applies on next
e get missing sign off as well as bad sign off warnings for:
Siganed-off-by: Tony Lindgren
Here it is probably best to fix the typo with BAD_SIGN_OFF warning and
avoid adding an additional signoff.
Suggested-by: Joe Perches
Signed-off-by: Aditya Srivastava
---
applies over next-20201120
indgren
Here it is probably best to fix the typo with BAD_SIGN_OFF warning and
avoid adding an additional signoff.
Suggested-by: Joe Perches
Signed-off-by: Aditya Srivastava
---
applies over next-20201120 and my last changes
at:https://lore.kernel.org/linux-kernel-mentees/db1195235752685fc85fb52
to be a bad correction:
Tweeted-by (count: 1) => Tested-by
Signed-off-by: Aditya Srivastava
---
applies on next-20201120
changes in v2: modify commit message: replace specific example with overall
evaluation, minor changes
changes in v3: summarize commit message
changes in v4: improve com
to be a bad correction:
Tweeted-by (count: 1) => Tested-by
Signed-off-by: Aditya Srivastava
---
applies on next-20201120
changes in v2: modify commit message: replace specific example with overall
evaluation, minor changes
changes in v3: summarize commit message
changes in v4: improve com
to be a bad correction:
Tweeted-by (count: 1) => Tested-by
Signed-off-by: Aditya Srivastava
---
changes in v2: modify commit message: replace specific example with overall
evaluation, minor changes
changes in v3: summarize commit message
changes in v4: improve commit message; remove signat
improve warning messages correspondingly, providing users
suggestions to either replace or remove the signature. Also provide
suitable rationale to the user for the suggestion made.
Signed-off-by: Aditya Srivastava
---
changes in v2: replace commit specific example with brief evaluation
cha
improve warning messages correspondingly, providing users
suggestions to either replace or remove the signature. Also provide
suitable rationale to the user for the suggestion made.
Signed-off-by: Aditya Srivastava
---
changes in v2: replace commit specific example with brief evaluation
cha
ons should be on the
previous line
+ if (!ret
+ && camera_port ==
Provide a simple fix by inserting logical operator at the last
non-comment, non-whitespace char of the previous line and removing from
current line, if both the lines are additions(ie start with '+&#
ons should be on the
previous line
+ if (!ret
+ && camera_port ==
Provide a simple fix by inserting logical operator at the last
non-comment, non-whitespace char of the previous line and removing from
current line, if both the lines are additions(ie start with '+&#
ons should be on the
previous line
+ if (!ret
+ && camera_port ==
Provide a simple fix by adding logical operator at the end of previous
line and removing from current line, if both the lines are additions
(ie start with '+')
Signed-off-by: Aditya Srivasta
ons should be on the
previous line
+ if (!ret
+ && camera_port ==
Provide a simple fix by adding logical operator at the end of previous
line and removing from current line, if both the lines are additions
(ie start with '+')
Signed-off-by: Aditya Srivasta
ons should be on the
previous line
+ if (!ret
+ && camera_port ==
Provide a simple fix by adding logical operator at the end of previous
line and removing from current line, if both the lines are additions
(ie start with '+')
Signed-off-by: Aditya Srivasta
ons should be on the
previous line
+ if (!ret
+ && camera_port ==
Provide a simple fix by adding logical operator at the end of previous
line and removing from current line, if both the lines are additions
(ie start with '+')
Signed-off-by: Aditya Srivasta
on the previous line
+ struct netvsc_device *nvdev
+ = container_of(w, struct netvsc_device, subchan_work);
Provide a simple fix by appending assignment operator to the previous
line and removing from the current line, if both the lines are additions
(ie start with '+')
Si
on the previous line
+ struct netvsc_device *nvdev
+ = container_of(w, struct netvsc_device, subchan_work);
Provide a simple fix by appending assignment operator to the previous
line and removing from the current line, if both the lines are additions
(ie start with '+')
Si
on the previous line
+ struct netvsc_device *nvdev
+ = container_of(w, struct netvsc_device, subchan_work);
Provide a simple fix by appending assignment operator to the previous
line and removing from the current line, if both the lines are additions
(ie start with '+')
Si
list file patterns in
alphabetic order
+F: include/uapi/linux/nexthop.h
+F: include/net/netns/nexthop.h
Provide a simple fix by swapping the unordered lines, if both the lines
are additions (start with '+')
Signed-off-by: Aditya Srivastava
---
Changes in v2:
modified commit message
he dropped warnings related to signature
tags.
Signed-off-by: Aditya Srivastava
---
Changes in v2:
modify commit message: remove specific commit example, add cause of the warning
instead
Changes in v3:
modify commit message: minor english fix; remove difference count, add relative
counts instead
try - list 'Q:' before 'T:'
T: git
git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git
+Q: https://patchwork.ozlabs.org/project/linux-pwm/list/
Provide a simple fix by swapping the unordered lines
Signed-off-by: Aditya Srivastava
---
Changes
sign off for:
Siganed-off-by: Tony Lindgren
Here it is probably best to give BAD_SIGN_OFF warning for Non-standard
signature and avoid MISSING_SIGN_OFF
Suggested-by: Joe Perches
Signed-off-by: Aditya Srivastava
---
Changes in v2:
Add space after 'if'
Add check for $patch_separat
sign off for:
Siganed-off-by: Tony Lindgren
Here it is probably best to give BAD_SIGN_OFF warning for Non-standard
signature and avoid MISSING_SIGN_OFF
Suggested-by: Joe Perches
Signed-off-by: Aditya Srivastava
---
scripts/checkpatch.pl | 18 +++---
1 file changed, 15 insertions(
documentation regarding the same to document the community
consensus and let readers know.
Signed-off-by: Aditya Srivastava
---
Documentation/process/submitting-patches.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/process/submitting-patches.rst
b/Documentation/process
documentation regarding the same to document the community
consensus and let readers know.
Signed-off-by: Aditya Srivastava
---
Documentation/process/submitting-patches.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/process/submitting-patches.rst
b/Documentation/process
documentation regarding the same to document the community
consensus and let readers know.
Signed-off-by: Aditya Srivastava
---
Documentation/process/submitting-patches.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/process/submitting-patches.rst
b/Documentation/process
7;Tim Chen '
Co-developed-by: Tim Chen
Provide a simple fix by removing the co-developed-by line from the
commit message
A quick evaluation on v4.13..v5.8 showed that this fix was getting
triggered 6 times.
A quick manual check found out that all fixes were correct in those
cases.
Signed-off-b
d's before submitting upstream
Change-Id: I5725e46394f3f53c3069723fd513cc53c7df383d
Provide a simple fix option by simply deleting the indicated line.
Signed-off-by: Aditya Srivastava
---
scripts/checkpatch.pl | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/
t or
list command outputs in commit messages.
Signed-off-by: Aditya Srivastava
---
scripts/checkpatch.pl | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 7e505688257a..519da711cb12 100755
--- a/scripts/checkp
sists of hex symbols and skip this warning if it is not among the
common english words formed using hex letters.
A quick evaluation on v5.6..v5.8 showed that this fix reduces
REPEATED_WORD warnings from 2797 to 907.
A quick manual check found all cases are related to hex output or
list com
sists of hex symbols and skip this warning if it is not among the
common english words formed using hex letters.
A quick evaluation on v5.6..v5.8 showed that this fix reduces
REPEATED_WORD warnings from 2797 to 907.
A quick manual check found all cases are related to hex output or
list com
1 - 100 of 103 matches
Mail list logo
