On Sun, Jul 12, 2020 at 12:39:44PM -0700, Josh Triplett wrote:
>...
> Rust has hard stability guarantees when upgrading from one stable
> version to the next. If code compiles with a given stable version of
> Rust, it'll compile with a newer stable version of Rust.
>...
In librsvg, breakages with
On Thu, Jul 16, 2020 at 03:06:01PM +0200, Arnd Bergmann wrote:
>
> I would expect we'd want a fairly tight coupling between kernel
> releases and minimum rust releases at first. Whatever is the latest
> stable rust version during the kernel's merge window might be
> assumed to be the minimum
On Sun, Jul 12, 2020 at 12:39:44PM -0700, Josh Triplett wrote:
> On Sun, Jul 12, 2020 at 03:31:51PM +0300, Adrian Bunk wrote:
> > On Thu, Jul 09, 2020 at 11:41:47AM -0700, Nick Desaulniers wrote:
> > >...
> > > but also a larger question of "should we do
> >
On Thu, Jul 09, 2020 at 11:41:47AM -0700, Nick Desaulniers wrote:
>...
> but also a larger question of "should we do
> this?" or "how might we place limits on where this can be used?"
>...
I won't attend, but I do have a topic that should be covered:
Firefox always depends on recent Rust, which
On Mon, May 14, 2018 at 03:11:30AM +0100, Ben Hutchings wrote:
> On Sun, 2018-05-13 at 23:48 +0300, Adrian Bunk wrote:
>...
> > Due to the gdm bugs mentioned above we know that there are real-life
> > situations where gdm currently uses "random" data that might be
&g
On Mon, May 14, 2018 at 03:11:30AM +0100, Ben Hutchings wrote:
> On Sun, 2018-05-13 at 23:48 +0300, Adrian Bunk wrote:
>...
> > Due to the gdm bugs mentioned above we know that there are real-life
> > situations where gdm currently uses "random" data that might be
&g
On Wed, May 09, 2018 at 11:46:00PM +0100, Ben Hutchings wrote:
>...
> # Security flaw and initial fix
>
> Recently it was discovered that getrandom() could return successfully
> before the RNG was really ready to produce unpredictable data. This
> issue was designated as CVE-2018-1108, and was
On Wed, May 09, 2018 at 11:46:00PM +0100, Ben Hutchings wrote:
>...
> # Security flaw and initial fix
>
> Recently it was discovered that getrandom() could return successfully
> before the RNG was really ready to produce unpredictable data. This
> issue was designated as CVE-2018-1108, and was
On Wed, Aug 22, 2012 at 12:22:41PM -0700, Kent Overstreet wrote:
> On Wed, Aug 22, 2012 at 08:43:52PM +0300, Adrian Bunk wrote:
> > On Wed, Aug 22, 2012 at 10:04:05AM -0700, Kent Overstreet wrote:
> > >...
> > > --- a/include/linux/blk_types.h
> > > +++ b/inclu
On Wed, Aug 22, 2012 at 10:04:05AM -0700, Kent Overstreet wrote:
>...
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -117,6 +117,7 @@ struct bio {
> * BIO_POOL_IDX()
> */
> #define BIO_RESET_BITS 12
> +#define BIO_OWNS_VEC 12 /* bio_free() should free bvec
On Wed, Aug 22, 2012 at 10:04:05AM -0700, Kent Overstreet wrote:
...
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -117,6 +117,7 @@ struct bio {
* BIO_POOL_IDX()
*/
#define BIO_RESET_BITS 12
+#define BIO_OWNS_VEC 12 /* bio_free() should free bvec */
...
On Wed, Aug 22, 2012 at 12:22:41PM -0700, Kent Overstreet wrote:
On Wed, Aug 22, 2012 at 08:43:52PM +0300, Adrian Bunk wrote:
On Wed, Aug 22, 2012 at 10:04:05AM -0700, Kent Overstreet wrote:
...
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -117,6 +117,7
On Tue, Feb 26, 2008 at 08:58:02PM +0100, Sam Ravnborg wrote:
> >
> > Please name the tools that are that broken that they wouldn't apply this
> > patch correctly and don't claim my patch was broken (or shut up).
>
> It is only one or two weeks ago we ended up with a zero size file
> in the
With using KBUILD_DEFCONFIG we don't have to ship a second copy of
m32700ut.smp_defconfig
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
arch/m32r/Makefile |2
arch/m32r/defconfig | 863
2 files changed, 2 insertions(+), 863 del
The default defconfig should be one from arch/m68k/configs/
arch/m68k/defconfig was not exactly identical to amiga_defconfig but
also considering how long they have been without any update that doesn't
seem to have been on purpose.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
With KBUILD_DEFCONFIG we don't have to ship a second copy of
ip22_defconfig
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
arch/mips/Makefile |2
arch/mips/defconfig | 1158
2 files changed, 2 insertions(+), 1158 del
On Tue, Feb 26, 2008 at 08:44:53PM +0100, Sam Ravnborg wrote:
> On Tue, Feb 26, 2008 at 07:04:02PM +0100, Jesper Nilsson wrote:
> > On Tue, Feb 26, 2008 at 07:47:03PM +0200, Adrian Bunk wrote:
> > > This patch moves the cris defconfigs to arch/cris/configs/ where
On Tue, Feb 26, 2008 at 11:48:29PM +0530, Kamalesh Babulal wrote:
> Adrian Bunk wrote:
> > On Tue, Feb 26, 2008 at 07:59:08PM +0530, Kamalesh Babulal wrote:
> >> Hi,
> >>
> >> The 2.6.25-rc3 kernel build fails on powerpc with allyesconfig config
> >&g
Commit e108b2ca2349f510ce7d7f910eda89f71d710d84 broke the compilation of
drivers/serial/sh-sci.c on h8300:
<-- snip -->
...
CC drivers/serial/sh-sci.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/sh-sci.c:57:21: error:
asm/sci.h: No such file or directory
...
make[3]: ***
when it results in a
64bit division:
<-- snip -->
...
MODPOST 759 modules
ERROR: "__divdi3" [drivers/crypto/hifn_795x.ko] undefined!
<-- snip -->
Reported by Martin Michlmayr.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
40b45041ddc587c20b872a86a6a36952c
On Tue, Feb 26, 2008 at 07:59:08PM +0530, Kamalesh Babulal wrote:
> Hi,
>
> The 2.6.25-rc3 kernel build fails on powerpc with allyesconfig config option,
> the .config has been attached.
>...
Builds fine here.
Local problem (e.g. disk full) on your machine?
cu
Adrian
--
"Is there not
On Tue, Feb 26, 2008 at 11:22:03AM +0100, Willy Tarreau wrote:
> On Tue, Feb 26, 2008 at 11:14:55AM +0200, Adrian Bunk wrote:
> > On Mon, Feb 25, 2008 at 11:21:38PM +0100, Willy Tarreau wrote:
>...
> > > Have you tried keeping the module names intact (.ko, not .ko.gz) ?
> &
On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote:
>
> it's not just that it falls under the category of PCI "legacy" but,
> if you look in drivers/pci/search.c near the bottom:
>
> ...
> #ifdef CONFIG_PCI_LEGACY
> EXPORT_SYMBOL(pci_find_device);
> EXPORT_SYMBOL(pci_find_slot);
On Mon, Feb 25, 2008 at 11:21:38PM +0100, Willy Tarreau wrote:
> On Mon, Feb 25, 2008 at 09:42:09PM +, Steve Brokenshire wrote:
> > Hi,
> >
> > (I've sent this to the linux-kbuild and linux-kernel lists as this
> > patch modifies the Makefile.modinst file. I also don't subscribe to the
> >
On Mon, Feb 25, 2008 at 11:21:38PM +0100, Willy Tarreau wrote:
On Mon, Feb 25, 2008 at 09:42:09PM +, Steve Brokenshire wrote:
Hi,
(I've sent this to the linux-kbuild and linux-kernel lists as this
patch modifies the Makefile.modinst file. I also don't subscribe to the
linux-kbuild
On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote:
it's not just that it falls under the category of PCI legacy but,
if you look in drivers/pci/search.c near the bottom:
...
#ifdef CONFIG_PCI_LEGACY
EXPORT_SYMBOL(pci_find_device);
EXPORT_SYMBOL(pci_find_slot);
#endif /*
On Tue, Feb 26, 2008 at 11:22:03AM +0100, Willy Tarreau wrote:
On Tue, Feb 26, 2008 at 11:14:55AM +0200, Adrian Bunk wrote:
On Mon, Feb 25, 2008 at 11:21:38PM +0100, Willy Tarreau wrote:
...
Have you tried keeping the module names intact (.ko, not .ko.gz) ?
It's what I was doing
On Tue, Feb 26, 2008 at 07:59:08PM +0530, Kamalesh Babulal wrote:
Hi,
The 2.6.25-rc3 kernel build fails on powerpc with allyesconfig config option,
the .config has been attached.
...
Builds fine here.
Local problem (e.g. disk full) on your machine?
cu
Adrian
--
Is there not
modules
ERROR: __divdi3 [drivers/crypto/hifn_795x.ko] undefined!
-- snip --
Reported by Martin Michlmayr.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
40b45041ddc587c20b872a86a6a36952c28b02c7 diff --git
a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 3110bf7..b1541c6
Commit e108b2ca2349f510ce7d7f910eda89f71d710d84 broke the compilation of
drivers/serial/sh-sci.c on h8300:
-- snip --
...
CC drivers/serial/sh-sci.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/sh-sci.c:57:21: error:
asm/sci.h: No such file or directory
...
make[3]: ***
On Tue, Feb 26, 2008 at 11:48:29PM +0530, Kamalesh Babulal wrote:
Adrian Bunk wrote:
On Tue, Feb 26, 2008 at 07:59:08PM +0530, Kamalesh Babulal wrote:
Hi,
The 2.6.25-rc3 kernel build fails on powerpc with allyesconfig config
option,
the .config has been attached.
...
Builds
On Tue, Feb 26, 2008 at 08:44:53PM +0100, Sam Ravnborg wrote:
On Tue, Feb 26, 2008 at 07:04:02PM +0100, Jesper Nilsson wrote:
On Tue, Feb 26, 2008 at 07:47:03PM +0200, Adrian Bunk wrote:
This patch moves the cris defconfigs to arch/cris/configs/ where they
belong.
As a side effect
With KBUILD_DEFCONFIG we don't have to ship a second copy of
ip22_defconfig
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
arch/mips/Makefile |2
arch/mips/defconfig | 1158
2 files changed, 2 insertions(+), 1158 deletions
The default defconfig should be one from arch/m68k/configs/
arch/m68k/defconfig was not exactly identical to amiga_defconfig but
also considering how long they have been without any update that doesn't
seem to have been on purpose.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
arch/m68k
With using KBUILD_DEFCONFIG we don't have to ship a second copy of
m32700ut.smp_defconfig
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
arch/m32r/Makefile |2
arch/m32r/defconfig | 863
2 files changed, 2 insertions(+), 863 deletions
On Tue, Feb 26, 2008 at 08:58:02PM +0100, Sam Ravnborg wrote:
Please name the tools that are that broken that they wouldn't apply this
patch correctly and don't claim my patch was broken (or shut up).
It is only one or two weeks ago we ended up with a zero size file
in the kernel tree
On Mon, Feb 25, 2008 at 02:48:35PM -0500, Alan Cox wrote:
> On Mon, Feb 25, 2008 at 09:27:10PM +0200, Adrian Bunk wrote:
> > > As I understand it if Vladis wants to submit his own change to the symbol
> > > thats up to him, and he'll be liable for any fallout with the FSF, o
On Mon, Feb 25, 2008 at 06:19:57PM +, Alan Cox wrote:
> > The reason I added GPL is not because of some idea that this is all
> > "chummy" with the kernel. But because I derived the mcount code from
> > glibc's version of mcount. Now you may argue that glibc is under LGPL
> > and a non-GPL
On Mon, Feb 25, 2008 at 02:45:49PM +0100, Ingo Molnar wrote:
>...
> > > I've seen architectures that were build-tested for the _first time_
> > > at around 2.6.24-rc8...
> >
> > That can't be true.
> >
> > Can you name what architectures you think of and why you think noone
> > tried to
On Mon, Feb 25, 2008 at 01:57:07PM +0100, Ingo Molnar wrote:
>
> * Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > > the existing 32-bit and 64-bit defconfigs should be enough for that.
> > > For better/full coverage, randconfig should be used.
> >
&g
On Mon, Feb 25, 2008 at 12:50:22PM +0100, Ingo Molnar wrote:
>
> * Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > > What i do against build breakage is randconfig testing. That catches
> > > far more build breakage than a few limited number of defconfigs
>
On Mon, Feb 25, 2008 at 12:27:34PM +0100, Florian Fainelli wrote:
> Le lundi 25 février 2008, Adrian Bunk a écrit :
> > Booting it might fine, but CLOCK_TICK_RATE will be wrong...
>
> PIT_TICK_RATE is overriden specificaly for R321x in include/asm-x86/timex.h,
> just like for A
On Mon, Feb 25, 2008 at 12:17:07PM +0100, Ingo Molnar wrote:
>
> * Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > What I want is that e.g. after fiddling with kernel headers I want an
> > easy way of having much compile coverage. And my script that builds
> > all
On Mon, Feb 25, 2008 at 11:51:10AM +0100, Ingo Molnar wrote:
>
> * Florian Fainelli <[EMAIL PROTECTED]> wrote:
>
> > > In fact for rdc321x that should be rather easy to do right now:
> > > wdt.c could/should become a regular watchdog driver, and do we
> > > really need those GPIO specials in
On Mon, Feb 25, 2008 at 11:14:33AM +0100, Ingo Molnar wrote:
>
> * Florian Fainelli <[EMAIL PROTECTED]> wrote:
>
> > This patch adds the default kernel configuration for the RDC R-321x
> > SoC.
>
> hm, i'm not sure. Right now we just have a 32-bit defconfig and a 64-bit
> defconfig - but
On Mon, Feb 25, 2008 at 11:14:33AM +0100, Ingo Molnar wrote:
* Florian Fainelli [EMAIL PROTECTED] wrote:
This patch adds the default kernel configuration for the RDC R-321x
SoC.
hm, i'm not sure. Right now we just have a 32-bit defconfig and a 64-bit
defconfig - but there are about
On Mon, Feb 25, 2008 at 11:51:10AM +0100, Ingo Molnar wrote:
* Florian Fainelli [EMAIL PROTECTED] wrote:
In fact for rdc321x that should be rather easy to do right now:
wdt.c could/should become a regular watchdog driver, and do we
really need those GPIO specials in
On Mon, Feb 25, 2008 at 12:17:07PM +0100, Ingo Molnar wrote:
* Adrian Bunk [EMAIL PROTECTED] wrote:
What I want is that e.g. after fiddling with kernel headers I want an
easy way of having much compile coverage. And my script that builds
all defconfig's is trivial (although it takes
On Mon, Feb 25, 2008 at 12:27:34PM +0100, Florian Fainelli wrote:
Le lundi 25 février 2008, Adrian Bunk a écrit :
Booting it might fine, but CLOCK_TICK_RATE will be wrong...
PIT_TICK_RATE is overriden specificaly for R321x in include/asm-x86/timex.h,
just like for AMD Elan.
Not when you
On Mon, Feb 25, 2008 at 12:50:22PM +0100, Ingo Molnar wrote:
* Adrian Bunk [EMAIL PROTECTED] wrote:
What i do against build breakage is randconfig testing. That catches
far more build breakage than a few limited number of defconfigs
would ever.
How do you test whether a x86
On Mon, Feb 25, 2008 at 01:57:07PM +0100, Ingo Molnar wrote:
* Adrian Bunk [EMAIL PROTECTED] wrote:
the existing 32-bit and 64-bit defconfigs should be enough for that.
For better/full coverage, randconfig should be used.
The two big problems with randconfigs are:
- either you
On Mon, Feb 25, 2008 at 02:45:49PM +0100, Ingo Molnar wrote:
...
I've seen architectures that were build-tested for the _first time_
at around 2.6.24-rc8...
That can't be true.
Can you name what architectures you think of and why you think noone
tried to compile them before?
On Mon, Feb 25, 2008 at 06:19:57PM +, Alan Cox wrote:
The reason I added GPL is not because of some idea that this is all
chummy with the kernel. But because I derived the mcount code from
glibc's version of mcount. Now you may argue that glibc is under LGPL
and a non-GPL export is
On Mon, Feb 25, 2008 at 02:48:35PM -0500, Alan Cox wrote:
On Mon, Feb 25, 2008 at 09:27:10PM +0200, Adrian Bunk wrote:
As I understand it if Vladis wants to submit his own change to the symbol
thats up to him, and he'll be liable for any fallout with the FSF, or
harm to Linux resulting
This patch adds proper extern declarations for five variables in
include/linux/vmstat.h
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
fs/proc/proc_misc.c|4
include/linux/vmstat.h |6 ++
kernel/sysctl.c|2 +-
mm/vmstat.c|1 +
4
It's confusing that set_max_huge_pages() contained two different
variables named "ret", and although the code works correctly this should
be fixed.
The inner of the two variables can simply be removed.
Spotted by sparse.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--
This patch adds proper extern declarations for three variables in
include/linux/oom.h
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux/oom.h |4
kernel/sysctl.c |4 +---
2 files changed, 5 insertions(+), 3 deletions(-)
5ac59cd3de28fdad038576ebef6a2ac41c
()
- find_usable_zone_for_movable()
- adjust_zone_range_for_zone_movable()
- __absent_pages_in_range()
- find_min_pfn_for_node()
- find_zone_movable_pfns_for_nodes()
- #if 0 the following no longer used global function:
- free_cold_page()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux
Robert P. J. Day spotted that my removal of the Sangoma drivers missed a
few bits.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
Documentation/networking/00-INDEX |2
Documentation/networking/wan-router.txt | 621
include/linux/
Every file should include the headers containing the externs for its
global code (in this case for struct generic_file_vm_ops).
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
31f02514a5fdca74a4f4f48f13d3450880b7f038 diff --git a/mm/filemap.c
b/mm/filemap.c
index 5c74b68..9b58ae0
This patch adds a proper prototype for show_numa_map()
in include/linux/mempolicy.h
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
fs/proc/task_mmu.c|2 --
include/linux/mempolicy.h |3 +++
2 files changed, 3 insertions(+), 2 del
0x1d48): undefined reference to `video_register_device'
drivers/built-in.o:(.rodata+0x1b40): undefined reference to
`video_ioctl2'drivers/built-in.o:(.data+0x140c): undefined reference to
`video_device_release'
make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[
This patch adds proper prototypes for vread/vwrite in
include/linux/vmalloc.h
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/char/mem.c |3 ---
include/linux/vmalloc.h |3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
ce4fe62358ed9369d3ff4e67d621164b38
This patch makes the needlessly global anon_vma_cachep static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux/rmap.h | 12
mm/rmap.c| 12 +++-
2 files changed, 11 insertions(+), 13 deletions(-)
8d2d63d71ecbf2db78f31025acb136c9dd
This patch makes the following needlessly global code static:
- swap_lock
- nr_swapfiles
- struct swap_list
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux/swap.h |3 ---
mm/swapfile.c|6 +++---
2 files changed, 3 insertions(+), 6 del
atapi_dmadir can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c |2 +-
drivers/ata/libata.h |1 -
2 files changed, 1 insertion(+), 2 deletions(-)
ad621a905275c744307cdb9bb4bab47a187a477b diff --git a/drivers/ata/libata-cor
This patch makes the following needlessly global functions static:
- percpu_depopulate()
- __percpu_depopulate_mask()
- percpu_populate()
- __percpu_populate_mask()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux/percpu.h | 29 -
mm/allocpe
This patch makes the needlessly global print_bad_pte() static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux/mm.h |1 -
mm/memory.c|3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
cf47cf1dae0fe5b04b95ede85cac61c74f75c1c2 diff --git a/include
This patch makes the needlessly global sparse_early_mem_map_alloc()
static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
47e8f879748b0e89a465a50626ae93dd55844a15 diff --git a/mm/sparse.c b/mm/sparse.c
index f6a43c0..99cd810 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -269,7
This patch makes thefollowing needlessly global functions static:
- mem_cgroup_force_empty()
- mem_cgroup_write_strategy()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
mm/memcontrol.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
0d8013bdcc403636cc326410af419e2e94
On Sun, Feb 24, 2008 at 10:10:33PM +0100, Paolo Ciarrocchi wrote:
> Before:
> total: 43 errors, 66 warnings, 2183 lines checked
>
> After:
> total: 0 errors, 36 warnings, 2192 lines checked
>
> I didn't (and I don't plan to) fix the warnings:
> WARNING: line over 80 characters
>
>
>
For compile tests it would be nice it we had at least for each
subarchitecture not covered by X86_GENERICARCH a defconfig.
These are the following subarchitectures:
- X86_ELAN
- X86_VOYAGER
- X86_NUMAQ
- X86_VISWS
- X86_RDC321X
- X86_VSMP
A defconfig is nothing special, it's enough to simply
For compile tests it would be nice it we had at least for each
subarchitecture not covered by X86_GENERICARCH a defconfig.
These are the following subarchitectures:
- X86_ELAN
- X86_VOYAGER
- X86_NUMAQ
- X86_VISWS
- X86_RDC321X
- X86_VSMP
A defconfig is nothing special, it's enough to simply
On Sun, Feb 24, 2008 at 10:10:33PM +0100, Paolo Ciarrocchi wrote:
Before:
total: 43 errors, 66 warnings, 2183 lines checked
After:
total: 0 errors, 36 warnings, 2192 lines checked
I didn't (and I don't plan to) fix the warnings:
WARNING: line over 80 characters
Signed-off-by: Paolo
This patch makes thefollowing needlessly global functions static:
- mem_cgroup_force_empty()
- mem_cgroup_write_strategy()
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
mm/memcontrol.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
0d8013bdcc403636cc326410af419e2e94d2450d
This patch makes the needlessly global sparse_early_mem_map_alloc()
static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
47e8f879748b0e89a465a50626ae93dd55844a15 diff --git a/mm/sparse.c b/mm/sparse.c
index f6a43c0..99cd810 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -269,7 +269,7
This patch makes the following needlessly global functions static:
- percpu_depopulate()
- __percpu_depopulate_mask()
- percpu_populate()
- __percpu_populate_mask()
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
include/linux/percpu.h | 29 -
mm/allocpercpu.c
This patch makes the needlessly global print_bad_pte() static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
include/linux/mm.h |1 -
mm/memory.c|3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
cf47cf1dae0fe5b04b95ede85cac61c74f75c1c2 diff --git a/include/linux/mm.h
atapi_dmadir can now become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |2 +-
drivers/ata/libata.h |1 -
2 files changed, 1 insertion(+), 2 deletions(-)
ad621a905275c744307cdb9bb4bab47a187a477b diff --git a/drivers/ata/libata-core.c
b
This patch makes the following needlessly global code static:
- swap_lock
- nr_swapfiles
- struct swap_list
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
include/linux/swap.h |3 ---
mm/swapfile.c|6 +++---
2 files changed, 3 insertions(+), 6 deletions
This patch makes the needlessly global anon_vma_cachep static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
include/linux/rmap.h | 12
mm/rmap.c| 12 +++-
2 files changed, 11 insertions(+), 13 deletions(-)
8d2d63d71ecbf2db78f31025acb136c9dd4db6a2 diff
This patch adds proper prototypes for vread/vwrite in
include/linux/vmalloc.h
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
drivers/char/mem.c |3 ---
include/linux/vmalloc.h |3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
ce4fe62358ed9369d3ff4e67d621164b381234ab
): undefined reference to `video_register_device'
drivers/built-in.o:(.rodata+0x1b40): undefined reference to
`video_ioctl2'drivers/built-in.o:(.data+0x140c): undefined reference to
`video_device_release'
make: *** [.tmp_vmlinux1] Error 1
-- snip --
Signed-off-by: Adrian Bunk [EMAIL PROTECTED
This patch adds a proper prototype for show_numa_map()
in include/linux/mempolicy.h
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
fs/proc/task_mmu.c|2 --
include/linux/mempolicy.h |3 +++
2 files changed, 3 insertions(+), 2 deletions
Robert P. J. Day spotted that my removal of the Sangoma drivers missed a
few bits.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
Documentation/networking/00-INDEX |2
Documentation/networking/wan-router.txt | 621
include/linux/Kbuild
Every file should include the headers containing the externs for its
global code (in this case for struct generic_file_vm_ops).
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
31f02514a5fdca74a4f4f48f13d3450880b7f038 diff --git a/mm/filemap.c
b/mm/filemap.c
index 5c74b68..9b58ae0 100644
This patch adds proper extern declarations for three variables in
include/linux/oom.h
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
include/linux/oom.h |4
kernel/sysctl.c |4 +---
2 files changed, 5 insertions(+), 3 deletions(-)
5ac59cd3de28fdad038576ebef6a2ac41c5d7c69
()
- find_usable_zone_for_movable()
- adjust_zone_range_for_zone_movable()
- __absent_pages_in_range()
- find_min_pfn_for_node()
- find_zone_movable_pfns_for_nodes()
- #if 0 the following no longer used global function:
- free_cold_page()
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
include/linux/gfp.h
This patch adds proper extern declarations for five variables in
include/linux/vmstat.h
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
fs/proc/proc_misc.c|4
include/linux/vmstat.h |6 ++
kernel/sysctl.c|2 +-
mm/vmstat.c|1 +
4 files changed
It's confusing that set_max_huge_pages() contained two different
variables named ret, and although the code works correctly this should
be fixed.
The inner of the two variables can simply be removed.
Spotted by sparse.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
mm/hugetlb.c |1
error: (Each undeclared identifier is reported only once
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/usb/host/u132-hcd.c:3225:
error: for each function it appears in.)
make[4]: *** [drivers/usb/host/u132-hcd.o] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[
On Sat, Feb 23, 2008 at 03:05:47PM +0100, Paolo Ciarrocchi wrote:
> File is now error free.
> Compile tested.
>
>
> Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
> ---
> drivers/ide/pci/generic.c | 50 ++--
> 1 files changed, 25 insertions(+), 25
On Sat, Feb 23, 2008 at 03:05:47PM +0100, Paolo Ciarrocchi wrote:
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/pci/generic.c | 50 ++--
1 files changed, 25 insertions(+), 25
: (Each undeclared identifier is reported only once
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/usb/host/u132-hcd.c:3225:
error: for each function it appears in.)
make[4]: *** [drivers/usb/host/u132-hcd.o] Error 1
-- snip --
Signed-off-by: Adrian Bunk [EMAIL PROTECTED
Trying to compile common_defconfig fails with the following error:
<-- snip -->
...
CC init/main.o
In file included from include2/asm/hardirq.h:15,
from
/home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/hardirq.h:7,
from
Every file should include the headers containing the externs for its
global functions (in this case for sys_move_pages()).
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
5624ee2189a0b767e8e474cdd53d8a536dd8f262 diff --git a/mm/migrate.c
b/mm/migrate.c
index a73504f..36e1820 100644
--
This patc makes the needlessly global struct default_policy static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
4a69fc08292ebe8b7d202436a71926950a980c21 diff --git a/include/linux/mempolicy.h
b/include/linux/mempolicy.h
index 59c4865..fd20b03 100644
--- a/include/linux/mempolicy.h
On Wed, Feb 20, 2008 at 03:52:44PM +0200, Pekka Enberg wrote:
>
> Hi Adrian,
>
> On 2/20/2008, "Adrian Bunk" <[EMAIL PROTECTED]> wrote:
> > The Coverity checker spotted the following inconsequent NULL checking
> > introduced by commit 8ff12cfc009a2a38d87f
On Wed, Feb 20, 2008 at 08:09:35AM -0800, Greg KH wrote:
> On Wed, Feb 20, 2008 at 09:56:28AM +0200, Adrian Bunk wrote:
> > On Tue, Feb 19, 2008 at 09:47:58PM -0800, Greg KH wrote:
> > > On Tue, Feb 19, 2008 at 09:29:02PM +0200, Adrian Bunk wrote:
> > > > The Coverity
.
It simply notices that it's once checked and once dereferenced
unconditionally.
> The check can go.
Thanks, patch below.
> Alan
cu
Adrian
<-- snip -->
There's no reason for checking pdev->bus for being NULL here (and we'd
anyway Oops below if it was).
Signed-off-by: Adrian
1 - 100 of 8052 matches
Mail list logo
