Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

On 07.07.2020 12:25, Mark Brown wrote: > On Mon, Jul 06, 2020 at 09:57:53PM +0200, Geert Uytterhoeven wrote: >> On Mon, Jul 6, 2020 at 6:18 PM Mark Brown wrote: >>> It would really help to have an example of how a client device will use >>> this, right now it's a bit hard to follow. Overall it

Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

On 06.07.2020 18:18, Mark Brown wrote: > On Mon, Jul 06, 2020 at 11:22:43AM +0200, Adrian Fiergolski wrote: > > Please don't send new patches in reply to old threads, it buries them > and can be confusing. Ok, thanks. It's my debut in sharing a complete driver patch ;-) &

Re: [PATCH v2 2/2] dt-bindings: Add documentation for SPI daisy chain driver.

Hi Geert and Mark, Thank you for your comments. I will try to address them in the next replies. On 06.07.2020 18:22, Mark Brown wrote: > On Mon, Jul 06, 2020 at 05:32:51PM +0200, Geert Uytterhoeven wrote: > >> However, that information would need to be added to each driver only once. >> With your

Re: [PATCH v2 2/2] dt-bindings: Add documentation for SPI daisy chain driver.

Hi Geert, Thank you for your reply. On 06.07.2020 17:10, Geert Uytterhoeven wrote: > Hi Adrian, > > On Mon, Jul 6, 2020 at 11:23 AM Adrian Fiergolski > wrote: >> Add documentation for SPI daisy chain driver. >> >> Signed-off-by: Adrian Fiergolski > Thanks f

[PATCH v2 2/2] dt-bindings: Add documentation for SPI daisy chain driver.

Add documentation for SPI daisy chain driver. Signed-off-by: Adrian Fiergolski --- .../bindings/spi/spi-daisy_chain.txt | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/spi-daisy_chain.txt diff --git a/Documentation

[PATCH v2 1/2] spi: Add the SPI daisy chain support.

;spi-daisy-chain-bits_per_word'). It has been tested on hardware with a chain of three ltc2694 devices (kernel v4.19). Signed-off-by: Adrian Fiergolski --- Changes in v2: - declare spi_daisy_chain_clean as static Reported-by: kernel test robot --- drivers/spi/Kconfig

[PATCH 1/2] spi: Add the SPI daisy chain support.

;spi-daisy-chain-bits_per_word'). It has been tested on hardware with a chain of three ltc2694 devices (kernel v4.19). Signed-off-by: Adrian Fiergolski --- drivers/spi/Kconfig | 8 + drivers/spi/Makefile| 1 + drivers/spi/spi-daisy_chain.c | 428 ++

[PATCH 2/2] dt-bindings: Add documentation for SPI daisy chain driver.

Add documentation for SPI daisy chain driver. Signed-off-by: Adrian Fiergolski --- .../bindings/spi/spi-daisy_chain.txt | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/spi-daisy_chain.txt diff --git a/Documentation

Re: [RFC PATCH 0/2] check I2C device id for pca984x chips

On 27.01.2018 at 09:37, Peter Rosin wrote: > On 2018-01-26 17:33, Adrian Fiergolski wrote: >> Hi Peter, >> >> Sorry for the late reply. > No problem. > >> Yes, it's true I have one of the chip. However, my yocto based build system >> depends on http

Re: [RFC PATCH 0/2] check I2C device id for pca984x chips

Hi Peter, Sorry for the late reply. Yes, it's true I have one of the chip. However, my yocto based build system depends on https://github.com/Xilinx/linux-xlnx and it's in version 4.9.0-xilinx-v2017.3. Apparently, there were some bigger changes in i2c core between this version and upstream, thus

Re: [PATCH] spi: Add spi-bits-per-word binding.

Hi Geert, On 13.03.2017 at 20:57, Geert Uytterhoeven wrote: > On Mon, Mar 13, 2017 at 7:12 PM, Adrian Fiergolski > wrote: >> On 13.03.2017 at 18:55, Mark Brown wrote: >>>> In my case, xilinx_spi_probe function (of spi-xilinx controller) sets >>>> bits_per_wo

Re: [PATCH] spi: Add spi-bits-per-word binding.

On 13.03.2017 at 18:55, Mark Brown wrote: > >> In my case, xilinx_spi_probe function (of spi-xilinx controller) sets >> bits_per_word_mask of spi_master struct only to 16 bits support. Later, >> xilinx_spi_probe calls of_register_spi_devices, which calls >> of_register_spi_devices. The last one all

Re: [PATCH] spi: Add spi-bits-per-word binding.

evice driver. As you see, the device driver doesn't have possibility to modify bits_per_word during the registration process, thus it can't provide support for such limited controllers. Regards, Adrian On 21.02.2017 at 20:08, Mark Brown wrote: > On Mon, Feb 20, 2017 at 04:35:12PM +010

[PATCH] spi: Add spi-bits-per-word binding.

word set to 0. Thus, the spi_setup function will set it to default 8. Further, the same function will call __spi_validate_bits_per_word which will fail the whole registration for controllers not supporting 8 bit transfers (i.e. xilinx-spi). Signed-off-by: Adrian Fiergolski --- Documentation/de

[PATCH] Add possibility to define bits-per-word property.

Signed-off-by: Adrian Fiergolski --- drivers/spi/spi.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 0239b45..d2267e9 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1549,6 +1549,17 @@ of_register_spi_device(struct