drm: understanding the kernel warning during drm_vblank_cleanup()

2018-11-29 Thread Ahsan Hussain
Hi folks, I'm new to DRM and trying to understand the warning in drivers/gpu/drm/drm_vblank.c during drm_vblank_cleanup(). WARN_ON(READ_ONCE(vblank->enabled) &&     drm_core_check_feature(dev, DRIVER_MODESET)); Is the drm driver responsible for making sure that !(vblank->enabled) in the .unb

Re: [PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking

2018-04-16 Thread Ahsan Hussain
On 04/16/2018 10:28 PM, Guenter Roeck wrote: > On Mon, Apr 16, 2018 at 10:08:19PM +0500, Ahsan Hussain wrote: >> >> Upstream commit >> >> 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed") >> > This doesn't have to be on sep

[PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking

2018-04-16 Thread Ahsan Hussain
Upstream commit 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed") makes ina2xx_set_shunt() call mutex_lock on an un-initialized mutex. Initialize it prior so we don't get a NULL pointer dereference error Signed-off-by: Ahsan Hussain --- drivers/hwmon/ina2x