Signed-off-by: Anton Yakovlev
Signed-off-by: Aiswarya Cyriac
Reported-by: coverity-bot
Addresses-Coverity-ID: 1583619 ("Uninitialized variables")
Fixes: d6568e3de42d ("ALSA: virtio: add support for audio controls")
---
sound/virtio/virtio_kctl.c | 19 +++
1 file cha
>>On Wed, Feb 14, 2024 at 03:01:10PM +0100, Aiswarya Cyriac wrote:
>> This commit fixes the following warning when building virtio_snd driver.
>>
>> "
>> *** CID 1583619: Uninitialized variables (UNINIT)
>> sound/virtio/virtio_kctl.c:2
Signed-off-by: Anton Yakovlev
Signed-off-by: Aiswarya Cyriac
Reported-by: coverity-bot
Addresses-Coverity-ID: 1583619 ("Uninitialized variables")
Fixes: d6568e3de42d ("ALSA: virtio: add support for audio controls")
---
sound/virtio/virtio_kctl.c | 25 +
1 fi
On Wed, 14 Feb 2024 12:30:19 +0100,
Michael S. Tsirkin wrote:
>>
>> On Wed, Feb 14, 2024 at 09:08:26AM +0000, Aiswarya Cyriac wrote:
>> > Hi Michael,
>> >
>> > Thank you for reviewing. I have updated my response inline
>> >
>> > On Tue
Signed-off-by: Anton Yakovlev
Signed-off-by: Aiswarya Cyriac
Reported-by: coverity-bot
Addresses-Coverity-ID: 1583619 ("Uninitialized variables")
Fixes: d6568e3de42d ("ALSA: virtio: add support for audio controls")
---
sound/virtio/virtio_kctl.c | 24
1 fi
Hi Michael,
Thank you for reviewing. I have updated my response inline
On Tue, Feb 13, 2024 at 09:51:30AM +0100, Aiswarya Cyriac wrote:
>> Fix the following warning when building virtio_snd driver.
>>
>> "
>> *** CID 1583619: Uninitialized variables (UNINIT)
>
)
vvv Using uninitialized value "rc".
294 return rc;
295 }
296
297 /**
298 * virtsnd_kctl_get_enum_items() - Query items for the ENUMERATED
element type.
299 * @snd: VirtIO sound device.
"
Signed-off-by: Anton Yakovlev
Signed-off-by: Aiswarya Cyriac
Repor
{
...
/* control element event types */
VIRTIO_SND_EVT_CTL_NOTIFY = 0x1200,
...
};
See additional details in [1].
[1] https://lists.oasis-open.org/archives/virtio-comment/202104/msg00013.html
Signed-off-by: Anton Yakovlev
Signed-off-by: Aiswarya Cyriac
---
include/uapi/linux/virtio_snd.h | 154
From: Anton Yakovlev
Changes in v2
- Fix reporting of incorrect number of items for ENUMERATED controls
Implementation of support for audio controls in accordance with the
extension of the virtio sound device specification[1] planned for
virtio-v1.3-cs01.
Design of virtual audio controls is bas
Hi Marcin,
I have pushed v2 of the patches with a fix today. The feature development is
complete and the patch awaits review.
Thanks for any support in testing or review.
Best Regards,
Aiswarya Cyriac
Software Engineer
OpenSynergy GmbH
Rotherstr. 20, 10245 Berlin
EMail: aiswarya.cyr
10 matches
Mail list logo