Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

On 25/02/21 12:39 pm, Kalle Valo wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > writes: > >> On 24/02/21 10:13 pm, Kalle Valo wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you >>> know the content is safe >>

Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

On 24/02/21 10:13 pm, Kalle Valo wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Marcus Folkesson writes: > >> Write the value instead of reading it twice. >> >> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for functio

Re: [PATCH][next] wilc1000: remove redundant assignment to pointer vif

On 03/12/20 11:13 pm, Colin King wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > From: Colin Ian King > > The assignment to pointer vif is redundant as the assigned value > is never read, hence it can be removed. > > Addresses-Coverit

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_bus_probe

On 20/08/20 11:22 am, Dinghao Liu wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > When devm_clk_get() returns -EPROBE_DEFER, spi_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 854d66df74aed ("staging: wil

Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_sdio_probe

On 20/08/20 11:18 am, Dinghao Liu wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > When devm_clk_get() returns -EPROBE_DEFER, sdio_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 8692b047e86cf ("staging: wil

Re: [PATCH] staging: wilc1000: Fix memleak in wilc_sdio_probe

Thanks for submitting the patch. The code changes looks okay to me. The driver is now moved out of staging so 'staging' prefix is not required in subject. For future patches on wilc driver, the 'staging' prefix can be removed. For this patch, I am not sure if Kalle can apply as is otherwise pleas

Re: [PATCH v2] staging: wilc1000: Increase the size of wid_list array

On 03/05/20 1:21 pm, Oscar Carter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Increase by one the size of wid_list array as index variable can reach a > value of 5. If this happens, an out-of-bounds access is performed. > > Addresse

Re: [PATCH] staging: wilc1000: Increase the size of wid_list array

On 01/05/20 10:32 pm, Oscar Carter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Increase by one the size of wid_list array as index variable can reach a > value of 5. If this happens, an out-of-bounds access is performed. > > Addresse

Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

Hi Greg, On 05-Sep-19 1:07 PM, Greg KH wrote: > On Thu, Sep 05, 2019 at 06:09:43AM +, ajay.kat...@microchip.com wrote: >> Hi Eugen, >> >> On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote: >>> From: Eugen Hristev >>> >>> Add bindings for optional rtc clock pin. >>> >>> Signed-off-by: Eugen H

Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

Hi Eugen, On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote: > From: Eugen Hristev > > Add bindings for optional rtc clock pin. > > Signed-off-by: Eugen Hristev Thanks for sending the patch series. The changes in this series looks good to me. Acked-by: Ajay Singh Regards, Ajay > --- >

Re: [PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

On 7/19/2019 5:16 PM, Chuhong Yuan wrote: > > 于2019年7月19日周五 下午7:34写道： >> >> On 7/19/2019 1:40 PM, Chuhong Yuan wrote: >>> >>> Merge the combo use of memcpy and le32_to_cpus. >>> Use get_unaligned_le32 instead. >>> This simplifies the code. >>> >>> Signed-off-by: Chuhong Yuan >>> --- >>> driver

Re: [PATCH] staging: wilc1000: Merge memcpy + le32_to_cpus to get_unaligned_le32

On 7/19/2019 1:40 PM, Chuhong Yuan wrote: > > Merge the combo use of memcpy and le32_to_cpus. > Use get_unaligned_le32 instead. > This simplifies the code. > > Signed-off-by: Chuhong Yuan > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

Re: [PATCH V2] staging: wilc1000: fix incorrent type assignment

Thanks. On 2/26/2019 12:55 PM, Bo YU wrote: > Fix sparse warning: > > drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in > assignment (different base types) > drivers/staging/wilc1000/host_interface.c:450:30:expected restricted > __le16 [usertype] beacon_period > d

Re: [PATCH] staging: wilc1000: Fix incorrent type in assignment

On 2/26/2019 8:58 AM, Bo YU wrote: > The patch fixes following sparse warning: > > drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in > assignment (different base types) > drivers/staging/wilc1000/host_interface.c:450:30:expected restricted > __le16 [usertype] bea

Re: [PATCH v4] staging: wilc1000: fix registration frame size

On 1/7/2019 8:13 PM, Július Milan wrote: > Fixes the following sparse warnings: > > drivers/staging/wilc1000/host_interface.c:2360:30: warning: > incorrect type in assignment (different base types) > expected restricted __le32 [addressable] [assigned] [usertype] frame_type > got restric

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

Hi Julius, On 1/6/2019 12:48 PM, Július Milan wrote: >> Before you send V3, are you sure this is the correct fix? As "frame_type" is >> input as u16, it seems to me that the frame_type member of struct >> wilc_reg_frame >> should be __le16, not __le32. > > Yes, I am confident about it. > The fra

Re: [PATCH] staging: wilc1000: fix missing read_write setting when reading data

On 12/19/2018 10:00 PM, Colin King wrote: > From: Colin Ian King > > Currently the cmd.read_write setting is not initialized so it contains > garbage from the stack. Fix this by setting it to 0 to indicate a > read is required. > > Detected by CoverityScan, CID#1357925 ("Uninitialized scalar