Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header

2020-05-16 Thread Ajit Pandey
On 5/14/2020 10:18 PM, Mark Brown wrote: On Thu, May 14, 2020 at 10:08:16PM +0530, Ajit Pandey wrote: +#define MI2S_PRIMARY 0 +#define MI2S_SECONDARY 1 + +#define LPASS_MCLK00 These look like they could use namespacing. Is primary/secondary perhaps something that could be a boolean

Re: [PATCH v2 2/7] ASoC: qcom: Add common array to initialize soc based core clocks

2020-05-16 Thread Ajit Pandey
On 5/14/2020 10:15 PM, Mark Brown wrote: On Thu, May 14, 2020 at 10:08:14PM +0530, Ajit Pandey wrote: AHB-I/X bus clocks inside LPASS coreis not a mandatory clocks for SC7180 soc lpass variants, hence make it an optional one. Do we need to improve the checks in the rest of the code so that if

Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding

2020-05-16 Thread Ajit Pandey
On 5/14/2020 10:14 PM, Mark Brown wrote: On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote: Done the required cleanups to update lpass-cpu binding with newer yaml formats. Please do YAML conversions as the last thing in any patch series, there is quite a big backlog of reviews of