Hi,Mark
Thank you, I already understand, sorry for causing you trouble.
Ajye
On Tue, Nov 10, 2020 at 7:56 PM Mark Brown wrote:
>
> On Tue, Nov 10, 2020 at 05:40:40PM +0800, Ajye Huang wrote:
> > Hi, Mark
> >
> > Could you please kindly review the series patc
Hi, Mark
Could you please kindly review the series patch v6? And may I get your
approval if the review is done.
thanks
Ajye
On Fri, Nov 6, 2020 at 2:14 PM Ajye Huang wrote:
>
> Note:
> - The patch is made by the collaboration of
> Ajye Huang
> Cheng-Yi Chiang
>
>
Hi, Rob
I follow your suggests that adding (maxItems: 1) for dmic-gpis property,
and keep one example of adding dmic-gpios property in it
Could you please kindly review it ?
Thank you so much
Ajye
On Fri, Nov 6, 2020 at 2:14 PM Ajye Huang wrote:
>
> Add a property "dmic-gpios&quo
Add a property "dmic-gpios" for switching between two MICs.
Signed-off-by: Ajye Huang
---
.../devicetree/bindings/sound/google,sc7180-trogdor.yaml | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogd
Note:
- The patch is made by the collaboration of
Ajye Huang
Cheng-Yi Chiang
v6:
- Documentation: Addressed suggestions from Rob Herring.
- Define "maxItems: 1" in dmic-gpios property.
- Only keep one example and add dmic-gpios property in.
v5:
- Machine driver:
- Fix a for
In addition, having mixer control to switch between DMICs by
using "dmic-gpios" property.
Refer to this one as an example,
commit b7a742cff3f6 ("ASoC: AMD: Use mixer control to switch between DMICs")
Signed-off-by: Ajye Huang
Reviewed-by: Tzung-Bi Shih
---
sound/so
HI, Rob,
Thank you for the comments.
On Fri, Nov 6, 2020 at 2:43 AM Rob Herring wrote:
>
> On Tue, Nov 03, 2020 at 06:30:50PM +0800, Ajye Huang wrote:
> > Add a property "dmic-gpios" for switching between two MICs.
> >
> > Signed-off-by: Ajye Huang
>
bother you again to review it. Please let me know if
this looks good to you.
Thanks!
On Tue, Nov 3, 2020 at 6:31 PM Ajye Huang wrote:
>
> Add a property "dmic-gpios" for switching between two MICs.
>
> Signed-off-by: Ajye Huang
> ---
> .../bindings/sound/google,sc7180
Note:
- The patch is made by the collaboration of
Ajye Huang
Cheng-Yi Chiang
v5:
- Machine driver:
- Fix a format string warning (Reported-by: kernel test robot
).
detailed info at https://lore.kernel.org/patchwork/patch/1331087/
v4:
- Machine driver: Addressed suggestions from Tzung
Add a property "dmic-gpios" for switching between two MICs.
Signed-off-by: Ajye Huang
---
.../bindings/sound/google,sc7180-trogdor.yaml | 58 +++
1 file changed, 58 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
b/Doc
In addition, having mixer control to switch between DMICs by
using "dmic-gpios" property.
Refer to this one as an example,
commit b7a742cff3f6 ("ASoC: AMD: Use mixer control to switch between DMICs")
Signed-off-by: Ajye Huang
Reviewed-by: Tzung-Bi Shih
---
sound/so
ples.
That is why I bother you again to review it. Please let me know if
this looks good to you.
Thanks!
On Tue, Nov 3, 2020 at 10:54 AM Ajye Huang wrote:
>
> Add a property "dmic-gpios" for switching between two MICs.
>
> Signed-off-by: Ajye Huang
> ---
> ..
Add a property "dmic-gpios" for switching between two MICs.
Signed-off-by: Ajye Huang
---
.../bindings/sound/google,sc7180-trogdor.yaml | 58 +++
1 file changed, 58 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
b/Doc
Note:
- The patch is made by the collaboration of
Ajye Huang
Cheng-Yi Chiang
Changes from v1 to v2:
- Ducumentation: Modify the dimc-gpios property description and examples.
- Machine driver:
- Remove "qcom,sc7180-sndcard-rt5682-m98357-2mic" compatible
- See gpio proper
In addition, having mixer control to switch between DMICs by
using "dmic-gpios" property.
Refer to this one as an example,
commit b7a742cff3f6 ("ASoC: AMD: Use mixer control to switch between DMICs")
Signed-off-by: Ajye Huang
---
sound/so
On Mon, Nov 2, 2020 at 6:46 PM Tzung-Bi Shih wrote:
>
> On Mon, Nov 2, 2020 at 2:24 PM Ajye Huang wrote:
> >
> > In addition, having mixer control to switch between DMICs by
> > using "dmic-gpios" property.
> >
> > Refer to this one as an example,
In addition, having mixer control to switch between DMICs by
using "dmic-gpios" property.
Refer to this one as an example,
commit b7a742cff3f6 ("ASoC: AMD: Use mixer control to switch between DMICs")
Signed-off-by: Ajye Huang
---
sound/so
Note:
- The patch is made by the collaboration of
Ajye Huang
Cheng-Yi Chiang
Changes from v1 to v2:
- Ducumentation: Modify the dimc-gpios property description and examples.
- Machine driver:
- Remove "qcom,sc7180-sndcard-rt5682-m98357-2mic" compatible
- See gpio proper
Add a property "dmic-gpios" for switching between two MICs.
Signed-off-by: Ajye Huang
---
.../bindings/sound/google,sc7180-trogdor.yaml | 58 +++
1 file changed, 58 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
b/Doc
Hi, Tzung-Bi
I will release v3 version base on your suggestion
Thank you for your reply
Ajye
Tzung-Bi Shih 於 2020年10月30日 週五 下午7:19寫道：
>
> On Fri, Oct 30, 2020 at 6:55 PM Ajye Huang
> wrote:
> > But dmic_get() will need dmic_switch, should i keep dmic_switch?
>
> I see.
On Fri, Oct 30, 2020 at 5:23 PM Tzung-Bi Shih wrote:
>
> On Fri, Oct 30, 2020 at 3:57 PM Ajye Huang wrote:
> > +static struct gpio_desc *dmic_sel;
> > +static int dmic_switch;
>
> If you really need them, you should put them in struct sc7180_snd_data.
>
Thank you, I
In addition, having mixer control to switch between DMICs by
using "dmic-gpios" property.
Refer to this one as an example,
commit b7a742cff3f6 ("ASoC: AMD: Use mixer control to switch between DMICs")
Signed-off-by: Ajye Huang
---
sound/so
Add a property "dmic-gpios" for switching between two MICs.
Signed-off-by: Ajye Huang
---
.../bindings/sound/google,sc7180-trogdor.yaml | 58 +++
1 file changed, 58 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
b/Doc
Note:
- The patch is made by the collaboration of
Ajye Huang
Cheng-Yi Chiang
Changes from v1 to v2:
- Ducumentation: Modify the dimc-gpios property description and examples.
- Machine driver:
- Remove "qcom,sc7180-sndcard-rt5682-m98357-2mic" compatible
- See gpio proper
On Mon, Oct 12, 2020 at 9:50 PM Mark Brown wrote:
>
> On Sat, Oct 10, 2020 at 12:07:54AM +0800, Ajye Huang wrote:
> > On Fri, Oct 9, 2020 at 9:52 PM Mark Brown wrote:
> > > On Mon, Sep 28, 2020 at 02:37:43PM +0800, Ajye Huang wrote:
>
> > > > Add compatibl
On Fri, Oct 9, 2020 at 9:52 PM Mark Brown wrote:
>
> On Mon, Sep 28, 2020 at 02:37:43PM +0800, Ajye Huang wrote:
> > Add compatible "qcom,sc7180-sndcard-rt5682-m98357-2mic"
> > for 2mic case.
>
> This doesn't apply against current code, please check and rese
collaboration of
Ajye Huang
Cheng-Yi Chiang
Thanks for the review!
Ajye Huang (2):
ASoC: qcom: dt-bindings: Modify sc7180 machine bindings
ASoC: qcom: sc7180: Modify machine driver for 2mic
.../bindings/sound/qcom,sc7180.yaml | 64 ++-
sound/soc/qcom/sc7180.c
In addition, having mixer control to switch between DMICs for
"qcom,sc7180-sndcard-rt5682-m98357-2mic" 2mic case.
Refer to this one as an example,
commit b7a742cff3f6 ("ASoC: AMD: Use mixer control to switch between DMICs")
Signed-off-by: Ajye Huang
---
This patch depends
Add compatible "qcom,sc7180-sndcard-rt5682-m98357-2mic"
for 2mic case.
Signed-off-by: Ajye Huang
---
This patch depends on this patch series
https://patchwork.kernel.org/patch/11773221/ .
.../bindings/sound/qcom,sc7180.yaml | 64 ++-
1 file changed, 63
29 matches
Mail list logo
