RE: [PATCH v2 0/7] perf arm-spe: Enable timestamp

2021-04-06 Thread Al Grant
> -Original Message- > From: Leo Yan > Sent: 03 April 2021 08:24 > To: Arnaldo Carvalho de Melo ; John Garry > ; Will Deacon ; Mathieu Poirier > ; James Clark ; Al Grant > ; Peter Zijlstra ; Ingo Molnar > ; Mark Rutland ; Alexander > Shishkin ; Jiri Ols

RE: [PATCH V3 14/14] coresight: etm-perf: Add support for trace buffer format

2021-01-27 Thread Al Grant
> > +/* CoreSight PMU AUX buffer formats */ > > +#define PERF_AUX_FLAG_CORESIGHT_FORMAT_CORESIGHT 0x /* > Default for backward compatibility */ > > +#define PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW 0x0100 /* > Raw format of the source */ > > Would CORESIGHT_FORMAT_ETR / CORESIGHT_FORMAT_TR

RE: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Al Grant
> From: Suzuki K Poulose > On 1/19/21 9:51 AM, Sai Prakash Ranjan wrote: > > Hi Al, > > > > On 2021-01-19 14:06, Al Grant wrote: > >> Hi Sai, > >> > >>> From: saiprakash.ranjan=codeaurora@mg.codeaurora.org > >>> Hi Mathieu,

RE: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Al Grant
Hi Sai, > From: saiprakash.ranjan=codeaurora@mg.codeaurora.org > Hi Mathieu, > > On 2021-01-19 01:53, Mathieu Poirier wrote: > > On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan wrote: > >> Hello Mathieu, Suzuki > >> > >> On 2020-10-15 21:32, Mathieu Poirier wrote: > >> > On Thu,

RE: [PATCH v2] drivers/perf: Enable PID_IN_CONTEXTIDR with SPE

2021-01-07 Thread Al Grant
> From: Mark Rutland > Sent: 06 January 2021 10:24 > To: James Clark > Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > perf-us...@vger.kernel.org; w...@kernel.org; leo....@linaro.org; Al Grant > ; John Garry ; Suzuki Poulose > ; Mathie

[PATCH] perf inject: correct event attribute sizes

2020-11-24 Thread Al Grant
When perf inject reads a perf.data file from an older version of perf, it writes event attributes into the output with the original size field, but lays them out as if they had the size currently used. Readers see a corrupt file. Update the size field to match the layout. Signed-off-by: Al Grant

[tip: perf/urgent] perf: correct SNOOPX field offset

2020-10-19 Thread tip-bot2 for Al Grant
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: f3d301c1f2f5676465cdf3259737ea19cc82731f Gitweb: https://git.kernel.org/tip/f3d301c1f2f5676465cdf3259737ea19cc82731f Author:Al Grant AuthorDate:Mon, 21 Sep 2020 21:46:37 +01:00 Committer

[tip: perf/urgent] perf: correct SNOOPX field offset

2020-10-19 Thread tip-bot2 for Al Grant
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 04de3266214453deb5f1d7849a66313e351af8cc Gitweb: https://git.kernel.org/tip/04de3266214453deb5f1d7849a66313e351af8cc Author:Al Grant AuthorDate:Mon, 21 Sep 2020 21:46:37 +01:00 Committer

[PATCH] perf: correct SNOOPX field offset

2020-09-21 Thread Al Grant
tools: Add support for printing new mem_info encodings") Signed-off-by: Al Grant Reviewed-by: Andi Kleen --- include/uapi/linux/perf_event.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index 07

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Al Grant
On 01/09/2020 16:02, Arnaldo Carvalho de Melo wrote: Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote

RE: [RFC PATCH v2] coresight: etm4x: Modify core-commit of cpu to avoid the overflow of HiSilicon ETM

2020-08-28 Thread Al Grant
Hi Mathieu and CS maintainers, > Hi Liu, > > On Wed, Aug 19, 2020 at 04:06:37PM +0800, Qi Liu wrote: > > When too much trace information is generated on-chip, the ETM will > > overflow, and cause data loss. This is a common phenomenon on ETM > > devices. > > > > But sometimes we do not want to lo

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Al Grant
On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE

Re: [PATCH] perf inject: correct event attribute sizes

2020-08-26 Thread Al Grant
On 26/08/2020 12:27, Mark Rutland wrote: On Wed, Aug 26, 2020 at 10:42:04AM +0100, Al Grant wrote: When perf inject reads a perf.data file from an older version of perf, it writes event attributes into the output with the original size field, but lays them out as if they had the size currently

[PATCH] perf inject: correct event attribute sizes

2020-08-26 Thread Al Grant
Signed-off-by: Al Grant tools/perf/util/header.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 9cf4efdcbbbd..762eb94bd532 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -3326,6 +3326,14 @@ int

[PATCH] perf: correct SNOOPX field offset

2020-08-24 Thread Al Grant
perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE offsets were both 37. These are distinct fields, and the bitfield layout in perf_mem_data_src confirms that SNOOPX should be at offset 38. From: Al Grant include/uapi/linux

RE: Question: perf dso support for /proc/kallsyms

2018-11-02 Thread Al Grant
> root@debian:~/coresight_test# perf buildid-list > 0242d9154c78df1d8fe1d0512c36a236d0861a18 [kernel.kallsyms] > b8c89e8ba41a2ea486c66a50c29c60d38c34a759 /root/coresight_test/main > 26b12a9d1a54ed2b0478cb0203435b76aabab3fb /usr/lib/aarch64-linux-gnu/ld- > 2.27.so > 8fca7ed524c9469b065af83bc8a529fe7

RE: Question: perf dso support for /proc/kallsyms

2018-11-02 Thread Al Grant
> Now I still don't understand how the dso/map support "/proc/kallsyms" and > have no idea to fix this issue, though I spent some time to look into it. The way this is supported is that at record time, pseudo mmap records are created for the kernel. But depending on permissions these might not get

RE: [PATCH V2 3/6] stm class: provision for statically assigned masterIDs

2016-02-08 Thread Al Grant
> Mike did write "master IDs are hardwired to individual cores and core security > states", which make assignment for one platform very static. > On the flip side those will change from one system to another. It depends on your perspective. From the perspective of a userspace process not pinned t

RE: [PATCH v4 00/22] perf: Add infrastructure and support for Intel PT

2014-09-08 Thread Al Grant
> Ok, in perf the trace configuration would be part of 'session' > information, so the way the tracing was configured by userspace will > be > saved to the resulting trace file (perf.data) by the userspace. > We have that with Intel PT as well. For ETM, in principle, those aspects of the ETM confi

RE: [PATCH 07/10 v3] coresight-etm: add CoreSight ETM/PTM driver

2014-08-08 Thread Al Grant
; Cc: mathieu.poir...@linaro.org; a...@android.com; > john.stu...@linaro.org; prat...@codeaurora.org; varsh...@ti.com; Al > Grant; jonas.svennebr...@avagotech.com; james.k...@linaro.org; > panchaxari.prasannamur...@linaro.org; marcin.jabr...@gmail.com; > r.sengu...@samsung.com; robbelibob

RE: [PATCH 0/9 v2] Coresight framework and drivers

2014-07-01 Thread Al Grant
> This set is addressing comments received after the May 30th > submission[1]. More specifically: > > .All drivers have been converted to use the AMBA bus > interface. > .Debugfs entries are now created with a macro. > .A header file was created for the ETM driver to allow > for the reuse of con