Re: [PATCH v5 0/4] man2: udpate mm/userfaultfd manpages to latest

2021-04-01 Thread Alejandro Colomar (man-pages)
tfd.2: Add UFFD_FEATURE_THREAD_ID docs ioctl_userfaultfd.2: Add write-protect mode docs I applied all 4 patches (with a few minor fixes to 1/4 and 4/4 (cosmetic fixes; some of them about the 80-col right margin)): <https://github.com/alejandro-colomar/man-pages/tree/eb8f2001d493d458d0

Re: [PATCH v4 4/4] ioctl_userfaultfd.2: Add write-protect mode docs

2021-03-29 Thread Alejandro Colomar (man-pages)
Hi Peter, On 3/29/21 11:51 PM, Peter Xu wrote: > On Thu, Mar 25, 2021 at 10:32:20PM +0100, Alejandro Colomar (man-pages) wrote: >>>>> +.TP >>>>> +.B ENOENT >>>>> +The range specified in >>>>> +.I range >>>>> +is not

Re: [PATCH] mremap.2: MREMAP_DONTUNMAP to reflect to supported mappings

2021-03-25 Thread Alejandro Colomar (man-pages)
Hello Brian, Is this already merged in Linux? I guess not, as I've seen a patch of yous for the kernel, right? Thanks, Alex On 3/23/21 7:25 PM, Brian Geffon wrote: mremap(2) now supports MREMAP_DONTUNMAP with mapping types other than private anonymous. Signed-off-by: Brian Geffon --- m

Re: [PATCH v4 4/4] ioctl_userfaultfd.2: Add write-protect mode docs

2021-03-25 Thread Alejandro Colomar (man-pages)
Hi Peter, On 3/23/21 8:16 PM, Peter Xu wrote: On Tue, Mar 23, 2021 at 07:11:04PM +0100, Alejandro Colomar (man-pages) wrote: +.TP +.B UFFDIO_COPY_MODE_WP +Copy the page with read-only permission. +This allows the user to trap the next write to the page, +which will block and generate another

Re: [PATCH v4 2/4] userfaultfd.2: Add write-protect mode

2021-03-23 Thread Alejandro Colomar (man-pages)
Hi Peter, Please see a few more comments below. Thanks, Alex On 3/22/21 11:08 PM, Peter Xu wrote: Write-protect mode is supported starting from Linux 5.7. Signed-off-by: Peter Xu --- man2/userfaultfd.2 | 104 - 1 file changed, 102 insertions(+)

Re: [PATCH v4 4/4] ioctl_userfaultfd.2: Add write-protect mode docs

2021-03-23 Thread Alejandro Colomar (man-pages)
Hi Peter, Please see a few comments below. Thanks, Alex On 3/22/21 11:08 PM, Peter Xu wrote: Userfaultfd write-protect mode is supported starting from Linux 5.7. Signed-off-by: Peter Xu --- man2/ioctl_userfaultfd.2 | 84 ++-- 1 file changed, 81 inserti

Re: [PATCH v3 4/4] ioctl_userfaultfd.2: Add write-protect mode docs

2021-03-19 Thread Alejandro Colomar (man-pages)
Hi Peter, A few more comments below. Thanks, Alex On 3/10/21 11:23 PM, Peter Xu wrote: > Userfaultfd write-protect mode is supported starting from Linux 5.7. > > Signed-off-by: Peter Xu > --- > man2/ioctl_userfaultfd.2 | 81 ++-- > 1 file changed, 78 inser

Re: [PATCH v3 2/4] userfaultfd.2: Add write-protect mode

2021-03-19 Thread Alejandro Colomar (man-pages)
Hi Peter, Please, see a few minor comments below. Thanks, Alex On 3/10/21 11:22 PM, Peter Xu wrote: > Write-protect mode is supported starting from Linux 5.7. > > Signed-off-by: Peter Xu > --- > man2/userfaultfd.2 | 103 - > 1 file changed, 101 ins

Re: AW: [RFC v3 04/17] arch_prctl.2: SYNOPSIS: Remove unused includes

2021-03-16 Thread Alejandro Colomar (man-pages)
Hi Walter, On 3/15/21 7:00 PM, Walter Harms wrote: I have learned the other way around: #include Is a general system header to use that may include the asm/prctrl.h what should never be included by userspace programms. Are you sure that includes ? user@debian:/usr/include$ grep -rn '\bARCH

Re: [PATCH v2 2/4] userfaultfd.2: Add write-protect mode

2021-03-10 Thread Alejandro Colomar (man-pages)
Hi Peter, Please see a few comments below. Thanks, Alex On 3/4/21 5:31 PM, Peter Xu wrote: Write-protect mode is supported starting from Linux 5.7. Signed-off-by: Peter Xu --- man2/userfaultfd.2 | 98 +- 1 file changed, 96 insertions(+), 2 dele

Re: [RFC v4] copy_file_range.2: Update cross-filesystem support for 5.12

2021-03-04 Thread Alejandro Colomar (man-pages)
Hi Darrick, On 3/4/21 6:13 PM, Darrick J. Wong wrote: On Thu, Mar 04, 2021 at 10:38:07AM +0100, Alejandro Colomar wrote: +However, on some virtual filesystems, +the call failed to copy, while still reporting success. ...success, or merely a short copy? Okay. (The rest looks reasonable (a

Re: [PATCH 1/4] userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs

2021-03-04 Thread Alejandro Colomar (man-pages)
Hi Peter, On 3/4/21 4:50 PM, Peter Xu wrote: On Thu, Mar 04, 2021 at 10:22:18AM +0100, Alejandro Colomar (man-pages) wrote: +.BR UFFD_FEATURE_THREAD_ID This should use [.B] and not [.BR]. .BR is for alternate Bold and Roman. .B is for bold. (There are more appearances of this in the other

Re: [PATCH 1/4] userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs

2021-03-04 Thread Alejandro Colomar (man-pages)
Hello Peter, On 3/4/21 2:59 AM, Peter Xu wrote: UFFD_FEATURE_THREAD_ID is supported since Linux 4.14. Signed-off-by: Peter Xu --- man2/userfaultfd.2 | 12 1 file changed, 12 insertions(+) diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2 index e7dc9f813..2d14effc6 100644 --

Re: [PATCH] mount_setattr.2: New manual page documenting the mount_setattr() system call

2021-03-01 Thread Alejandro Colomar (man-pages)
On 3/1/21 10:34 AM, Christian Brauner wrote: Signed-off-by: Christian Brauner Hi Christian, I commented about some formatting issues. I'm sorry I don't have time right now to review the contents of the page. Thanks, Alex --- man2/mount_setattr.2 | 1071 +++

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-27 Thread Alejandro Colomar (man-pages)
Hi Amir, On 2/27/21 6:41 AM, Amir Goldstein wrote: On Sat, Feb 27, 2021 at 12:19 AM Alejandro Colomar (man-pages) On 2/24/21 5:10 PM, Amir Goldstein wrote: On Wed, Feb 24, 2021 at 4:22 PM Luis Henriques wrote: .TP +.B EOPNOTSUPP I'll add the kernel version here: .BR EOPNO

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-26 Thread Alejandro Colomar (man-pages)
Hello Amir, Luis, On 2/24/21 5:10 PM, Amir Goldstein wrote: On Wed, Feb 24, 2021 at 4:22 PM Luis Henriques wrote: Update man-page with recent changes to this syscall. Signed-off-by: Luis Henriques --- Hi! Here's a suggestion for fixing the manpage for copy_file_range(). Note that I've ass

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-26 Thread Alejandro Colomar (man-pages)
Hello Jeff, On 2/26/21 2:59 PM, Jeff Layton wrote: Here's a link that should work. I'm probably breaking the rules a bit as a subscriber, but hopefully Jon won't mind too much. FWIW, I've found it to be worthwhile to subscribe to LWN if you're doing a lot of kernel development: https://lwn

Re: [RFC v2] execve.2: SYNOPSIS: Document both glibc wrapper and kernel sycalls

2021-02-26 Thread Alejandro Colomar (man-pages)
Hi Michael, Okay, after a few days of thinking, I'm not sure about what to do in some cases. But I think we agree to use syscall(SYS_ ...) for syscalls with no wrapper (such as membarrier(2)). Is that right? I think it may be better to separate this into 2 sets of changes. 1) Document s

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-26 Thread Alejandro Colomar (man-pages)
Hello Amir, On 2/26/21 11:34 AM, Amir Goldstein wrote: Is this detailed enough? ;-) https://lwn.net/Articles/846403/ I'm sorry I can't read it yet: [ Subscription required The page you have tried to view (How useful should copy_file_range() be?) is currently available to LWN subscribers onl

Re: [PATCH] copy_file_range.2: Kernel v5.12 updates

2021-02-26 Thread Alejandro Colomar (man-pages)
Hello Luis, On 2/25/21 11:21 AM, Luis Henriques wrote: On Wed, Feb 24, 2021 at 06:10:45PM +0200, Amir Goldstein wrote: If it were me, I would provide all the details of the situation to Michael and ask him to write the best description for this section. Thanks Amir. Yeah, it's tricky. Suppo

Re: [RFC v2] execve.2: SYNOPSIS: Document both glibc wrapper and kernel sycalls

2021-02-19 Thread Alejandro Colomar (man-pages)
Hi Michael, On 2/19/21 1:39 PM, Michael Kerrisk (man-pages) wrote: Hey Alex, On 2/18/21 4:13 PM, Alejandro Colomar wrote: Until now, the manual pages have (usually) documented only either the glibc (or another library) wrapper for a syscall, or the kernel syscall (this only when there's not a

Re: [RFC] execve.2: SYNOPSIS: Document both glibc wrapper and kernel sycalls

2021-02-18 Thread Alejandro Colomar (man-pages)
Hi Micahel, On 2/18/21 1:27 PM, Michael Kerrisk (man-pages) wrote: Hi Alex, On 2/14/21 2:39 PM, Alejandro Colomar wrote: Until now, the manual pages have (usually) documented only either the glibc (or another library) wrapper for a syscall, or the raw syscall (this only when there's not a wrap

Re: outb.2: What to do with prototypes?

2021-02-04 Thread Alejandro Colomar (man-pages)
On 2/4/21 1:59 PM, Alejandro Colomar (man-pages) wrote: > Hi Michael, > > What would you do with the prototypes in outb.2? > They are different in glibc and the kernel. > However, since these are functions to be called mostly withing the > kernel, the kernel prototype is more

Re: [PATCH -V9 2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

2021-01-21 Thread Alejandro Colomar (man-pages)
Hi Huang Ying, On 1/20/21 7:12 AM, Huang Ying wrote: > Signed-off-by: "Huang, Ying" > Cc: "Alejandro Colomar" Sorry, for the confusion. I have a different email for reading lists. I use alx.manpages@ for everything, and alx.mailinglists@ just for reading lists, but sometimes, when I answer emai

Ping: [PATCH] futex: Change 'utime' parameter to be 'const ... *'

2021-01-17 Thread Alejandro Colomar (man-pages)
Ping! On 12/10/20 6:36 PM, Alejandro Colomar (man-pages) wrote: > Hi Thomas & Ingo, > > I tested the changes. Everything's OK. > > Cheers, > > Alex > > $ uname -a > Linux debian 5.10.0-rc7+alx3+ #4 SMP Thu Dec 10 18:05:03 CET 2020 x86_64 > GNU/Li

Re: [PATCH] getcpu.2: Document glibc wrapper instead of kernel syscall

2021-01-02 Thread Alejandro Colomar (man-pages)
On 1/2/21 9:41 AM, Michael Kerrisk (man-pages) wrote: > Hi Alex, > > On 12/30/20 10:41 PM, Alejandro Colomar wrote: >> The glibc wrapper doesn't provide the third argument. >> Simplify the info about the (unused) kernel parameter >> to the minimum that is useful. >> >> kernels <=2.6.23 are EOL

Re: [PATCH v3] close_range.2: new page documenting close_range(2)

2020-12-21 Thread Alejandro Colomar (man-pages)
Hi Stephen, On 12/21/20 8:24 PM, Stephen Kitt wrote: > Hi Alex, > > On Sat, 19 Dec 2020 15:00:00 +0100, "Alejandro Colomar (man-pages)" > wrote: >> On 12/18/20 5:58 PM, Stephen Kitt wrote: > [...] >>> +This program executes the command given on its c

Re: [PATCH v3] close_range.2: new page documenting close_range(2)

2020-12-21 Thread Alejandro Colomar (man-pages)
On 12/20/20 11:00 PM, Stephen Kitt wrote: > Hi Alex, > > On Sat, 19 Dec 2020 15:00:00 +0100, "Alejandro Colomar (man-pages)" > wrote: >> Please see some comments below. >> It's looking good ;) > > Thanks for your review and patience! > >

Re: [PATCH v3] close_range.2: new page documenting close_range(2)

2020-12-19 Thread Alejandro Colomar (man-pages)
Hi Stephen, Please see some comments below. It's looking good ;) Thanks, Alex On 12/18/20 5:58 PM, Stephen Kitt wrote: > This documents close_range(2) based on information in > 278a5fbaed89dacd04e9d052f4594ffd0e0585de, > 60997c3d45d9a67daf01c56d805ae4fec37e0bd8, and > 582f1fb6b721facf04848d2ca5

Ping: [patch] close_range.2: new page documenting close_range(2)

2020-12-18 Thread Alejandro Colomar (man-pages)
Hi Stephen, Linux 5.10 has been recently released. Do you have any updates for this patch? Thanks, Alex On 12/12/20 6:58 PM, Alejandro Colomar (man-pages) wrote: > Hi Christian, > > Makes sense to me. > > Thanks, > > Alex > > On 12/12/20 1:14 PM, Christian Braun

Re: [Bug 210655] ptrace.2: documentation is incorrect about access checking threads in same thread group

2020-12-16 Thread Alejandro Colomar (man-pages)
[CC += Thomas, Ingo, Peter, Darren] Hi Oleg, On 12/16/20 3:33 AM, Jann Horn wrote: > On Wed, Dec 16, 2020 at 3:21 AM Ted Estes wrote: >> On 12/15/2020 6:01 PM, Jann Horn wrote: >>> On Wed, Dec 16, 2020 at 12:25 AM Alejandro Colomar (man-pages) >>> wrote: >>&

Re: [Bug 210655] ptrace.2: documentation is incorrect about access checking threads in same thread group

2020-12-15 Thread Alejandro Colomar (man-pages)
Hi Jann, On 12/16/20 12:07 AM, Jann Horn wrote: > Am Tue, Dec 15, 2020 at 06:01:25PM +0100 schrieb Alejandro Colomar > (man-pages): >> Hi, >> >> There's a bug report: https://bugzilla.kernel.org/show_bug.cgi?id=210655 >> >> [[ >> Under "Pt

Re: [Bug 210655] ptrace.2: documentation is incorrect about access checking threads in same thread group

2020-12-15 Thread Alejandro Colomar (man-pages)
On 12/16/20 12:23 AM, Alejandro Colomar (man-pages) wrote: > Hi Jann, > > On 12/16/20 12:07 AM, Jann Horn wrote: >> Am Tue, Dec 15, 2020 at 06:01:25PM +0100 schrieb Alejandro Colomar >> (man-pages): >>> Hi, >>> >>> There's a bug repor

Re: [Bug 210655] ptrace.2: documentation is incorrect about access checking threads in same thread group

2020-12-15 Thread Alejandro Colomar (man-pages)
[CC += Andreas, Linus, Roland, Markus; fixed Oleg] On 12/15/20 7:34 PM, Alejandro Colomar (man-pages) wrote: > Hi Ted, > > On 12/15/20 7:31 PM, Ted Estes wrote: >> Per my research on the topic, the error is in the manual page. The >> behavior of ptrace(2) was intentionall

Re: [Bug 210655] ptrace.2: documentation is incorrect about access checking threads in same thread group

2020-12-15 Thread Alejandro Colomar (man-pages)
> > I found this email thread on the subject: > https://lkml.org/lkml/2006/8/31/241 Thank you for all the details and links! I'll fix the page. Thanks, Alex > > Thank you. > --Ted Estes > > On 12/15/2020 11:01 AM, Alejandro Colomar (man-pages) wrote:

[Bug 210655] ptrace.2: documentation is incorrect about access checking threads in same thread group

2020-12-15 Thread Alejandro Colomar (man-pages)
Hi, There's a bug report: https://bugzilla.kernel.org/show_bug.cgi?id=210655 [[ Under "Ptrace access mode checking", the documentation states: "1. If the calling thread and the target thread are in the same thread group, access is always allowed." This is incorrect. A thread may never attach t

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-12 Thread Alejandro Colomar (man-pages)
Hi Christian, Makes sense to me. Thanks, Alex On 12/12/20 1:14 PM, Christian Brauner wrote: > On Thu, Dec 10, 2020 at 03:36:42PM +0100, Alejandro Colomar (man-pages) wrote: >> Hi Christian, > > Hi Alex, > >> >> Thanks for confirming that behavior. Seems rea

Re: [PATCH] futex: Change 'utime' parameter to be 'const ... *'

2020-12-10 Thread Alejandro Colomar (man-pages)
Hi Thomas & Ingo, I tested the changes. Everything's OK. Cheers, Alex $ uname -a Linux debian 5.10.0-rc7+alx3+ #4 SMP Thu Dec 10 18:05:03 CET 2020 x86_64 GNU/Linux .../linux/tools/testing/selftests/futex$ sudo ./run.sh [sudo] password for user: TAP version 13 1..1 # futex_requeue_pi: Test req

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-10 Thread Alejandro Colomar (man-pages)
these errors are not normally reported against the first write which exceeds the available storage space, but instead against a subsequent write(2), fsync(2), or close(). Thanks, Alex On 12/9/20 11:56 AM, Christian Brauner wrote: > On Wed, Dec 09,

Re: [PATCH v2] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Alejandro Colomar (man-pages)
Hi Stephen, A few more comments below. Michael, please have a look at them too. Christian, do you have any program that you used to test the syscall that could be added as an example program to the page? Thanks, Alex On 12/9/20 11:00 PM, Stephen Kitt wrote: > This documents close_range(2) bas

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Alejandro Colomar (man-pages)
Hey Christian, I have a question for you below. Thanks, Alex On 12/9/20 10:58 AM, Christian Brauner wrote: > On Tue, Dec 08, 2020 at 10:51:33PM +0100, Stephen Kitt wrote: >> This documents close_range(2) based on information in >> 278a5fbaed89dacd04e9d052f4594ffd0e0585de and >> 60997c3d45d9a67d

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Alejandro Colomar (man-pages)
Hello Stephen and Michael, Thanks for the page! A few more comments below. Thanks, Alex On 12/9/20 9:50 AM, Michael Kerrisk (man-pages) wrote: > Hello Stephen > > Thank you for writing this page! Some comments/questions below. > > On Tue, 8 Dec 2020 at 22:51, Stephen Kitt wrote: >> >> This

Re: [PATCH -V7 2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

2020-12-04 Thread Alejandro Colomar (man-pages)
Hi Huang Ying, Please, see a few fixes below. Thanks, Alex On 12/4/20 10:15 AM, Huang Ying wrote: > Signed-off-by: "Huang, Ying" > --- > man2/set_mempolicy.2 | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2 > index 68011eecb

Re: [PATCH] spu_create.2: Clarify that one of the prototypes is the current one

2020-11-27 Thread Alejandro Colomar (man-pages)
Hi Michael, On 11/27/20 11:43 AM, Michael Kerrisk (man-pages) wrote: > Hi ALex, > > On 11/26/20 7:32 PM, Alejandro Colomar wrote: >> The current Linux kernel only provides a definition of 'spu_create()'. >> It has 4 parameters, the last being 'int neighbor_fd'. >> >> Before Linux 2.6.23, there wa

set_thread_area.2: csky architecture undocumented

2020-11-23 Thread Alejandro Colomar (man-pages)
Hi Michael, SYNOPSIS #include #if defined __i386__ || defined __x86_64__ # include int get_thread_area(struct user_desc *u_info); int set_thread_area(struct user_desc *u_info); #elif defined __m68k__ int get_thread_area(void); int set_t

Re: [PATCH] lseek.2: SYNOPSIS: Use correct types

2020-11-22 Thread Alejandro Colomar (man-pages)
Hi Florian, On 11/22/20 1:43 PM, Florian Weimer wrote: > * Alejandro Colomar: > >> The Linux kernel uses 'unsigned int' instead of 'int' for 'fd' and >> 'whence'. As glibc provides no wrapper, use the same types the >> kernel uses. > > lseek is a POSIX interface, and glibc provides it. POSIX u

Re: [PATCH] lseek.2: SYNOPSIS: Use correct types

2020-11-21 Thread Alejandro Colomar (man-pages)
Hi Michael, I'm a bit lost in all the *lseek* pages. You had a good read some months ago, so you may know it better. I don't know which of those functions come from the kernel, and which come from glibc (if any). In the kernel I only found the lseek, llseek, and 32_llseek (as you can see in the pa

Re: [PATCH v5] perf_event_open.2: Update man page with recent changes

2020-11-17 Thread Alejandro Colomar (man-pages)
On 11/17/20 8:37 AM, Namhyung Kim wrote: > From: Namhyung Kim > > There are lots of changes as usual. I've tried to fill some missing > bits in the man page but it'd be nice if you could take a look and put > more info there. > > Signed-off-by: Namhyung Kim > [alx: ffix + tfix] > Cowritten-

Re: [PATCH v4] perf_event_open.2: Update man page with recent changes

2020-11-16 Thread Alejandro Colomar (man-pages)
On 11/16/20 5:17 PM, Namhyung Kim wrote: > Hello Alex, > > On Sat, Nov 14, 2020 at 6:28 AM Alejandro Colomar > wrote: >> >> From: Namhyung Kim >> >> There are lots of changes as usual. I've tried to fill some missing >> bits in the man page but it'd be nice if you could take a look and put >>