ock should go after cutter '---' (see below) line...
>
> > Fixes: 56a1485b102e (i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver)
> > Signed-off-by: Tali Perry
Reviewed-by: Alex Qiu
Tested-by: Alex Qiu
> > ---
>
> ...here.
>
> > drivers/i2c/busses/i2c-npcm7x
Jason pointed me to the patch
https://github.com/torvalds/linux/commit/294f69e662d1570703e9b56e95be37a9fd3afba5.
Nvm...
- Alex Qiu
On Tue, Oct 13, 2020 at 11:18 AM Alex Qiu wrote:
>
> (Intercepting the email thread...)
>
> Hi Grant,
>
> Looks like you made a typo in your p
(Intercepting the email thread...)
Hi Grant,
Looks like you made a typo in your patch:
> + case raa_dmpvr2_2rail_nontc:
> + info->func[0] &= ~PMBUS_HAVE_TEMP;
> + info->func[1] &= ~PMBUS_HAVE_TEMP;
> + fallthrough;
Did you mean "/* fallthrough */" instead of "fallthrough;"?
- Alex Qiu
o
Hi Andy,
That makes perfect sense. We may keep it downstream to unblock our own
work if it's not accepted upstream. Thanks for your review!
- Alex Qiu
ices are not known
at compile time, but at runtime. We start with 100 kHz, and go 400 kHz
if applicable. FYI, we are using 5.1 kernel, however I don't know much
about DT overlay.
Thx.
-Alex Qiu
d-by: Avi Fishman
>
> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
> Reviewed-by: Joel Stanley
Reviewed-by: Alex Qiu
>
> Cheers,
>
> Joel
>
> > ---
> > drivers/i2c/busses/i2c-npcm7xx.c | 8 ++--
> > 1 file
6 matches
Mail list logo
