[PATCH 13/16] net: phy: adin: implement Energy Detect Powerdown mode

2019-08-05 Thread Alexandru Ardelean
The ADIN PHYs support Energy Detect Powerdown mode, which puts the PHY into a low power mode when there is no signal on the wire (typically cable unplugged). This behavior is enabled by default, but can be disabled via device property. Signed-off-by: Alexandru Ardelean --- drivers/net/phy

[PATCH 10/16] net: phy: adin: add EEE translation layer for Clause 22

2019-08-05 Thread Alexandru Ardelean
nism, a translation table is required to convert these addresses. For Clause 45, this is not needed; the addresses are available as specified by IEEE. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 61 -- 1 file changed, 59 insertions(+), 2 delet

[PATCH 12/16] net: phy: adin: read EEE setting from device-tree

2019-08-05 Thread Alexandru Ardelean
advertisement register. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c index 476a81ce9341..cf99ccacfeeb 100644 --- a/drivers/net/phy/adin.c +++ b/drivers

[PATCH 15/16] net: phy: adin: add ethtool get_stats support

2019-08-05 Thread Alexandru Ardelean
spec). Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 108 + 1 file changed, 108 insertions(+) diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c index a1f3456a8504..04896547dac8 100644 --- a/drivers/net/phy/adin.c +++ b/drivers

[PATCH 11/16] net: phy: adin: PHY reset mechanisms

2019-08-05 Thread Alexandru Ardelean
e entire PHY subsystem during probe. During PHY HW init (phy_hw_init() logic) the PHY core regs will be reset again via BMCR_RESET. This will also need to happen during a PM resume. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 82 ++ 1 file

[PATCH 03/16] net: phy: adin: add support for interrupts

2019-08-05 Thread Alexandru Ardelean
This change adds support for enabling PHY interrupts that can be used by the PHY framework to get signal for link/speed/auto-negotiation changes. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 44 ++ 1 file changed, 44 insertions(+) diff

[PATCH 14/16] net: phy: adin: make sure down-speed auto-neg is enabled

2019-08-05 Thread Alexandru Ardelean
Down-speed auto-negotiation may not always be enabled, in which case the PHY won't down-shift to 100 or 10 during auto-negotiation. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/phy

[PATCH 07/16] net: phy: adin: make RGMII internal delays configurable

2019-08-05 Thread Alexandru Ardelean
The internal delays for the RGMII are configurable for both RX & TX. This change adds support for configuring them via device-tree (or ACPI). Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 37 + 1 file changed, 37 insertions(+) diff -

[PATCH 01/16] net: phy: adin: add support for Analog Devices PHYs

2019-08-05 Thread Alexandru Ardelean
data-sheets/ADIN1200.pdf Signed-off-by: Alexandru Ardelean --- MAINTAINERS | 7 + drivers/net/phy/Kconfig | 9 ++ drivers/net/phy/Makefile | 1 + drivers/net/phy/adin.c | 59 4 files changed, 76 insertions(+) create mode 100644 dri

[PATCH 16/16] dt-bindings: net: add bindings for ADIN PHY driver

2019-08-05 Thread Alexandru Ardelean
This change adds bindings for the Analog Devices ADIN PHY driver, detailing all the properties implemented by the driver. Signed-off-by: Alexandru Ardelean --- .../devicetree/bindings/net/adi,adin.yaml | 93 +++ MAINTAINERS | 2 + include

[PATCH 09/16] net: phy: adin: add support MDI/MDIX/Auto-MDI selection

2019-08-05 Thread Alexandru Ardelean
3. MDI preferred & ! Pair01Swapped == MDIX 4. MDIX preferred & ! Pair01Swapped == MDI The preferred MDI/MDIX mode is not configured via SW, but can be configured via HW pins. Note that the `Pair01Swapped` is the Green-Yellow physical pairs. Signed-off-by: Alexandru Ardelean --- driv

[PATCH 02/16] net: phy: adin: hook genphy_{suspend,resume} into the driver

2019-08-05 Thread Alexandru Ardelean
The chip supports standard suspend/resume via BMCR reg. Hook these functions into the `adin` driver. Signed-off-by: Alexandru Ardelean --- drivers/net/phy/adin.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c index 6a610d4563c3

[PATCH 00/16] net: phy: adin: add support for Analog Devices PHYs

2019-08-05 Thread Alexandru Ardelean
ttps://www.analog.com/media/en/technical-documentation/data-sheets/ADIN1200.pdf Signed-off-by: Alexandru Ardelean Alexandru Ardelean (16): net: phy: adin: add support for Analog Devices PHYs net: phy: adin: hook genphy_{suspend,resume} into the driver net: phy: adin: add support for interrupts net:

[PATCH 0/3][V4] iio: imu: Add support for the ADIS16460 IMU

2019-07-23 Thread Alexandru Ardelean
cs_change_delay[_usecs]` Alexandru Ardelean (3): iio: imu: adis: Add support for SPI transfer cs_change_delay iio: imu: Add support for the ADIS16460 IMU dt-bindings: iio: imu: add bindings for ADIS16460 .../bindings/iio/imu/adi,adis16460.yaml | 53

[PATCH 1/3][V4] iio: imu: adis: Add support for SPI transfer cs_change_delay

2019-07-23 Thread Alexandru Ardelean
the `cs_change_delay` functionality from the SPI subsystem. Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis.c | 12 include/linux/iio/imu/adis.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu

[PATCH 3/3][V4] dt-bindings: iio: imu: add bindings for ADIS16460

2019-07-23 Thread Alexandru Ardelean
This change adds device-tree bindings for the ADIS16460. Reviewed-by: Rob Herring Signed-off-by: Alexandru Ardelean --- .../bindings/iio/imu/adi,adis16460.yaml | 53 +++ MAINTAINERS | 1 + 2 files changed, 54 insertions(+) create mode

[PATCH 2/3][V4] iio: imu: Add support for the ADIS16460 IMU

2019-07-23 Thread Alexandru Ardelean
fine for those other chips; they haven't been tested with lower CS change delays yet. Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adis16460.pdf Signed-off-by: Dragos Bogdan Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- MAINTAI

Re: [PATCH 1/4][V3] spi: Add optional stall delay between cs_change transfers

2019-07-22 Thread Alexandru Ardelean
On Mon, Jul 22, 2019 at 8:42 PM Mark Brown wrote: > > On Mon, Jul 22, 2019 at 03:47:44PM +0300, Alexandru Ardelean wrote: > > Some devices like the ADIS16460 IMU require a longer period between > > transfers, i.e. between when the CS is de-asserted and re-asserted. The > &g

[PATCH 0/4][V3] iio: imu: Add support for the ADIS16460 IMU

2019-07-22 Thread Alexandru Ardelean
adjusted to new `cs_change_delay[_usecs]` Alexandru Ardelean (4): spi: Add optional stall delay between cs_change transfers iio: imu: adis: Add support for SPI transfer cs_change_delay iio: imu: Add support for the ADIS16460 IMU dt-bindings: iio: imu: add bindings for ADIS16460 .../bindings/iio/imu/ad

[PATCH 3/4][V3] iio: imu: Add support for the ADIS16460 IMU

2019-07-22 Thread Alexandru Ardelean
fine for those other chips; they haven't been tested with lower CS change delays yet. Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adis16460.pdf Signed-off-by: Dragos Bogdan Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- MAINTAI

[PATCH 4/4][V3] dt-bindings: iio: imu: add bindings for ADIS16460

2019-07-22 Thread Alexandru Ardelean
This change adds device-tree bindings for the ADIS16460. Reviewed-by: Rob Herring Signed-off-by: Alexandru Ardelean --- .../bindings/iio/imu/adi,adis16460.yaml | 53 +++ MAINTAINERS | 1 + 2 files changed, 54 insertions(+) create mode

[PATCH 2/4][V3] iio: imu: adis: Add support for SPI transfer cs_change_delay

2019-07-22 Thread Alexandru Ardelean
the `cs_change_delay` functionality in SPI. Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis.c | 6 ++ include/linux/iio/imu/adis.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c index c771ae6803a9

[PATCH 1/4][V3] spi: Add optional stall delay between cs_change transfers

2019-07-22 Thread Alexandru Ardelean
is case it is unspecified. Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- drivers/spi/spi.c | 3 ++- include/linux/spi/spi.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 5e75944ad5d1..fe7fa7fb25c5

[PATCH 0/4][V2] iio: imu: Add support for the ADIS16460 IMU

2019-07-17 Thread Alexandru Ardelean
r ADIS lib: * renamed `stall_delay` -> `cs_change_delay` * removed some assignments of `cs_change_delay` where `cs_change` is not set * for ADIS16460 driver: * fixed license * adjusted to new `cs_change_delay[_usecs]` Alexandru Ardelean (4): drivers: spi: core: Add optional stall

[PATCH 4/4][V2] dt-bindings: iio: imu: add bindings for ADIS16460

2019-07-17 Thread Alexandru Ardelean
This change adds device-tree bindings for the ADIS16460. Signed-off-by: Alexandru Ardelean --- .../bindings/iio/imu/adi,adis16460.yaml | 53 +++ MAINTAINERS | 1 + 2 files changed, 54 insertions(+) create mode 100644 Documentation

[PATCH 2/4][V2] iio: imu: adis: Add support for SPI transfer cs_change_delay_usecs

2019-07-17 Thread Alexandru Ardelean
the `cs_change_stall_delay_us` functionality in SPI. Not all transfers set `cs_change` to 1. Only those that do, have the `cs_change_delay` assigned. Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis.c | 6 ++ include/linux/iio/imu/adis.h | 2 ++ 2

[PATCH 3/4][V2] iio: imu: Add support for the ADIS16460 IMU

2019-07-17 Thread Alexandru Ardelean
fine for those other chips; they haven't been tested with lower CS change delays yet. Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adis16460.pdf Signed-off-by: Dragos Bogdan Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- MAINTAI

[PATCH 1/4][V2] drivers: spi: core: Add optional delay between cs_change transfers

2019-07-17 Thread Alexandru Ardelean
Signed-off-by: Alexandru Ardelean --- drivers/spi/spi.c | 3 ++- include/linux/spi/spi.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 5e75944ad5d1..02fd00bcaace 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1163,7

[PATCH][V4] lib: fix __sysfs_match_string() helper when n != -1

2019-06-25 Thread Alexandru Ardelean
oint in time). This behavior change allows for an array of strings to have NULL elements within the array, which will be ignored. This is particularly useful when creating mapping of strings and integers (as bitfields or other HW description). Signed-off-by: Alexandru Ardelean --- Changelog v3 -

[PATCH 1/5] MAINTAINERS: add ADIS IMU driver library entry

2019-06-25 Thread Alexandru Ardelean
This change adds the ADIS driver library to the MAINTAINERS list, and adds myself as the current maintainer of this library. Signed-off-by: Alexandru Ardelean --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1eb971608ac4..544e23753e96

[PATCH 3/5] iio: imu: adis: Add support for SPI transfer cs_change_stall_delay_us

2019-06-25 Thread Alexandru Ardelean
the `cs_change_stall_delay_us` functionality in SPI. Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis.c | 9 + include/linux/iio/imu/adis.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c index

[PATCH 2/5] drivers: spi: core: Add optional stall delay between cs_change transfers

2019-06-25 Thread Alexandru Ardelean
Signed-off-by: Alexandru Ardelean --- drivers/spi/spi.c | 3 ++- include/linux/spi/spi.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 5e75944ad5d1..739de0118ee1 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1163,7

[PATCH 4/5] iio: imu: Add support for the ADIS16460 IMU

2019-06-25 Thread Alexandru Ardelean
-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- MAINTAINERS | 7 + drivers/iio/imu/Kconfig | 9 + drivers/iio/imu/Makefile| 1 + drivers/iio/imu/adis16460.c | 490 4 files changed, 507 insertions(+) create mode 10

Re: [PATCH] staging: iio: adis16240: add of_match_table entry

2019-05-24 Thread Alexandru Ardelean
On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote: > > This patch adds of_match_table entry in device driver in order to > enable spi fallback probing. > > Signed-off-by: Rodrigo Ribeiro > Reviewed-by: Marcelo Schmitt > --- > drivers/staging/iio/accel/adis16240.c | 1 + > 1 file changed, 1

Re: [PATCH] dt-bindings: iio: ad7949: switch binding to yaml

2019-05-20 Thread Alexandru Ardelean
On Sun, May 19, 2019 at 8:29 PM Jonathan Cameron wrote: > > On Sat, 18 May 2019 19:40:36 -0300 > João Victor Marques de Oliveira wrote: > > > Changes switches from old text bindings, to YAML bindings, and also > > include adi,reference-select property to specify the source for the > >

Re: [PATCH] dt-bindings: iio: accel: adxl372: switch to YAML bindings

2019-05-20 Thread Alexandru Ardelean
On Sun, May 19, 2019 at 8:27 PM Jonathan Cameron wrote: > > On Sat, 18 May 2019 18:55:42 -0300 > Lucas Oshiro wrote: > > > Convert the old device tree documentation to yaml format. > > > > Signed-off-by: Lucas Oshiro > > Signed-off-by: Rodrigo Ribeiro > > Co-developed-by: Rodrigo Ribeiro > >

Re: [RESEND PATCH] staging: iio: ad7192: create of_device_id array

2019-05-20 Thread Alexandru Ardelean
On Sun, May 19, 2019 at 8:53 PM Jonathan Cameron wrote: > > On Sat, 18 May 2019 19:44:35 -0300 > Bárbara Fernandes wrote: > I don't have anything else on top of what Jonathan added. Acked-by: Alexandru Ardelean CC-ing my work-email There are some issues with it and mailing

Re: [PATCH] staging:iio:ad7150: fix threshold mode config bit

2019-05-20 Thread Alexandru Ardelean
On Sun, May 19, 2019 at 8:38 PM Jonathan Cameron wrote: > > On Sat, 18 May 2019 22:04:56 -0300 > Melissa Wen wrote: > > > According to the AD7150 configuration register description, bit 7 assumes > > value 1 when the threshold mode is fixed and 0 when it is adaptive, > > however, the operation

Re: [RESEND PATCH] staging: iio: adt7316: create of_device_id array

2019-05-20 Thread Alexandru Ardelean
y: Bárbara Fernandes > > Signed-off-by: Wilson Sales > > Co-developed-by: Wilson Sales > Looks good to me. > > Applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to play with it. > > Thanks, Also, Acked-by: Alexandru Ardelean CC

Re: [PATCH] staging: iio: ad9832: Add device tree support

2019-05-20 Thread Alexandru Ardelean
On Sun, May 19, 2019 at 8:17 PM Jonathan Cameron wrote: > > On Sat, 18 May 2019 17:48:25 -0300 > João Seckler wrote: > > > Add a of_device_id struct variable and subsequent call to > > MODULE_DEVICE_TABLE macro to support device tree. > > > > Signed-off-by: João Seckler > > Signed-off-by:

[PATCH 03/16] lib,treewide: add new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
This change re-introduces `match_string()` as a macro that uses ARRAY_SIZE() to compute the size of the array. The macro is added in all the places that do `match_string(_a, ARRAY_SIZE(_a), s)`, since the change is pretty straightforward. Signed-off-by: Alexandru Ardelean --- drivers/clk/bcm

[PATCH 06/16] x86/mtrr: use new match_string() helper + add gaps == minor fix

2019-05-08 Thread Alexandru Ardelean
n't), but this fixes that. Signed-off-by: Alexandru Ardelean --- arch/x86/kernel/cpu/mtrr/if.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/if.c b/arch/x86/kernel/cpu/mtrr/if.c index 4ec7a5f7b94c..e67820a044cc 100644 --- a/arch/x86/kernel/cpu/mtrr

[PATCH 10/16] pinctrl: armada-37xx: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
off-by: Alexandru Ardelean --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 07a5bcaa0067..68b0db5ef5e9 100644 --- a/drivers/pinc

[PATCH 15/16] video: fbdev: pxafb: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
The `lcd_types` array is a static array of strings. Using match_string() (which computes the array size via ARRAY_SIZE()) is possible. This reduces the array by 1 element, since the NULL (at the end of the array) is no longer needed. Signed-off-by: Alexandru Ardelean --- drivers/video/fbdev

[PATCH 09/16] mmc: sdhci-xenon: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
The change is also cosmetic, but it also does a tighter coupling between the enums & the string values. This way, the ARRAY_SIZE(phy_types) that is implicitly done in the match_string() macro is also a bit safer. Signed-off-by: Alexandru Ardelean --- drivers/mmc/host/sdhci-xenon-phy.c

[PATCH 05/16] ALSA: oxygen: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
and ignore the NULL. Signed-off-by: Alexandru Ardelean --- sound/pci/oxygen/oxygen_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c index 13c2fb75fd71..961fd1cbc712 100644 --- a/sound/pci/oxygen

[PATCH 00/16] treewide: fix match_string() helper when array size

2019-05-08 Thread Alexandru Ardelean
y. The first patch is important, the others can be dropped. Signed-off-by: Alexandru Ardelean Alexandru Ardelean (16): lib: fix match_string() helper when array size is positive treewide: rename match_string() -> __match_string() lib,treewide: add new match_string() helper/macro power

[PATCH 12/16] rdmacg: use new match_string() helper/macro

2019-05-08 Thread Alexandru Ardelean
The `rdmacg_resource_names` array is a static array of strings. Using match_string() (which computes the array size via ARRAY_SIZE()) is possible. The change is mostly cosmetic. No functionality change. Signed-off-by: Alexandru Ardelean --- kernel/cgroup/rdma.c | 2 +- 1 file changed, 1

[PATCH 2/3][V3] scsi: sd: remove sysfs_match_string() dense array comment

2019-05-08 Thread Alexandru Ardelean
The comment is no longer valid, since it supports arrays with gaps now. Signed-off-by: Alexandru Ardelean --- Changelog v2 -> v3: * after fixing __sysfs_match_string() this comment is no longer valid drivers/scsi/sd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/sd.

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-05-06 Thread Alexandru Ardelean
On Fri, Apr 26, 2019 at 5:27 PM andriy.shevche...@linux.intel.com wrote: > > On Fri, Apr 26, 2019 at 12:29:11PM +0300, Alexandru Ardelean wrote: > > > Hmm, I actually did not give much thought to that -1. > > I'll check into this and see about a V3. > > It may

Re: [PATCH 0/4] staging: iio: ad7150: improve driver readability

2019-05-04 Thread Alexandru Ardelean
On Sat, May 4, 2019 at 2:12 PM Alexandru Ardelean wrote: > > On Sat, May 4, 2019 at 1:24 AM Melissa Wen wrote: > > > > This patchset solves readability issues in AD7150 code, such as clarify > > register and mask definition, fashion improvement of mask uses, redu

Re: [PATCH 0/4] staging: iio: ad7150: improve driver readability

2019-05-04 Thread Alexandru Ardelean
On Sat, May 4, 2019 at 1:24 AM Melissa Wen wrote: > > This patchset solves readability issues in AD7150 code, such as clarify > register and mask definition, fashion improvement of mask uses, reduce > tedious operation and useless comments. > Hey, Two patches seem a bit noisy/un-needed. The

Re: [PATCH 2/4] staging: iio: ad7150: use FIELD_GET and GENMASK

2019-05-04 Thread Alexandru Ardelean
On Sat, May 4, 2019 at 1:25 AM Melissa Wen wrote: > > Use the bitfield macro FIELD_GET, and GENMASK to do the shift and mask in > one go. This makes the code more readable than explicit masking followed > by a shift. > This looks neat. I'd have to remember to ack it from my work email. One

Re: [PATCH 3/4] staging: iio: ad7150: simplify i2c SMBus return treatment

2019-05-04 Thread Alexandru Ardelean
On Sat, May 4, 2019 at 1:26 AM Melissa Wen wrote: > > Since i2c_smbus_write_byte_data returns no-positive value, this commit > making the treatment of its return value less verbose. > > Signed-off-by: Melissa Wen > --- > drivers/staging/iio/cdc/ad7150.c | 10 +++--- > 1 file changed, 3

Re: [PATCH 1/4] staging: iio: ad7150: organize registers definition

2019-05-04 Thread Alexandru Ardelean
On Sat, May 4, 2019 at 1:25 AM Melissa Wen wrote: > > Use the suffix REG to make the register addresses clear > and indentation to highlight field names. > I'm inclined to say that this change is a bit too much noise versus added value. While the REG suffix does make sense (generally), since it

Re: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-26 Thread Alexandru Ardelean
n, 2019-04-22 at 23:06 +0200, Greg KH wrote: > > > > > > > > > > > > On Mon, Apr 22, 2019 at 11:32:56AM +0300, Alexandru Ardelean wrote: > > > > > This helper is similar to __sysfs_match_string() with the exception > > > > > that it > > > > >

Re: [PATCH v2] iio: adc: ad7766: Change alignment to match paranthesis

2019-04-25 Thread Alexandru Ardelean
he ad7766 driver changes. Thanks Alex > Best regards, > Camylla Cantanheide > > Em qua, 24 de abr de 2019 às 04:43, Alexandru Ardelean > escreveu: >> >> On Tue, Apr 23, 2019 at 11:04 PM Camylla Gonçalves Cantanheide >> wrote: >> > >> > This co

Re: [PATCH v2] iio: adc: ad7766: Change alignment to match paranthesis

2019-04-24 Thread Alexandru Ardelean
On Tue, Apr 23, 2019 at 11:04 PM Camylla Gonçalves Cantanheide wrote: > > This commit align broken line to match upper line parenthesis, > in lines 80, 130, 237, 242, 255, 264 and 293. Solves the checkpatch.pl's > message: > > CHECK: Alignment should match open parenthesis > >In lines 130, 255,

Re: [PATCH] Wqiio: adc: ad7766: Change alignment to match paranthesis

2019-04-24 Thread Alexandru Ardelean
On Tue, Apr 23, 2019 at 11:01 PM Camylla Gonçalves Cantanheide wrote: > > This commit align broken line to match upper line parenthesis, > in lines 80, 130, 237, 242, 255, 264 and 293. Solves the checkpatch.pl's > message: > > CHECK: Alignment should match open parenthesis > > In lines 130, 255,

[PATCH 2/2][V2] iio: Handle enumerated properties with gaps

2019-04-22 Thread Alexandru Ardelean
. A reserved values is marked by setting its entry in the items array to NULL rather than the normal descriptive string value. Signed-off-by: Lars-Peter Clausen Signed-off-by: Alexandru Ardelean --- drivers/iio/industrialio-core.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 1/2][V2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-22 Thread Alexandru Ardelean
-by: Alexandru Ardelean --- include/linux/string.h | 2 ++ lib/string.c | 48 -- 2 files changed, 39 insertions(+), 11 deletions(-) diff --git a/include/linux/string.h b/include/linux/string.h index 7927b875f80c..08e4a33b5f29 100644 --- a/include/linux

[PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper

2019-04-22 Thread Alexandru Ardelean
-by: Alexandru Ardelean --- include/linux/string.h | 9 - lib/string.c | 14 ++ 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/include/linux/string.h b/include/linux/string.h index 7927b875f80c..30595ed483dc 100644 --- a/include/linux/string.h +++ b/include

[PATCH 2/2] iio: Handle enumerated properties with gaps

2019-04-22 Thread Alexandru Ardelean
. A reserved values is marked by setting its entry in the items array to NULL rather than the normal descriptive string value. Signed-off-by: Lars-Peter Clausen Signed-off-by: Alexandru Ardelean --- drivers/iio/industrialio-core.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

Re: linux-next: manual merge of the staging tree with the staging.current tree

2019-04-10 Thread Alexandru Ardelean
On Tue, Apr 9, 2019 at 6:40 PM Andy Shevchenko wrote: > > On Mon, Apr 08, 2019 at 01:01:51PM +0100, Jonathan Cameron wrote: > > On Mon, 8 Apr 2019 13:34:37 +0300 > > Andy Shevchenko wrote: > > > On Mon, Apr 08, 2019 at 11:14:39AM +0100, Jonathan Cameron wrote: > > > > On Mon, 8 Apr 2019 13:01:21

Re: [PATCH] staging: iio: cdc: ad7746: Replace bitshift by BIT

2019-04-04 Thread Alexandru Ardelean
On Wed, Apr 3, 2019 at 11:46 PM Lucas Oshiro wrote: > > Replace bitshifts on lines 54, 56 and 78 of ad7746.c. > Hey, This is only partially done. If doing conversions to BIT(x) macro, I would say to do them for all cases. Thanks Alex > Signed-off-by: Lucas Oshiro > --- >

Re: Work on iio: stating: frequency: ad9832

2019-04-02 Thread Alexandru Ardelean
On Mon, Apr 1, 2019 at 7:13 PM Jonathan Cameron wrote: > > On Mon, 1 Apr 2019 11:25:29 -0300 > Marcelo Schmitt wrote: > > > Hello, > > > > I was looking for some work on staging: iio: ad9832 and made some > > observations while reading the driver. > > > > Apparently it had no devicetree

Re: [PATCH 4/4] staging: iio: ad9832: add devicetree documentation

2019-04-02 Thread Alexandru Ardelean
On Mon, Apr 1, 2019 at 5:38 PM Marcelo Schmitt wrote: > > Add a devicetree documentation for the ad9832 direct digital > synthesizer, waveform generator. > > Signed-off-by: Marcelo Schmitt > --- > .../bindings/iio/frequency/ad9832.txt | 26 +++ > 1 file changed, 26

Re: Help on testing ad5933 driver

2019-03-22 Thread Alexandru Ardelean
On Thu, Mar 21, 2019 at 9:39 PM Marcelo Schmitt wrote: > > Hello, would anyone mind helping me test ad5933 driver on actual > hardware? I went through this > (https://oslongjourney.github.io/linux-kernel/experiment-one-iio-dummy/) > tutorial so I was able to load iio_simple_dummy driver, create

Re: [PATCH v3 5/7] staging: iio: ad5933: add ABI documentation

2019-03-13 Thread Alexandru Ardelean
On Tue, Mar 12, 2019 at 7:31 PM Marcelo Schmitt wrote: > > On 03/11, Alexandru Ardelean wrote: > > On Sun, Mar 10, 2019 at 7:47 PM Marcelo Schmitt > > wrote: > > > > > > Add an ABI documentation for the ad5933 driver. > > > > There's alrea

Re: [PATCH v3 5/7] staging: iio: ad5933: add ABI documentation

2019-03-11 Thread Alexandru Ardelean
On Sun, Mar 10, 2019 at 7:47 PM Marcelo Schmitt wrote: > > Add an ABI documentation for the ad5933 driver. There's already an ABI documentation for this driver. See:

Re: [PATCH] staging: iio: adc: ad7192: Add spaces around minus operator

2019-03-11 Thread Alexandru Ardelean
On Sun, Mar 10, 2019 at 11:23 PM Karen Palacio wrote: > > Add spaces around minus operator to fix readibility. > > Signed-off-by: Karen Palacio > --- > drivers/staging/iio/adc/ad7192.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c >

Re: [PATCH v4 0/9] staging: iio: ad7780: move out of staging

2019-03-03 Thread Alexandru Ardelean
On Sun, Mar 3, 2019 at 3:52 PM Renato Lui Geh wrote: > > Hi Alexandru, > > Thanks for the review. Some questions inline. > > Thanks, > Renato > > On 03/01, Ardelean, Alexandru wrote: > >On Thu, 2019-02-28 at 11:23 -0300, Renato Lui Geh wrote: > >> > > > >The patch-series is a bit big. > >I guess

[PATCH] lib/scatterlist: introduce sg_nents_for_dma() helper

2019-02-27 Thread Alexandru Ardelean
From: Andy Shevchenko Sometimes the user needs to split each entry on the mapped scatter list due to DMA length constrains. This helper returns a number of entities assuming that each of them is not bigger than supplied maximum length. Signed-off-by: Andy Shevchenko Signed-off-by: Alexandru

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-01-29 Thread Alexandru Ardelean
On Sat, Jan 26, 2019 at 8:13 PM Jonathan Cameron wrote: > > On Fri, 25 Jan 2019 22:14:32 -0200 > Rodrigo Ribeiro wrote: > > > Em sex, 25 de jan de 2019 às 21:46, Rodrigo Ribeiro > > escreveu: > > > > > > Em sex, 25 de jan de 2019 às

Re: [PATCH v3] iio: adc: ad7476: Add support for TI ADS786X ADCs

2019-01-28 Thread Alexandru Ardelean
On Mon, Jan 28, 2019 at 11:49 AM Ricardo Ribalda Delgado wrote: > > Add support for Texas Instruments ADS7866, ADS7867 and ADS7868 > 8/10/12 bit Single channel ADC. > > Datasheet: http://www.ti.com/lit/ds/symlink/ads7868.pdf > > Cc: Alexandru Ardelean > Signed-off-by:

Re: [PATCH v2] iio: adc: ad7476: Add support for ADS786X ADCs

2019-01-27 Thread Alexandru Ardelean
On Mon, Jan 28, 2019 at 9:43 AM Ricardo Ribalda Delgado wrote: > > HI Alexandru > > On Mon, Jan 28, 2019 at 8:38 AM Alexandru Ardelean > wrote: > > > > On Sat, Jan 26, 2019 at 8:21 PM Jonathan Cameron wrote: > > > > > > On Fri, 25 Jan 2019 11:04:

Re: [PATCH v2] iio: adc: ad7476: Add support for ADS786X ADCs

2019-01-27 Thread Alexandru Ardelean
On Sat, Jan 26, 2019 at 8:21 PM Jonathan Cameron wrote: > > On Fri, 25 Jan 2019 11:04:51 +0100 > Ricardo Ribalda Delgado wrote: > > > Add support for ADS7866, ADS7867 and ADS7868 8/10/12 bit Single channel > > ADC. > > I don't want this reply be offensive or anything. But since I've seen this

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-01-27 Thread Alexandru Ardelean
On Sat, Jan 26, 2019 at 8:09 PM Jonathan Cameron wrote: > > On Fri, 25 Jan 2019 10:19:54 +0200 > Alexandru Ardelean wrote: > > > On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro > > wrote: > > > > > > Remove the checkpatch.pl check: > > >

Re: [PATCH] iio: adc: ad7476: Add support for ADS786X ADCs

2019-01-25 Thread Alexandru Ardelean
On Thu, Jan 24, 2019 at 11:33 PM Ricardo Ribalda Delgado wrote: > > Add support for ADS7866, ADS7867 and ADS7868 8/10/12 bit Single channel > ADC. > > Datasheet: http://www.ti.com/product/ADS7866 > Datasheet: http://www.ti.com/product/ADS7867 > Datasheet: http://www.ti.com/product/ADS7868 > >

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

2019-01-25 Thread Alexandru Ardelean
On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro wrote: > > Remove the checkpatch.pl check: > > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'? Hey, A bit curios about this one. Are you using this chip/driver ? Thing is: the part is nearing EOL, and it could be an idea to be marked

Re: [PATCH 1/2] staging: iio: adc: ad7192: Add clock for external clock reference

2019-01-25 Thread Alexandru Ardelean
On Fri, Jan 25, 2019 at 12:41 AM Stephen Boyd wrote: > > Quoting Jonathan Cameron (2018-12-16 02:07:41) > > Rob, Clk experts, questions for you below. > > > > Jonathan > > > > > > On Thu, 13 Dec 2018 17:39:22 -0800 > > Stephen Boyd wrote: > > > > > Quoting Jonathan Cameron (2018-12-08 07:29:54)

Re: [PATCH] drivers: iio: industrialio-core: add check when kzalloc fails

2019-01-24 Thread Alexandru Ardelean
On Thu, Jan 24, 2019 at 4:28 PM Bharath Vedartham wrote: > > add code to handle the case when kzalloc fails to allocate memory to dev > > Signed-off-by: Bharath Vedartham > --- > drivers/iio/industrialio-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

<    5   6   7   8   9   10