47.648492] *** DEADLOCK ***
Using NVMEoF after this patch seems to finally be stable, without it,
rxe eventually deadlocks the whole system and causes RCU stalls.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v3->v4: only force rxe_post_send_kernel() to alw
47.648492] *** DEADLOCK ***
Using NVMEoF after this patch seems to finally be stable, without it,
rxe eventually deadlocks the whole system and causes RCU stalls.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v3->v4: only force rxe_post_send_kernel() to alw
On Tue, May 08, 2018 at 11:09:18AM +0800, Yanjun Zhu wrote:
>
>
> On 2018/5/8 4:58, Alexandru Moise wrote:
> > This addresses 3 separate problems:
> >
> > 1. When using NVME over Fabrics we may end up sending IP
> > packets in interrupt context, we should
On Tue, May 08, 2018 at 11:09:18AM +0800, Yanjun Zhu wrote:
>
>
> On 2018/5/8 4:58, Alexandru Moise wrote:
> > This addresses 3 separate problems:
> >
> > 1. When using NVME over Fabrics we may end up sending IP
> > packets in interrupt context, we should
EADLOCK ***
Using NVMEoF after this patch seems to finally be stable, without it,
rxe eventually deadlocks the whole system and causes RCU stalls.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v2->v3: Abandoned the idea of just offloading work to tasklet in irq
context. NVM
EADLOCK ***
Using NVMEoF after this patch seems to finally be stable, without it,
rxe eventually deadlocks the whole system and causes RCU stalls.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v2->v3: Abandoned the idea of just offloading work to tasklet in irq
context. NVM
/0xd0
[ 51.006182] common_interrupt+0xf/0xf
[ 51.007129]
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v1->v2: added Zhu Yanjun's suggestion on in_irq() check
drivers/infiniband/sw/rxe/rxe_verbs.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions
/0xd0
[ 51.006182] common_interrupt+0xf/0xf
[ 51.007129]
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v1->v2: added Zhu Yanjun's suggestion on in_irq() check
drivers/infiniband/sw/rxe/rxe_verbs.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions
/0xd0
[ 51.006182] common_interrupt+0xf/0xf
[ 51.007129]
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
drivers/infiniband/sw/rxe/rxe_verbs.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c
b/d
/0xd0
[ 51.006182] common_interrupt+0xf/0xf
[ 51.007129]
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
drivers/infiniband/sw/rxe/rxe_verbs.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c
b/d
On Wed, Apr 11, 2018 at 09:28:30PM +, Bart Van Assche wrote:
> On Wed, 2018-04-11 at 23:23 +0200, Alexandru Moise wrote:
> > Hi, I tested it, it doesn't solve the problem.
> > By the time you get here it's already too late, my patch
> > prevents this from failing in the fi
On Wed, Apr 11, 2018 at 09:28:30PM +, Bart Van Assche wrote:
> On Wed, 2018-04-11 at 23:23 +0200, Alexandru Moise wrote:
> > Hi, I tested it, it doesn't solve the problem.
> > By the time you get here it's already too late, my patch
> > prevents this from failing in the fi
On Wed, Apr 11, 2018 at 01:55:25PM -0600, Bart Van Assche wrote:
> On 04/11/18 13:00, Alexandru Moise wrote:
> > But the root cause of it is in blkcg_init_queue() when blkg_create() returns
> > an ERR ptr, because it tries to insert into a populated index into
> > blkcg->
On Wed, Apr 11, 2018 at 01:55:25PM -0600, Bart Van Assche wrote:
> On 04/11/18 13:00, Alexandru Moise wrote:
> > But the root cause of it is in blkcg_init_queue() when blkg_create() returns
> > an ERR ptr, because it tries to insert into a populated index into
> > blkcg->
On Wed, Apr 11, 2018 at 03:54:53PM +, Bart Van Assche wrote:
> On Wed, 2018-04-11 at 16:28 +0200, Alexandru Moise wrote:
> > [0.76] BUG: unable to handle kernel NULL pointer dereference at
> > 01b4
> > [0.763350] Kernel panic - not syncing: A
On Wed, Apr 11, 2018 at 03:54:53PM +, Bart Van Assche wrote:
> On Wed, 2018-04-11 at 16:28 +0200, Alexandru Moise wrote:
> > [0.76] BUG: unable to handle kernel NULL pointer dereference at
> > 01b4
> > [0.763350] Kernel panic - not syncing: A
On Wed, Apr 11, 2018 at 07:20:19AM -0700, Tejun Heo wrote:
> Hello,
>
> On Wed, Apr 11, 2018 at 12:12:56PM +0200, Alexandru Moise wrote:
> > > But we already do this through calling blkcg_exit_queue() from
> > > __blk_release_queue(). What's missing?
> >
> &
On Wed, Apr 11, 2018 at 07:20:19AM -0700, Tejun Heo wrote:
> Hello,
>
> On Wed, Apr 11, 2018 at 12:12:56PM +0200, Alexandru Moise wrote:
> > > But we already do this through calling blkcg_exit_queue() from
> > > __blk_release_queue(). What's missing?
> >
> &
On Mon, Apr 09, 2018 at 03:09:38PM -0700, Tejun Heo wrote:
> (cc'ing Joseph as he worked on the area recently, hi!)
>
> Hello,
>
> On Sat, Apr 07, 2018 at 12:21:48PM +0200, Alexandru Moise wrote:
> > The q->id is used as an index within the blkg_tree radix tre
On Mon, Apr 09, 2018 at 03:09:38PM -0700, Tejun Heo wrote:
> (cc'ing Joseph as he worked on the area recently, hi!)
>
> Hello,
>
> On Sat, Apr 07, 2018 at 12:21:48PM +0200, Alexandru Moise wrote:
> > The q->id is used as an index within the blkg_tree radix tre
ing.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v2: Added no-op for !CONFIG_BLK_CGROUP
block/blk-cgroup.c | 2 +-
block/blk-sysfs.c | 4
include/linux/blk-cgroup.h | 3 +++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/block/blk-c
ing.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v2: Added no-op for !CONFIG_BLK_CGROUP
block/blk-cgroup.c | 2 +-
block/blk-sysfs.c | 4
include/linux/blk-cgroup.h | 3 +++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/block/blk-c
ing.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
block/blk-cgroup.c | 2 +-
block/blk-sysfs.c | 4
include/linux/blk-cgroup.h | 2 ++
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 1c1
ing.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
block/blk-cgroup.c | 2 +-
block/blk-sysfs.c | 4
include/linux/blk-cgroup.h | 2 ++
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 1c1
On Mon, Oct 02, 2017 at 06:15:00PM +0200, Michal Hocko wrote:
> On Mon 02-10-17 17:06:38, Alexandru Moise wrote:
> > On Mon, Oct 02, 2017 at 04:27:17PM +0200, Michal Hocko wrote:
> > > On Mon 02-10-17 16:06:33, Alexandru Moise wrote:
> > > > On Mon, Oct 02, 2017 at
On Mon, Oct 02, 2017 at 06:15:00PM +0200, Michal Hocko wrote:
> On Mon 02-10-17 17:06:38, Alexandru Moise wrote:
> > On Mon, Oct 02, 2017 at 04:27:17PM +0200, Michal Hocko wrote:
> > > On Mon 02-10-17 16:06:33, Alexandru Moise wrote:
> > > > On Mon, Oct 02, 2017 at
On Mon, Oct 02, 2017 at 04:27:17PM +0200, Michal Hocko wrote:
> On Mon 02-10-17 16:06:33, Alexandru Moise wrote:
> > On Mon, Oct 02, 2017 at 02:54:32PM +0200, Michal Hocko wrote:
> > > On Mon 02-10-17 00:51:11, Alexandru Moise wrote:
> > > > This attempts to bring mor
On Mon, Oct 02, 2017 at 04:27:17PM +0200, Michal Hocko wrote:
> On Mon 02-10-17 16:06:33, Alexandru Moise wrote:
> > On Mon, Oct 02, 2017 at 02:54:32PM +0200, Michal Hocko wrote:
> > > On Mon 02-10-17 00:51:11, Alexandru Moise wrote:
> > > > This attempts to bring mor
On Mon, Oct 02, 2017 at 02:54:32PM +0200, Michal Hocko wrote:
> On Mon 02-10-17 00:51:11, Alexandru Moise wrote:
> > This attempts to bring more flexibility to how hugepages are allocated
> > by making it possible to decide whether we want the hugepages to be
> > alloca
On Mon, Oct 02, 2017 at 02:54:32PM +0200, Michal Hocko wrote:
> On Mon 02-10-17 00:51:11, Alexandru Moise wrote:
> > This attempts to bring more flexibility to how hugepages are allocated
> > by making it possible to decide whether we want the hugepages to be
> > alloca
mplementation is a bit dirty so obviously I'm open to suggestions
for a better way to implement this behavior, or comments whether the whole
idea is fundamentally __wrong__.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
Documentation/admin-guide/kernel-parameters.txt | 8 ++
mplementation is a bit dirty so obviously I'm open to suggestions
for a better way to implement this behavior, or comments whether the whole
idea is fundamentally __wrong__.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
Documentation/admin-guide/kernel-parameters.txt | 8 ++
On Fri, Sep 29, 2017 at 02:16:10PM -0700, Mike Kravetz wrote:
> Adding Anshuman
>
> On 09/29/2017 01:43 PM, Alexandru Moise wrote:
> > On Fri, Sep 29, 2017 at 05:13:39PM +0200, Alexandru Moise wrote:
> >>
> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> >&g
On Fri, Sep 29, 2017 at 02:16:10PM -0700, Mike Kravetz wrote:
> Adding Anshuman
>
> On 09/29/2017 01:43 PM, Alexandru Moise wrote:
> > On Fri, Sep 29, 2017 at 05:13:39PM +0200, Alexandru Moise wrote:
> >>
> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> >&g
On Fri, Sep 29, 2017 at 05:13:39PM +0200, Alexandru Moise wrote:
> If hugepage_migration_supported() returns true, this renders the
> hugepages_treat_as_movable sysctl completely pointless.
>
> Let's keep this behavior optional by switching the if() condition
> from || to &
On Fri, Sep 29, 2017 at 05:13:39PM +0200, Alexandru Moise wrote:
> If hugepage_migration_supported() returns true, this renders the
> hugepages_treat_as_movable sysctl completely pointless.
>
> Let's keep this behavior optional by switching the if() condition
> from || to &
If hugepage_migration_supported() returns true, this renders the
hugepages_treat_as_movable sysctl completely pointless.
Let's keep this behavior optional by switching the if() condition
from || to &&.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
mm/huget
If hugepage_migration_supported() returns true, this renders the
hugepages_treat_as_movable sysctl completely pointless.
Let's keep this behavior optional by switching the if() condition
from || to &&.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
mm/huget
On Fri, Sep 29, 2017 at 04:55:54PM +0300, Kirill A. Shutemov wrote:
> On Wed, Sep 13, 2017 at 12:10:47PM +0200, Alexandru Moise wrote:
> > since 94310cb we've been able to soft offline 1G hugepages at the PGD
> > level, however x86_64 gigantic hugepages are at the PUD level so we
On Fri, Sep 29, 2017 at 04:55:54PM +0300, Kirill A. Shutemov wrote:
> On Wed, Sep 13, 2017 at 12:10:47PM +0200, Alexandru Moise wrote:
> > since 94310cb we've been able to soft offline 1G hugepages at the PGD
> > level, however x86_64 gigantic hugepages are at the PUD level so we
__free_irq() can return a NULL irqaction for example when trying to
free already-free IRQ. Fix this by adding a check and return NULL.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
kernel/irq/manage.c | 4
1 file changed, 4 insertions(+)
diff --git a/kern
__free_irq() can return a NULL irqaction for example when trying to
free already-free IRQ. Fix this by adding a check and return NULL.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
kernel/irq/manage.c | 4
1 file changed, 4 insertions(+)
diff --git a/kern
level pagetable.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
include/linux/hugetlb.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index 8bbbd37ab105..86c3f3d9da0a 100644
--- a/include/linux/hugetlb.h
+++ b/include
level pagetable.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
include/linux/hugetlb.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index 8bbbd37ab105..86c3f3d9da0a 100644
--- a/include/linux/hugetlb.h
+++ b/include
On Wed, Sep 13, 2017 at 12:13:09AM +, Naoya Horiguchi wrote:
> Hi Alexandru,
>
> On Tue, Sep 12, 2017 at 10:43:06PM +0200, Alexandru Moise wrote:
> > This fixes a bug in madvise() where if you'd try to soft offline a
> > hugepage via madvise(), while walking the addre
On Wed, Sep 13, 2017 at 12:13:09AM +, Naoya Horiguchi wrote:
> Hi Alexandru,
>
> On Tue, Sep 12, 2017 at 10:43:06PM +0200, Alexandru Moise wrote:
> > This fixes a bug in madvise() where if you'd try to soft offline a
> > hugepage via madvise(), while walking the addre
On Tue, Sep 12, 2017 at 01:58:35PM -0700, Andrew Morton wrote:
> On Tue, 12 Sep 2017 13:54:48 -0700 Andrew Morton <a...@linux-foundation.org>
> wrote:
>
> > On Tue, 12 Sep 2017 22:43:06 +0200 Alexandru Moise
> > <00moses.alexande...@gmail.com> wrote:
>
On Tue, Sep 12, 2017 at 01:58:35PM -0700, Andrew Morton wrote:
> On Tue, 12 Sep 2017 13:54:48 -0700 Andrew Morton
> wrote:
>
> > On Tue, 12 Sep 2017 22:43:06 +0200 Alexandru Moise
> > <00moses.alexande...@gmail.com> wrote:
> >
> > > This fixes a b
On Tue, Sep 12, 2017 at 01:54:48PM -0700, Andrew Morton wrote:
> On Tue, 12 Sep 2017 22:43:06 +0200 Alexandru Moise
> <00moses.alexande...@gmail.com> wrote:
>
> > This fixes a bug in madvise() where if you'd try to soft offline a
> > hugepage via madvise(), while walk
On Tue, Sep 12, 2017 at 01:54:48PM -0700, Andrew Morton wrote:
> On Tue, 12 Sep 2017 22:43:06 +0200 Alexandru Moise
> <00moses.alexande...@gmail.com> wrote:
>
> > This fixes a bug in madvise() where if you'd try to soft offline a
> > hugepage via madvise(), while walk
c3114a8).
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
mm/madvise.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/mm/madvise.c b/mm/madvise.c
index 21261ff0466f..25bade36e9ca 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -625,18 +
c3114a8).
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
mm/madvise.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/mm/madvise.c b/mm/madvise.c
index 21261ff0466f..25bade36e9ca 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -625,18 +
On Mon, Jul 10, 2017 at 08:00:37PM +0200, Daniel Vetter wrote:
> On Mon, Jul 10, 2017 at 9:14 AM, Alexandru Moise
> <00moses.alexande...@gmail.com> wrote:
> > On Mon, Jul 10, 2017 at 08:52:46AM +0200, Daniel Vetter wrote:
> >> On Sat, Jul 08, 2017 at 11:43:52PM +
On Mon, Jul 10, 2017 at 08:00:37PM +0200, Daniel Vetter wrote:
> On Mon, Jul 10, 2017 at 9:14 AM, Alexandru Moise
> <00moses.alexande...@gmail.com> wrote:
> > On Mon, Jul 10, 2017 at 08:52:46AM +0200, Daniel Vetter wrote:
> >> On Sat, Jul 08, 2017 at 11:43:52PM +
On Mon, Jul 10, 2017 at 08:52:46AM +0200, Daniel Vetter wrote:
> On Sat, Jul 08, 2017 at 11:43:52PM +0200, Alexandru Moise wrote:
> > If the DRM core fails to init for whatever reason, ensure that
> > no driver ever calls drm_dev_register().
> >
> > This i
On Mon, Jul 10, 2017 at 08:52:46AM +0200, Daniel Vetter wrote:
> On Sat, Jul 08, 2017 at 11:43:52PM +0200, Alexandru Moise wrote:
> > If the DRM core fails to init for whatever reason, ensure that
> > no driver ever calls drm_dev_register().
> >
> > This i
p->lookup() while it was
NULL in debugfs at inode_lock() or lookup_*().
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
drivers/gpu/drm/drm_drv.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
p->lookup() while it was
NULL in debugfs at inode_lock() or lookup_*().
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
drivers/gpu/drm/drm_drv.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
On Fri, Apr 14, 2017 at 10:51:32AM +0200, Peter Zijlstra wrote:
> On Fri, Apr 14, 2017 at 12:24:55AM +0200, Alexandru Moise wrote:
> > Seeing as RB_RED is defined to be 0 in include/linux/rbtree_augmented.h
> > A call of this form: rb_set_parent_color(node, parent, RB_RE
On Fri, Apr 14, 2017 at 10:51:32AM +0200, Peter Zijlstra wrote:
> On Fri, Apr 14, 2017 at 12:24:55AM +0200, Alexandru Moise wrote:
> > Seeing as RB_RED is defined to be 0 in include/linux/rbtree_augmented.h
> > A call of this form: rb_set_parent_color(node, parent, RB_RE
Seeing as RB_RED is defined to be 0 in include/linux/rbtree_augmented.h
A call of this form: rb_set_parent_color(node, parent, RB_RED);
as seen in __rb_insert would only end up reassigning the parent "color"
(which is the parent pointer value cast to unsigned long) OR'd with 0.
Which would mean
Seeing as RB_RED is defined to be 0 in include/linux/rbtree_augmented.h
A call of this form: rb_set_parent_color(node, parent, RB_RED);
as seen in __rb_insert would only end up reassigning the parent "color"
(which is the parent pointer value cast to unsigned long) OR'd with 0.
Which would mean
This struct member is already initialized to zero upon root_ht's
allocation via kzalloc().
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
net/sched/cls_u32.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index ae83c3ae..a6
This struct member is already initialized to zero upon root_ht's
allocation via kzalloc().
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
net/sched/cls_u32.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index ae83c3ae..a6
As each mount of devpts is now an independent filesystem,
the DEVPTS_MULTIPLE_INSTANCES config option no longer exists.
So remove it.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
arch/arc/configs/tb10x_defconfig| 1 -
arch/arm/configs/mxs_def
As each mount of devpts is now an independent filesystem,
the DEVPTS_MULTIPLE_INSTANCES config option no longer exists.
So remove it.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
arch/arc/configs/tb10x_defconfig| 1 -
arch/arm/configs/mxs_def
On Tue, Dec 29, 2015 at 01:19:57PM -0700, Jens Axboe wrote:
> On 12/29/2015 01:16 PM, Alexandru Moise wrote:
> >This patch refers to Jens Axboe's change way back in 2006:
> >7b14e3b52 cfq-iosched: slice expiry fixups
> >
> >In this patch he fixed a potential timer
.
Signed-off-by: Alexandru Moise <00moses.alexade...@gmail.com>
---
V2: slice_idle not in miliseconds, convert only group_idle
block/cfq-iosched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 1f9093e..088c45d 100644
--- a
On Tue, Dec 29, 2015 at 10:19:17AM -0700, Jens Axboe wrote:
> On 12/28/2015 06:08 PM, Alexandru Moise wrote:
> >This patch refers to Jens Axboe's change way back in 2006:
> >7b14e3b52 cfq-iosched: slice expiry fixups
> >
> >In this patch he fixed a potential timer
On Tue, Dec 29, 2015 at 10:19:17AM -0700, Jens Axboe wrote:
> On 12/28/2015 06:08 PM, Alexandru Moise wrote:
> >This patch refers to Jens Axboe's change way back in 2006:
> >7b14e3b52 cfq-iosched: slice expiry fixups
> >
> >In this patch he fixed a potential timer
.
Signed-off-by: Alexandru Moise <00moses.alexade...@gmail.com>
---
V2: slice_idle not in miliseconds, convert only group_idle
block/cfq-iosched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 1f9093e..088c45d 100644
--- a
On Tue, Dec 29, 2015 at 01:19:57PM -0700, Jens Axboe wrote:
> On 12/29/2015 01:16 PM, Alexandru Moise wrote:
> >This patch refers to Jens Axboe's change way back in 2006:
> >7b14e3b52 cfq-iosched: slice expiry fixups
> >
> >In this patch he fixed a potential timer
vary too much for me to post any believable
numbers (10 milliseconds difference at most on average).
Signed-off-by: Alexandru Moise <00moses.alexade...@gmail.com>
---
block/cfq-iosched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/cfq-iosched.c b/block/cfq-ios
vary too much for me to post any believable
numbers (10 milliseconds difference at most on average).
Signed-off-by: Alexandru Moise <00moses.alexade...@gmail.com>
---
block/cfq-iosched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/cfq-iosched.c b/block/cfq-ios
-by: Alexandru Moise <00moses.alexande...@gmail.com>
Reviewed-by: Jan Kara
---
fs/jbd2/transaction.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 89463ee..3fd597b 100644
--- a/fs/jbd2/transaction.c
+++ b/f
-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
fs/jbd2/transaction.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 89463ee..3fd597b 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@
-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
fs/jbd2/transaction.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 89463ee..3fd597b 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@
-by: Alexandru Moise <00moses.alexande...@gmail.com>
Reviewed-by: Jan Kara <j...@suse.com>
---
fs/jbd2/transaction.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 89463ee..3fd597b 100644
--- a/fs/jbd2/t
On Sun, Oct 25, 2015 at 01:33:45PM -0400, Jeff Mahoney wrote:
>
> On Oct 25, 2015, at 3:50 PM, Alexandru Moise <00moses.alexande...@gmail.com>
> wrote:
>
> >>> This allows us to trim out half of btrfs_init_delayed_node() which
> >>> i
It's slightly cleaner to zero-out the delayed node upon allocation
than to do it by hand in btrfs_init_delayed_node() for a few members
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v2: Thanks Jeff Mahoney for pointing out the mistake of removing
the atomic_set
> > This allows us to trim out half of btrfs_init_delayed_node() which
> > is now reduntant.
>
> It's redundant if kmem_cache_zalloc is used, but you haven't
> documented that doing so is now required. For all of these changes
> you've posted, if they're to be accepted, I'd really prefer to set
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
fs/btrfs/transaction.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index a5b0644..cb50f53 100644
--- a/fs/btrfs/transaction.c
+++ b/fs
This allows us to trim out half of btrfs_init_delayed_node()
which is now reduntant.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
fs/btrfs/delayed-inode.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/d
On Sun, Oct 25, 2015 at 01:33:45PM -0400, Jeff Mahoney wrote:
>
> On Oct 25, 2015, at 3:50 PM, Alexandru Moise <00moses.alexande...@gmail.com>
> wrote:
>
> >>> This allows us to trim out half of btrfs_init_delayed_node() which
> >>> i
> > This allows us to trim out half of btrfs_init_delayed_node() which
> > is now reduntant.
>
> It's redundant if kmem_cache_zalloc is used, but you haven't
> documented that doing so is now required. For all of these changes
> you've posted, if they're to be accepted, I'd really prefer to set
It's slightly cleaner to zero-out the delayed node upon allocation
than to do it by hand in btrfs_init_delayed_node() for a few members
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
v2: Thanks Jeff Mahoney for pointing out the mistake of removing
the atomic_set
This allows us to trim out half of btrfs_init_delayed_node()
which is now reduntant.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
fs/btrfs/delayed-inode.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/d
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
fs/btrfs/transaction.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index a5b0644..cb50f53 100644
--- a/fs/btrfs/transaction.c
+++ b/fs
The assignment to NULL within the error condition was written
in a 2014 patch to suppress a compiler warning.
However it would be cleaner to just initialize the kmem_cache
to NULL and just return it in case of an error condition.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.
The assignment to NULL within the error condition was written
in a 2014 patch to suppress a compiler warning.
However it would be cleaner to just initialize the kmem_cache
to NULL and just return it in case of an error condition.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.
Conform to __btrfs_fs_incompat() cast-to-bool (!!) by explicitly
returning boolean not int.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
fs/btrfs/ctree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 9
Conform to __btrfs_fs_incompat() cast-to-bool (!!) by explicitly
returning boolean not int.
Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com>
---
fs/btrfs/ctree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 9
On Tue, Sep 29, 2015 at 10:28:57PM -0700, Andrew Morton wrote:
> On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise
> <00moses.alexande...@gmail.com> wrote:
>
> > > > --- a/mm/vmscan.c
> > > > +++ b/mm/vmscan.c
> > > > @@ -194,7 +194,7
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
> >
> > static unsigned long zone_reclaimable_pages(struct zone *zone)
> > {
> > - int nr;
> > + unsigned long nr;
> >
> > nr = zone_page_state(zone, NR_ACTIVE_FILE)
On Tue, Sep 29, 2015 at 02:32:29PM +0200, David Sterba wrote:
> On Sat, Sep 26, 2015 at 12:05:19PM +0000, Alexandru Moise wrote:
> > fs_path_alloc() either returns an alloc'ed struct fs_path
> > or NULL, no need to initialize the pointer to NULL.
> >
> > Sig
On Tue, Sep 29, 2015 at 11:13:27AM +0100, Mel Gorman wrote:
> On Sun, Sep 27, 2015 at 09:04:16PM +0000, Alexandru Moise wrote:
> > Their stored values come from zone_page_state() which returns
> > an unsigned long. To improve code correctness we should avoid
> > mixing signed
On Tue, Sep 29, 2015 at 11:13:27AM +0100, Mel Gorman wrote:
> On Sun, Sep 27, 2015 at 09:04:16PM +0000, Alexandru Moise wrote:
> > Their stored values come from zone_page_state() which returns
> > an unsigned long. To improve code correctness we should avoid
> > mixing signed
On Tue, Sep 29, 2015 at 02:32:29PM +0200, David Sterba wrote:
> On Sat, Sep 26, 2015 at 12:05:19PM +0000, Alexandru Moise wrote:
> > fs_path_alloc() either returns an alloc'ed struct fs_path
> > or NULL, no need to initialize the pointer to NULL.
> >
> > Sig
On Tue, Sep 29, 2015 at 10:28:57PM -0700, Andrew Morton wrote:
> On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise
> <00moses.alexande...@gmail.com> wrote:
>
> > > > --- a/mm/vmscan.c
> > > > +++ b/mm/vmscan.c
> > > > @@ -194,7 +194,7
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
> >
> > static unsigned long zone_reclaimable_pages(struct zone *zone)
> > {
> > - int nr;
> > + unsigned long nr;
> >
> > nr = zone_page_state(zone, NR_ACTIVE_FILE)
1 - 100 of 154 matches
Mail list logo
