Re: [PATCH v2 1/2] perf tools: add 'perf irq' to measure the hardware interrupts

2021-01-14 Thread Alexei Budankov
On 14.01.2021 10:48, Bixuan Cui wrote: > Add 'perf irq' to trace/measure the hardware interrupts. > > Now three functions are provided: > 1. 'perf irq record ' to record the irq handler events. > 2. 'perf irq script' to see a detailed trace of the workload that >was recorded. > 3. 'per

Re: [PATCH v2 2/2] perf tools: Add documentation for 'perf irq' command

2021-01-14 Thread Alexei Budankov
On 14.01.2021 10:48, Bixuan Cui wrote: > Add documentation for 'perf irq' command. > > Signed-off-by: Bixuan Cui > --- > tools/perf/Documentation/perf-irq.txt | 58 +++ > tools/perf/command-list.txt | 1 + > 2 files changed, 59 insertions(+) > create mode 10

Re: [PATCH 1/2] perf tools: add 'perf irq' to measure the hardware interrupts

2021-01-12 Thread Alexei Budankov
Hi Bixuan, On 12.01.2021 15:55, Bixuan Cui wrote: > Add 'perf irq' to trace/measure the hardware interrupts. > > Now three functions are provided: > 1. 'perf irq record ' to record the irq handler events. > 2. 'perf irq script' to see a detailed trace of the workload that >was recorded.

Re: [PATCH 2/2] perf tools: Add documentation for 'perf irq' command

2021-01-12 Thread Alexei Budankov
Hi, On 12.01.2021 15:55, Bixuan Cui wrote: > Add documentation for 'perf irq' command. > > Signed-off-by: Bixuan Cui > --- > tools/perf/Documentation/perf-irq.txt | 58 +++ > tools/perf/command-list.txt | 1 + > 2 files changed, 59 insertions(+) > create mo

Re: [PATCH 4/8] perf daemon: Add daemon command

2020-12-15 Thread Alexei Budankov
On 15.12.2020 22:43, Jiri Olsa wrote: > On Tue, Dec 15, 2020 at 06:40:26PM +0300, Alexei Budankov wrote: >> Hi, >> >> On 12.12.2020 13:43, Jiri Olsa wrote: >>> Adding daemon command that allows to run record sessions >>> on background. Each session repres

Re: [PATCH 4/8] perf daemon: Add daemon command

2020-12-15 Thread Alexei Budankov
Hi, On 12.12.2020 13:43, Jiri Olsa wrote: > Adding daemon command that allows to run record sessions > on background. Each session represents one perf record > process and is configured in config file. > > Example: > > # cat config.daemon > [daemon] > base=/opt/perfdata It could probably

Re: [PATCH v3 00/12] Introduce threaded trace streaming for basic perf record operation

2020-12-15 Thread Alexei Budankov
Hi, On 20.11.2020 12:45, Namhyung Kim wrote: > Hi, > > Thanks for working on this! Thanks for your review. Just spotted comments for this version. Sorry for delay. > > On Mon, Nov 16, 2020 at 03:12:47PM +0300, Alexey Budankov wrote: >> >> Changes in v3: >> - avoided skipped redundant patch 3/1

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Alexei Budankov
On 10.12.2020 21:20, Alexei Budankov wrote: > > On 10.12.2020 21:06, Jiri Olsa wrote: >> On Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa wrote: >>> On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: >>>> Hi, >>>> >>>&g

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-10 Thread Alexei Budankov
On 10.12.2020 21:06, Jiri Olsa wrote: > On Thu, Dec 10, 2020 at 05:24:30PM +0100, Jiri Olsa wrote: >> On Mon, Dec 07, 2020 at 08:02:20PM +0300, Alexei Budankov wrote: >>> Hi, >>> >>> On 06.12.2020 20:05, Jiri Olsa wrote: >>>> Adding new control e

Re: [PATCH 1/3] perf tools: Add evlist__disable_evsel/evlist__enable_evsel

2020-12-07 Thread Alexei Budankov
he toggle can work properly and toggle > evlist to disabled state. > > Signed-off-by: Jiri Olsa > --- > tools/perf/util/evlist.c | 69 ++-- > tools/perf/util/evlist.h | 2 ++ > 2 files changed, 68 insertions(+), 3 deletions(-) Acked-by: Alexei Budankov Regards, Alexei

Re: [PATCH 3/3] perf tools: Allow to list events via control file

2020-12-07 Thread Alexei Budankov
Hi, On 07.12.2020 19:28, Arnaldo Carvalho de Melo wrote: > Em Sun, Dec 06, 2020 at 06:05:19PM +0100, Jiri Olsa escreveu: >> Adding new control event to display all evlist events. >> >> The interface string for control file is 'list'. When >> received, perf will scan and print current evlist into >

Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file

2020-12-07 Thread Alexei Budankov
Hi, On 06.12.2020 20:05, Jiri Olsa wrote: > Adding new control events to enable/disable specific event. > The interface string for control file are: > > 'enable-' > 'disable-' > > when received the command, perf will scan the current evlist > for and if found it's enabled/disabled. >

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-12-02 Thread Alexei Budankov
_event() fails with > ENOMEM, > due to exceeded memory limit for 32-bit applications. > This happens with or without Petr's patch. > > As I can see, these mappings are only released in perf_session__delete(). > We should think how to release them early. > > On 02.12.

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-12-01 Thread Alexei Budankov
Eventually sending to the proper Alexey's address. On 02.12.2020 0:04, Alexei Budankov wrote: > > On 01.12.2020 22:09, Jiri Olsa wrote: >> On Mon, Nov 30, 2020 at 12:40:20PM +0100, Petr Malat wrote: >>> Hi Jiří, >>> were you able to reproduce the issue? I

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-12-01 Thread Alexei Budankov
On 01.12.2020 22:09, Jiri Olsa wrote: > On Mon, Nov 30, 2020 at 12:40:20PM +0100, Petr Malat wrote: >> Hi Jiří, >> were you able to reproduce the issue? I may also upload perf-archive >> if that would help. > > oh yea ;-) seems like those 2 commits you reverted broke 32 bits > perf for data file

Re: [PATCH v2 12/15] perf record: introduce thread local variable for trace streaming

2020-10-26 Thread Alexei Budankov
On 26.10.2020 13:34, Jiri Olsa wrote: > On Mon, Oct 26, 2020 at 11:21:28AM +0300, Alexei Budankov wrote: >> >> On 24.10.2020 18:43, Jiri Olsa wrote: >>> On Wed, Oct 21, 2020 at 07:07:00PM +0300, Alexey Budankov wrote: >>>> >>>> Introduce thr

Re: [PATCH v2 08/15] perf record: write trace data into mmap trace files

2020-10-26 Thread Alexei Budankov
On 26.10.2020 13:32, Jiri Olsa wrote: > On Mon, Oct 26, 2020 at 11:52:21AM +0300, Alexei Budankov wrote: >> >> On 24.10.2020 18:44, Jiri Olsa wrote: >>> On Wed, Oct 21, 2020 at 07:02:56PM +0300, Alexey Budankov wrote: >>> >>> SNIP >>> >>&g

Re: [PATCH v2 05/15] perf session: introduce decompressor into trace reader object

2020-10-26 Thread Alexei Budankov
On 24.10.2020 18:44, Jiri Olsa wrote: > On Wed, Oct 21, 2020 at 07:00:30PM +0300, Alexey Budankov wrote: >> >> Introduce decompressor to trace reader object so that decompression >> could be executed on per trace file basis separately for every >> trace file located in trace directory. >> >> Sign

Re: [PATCH v2 09/15] perf record: introduce thread specific objects for trace streaming

2020-10-26 Thread Alexei Budankov
On 24.10.2020 18:44, Jiri Olsa wrote: > On Wed, Oct 21, 2020 at 07:03:48PM +0300, Alexey Budankov wrote: >> >> Introduce thread local data object and its array to be used for >> threaded trace streaming. >> >> Signed-off-by: Alexey Budankov >> --- >> tools/perf/builtin-record.c | 18 ++

Re: [PATCH v2 08/15] perf record: write trace data into mmap trace files

2020-10-26 Thread Alexei Budankov
On 24.10.2020 18:44, Jiri Olsa wrote: > On Wed, Oct 21, 2020 at 07:02:56PM +0300, Alexey Budankov wrote: > > SNIP > >> >> record__synthesize(rec, true); >> -/* this will be recalculated during process_buildids() */ >> -rec->samples = 0; >> >> if (!err) { >> if

Re: [PATCH v2 14/15] perf record: start threads in the beginning of trace streaming

2020-10-26 Thread Alexei Budankov
On 24.10.2020 18:44, Jiri Olsa wrote: > On Wed, Oct 21, 2020 at 07:10:09PM +0300, Alexey Budankov wrote: >> >> Start threads in detached state because its management is possible >> via messaging. Block signals prior the threads start so only main >> tool thread would be notified on external async

Re: [PATCH v2 10/15] perf record: manage thread specific data array

2020-10-26 Thread Alexei Budankov
On 24.10.2020 18:44, Jiri Olsa wrote: > On Wed, Oct 21, 2020 at 07:04:26PM +0300, Alexey Budankov wrote: >> >> Provide allocation, initialization, finalization and releasing of >> thread specific objects at thread specific data array. Allocate >> thread specific object for every data buffer makin

Re: [PATCH v2 12/15] perf record: introduce thread local variable for trace streaming

2020-10-26 Thread Alexei Budankov
On 24.10.2020 18:43, Jiri Olsa wrote: > On Wed, Oct 21, 2020 at 07:07:00PM +0300, Alexey Budankov wrote: >> >> Introduce thread local variable and use it for threaded trace streaming. >> >> Signed-off-by: Alexey Budankov >> --- >> tools/perf/builtin-record.c | 71 +++