Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p

2008-02-25 Thread Alexey Starikovskiy
Michael S. Tsirkin wrote: On Mon, Feb 25, 2008 at 10:50 PM, Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: Michael S. Tsirkin wrote: > Did you guys stop accepting reports by mail? > I hope not. It is easier to track bug information in bugzilla. If you for some reason do not wi

Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p

2008-02-25 Thread Alexey Starikovskiy
Michael S. Tsirkin wrote: Did you guys stop accepting reports by mail? I hope not. It is easier to track bug information in bugzilla. If you for some reason do not wish to create a bug report, I can do it for you. You only need to provide acpidump. and attach acpidump? I'll see if I can

Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p

2008-02-25 Thread Alexey Starikovskiy
Michael S. Tsirkin wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). This no longer happens in 2.6.25-rc3: I see nothing in

Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p

2008-02-25 Thread Alexey Starikovskiy
Michael S. Tsirkin wrote: On my T61p, 2.6.25-rc2 seems to get acpi events from keypresses such as Fn-F4 and lid open/close, prints them in /var/log/acpid and reacts accordingly (my acpi scripts suspend on lid close and Fn-F4). This no longer happens in 2.6.25-rc3: I see nothing in

Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p

2008-02-25 Thread Alexey Starikovskiy
Michael S. Tsirkin wrote: Did you guys stop accepting reports by mail? I hope not. It is easier to track bug information in bugzilla. If you for some reason do not wish to create a bug report, I can do it for you. You only need to provide acpidump. and attach acpidump? I'll see if I can

Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p

2008-02-25 Thread Alexey Starikovskiy
Michael S. Tsirkin wrote: On Mon, Feb 25, 2008 at 10:50 PM, Alexey Starikovskiy [EMAIL PROTECTED] wrote: Michael S. Tsirkin wrote: Did you guys stop accepting reports by mail? I hope not. It is easier to track bug information in bugzilla. If you for some reason do not wish to create a bug

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Wednesday, 20 of February 2008, Linus Torvalds wrote: On Wed, 20 Feb 2008, Rafael J. Wysocki wrote: I think we should export the target sleep state somehow. Yeah. By *not* using "->suspend()" for freezing or hibernate. Please, Rafael - just make the

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green.

2008-02-20 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Wednesday, 20 of February 2008, Linus Torvalds wrote: On Wed, 20 Feb 2008, Rafael J. Wysocki wrote: I think we should export the target sleep state somehow. Yeah. By *not* using -suspend() for freezing or hibernate. Please, Rafael - just make the

Re: [PATCH] ACPI: EC: add leading zeros to debug messages

2008-01-17 Thread Alexey Starikovskiy
Marton, Could you please attach these patches to bug report? It is easier to track them there. Thanks, Alex. Németh Márton wrote: From: Márton Németh <[EMAIL PROTECTED]> Add leading zeros to pr_debug() calls. For example if x=0x0a, the format "0x%2x" will result the string "0x a", the format

Re: [PATCH] ACPI: EC: add leading zeros to debug messages

2008-01-17 Thread Alexey Starikovskiy
Marton, Could you please attach these patches to bug report? It is easier to track them there. Thanks, Alex. Németh Márton wrote: From: Márton Németh [EMAIL PROTECTED] Add leading zeros to pr_debug() calls. For example if x=0x0a, the format 0x%2x will result the string 0x a, the format

Re: kpowersave stuck at battery charging

2008-01-02 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: On Wednesday 02 January 2008, Alexey Starikovskiy wrote: Andrey Borzenkov wrote: This is did not happen before; I am not sure right now what caused this (i.e. battery aging or some software change) nor whether this is kernel/HAL/kpowersave

Re: kpowersave stuck at battery charging

2008-01-02 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: This is did not happen before; I am not sure right now what caused this (i.e. battery aging or some software change) nor whether this is kernel/HAL/kpowersave issue. kpowersave is stuck at assuming battery is loading and at 94%. Sysfs displays battery state as Full:

Re: kpowersave stuck at battery charging

2008-01-02 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: This is did not happen before; I am not sure right now what caused this (i.e. battery aging or some software change) nor whether this is kernel/HAL/kpowersave issue. kpowersave is stuck at assuming battery is loading and at 94%. Sysfs displays battery state as Full:

Re: kpowersave stuck at battery charging

2008-01-02 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: On Wednesday 02 January 2008, Alexey Starikovskiy wrote: Andrey Borzenkov wrote: This is did not happen before; I am not sure right now what caused this (i.e. battery aging or some software change) nor whether this is kernel/HAL/kpowersave

Re: Suspend code ordering (again)

2007-12-26 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Wednesday, 26 of December 2007, Linus Torvalds wrote: On Tue, 25 Dec 2007, Rafael J. Wysocki wrote: the ACPI specification between versions 1.0x and 2.0. Namely, while ACPI 2.0 and later wants us to put devices into low power states before calling _PTS,

Re: Suspend code ordering (again)

2007-12-26 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Wednesday, 26 of December 2007, Linus Torvalds wrote: On Tue, 25 Dec 2007, Rafael J. Wysocki wrote: the ACPI specification between versions 1.0x and 2.0. Namely, while ACPI 2.0 and later wants us to put devices into low power states before calling _PTS,

Re: 2.6.24-rc4-mm1: acpi reboots machine... solved

2007-12-12 Thread Alexey Starikovskiy
Borislav Petkov wrote: On Tue, Dec 11, 2007 at 05:08:59PM -0700, Bjorn Helgaas wrote: On Tuesday 11 December 2007 01:52:55 pm Borislav Petkov wrote: From what i can roughly tell so far it seems like an resource conflict between acpi and the pnp requested regions in your patch which

Re: 2.6.24-rc4-mm1: acpi reboots machine... solved

2007-12-12 Thread Alexey Starikovskiy
Borislav Petkov wrote: On Tue, Dec 11, 2007 at 05:08:59PM -0700, Bjorn Helgaas wrote: On Tuesday 11 December 2007 01:52:55 pm Borislav Petkov wrote: From what i can roughly tell so far it seems like an resource conflict between acpi and the pnp requested regions in your patch which

Re: [PATCH] Fix segfault when printing battery status

2007-11-19 Thread Alexey Starikovskiy
Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: cat /sys/devices/LNXSYSTM:00/device:00/PNP0A08:00/device:19/PNP0C0A:00/power_ supply/BAT1/status This leads to a stacktrace as acpi_battery_get_property() returns 0 for a case where it does not set val->int

Re: [PATCH] Fix segfault when printing battery status

2007-11-19 Thread Alexey Starikovskiy
Rolf Eike Beer wrote: cat /sys/devices/LNXSYSTM:00/device:00/PNP0A08:00/device:19/PNP0C0A:00/power_supply/BAT1/status This leads to a stacktrace as acpi_battery_get_property() returns 0 for a case where it does not set val->intval. These value is used as an array index in

Re: [PATCH] Fix segfault when printing battery status

2007-11-19 Thread Alexey Starikovskiy
Rolf Eike Beer wrote: cat /sys/devices/LNXSYSTM:00/device:00/PNP0A08:00/device:19/PNP0C0A:00/power_supply/BAT1/status This leads to a stacktrace as acpi_battery_get_property() returns 0 for a case where it does not set val-intval. These value is used as an array index in

Re: [PATCH] Fix segfault when printing battery status

2007-11-19 Thread Alexey Starikovskiy
Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: cat /sys/devices/LNXSYSTM:00/device:00/PNP0A08:00/device:19/PNP0C0A:00/power_ supply/BAT1/status This leads to a stacktrace as acpi_battery_get_property() returns 0 for a case where it does not set val-intval

Re: 2.6.24-rc1: OOPS at acpi_battery_update

2007-11-13 Thread Alexey Starikovskiy
Nov 2007 12:36:43 +0300 Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: A> On Thu, 08 Nov 2007 19:35:23 +0300 Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: [remove_cycle_at_battery_removal.patch text/x-patch (1.7KB)] ACPI: Battery: remove cyc

Re: 2.6.24-rc1: OOPS at acpi_battery_update

2007-11-13 Thread Alexey Starikovskiy
Nov 2007 12:36:43 +0300 Alexey Starikovskiy [EMAIL PROTECTED] wrote: Andrew Morton wrote: A On Thu, 08 Nov 2007 19:35:23 +0300 Alexey Starikovskiy [EMAIL PROTECTED] wrote: [remove_cycle_at_battery_removal.patch text/x-patch (1.7KB)] ACPI: Battery: remove cycle from battery

Re: [PATCH] 2.6.24-rc2: fix oops in ACPI battery removal

2007-11-10 Thread Alexey Starikovskiy
Andrey, Fix already exists. It already went up to Len's tree. Regards, Alex. Andrey Borzenkov wrote: Alexey, this fixes my patch that went into -rc2. Sorry for Oops. Subject: [PATCH] 2.6.24-rc2: do not unregister power_supply in sysfs ->show method From: Andrey Borzenkov <[EMAIL PROTECTED]>

Re: [PATCH] 2.6.24-rc2: fix oops in ACPI battery removal

2007-11-10 Thread Alexey Starikovskiy
Andrey, Fix already exists. It already went up to Len's tree. Regards, Alex. Andrey Borzenkov wrote: Alexey, this fixes my patch that went into -rc2. Sorry for Oops. Subject: [PATCH] 2.6.24-rc2: do not unregister power_supply in sysfs -show method From: Andrey Borzenkov [EMAIL PROTECTED]

Re: 2.6.24-rc1: OOPS at acpi_battery_update

2007-11-09 Thread Alexey Starikovskiy
Andrew Morton wrote: A> On Thu, 08 Nov 2007 19:35:23 +0300 Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: [remove_cycle_at_battery_removal.patch text/x-patch (1.7KB)] ACPI: Battery: remove cycle from battery removal. From: Alexey Starikovskiy <[EMAIL PROTECTED]> get_pr

Re: 2.6.24-rc1: OOPS at acpi_battery_update

2007-11-09 Thread Alexey Starikovskiy
Andrew Morton wrote: A On Thu, 08 Nov 2007 19:35:23 +0300 Alexey Starikovskiy [EMAIL PROTECTED] wrote: [remove_cycle_at_battery_removal.patch text/x-patch (1.7KB)] ACPI: Battery: remove cycle from battery removal. From: Alexey Starikovskiy [EMAIL PROTECTED] get_property() should not call

Re: 2.6.24-rc1: OOPS at acpi_battery_update

2007-11-08 Thread Alexey Starikovskiy
t in order to not get stale data. Regards, Alex. ACPI: Battery: remove cycle from battery removal. From: Alexey Starikovskiy <[EMAIL PROTECTED]> get_property() should not call battery_update() on absent battery to avoid cycle and oops. Signed-off-by: Alexey Starikovskiy <[EMAIL PROTECTED]>

Re: 2.6.24-rc1: OOPS at acpi_battery_update

2007-11-08 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Thursday, 8 of November 2007, Johannes Weiner wrote: Hi, is there any reason, why acpi_battery_get_property() should call acpi_battery_update() at all? Alex? If someone wants to read stale values, he could comment out acpi_battery_update. Regards, Alex. - To

Re: 2.6.24-rc2 (esthetic?) regression: auto select interrupt spams my logs

2007-11-08 Thread Alexey Starikovskiy
Hi Romano, EC was changed to automatically choose it's working mode (poll vs. interrupt driven). You see it oscillating between modes because it receives interrupts just after it stops waiting for them. Please open new bug entry at bugzilla.kernel.org. Your .config might be usefull. Thanks,

Re: 2.6.24-rc2 (esthetic?) regression: auto select interrupt spams my logs

2007-11-08 Thread Alexey Starikovskiy
Hi Romano, EC was changed to automatically choose it's working mode (poll vs. interrupt driven). You see it oscillating between modes because it receives interrupts just after it stops waiting for them. Please open new bug entry at bugzilla.kernel.org. Your .config might be usefull. Thanks,

Re: 2.6.24-rc1: OOPS at acpi_battery_update

2007-11-08 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Thursday, 8 of November 2007, Johannes Weiner wrote: Hi, is there any reason, why acpi_battery_get_property() should call acpi_battery_update() at all? Alex? If someone wants to read stale values, he could comment out acpi_battery_update. Regards, Alex. - To

Re: 2.6.24-rc1: OOPS at acpi_battery_update

2007-11-08 Thread Alexey Starikovskiy
to not get stale data. Regards, Alex. ACPI: Battery: remove cycle from battery removal. From: Alexey Starikovskiy [EMAIL PROTECTED] get_property() should not call battery_update() on absent battery to avoid cycle and oops. Signed-off-by: Alexey Starikovskiy [EMAIL PROTECTED] Tested-by: Rolf Eike Beer

Re: [PATCH] 2.6.24: make /proc/acpi/ac_adapter dependent on ACPI_PROCFS

2007-11-03 Thread Alexey Starikovskiy
adapter register/unregister at on/off. Acked-by: Alexey Starikovskiy <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] 2.6.24: make /proc/acpi/ac_adapter dependent on ACPI_PROCFS

2007-11-03 Thread Alexey Starikovskiy
adapter register/unregister at on/off. Acked-by: Alexey Starikovskiy [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Alexey Starikovskiy
Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Rolf Eike Beer wrote: Hi, this happened while I removed my battery on bootup. Complete dmesg is attached. Kernel is 2.6.24-rc1-git of yesterday (last commit

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Alexey Starikovskiy
Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Rolf Eike Beer wrote: Hi, this happened while I removed my battery on bootup. Complete dmesg is attached. Kernel is 2.6.24-rc1-git of yesterday (last commit was d919fd433b5823d1cf9d0688eb2eec183de9b74c). Ok, I found out

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Alexey Starikovskiy
d oops. Signed-off-by: Alexey Starikovskiy <[EMAIL PROTECTED]> --- drivers/acpi/battery.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index c2ce0ad..50cdf6f 100644 --- a/drivers/acpi/battery.c +++ b/drivers/ac

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Alexey Starikovskiy
Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Rolf Eike Beer wrote: Hi, this happened while I removed my battery on bootup. Complete dmesg is attached. Kernel is 2.6.24-rc1-git of yesterday (last commit

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Alexey Starikovskiy
Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Rolf Eike Beer wrote: Hi, this happened while I removed my battery on bootup. Complete dmesg is attached. Kernel is 2.6.24-rc1-git of yesterday (last commit was d919fd433b5823d1cf9d0688eb2eec183de9b74c). Ok, I found out

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Alexey Starikovskiy
. Signed-off-by: Alexey Starikovskiy [EMAIL PROTECTED] --- drivers/acpi/battery.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index c2ce0ad..50cdf6f 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c

Re: [2.6.24-rc1 regression] AC adapter state does not change after resume

2007-10-30 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > On Wednesday 31 October 2007, Alexey Starikovskiy wrote: >> Andrey Borzenkov wrote: >>> I suspect new ACPI AC adapter code but have to add some printk's to be >>> sure. >>> >>> To reproduce - plug in AC cord, suspend, unplug,

Re: [2.6.24-rc1 regression] AC adapter state does not change after resume

2007-10-30 Thread Alexey Starikovskiy
patch helps. Regards, Alex. ACPI: AC: Update AC state on sysfs read From: Alexey Starikovskiy <[EMAIL PROTECTED]> Signed-off-by: Alexey Starikovskiy <[EMAIL PROTECTED]> --- drivers/acpi/ac.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/ac

Re: [2.6.24-rc1 regression] AC adapter state does not change after resume

2007-10-30 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > I suspect new ACPI AC adapter code but have to add some printk's to be sure. > > To reproduce - plug in AC cord, suspend, unplug, resume - kpowersave and > sysfs > still show AC adapter online. Or other way round. > > -andrey The only change to drivers/acpi/ac.c after

Re: [2.6.24-rc1 regression] AC adapter state does not change after resume

2007-10-30 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: I suspect new ACPI AC adapter code but have to add some printk's to be sure. To reproduce - plug in AC cord, suspend, unplug, resume - kpowersave and sysfs still show AC adapter online. Or other way round. -andrey The only change to drivers/acpi/ac.c after .23

Re: [2.6.24-rc1 regression] AC adapter state does not change after resume

2007-10-30 Thread Alexey Starikovskiy
. ACPI: AC: Update AC state on sysfs read From: Alexey Starikovskiy [EMAIL PROTECTED] Signed-off-by: Alexey Starikovskiy [EMAIL PROTECTED] --- drivers/acpi/ac.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c index e03de37..bb618c8

Re: [2.6.24-rc1 regression] AC adapter state does not change after resume

2007-10-30 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: On Wednesday 31 October 2007, Alexey Starikovskiy wrote: Andrey Borzenkov wrote: I suspect new ACPI AC adapter code but have to add some printk's to be sure. To reproduce - plug in AC cord, suspend, unplug, resume - kpowersave and sysfs still show AC adapter online

Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > On Saturday 27 October 2007, Alexey Starikovskiy wrote: >> Andrey Borzenkov wrote: >>> I am not exactly sure about this one ... what other power_supply class >>> drivers do? Should I fix HAL instead (but then, I do not know whether HAL

Re: [PATCH] 2.6.24-rc1: ensure "present" sysfs attribute even if battery is absent

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > I am not exactly sure about this one ... what other power_supply class > drivers > do? Should I fix HAL instead (but then, I do not know whether HAL is the only > application that is using this interface). > > Hm, do you need separate set of properties for that? You

Re: [2.624-rc1 regression] lost battery information

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > On Saturday 27 October 2007, Alexey Starikovskiy wrote: >> As you wish... :) Please check the attached patch. >> > > Not sure why you need to reimplement acpi_extract_package, but ... Take a look on memory allocations around it... :) > >

Re: [2.624-rc1 regression] lost battery information

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > On Saturday 27 October 2007, Alexey Starikovskiy wrote: >> Andrey, >> Please try the attached patch. I choose to do snprintf() instead of direct >> copy, as your previous message showed empty OEM type. >> > > Not quite. Now I get >

Re: [2.624-rc1 regression] lost battery information

2007-10-27 Thread Alexey Starikovskiy
Andrey, Please try the attached patch. I choose to do snprintf() instead of direct copy, as your previous message showed empty OEM type. Thanks, Alex. Andrey Borzenkov wrote: > On Friday 26 October 2007, Alexey Starikovskiy wrote: >> Your cat's "Bad address" means -EFAULT, acco

Re: [2.624-rc1 regression] lost battery information

2007-10-27 Thread Alexey Starikovskiy
Andrey, Please try the attached patch. I choose to do snprintf() instead of direct copy, as your previous message showed empty OEM type. Thanks, Alex. Andrey Borzenkov wrote: On Friday 26 October 2007, Alexey Starikovskiy wrote: Your cat's Bad address means -EFAULT, according to man errno

Re: [2.624-rc1 regression] lost battery information

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: On Saturday 27 October 2007, Alexey Starikovskiy wrote: Andrey, Please try the attached patch. I choose to do snprintf() instead of direct copy, as your previous message showed empty OEM type. Not quite. Now I get OEM info:0 Ok, I was hoping

Re: [2.624-rc1 regression] lost battery information

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: On Saturday 27 October 2007, Alexey Starikovskiy wrote: As you wish... :) Please check the attached patch. Not sure why you need to reimplement acpi_extract_package, but ... Take a look on memory allocations around it... :) Tested-by: Andrey Borzenkov [EMAIL

Re: [PATCH] 2.6.24-rc1: ensure present sysfs attribute even if battery is absent

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: I am not exactly sure about this one ... what other power_supply class drivers do? Should I fix HAL instead (but then, I do not know whether HAL is the only application that is using this interface). Hm, do you need separate set of properties for that? You could

Re: [PATCH] 2.6.24-rc1: ensure present sysfs attribute even if battery is absent

2007-10-27 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: On Saturday 27 October 2007, Alexey Starikovskiy wrote: Andrey Borzenkov wrote: I am not exactly sure about this one ... what other power_supply class drivers do? Should I fix HAL instead (but then, I do not know whether HAL is the only application that is using

Re: [2.624-rc1 regression] lost battery information

2007-10-26 Thread Alexey Starikovskiy
Frans Pop wrote: > Alexey Starikovskiy wrote: >> Andrey Borzenkov wrote: >>> is it in -rc1 or can you point me to the patch (I'd rather avoid having >>> to pull from different git trees). Thank you. >> No, it should be rc1. >>> And what about ACPI_PROCF

Re: [2.624-rc1 regression] lost battery information

2007-10-26 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > On Friday 26 October 2007, Alexey Starikovskiy wrote: >> Andrey Borzenkov wrote: >>> On Friday 26 October 2007, Alexey Starikovskiy wrote: >>>> Andrey Borzenkov wrote: >>>>> I have lost battery in 2.6.24-rc1. Without CONFIG_A

Re: [2.624-rc1 regression] lost battery information

2007-10-26 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: > On Friday 26 October 2007, Alexey Starikovskiy wrote: >> Andrey Borzenkov wrote: >>> I have lost battery in 2.6.24-rc1. Without CONFIG_ACPI_PROCFS I have >>> no /proc/acpi/battery and cannot test netlink interface because right n

Re: [2.624-rc1 regression] lost battery information

2007-10-26 Thread Alexey Starikovskiy
ebug_layer (/sys/module/acpi/parameters/debug_layer) > /proc/acpi/debug_level (/sys/module/acpi/parameters/debug_level) > > neither does it mention /proc/acpi/battery not do I actually have any battery > information in /sys. > > Personally I do not like it (if it is intenti

Re: [2.624-rc1 regression] lost battery information

2007-10-26 Thread Alexey Starikovskiy
on restart ... -andrey ACPI: use select POWER_SUPPLY for AC, BATTERY and SBS From: Alexey Starikovskiy [EMAIL PROTECTED] POWER_SUPPLY is needed for AC, battery, and SBS sysfs support. Use 'select' instead of 'depends on', as it is will not be selected by anything else, leading to confusion

Re: [2.624-rc1 regression] lost battery information

2007-10-26 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: On Friday 26 October 2007, Alexey Starikovskiy wrote: Andrey Borzenkov wrote: I have lost battery in 2.6.24-rc1. Without CONFIG_ACPI_PROCFS I have no /proc/acpi/battery and cannot test netlink interface because right now there is no consumer of this. for /sysfs

Re: [2.624-rc1 regression] lost battery information

2007-10-26 Thread Alexey Starikovskiy
Andrey Borzenkov wrote: On Friday 26 October 2007, Alexey Starikovskiy wrote: Andrey Borzenkov wrote: On Friday 26 October 2007, Alexey Starikovskiy wrote: Andrey Borzenkov wrote: I have lost battery in 2.6.24-rc1. Without CONFIG_ACPI_PROCFS I have no /proc/acpi/battery and cannot test

Re: [2.624-rc1 regression] lost battery information

2007-10-26 Thread Alexey Starikovskiy
Frans Pop wrote: Alexey Starikovskiy wrote: Andrey Borzenkov wrote: is it in -rc1 or can you point me to the patch (I'd rather avoid having to pull from different git trees). Thank you. No, it should be rc1. And what about ACPI_PROCFS case? It still needs attention I believe. As you can see

Re: [2.6 patch] acpi/ec.c: fix use-after-free

2007-10-24 Thread Alexey Starikovskiy
Adrian Bunk wrote: > On Wed, Oct 24, 2007 at 09:15:18PM +0400, Alexey Starikovskiy wrote: >> Adrian, >> >> commit 30c08574da0ead1a47797ce028218ce5b2de61c7 can not introduce >> use-after-free. >> >> Please check... > > > Commit 30c08574da0e

Re: [2.6 patch] acpi/battery.c: remove dead code

2007-10-24 Thread Alexey Starikovskiy
Adrian Bunk wrote: > After commit f1d4661abe05d0a2c014166042d15ed8b69ae8f2 this was dead > code. > > Spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked. Thanks. > > --- > --- linux-2.6/drivers/acpi/battery.c.old 2007-10-23 18:44:13.0 > +0200

Re: [2.6 patch] acpi/ec.c: fix use-after-free

2007-10-24 Thread Alexey Starikovskiy
Adrian, commit 30c08574da0ead1a47797ce028218ce5b2de61c7 can not introduce use-after-free. Please check... Regards, Alex. Adrian Bunk wrote: > This patch fixes a use-after-free introduced by > commit 30c08574da0ead1a47797ce028218ce5b2de61c7. > > Spotted by the Coverity checker. > >

Re: [2.6 patch] acpi/ec.c: fix use-after-free

2007-10-24 Thread Alexey Starikovskiy
Adrian, commit 30c08574da0ead1a47797ce028218ce5b2de61c7 can not introduce use-after-free. Please check... Regards, Alex. Adrian Bunk wrote: This patch fixes a use-after-free introduced by commit 30c08574da0ead1a47797ce028218ce5b2de61c7. Spotted by the Coverity checker. Signed-off-by:

Re: [2.6 patch] acpi/battery.c: remove dead code

2007-10-24 Thread Alexey Starikovskiy
Adrian Bunk wrote: After commit f1d4661abe05d0a2c014166042d15ed8b69ae8f2 this was dead code. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked. Thanks. --- --- linux-2.6/drivers/acpi/battery.c.old 2007-10-23 18:44:13.0 +0200 +++

Re: [2.6 patch] acpi/ec.c: fix use-after-free

2007-10-24 Thread Alexey Starikovskiy
Adrian Bunk wrote: On Wed, Oct 24, 2007 at 09:15:18PM +0400, Alexey Starikovskiy wrote: Adrian, commit 30c08574da0ead1a47797ce028218ce5b2de61c7 can not introduce use-after-free. Please check... Commit 30c08574da0ead1a47797ce028218ce5b2de61c7 did: -- snip

Re: latest 2.6.23 git missing ACPI POWER_SUPPLY

2007-10-22 Thread Alexey Starikovskiy
bscribe linux-acpi" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > ACPI: use select POWER_SUPPLY for AC, BATTERY and SBS From: Alexey Starikovskiy <[EMAIL PROTECTED]> POWER_SUPPLY is needed for AC, batte

Re: latest 2.6.23 git missing ACPI POWER_SUPPLY

2007-10-22 Thread Alexey Starikovskiy
://vger.kernel.org/majordomo-info.html ACPI: use select POWER_SUPPLY for AC, BATTERY and SBS From: Alexey Starikovskiy [EMAIL PROTECTED] POWER_SUPPLY is needed for AC, battery, and SBS sysfs support. Use 'select' instead of 'depends on', as it is will not be selected by anything else, leading

Re: halt does not shut the system down

2007-10-17 Thread Alexey Starikovskiy
John Sigler wrote: > Alexey Starikovskiy wrote: > >> John Sigler wrote: >> >>> +===+ >>> | Soft-Off by PWR-BTTN | >>> |

Re: halt does not shut the system down

2007-10-17 Thread Alexey Starikovskiy
John Sigler wrote: Alexey Starikovskiy wrote: John Sigler wrote: +===+ | Soft-Off by PWR-BTTN | |---| | Instant-Off . [v]| | Delay 4 Sec

Re: halt does not shut the system down

2007-10-16 Thread Alexey Starikovskiy
John Sigler wrote: > +===+ > | Soft-Off by PWR-BTTN | > |---| > | Instant-Off . [v]| > | Delay 4 Sec. . [ ]| > |

Re: halt does not shut the system down

2007-10-16 Thread Alexey Starikovskiy
John Sigler wrote: +===+ | Soft-Off by PWR-BTTN | |---| | Instant-Off . [v]| | Delay 4 Sec. . [ ]| |

Re: halt does not shut the system down

2007-10-15 Thread Alexey Starikovskiy
John Sigler wrote: > Alexey Starikovskiy wrote: > >> John Sigler wrote: >> >>> Alexey Starikovskiy wrote: >>> >>>> Could you please open bug at bugzilla.kernel.org and put all >>>> these files there? >>> >>> http

Re: halt does not shut the system down

2007-10-15 Thread Alexey Starikovskiy
John Sigler wrote: > John Sigler wrote: > >> Alexey Starikovskiy wrote: >> >>> Could you please open bug at bugzilla.kernel.org and put all these >>> files there? >> >> http://bugzilla.kernel.org/show_bug.cgi?id=9148 > > Writing 15361 (i.e. 0

Re: halt does not shut the system down

2007-10-15 Thread Alexey Starikovskiy
John Sigler wrote: John Sigler wrote: Alexey Starikovskiy wrote: Could you please open bug at bugzilla.kernel.org and put all these files there? http://bugzilla.kernel.org/show_bug.cgi?id=9148 Writing 15361 (i.e. 0x3C01) to ACPI_REGISTER_PM1A_CONTROL appears to hang my system

Re: halt does not shut the system down

2007-10-15 Thread Alexey Starikovskiy
John Sigler wrote: Alexey Starikovskiy wrote: John Sigler wrote: Alexey Starikovskiy wrote: Could you please open bug at bugzilla.kernel.org and put all these files there? http://bugzilla.kernel.org/show_bug.cgi?id=9148 Writing 15361 (i.e. 0x3C01) to ACPI_REGISTER_PM1A_CONTROL appears

Re: halt does not shut the system down

2007-10-12 Thread Alexey Starikovskiy
Could you please open bug at bugzilla.kernel.org and put all these files there? Thanks, Alex. John Sigler wrote: John Sigler wrote: When I run 'halt' the kernel prints: Halting. Shutdown: hdc ACPI: PCI interrupt for device :01:05.0 disabled ACPI: PCI interrupt for device :01:04.0

Re: halt does not shut the system down

2007-10-12 Thread Alexey Starikovskiy
Could you please open bug at bugzilla.kernel.org and put all these files there? Thanks, Alex. John Sigler wrote: John Sigler wrote: When I run 'halt' the kernel prints: Halting. Shutdown: hdc ACPI: PCI interrupt for device :01:05.0 disabled ACPI: PCI interrupt for device :01:04.0

Re: regression in 2.6.23-rc8 - power off failed

2007-10-01 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Saturday, 29 September 2007 22:47, Bill Davidsen wrote: Alexey Starikovskiy wrote: -static void -acpi_power_off (void) -{ - printk("%s called\n",__FUNCTION__); - /* Some SMP machines only can poweroff in boot CPU */ - set_cpus_allow

Re: regression in 2.6.23-rc8 - power off failed

2007-10-01 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: On Saturday, 29 September 2007 22:47, Bill Davidsen wrote: Alexey Starikovskiy wrote: -static void -acpi_power_off (void) -{ - printk(%s called\n,__FUNCTION__); - /* Some SMP machines only can poweroff in boot CPU */ - set_cpus_allowed(current

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Alexey Starikovskiy
Mark Lord wrote: Wolfgang Erig wrote: On Sat, Sep 29, 2007 at 01:30:33AM -0700, H. Peter Anvin wrote: Wolfgang Erig wrote: Both are bad. Two different systems and two different bisections. I sent the last step of each. $ git bisect good Bisecting: 0 revisions left to test after this

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Alexey Starikovskiy
Hi, This is known issue. Please try latest rc8-git2, it should contain the fix. Regards, Alex. Wolfgang Erig wrote: Hi, the latest kernel does not power off my system. 2.6.22 succeeded 2.6.23-rc8 failed $ git bisect bad Bisecting: 0 revisions left to test after this

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Alexey Starikovskiy
Hi, This is known issue. Please try latest rc8-git2, it should contain the fix. Regards, Alex. Wolfgang Erig wrote: Hi, the latest kernel does not power off my system. 2.6.22 succeeded 2.6.23-rc8 failed $ git bisect bad Bisecting: 0 revisions left to test after this

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Alexey Starikovskiy
Mark Lord wrote: Wolfgang Erig wrote: On Sat, Sep 29, 2007 at 01:30:33AM -0700, H. Peter Anvin wrote: Wolfgang Erig wrote: Both are bad. Two different systems and two different bisections. I sent the last step of each. $ git bisect good Bisecting: 0 revisions left to test after this

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Torsten Kaiser wrote: > Back to debugging this: > http://marc.info/?l=linux-acpi=119052970904643=4 > fails to apply against 2.6.23-rc7-mm1, but moving that function by > hand was not to difficult. ;) > (With only the second patch I got a link error...) > >

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Torsten Kaiser wrote: > On 9/25/07, Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: >> Torsten Kaiser wrote: >>> No, I do not have CONFIG_ACPI_SLEEP set, >>> because I do not have CONFIG_PM_SLEEP set, >>> because I do not want SUSPEND and/or HIBER

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Andrew, There are 2 patches, this is the second. Above, Rafael gave link to first. Here it is again: http://marc.info/?l=linux-kernel=119052978117735=4 Sorry for confusion, Alex. Andrew Morton wrote: > On Tue, 25 Sep 2007 18:45:15 +0400 Alexey Starikovskiy <[EMAIL PROTECTED]>

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: > On Tuesday, 25 September 2007 16:19, Alexey Starikovskiy wrote: >> Rafael J. Wysocki wrote: >>> On Tuesday, 25 September 2007 15:15, Alexey Starikovskiy wrote: >>>> Rafael J. Wysocki wrote: >>>>> On Tuesday, 25 Se

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: > On Tuesday, 25 September 2007 15:15, Alexey Starikovskiy wrote: >> Rafael J. Wysocki wrote: >>> On Tuesday, 25 September 2007 14:53, Alexey Starikovskiy wrote: >>>> Rafael J. Wysocki wrote: >>>>> On Tuesday, 25 Se

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: > On Tuesday, 25 September 2007 14:53, Alexey Starikovskiy wrote: >> Rafael J. Wysocki wrote: >>> On Tuesday, 25 September 2007 14:05, Alexey Starikovskiy wrote: >>>> Rafael J. Wysocki wrote: >>>>> On Tuesday, 25

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Rafael J. Wysocki wrote: > On Tuesday, 25 September 2007 14:05, Alexey Starikovskiy wrote: >> Rafael J. Wysocki wrote: >>> On Tuesday, 25 September 2007 13:45, Rafael J. Wysocki wrote: >>>> On Tuesday, 25 September 2007 11:58, Damien Wyart wrote: >>>>&

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
> > Greetings, > Rafael > - > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > ACPI: suspend: fix ACPI_SLEEP states From:

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Daniel, thanks for the patch, but patch for solving your issue is already done. And it is different from one we having here. If you feel "patchy" today you may try to remove ACPI_SLEEP from drivers/acpi/sleep/Makefile in the raw of main.o Regards, Alex. Daniel Ritz wrote: > does that one help?

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Alexey Starikovskiy
Torsten Kaiser wrote: > On 9/25/07, Alexey Starikovskiy <[EMAIL PROTECTED]> wrote: >> Do you have CONFIG_ACPI_SLEEP enabled in your .config? > > I'm answering that too, because I suspect that my "2.6.23-rc7-mm1 does > not power off"-error might have the

  1   2   3   >