[PATCH] Minor improvement for smsc95xx netusb driver performance.

Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%, or reduce CPU usage on a comparable value. Signed-off-by: Ameen Ali --- drivers/net/usb/smsc95xx.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/usb

[PATCH] Minor improvement for smsc95xx netusb driver performance.

Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%, or reduce CPU usage on a comparable value. Signed-off-by: Ameen Ali <ameenali...@gmail.com> --- drivers/net/usb/smsc95xx.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff

[PATCH 2/2] Minor improvement for smsc95xx netusb driver performance.

Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%. or reduce CPU usage on a comparable value. Signed-off-by: Ameen Ali --- drivers/net/usb/smsc95xx.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb/smsc95xx.c

[PATCH 3/3] Minor improvement for smsc95xx netusb driver performance.

Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%. or reduce cpu usage on a comparable value. Signed-off-by: Ameen Ali --- drivers/net/usb/smsc95xx.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb

[PATCH 3/3] Minor improvement for smsc95xx netusb driver performance.

Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%. or reduce cpu usage on a comparable value. Signed-off-by: Ameen Ali --- drivers/net/usb/smsc95xx.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb

[PATCH 2/2] updating for keypayload null check.

adding NULL check to make it fail safe. Signed-Off-By : Ameen Ali --- crypto/asymmetric_keys/x509_public_key.c | 4 1 file changed, 4 insertions(+) diff --git a/crypto/asymmetric_keys/x509_public_key.c b/crypto/asymmetric_keys/x509_public_key.c index 2a44b37..76610cc 100644 --- a/crypto

[PATCH] Update ratelimit.c

fix a bug in ratelimit, if the "begin" doesn't update at the same time with printed the print will start from 1 in loops except for the first time, lets to only 9 logs suppressed, but not 10 as expected. Signed-off-by : Ameen Ali --- lib/ratelimit.c | 4 +--- 1 file changed, 1 inser

[PATCH 3/3] Minor improvement for smsc95xx netusb driver performance.

Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%. or reduce cpu usage on a comparable value. Signed-off-by: Ameen Ali <ameenali...@gmail.com> --- drivers/net/usb/smsc95xx.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff

[PATCH 3/3] Minor improvement for smsc95xx netusb driver performance.

Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%. or reduce cpu usage on a comparable value. Signed-off-by: Ameen Ali <ameenali...@gmail.com> --- drivers/net/usb/smsc95xx.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff

[PATCH] Update ratelimit.c

fix a bug in ratelimit, if the "begin" doesn't update at the same time with printed the print will start from 1 in loops except for the first time, lets to only 9 logs suppressed, but not 10 as expected. Signed-off-by : Ameen Ali <ameenali...@gmail.com> --- lib/ratelimit.c

[PATCH 2/2] updating for keypayload null check.

adding NULL check to make it fail safe. Signed-Off-By : Ameen Ali <ameenali...@gmail.com> --- crypto/asymmetric_keys/x509_public_key.c | 4 1 file changed, 4 insertions(+) diff --git a/crypto/asymmetric_keys/x509_public_key.c b/crypto/asymmetric_keys/x509_public_key.c index 2

[PATCH 2/2] Minor improvement for smsc95xx netusb driver performance.

Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%. or reduce CPU usage on a comparable value. Signed-off-by: Ameen Ali <ameenali...@gmail.com> --- drivers/net/usb/smsc95xx.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[PATCH 14/14] drivers/tty/vt/vt.c : access out-of-bounds

make sure that out-of-bounds never happens Signed-off-by : Ameen Ali --- drivers/tty/vt/vt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 6e00572..cf73e92 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty

[PATCH 14/14] drivers/tty/vt/vt.c : access out-of-bounds

make sure that out-of-bounds never happens Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/tty/vt/vt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 6e00572..cf73e92 100644 --- a/drivers/tty/vt

[PATCH 13/13] builtin-sched.c %ld in format string %ld in format string requires 'long' but the argument type is 'unsigned long'.

Signed-off-by: Ameen Ali --- tools/perf/builtin-sched.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index 891c393..dbc417a 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin

[PATCH 12/12] crypto/sha-mb/sha1_mb.c : Syntax error

fixing a syntax-error . Signed-off-by : Ameen Ali --- arch/x86/crypto/sha-mb/sha1_mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c index fd9f6b0..ec0b989 100644 --- a/arch/x86/crypto/sha-mb/sha1_mb.c

[PATCH 12/12] crypto/sha-mb/sha1_mb.c : Syntax error

fixing a syntax-error . Signed-off-by : Ameen Ali --- arch/x86/crypto/sha-mb/sha1_mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c index fd9f6b0..ec0b989 100644 --- a/arch/x86/crypto/sha-mb/sha1_mb.c

[PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset

The 2nd memset() argument '286331153' doesn't fit into an 'unsigned char'. Signed-off-by : --- drivers/dma/iop-adma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c index 263d9f6..78382b0 100644 --- a/drivers/dma/iop-adma.c

[PATCH 10/11] arch/arm/mach-s3c24xx/mach-osiris-dvs.c: use "&&" (not "&") with bool operands

bitwise AND ("&") was used in logical expressions with operands having "bool" type. Replaced bitwise AND operators with logical AND. Signed-off-by : Ameen Ali http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 10/10] mach-osiris-dvs.c : use "&&" (not "&") with bool operands

itwise AND ("&") was used in logical expressions with operands having "bool" type. Replaced bitwise AND operators with logical AND. Signed-off-by : http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 9/9] tulip_core.c : out-of-bounds check.

Array index 'j' is used before limits check. Suggest put limit check before index use. Signed-off-by : --- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c

[PATCH 8/8] kdb_bp.c:42: pointless test

Checking if unsigned variable 'bp_type' is less than zero. Signed-off-by : --- kernel/debug/kdb/kdb_bp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c index e1dbf4a..7ad82e7 100644 --- a/kernel/debug/kdb/kdb_bp.c +++

[PATCH 7/7] common.c:105 Variable 'gephy' is never used.

Variable 'gephy' is assigned a value that is never used. Signed-off-by : --- arch/arm/mach-dove/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c index 0d1a892..115a413 100644 --- a/arch/arm/mach-dove/common.c

[PATCH 12/12] crypto/sha-mb/sha1_mb.c : Syntax error

fixing a syntax-error . Signed-off-by : Ameen Ali ameenali...@gmail.com --- arch/x86/crypto/sha-mb/sha1_mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c index fd9f6b0..ec0b989 100644 --- a/arch/x86/crypto

[PATCH 13/13] builtin-sched.c %ld in format string %ld in format string requires 'long' but the argument type is 'unsigned long'.

Signed-off-by: Ameen Ali ameenali...@gmail.com --- tools/perf/builtin-sched.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index 891c393..dbc417a 100644 --- a/tools/perf/builtin-sched.c

[PATCH 12/12] crypto/sha-mb/sha1_mb.c : Syntax error

fixing a syntax-error . Signed-off-by : Ameen Ali ameenali...@gmail.com --- arch/x86/crypto/sha-mb/sha1_mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c index fd9f6b0..ec0b989 100644 --- a/arch/x86/crypto

[PATCH 10/10] mach-osiris-dvs.c : use (not ) with bool operands

itwise AND () was used in logical expressions with operands having bool type. Replaced bitwise AND operators with logical AND. Signed-off-by : ameenali...@gmail.com --- arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 10/11] arch/arm/mach-s3c24xx/mach-osiris-dvs.c: use (not ) with bool operands

bitwise AND () was used in logical expressions with operands having bool type. Replaced bitwise AND operators with logical AND. Signed-off-by : Ameen Ali ameenali...@gmail.com --- arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 11/11] iop-adma.c:1129: possible bad parameter in memset

The 2nd memset() argument '286331153' doesn't fit into an 'unsigned char'. Signed-off-by : ameenali...@gmail.com --- drivers/dma/iop-adma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c index 263d9f6..78382b0 100644 ---

[PATCH 7/7] common.c:105 Variable 'gephy' is never used.

Variable 'gephy' is assigned a value that is never used. Signed-off-by : ameenali...@gmail.com --- arch/arm/mach-dove/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c index 0d1a892..115a413 100644 ---

[PATCH 9/9] tulip_core.c : out-of-bounds check.

Array index 'j' is used before limits check. Suggest put limit check before index use. Signed-off-by : ameenali...@gmail.com --- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c

[PATCH 8/8] kdb_bp.c:42: pointless test

Checking if unsigned variable 'bp_type' is less than zero. Signed-off-by : ameenali...@gmail.com --- kernel/debug/kdb/kdb_bp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c index e1dbf4a..7ad82e7 100644 ---

[PATCH 6/6] qlcnic_dcb.c : possible division by zero.

Whenever there is a division it is usually worthwhile to add some belt'n'braces code to ensure that cnt != 0, otherwise a machine signal can occur. Signed-off-by : Ameen Ali --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 6/6] qlcnic_dcb.c : possible division by zero.

Whenever there is a division it is usually worthwhile to add some belt'n'braces code to ensure that cnt != 0, otherwise a machine signal can occur. Signed-off-by : Ameen Ali --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 5/5] ohci-tmio.c : missing 'break' statements

Redundant bitwise operation on 'pm' in 'switch' statement. Signed-off-by : Ameen Ali --- drivers/usb/host/ohci-tmio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c index e9a6eec..c580615 100644 --- a/drivers/usb/host/ohci

[PATCH 4/4] net/core/dev.c : Race condition in net_tx_action.

Transmitting asynchronously on all the network devices available we will notice the following behaviour: a) The instruction "if (sd->completion_queue) {" saves on a CPU register the pointer value (register contents is used for the comparison) b) The interupt is disabled (using

[PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

else if at line 406 has the same condition as the else if at line 404. i chosed 0x5 because it's half 0xb (just a rate controller) Signed-off-by : Ameen Ali --- drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 4/4] net/core/dev.c : Race condition in net_tx_action.

Transmitting asynchronously on all the network devices available we will notice the following behaviour: a) The instruction if (sd-completion_queue) { saves on a CPU register the pointer value (register contents is used for the comparison) b) The interupt is disabled (using local_irq_disable)

[PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

else if at line 406 has the same condition as the else if at line 404. i chosed 0x5 because it's half 0xb (just a rate controller) Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 5/5] ohci-tmio.c : missing 'break' statements

Redundant bitwise operation on 'pm' in 'switch' statement. Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/usb/host/ohci-tmio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c index e9a6eec..c580615 100644

[PATCH 6/6] qlcnic_dcb.c : possible division by zero.

Whenever there is a division it is usually worthwhile to add some belt'n'braces code to ensure that cnt != 0, otherwise a machine signal can occur. Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 6/6] qlcnic_dcb.c : possible division by zero.

Whenever there is a division it is usually worthwhile to add some belt'n'braces code to ensure that cnt != 0, otherwise a machine signal can occur. Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

else if at line 406 has the same condition as the else if at line 404. Signed-off-by : Ameen Ali --- drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging

[PATCH 2/2] cosa.c : Array index 'i' is used before limits check.

avoid out-of-bounds-read by checking count before indexing. Signed-off-by: Ameen Ali --- drivers/net/wan/cosa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c index 83c39e2..5252e21 100644 --- a/drivers/net/wan/cosa.c +++ b

[PATCH] dcssblk.c : Array index 'i' is used before limits check.

avoid out-of-bounds-read by checking count before indexing. Signed-off-by : Ameen Ali --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281 100644 --- a/drivers/s390

[PATCH] dcssblk.c : Array index 'i' is used before limits check.

Signed-off-by : Ameen Ali --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -547,7

[PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

else if at line 406 has the same condition as the else if at line 404. Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c

[PATCH 2/2] cosa.c : Array index 'i' is used before limits check.

avoid out-of-bounds-read by checking count before indexing. Signed-off-by: Ameen Ali ameenali...@gmail.com --- drivers/net/wan/cosa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c index 83c39e2..5252e21 100644 --- a/drivers

[PATCH] dcssblk.c : Array index 'i' is used before limits check.

Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390

[PATCH] dcssblk.c : Array index 'i' is used before limits check.

avoid out-of-bounds-read by checking count before indexing. Signed-off-by : Ameen Ali ameenali...@gmail.com --- drivers/s390/block/dcssblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 96128cb..da21281

[PATCH] __aligned(size) is preferred over __attribute__((aligned(size)))

Signed-off-by: Ameen Ali --- net/compat.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/compat.c b/net/compat.c index 3236b41..49c6a8f 100644 --- a/net/compat.c +++ b/net/compat.c @@ -508,25 +508,25 @@ COMPAT_SYSCALL_DEFINE5(getsockopt, int, fd, int, level

[PATCH] __aligned(size) is preferred over __attribute__((aligned(size)))

Signed-off-by: Ameen Ali ameenali...@gmail.com --- net/compat.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/compat.c b/net/compat.c index 3236b41..49c6a8f 100644 --- a/net/compat.c +++ b/net/compat.c @@ -508,25 +508,25 @@ COMPAT_SYSCALL_DEFINE5(getsockopt

[PATCH 2/2] staging: replace simple_strtoul with kstroul

Replacing obsolete simple_stroul with kstroul Signed-off-by: Ameen Ali --- kernel/printk/printk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index c06df7d..058302c 100644 --- a/kernel/printk/printk.c +++ b/kernel

[PATCH 2/2] staging: replace simple_strtoul with kstroul

Replacing obsolete simple_stroul with kstroul Signed-off-by: Ameen Ali ameenali...@gmail.com --- kernel/printk/printk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index c06df7d..058302c 100644 --- a/kernel/printk

[PATCH] audit.c : Code clean up

Fixed a coding style issue (unnecessary parentheses , unnecessary braces) Signed-off-by: Ameen-Ali --- kernel/audit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index 72ab759..0607e12 100644 --- a/kernel/audit.c +++ b/kernel/audit.c

[PATCH] audit.c : Code clean up

Fixed a coding style issue (unnecessary parentheses , unnecessary braces) Signed-off-by: Ameen-Ali ameenali...@gmail.com --- kernel/audit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index 72ab759..0607e12 100644 --- a/kernel/audit.c