[PATCH 1/2] leds: blinkm: constify attribute_group structure

-blinkm.o File size after: text data bss dec hex filename 8753 3400 64 122172fb9 drivers/leds/leds-blinkm.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/leds/leds-blinkm.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/2] leds: lm3533: constify attribute_group structure

-lm3533.o File size after: text data bss dec hex filename 8368 4512 64 129443290 drivers/leds/leds-lm3533.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/leds/leds-lm3533.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] imon: constify attribute_group structures

File size after: text data bss dec hex filename 3717316584 960 54717d5bd drivers/media/rc/imon.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/media/rc/imon.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] thunderbolt: constify attribute_group structure

/switch.o File size after: text data bss dec hex filename 28661 7204 0 358658c19 drivers/thunderbolt/switch.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/thunderbolt/switch.c | 2 +- 1 file changed, 1 insertion

[PATCH] loop: constify attribute_group structure

File size after: text data bss dec hex filename 28320 5421 480 3422185ad drivers/block/loop.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] ACPI / dock: constify attribute_group structure

File size after: text data bss dec hex filename 7998 3432 64 114942ce6 drivers/acpi/dock.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/acpi/dock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] atm: solos-pci: constify attribute_group structures

File size after: text data bss dec hex filename 3593228232 832 64996fde4 drivers/atm/solos-pci.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/atm/solos-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 1/2] atm: adummy: constify attribute_group structure

File size after: text data bss dec hex filename 2129 1352 03481 d99 drivers/atm/adummy.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/atm/adummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] staging: greybus: Remove unnecessary platform_set_drvdata

platform_device *pdev; @@ - platform_set_drvdata(pdev, NULL); // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/greybus/arche-platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index eced2d2

[PATCH] staging: unisys: visorchipset: constify attribute_group structure

/visorbus/visorchipset.o File size after: text data bss dec hex filename 242206120 448 307887844 drivers/staging/unisys/visorbus/visorchipset.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/unisys/visorbus

[PATCH] staging: unisys: visorbus_main: constify attribute_group structures

/visorbus/visorbus_main.o File size after: text data bss dec hex filename 144087112 832 223525750 drivers/staging/unisys/visorbus/visorbus_main.o This change was made with the help of Coccinelle. Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/unisys/visorbus

[PATCH v2] staging: media: atomisp: Use kvfree() instead of kfree()/vfree()

: // @@ expression a; @@ - if(...) { vfree(a); } - else { kfree(a); } + kvfree(a); // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Remove wrapper function .../staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 19 +++ .../staging/media/atomisp/pci/atomisp2

Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree()

On Sat, Jul 8, 2017 at 4:58 AM, Bernd Petrovitsch wrote: > On Fri, 2017-07-07 at 20:41 -0400, Amitoj Kaur Chawla wrote: > [...] >> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c >> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c >> @

[PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree()

); } - else { kfree(a); } + kvfree(a); @@ expression a; @@ - if(...) { kfree(a); } - else { vfree(a); } + kvfree(a); // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers

[PATCH 1/2] staging: media: atomisp2: css2400: Replace kfree()/vfree() with kvfree()

); @@ expression a; @@ - if(...) { kfree(a); } - else { vfree(a); } + kvfree(a); // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400

[PATCH] staging: comedi: Use offset_in_page macro

Use offset_in_page macro instead of (var & ~PAGE_MASK) The Coccinelle semantic patch used to make this change is as follows: // @@ unsigned long p; @@ - p & ~PAGE_MASK + offset_in_page(p) // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/comedi/comedi_buf.c | 2 +- 1 file ch

[PATCH] staging: media: atomisp: Remove unnecessary return statement in void function

Return statement at the end of a void function is useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/media/atomisp/pci/at

[PATCH] staging: rtl8723bs: Remove unnecessary cast in kfree

Remove unnecassary casts in the argument to kfree. Found using Coccinelle. The semantic patch used to find this is as follows: // @@ type T; expression *f; @@ - kfree((T *)(f)); + kfree(f); // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 14

Re: [Cocci] [PATCH v3] Coccinelle: Script to replace allocate and memset with zalloc functions

On Mon, Aug 1, 2016 at 4:53 PM, SF Markus Elfring wrote: >> +@vz1 depends on patch && !context && !org && !report@ >> +type T; >> +T *d; >> +statement S; >> +@@ >> + >> +d = >> +-vmalloc >> ++vzalloc >> + (...); >> +if (!d) S >> +- memset(d

[PATCH v2] drm/tegra: dpaux: Modify error handling

urn - ... + PTR_ERR(e) ; ...+> } Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Correct typo drivers/gpu/drm/tegra/dpaux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 059f409..2

[PATCH] drm/nouveau/tegra: Modify error handling

iommu_domain_alloc returns NULL on error so replace an incorrect IS_ERR check with a NULL check. The Coccinelle semantic patch used to find this issue is as follows: @@ expression e; statement S; @@ *e = iommu_domain_alloc(...); if (IS_ERR(e)) S Signed-off-by: Amitoj Kaur Chawla --- drivers

[PATCH] drm/tegra: dpaux: Modify error handling

urn - ... + PTR_ERR(e) ; ...+> } Signed-off-by: Amitoj Kaur Chawla --- drivers/gpu/drm/tegra/dpaux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 059f409..2fde44c 100644 --- a/drivers/gpu/drm

[PATCH] MIPS: ath79: Modify error handling

Kaur Chawla --- arch/mips/ath79/clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/ath79/clock.c b/arch/mips/ath79/clock.c index 2e73784..cc3a1e3 100644 --- a/arch/mips/ath79/clock.c +++ b/arch/mips/ath79/clock.c @@ -96,7 +96,7 @@ static struct clk * __init

[PATCH] sunrpc: Remove unnecessary variable

The variable `err` is not used anywhere and just returns the predefined value `0` at the end of the function. Hence, remove the variable and return 0 explicitly. Signed-off-by: Amitoj Kaur Chawla --- net/sunrpc/clnt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net

[PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

This script detects cases which have incorrect error handling for devm_ioremap_resource function, employing a NULL test instead of an IS_ERR() test. Acked-by: Julia Lawall Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Changed script to correct error handling instead of just

[PATCH] drm/amdgpu: Modify error handling in amdgpu_ttm

; @@ * e = debugfs_create_file(...); ... when != e == NULL e->f Signed-off-by: Amitoj Kaur Chawla --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 8a17

[PATCH] drm/amdgpu: Modify error handling

; @@ * e = debugfs_create_file(...); ... when != e == NULL e->f Signed-off-by: Amitoj Kaur Chawla --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c in

[PATCH] iommu/exynos: Modify error handling

) { <+... return - PTR_ERR(e) + -ENODEV ; ...+> } Signed-off-by: Amitoj Kaur Chawla --- drivers/iommu/exynos-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 97c41b8..2888bbf 100644 --- a/drivers/iommu/

[PATCH v3] Coccinelle: Script to replace allocate and memset with zalloc functions

This script finds instances of allocate and memset which can be replaced with a direct call to zalloc equivalent of a function. Signed-off-by: Amitoj Kaur Chawla Acked-by: Julia Lawall --- Changes in v2: -Modified commit message and subject Changes in v3: -Modified comment

[PATCH] i2c: Modify error handling

...; + return PTR_ERR(e); } Signed-off-by: Amitoj Kaur Chawla --- drivers/media/i2c/adp1653.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c/adp1653.c index 7e9cbf7..54b355e 100644 --- a/drivers/media/i2c/adp1653.c +++ b/drivers

[PATCH] s390/pci: Remove unnecessary if condition

: Amitoj Kaur Chawla --- arch/s390/pci/pci_debug.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/s390/pci/pci_debug.c b/arch/s390/pci/pci_debug.c index 4129b0a..8a25b04 100644 --- a/arch/s390/pci/pci_debug.c +++ b/arch/s390/pci/pci_debug.c @@ -139,8 +139,6 @@ void zpci_debug_init_device

[PATCH] MIPS: Modify error handling

ERR(e) + -ENOMEM ; ...+> } Signed-off-by: Amitoj Kaur Chawla --- arch/mips/mm/sc-debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/mm/sc-debugfs.c b/arch/mips/mm/sc-debugfs.c index 5eefe32..01f1154 100644 --- a/arch/mips/mm/sc-debugfs.c +++ b/arc

[PATCH v2] Coccinelle: Script to replace allocate and memset with zalloc functions

This script finds instances of allocate and memset which can be replaced with a direct call to zalloc equivalent of a function. Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Modified commit message and subject scripts/coccinelle/api/zalloc.cocci | 556

[PATCH v2] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

This script detects cases which have incorrect error handling for devm_ioremap_resource function, employing a NULL test instead of an IS_ERR() test. Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Changed script to correct error handling instead of just detecting cases of

[PATCH] Coccinelle: Script to replace allocate and memcpy with zalloc functions

This script finds instances of allocate and memcpy which can be replaced with a direct call to zalloc equivalent of a function. Signed-off-by: Amitoj Kaur Chawla --- scripts/coccinelle/api/zalloc.cocci | 556 1 file changed, 556 insertions(+) create mode

[PATCH] clocksource/drivers/timer-sp804: Use clk_disable_unprepare

Replace clk_disable and clk_unprepare with clk_disable_unprepare. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ - clk_disable(e); - clk_unprepare(e); + clk_disable_unprepare(e); Signed-off-by: Amitoj Kaur Chawla --- drivers/clocksource/timer-sp804.c

[PATCH] drm: Use clk_disable_unprepare

Replace clk_disable and clk_unprepare with clk_disable_unprepare. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ - clk_disable(e); - clk_unprepare(e); + clk_disable_unprepare(e); Signed-off-by: Amitoj Kaur Chawla --- drivers/gpu/drm/fsl-dcu

[PATCH] ARM: sa1111: Use clk_disable_unprepare

Replace clk_disable and clk_unprepare with clk_disable_unprepare. The Coccinelle semantic patch used to make this change is as follows: @@ expression e; @@ - clk_disable(e); - clk_unprepare(e); + clk_disable_unprepare(e); Signed-off-by: Amitoj Kaur Chawla --- arch/arm/common/sa.c | 3

[PATCH v2] 2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare

; @@ - clk_disable(e); - clk_unprepare(e); + clk_disable_unprepare(e); Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Rebased patch drivers/i2c/busses/i2c-mv64xxx.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b

[PATCH] Coccinelle: Script to use roundup and DIV_ROUND_UP

This script replaces manual calculations by using the predefined macros in kernel.h, DIV_ROUND_UP and roundup for readability purposes. Signed-off-by: Amitoj Kaur Chawla --- scripts/coccinelle/api/roundup.cocci | 215 +++ 1 file changed, 215 insertions(+) create

[PATCH v2] sound: oss: Remove useless initialisation

Remove useless initialisation of variable whose value is reinitialised later. The Coccinelle semantic patch used to make this change is as follows: @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Modify

[PATCH] sound: oss: Remove useless initialisation

@@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; Signed-off-by: Amitoj Kaur Chawla --- sound/oss/ad1848.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c index 10c8de1..6368e5c 100644 --- a/sound/oss/ad1848.c

Re: [PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource

On Mon, Jul 4, 2016 at 8:36 PM, Amitoj Kaur Chawla wrote: > On Mon, Jul 4, 2016 at 8:29 PM, Mark Brown wrote: >> On Mon, Jul 04, 2016 at 04:52:43PM +0200, Julia Lawall wrote: >>> On Mon, 4 Jul 2016, Mark Brown wrote: >> >>> > Please use subject lines matchin

Re: [PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource

On Mon, Jul 4, 2016 at 8:29 PM, Mark Brown wrote: > On Mon, Jul 04, 2016 at 04:52:43PM +0200, Julia Lawall wrote: >> On Mon, 4 Jul 2016, Mark Brown wrote: > >> > Please use subject lines matching the style for the subsystem. This >> > makes it easier for people to identify relevant patches. > >>

[PATCH] ASOC: atmel-pdmic: Simplify use of devm_ioremap_resource

= platform_get_resource(pdev, IORESOURCE_MEM, n); ... when != res - if (res == NULL) { ... \(goto l;\|return ret;\) } ... when != res + res = platform_get_resource(pdev, IORESOURCE_MEM, n); e = devm_ioremap_resource(e1, res); // Signed-off-by: Amitoj Kaur Chawla --- sound/soc/atmel/atmel-pdmic.c | 5

[PATCH] ASOC: Atmel: ClassD: Simplify use of devm_ioremap_resource

= platform_get_resource(pdev, IORESOURCE_MEM, n); ... when != res - if (res == NULL) { ... \(goto l;\|return ret;\) } ... when != res + res = platform_get_resource(pdev, IORESOURCE_MEM, n); e = devm_ioremap_resource(e1, res); // Signed-off-by: Amitoj Kaur Chawla --- sound/soc/atmel/atmel-classd.c | 5

[PATCH] crypto: bfin_crc: Simplify use of devm_ioremap_resource

= platform_get_resource(pdev, IORESOURCE_MEM, n); ... when != res - if (res == NULL) { ... \(goto l;\|return ret;\) } ... when != res + res = platform_get_resource(pdev, IORESOURCE_MEM, n); e = devm_ioremap_resource(e1, res); // Signed-off-by: Amitoj Kaur Chawla --- drivers/crypto/bfin_crc.c | 5 - 1

[PATCH] RDMA/cxgb3: Use AF_INET for sin_family field

== - PF_INET + AF_INET | sip.sin_family != - PF_INET + AF_INET | sip.sin_family = - PF_INET + AF_INET ) // Signed-off-by: Amitoj Kaur Chawla --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b

[PATCH] bcache: Use setup_timer and mod_timer

n = f; | -init_timer(&t); +setup_timer(&t,f,d); | -init_timer_on_stack(&t); +setup_timer_on_stack(&t,f,d); ) <... when != S1 t.x1 = e1; ...> Also convert calls to add_timer and intialisation of timer's expire field to a call to mod_timer which is more compact. S

[PATCH] atm: horizon: Use setup_timer

n = f; | -init_timer(&t); +setup_timer(&t,f,d); | -init_timer_on_stack(&t); +setup_timer_on_stack(&t,f,d); ) <... when != S1 t.x1 = e1; ...> Signed-off-by: Amitoj Kaur Chawla --- drivers/atm/horizon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/

Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

On Thu, Jun 30, 2016 at 12:53 AM, Wolfram Sang wrote: > On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote: >> This script detects cases which have incorrect error handling for >> devm_ioremap_resource function, employing a NULL test instead of an >> IS_ERR

[PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

This script detects cases which have incorrect error handling for devm_ioremap_resource function, employing a NULL test instead of an IS_ERR() test. Signed-off-by: Amitoj Kaur Chawla --- .../coccinelle/null/devm_ioremap_resource.cocci| 37 ++ 1 file changed, 37

[PATCH] PCI: xilinx: Modify error handling

R(E) ...+> } Signed-off-by: Amitoj Kaur Chawla --- drivers/pci/host/pcie-xilinx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c index 65f0fe0..d76ea8d 100644 --- a/drivers/pci/host/pcie-xilinx.c +++ b/drivers/pc

[PATCH] x86/xen: Use DIV_ROUND_UP

)) / d + DIV_ROUND_UP(n,d) ) Signed-off-by: Amitoj Kaur Chawla --- arch/x86/xen/enlighten.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 880862c..6847512 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen

[PATCH] ALSA: riptide: Use DIV_ROUND_UP

)) / d + DIV_ROUND_UP(n,d) ) Signed-off-by: Amitoj Kaur Chawla --- sound/pci/riptide/riptide.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c index 94639d6..067a912 100644 --- a/sound/pci/riptide/riptide.c +++ b/sound

[PATCH] i2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare

; @@ - clk_disable(e); - clk_unprepare(e); + clk_disable_unprepare(e); Signed-off-by: Amitoj Kaur Chawla --- drivers/i2c/busses/i2c-mv64xxx.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c index

[PATCH] pinctrl: stm32: Modify error handling for pinctrl_register

) ; } Signed-off-by: Amitoj Kaur Chawla --- drivers/pinctrl/stm32/pinctrl-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 8deb566..857bb3d 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c

[PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent

pci_free_consistent's argument 'struct pci_dev' should be NULL not 0. The Coccinelle semantic patch used to make this change is as follows: @@ @@ pci_free_consistent( - 0 + NULL , ...) Signed-off-by: Amitoj Kaur Chawla --- drivers/net/ethernet/tundra/tsi108_eth.c | 3 ++- 1

[PATCH] pinctrl: Add missing of_node_put

: Amitoj Kaur Chawla --- drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/sirf/pinctrl-atlas7.c b/drivers/pinctrl/sirf/pinctrl-atlas7.c index 3d233fc..7d9c1a3 100644 --- a/drivers/pinctrl/sirf/pinctrl-atlas7.c +++ b/drivers

[PATCH] caif: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla --- net/caif/chnl_net.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH] ASOC: wm8753: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla --- sound/soc/codecs/wm8753.c | 1 - 1 file changed, 1 deletion

[PATCH] w1: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla --- drivers/w1/w1.c | 1 - 1 file changed, 1 deletion(-) diff --git a

[PATCH] memstick: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla --- drivers/memstick/core/mspro_block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c index 922a750..0fb27d3 100644 --- a/drivers

[PATCH] i40e: Remove redundant memset

Remove redundant call to memset before a call to memcpy. The Coccinelle semantic patch used to make this change is as follows: @@ expression e1,e2,e3,e4; @@ - memset(e1,e2,e3); memcpy(e1,e4,e3); Signed-off-by: Amitoj Kaur Chawla --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - 1 file

[PATCH] dlm: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla --- fs/dlm/lowcomms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 1ab012a..963016c 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -1279,10 +1279,9

[PATCH] tipc: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla --- net/tipc/server.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/tipc/server.c b/net/tipc/server.c index 2446bfb..38a6f33 100644 --- a/net/tipc/server.c +++ b/net/tipc/server.c @@ -411,13 +411,12 @@ static

[PATCH] hfs: Change structure initialisation to C99 style

@ identifier i1,fld; type T; field list[n] fs; @@ struct i1 { fs T fld; ...}; @@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- fs/hfs/inode.c | 4 ++-- 1 file changed, 2

[PATCH] ddbridge: Replace vmalloc with vzalloc

: Amitoj Kaur Chawla --- drivers/media/pci/ddbridge/ddbridge-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-core.c b/drivers/media/pci/ddbridge/ddbridge-core.c index 6e995ef..47def73 100644 --- a/drivers/media/pci/ddbridge/ddbridge

[PATCH] ACPICA: Use acpi_os_allocate_zeroed

) S - memset(d, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla --- drivers/acpi/acpica/utcache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/acpica/utcache.c b/drivers/acpi/acpica/utcache.c index f8e9978..862f963 100644 --- a/drivers/acpi/acpica

[PATCH] net: cavium: liquidio: Use vzalloc instead of vmalloc

: Amitoj Kaur Chawla --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index f67641a..2bf90c1 100644 --- a

[PATCH] ACPICA: Use acpi_os_allocate_zeroed

) S - memset(d, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla --- drivers/acpi/acpica/uttrack.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/acpica/uttrack.c b/drivers/acpi/acpica/uttrack.c index 60c406a..5ad2641 100644 --- a/drivers/acpi/acpica

[PATCH] ALSA: ctxfi: Change structure initialisation to C99 style

; ...}; @@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- sound/pci/ctxfi/cthw20k2.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a

[PATCH v2] ALSA: usb-audio: Change structure initialisation to C99 style

,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Modified commit message sound/usb/mixer_maps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound

[PATCH] ALSA: usb-audio: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- sound/usb/mixer_maps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c index 1f8fb0d9..9038b2e 100644 --- a/sound/usb

[PATCH] ALSA: seq_oss: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Also, removed some unnecessary comments. Signed-off-by: Amitoj Kaur Chawla --- sound/core/seq/oss/seq_oss_synth.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/core/seq/oss/seq_oss_synth.c

[PATCH] sound: aedsp16: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- sound/oss/aedsp16.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/oss/aedsp16.c b/sound/oss/aedsp16.c index 35b5912..bb477d5 100644 --- a/sound/oss

[PATCH] [ACPI] Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- arch/ia64/kernel/acpi-ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/kernel/acpi-ext.c b/arch/ia64/kernel/acpi-ext.c index bd09bf7..31e331a 100644 --- a

[PATCH] parisc: Change structure intialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- arch/parisc/lib/iomap.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/arch/parisc/lib/iomap.c b/arch/parisc/lib

[PATCH 1/2] ARM: pxa: ssp: Drop unnecessary freeing functions

= devm_ioremap(...) | x = devm_ioremap_nocache(...) ) @@ expression r.x; @@ ( * kfree(x) | * free_irq(x) | * iounmap(x) ) Signed-off-by: Amitoj Kaur Chawla --- arch/arm/plat-pxa/ssp.c | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index

[PATCH 2/2] ARM: pxa: ssp: Switch to devm_ioremap_resource

rce to take advantage of the null check on res by devm_ioremap_resource. Signed-off-by: Amitoj Kaur Chawla --- arch/arm/plat-pxa/ssp.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index 97bd43c..aecc

[PATCH 0/2] ARM: pxa: ssp: Clean up probe and remove functions

and devm_ioremap with devm_ioremap_resource. Amitoj Kaur Chawla (2): ARM: pxa: ssp: Drop unnecessary freeing functions ARM: pxa: ssp: Switch to devm_ioremap_resource arch/arm/plat-pxa/ssp.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) -- 1.9.1

[PATCH] ARM: zx: Fix devm_ioremap_resource error detection code

: Amitoj Kaur Chawla --- arch/arm/mach-zx/zx296702-pm-domain.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c index e08574d..17f778b 100644 --- a/arch/arm/mach-zx/zx296702-pm-domain.c

[PATCH] pinctrl: xway: Change structure initialisation to c99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- drivers/pinctrl/pinctrl-xway.c | 72 -- 1 file changed, 48 insertions(+), 24 deletions(-) diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl

[PATCH] dmaengine: xilinx_vdma: Use dma_pool_zalloc

, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla --- drivers/dma/xilinx/xilinx_vdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_vdma.c b/drivers/dma/xilinx/xilinx_vdma.c index ef67f27..d35317f 100644 --- a/drivers/dma/xilinx/xilinx_vdma.c

[PATCH] saa7164: Replace if and BUG with BUG_ON

off-by: Amitoj Kaur Chawla --- drivers/media/pci/saa7164/saa7164-encoder.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-encoder.c b/drivers/media/pci/saa7164/saa7164-encoder.c index 1b184c3..32a353d 100644 --- a/drivers/media/pci/s

[PATCH] mtd: Replace if and BUG with BUG_ON

off-by: Amitoj Kaur Chawla --- drivers/mtd/ssfdc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index daf82ba..41b13d1 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -380,8 +380,7 @@ static int ssfdcr_readsect(

[PATCH] um: Eliminate null test after alloc_bootmem

alloc_bootmem function never returns NULL. Thus a NULL test after a call to this function is unnecessary. The Coccinelle semantic patch used to make this change is follows: @@ expression E; statement S; @@ E = alloc_bootmem(...) ... when != E - if (E == NULL) S Signed-off-by: Amitoj Kaur Chawla

[PATCH] drbd: Replace if and BUG with BUG_ON

{ BUG(); } + BUG_ON(E); ) @@ expression E,f; @@ ( if (<+... f(...) ...+>) { BUG(); } | - if (E) { BUG(); } + BUG_ON(E); ) Signed-off-by: Amitoj Kaur Chawla --- drivers/block/drbd/drbd_state.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_state

[PATCH] mailbox: Fix devm_ioremap_resource error detection code

devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. The Coccinelle semantic patch used to make this change is as follows: @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(...); if (!e1) S Signed-off-by: Amitoj Kaur Chawla --- drivers/mailbox/mailbox-sti.c | 4

[PATCH] dm thin: Remove return statement from void function

Return statement at the end of a void function is useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- drivers/md/dm-thin.c | 2 +- 1 file chan

[PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue

alloc_ordered_workqueue. WQ_MEM_RECLAIM flag has been set since ethernet devices seem to sit in memory reclaim path, so to guarantee forward progress regardless of memory pressure. Signed-off-by: Amitoj Kaur Chawla Acked-by: Tejun Heo --- Not sure if the assumption of requiring ordering of work items

[PATCH] can: mcp251x: Replace create_freezable_workqueue with alloc_workqueue

is required. WQ_MEM_RECLAIM flag has been set here to ensure forward progress regardless of memory pressure. The order of execution is not important so set @max_active as 0. Signed-off-by: Amitoj Kaur Chawla Acked-by: Tejun Heo --- drivers/net/can/spi/mcp251x.c | 3 ++- 1 file changed

[PATCH v2] misc: mic: Remove return statements from void functions

Return statements at the end of void functions are useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Resend to add

[PATCH] iio: light: tsl2563: Remove flush_scheduled_work

of flush_scheduled_work(). Acked-by: Tejun Heo Signed-off-by: Amitoj Kaur Chawla --- drivers/iio/light/tsl2563.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c index 12731d6..57b108c 100644 --- a/drivers/iio/light/tsl256

[PATCH] misc: mic: Remove return statements from void functions

Return statements at the end of void functions are useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- drivers/misc/mic/host/mic_boot.c | 6 +++

[PATCH] crypto: n2 - Remove return statement from void function

Return statement at the end of a void function is useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- drivers/crypto/n2_core.c | 2 +- 1 file c

Re: [PATCH 1/2] Staging: atm: fix 'endianess' spelling to 'endianness' in fore200e.c This is a patch to the fore200e that fixes the spelling of 'endianess' to the correct one, that is, 'endianness' fo

On Thu, Mar 10, 2016 at 11:00 AM, rneha725 wrote: > Signed-off-by: Neha Rani > --- Hi Neha, You should ideally submit patches for drivers/staging/ as a newbie and not other drivers. Other than that, Your subject is too long and you haven't written a commit message, A better way to write the su

[PATCH v2 2/6] leds: lp8788: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Remove unnecessary

[PATCH v2 3/6] leds: wm831x-status: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Remove unnecessary

[PATCH v2 5/6] leds: da903x: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Remove unnecessary

  1   2   >