Re: [PATCH 1/3 RESEND] sched: Remove __rcu annotation from cred pointer

2020-05-25 Thread Amol Grover
On Mon, May 25, 2020 at 09:17:41AM -0400, Richard Guy Briggs wrote: > On 2020-05-24 13:41, Amol Grover wrote: > > On Thu, Apr 02, 2020 at 11:26:38AM +0530, Amol Grover wrote: > > > task_struct::cred (subjective credentials) is *always* used > > > task-synchronously,

Re: [PATCH 1/3 RESEND] sched: Remove __rcu annotation from cred pointer

2020-05-24 Thread Amol Grover
On Thu, Apr 02, 2020 at 11:26:38AM +0530, Amol Grover wrote: > task_struct::cred (subjective credentials) is *always* used > task-synchronously, hence, does not require RCU semantics. > > task_struct::real_cred (objective credentials) can be used in > RCU context and its _

Re: f410328e93 ("Default enable RCU list lockdep debugging with .."): WARNING: suspicious RCU usage

2020-05-23 Thread Amol Grover
ault. > > > >However, there are still chances of enountering > >false-positive lockdep splats because not everything is converted, > >in case RCU list primitives are used in non-RCU read-side critical > >section but under the protection of a l

Re: WARNING: suspicious RCU usage with PROVE_RCU_LIST=y

2020-05-14 Thread Amol Grover
On Mon, Apr 06, 2020 at 05:11:34PM +0530, Amol Grover wrote: > Hello, > > With respect to the patch https://lore.kernel.org/patchwork/patch/1202512/ > I boot tested with CONFIG_PROVE_RCU_LIST=y and encountered a susppicious RCU > usage warning in "security/apparmor/inclu

Re: linux-next boot error: WARNING: suspicious RCU usage in bpq_device_event

2020-05-14 Thread Amol Grover
On Thu, May 14, 2020 at 08:24:54AM -0400, Qian Cai wrote: > > > > On May 14, 2020, at 7:37 AM, syzbot > > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:c9529331 Add linux-next specific files for 20200514 > > git tree: linux-next > > console

[PATCH net v2 1/2] ipmr: Fix RCU list debugging warning

2020-05-14 Thread Amol Grover
ables") Signed-off-by: Amol Grover --- v2: - Add appropriate Fixes tag net/ipv4/ipmr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 9cf83cc85e4a..4897f7420c8f 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -110,7 +110,8 @@ s

[PATCH net v2 2/2] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-14 Thread Amol Grover
i Signed-off-by: Amol Grover --- v2: - Change the lockdep expression to check for list emptiness at init - Add Fixes tag - Add Reported-by tag for syzbot report net/ipv4/ipmr.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index

Re: [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-12 Thread Amol Grover
On Tue, May 12, 2020 at 10:47:05AM +0530, Madhuparna Bhowmik wrote: > On Sat, May 09, 2020 at 02:19:38PM -0700, Jakub Kicinski wrote: > > On Sat, 9 May 2020 12:52:44 +0530 Amol Grover wrote: > > > ipmr_for_each_table() uses list_for_each_entry_rcu() for > > > traver

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-09 Thread Amol Grover
On Tue, Apr 28, 2020 at 10:28:41AM -0400, Qian Cai wrote: > > > > On Apr 28, 2020, at 10:11 AM, Madhuparna Bhowmik > > wrote: > > > > On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote: > >> > >> > >>> On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > net/ipv4/ipmr.c:136

[PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-09 Thread Amol Grover
] = [0.645294] WARNING: suspicious RCU usage [0.645296] 5.5.4-stable #17 Not tainted [0.645297] - [0.645299] net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!! Signed-off-by: Amol Grover --- net/ipv4/ipmr.c | 7 --- 1 file changed

[PATCH net 1/2 RESEND] ipmr: Fix RCU list debugging warning

2020-05-09 Thread Amol Grover
] = [4.319349] WARNING: suspicious RCU usage [4.319351] 5.5.4-stable #17 Tainted: GE [4.319352] - [4.319354] net/ipv4/ipmr.c:1757 RCU-list traversed in non-reader section!! Signed-off-by: Amol Grover --- net/ipv4/ipmr.c | 3 ++- 1

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-09 Thread Amol Grover
On Thu, May 07, 2020 at 06:26:01AM +1000, Stephen Rothwell wrote: > Hi all, > > On Thu, 7 May 2020 06:16:35 +1000 Stephen Rothwell > wrote: > > > > Hi Qian, > > > > On Tue, 28 Apr 2020 09:56:59 -0400 Qian Cai wrote: > > > > > > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > > > >

Re: linux-next boot error: WARNING: suspicious RCU usage in ipmr_get_table

2020-05-06 Thread Amol Grover
On Tue, Apr 28, 2020 at 09:56:59AM -0400, Qian Cai wrote: > > > > On Apr 28, 2020, at 4:57 AM, Dmitry Vyukov wrote: > >> net/ipv4/ipmr.c:136 RCU-list traversed in non-reader section!! > > https://lore.kernel.org/netdev/20200222063835.14328-2-frextr...@gmail.com/ > > Never been picked up for a

[PATCH] staging: media: Fix alignment to match open parenthesis

2019-09-11 Thread Amol Grover
CHECK: Alignment should match open parenthesis Signed-off-by: Amol Grover --- drivers/staging/media/imx/imx-media-csi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index