RE: [PATCH 1/3] aio: fix oops because of extra IO control block freeing.

2007-03-08 Thread Ananiev, Leonid I
ZB>If we really decide to remove EIOCBRETRY support we'd get rid of all ZB>the retry infrastructure and remove the EIOCBRETRY errno so their ZB>builds failed. Originally EIOCBRETRY was used in fs/read_write.c for vector IO. And EIOCBRETRY was deleted from it after. Now EIOCBRETRY is used in driver

RE: [PATCH 2/3] aio: fix oops because of extra IO control block freeing.

2007-03-05 Thread Ananiev, Leonid I
] >Sent: Monday, March 05, 2007 10:36 PM >To: Ananiev, Leonid I >Cc: Kernel development list >Subject: Re: [PATCH 2/3] aio: fix oops because of extra IO control block freeing. > >On Mon, 5 Mar 2007, Leonid Ananiev wrote: > >> From Leonid Ananiev >> >> This patc

Cfq first request patch changes IO performance

2007-02-26 Thread Ananiev, Leonid I
The patch "cfq-iosched: defer slice activation to first request being active" http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=c ommitdiff;h=44f7c16065c83060cbb9dd9b367141682a6e2b8e;hp=99f9628aba4d8fb3 b8d955c9efded0d0a1995fad Sysbench fileio (random read/write mix) -15% Tiob

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Ananiev, Leonid I
EIO (remember 47% EIO in aio-stress runs after patching) will buy new disk... This patch is harmful. Leonid >-Original Message- >From: Zach Brown [mailto:[EMAIL PROTECTED] >Sent: Wednesday, February 21, 2007 9:25 PM >To: Ken Chen >Cc: Ananiev, Leonid I; Chris Mason; linux

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Ananiev, Leonid I
_busy(bh)returns 1; it returns 0 because of buffer_head count is 1 (bh->b_count==1) as additional printk reports. Leonid -Original Message- From: Ken Chen [mailto:[EMAIL PROTECTED] Sent: Wednesday, February 21, 2007 11:36 AM To: Ananiev, Leonid I Cc: Chris Mason; Zach Brown; [EMAI

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
-o 2 -i 1 -r 16k 5) if i++<50 goto 2). Leonid -Original Message- From: Chris Mason [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 20, 2007 8:55 PM To: Ananiev, Leonid I Cc: Zach Brown; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; Benjamin LaHaise; Suparna bhattacharya; Andrew Morto

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
[EMAIL PROTECTED]; linux-kernel@vger.kernel.org Cc: Benjamin LaHaise; Suparna bhattacharya; Andrew Morton; Ananiev, Leonid I Subject: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event aio: propogate post-EIOCBQUEUED errors to completion event This addresses an oops reported by

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
, 2007 8:04 PM To: Ananiev, Leonid I Cc: Zach Brown; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; Benjamin LaHaise; Suparna bhattacharya; Andrew Morton Subject: Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event On Tue, Feb 20, 2007 at 07:57:49PM +0300, Ananiev, Leonid I

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
enjamin LaHaise; Suparna bhattacharya; Andrew Morton; Ananiev, Leonid I Subject: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event aio: propogate post-EIOCBQUEUED errors to completion event This addresses an oops reported by Leonid Ananiev <[EMAIL PROTECTED]> as archived at

RE: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-20 Thread Ananiev, Leonid I
n [mailto:[EMAIL PROTECTED] Sent: Monday, February 19, 2007 11:35 PM To: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org Cc: Benjamin LaHaise; Suparna bhattacharya; Andrew Morton; Ananiev, Leonid I Subject: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event aio: propogate post-EIO

RE: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-19 Thread Ananiev, Leonid I
ion in synchronization process could be performed instead. Leonid -Original Message- From: Zach Brown [mailto:[EMAIL PROTECTED] Sent: Monday, February 19, 2007 11:35 PM To: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org Cc: Benjamin LaHaise; Suparna bhattacharya; Andrew Morton; Ananiev, Leonid I S

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-16 Thread Ananiev, Leonid I
ely into sources we can see that EIOCBQUEUED never may be returned to aio_run_iocb(). include/linux/aio.h says * If ki_retry returns -EIOCBRETRY ... Could you point source line which "returns -EIOCBRETRY"? Leonid -Original Message- From: Zach Brown [mailto:[EMAIL PROTECTED]

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-15 Thread Ananiev, Leonid I
o_run_iocb() during 5 hours aiostress running. Does it mean that EIOCBQUEUED is always reset and never returned? Leonid -Original Message----- From: Zach Brown [mailto:[EMAIL PROTECTED] Sent: Thursday, February 15, 2007 10:23 PM To: Ananiev, Leonid I Cc: Ken Chen; [EMAIL PROTECTED]; Andrew

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-15 Thread Ananiev, Leonid I
-Original Message- From: Zach Brown [mailto:[EMAIL PROTECTED] Sent: Thursday, February 15, 2007 10:23 PM To: Ananiev, Leonid I Cc: Ken Chen; [EMAIL PROTECTED]; Andrew Morton; linux-kernel@vger.kernel.org; linux-aio; Chris Mason Subject: Re: [PATCH] aio: fix kernel bug when page is

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-15 Thread Ananiev, Leonid I
t it? Leonid -Original Message- From: Zach Brown [mailto:[EMAIL PROTECTED] Sent: Thursday, February 15, 2007 9:25 PM To: Ananiev, Leonid I Cc: Ken Chen; [EMAIL PROTECTED]; Andrew Morton; linux-kernel@vger.kernel.org; linux-aio; Chris Mason Subject: Re: [PATCH] aio: fix kernel bug when p

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-15 Thread Ananiev, Leonid I
Ken Chen wrote > It might shut up kernel > panic by eliminate double calls to aio_complete(), but it will > silently introduce data corruption. I had got kernel panic after an hour of aiostress running. After patching I have not got aiostress massage "verify error, file %s offset %Lu contents (of

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-14 Thread Ananiev, Leonid I
ait_idle+0x0/0x20 [] ret_from_intr+0x0/0xa [] mwait_idle_with_hints+0x44/0x45 [] mwait_idle+0xc/0x20 [] cpu_idle+0x8b/0xb0 [] start_secondary+0x462/0x471 -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Thursday, February 15, 2007 6:31 AM To: Ananiev, Leonid I Cc: linux-kernel@vger.kerne

[PATCH] aio: fix kernel bug when page is temporally busy

2007-02-14 Thread Ananiev, Leonid I
-wrap lines are fixed. Sorry. >From Leonid Ananiev Fix kernel bug if IO page is temporally busy: invalidate_inode_pages2_range() returns EIOCBRETRY but not EIO. invalidate_inode_pages2() returns EIO as earlier. Signed-off-by: Leonid Ananiev <[EMAIL PROTECTED]> --- --- linux-2.6.20/mm/truncate.c

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-12 Thread Ananiev, Leonid I
Andrew, You wrote on Friday, February 09, 2007 8:53 AM > invalidate_inode_pages2() has other callers. I suspect with this change > we'll end up leaking EIOCBRETRY back to userspace. The path is modified so that invalidate_inode_pages2() returns EIO as earlier. could you consider modified patch Th

Recall: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-12 Thread Ananiev, Leonid I
Ananiev, Leonid I would like to recall the message, "[PATCH] aio: fix kernel bug when page is temporally busy". - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Recall: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-12 Thread Ananiev, Leonid I
Ananiev, Leonid I would like to recall the message, "[PATCH] aio: fix kernel bug when page is temporally busy". - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-12 Thread Ananiev, Leonid I
Andrew, You wrote on Friday, February 09, 2007 8:53 AM > invalidate_inode_pages2() has other callers. I suspect with this change > we'll end up leaking EIOCBRETRY back to userspace. The path is modified so that invalidate_inode_pages2() returns EIO as earlier. could you consider modified patch Th

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-10 Thread Ananiev, Leonid I
Ken Chen writes: > So any error value returned from invalidate_inode_pages2_range() has > to be taken seriously in the direct IO submit path instead of dropping > it to the floor. If invalidate_inode_pages2_range() will return EIOCBRETRY as the patch "aio: fix kernel bug when page is temporally b

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-10 Thread Ananiev, Leonid I
> If invalidate_inode_pages2_range() says it can not invalidate pages, > while dio to the same file offset range is in flight, something is > really wrong there. If invalidate_inode_pages2_range() says it can not invalidate pages It means that soft_irq does completing IO now on other cpu. Next ret

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-10 Thread Ananiev, Leonid I
ext retry() will see a IO well completed. Leonid -Original Message- From: Ken Chen [mailto:[EMAIL PROTECTED] Sent: Saturday, February 10, 2007 9:05 PM To: Ananiev, Leonid I Cc: [EMAIL PROTECTED]; Andrew Morton; linux-kernel@vger.kernel.org; linux-aio; Zach Brown; Chris Mason; Badari

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-10 Thread Ananiev, Leonid I
PM To: Ananiev, Leonid I Cc: [EMAIL PROTECTED]; Andrew Morton; linux-kernel@vger.kernel.org; linux-aio; Zach Brown; Chris Mason; Badari Pulavarty Subject: Re: [PATCH] aio: fix kernel bug when page is temporally busy On 2/9/07, Ananiev, Leonid I <[EMAIL PROTECTED]> wrote: > I have used E

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-09 Thread Ananiev, Leonid I
Leonid -Original Message- From: Suparna Bhattacharya [mailto:[EMAIL PROTECTED] Sent: Friday, February 09, 2007 2:06 PM To: Jiri Kosina Cc: Andrew Morton; Ananiev, Leonid I; linux-kernel@vger.kernel.org; linux-aio; Zach Brown; Chris Mason; Badari Pulavarty; Jan Kara Subject: Re: [PATCH] ai

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-09 Thread Ananiev, Leonid I
Y for irredundant set. Leonid -Original Message- From: Suparna Bhattacharya [mailto:[EMAIL PROTECTED] Sent: Friday, February 09, 2007 10:16 AM To: Ananiev, Leonid I Cc: Andrew Morton; linux-kernel@vger.kernel.org; linux-aio; Zach Brown; Chris Mason; Badari Pulavarty Subject: Re: [PATCH] aio

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-08 Thread Ananiev, Leonid I
> invalidate_inode_pages2() has other callers. I suspect with this change > we'll end up leaking EIOCBRETRY back to userspace. EIOCBRETRY is used and caught already in do_sync_read() and do_sync_readv_writev(). Below fixed patch against kernel 2.6.20. >From Leonid Ananiev Fix kernel bug when

[PATCH] aio: fix kernel bug when page is temporally busy

2007-02-08 Thread Ananiev, Leonid I
>From Leonid Ananiev Fix "Kernel BUG at fs/aio.c:509". Return EIOCBRETRY but not EIO if page is busy. Signed-off-by: Leonid Ananiev <[EMAIL PROTECTED]> "Kernel BUG at fs/aio.c:509" http://marc.theaimsgroup.com/?l=linux-kernel&m=117031052517746&w=2 is present in 2.6.20 as well as 2.6.19. The in

RE: Kernel BUG at fs/aio.c:509

2007-02-01 Thread Ananiev, Leonid I
w Morton [mailto:[EMAIL PROTECTED] Sent: Thursday, February 01, 2007 10:16 AM To: Ananiev, Leonid I Cc: linux-kernel@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: Kernel BUG at fs/aio.c:509 On Thu, 1 Feb 2007 09:13:51 +0300 "Ananiev, Leonid I" <[EMAIL PROTECTED]> wrote: > While r

Kernel BUG at fs/aio.c:509

2007-01-31 Thread Ananiev, Leonid I
While repeatedly running 'aiostress -O -o 2' test I've got in /var/log/messages: BUG: warning at mm/truncate.c:398/invalidate_inode_pages2_range() Call Trace: [] invalidate_inode_pages2_range+0x236/0x26b [] ext3_direct_IO+0x16c/0x19e [] ext3_get_block+0x0/0xe2 [] generic_file_direct_IO+0xb9/0x

RE: [patch 1/] timers: tsc using for cpu scheduling

2005-07-23 Thread Ananiev, Leonid I
= 1; /* * We could be more selective here I suspect * and just enable this for the next intel chips ? -Original Message- From: john stultz [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 06, 2005 5:43 AM T

RE: [patch 1/] timers: tsc using for cpu scheduling

2005-07-05 Thread Ananiev, Leonid I
tultz [mailto:[EMAIL PROTECTED] Sent: Thursday, June 30, 2005 11:08 PM To: Ananiev, Leonid I Cc: lkml; Dominik Brodowski Subject: Re: [patch 1/] timers: tsc using for cpu scheduling On Thu, 2005-06-30 at 15:43 +0400, Ananiev, Leonid I wrote: > Patch for using TSC but not PMT in cpu