Re: [PATCH] scsi: qla2xxx: deadlock by configfs_depend_item

2018-12-13 Thread Anatoliy Glagolev
Any thoughts on this change? Thanks.

[PATCH v2] scsi: qla2xxx: pci error handler sync

2018-12-13 Thread Anatoliy Glagolev
and pci_unregister_driver. Then we have to maintain per-pci_dev context with the state of in-flight handlers and the driver structures associated with pci_dev. The contet outlives both the structs and the pci_dev. Signed-off-by: Anatoliy Glagolev --- drivers/scsi/qla2xxx/Makefile| 3

Re: [PATCH] scsi: qla2xxx: disabling pci error handler early

2018-12-10 Thread Anatoliy Glagolev
will send a new patch. On Fri, Dec 07, 2018 at 04:00:27PM -0600, Brian King wrote: > On 12/07/2018 01:56 PM, Anatoliy Glagolev wrote: > > qla2x00_disable_board_on_pci_error and pcie error handlers may run > > in parallel. Specifically, I observed qla2xxx_pci_slot_reset runnin

[PATCH] scsi: qla2xxx: disabling pci error handler early

2018-12-07 Thread Anatoliy Glagolev
, the handler crashes. This patch disables pcie error handling early in qla2x00_disable_board_on_pci_error and in other paths that remove those structs. Signed-off-by: Anatoliy Glagolev --- drivers/scsi/qla2xxx/qla_os.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH] scsi: qla2xxx: deadlock by configfs_depend_item

2018-12-06 Thread Anatoliy Glagolev
epend_item from a configfs callback: the call occasionally deadlocks. Thus, removing configfs_depend_item calls does not break anything and fixes the deadlock problem. Signed-off-by: Anatoliy Glagolev --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 48 +++--- drivers/sc

[PATCH] scsi: qla2xxx: deadlock by configfs_depend_item

2018-12-06 Thread Anatoliy Glagolev
epend_item from a configfs callback: the call occasionally deadlocks. Thus, removing configfs_depend_item calls does not break anything and fixes the deadlock problem. Signed-off-by: Anatoliy Glagolev --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 48 +++--- drivers/sc

[PATCH] Bsg referencing parent device

2018-05-16 Thread Anatoliy Glagolev
00:00:00 2001 From: Anatoliy Glagolev <glago...@gmail.com> Date: Wed, 16 May 2018 17:03:09 -0600 Subject: [PATCH] Bsg referencing parent device Signed-off-by: Anatoliy Glagolev <glago...@gmail.com> Bsg holding reference to a parent device may result in a crash if user closes a bsg fil

[PATCH] Bsg referencing parent device

2018-05-16 Thread Anatoliy Glagolev
00:00:00 2001 From: Anatoliy Glagolev Date: Wed, 16 May 2018 17:03:09 -0600 Subject: [PATCH] Bsg referencing parent device Signed-off-by: Anatoliy Glagolev Bsg holding reference to a parent device may result in a crash if user closes a bsg file handle after the parent device driver has unlo

Re: [PATCH] bsg referencing bus driver module

2018-05-01 Thread Anatoliy Glagolev
idea of cutting of the bsg layer at fc_bsg_remove time? Thanks. On Thu, Apr 26, 2018 at 06:01:00PM -0600, Anatoliy Glagolev wrote: > Any thoughts on this? Can we really drop a reference from a child device > (bsg_class_device) to a parent device (Scsi_Host) while the child device >

Re: [PATCH] bsg referencing bus driver module

2018-05-01 Thread Anatoliy Glagolev
idea of cutting of the bsg layer at fc_bsg_remove time? Thanks. On Thu, Apr 26, 2018 at 06:01:00PM -0600, Anatoliy Glagolev wrote: > Any thoughts on this? Can we really drop a reference from a child device > (bsg_class_device) to a parent device (Scsi_Host) while the child device >

Re: [PATCH] bsg referencing bus driver module

2018-04-26 Thread Anatoliy Glagolev
a SCSI bus driver (like qla2xxx) itself; it is safe to drop the module reference at that time. >From c744d4fd93578545ad12faa35a3354364793b124 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev <glago...@gmail.com> Date: Wed, 25 Apr 2018 19:16:10 -0600 Subject: [PATCH] bsg referencing pare

Re: [PATCH] bsg referencing bus driver module

2018-04-26 Thread Anatoliy Glagolev
a SCSI bus driver (like qla2xxx) itself; it is safe to drop the module reference at that time. >From c744d4fd93578545ad12faa35a3354364793b124 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev Date: Wed, 25 Apr 2018 19:16:10 -0600 Subject: [PATCH] bsg referencing parent module Signed-

Re: [PATCH] bsg referencing bus driver module

2018-04-23 Thread Anatoliy Glagolev
Thanks, James. The idea of cutting communications with Scsi_Host at bsg_unregister_queue(..) time and leaving bsg_class_device to its own fate makes a lot of sense, conceptually. But there are implementation issues that are difficult to work around. bsg.c creates bsg_class_device and takes a

Re: [PATCH] bsg referencing bus driver module

2018-04-23 Thread Anatoliy Glagolev
Thanks, James. The idea of cutting communications with Scsi_Host at bsg_unregister_queue(..) time and leaving bsg_class_device to its own fate makes a lot of sense, conceptually. But there are implementation issues that are difficult to work around. bsg.c creates bsg_class_device and takes a

Re: [PATCH] bsg referencing bus driver module

2018-04-20 Thread Anatoliy Glagolev
ot;Waiting for scsi_host_template release" discussion. >From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev <glago...@gmail.com> Date: Thu, 19 Apr 2018 15:06:06 -0600 Subject: [PATCH] bsg referencing parent module Fixing a bug when bsg lay

Re: [PATCH] bsg referencing bus driver module

2018-04-20 Thread Anatoliy Glagolev
ot;Waiting for scsi_host_template release" discussion. >From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev Date: Thu, 19 Apr 2018 15:06:06 -0600 Subject: [PATCH] bsg referencing parent module Fixing a bug when bsg layer holds the last reference to

Re: [PATCH] bsg referencing bus driver module

2018-04-19 Thread Anatoliy Glagolev
Updated: rebased on recent Linux, cc-ed maintainers per instructions in MAINTAINERS file >From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev <aglago...@purestorage.com> Date: Thu, 19 Apr 2018 15:06:06 -0600 Subject: [PATCH] bsg referencing pare

Re: [PATCH] bsg referencing bus driver module

2018-04-19 Thread Anatoliy Glagolev
Updated: rebased on recent Linux, cc-ed maintainers per instructions in MAINTAINERS file >From df939b80d02bf37b21efaaef8ede86cfd39b0cb8 Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev Date: Thu, 19 Apr 2018 15:06:06 -0600 Subject: [PATCH] bsg referencing parent module Fixing a bug when