Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-12-01 Thread Anders Kaseorg
On Sat, 1 Dec 2012, Tejun Heo wrote: > Can you please test this one too? Thanks! > > […] > + if (!delay) { > + __queue_work(cpu, wq, >work); > + return; > + } > + > […] > - if (!delay) > - return queue_work_on(cpu, wq, >work); > - Yes, this one

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-12-01 Thread Anders Kaseorg
On Sat, 1 Dec 2012, Tejun Heo wrote: Can you please test this one too? Thanks! […] + if (!delay) { + __queue_work(cpu, wq, dwork-work); + return; + } + […] - if (!delay) - return queue_work_on(cpu, wq, dwork-work); - Yes, this one

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-11-30 Thread Anders Kaseorg
On Fri, 30 Nov 2012, Tejun Heo wrote: > Hey, again. > > Can you please test whether the following patch makes any difference? > > Thanks! > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 042d221..26368ef 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -1477,7

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-11-30 Thread Anders Kaseorg
On Fri, 30 Nov 2012, Tejun Heo wrote: Hey, again. Can you please test whether the following patch makes any difference? Thanks! diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 042d221..26368ef 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1477,7 +1477,10 @@

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-11-28 Thread Anders Kaseorg
On Wed, 28 Nov 2012, Anders Kaseorg wrote: > My Intel 6250 wireless card (iwldvm) can no longer associate with a > WPA-Enterprise network (PEAP-MSCHAPv2). To my surprise, I bisected this > regression to commit e7c2f967445dd2041f0f8e3179cca22bb8bb7f79, > workqueue: use mod_

Re: Wireless regression in workqueue: use mod_delayed_work() instead of __cancel + queue

2012-11-28 Thread Anders Kaseorg
On Wed, 28 Nov 2012, Anders Kaseorg wrote: My Intel 6250 wireless card (iwldvm) can no longer associate with a WPA-Enterprise network (PEAP-MSCHAPv2). To my surprise, I bisected this regression to commit e7c2f967445dd2041f0f8e3179cca22bb8bb7f79, workqueue: use mod_delayed_work() instead

[PATCH v2] fifo: Do not restart open() if it already found a partner

2012-07-15 Thread Anders Kaseorg
); CHECK(waitpid(pid, NULL, 0)); } } This is what I suspect was causing the Git test suite to fail in t9010-svn-fe.sh: http://bugs.debian.org/678852 Signed-off-by: Anders Kaseorg Reviewed-by: Jonathan Nieder --- (Re-sending v2 to Linus with no changes.) fs/fifo.c |

[PATCH v2] fifo: Do not restart open() if it already found a partner

2012-07-15 Thread Anders Kaseorg
, O_WRONLY)); CHECK(close(fd)); CHECK(waitpid(pid, NULL, 0)); } } This is what I suspect was causing the Git test suite to fail in t9010-svn-fe.sh: http://bugs.debian.org/678852 Signed-off-by: Anders Kaseorg ande...@mit.edu Reviewed-by: Jonathan Nieder jrnie...@gmail.com