[PATCH v3 1/6] gnss: sirf: write data to gnss only when the gnss device is open

2019-01-16 Thread Andreas Kemnade
The api forbids writing data there otherwise. Prepare for the serdev_open()/close() being a part of sirf_set_active. Signed-off-by: Andreas Kemnade --- Changes in v3: - add more locking - style cleanup - mutex *not* renamed since we need a second one Changes in v2: - add locking drivers

[PATCH v3 0/6] gnss: sirf: add support for w2sg0004 + lna

2019-01-16 Thread Andreas Kemnade
- better regulator error handling - timeout logic cleaned up and problems documented - initial power off sorted out as a separate patch - renamed patch gnss: sirf: power on logic for devices without wakeup signal Andreas Kemnade (6): gnss: sirf: write data to gnss only when the gnss

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-15 Thread Andreas Kemnade
On Mon, 14 Jan 2019 11:51:29 +0100 Johan Hovold wrote: > On Thu, Jan 10, 2019 at 11:02:23PM +0100, Andreas Kemnade wrote: > > Hi Johan, > > > > On Thu, 10 Jan 2019 13:10:38 +0100 > > Johan Hovold wrote: > > > > On Sun, Dec 09, 2018 at

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-14 Thread Andreas Kemnade
On Mon, 14 Jan 2019 11:51:29 +0100 Johan Hovold wrote: here is a second part of a reply. [...] > > > In pseudo code we have: > > > > > > activate: > > >- toggle on-off > > >- wait(data-received, ACTIVATE_TIMEOUT + REPORT_CYCLE) > > > - reception: success > > > > Note: we can

Re: [PATCH v2 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2019-01-13 Thread Andreas Kemnade
On Thu, 10 Jan 2019 13:02:28 +0100 Johan Hovold wrote: > On Sun, Dec 09, 2018 at 08:51:46PM +0100, Andreas Kemnade wrote: > > The api forbids writing data there otherwise. Prepare for the > > serdev_open()/close() being a part of runtime pm. > > > > Sig

Re: [PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2019-01-10 Thread Andreas Kemnade
Hi Johan, On Thu, 10 Jan 2019 13:10:38 +0100 Johan Hovold wrote: > Please change the commit summary to something more descriptive like > > gnss: sirf: add support for configurations without wakeup signal > > On Sun, Dec 09, 2018 at 08:51:47PM +0100, Andreas Kemnade wrote:

Re: [PATCH v2 5/5] dt-bindings: gnss: add lna-supply property

2019-01-10 Thread Andreas Kemnade
On Thu, 10 Jan 2019 13:27:57 +0100 Johan Hovold wrote: > On Sun, Dec 09, 2018 at 08:51:50PM +0100, Andreas Kemnade wrote: > > Add lna-supply property. > > > > Signed-off-by: Andreas Kemnade > > --- > > Changes in v2: > > - reordering > > Orig

[PATCH RFC] media: omap3isp: Fix high idle current

2019-01-09 Thread Andreas Kemnade
right or not. Signed-off-by: Andreas Kemnade --- drivers/media/platform/omap3isp/isp.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 13f2828d880d..b837ca5604ad

Re: [PATCH v2] arm: dts: gta04: add bluetooth serdev driver flags

2019-01-09 Thread Andreas Kemnade
Hi, On Wed, 9 Jan 2019 18:47:52 +0100 "H. Nikolaus Schaller" wrote: > From: Andreas Kemnade > > gta04a[34] have bluetooth chips which simply understand > h4 protocol. > > Signed-off-by: Andreas Kemnade what about upstreaming the full patch based on mainline

Re: [Letux-kernel] [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2019-01-04 Thread Andreas Kemnade
Hi Marcel, On Fri, 4 Jan 2019 10:07:34 +0100 Marcel Holtmann wrote: > Hi Andreas, > > Btw. I see nothing standing in the way of merging btuart.c driver and > then go from there. Either I dig this out and submit or someone else > does. > > >>> Do you mean this? > >>> htt

Re: [Letux-kernel] [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2019-01-03 Thread Andreas Kemnade
Hi Marcel, On Fri, 16 Nov 2018 20:58:24 +0100 Marcel Holtmann wrote: > Hi Andreas, > > >> Btw. I see nothing standing in the way of merging btuart.c driver and then > >> go from there. Either I dig this out and submit or someone else does. > >> > > Do you mean this? > > https://patchwork.ke

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-12-31 Thread Andreas Kemnade
On Mon, 31 Dec 2018 09:23:01 +0200 Tero Kristo wrote: > On 28/12/2018 22:02, Tony Lindgren wrote: > > * Andreas Kemnade [181227 20:13]: > >> Hi, > >> > >> On Tue, 4 Dec 2018 08:45:57 -0800 > >> Tony Lindgren wrote: > >> > >>&

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-12-27 Thread Andreas Kemnade
Hi, On Tue, 4 Dec 2018 08:45:57 -0800 Tony Lindgren wrote: > * Andreas Kemnade [181204 06:17]: > > On Mon, 3 Dec 2018 07:39:10 -0800 > > Tony Lindgren wrote: > > > The consumer device stays active just fine with PM runtime > > > calls. So yes, the prob

[PATCH 0/2] hwmon: devicetree support for hih6130

2018-12-27 Thread Andreas Kemnade
This patch set adds devicetree support for hih6130, so it can be properly auto-probed using devicetree files Andreas Kemnade (2): hwmon: (hih6130) add dtb compatibility tables devicetree: hwmon: Add bindings documentation for HIH6130 Documentation/devicetree/bindings/hwmon/hih6130.txt | 12

[PATCH 2/2] devicetree: hwmon: Add bindings documentation for HIH6130

2018-12-27 Thread Andreas Kemnade
Add bindings documentation for HIH6130 driver. Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/hwmon/hih6130.txt | 12 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/hih6130.txt diff --git a/Documentation

[PATCH 1/2] hwmon: (hih6130) add dtb compatibility tables

2018-12-27 Thread Andreas Kemnade
This allows the hih6130 to be used in devicetree files and auto-probed that way. Signed-off-by: Andreas Kemnade --- drivers/hwmon/hih6130.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/hih6130.c b/drivers/hwmon/hih6130.c index 0ae1ee1dbf76

Re: [PATCH] gnss: sirf: fix activation retry handling

2018-12-09 Thread Andreas Kemnade
Hi, On Wed, 5 Dec 2018 11:21:49 +0100 Johan Hovold wrote: > Fix activation helper which would return -ETIMEDOUT even if the last > retry attempt was successful. > > Also change the semantics of the retries variable so that it actually > holds the number of retries (rather than tries). > Sound

[PATCH v2 3/5] dt-bindings: gnss: add w2sg0004 compatible string

2018-12-09 Thread Andreas Kemnade
Add w2sg0004 compatible string since devices without wakeup pins are now supported. Signed-off-by: Andreas Kemnade --- Changes in v2: - reordering of entries With the original order there was a Reviewed-by: Rob Herring Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 + 1 file changed

[PATCH v2 4/5] gnss: sirf: add a separate supply for a lna

2018-12-09 Thread Andreas Kemnade
Devices might have a separate lna between antenna output of the gps chip and the antenna which might have a separate supply. Signed-off-by: Andreas Kemnade --- Changes in v2: - handle lna also if there is no on-off gpio - rebase on changed 2/5 drivers/gnss/sirf.c | 26

[PATCH v2 5/5] dt-bindings: gnss: add lna-supply property

2018-12-09 Thread Andreas Kemnade
Add lna-supply property. Signed-off-by: Andreas Kemnade --- Changes in v2: - reordering Original order had a Reviewed-by: Rob Herring Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gnss/sirfstar.txt b

[PATCH v2 2/5] gnss: sirf: power on logic for devices without wakeup signal

2018-12-09 Thread Andreas Kemnade
, because the reaction on serial line is slower and are in line with previous patches by Neil Brown and H. Nikolaus Schaller . Signed-off-by: Andreas Kemnade --- Changes in v2: - style cleanup - do not keep serdev open just because runtime is active, only when needed (gnss device is opened or

[PATCH v2 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2018-12-09 Thread Andreas Kemnade
The api forbids writing data there otherwise. Prepare for the serdev_open()/close() being a part of runtime pm. Signed-off-by: Andreas Kemnade --- Changes in v2: add locking drivers/gnss/sirf.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 0/5] gnss: sirf: add support for w2sg0004 + lna

2018-12-09 Thread Andreas Kemnade
reordering Andreas Kemnade (5): gnss: sirf: write data to gnss only when the gnss device is open gnss: sirf: power on logic for devices without wakeup signal dt-bindings: gnss: add w2sg0004 compatible string gnss: sirf: add a separate supply for a lna dt-bindings: gnss: add lna-supply property

Re: [PATCH RFC 5/5] dt-bindings: gnss: add lna-supply property

2018-12-09 Thread Andreas Kemnade
On Wed, 5 Dec 2018 16:09:39 +0100 Johan Hovold wrote: > On Sun, Nov 18, 2018 at 10:58:01PM +0100, Andreas Kemnade wrote: > > Add lna-supply property. > > > > Signed-off-by: Andreas Kemnade > > --- > > Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 +

Re: [PATCH 2/5] gnss: sirf: power on logic for devices without wakeup signal

2018-12-05 Thread Andreas Kemnade
On Wed, 5 Dec 2018 16:01:16 +0100 Johan Hovold wrote: > On Sun, Nov 18, 2018 at 10:57:58PM +0100, Andreas Kemnade wrote: > > Some Wi2Wi devices do not have a wakeup output, so device state can > > only be indirectly detected by looking whether there is communitcation > >

Re: [PATCH 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2018-12-05 Thread Andreas Kemnade
On Wed, 5 Dec 2018 15:47:39 +0100 Johan Hovold wrote: > On Sun, Nov 18, 2018 at 10:57:57PM +0100, Andreas Kemnade wrote: > > The api forbids writing data there otherwise. Prepare for the > > serdev_open()/close() being a part of runtime pm. > > > > Sig

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-12-03 Thread Andreas Kemnade
On Mon, 3 Dec 2018 07:39:10 -0800 Tony Lindgren wrote: > * Stephen Boyd [181130 23:52]: > > Quoting Tony Lindgren (2018-11-30 07:37:29) > > > Hi, > > > > > > * Tero Kristo [181130 09:21]: > > > > On 30/11/2018 09:57, Stephen Boyd wrote: > > > > > No that is not preferred. Can the omap2_c

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-11-30 Thread Andreas Kemnade
Hi Tero, On Fri, 30 Nov 2018 11:20:49 +0200 Tero Kristo wrote: > On 30/11/2018 09:57, Stephen Boyd wrote: > > Quoting Tero Kristo (2018-11-29 23:35:35) > >> On 30/11/2018 09:20, Stephen Boyd wrote: > >>> Quoting Andreas Kemnade (2018-11-29 22:15:34) > >

Re: [PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna

2018-11-29 Thread Andreas Kemnade
Hi, On Tue, 27 Nov 2018 19:03:57 +0100 Pavel Machek wrote: > Hi! > > > Devices might have a separate lna between antenna output of the gps > > chip and the antenna which might have a separate supply > > Might have. > > > @@ -340,6 +349,12 @@ static int sirf_probe(struct serdev_device *serde

Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-11-29 Thread Andreas Kemnade
Hi Stephen, On Thu, 29 Nov 2018 16:25:05 -0800 Stephen Boyd wrote: > Quoting Andreas Kemnade (2018-11-10 12:31:14) > > Code might use autoidle api with clocks not being omap2 clocks, > > so check if clock type is not basic > > > > Signed-off-by: Andreas Kem

Re: [Letux-kernel] [PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna

2018-11-19 Thread Andreas Kemnade
Hi, On Mon, 19 Nov 2018 09:22:59 +0100 "H. Nikolaus Schaller" wrote: > Hi, > > > Am 18.11.2018 um 22:57 schrieb Andreas Kemnade : > > > > Here is another chapter of the story to get gta04 gnss power > > management into the mainline kernel. > > Th

[PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna

2018-11-18 Thread Andreas Kemnade
that chip without an additional lna power supply can already benefit from it if we should do more discussion first. I just kept them together so that the full picture can be seen. Andreas Kemnade (5): gnss: sirf: write data to gnss only when the gnss device is open gnss: sirf: power on logic for

[PATCH 1/5] gnss: sirf: write data to gnss only when the gnss device is open

2018-11-18 Thread Andreas Kemnade
The api forbids writing data there otherwise. Prepare for the serdev_open()/close() being a part of runtime pm. Signed-off-by: Andreas Kemnade --- drivers/gnss/sirf.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c

[PATCH 3/5] dt-bindings: gnss: add w2sg0004 compatible string

2018-11-18 Thread Andreas Kemnade
Add w2sg0004 compatible string since devices without wakeup pins are now supported. Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gnss/sirfstar.txt b/Documentation

[PATCH RFC 4/5] gnss: sirf: add a separate supply for a lna

2018-11-18 Thread Andreas Kemnade
Devices might have a separate lna between antenna output of the gps chip and the antenna which might have a separate supply Signed-off-by: Andreas Kemnade --- drivers/gnss/sirf.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gnss/sirf.c b/drivers/gnss/sirf.c index

[PATCH RFC 5/5] dt-bindings: gnss: add lna-supply property

2018-11-18 Thread Andreas Kemnade
Add lna-supply property. Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/gnss/sirfstar.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gnss/sirfstar.txt b/Documentation/devicetree/bindings/gnss/sirfstar.txt index 1be7597ae884

[PATCH 2/5] gnss: sirf: power on logic for devices without wakeup signal

2018-11-18 Thread Andreas Kemnade
, because the reaction on serial line is slower and are in line with previous patches by Neil Brown and H. Nikolaus Schaller . Signed-off-by: Andreas Kemnade --- drivers/gnss/sirf.c | 97 +++-- 1 file changed, 65 insertions(+), 32 deletions(-) diff

Re: [Letux-kernel] [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2018-11-16 Thread Andreas Kemnade
Hi Marcel, On Wed, 14 Nov 2018 08:51:17 +0100 Marcel Holtmann wrote: [...[ > Btw. I see nothing standing in the way of merging btuart.c driver and then go > from there. Either I dig this out and submit or someone else does. > Do you mean this? https://patchwork.kernel.org/patch/10490651/ Regar

Re: [Letux-kernel] [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2018-11-14 Thread Andreas Kemnade
On Wed, 14 Nov 2018 08:51:17 +0100 Marcel Holtmann wrote: > Hi Andreas, > > >>>>> Am 12.11.2018 um 21:59 schrieb Andreas Kemnade : > >>>>> On Sun, 11 Nov 2018 03:46:48 +0100 > >>>>> Sebastian Reichel wrote: > >>

Re: [Letux-kernel] [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2018-11-13 Thread Andreas Kemnade
On Mon, 12 Nov 2018 18:17:38 -0600 Rob Herring wrote: > On Mon, Nov 12, 2018 at 4:27 PM Sebastian Reichel > wrote: > > > > Hi, > > > > On Mon, Nov 12, 2018 at 10:19:02PM +0100, H. Nikolaus Schaller wrote: > > > > Am 12.11.2018 um 21:59 schrieb Andrea

Re: [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2018-11-12 Thread Andreas Kemnade
Hi, On Sun, 11 Nov 2018 03:46:48 +0100 Sebastian Reichel wrote: > Hi, > > On Sun, Nov 11, 2018 at 12:20:34AM +0100, Andreas Kemnade wrote: > > This is a first try to be able to use h4 devices specified in > > the devicetree, so you do not need to call hciattach and > &

[PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2018-11-10 Thread Andreas Kemnade
proceeding further it should be checked if the general way of doing things is right. Signed-off-by: Andreas Kemnade --- drivers/bluetooth/hci_h4.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/drivers/bluetooth/hci_h4.c b/drivers/bluetooth/hci_h4

[PATCH v2 0/3] mach-omap2: handle autoidle denial

2018-11-10 Thread Andreas Kemnade
logic - check whether clock type is basic Andreas Kemnade (3): clk: ti: add a usecount for autoidle clk: ti: check clock type before doing autoidle ops arm: omap_hwmod disable ick autoidling when a hwmod requires that arch/arm/mach-omap2/omap_hwmod.c | 16 ++ drivers/clk/ti

[PATCH v2 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2018-11-10 Thread Andreas Kemnade
_setup_iclk_autoidle. dss_ick is an example for that. Signed-off-by: Andreas Kemnade --- Comments to v1 to this patch were worked into a new 2/3 --- arch/arm/mach-omap2/omap_hwmod.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-11-10 Thread Andreas Kemnade
Code might use autoidle api with clocks not being omap2 clocks, so check if clock type is not basic Signed-off-by: Andreas Kemnade --- New in v2 --- drivers/clk/ti/autoidle.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/clk/ti/autoidle.c b/drivers

[PATCH v2 1/3] clk: ti: add a usecount for autoidle

2018-11-10 Thread Andreas Kemnade
Multiple users might deny autoidle on a clock. So we should have some counting here, also according to the comment in _setup_iclk_autoidle(). Also setting autoidle regs is not atomic, so there is another reason for locking. Signed-off-by: Andreas Kemnade --- Changes since v1: - use spinlocks

Re: [PATCH 1/2] clk: ti: add a usecount for autoidle

2018-11-09 Thread Andreas Kemnade
On Thu, 8 Nov 2018 12:36:35 +0200 Tero Kristo wrote: > On 04/10/2018 23:38, Andreas Kemnade wrote: > > We have the scenario that first autoidle is disabled for all clocks, > > then it is disabled for selected ones and then enabled for all. So > > we should have some counting

Re: [PATCH 2/2] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2018-11-08 Thread Andreas Kemnade
Hi, On Thu, 8 Nov 2018 12:26:08 +0200 Tero Kristo wrote: > On 04/10/2018 23:38, Andreas Kemnade wrote: > > Deny autoidle for hwmods with the OCPIF_SWSUP_IDLE flag, > > that makes hwmods working properly which cannot handle > > autoidle properly in lower power states. >

Re: [PATCH 0/2] mach-omap2: handle autoidle denial

2018-11-07 Thread Andreas Kemnade
ping. ..after stumbling again about that problem during testing with 4.20-rc1. will retest it there. On Thu, 4 Oct 2018 22:38:15 +0200 Andreas Kemnade wrote: > On the gta04 with a dm3730 omap_hdq does not work properly when the > device enters lower power states. Idling uart1 and 2 is

[PATCH 1/2] clk: ti: add a usecount for autoidle

2018-10-04 Thread Andreas Kemnade
We have the scenario that first autoidle is disabled for all clocks, then it is disabled for selected ones and then enabled for all. So we should have some counting here, also according to the comment in _setup_iclk_autoidle() Signed-off-by: Andreas Kemnade --- drivers/clk/ti/autoidle.c | 32

[PATCH 2/2] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2018-10-04 Thread Andreas Kemnade
_setup_iclk_autoidle. dss_ick is an example for that. Signed-off-by: Andreas Kemnade --- arch/arm/mach-omap2/omap_hwmod.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index bb641e6c93d0

[PATCH 0/2] mach-omap2: handle autoidle denial

2018-10-04 Thread Andreas Kemnade
- deny_idle/allow_idle calls moved to clock enable/disable of the individual modules Andreas Kemnade (2): clk: ti: add a usecount for autoidle arm: omap_hwmod disable ick autoidling when a hwmod requires that arch/arm/mach-omap2/omap_hwmod.c | 16 drivers/clk/ti/autoidle.c

Re: [PATCH RFC 1/2] clk: ti: add a usecount for autoidle

2018-10-04 Thread Andreas Kemnade
Hi, On Thu, 4 Oct 2018 17:40:06 +0300 Tero Kristo wrote: > On 04/10/18 08:51, Andreas Kemnade wrote: > > We have the scenario that first autoidle is disabled for all clocks, > > then it is disabled for selected ones and then enabled for all. So > > we should have som

[PATCH RFC 1/2] clk: ti: add a usecount for autoidle

2018-10-03 Thread Andreas Kemnade
We have the scenario that first autoidle is disabled for all clocks, then it is disabled for selected ones and then enabled for all. So we should have some counting here, also according to the comment in _setup_iclk_autoidle() Signed-off-by: Andreas Kemnade --- drivers/clk/ti/autoidle.c | 20

[PATCH RFC 2/2] arm: mach-omap2: setup iclk autoidle according to flags

2018-10-03 Thread Andreas Kemnade
explicitly because there might be clocks which do not support that operation and it is enabled afterwards in arm/mach-omap2/pm.c anyways. Signed-off-by: Andreas Kemnade --- arch/arm/mach-omap2/omap_hwmod.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH RFC 0/2] mach-omap2: handle autoidle denial

2018-10-03 Thread Andreas Kemnade
changing order. Andreas Kemnade (2): clk: ti: add a usecount for autoidle arm: mach-omap2: setup iclk autoidle according to flags arch/arm/mach-omap2/omap_hwmod.c | 8 ++-- drivers/clk/ti/autoidle.c| 20 include/linux/clk/ti.h | 1 + 3 files changed

Re: [PATCH RESEND] twl4030_charger: fix charging current out-of-bounds

2018-09-30 Thread Andreas Kemnade
Hi Pavel, On Sun, 30 Sep 2018 22:16:42 +0200 Pavel Machek wrote: > On Mon 2018-09-17 07:20:35, Andreas Kemnade wrote: > > the charging current uses unsigned int variables, if we step back > > if the current is still low, we would run into negative which > > means setting

Re: [PATCH] ARM: dts: gta04: add serial console wakeup irq

2018-09-24 Thread Andreas Kemnade
Hi Tony, On Mon, 24 Sep 2018 15:03:45 -0700 Tony Lindgren wrote: > * Andreas Kemnade [180923 08:12]: > > This enables the possibility to have more aggressive runtime pm > > by providing proper wakeup irq for the serial console. > > Thanks applying to omap-for-v4.20/dt.

[PATCH] ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio

2018-09-24 Thread Andreas Kemnade
Pullup and down settings were missing, so add them to avoid floating pins and make headset detection working. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/omap3-gta04.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm

[PATCH] ARM: dts: gta04: add serial console wakeup irq

2018-09-23 Thread Andreas Kemnade
This enables the possibility to have more aggressive runtime pm by providing proper wakeup irq for the serial console. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/omap3-gta04.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot

[PATCH] w1: omap-hdq: fix missing bus unregister at removal

2018-09-22 Thread Andreas Kemnade
] Code: bad PC value [ 128.064697] ---[ end trace af066e33c0e14119 ]--- Cc: Signed-off-by: Andreas Kemnade --- drivers/w1/masters/omap_hdq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index 83fc9aab34e8..3099052e1243 100644

[PATCH v2] phy: phy-twl4030-usb: fix denied runtime access

2018-09-22 Thread Andreas Kemnade
device is woken up from suspend by plugging in usb. Signed-off-by: Andreas Kemnade --- Changes in v2: * use pm suspend/resume callback instead of delayed_work as suggested by Dmitry drivers/phy/ti/phy-twl4030-usb.c | 29 + 1 file changed, 29 insertions(+) diff --git a

Re: [PATCH RESEND] phy: phy-twl4030-usb: fix denied runtime access

2018-09-18 Thread Andreas Kemnade
Hi, On Mon, 17 Sep 2018 15:23:45 -0700 Dmitry Torokhov wrote: > On Mon, Sep 17, 2018 at 08:56:34PM +0200, Andreas Kemnade wrote: > > Hi Dmitry, > > > > On Mon, 17 Sep 2018 10:51:31 -0700 > > Dmitry Torokhov wrote: > > > > > Hi Andreas, > > &

Re: [PATCH RESEND] phy: phy-twl4030-usb: fix denied runtime access

2018-09-17 Thread Andreas Kemnade
Hi Dmitry, On Mon, 17 Sep 2018 10:51:31 -0700 Dmitry Torokhov wrote: > Hi Andreas, > > On Mon, Sep 17, 2018 at 07:22:54AM +0200, Andreas Kemnade wrote: > > When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS, > > the counter will be incremented but th

[PATCH RESEND] phy: phy-twl4030-usb: fix denied runtime access

2018-09-16 Thread Andreas Kemnade
suspend by plugging in usb. Signed-off-by: Andreas Kemnade --- drivers/phy/ti/phy-twl4030-usb.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/phy/ti/phy-twl4030-usb.c b/drivers/phy/ti/phy-twl4030-usb.c index a44680d64f9b..1f3cf4e48383 100644 --- a/drivers/phy/ti/phy-twl4030

[PATCH RESEND] twl4030_charger: fix charging current out-of-bounds

2018-09-16 Thread Andreas Kemnade
the charging current uses unsigned int variables, if we step back if the current is still low, we would run into negative which means setting the target to a huge value. Better add checks here. Signed-off-by: Andreas Kemnade --- drivers/power/supply/twl4030_charger.c | 3 ++- 1 file changed, 2

Re: Regression in next with filesystem context concept

2018-09-07 Thread Andreas Kemnade
Hi, On Fri, 7 Sep 2018 09:10:23 -0700 Tony Lindgren wrote: > * David Howells [180907 08:51]: > > Tony Lindgren wrote: > > > > > Looks like next-20180906 now has a regression where mounting > > > root won't work with commit fd0002870b45 ("vfs: Implement a > > > filesystem superblock creation

Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal

2018-09-04 Thread Andreas Kemnade
Hi, On Tue, 4 Sep 2018 16:34:56 +0200 Ulf Hansson wrote: > On 2 September 2018 at 09:30, Andreas Kemnade wrote: > > after unbinding mmc I get things like this: > > [ 185.294067] mmc1: card 0001 removed > > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no re

[PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal

2018-09-02 Thread Andreas Kemnade
at removal. Signed-off-by: Andreas Kemnade Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq") --- drivers/mmc/host/omap_hsmmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsm

[PATCH] phy: phy-twl4030-usb: fix denied runtime access

2018-08-27 Thread Andreas Kemnade
suspend by plugging in usb. Signed-off-by: Andreas Kemnade --- drivers/phy/ti/phy-twl4030-usb.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/phy/ti/phy-twl4030-usb.c b/drivers/phy/ti/phy-twl4030-usb.c index a44680d64f9b..1f3cf4e48383 100644 --- a/drivers/phy/ti/phy-twl4030

[PATCH] pwm: pwm-omap-dmtimer: fix probing problems by returning EPROBE_DEFER

2018-07-28 Thread Andreas Kemnade
defer probing Fixes: b7290cf6ff78 (pwm: pwm-omap-dmtimer: Adapt driver to utilize dmtimer pdata ops) Signed-off-by: Andreas Kemnade --- drivers/pwm/pwm-omap-dmtimer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap

Re: bloated defconfigs

2018-07-28 Thread Andreas Kemnade
Hi, On Sat, 28 Jul 2018 16:01:41 +0300 Andy Shevchenko wrote: > On Sat, Jul 28, 2018 at 3:59 PM, Andreas Kemnade wrote: > > Hi, > > > > I just stumbled upon our defconfigs. > > > > andi@aktux:~/gta04/gta04-kernel$ ls -l arch/arm/configs/ -Sr | tail -n > &g

bloated defconfigs

2018-07-28 Thread Andreas Kemnade
Hi, I just stumbled upon our defconfigs. andi@aktux:~/gta04/gta04-kernel$ ls -l arch/arm/configs/ -Sr | tail -n 10 -rw-r--r-- 1 andi andi 9524 Apr 7 14:53 imote2_defconfig -rw-r--r-- 1 andi andi 9985 Jul 28 13:34 imx_v6_v7_defconfig -rw-r--r-- 1 andi andi 10118 Apr 7 14:53 ezx_defconfig -r

Re: [Letux-kernel] [PATCH 09/32] ARM: dts: omap3-gta04: make NAND partitions compatible with recent U-Boot

2018-07-25 Thread Andreas Kemnade
On Wed, 25 Jul 2018 10:33:05 +0200 Ladislav Michl wrote: > On Wed, Jul 25, 2018 at 10:18:28AM +0200, H. Nikolaus Schaller wrote: > > > > > Am 25.07.2018 um 10:07 schrieb Ladislav Michl : > > > > > > On Wed, Jul 25, 2018 at 08:58:41AM +0200, H. Nikolaus Schaller wrote: > > >> Vendor defined

Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding

2018-05-03 Thread Andreas Kemnade
On Thu, 3 May 2018 11:35:21 +0200 H. Nikolaus Schaller wrote: > I have realized that the w2sg0004 is an exception (although a Sirf chip) > that it does not provide a WAKEUP signal. And another significant > difference is that we have to keep the serdev UART enabled even if there > is no user-spa

Re: [PATCH 0/7] gnss: add new GNSS subsystem

2018-04-24 Thread Andreas Kemnade
On Tue, 24 Apr 2018 22:13:19 +0200 Pavel Machek wrote: > Hi! > > > This series adds a new subsystem for GNSS receivers (e.g. GPS > > receivers). > > Actually... I'd just call it GPS subsystem. Yes, GPS is a bit > misleading, but so is GNSS. We'd like Loran to use similar interface, > right? W

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-10 Thread Andreas Kemnade
Hi Ladis, On Tue, 10 Apr 2018 22:56:43 +0200 Ladislav Michl wrote: > Hi Nikolaus, > > On Tue, Apr 10, 2018 at 06:25:17PM +0200, H. Nikolaus Schaller wrote: > > Hi, > > we just started testing the v4.16 kernel and found the > > device no longer bootable (works with v4.15). It turned > > out that

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-03-07 Thread Andreas Kemnade
Hi, On Thu, 18 Jan 2018 17:47:36 +1100 Johan Hovold wrote: [...] > > > > So to avoid having hardware information spread all over the table at least > > these information would need to be in devicetree. But that also all feels > > like a hack and hard to maintain. > > Having the device descri

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-15 Thread Andreas Kemnade
On Wed, 7 Feb 2018 14:37:00 -0600 Bin Liu wrote: > On Tue, Feb 06, 2018 at 08:00:24PM +0100, Andreas Kemnade wrote: > > Hi, > > > > On Tue, 6 Feb 2018 12:46:05 -0600 > > Bin Liu wrote: > > > > > Hi, > > > > > > On Sat, Jan 27, 2

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Andreas Kemnade
Hi, On Tue, 6 Feb 2018 10:47:25 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180127 08:34]: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set before suspend (becau

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Andreas Kemnade
Hi, On Tue, 6 Feb 2018 12:46:05 -0600 Bin Liu wrote: > Hi, > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is no

[PATCH] usb: musb: fix enumeration after resume

2018-01-27 Thread Andreas Kemnade
lated stuff which needs to be enabled. Also interrupts are enabled, as it was the original idea of calling musb_start() in musb_resume() according to Commit 6fc6f4b87cb3 ("usb: musb: Disable interrupts on suspend, enable them on resume") Signed-off-by: Andreas Kemnade --- drivers/usb/musb/

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-12 Thread Andreas Kemnade
On Fri, 12 Jan 2018 15:46:47 +0100 Johan Hovold wrote: > On Tue, Jan 09, 2018 at 06:43:47PM +0100, Andreas Kemnade wrote: > > On Fri, 22 Dec 2017 13:44:27 +0100 > > Johan Hovold wrote: > > > > [...] > > > I'd suggest reiterating the problem you

Re: [Letux-kernel] [PATCH v5 3/5] misc serdev: Add w2sg0004 (gps receiver) power control driver

2018-01-09 Thread Andreas Kemnade
On Fri, 22 Dec 2017 13:44:27 +0100 Johan Hovold wrote: [...] > I'd suggest reiterating the problem you're trying to solve and > enumerating the previously discussed potential solutions in order to > find a proper abstraction level for this (before getting lost in > implementation details). > The

Re: [PATCH 1/3] [media] si2157: get chip id during probing

2017-05-15 Thread Andreas Kemnade
Hi, On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari wrote: > On 03/16/2017 12:22 AM, Andreas Kemnade wrote: > > If the si2157 is behind a e.g. si2168, the si2157 will > > at least in some situations not be readable after the si268 > > got the command 0101. It still acc

Re: [PATCH 2/3] [media] af9035: init i2c already in it930x_frontend_attach

2017-05-04 Thread Andreas Kemnade
On Wed, 15 Mar 2017 23:22:09 +0100 Andreas Kemnade wrote: > i2c bus is already needed when the frontend is probed, > so init it already in it930x_frontend_attach > That prevents errors like > si2168: probe of 6-0067 failed with error -5 > > Signed-off-by: Andreas Kemnade

Re: [PATCH] net: hso: register netdev later to avoid a race condition

2017-04-28 Thread Andreas Kemnade
On Thu, 27 Apr 2017 10:44:01 +0200 Johan Hovold wrote: > On Wed, Apr 26, 2017 at 07:26:40PM +0200, Andreas Kemnade wrote: > > If the netdev is accessed before the urbs are initialized, > > there will be NULL pointer dereferences. That is avoided by > > registering it when it

Re: [PATCH] ARM: Fix __show_regs output timestamps

2017-04-26 Thread Andreas Kemnade
o_start_net_device+0x50/0xc0 [hso] [ 102.674835] LR is at hso_net_open+0x68/0x84 [hso] [ 102.679809] pc : []lr : []psr: a00b0013 [ 102.686462] sp : ed047e20 ip : fp : yes, the kernel oopses in a nicer way. Tested-by: Andreas Kemnade Regards, Andreas Kemnade > S

[PATCH] net: hso: register netdev later to avoid a race condition

2017-04-26 Thread Andreas Kemnade
e3822080 e1822781 e5981014 (e5832030) [ 1514.510833] ---[ end trace dfb3e53c657f34a0 ]--- Reported-by: H. Nikolaus Schaller Signed-off-by: Andreas Kemnade --- drivers/net/usb/hso.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb

[PATCH] net: hso: fix module unloading

2017-04-24 Thread Andreas Kemnade
[] (SyS_delete_module+0x160/0x1dc) [40265.985443] [] (SyS_delete_module) from [] (ret_fast_syscall+0x0/0x1c) [40265.994171] Code: c1458d54 e59f3020 e92d4010 e1a04000 (e5941034) [40266.016693] ---[ end trace 9d5ac43c7e41075c ]--- Signed-off-by: Andreas Kemnade --- drivers/net/usb/hso.c | 2 +- 1

Re: [PATCH 1/3] [media] si2157: get chip id during probing

2017-04-23 Thread Andreas Kemnade
On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari wrote: > On 03/16/2017 12:22 AM, Andreas Kemnade wrote: > > If the si2157 is behind a e.g. si2168, the si2157 will > > at least in some situations not be readable after the si268 > > got the command 0101. It still accepts co

Re: [PATCH 0/3] support for Logilink VG0022a DVB-T2 stick

2017-04-10 Thread Andreas Kemnade
ping On Wed, 15 Mar 2017 23:22:07 +0100 Andreas Kemnade wrote: > Hi all, > here are some patches needed for supporting the > Logilink VG0022A DVB-T2 stick. > As the combination of chips in that stick is not > uncommon, the first two patches might also fix problems > fo

[PATCH 1/3] [media] si2157: get chip id during probing

2017-03-15 Thread Andreas Kemnade
a symptome of that problem: si2157 7-0063: unknown chip version Si21255-\x\x\x Signed-off-by: Andreas Kemnade --- drivers/media/tuners/si2157.c | 54 ++ drivers/media/tuners/si2157_priv.h | 7 + 2 files changed, 39 insertions

[PATCH 3/3] [media] af9035: add Logilink vg0022a to device id table

2017-03-15 Thread Andreas Kemnade
Ths adds the logilink VG00022a dvb-t dongle to the device table. The dongle contains (checked by removing the case) IT9303 SI2168 214730 Signed-off-by: Andreas Kemnade --- drivers/media/usb/dvb-usb-v2/af9035.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2

[PATCH 2/3] [media] af9035: init i2c already in it930x_frontend_attach

2017-03-15 Thread Andreas Kemnade
i2c bus is already needed when the frontend is probed, so init it already in it930x_frontend_attach That prevents errors like si2168: probe of 6-0067 failed with error -5 Signed-off-by: Andreas Kemnade --- drivers/media/usb/dvb-usb-v2/af9035.c | 43 ++- 1

[PATCH 0/3] support for Logilink VG0022a DVB-T2 stick

2017-03-15 Thread Andreas Kemnade
Hi all, here are some patches needed for supporting the Logilink VG0022A DVB-T2 stick. As the combination of chips in that stick is not uncommon, the first two patches might also fix problems for similar hardware. Andreas Kemnade (3): [media] si2157: get chip id during probing [media] af9035

Re: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-21 Thread Andreas Kemnade
Hi, [...] > > Hm. Why not touching pixel (0,0) on the touch is always pixel (0,0) > > on the screen and touching pixel (639,479) is always (639,479)? > > Important is that there is no 1:1 mapping between input evdev device > and drm/fb output device. These are two independent devices. There is >

Re: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-19 Thread Andreas Kemnade
Hi, On Sun, 19 Feb 2017 21:57:08 +0100 Pavel Machek wrote: > Hi! > > > > But as said I don't think we need float or fixed point for > > practical systems at all. > > So you are going to loose precision. And if userspace decides to > calibrate it slightly differently from kernel, lost precisio

Re: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-18 Thread Andreas Kemnade
Hi Dmitry, On Fri, 17 Feb 2017 12:40:41 -0800 Dmitry Torokhov wrote: [...] > > Let me cite myself: > > > > >> This makes it possible to pre-calibrate the touch so that is > > >> (almost) > > Yes, it allows you to pre-calibrate, I get it. But you still do > properly calibrate later, right? So

Re: [v2] musb: omap2430: do not assume balanced enable()/disable()

2016-09-10 Thread Andreas Kemnade
On Fri, 9 Sep 2016 16:40:15 -0700 Tony Lindgren wrote: > * Tony Lindgren [160909 14:33]: > > * Andreas Kemnade [160909 14:22]: > > > We have two independant things: > > > 1. phy-twl4030-usb (and perhaps others) do not enable > > > the phy enough

<    1   2   3   4   >