On 21.02.2016 22:30, Joe Perches wrote:
On Sun, 2016-02-21 at 22:38 +0100, Andrej Krpic wrote:
Minor formatting changes to remove errors and reduce number of
warnings produced by checkpatch.pl script.
[]
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
[]
@@ -489,7 +490,8 @@ static
On 21.02.2016 22:30, Joe Perches wrote:
On Sun, 2016-02-21 at 22:38 +0100, Andrej Krpic wrote:
Minor formatting changes to remove errors and reduce number of
warnings produced by checkpatch.pl script.
[]
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
[]
@@ -489,7 +490,8 @@ static
On 21.02.2016 23:42, One Thousand Gnomes wrote:
On Sun, 21 Feb 2016 22:38:29 +0100
Andrej Krpic <a...@tnode.com> wrote:
When using n_gsm you have to explicitly set it to work as a
initiator
station. This led me to believe that it can also work as a
responder.
snip
This looks reasonable
On 21.02.2016 23:42, One Thousand Gnomes wrote:
On Sun, 21 Feb 2016 22:38:29 +0100
Andrej Krpic wrote:
When using n_gsm you have to explicitly set it to work as a
initiator
station. This led me to believe that it can also work as a
responder.
snip
This looks reasonable to me. It was never
Please ignore this duplicate thread.
Please ignore this duplicate thread.
Minor formatting changes to remove errors and reduce number of
warnings produced by checkpatch.pl script.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 138
1 file changed, 95 insertions(+), 43 deletions(-)
diff
Minor formatting changes to remove errors and reduce number of
warnings produced by checkpatch.pl script.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 138
1 file changed, 95 insertions(+), 43 deletions(-)
diff --git a/drivers/tty
0 10 0 (response)
1 0 _\ 01 1 (command)
0 1 / 01 1 (command)
1 1 10 0 (response)
Signed-off-by: An
0 10 0 (response)
1 0 _\ 01 1 (command)
0 1 / 01 1 (command)
1 1 10 0 (response)
Signed-off-by: An
, valid sent commands and received
responses must have C/R bit set to 0.
Change the value of C/R bit in command and response frames to
depend on whether the station is initator or not.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 4 ++--
1 file changed, 2 insertions
, valid sent commands and received
responses must have C/R bit set to 0.
Change the value of C/R bit in command and response frames to
depend on whether the station is initator or not.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
of transmitted control messages is fixed and
control messages start to be recognized.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 8aa90e0..b0d9edd
of transmitted control messages is fixed and
control messages start to be recognized.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 8aa90e0..b0d9edd 100644
--- a/drivers/tty
) as it is done in gsm_control_reply and expected in
gsm_dlci_command.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 3c4c521..8aa90e0 100644
--- a/d
).
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index b0d9edd..12b149d 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1895,9 +1
) as it is done in gsm_control_reply and expected in
gsm_dlci_command.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 3c4c521..8aa90e0 100644
--- a/drivers/tty/n_gsm.c
).
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index b0d9edd..12b149d 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1895,9 +1895,14 @@ static void
by the checkpatch script.
Andrej Krpic (8):
tty: n_gsm: fix formatting errors
tty: n_gsm: fix C/R bit when sending as a responder
tty: n_gsm: make mux work as a responder station
tty: n_gsm: send DM response when accessing an invalid channel
tty: n_gsm: replace dead code with a meaningful comment
by the checkpatch script.
Andrej Krpic (8):
tty: n_gsm: fix formatting errors
tty: n_gsm: fix C/R bit when sending as a responder
tty: n_gsm: make mux work as a responder station
tty: n_gsm: send DM response when accessing an invalid channel
tty: n_gsm: replace dead code with a meaningful comment
UI/UIH frame can be received as a command from other station or
as a response to a command we issued earlier.
Add this knowledge to the source code as a comment and remove
useless #if 0/#endif block.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 9 +
UI/UIH frame can be received as a command from other station or
as a response to a command we issued earlier.
Add this knowledge to the source code as a comment and remove
useless #if 0/#endif block.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 9 +
1 file changed, 5
Change C/R bit in a response to a UI/UIH frame sent to
non-existing/closed channel. As DM frame type is only valid as a
response, it should be sent using gsm_response function.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 2 +-
1 file changed, 1 insertion(+), 1 de
Change C/R bit in a response to a UI/UIH frame sent to
non-existing/closed channel. As DM frame type is only valid as a
response, it should be sent using gsm_response function.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Minor formatting changes to remove errors and reduce number of
warnings produced by checkpatch.pl script.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 138
1 file changed, 95 insertions(+), 43 deletions(-)
diff
Minor formatting changes to remove errors and reduce number of
warnings produced by checkpatch.pl script.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 138
1 file changed, 95 insertions(+), 43 deletions(-)
diff --git a/drivers/tty
by the checkpatch script.
Andrej Krpic (8):
tty: n_gsm: fix formatting errors
tty: n_gsm: fix C/R bit when sending as a responder
tty: n_gsm: make mux work as a responder station
tty: n_gsm: send DM response when accessing an invalid channel
tty: n_gsm: replace dead code with a meaningful comment
by the checkpatch script.
Andrej Krpic (8):
tty: n_gsm: fix formatting errors
tty: n_gsm: fix C/R bit when sending as a responder
tty: n_gsm: make mux work as a responder station
tty: n_gsm: send DM response when accessing an invalid channel
tty: n_gsm: replace dead code with a meaningful comment
) as it is done in gsm_control_reply and expected in
gsm_dlci_command.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 3c4c521..8aa90e0 100644
--- a/d
0 10 0 (response)
1 0 _\ 01 1 (command)
0 1 / 01 1 (command)
1 1 10 0 (response)
Signed-off-by: An
) as it is done in gsm_control_reply and expected in
gsm_dlci_command.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 3c4c521..8aa90e0 100644
--- a/drivers/tty/n_gsm.c
0 10 0 (response)
1 0 _\ 01 1 (command)
0 1 / 01 1 (command)
1 1 10 0 (response)
Signed-off-by: An
, valid sent commands and received
responses must have C/R bit set to 0.
Change the value of C/R bit in command and response frames to
depend on whether the station is initator or not.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 4 ++--
1 file changed, 2 insertions
of transmitted control messages is fixed and
control messages start to be recognized.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 8aa90e0..b0d9edd
Change C/R bit in a response to a UI/UIH frame sent to
non-existing/closed channel. As DM frame type is only valid as a
response, it should be sent using gsm_response function.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 2 +-
1 file changed, 1 insertion(+), 1 de
, valid sent commands and received
responses must have C/R bit set to 0.
Change the value of C/R bit in command and response frames to
depend on whether the station is initator or not.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
of transmitted control messages is fixed and
control messages start to be recognized.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 8aa90e0..b0d9edd 100644
--- a/drivers/tty
Change C/R bit in a response to a UI/UIH frame sent to
non-existing/closed channel. As DM frame type is only valid as a
response, it should be sent using gsm_response function.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
).
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index b0d9edd..12b149d 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1895,9 +1
UI/UIH frame can be received as a command from other station or
as a response to a command we issued earlier.
Add this knowledge to the source code as a comment and remove
useless #if 0/#endif block.
Signed-off-by: Andrej Krpic <a...@tnode.com>
---
drivers/tty/n_gsm.c | 9 +
).
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index b0d9edd..12b149d 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1895,9 +1895,14 @@ static void
UI/UIH frame can be received as a command from other station or
as a response to a command we issued earlier.
Add this knowledge to the source code as a comment and remove
useless #if 0/#endif block.
Signed-off-by: Andrej Krpic
---
drivers/tty/n_gsm.c | 9 +
1 file changed, 5
42 matches
Mail list logo