Re: [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

On 2018-05-08 02:12 PM, Luis R. Rodriguez wrote: Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/fallback-mechanisms.rst | 9

Re: [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

On 2018-05-08 02:12 PM, Luis R. Rodriguez wrote: Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/fallback-mechanisms.rst | 9 ++--- 1 file

Re: [PATCH 6/9] firmware: print firmware name on fallback path

On 2018-05-03 07:42 PM, Luis R. Rodriguez wrote: On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: Previously, one could assume the firmware name from the preceding message: "Direct firmware load for {name} failed with error %d". However, with the new firmware_requ

Re: [PATCH 6/9] firmware: print firmware name on fallback path

On 2018-05-03 07:42 PM, Luis R. Rodriguez wrote: On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: Previously, one could assume the firmware name from the preceding message: "Direct firmware load for {name} failed with error %d". However, with the new firmware_requ

[PATCH 2/2] usb: typec: fix formatting errors that cause build breakage

The ASCII art illustration should be marked as a preformatted text block. Otherwise the build will fail when attempting to parse it. Fixes: bdecb33af34f ( "usb: typec: API for controlling USB ..." ) Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- Documentation/driver-a

[PATCH 2/2] usb: typec: fix formatting errors that cause build breakage

The ASCII art illustration should be marked as a preformatted text block. Otherwise the build will fail when attempting to parse it. Fixes: bdecb33af34f ( "usb: typec: API for controlling USB ..." ) Signed-off-by: Andres Rodriguez --- Documentation/driver-api/usb/typec.rst | 2

[PATCH 1/2] firmware: some documentation fixes

Including: - Fixup outdated kernel-doc paths - Slightly too short title underline - Some typos Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- Hey Greg, Here is the patch rebased on gregkh/driver-core-linus as requested. Note that there is a patch by Hans de Goede

[PATCH 1/2] firmware: some documentation fixes

Including: - Fixup outdated kernel-doc paths - Slightly too short title underline - Some typos Signed-off-by: Andres Rodriguez --- Hey Greg, Here is the patch rebased on gregkh/driver-core-linus as requested. Note that there is a patch by Hans de Goede that contains some of the path fixes

[PATCH 6/9] firmware: print firmware name on fallback path

mware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c

[PATCH 6/9] firmware: print firmware name on fallback path

mware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/

[PATCH 5/9] firmware: add function to load firmware without warnings v5

_nowait for now, since we lack agreement on the API [0]: https://git.kernel.org/linus/c0cc00f250e1 Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- .../driver-api/firmware/request_firmware.rst | 5 + drivers/base/firmware_loader/main.c

[PATCH 1/9] firmware: some documentation fixes

Including: - Fixup outdated kernel-doc paths - Slightly too short title underline - Some typos Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- Documentation/driver-api/firmware/request_firmware.rst | 16 drivers/base/firmware_loader/fallback.c

[PATCH 5/9] firmware: add function to load firmware without warnings v5

_nowait for now, since we lack agreement on the API [0]: https://git.kernel.org/linus/c0cc00f250e1 Signed-off-by: Andres Rodriguez --- .../driver-api/firmware/request_firmware.rst | 5 + drivers/base/firmware_loader/main.c| 24 ++ include/linux

[PATCH 1/9] firmware: some documentation fixes

Including: - Fixup outdated kernel-doc paths - Slightly too short title underline - Some typos Signed-off-by: Andres Rodriguez --- Documentation/driver-api/firmware/request_firmware.rst | 16 drivers/base/firmware_loader/fallback.c| 4 ++-- drivers/base

[PATCH 4/9] firmware: use () to terminate kernel-doc function names

The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Randy Dunlap <rdun...@infradead.org> --- drivers/base/firmware_loader/fallback.c | 8 drivers/base/firmware_loader/main.c | 22 +++

[PATCH 4/9] firmware: use () to terminate kernel-doc function names

The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez Acked-by: Randy Dunlap --- drivers/base/firmware_loader/fallback.c | 8 drivers/base/firmware_loader/main.c | 22 +++--- 2 files changed, 15 insertions(+), 15 deletions

[PATCH 7/9] firmware: use rename fw_sysfs_fallback to use the firmware_ prefix

Use the correct prefix for symbols exported by firmware_loader(). This is done since firmware_sysfs_fallback() is now exposed through kernel-doc. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/fallback.c | 8 drivers/base/firmware_loader/fall

[PATCH 7/9] firmware: use rename fw_sysfs_fallback to use the firmware_ prefix

Use the correct prefix for symbols exported by firmware_loader(). This is done since firmware_sysfs_fallback() is now exposed through kernel-doc. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 8 drivers/base/firmware_loader/fallback.h | 4 ++-- drivers

[PATCH 9/9] ath10k: re-enable the firmware fallback mechanism for testmode

. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/testmode.c b/drivers/net/wireless/ath/ath10k/testmode.c index 568810b41657..0beb91be1b1c

[PATCH 9/9] ath10k: re-enable the firmware fallback mechanism for testmode

. Signed-off-by: Andres Rodriguez --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/testmode.c b/drivers/net/wireless/ath/ath10k/testmode.c index 568810b41657..0beb91be1b1c 100644 --- a/drivers/net

[PATCH 2/9] firmware: wrap FW_OPT_* into an enum

This should let us associate enum kdoc to these values. v2: use BIT() macro Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/fallback.c | 12 ++-- drivers/base/firmware_loader/fallback.h | 6 -- drivers/base/firmware_loader/firmware.

[PATCH 2/9] firmware: wrap FW_OPT_* into an enum

This should let us associate enum kdoc to these values. v2: use BIT() macro Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 12 ++-- drivers/base/firmware_loader/fallback.h | 6 -- drivers/base/firmware_loader/firmware.h | 18

[PATCH 3/9] firmware: add kernel-doc for enum fw_opt

Some basic definitions for the FW_OPT_* values v2: Documentation corrections from Luis. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/firmware.h | 20 1 file changed, 20 insertions(+) diff --git a/drivers/base/firmware_

[PATCH 3/9] firmware: add kernel-doc for enum fw_opt

Some basic definitions for the FW_OPT_* values v2: Documentation corrections from Luis. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/firmware.h | 20 1 file changed, 20 insertions(+) diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base

[PATCH 8/9] ath10k: use request_firmware_nowarn to load firmware

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Kalle Valo <kv...@codeaurora.org> --- drivers/net/wireless/ath/ath10k/core.c | 2

[PATCH 8/9] ath10k: use request_firmware_nowarn to load firmware

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez Acked-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 0/9] Loading optional firmware v4

everyone that chimed in. I'll be following up with some proposals for the async API. Hopefully we can end up with something that is not "the least bad" option. This series can be found in the for-luis-v4 branch of: https://github.com/lostgoat/linux.git Andres Rodriguez (9): firm

[PATCH 0/9] Loading optional firmware v4

everyone that chimed in. I'll be following up with some proposals for the async API. Hopefully we can end up with something that is not "the least bad" option. This series can be found in the for-luis-v4 branch of: https://github.com/lostgoat/linux.git Andres Rodriguez (9): firm

Re: [PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings

On 2018-04-20 06:26 AM, Kalle Valo wrote: Andres Rodriguez <andre...@gmail.com> writes: This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez <andre...@gmail.com

Re: [PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings

On 2018-04-20 06:26 AM, Kalle Valo wrote: Andres Rodriguez writes: This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/

Re: [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

On 2018-04-17 12:41 PM, Andres Rodriguez wrote: On 2018-04-17 11:52 AM, Christian König wrote: Am 17.04.2018 um 17:41 schrieb Andres Rodriguez: On 2018-04-17 11:33 AM, Christian König wrote: Am 17.04.2018 um 17:07 schrieb Andres Rodriguez: On 2018-04-17 04:48 AM, Christian König

Re: [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

On 2018-04-17 12:41 PM, Andres Rodriguez wrote: On 2018-04-17 11:52 AM, Christian König wrote: Am 17.04.2018 um 17:41 schrieb Andres Rodriguez: On 2018-04-17 11:33 AM, Christian König wrote: Am 17.04.2018 um 17:07 schrieb Andres Rodriguez: On 2018-04-17 04:48 AM, Christian König

Re: [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

On 2018-04-17 11:52 AM, Christian König wrote: Am 17.04.2018 um 17:41 schrieb Andres Rodriguez: On 2018-04-17 11:33 AM, Christian König wrote: Am 17.04.2018 um 17:07 schrieb Andres Rodriguez: On 2018-04-17 04:48 AM, Christian König wrote: Well this is a rather big NAK for this patch

Re: [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

On 2018-04-17 11:52 AM, Christian König wrote: Am 17.04.2018 um 17:41 schrieb Andres Rodriguez: On 2018-04-17 11:33 AM, Christian König wrote: Am 17.04.2018 um 17:07 schrieb Andres Rodriguez: On 2018-04-17 04:48 AM, Christian König wrote: Well this is a rather big NAK for this patch

Re: [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

On 2018-04-17 11:33 AM, Christian König wrote: Am 17.04.2018 um 17:07 schrieb Andres Rodriguez: On 2018-04-17 04:48 AM, Christian König wrote: Well this is a rather big NAK for this patch. Only a small fraction of the firmware files amdgpu uses are actually optional (the ones

Re: [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

On 2018-04-17 11:33 AM, Christian König wrote: Am 17.04.2018 um 17:07 schrieb Andres Rodriguez: On 2018-04-17 04:48 AM, Christian König wrote: Well this is a rather big NAK for this patch. Only a small fraction of the firmware files amdgpu uses are actually optional (the ones

[PATCH 2/9] firmware: wrap FW_OPT_* into an enum

This should let us associate enum kdoc to these values. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/fallback.c | 12 ++-- drivers/base/firmware_loader/fallback.h | 6 -- drivers/base/firmware_loader/firmware.h | 17 + d

[PATCH 2/9] firmware: wrap FW_OPT_* into an enum

This should let us associate enum kdoc to these values. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 12 ++-- drivers/base/firmware_loader/fallback.h | 6 -- drivers/base/firmware_loader/firmware.h | 17 + drivers/base

[PATCH 3/9] firmware: add kernel-doc for enum fw_opt

Some basic definitions for the FW_OPT_* values Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/firmware.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firm

[PATCH 3/9] firmware: add kernel-doc for enum fw_opt

Some basic definitions for the FW_OPT_* values Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/firmware.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h index 957396293b92

[PATCH 0/9] Loading optional firmware v3

This re-spin includes fixes for the kernel-doc style as pointed out by Randy Dunlap. Otherwise it should be functionally identical to the previous iteration. New changes can be found in patches 4 & 5. Andres Rodriguez (9): firmware: some documentation fixes firmware: wrap FW_

[PATCH 0/9] Loading optional firmware v3

This re-spin includes fixes for the kernel-doc style as pointed out by Randy Dunlap. Otherwise it should be functionally identical to the previous iteration. New changes can be found in patches 4 & 5. Andres Rodriguez (9): firmware: some documentation fixes firmware: wrap FW_

[PATCH 4/9] firmware: use () to terminate kernel-doc function names

The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/fallback.c | 8 drivers/base/firmware_loader/main.c | 22 +++--- 2 files changed, 15 insertions(+), 15 deletions(-)

[PATCH 4/9] firmware: use () to terminate kernel-doc function names

The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 8 drivers/base/firmware_loader/main.c | 22 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/base

[PATCH 5/9] firmware: add functions to load firmware without warnings v4

kernel-doc style [0]: https://git.kernel.org/linus/c0cc00f250e1 Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- .../driver-api/firmware/request_firmware.rst | 13 -- drivers/base/firmware_loader/main.c| 52 -- include/linux/firm

[PATCH 5/9] firmware: add functions to load firmware without warnings v4

kernel-doc style [0]: https://git.kernel.org/linus/c0cc00f250e1 Signed-off-by: Andres Rodriguez --- .../driver-api/firmware/request_firmware.rst | 13 -- drivers/base/firmware_loader/main.c| 52 -- include/linux/firmware.h

[PATCH 7/9] drm/amdgpu: use firmware_request_nowarn to load firmware

. This patch switches the amdgpu to use firmware_request_nowarn(), which will not produce the warnings mentioned above. Hopefully resulting in a cleaner bootup log. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 2 +- drivers/gpu/drm/amd/

[PATCH 7/9] drm/amdgpu: use firmware_request_nowarn to load firmware

. This patch switches the amdgpu to use firmware_request_nowarn(), which will not produce the warnings mentioned above. Hopefully resulting in a cleaner bootup log. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4

[PATCH 1/9] firmware: some documentation fixes

Including: - Fixup outdated kernel-doc paths - Slightly too short title underline - Some typos Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- Documentation/driver-api/firmware/request_firmware.rst | 16 drivers/base/firmware_loader/fallback.c

[PATCH 1/9] firmware: some documentation fixes

Including: - Fixup outdated kernel-doc paths - Slightly too short title underline - Some typos Signed-off-by: Andres Rodriguez --- Documentation/driver-api/firmware/request_firmware.rst | 16 drivers/base/firmware_loader/fallback.c| 4 ++-- drivers/base

[PATCH 8/9] ath10k: use request_firmware_nowarn to load firmware

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 8/9] ath10k: use request_firmware_nowarn to load firmware

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wi

[PATCH 6/9] firmware: print firmware name on fallback path

mware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c

[PATCH 6/9] firmware: print firmware name on fallback path

mware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/

[PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 7 --- 1 file changed, 4

[PATCH 9/9] brcmfmac: use request_firmware_nowait2 to load firmware without warnings

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

her the firmware load succeed or not. These are my 2c in the matter. Regards, Andres Regards, Christian. Am 17.04.2018 um 00:24 schrieb Andres Rodriguez: Currently, during the normal boot process the amdgpu driver will produce spew like the following in dmesg: Direct firmware load for amdgpu/polaris10_

Re: [PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

her the firmware load succeed or not. These are my 2c in the matter. Regards, Andres Regards, Christian. Am 17.04.2018 um 00:24 schrieb Andres Rodriguez: Currently, during the normal boot process the amdgpu driver will produce spew like the following in dmesg: Direct firmware load for amdgpu/polaris10_

[PATCH 1/8] firmware: some documentation fixes

Including: - Fixup outdated kernel-doc paths - Slightly too short title underline - Some typos Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- Documentation/driver-api/firmware/request_firmware.rst | 16 drivers/base/firmware_loader/fallback.c

[PATCH 1/8] firmware: some documentation fixes

Including: - Fixup outdated kernel-doc paths - Slightly too short title underline - Some typos Signed-off-by: Andres Rodriguez --- Documentation/driver-api/firmware/request_firmware.rst | 16 drivers/base/firmware_loader/fallback.c| 4 ++-- drivers/base

[PATCH 5/8] firmware: print firmware name on fallback path

mware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c

[PATCH 4/8] firmware: add functions to load firmware without warnings v3

]: https://git.kernel.org/linus/c0cc00f250e1 Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- .../driver-api/firmware/request_firmware.rst | 13 -- drivers/base/firmware_loader/main.c| 52 -- include/linux/firmware.h

[PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

. This patch switches the amdgpu to use firmware_request_nowarn(), which will not produce the warnings mentioned above. Hopefully resulting in a cleaner bootup log. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 2 +- drivers/gpu/drm/amd/

[PATCH 5/8] firmware: print firmware name on fallback path

mware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/

[PATCH 4/8] firmware: add functions to load firmware without warnings v3

]: https://git.kernel.org/linus/c0cc00f250e1 Signed-off-by: Andres Rodriguez --- .../driver-api/firmware/request_firmware.rst | 13 -- drivers/base/firmware_loader/main.c| 52 -- include/linux/firmware.h | 6 +++ 3 files changed

[PATCH 6/8] drm/amdgpu: use firmware_request_nowarn to load firmware

. This patch switches the amdgpu to use firmware_request_nowarn(), which will not produce the warnings mentioned above. Hopefully resulting in a cleaner bootup log. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4

[PATCH 8/8] brcmfmac: use request_firmware_nowait2 to load firmware without warnings

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 7 --- 1 file changed, 4

[PATCH 3/8] firmware: add kernel-doc for enum fw_opt

Some basic definitions for the FW_OPT_* values Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/firmware.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firm

[PATCH 8/8] brcmfmac: use request_firmware_nowait2 to load firmware without warnings

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH 3/8] firmware: add kernel-doc for enum fw_opt

Some basic definitions for the FW_OPT_* values Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/firmware.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h index 957396293b92

[PATCH 7/8] ath10k: use request_firmware_nowarn to load firmware

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 7/8] ath10k: use request_firmware_nowarn to load firmware

This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wi

[PATCH 0/8] Loading optional firmware v2

included patches for the following consumer drivers: - amdgpu - ath10k - brcmfmac Thanks again for your feedback. Regards, Andres Andres Rodriguez (8): firmware: some documentation fixes firmware: wrap FW_OPT_* into an enum firmware: add kernel-doc for enum fw_opt firmware: add

[PATCH 2/8] firmware: wrap FW_OPT_* into an enum

This should let us associate enum kdoc to these values. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_loader/fallback.c | 12 ++-- drivers/base/firmware_loader/fallback.h | 6 -- drivers/base/firmware_loader/firmware.h | 17 + d

[PATCH 0/8] Loading optional firmware v2

included patches for the following consumer drivers: - amdgpu - ath10k - brcmfmac Thanks again for your feedback. Regards, Andres Andres Rodriguez (8): firmware: some documentation fixes firmware: wrap FW_OPT_* into an enum firmware: add kernel-doc for enum fw_opt firmware: add

[PATCH 2/8] firmware: wrap FW_OPT_* into an enum

This should let us associate enum kdoc to these values. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 12 ++-- drivers/base/firmware_loader/fallback.h | 6 -- drivers/base/firmware_loader/firmware.h | 17 + drivers/base

Re: [PATCH] firmware: add a function to load optional firmware v2

On 2018-03-13 12:38 PM, Luis R. Rodriguez wrote: On Tue, Mar 13, 2018 at 03:39:23PM +0200, Kalle Valo wrote: "Luis R. Rodriguez" <mcg...@kernel.org> writes: On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: On 3/11/2018 5:05 PM, Andres Rodriguez wrote: Y

Re: [PATCH] firmware: add a function to load optional firmware v2

On 2018-03-13 12:38 PM, Luis R. Rodriguez wrote: On Tue, Mar 13, 2018 at 03:39:23PM +0200, Kalle Valo wrote: "Luis R. Rodriguez" writes: On Mon, Mar 12, 2018 at 12:10:47AM +0100, Arend van Spriel wrote: On 3/11/2018 5:05 PM, Andres Rodriguez wrote: Your patch series then should

Re: [PATCH] firmware: add a function to load optional firmware v2

Hi Luis, Thanks for all your feedback, greatly appreciated. On 2018-03-10 09:40 AM, Luis R. Rodriguez wrote: On Sat, Mar 10, 2018 at 6:35 AM, Luis R. Rodriguez wrote: You also I take it have users in mind? I'd like to see at least one user of the API or this fixing a

Re: [PATCH] firmware: add a function to load optional firmware v2

Hi Luis, Thanks for all your feedback, greatly appreciated. On 2018-03-10 09:40 AM, Luis R. Rodriguez wrote: On Sat, Mar 10, 2018 at 6:35 AM, Luis R. Rodriguez wrote: You also I take it have users in mind? I'd like to see at least one user of the API or this fixing a reported issue. Ie, if

[PATCH] firmware: add a function to load optional firmware v2

will not produce error/warning messages if the firmware file is not found, but will still attempt to query the usermodehelper for the optional firmware. Effectively, FW_OPT_UEVENT | FW_OPT_FALLBACK | FW_OPT_NO_WARN. v2: add header prototype, use updated opt_flags Signed-off-by: Andres Rodriguez <an

[PATCH] firmware: add a function to load optional firmware v2

will not produce error/warning messages if the firmware file is not found, but will still attempt to query the usermodehelper for the optional firmware. Effectively, FW_OPT_UEVENT | FW_OPT_FALLBACK | FW_OPT_NO_WARN. v2: add header prototype, use updated opt_flags Signed-off-by: Andres Rodriguez

[RFC 0/1] Loading optional firmware

a different strategy to tackle this issue. Andres Rodriguez (1): firmware: add a function to load optional firmware drivers/base/firmware_class.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) -- 2.14.1

[RFC 0/1] Loading optional firmware

a different strategy to tackle this issue. Andres Rodriguez (1): firmware: add a function to load optional firmware drivers/base/firmware_class.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) -- 2.14.1

[PATCH 1/1] firmware: add a function to load optional firmware

will not produce error/warning messages if the firmware file is not found, but will still attempt to query the usermodehelper for the optional firmware. Effectively, FW_OPT_UEVENT | FW_OPT_FALLBACK | FW_OPT_NO_WARN. Signed-off-by: Andres Rodriguez <andre...@gmail.com> --- drivers/base/firmware_c

[PATCH 1/1] firmware: add a function to load optional firmware

will not produce error/warning messages if the firmware file is not found, but will still attempt to query the usermodehelper for the optional firmware. Effectively, FW_OPT_UEVENT | FW_OPT_FALLBACK | FW_OPT_NO_WARN. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_class.c | 27