On 26/3/21 10:53 pm, dingsen...@163.com wrote:
From: dingsenjie
Remove unneeded variable: "rc".
Signed-off-by: dingsenjie
This looks obviously correct and doesn't raise any checkpatch warnings.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, AD
On 22/3/21 1:33 pm, Bhaskar Chowdhury wrote:
s/filesytem/filesystem/
s/symantics/semantics/
Signed-off-by: Bhaskar Chowdhury
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/context.c b
On 11/3/21 4:44 am, Laurent Dufour wrote:
It is better to rely on the API provided by the MM layer instead of
directly manipulating the mm_users field.
Signed-off-by: Laurent Dufour
LGTM, thanks for picking this up
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL
quot; the changlog on that commit,
which included the full ID. Obviously, counting to 12 is a challenging
task for a slow guy like me...:)
No, no, my local tree tells me that *I* made that tag by hand and failed
to count properly... sorry for the noise!
--
Andrew Donnellan
On 29/1/21 7:25 pm, Yang Li wrote:
Fix the following coccicheck warning:
./drivers/misc/cxl/sysfs.c:181:48-53: WARNING: conversion to bool not
needed here
Reported-by: Abaci Robot
Signed-off-by: Yang Li
Reviewed-by: Andrew Donnellan
Thanks!
---
drivers/misc/cxl/sysfs.c | 2 +-
1 file
uot;).
Thanks for picking this up.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 25/12/20 12:24 am, Zheng Yongjun wrote:
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Signed-off-by: Zheng Yongjun
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com
On 30/11/20 1:45 pm, Andrew Donnellan wrote:
LCA2021 Kernel Miniconf - Online - 2021-01-23
-
LCA Kernel Miniconf submissions now open! (Ever wanted to present at
LCA, but couldn't justify flying to Australia? Well, 2021 is your chance
- we're going
tching this!
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 30/11/20 2:46 pm, Andrew Donnellan wrote:
On 30/11/20 2:38 pm, CRISTIAN ANDRES VARGAS GONZALEZ wrote:
> More info: https://lca-kernel.ozlabs.org/2021-cfs.html
<https://lca-kernel.ozlabs.org/2021-cfs.html>
Hi, this link no working. :c
Ugh, let me fix my TLS setup. In the mean
ttp://lca-kernel.ozlabs.org/2021-cfs.html
Thanks for reporting!
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
of experience in the kernel community, covering a broad range of
topics. The focus of the miniconf will primarily be on Linux, however
non-Linux talks of sufficient interest to a primarily Linux audience
will be considered.
--
Andrew Donnellan OzLabs, ADL Canberra
ion compared with zero: win < 0
Reported-by: Tosk Robot
Signed-off-by: Kaixu Xia
This seems like the right fix, the value assigned to win can indeed be
-1 so it should be signed. Thanks for sending the patch.
Reviewed-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/pci-sriov
in 'get_function_0'
Cc: Frederic Barrat
Cc: Andrew Donnellan
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Lee Jones
Thanks!
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia
On 21/9/20 11:10 pm, Qinglang Miao wrote:
Simplify the return expression.
Signed-off-by: Qinglang Miao
Looks good
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
Thanks.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
]
178 | __be32 *data, drc_index, phandle;
| ^
Cc: Frederic Barrat
Cc: Andrew Donnellan
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Lee Jones
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
]
178 | __be32 *data, drc_index, phandle;
| ^
Cc: Frederic Barrat
Cc: Andrew Donnellan
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Lee Jones
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 3/6/20 9:57 pm, wanghai (M) wrote:
kfree(cr) can be called when
kobject_put()-->kobject_release()-->kobject_cleanup()-->kobj_type->release()
is called. The kobj_type here is afu_config_record_type
Of course, I missed that.
In that case
Acked-by: Andrew Donnellan
Thanks
o it falls through?
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 18/10/19 5:46 pm, Christophe Leroy wrote:
Le 17/10/2019 à 09:36, Andrew Donnellan a écrit :
On 10/9/19 7:16 pm, Christophe Leroy wrote:
+#if defined(CONFIG_VMAP_STACK) && CONFIG_THREAD_SHIFT < PAGE_SHIFT
+#define THREAD_SHIFT PAGE_SHIFT
+#else
#define T
Looking at 64-bit book3s: with 64K pages, this results in a THREAD_SIZE
that's too large for immediate mode arithmetic operations, which is
annoying. Hmm.
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
/2020-cfs.html **
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 17/9/19 3:42 am, Alastair D'Silva wrote:
From: Alastair D'Silva
Add OPAL calls for LPC memory alloc/release
Signed-off-by: Alastair D'Silva
This needs rebasing, but apart from that.
Acked-by: Andrew Donnellan
---
arch/powerpc/include/asm/opal-api.h| 4 +++-
arch/powerpc
++ style should be used)
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches
Signed-off-by: Nishad Kamdar
Thanks.
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/ocxl_internal.h | 2 +-
drivers/misc/ocxl/trace.h
On 28/6/19 10:30 pm, Mauro Carvalho Chehab wrote:
The content of this file is user-faced.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Andrew Donnellan
---
Documentation/{ => userspace-api}/accelerators/ocxl.rst | 2 --
Documentation/userspace-api/index.rst
mm_context_remove_copro(pe_data->mm);
+ mmdrop(pe_data->mm);
+ }
kfree_rcu(pe_data, rcu);
}
unlock:
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
);
- mmdrop(pe_data->mm);
+ if (pe_data->mm) {
+ mm_context_remove_copro(pe_data->mm);
+ mmdrop(pe_data->mm);
+ }
kfree_rcu(pe_data, rcu);
}
unlock:
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
/1083801/
If you choose to proceed with this patch:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
rc = ocxl_link_setup(dev, 0, >link);
- if (rc)
- return rc;
-
- rc = ocxl_config_set_TL(dev, fn->config.dvsec_tl_pos);
- if (rc) {
- ocxl_link_release(dev, fn->link);
- return rc;
- }
- return 0;
-}
-
-static void deconfigure_function(struct ocxl_fn *fn)
-{
- struct pci_dev *dev = to_pci_dev(fn->dev.parent);
-
- ocxl_link_release(dev, fn->link);
- pci_disable_device(dev);
-}
-
-static struct ocxl_fn *init_function(struct pci_dev *dev)
-{
- struct ocxl_fn *fn;
- int rc;
-
- fn = alloc_function(dev);
- if (!fn)
- return ERR_PTR(-ENOMEM);
-
- rc = configure_function(fn, dev);
- if (rc) {
- free_function(fn);
- return ERR_PTR(rc);
- }
-
- rc = device_register(>dev);
- if (rc) {
- deconfigure_function(fn);
- put_device(>dev);
- return ERR_PTR(rc);
- }
- return fn;
-}
-
-static void remove_function(struct ocxl_fn *fn)
-{
- deconfigure_function(fn);
- device_unregister(>dev);
-}
-
static int ocxl_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
int rc, afu_count = 0;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
Acked-by: Andrew Donnellan
arch/powerpc/include/asm/pnv-ocxl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/pnv-ocxl.h
b/arch/powerpc/include/asm/pnv-ocxl.h
index 208b5503f4ed..7de82647e761 100644
--- a/arch/powerpc/include/asm/pnv-ocxl.h
+++ b
On 15/3/19 3:49 pm, Andrew Donnellan wrote:
On 13/3/19 3:07 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
Remove some unused exported symbols.
Signed-off-by: Alastair D'Silva
See comments on v1
Also a couple of sparse warnings at
https://openpower.xyz/job/snowpatch/job/snowpatch
ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid);
-
/*
* Remove a Process Element from the Shared Process Area for a link
*/
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
tid);
+
This isn't actually exported, so if you spin a v2 do that separately
from this patch or document the change.
Otherwise
Acked-by: Andrew Donnellan
struct ocxl_context *ocxl_context_alloc(void);
int ocxl_context_init(struct ocxl_context *ctx, struct ocxl_afu *
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
The 'extern' keyword adds no value here.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/ocxl_internal.h | 54 +++
include/misc/ocxl.h | 36
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
No need for a return value in read_pasid as it only returns 0.
Signed-off-by: Alastair D'Silva
Reviewed-by: Greg Kurz
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/config.c | 9 ++---
1 file changed, 2
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
Use %# instead of using a literal '0x'
Signed-off-by: Alastair D'Silva
Not hugely fussed either way, but today I learned about %#...
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/config.c | 6 +++---
drivers
On 27/2/19 7:04 pm, Alastair D'Silva wrote:
-Original Message-
From: Andrew Donnellan
Sent: Wednesday, 27 February 2019 6:55 PM
To: Alastair D'Silva ; 'Alastair D'Silva'
Cc: 'Greg Kurz' ; 'Frederic Barrat'
; 'Arnd Bergmann' ; 'Greg Kroah-
Hartman' ; linuxppc-...@lists.ozlabs.org;
linux
date the function signature for ocxl_link_update_pe()
as well.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
link *link = (struct link *) link_handle;
+ struct ocxl_link *link = (struct ocxl_link *) link_handle;
pnv_ocxl_free_xive_irq(hw_irq);
atomic_inc(>irq_available);
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
protocol respectively - many of which will be FPGA boards
flashed with customer-designed accelerator cores for specific workloads,
some will be accelerators using ASICs or using FPGA images supplied by
vendors, some will be driven from userspace, others using the cxl/ocxl
kernel API, etc.
--
Andrew
-accelerat...@lists.ozlabs.org but we
haven't really started using...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ll you what this is all about, explain how to install the
kernel, and what to do if something goes wrong.
@@ -406,3 +406,4 @@ If something goes wrong
gdb'ing a non-running kernel currently fails because ``gdb`` (wrongly)
disregards the starting offset for which the kernel is compiled.
+
On 21/10/18 12:10 pm, Andrew Donnellan wrote:
The linux.conf.au Kernel Miniconf is happening once again, this time in
Christchurch on 22 Jan 2019.
*** Submissions close on 2018-12-16, 23:59 AoE, with early submissions
(before 2018-11-16, 23:59 AoE) given priority. ***
This deadline
-cfp.html for full details and the
submission form.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
-cfp.html for full details and the
submission form.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 4/10/18 3:02 pm, zhong jiang wrote:
It is not safe to dereference an object before a null test. It is
not needed and just remove them. Ftrace can be used instead.
Signed-off-by: zhong jiang
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/guest.c | 2 --
1 file changed, 2 deletions
On 4/10/18 3:02 pm, zhong jiang wrote:
It is not safe to dereference an object before a null test. It is
not needed and just remove them. Ftrace can be used instead.
Signed-off-by: zhong jiang
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/guest.c | 2 --
1 file changed, 2 deletions
On 26/9/18 9:41 pm, zhong jiang wrote:
It is safe to move a deference below a NULL test.
Signed-off-by: zhong jiang
Thanks for catching this.
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/guest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc
On 26/9/18 9:41 pm, zhong jiang wrote:
It is safe to move a deference below a NULL test.
Signed-off-by: zhong jiang
Thanks for catching this.
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/guest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc
architectures, compat_ptr()
does not do anything, but using the new generic_compat_ioctl_ptrarg
helper makes it more correct in theory, and simplifies the code.
Signed-off-by: Arnd Bergmann
For cxl:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1
architectures, compat_ptr()
does not do anything, but using the new generic_compat_ioctl_ptrarg
helper makes it more correct in theory, and simplifies the code.
Signed-off-by: Arnd Bergmann
For cxl:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1
got some spare time over the
next few days and send a v2.
Thanks,
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
got some spare time over the
next few days and send a v2.
Thanks,
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
Signed-off-by: Andrew Donnellan
---
RFC because I'm bad at Perl
---
scripts/checkpatch.pl | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index aca4d758112a..ae7a54287db7 100755
--- a/scripts
the value of the 'copros' counter of the memory context.
===
checkpatch will return a GIT_COMMIT_ID error even though the reference
actually follows the correct format.
Fix the GIT_COMMIT_ID test so it can match against a reference that spans 3
lines.
Reported-by: Frederic Barrat
Signed-off-
Signed-off-by: Andrew Donnellan
---
RFC because I'm bad at Perl
---
scripts/checkpatch.pl | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index aca4d758112a..ae7a54287db7 100755
--- a/scripts
the value of the 'copros' counter of the memory context.
===
checkpatch will return a GIT_COMMIT_ID error even though the reference
actually follows the correct format.
Fix the GIT_COMMIT_ID test so it can match against a reference that spans 3
lines.
Reported-by: Frederic Barrat
Signed-off-
On 03/08/18 20:20, Parth Y Shah wrote:
Resolved <"foo* bar" should be "foo *bar"> error
Signed-off-by: Parth Y Shah
Thanks for picking this up.
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
On 03/08/18 20:20, Parth Y Shah wrote:
Resolved <"foo* bar" should be "foo *bar"> error
Signed-off-by: Parth Y Shah
Thanks for picking this up.
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
On 11/05/18 16:12, Alastair D'Silva wrote:
From: Alastair D'Silva
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
On 11/05/18 16:12, Alastair D'Silva wrote:
From: Alastair D'Silva
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
. Alastair has also confirmed with me that truncating the pid to a u16
should be safe, so therefore:
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
. Alastair has also confirmed with me that truncating the pid to a u16
should be safe, so therefore:
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ed-off-by: Alastair D'Silva <alast...@d-silva.org>
nitpicks below
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
drivers/misc/ocxl/context.c | 5 +++-
drivers/misc/ocxl/file.c | 53 +++
drivers/misc/ocxl/li
nitpicks below
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/context.c | 5 +++-
drivers/misc/ocxl/file.c | 53 +++
drivers/misc/ocxl/link.c | 36 ++
drivers/misc/ocxl/ocxl_internal.h | 1 +
include
task_pid_nr(t);
mtspr(SPRN_TIDR, t->thread.tidr);
return 0;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
read_tidr(struct task_struct *t)
if (t->thread.tidr)
return 0;
- rc = assign_thread_tidr();
- if (rc < 0)
- return rc;
-
- t->thread.tidr = rc;
+ t->thread.tidr = (u16)task_pid_nr(t);
mtspr(SPRN_TIDR, t->thread.
silva.org>
Looks good to me
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Documentation/accelerators/ocxl.rst | 1 -
drivers/misc/ocxl/file.c| 25 +
include/uapi/misc/ocxl.h| 4
3 files changed, 29 insertions(+), 1
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
In order for a userspace AFU driver to call the Power9 specific
OCXL_IOCTL_ENABLE_P9_WAIT, it needs to verify that it can actually
make that call.
Signed-off-by: Alastair D'Silva
Looks good to me
Acked-by: Andrew Donnellan
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva <alast...@d-silva.org>
Signed-off-by: Alastair D'Silva <alast...@d-silva.org>
This looks better.
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Documentation/accelerators/ocxl.rst | 11 ++
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
Signed-off-by: Alastair D'Silva
This looks better.
Acked-by: Andrew Donnellan
---
Documentation/accelerators/ocxl.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/accelerators/ocxl.rst
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva <alast...@d-silva.org>
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva <alast...@d-silva.org>
Reviewed-by: Andrew Donnellan &l
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
my previous email:
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
This patch adds a CPU feature bit to show whether the CPU has
the TIDR register available, enabling as_notify/wait in userspace.
Signed-off-by: Alastair D'Silva
Per my previous email:
Reviewed-by: Andrew Donnellan
.li...@gmail.com>
This looks good to me
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
is looks good to me
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
apper around the OPAL call of a similar name.
But I don't feel strongly about this at all, so:
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
don't feel strongly about this at all, so:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
CPU_FTR_P9_TIDR))
return -EINVAL;
if (t != current)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
(t != current)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
features code but
nothing seems overly wrong...
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
features code but
nothing seems overly wrong...
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
you're just passing flags which I
suppose imply what the correct platform is, but really they're just
feature flags?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
the correct platform is, but really they're just
feature flags?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 12/03/18 22:36, Arvind Yadav wrote:
if device_register() returned an error! Always use put_device()
to give up the reference initialized.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
This looks right, thanks for picking it up.
Acked-by: Andrew Donnellan <andrew.donn
On 12/03/18 22:36, Arvind Yadav wrote:
if device_register() returned an error! Always use put_device()
to give up the reference initialized.
Signed-off-by: Arvind Yadav
This looks right, thanks for picking it up.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL
On 22/02/18 15:17, Alastair D'Silva wrote:
From: Alastair D'Silva <alast...@d-silva.org>
Signed-off-by: Alastair D'Silva <alast...@d-silva.org>
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel..
On 22/02/18 15:17, Alastair D'Silva wrote:
From: Alastair D'Silva
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
arsing effort in
userspace.
Signed-off-by: Alastair D'Silva <alast...@d-silva.org>
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 17/02/18 05:38, Masahiro Yamada wrote:
For PowerPC, GCC 5.2 is the requirement for GCC plugins. Move the
version check to Kconfig, and remove the ugly checker.
Signed-off-by: Masahiro Yamada
The old checker was as non-ugly as I could make it. :)
Acked-by: Andrew Donnellan
--
Andrew
.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
arsing effort in
userspace.
Signed-off-by: Alastair D'Silva <alast...@d-silva.org>
Seems fine.
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
Signed-off-by: Alastair D'Silva
Seems fine.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
xpression
compared with zero: used < 0
Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Thanks for picking this up!
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
driver
< 0
Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
Signed-off-by: Colin Ian King
Thanks for picking this up!
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mi
1 - 100 of 272 matches
Mail list logo
