de Goede
> Tested-by: Hans de Goede
Reviewed-by: Andrew Duggan
> ---
> drivers/input/rmi4/Kconfig | 8 ++
> drivers/input/rmi4/Makefile | 1 +
> drivers/input/rmi4/rmi_bus.c| 3 +
> drivers/input/rmi4/rmi_driver.h | 1 +
>
-by: Hans de Goede
Reviewed-by: Andrew Duggan
> ---
> drivers/hid/hid-rmi.c | 2 +-
> drivers/input/mouse/synaptics.c | 2 +-
> drivers/input/rmi4/rmi_f30.c| 14 +++---
> include/linux/rmi.h | 11 ++-
> 4 files changed, 15 insertions
driver will not dereference a NULL pointer.
Signed-off-by: Andrew Duggan
---
drivers/input/rmi4/rmi_bus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
index af706a583656..6c3abae1e159 100644
--- a/drivers/input
.
The kernel oops was reported in this message:
https://www.spinics.net/lists/linux-input/msg58433.html
Signed-off-by: Andrew Duggan
Reported-by: Federico Cerutti
---
drivers/hid/hid-rmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid
the IRQ was removed when the driver switched to using
an irq domain. Setting the fn_irq_bits and using them instead of
current_irq_mask in rmi_process_interrupt_requests() makes sense to me.
Andrew
> Signed-off-by: Evan Green
Reviewed-by: Andrew Duggan
> ---
>
> drivers/input/r
, that definitely looks like an oversight on my part. Thanks for the fix.
Andrew
Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
Reviewed-by: Andrew Duggan <adug...@synaptics.com>
---
drivers/input/rmi4/rmi_spi.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
, that definitely looks like an oversight on my part. Thanks for the fix.
Andrew
Signed-off-by: Christophe JAILLET
Reviewed-by: Andrew Duggan
---
drivers/input/rmi4/rmi_spi.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4
The Fujitsu R726 Pad has an optional USB keyboard dock which contains
a Synaptics touchpad. The dock identifies itself as a
Primax Rezel Tablet Keyboard.
Signed-off-by: Andrew Duggan <adug...@synaptics.com>
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid
The Fujitsu R726 Pad has an optional USB keyboard dock which contains
a Synaptics touchpad. The dock identifies itself as a
Primax Rezel Tablet Keyboard.
Signed-off-by: Andrew Duggan
---
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-rmi.c | 1 +
3 files changed, 3
in rmi_f30_is_valid_button() but should not be considered
buttons. This patch limits the GPIOs which are mapped to buttons to just
the first 6.
Signed-off-by: Andrew Duggan <adug...@synaptics.com>
Reported-by: Daniel Martin <consume.no...@gmail.com>
---
I think that this patch will fix the issue with t
in rmi_f30_is_valid_button() but should not be considered
buttons. This patch limits the GPIOs which are mapped to buttons to just
the first 6.
Signed-off-by: Andrew Duggan
Reported-by: Daniel Martin
---
I think that this patch will fix the issue with the Lenovo X1 Cover not
being set as a buttonpad. Based
have this check, but
this patch adds checks to the remaining callbacks.
Signed-off-by: Andrew Duggan <adug...@synaptics.com>
---
This is the patch which hopefully will address the X1 tablet dock freeze:
http://www.spinics.net/lists/linux-input/msg53582.html
I was not able to test on a com
have this check, but
this patch adds checks to the remaining callbacks.
Signed-off-by: Andrew Duggan
---
This is the patch which hopefully will address the X1 tablet dock freeze:
http://www.spinics.net/lists/linux-input/msg53582.html
I was not able to test on a composite USB device so I have
The hid-rmi driver may handle non rmi devices on composite USB devices.
Callbacks need to make sure that the current device is a RMI device before
calling RMI specific functions. Most callbacks already have this check, but
this patch adds checks to the remaining callbacks.
Signed-off-by: Andrew
The hid-rmi driver may handle non rmi devices on composite USB devices.
Callbacks need to make sure that the current device is a RMI device before
calling RMI specific functions. Most callbacks already have this check, but
this patch adds checks to the remaining callbacks.
Signed-off-by: Andrew
, but it
is unclear how much of an issue kernel jumps actually are. This patch
simply disabled kernel tracking for now.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1482640
Signed-off-by: Andrew Duggan <adug...@synaptics.com>
Tested-by: Kamil Páral <kpa...@redhat.com>
---
drivers/input/mouse/syn
, but it
is unclear how much of an issue kernel jumps actually are. This patch
simply disabled kernel tracking for now.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1482640
Signed-off-by: Andrew Duggan
Tested-by: Kamil Páral
---
drivers/input/mouse/synaptics.c | 3 +--
1 file changed, 1 insertion(+), 2
anity of the incoming report")
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195949
Signed-off-by: Andrew Duggan <adug...@synaptics.com>
---
Also, in addition to changing the size of the read I moved the query
buffer. I figured that since the query buffer is only acceessed in the
rmi_f54
anity of the incoming report")
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195949
Signed-off-by: Andrew Duggan
---
Also, in addition to changing the size of the read I moved the query
buffer. I figured that since the query buffer is only acceessed in the
rmi_f54_detect function it was not nece
On 04/10/2017 11:38 AM, Dmitry Torokhov wrote:
On Mon, Apr 10, 2017 at 03:18:03PM +0200, Jiri Kosina wrote:
[ a couple more people from "the other regression thread" added to CC ]
On Mon, 10 Apr 2017, Gabriele Mazzotta wrote:
Hi,
I'm having troubles with hid-rmi using 4.11-rc6. I'm getting
On 04/10/2017 11:38 AM, Dmitry Torokhov wrote:
On Mon, Apr 10, 2017 at 03:18:03PM +0200, Jiri Kosina wrote:
[ a couple more people from "the other regression thread" added to CC ]
On Mon, 10 Apr 2017, Gabriele Mazzotta wrote:
Hi,
I'm having troubles with hid-rmi using 4.11-rc6. I'm getting
On 03/31/2017 01:57 AM, Benjamin Tissoires wrote:
On Mar 29 2017 or thereabouts, Andrew Duggan wrote:
On 03/29/2017 01:50 AM, Benjamin Tissoires wrote:
On Mar 28 2017 or thereabouts, Andrew Duggan wrote:
On 03/19/2017 10:00 PM, Peter Hutterer wrote:
On Fri, Mar 17, 2017 at 12:23:36PM -0700
On 03/31/2017 01:57 AM, Benjamin Tissoires wrote:
On Mar 29 2017 or thereabouts, Andrew Duggan wrote:
On 03/29/2017 01:50 AM, Benjamin Tissoires wrote:
On Mar 28 2017 or thereabouts, Andrew Duggan wrote:
On 03/19/2017 10:00 PM, Peter Hutterer wrote:
On Fri, Mar 17, 2017 at 12:23:36PM -0700
On 03/29/2017 01:50 AM, Benjamin Tissoires wrote:
On Mar 28 2017 or thereabouts, Andrew Duggan wrote:
On 03/19/2017 10:00 PM, Peter Hutterer wrote:
On Fri, Mar 17, 2017 at 12:23:36PM -0700, Andrew Duggan wrote:
On 03/17/2017 09:57 AM, Benjamin Tissoires wrote:
On Wed, Mar 15, 2017 at 2:19
On 03/29/2017 01:50 AM, Benjamin Tissoires wrote:
On Mar 28 2017 or thereabouts, Andrew Duggan wrote:
On 03/19/2017 10:00 PM, Peter Hutterer wrote:
On Fri, Mar 17, 2017 at 12:23:36PM -0700, Andrew Duggan wrote:
On 03/17/2017 09:57 AM, Benjamin Tissoires wrote:
On Wed, Mar 15, 2017 at 2:19
On 03/19/2017 10:00 PM, Peter Hutterer wrote:
On Fri, Mar 17, 2017 at 12:23:36PM -0700, Andrew Duggan wrote:
On 03/17/2017 09:57 AM, Benjamin Tissoires wrote:
On Wed, Mar 15, 2017 at 2:19 AM, Andrew Duggan <adug...@synaptics.com> wrote:
On 03/13/2017 10:10 PM, Cameron Gutman wrote:
On
On 03/19/2017 10:00 PM, Peter Hutterer wrote:
On Fri, Mar 17, 2017 at 12:23:36PM -0700, Andrew Duggan wrote:
On 03/17/2017 09:57 AM, Benjamin Tissoires wrote:
On Wed, Mar 15, 2017 at 2:19 AM, Andrew Duggan wrote:
On 03/13/2017 10:10 PM, Cameron Gutman wrote:
On 03/13/2017 06:35 PM, Andrew
On 03/17/2017 09:57 AM, Benjamin Tissoires wrote:
On Wed, Mar 15, 2017 at 2:19 AM, Andrew Duggan <adug...@synaptics.com> wrote:
On 03/13/2017 10:10 PM, Cameron Gutman wrote:
On 03/13/2017 06:35 PM, Andrew Duggan wrote:
On 03/13/2017 06:15 AM, Benjamin Tissoires wrote:
[Resending,
On 03/17/2017 09:57 AM, Benjamin Tissoires wrote:
On Wed, Mar 15, 2017 at 2:19 AM, Andrew Duggan wrote:
On 03/13/2017 10:10 PM, Cameron Gutman wrote:
On 03/13/2017 06:35 PM, Andrew Duggan wrote:
On 03/13/2017 06:15 AM, Benjamin Tissoires wrote:
[Resending, forgot to add Jiri in CC
On 03/16/2017 05:04 PM, Dmitry Torokhov wrote:
On Thu, Mar 16, 2017 at 04:56:31PM -0700, Andrew Duggan wrote:
When the firmware identifies a contact as a palm the driver sets the tool
type to MT_TOOL_PALM, but sets the slot state as active. Reporting the
palm as active results in userspace
On 03/16/2017 05:04 PM, Dmitry Torokhov wrote:
On Thu, Mar 16, 2017 at 04:56:31PM -0700, Andrew Duggan wrote:
When the firmware identifies a contact as a palm the driver sets the tool
type to MT_TOOL_PALM, but sets the slot state as active. Reporting the
palm as active results in userspace
not suppressing palms when switching to the RMI4 driver. This
change fixes palm rejection when using the RMI4 driver.
Signed-off-by: Andrew Duggan <adug...@synaptics.com>
Tested-by: Cameron Gutman <aicomman...@gmail.com>
---
drivers/input/rmi4/rmi_2d_sensor.c | 3 ++-
1 file changed,
not suppressing palms when switching to the RMI4 driver. This
change fixes palm rejection when using the RMI4 driver.
Signed-off-by: Andrew Duggan
Tested-by: Cameron Gutman
---
drivers/input/rmi4/rmi_2d_sensor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input
On 03/13/2017 10:10 PM, Cameron Gutman wrote:
On 03/13/2017 06:35 PM, Andrew Duggan wrote:
On 03/13/2017 06:15 AM, Benjamin Tissoires wrote:
[Resending, forgot to add Jiri in CC]
On Mar 13 2017 or thereabouts, Benjamin Tissoires wrote:
On Mar 13 2017 or thereabouts, Thorsten Leemhuis wrote
On 03/14/2017 01:14 AM, Thorsten Leemhuis wrote:
Lo! On 14.03.2017 06:10, Cameron Gutman wrote:
On 03/13/2017 06:35 PM, Andrew Duggan wrote:
On 03/13/2017 06:15 AM, Benjamin Tissoires wrote:
On Mar 13 2017 or thereabouts, Benjamin Tissoires wrote:
On Mar 13 2017 or thereabouts, Thorsten
On 03/13/2017 10:10 PM, Cameron Gutman wrote:
On 03/13/2017 06:35 PM, Andrew Duggan wrote:
On 03/13/2017 06:15 AM, Benjamin Tissoires wrote:
[Resending, forgot to add Jiri in CC]
On Mar 13 2017 or thereabouts, Benjamin Tissoires wrote:
On Mar 13 2017 or thereabouts, Thorsten Leemhuis wrote
On 03/14/2017 01:14 AM, Thorsten Leemhuis wrote:
Lo! On 14.03.2017 06:10, Cameron Gutman wrote:
On 03/13/2017 06:35 PM, Andrew Duggan wrote:
On 03/13/2017 06:15 AM, Benjamin Tissoires wrote:
On Mar 13 2017 or thereabouts, Benjamin Tissoires wrote:
On Mar 13 2017 or thereabouts, Thorsten
On 03/13/2017 06:15 AM, Benjamin Tissoires wrote:
[Resending, forgot to add Jiri in CC]
On Mar 13 2017 or thereabouts, Benjamin Tissoires wrote:
On Mar 13 2017 or thereabouts, Thorsten Leemhuis wrote:
Lo! On 12.03.2017 02:55, Cameron Gutman wrote:
Beginning in 4.11-rc1, it looks like RMI4
On 03/13/2017 06:15 AM, Benjamin Tissoires wrote:
[Resending, forgot to add Jiri in CC]
On Mar 13 2017 or thereabouts, Benjamin Tissoires wrote:
On Mar 13 2017 or thereabouts, Thorsten Leemhuis wrote:
Lo! On 12.03.2017 02:55, Cameron Gutman wrote:
Beginning in 4.11-rc1, it looks like RMI4
On 03/10/2017 12:12 PM, Dmitry Torokhov wrote:
On Fri, Mar 10, 2017 at 10:56:33AM -0800, Andrew Duggan wrote:
On 03/10/2017 09:52 AM, Dmitry Torokhov wrote:
On Fri, Mar 10, 2017 at 04:57:35PM +0100, Benjamin Tissoires wrote:
Hi Dmitry,
On Mar 09 2017 or thereabouts, Dmitry Torokhov wrote
On 03/10/2017 12:12 PM, Dmitry Torokhov wrote:
On Fri, Mar 10, 2017 at 10:56:33AM -0800, Andrew Duggan wrote:
On 03/10/2017 09:52 AM, Dmitry Torokhov wrote:
On Fri, Mar 10, 2017 at 04:57:35PM +0100, Benjamin Tissoires wrote:
Hi Dmitry,
On Mar 09 2017 or thereabouts, Dmitry Torokhov wrote
On 03/10/2017 09:52 AM, Dmitry Torokhov wrote:
On Fri, Mar 10, 2017 at 04:57:35PM +0100, Benjamin Tissoires wrote:
Hi Dmitry,
On Mar 09 2017 or thereabouts, Dmitry Torokhov wrote:
Hi,
This is refresh of Benjamin's patches trying to bridge PS/2 and SMbus
devices for better support of
On 03/10/2017 09:52 AM, Dmitry Torokhov wrote:
On Fri, Mar 10, 2017 at 04:57:35PM +0100, Benjamin Tissoires wrote:
Hi Dmitry,
On Mar 09 2017 or thereabouts, Dmitry Torokhov wrote:
Hi,
This is refresh of Benjamin's patches trying to bridge PS/2 and SMbus
devices for better support of
On 02/28/2017 09:05 PM, Linus Torvalds wrote:
On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer
wrote:
I suspect you're just triggering a bug that wasn't triggered by the ps/2
emulation. you can run linput-debug-events --verbose and have a look at the
various state
On 02/28/2017 09:05 PM, Linus Torvalds wrote:
On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer
wrote:
I suspect you're just triggering a bug that wasn't triggered by the ps/2
emulation. you can run linput-debug-events --verbose and have a look at the
various state debugging information, that
On 02/28/2017 04:56 PM, Linus Torvalds wrote:
On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds
wrote:
Yeah, so enabling HID_RMI makes my touchpad work again.
.. so I just noticed something: it works subtly differently.
When I drag something around, I mostly just
On 02/28/2017 04:56 PM, Linus Torvalds wrote:
On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds
wrote:
Yeah, so enabling HID_RMI makes my touchpad work again.
.. so I just noticed something: it works subtly differently.
When I drag something around, I mostly just double-tap and move, and
that
ad if CONFIG_HID_RMI is disabled. Sorry, about the oversight.
Tested-by: Andrew Duggan <adug...@synaptics.com>
Thanks,
Andrew
From: Jiri Kosina <jkos...@suse.cz>
Subject: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not
built
Commit 279967a65b32 ("HID: rmi: Han
ad if CONFIG_HID_RMI is disabled. Sorry, about the oversight.
Tested-by: Andrew Duggan
Thanks,
Andrew
From: Jiri Kosina
Subject: [PATCH] HID: rmi: fallback to generic/multitouch if hid-rmi is not
built
Commit 279967a65b32 ("HID: rmi: Handle all Synaptics touchpads using hid-rmi")
On 02/12/2017 02:38 PM, Dmitry Torokhov wrote:
On Fri, Feb 10, 2017 at 11:02:21AM +0800, Aaron Ma wrote:
Synaptics add new TP firmware ID: 0x2 and 0x3, for now both lower 2 bits
are indicated as TP. Change the constant to bitwise values.
Hmm, I thought IBM/Lenovo owned trackpoint support...
On 02/12/2017 02:38 PM, Dmitry Torokhov wrote:
On Fri, Feb 10, 2017 at 11:02:21AM +0800, Aaron Ma wrote:
Synaptics add new TP firmware ID: 0x2 and 0x3, for now both lower 2 bits
are indicated as TP. Change the constant to bitwise values.
Hmm, I thought IBM/Lenovo owned trackpoint support...
On 01/11/2017 11:27 AM, Christopher Heiny wrote:
On Wed, 2017-01-11 at 18:48 +0100, Benjamin Tissoires wrote:
On Jan 11 2017 or thereabouts, Arnd Bergmann wrote:
On Wednesday, January 11, 2017 5:28:28 PM CET Benjamin Tissoires
wrote:
Yep, it was initially written that way, and IIRC there was
On 01/11/2017 11:27 AM, Christopher Heiny wrote:
On Wed, 2017-01-11 at 18:48 +0100, Benjamin Tissoires wrote:
On Jan 11 2017 or thereabouts, Arnd Bergmann wrote:
On Wednesday, January 11, 2017 5:28:28 PM CET Benjamin Tissoires
wrote:
Yep, it was initially written that way, and IIRC there was
On 01/10/2017 04:16 AM, Arnd Bergmann wrote:
If CONFIG_INPUT=m, we get a build error for the rmi4-f03 driver,
added in linux-4.10:
drivers/input/built-in.o: In function `rmi_f03_attention':
rmi_f03.c:(.text+0xcfe0): undefined reference to `serio_interrupt'
rmi_f03.c:(.text+0xd055): undefined
On 01/10/2017 04:16 AM, Arnd Bergmann wrote:
If CONFIG_INPUT=m, we get a build error for the rmi4-f03 driver,
added in linux-4.10:
drivers/input/built-in.o: In function `rmi_f03_attention':
rmi_f03.c:(.text+0xcfe0): undefined reference to `serio_interrupt'
rmi_f03.c:(.text+0xd055): undefined
Hi Benjamin,
On 01/03/2017 07:16 AM, Benjamin Tissoires wrote:
From: Andrew Duggan <adug...@synaptics.com>
The Synaptics RMI4 driver provides support for RMI4 devices. Instead of
duplicating the RMI4 processing code, make hid-rmi a transport driver
and register it with the Synaptics RMI
Hi Benjamin,
On 01/03/2017 07:16 AM, Benjamin Tissoires wrote:
From: Andrew Duggan
The Synaptics RMI4 driver provides support for RMI4 devices. Instead of
duplicating the RMI4 processing code, make hid-rmi a transport driver
and register it with the Synaptics RMI4 core.
Signed-off-by: Andrew
On 12/04/2016 05:04 PM, Nick Dyer wrote:
The debug would only ever output zero for the clip information.
Signed-off-by: Nick Dyer <n...@shmanahar.org>
Reviewed-by: Andrew Duggan <adug...@synaptics.com>
---
drivers/input/rmi4/rmi_f12.c | 7 ++-
1 file changed, 2 inse
On 12/04/2016 05:04 PM, Nick Dyer wrote:
The debug would only ever output zero for the clip information.
Signed-off-by: Nick Dyer
Reviewed-by: Andrew Duggan
---
drivers/input/rmi4/rmi_f12.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/input/rmi4
have gone into production.
Andrew
Function f03 has been tested in the rmi4-smbus, and the attn data API
on a test synaptics board.
Cheers,
Benjamin
Andrew Duggan (3):
HID: rmi: Make hid-rmi a transport driver for synaptics-rmi4
HID: rmi: Handle all Synaptics touchpads using hid-rmi
HID: rm
incoming event.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
Reviewed-by: Andrew Duggan <adug...@synaptics.com>
---
no changes in v2
---
drivers/input/rmi4/rmi_driver.c | 49 +++--
include/linux/rmi.h | 11 +++
On 12/02/2016 03:41 AM, Benjamin Tissoires wrote:
Now that we have a proper API to set the attention data, there is
no point in keeping it in the transport driver.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
Reviewed-by: Andrew Duggan <adug...@syna
have gone into production.
Andrew
Function f03 has been tested in the rmi4-smbus, and the attn data API
on a test synaptics board.
Cheers,
Benjamin
Andrew Duggan (3):
HID: rmi: Make hid-rmi a transport driver for synaptics-rmi4
HID: rmi: Handle all Synaptics touchpads using hid-rmi
HID: rm
incoming event.
Signed-off-by: Benjamin Tissoires
Reviewed-by: Andrew Duggan
---
no changes in v2
---
drivers/input/rmi4/rmi_driver.c | 49 +++--
include/linux/rmi.h | 11 +
2 files changed, 58 insertions(+), 2 deletions(-)
diff --git
On 12/02/2016 03:41 AM, Benjamin Tissoires wrote:
Now that we have a proper API to set the attention data, there is
no point in keeping it in the transport driver.
Signed-off-by: Benjamin Tissoires
Reviewed-by: Andrew Duggan
---
no changes in v2
---
drivers/input/rmi4/rmi_driver.c | 5
t;n...@shmanahar.org>
Reviewed-by: Andrew Duggan <adug...@synaptics.com>
---
drivers/input/rmi4/rmi_driver.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 4a88312..42
Reviewed-by: Andrew Duggan
---
drivers/input/rmi4/rmi_driver.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 4a88312..425bd19 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers
On 10/24/2016 08:13 PM, Guenter Roeck wrote:
Hi Andrew,
On 10/24/2016 05:59 PM, Andrew Duggan wrote:
Hi Guenter,
I have a couple of comments below.
Thanks a lot for the feedback.
On 09/30/2016 08:22 PM, Guenter Roeck wrote:
Sensor tuning support is needed to determine the number
On 10/24/2016 08:13 PM, Guenter Roeck wrote:
Hi Andrew,
On 10/24/2016 05:59 PM, Andrew Duggan wrote:
Hi Guenter,
I have a couple of comments below.
Thanks a lot for the feedback.
On 09/30/2016 08:22 PM, Guenter Roeck wrote:
Sensor tuning support is needed to determine the number
are enabled.
Fixes: 3bbacb89704fi ("[media] Input: synaptics-rmi4 - add support for F54 ...")
Cc: Nick Dyer <n...@shmanahar.org>
Cc: Andrew Duggan <adug...@synaptics.com>
Cc: Chris Healy <cphe...@gmail.com>
Signed-off-by: Guenter Roeck <li...@roeck-us.net>
Hi Guenter,
I have a couple of comments below.
On 09/30/2016 08:22 PM, Guenter Roeck wrote:
Sensor tuning support is needed to determine the number of enabled
tx and rx electrodes for use in F54 functions.
The number of enabled electrodes is not identical to the total number
of electrodes as
are enabled.
Fixes: 3bbacb89704fi ("[media] Input: synaptics-rmi4 - add support for F54 ...")
Cc: Nick Dyer
Cc: Andrew Duggan
Cc: Chris Healy
Signed-off-by: Guenter Roeck
Reviewed-by: Andrew Duggan
---
Notes:
- The Fixes: SHA might not be accurate if the originating branch is rebased.
-
Hi Guenter,
I have a couple of comments below.
On 09/30/2016 08:22 PM, Guenter Roeck wrote:
Sensor tuning support is needed to determine the number of enabled
tx and rx electrodes for use in F54 functions.
The number of enabled electrodes is not identical to the total number
of electrodes as
On 10/24/2016 04:39 PM, Dmitry Torokhov wrote:
On Mon, Oct 24, 2016 at 11:55:22PM +0100, Nick Dyer wrote:
We have encountered some RMI4 firmwares where there are blank pages in between
PDT pages which contain functions. Add a device tree property which can be set
to force reading the first N
On 10/24/2016 04:39 PM, Dmitry Torokhov wrote:
On Mon, Oct 24, 2016 at 11:55:22PM +0100, Nick Dyer wrote:
We have encountered some RMI4 firmwares where there are blank pages in between
PDT pages which contain functions. Add a device tree property which can be set
to force reading the first N
On Sat, Oct 1, 2016, at 10:45 AM, Guenter Roeck wrote:
> On 10/01/2016 10:27 AM, Andrew Duggan wrote:
> >
> >
> > On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote:
> >> On 09/30/2016 04:02 PM, Dmitry Torokhov wrote:
> >>> On Fri, Sep 30, 2016
On Sat, Oct 1, 2016, at 10:45 AM, Guenter Roeck wrote:
> On 10/01/2016 10:27 AM, Andrew Duggan wrote:
> >
> >
> > On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote:
> >> On 09/30/2016 04:02 PM, Dmitry Torokhov wrote:
> >>> On Fri, Sep 30, 2016
rk these operations into devm stream.
>
Since the regulator functions have their own devm_ versions I would
suggest switching to those functions to avoid dealing with
unregistering.
Registering and unregistering the transport device is a bit more
complicated since these functions add and put the rmi_dev dev
heir own devm_ versions I would
suggest switching to those functions to avoid dealing with
unregistering.
Registering and unregistering the transport device is a bit more
complicated since these functions add and put the rmi_dev device. But,
it sounds like we can handle the unregister using
devm_add
On 08/30/2016 08:13 AM, Benjamin Tissoires wrote:
Hi Andrew,
On Aug 26 2016 or thereabouts, Andrew Duggan wrote:
Resending as plain text
Hi Benjamin,
This patch causes standard clickpads without extended buttons to not work.
I'll explain some more below.
On 08/18/2016 02:24 AM, Benjamin
On 08/30/2016 08:13 AM, Benjamin Tissoires wrote:
Hi Andrew,
On Aug 26 2016 or thereabouts, Andrew Duggan wrote:
Resending as plain text
Hi Benjamin,
This patch causes standard clickpads without extended buttons to not work.
I'll explain some more below.
On 08/18/2016 02:24 AM, Benjamin
by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
Reviewed-by: Andrew Duggan <adug...@synaptics.com>
---
drivers/input/mouse/psmouse-base.c | 6 +
drivers/input/rmi4/Kconfig | 9 ++
drivers/input/rmi4/Makefile| 1 +
drivers/input/rmi4/rmi_bus.c |
Resending as plain text
On 08/18/2016 02:24 AM, Benjamin Tissoires wrote:
From: Lyude Paul
This adds basic functionality for PS/2 passthrough on Synaptics
Touchpads using RMI4 through smbus.
Signed-off-by: Lyude Paul
Signed-off-by: Benjamin Tissoires
Reviewed-by: Andrew Duggan
ata && pdata->f30_data->disable)
+ if (pdata && pdata->f30_data.disable)
And this one.
That's a fairly minor comment and I could see an argument for keeping
the checks in the event that the implementation of
rmi_get_platform_data() changes.
So:
Reviewed-by: Andr
sable)
+ if (pdata && pdata->f30_data.disable)
And this one.
That's a fairly minor comment and I could see an argument for keeping
the checks in the event that the implementation of
rmi_get_platform_data() changes.
So:
Reviewed-by: Andrew Duggan
Andrew
re
com>
Reviewed-by: Andrew Duggan <adug...@synaptics.com>
---
drivers/input/rmi4/rmi_f03.c | 37 +++--
1 file changed, 27 insertions(+), 10 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f03.c b/drivers/input/rmi4/rmi_f03.c
index 9945512..daae1c95 10
from the driver after the firmware read them will result in
invalid data. Which is exactly what Dennis is describing here.
Signed-off-by: Dennis Wassenberg
Signed-off-by: Benjamin Tissoires
Reviewed-by: Andrew Duggan
---
drivers/input/rmi4/rmi_f03.c | 37
- re-route tracksticks
buttons on the Lenovo 2015 series")
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
Acked-by: Andrew Duggan <adug...@synaptics.com>
---
drivers/input/mouse/psmouse-base.c | 3 +++
drivers/input/mouse/synaptics.c| 19 ++--
- re-route tracksticks
buttons on the Lenovo 2015 series")
Signed-off-by: Benjamin Tissoires
Acked-by: Andrew Duggan
---
drivers/input/mouse/psmouse-base.c | 3 +++
drivers/input/mouse/synaptics.c| 19 ++-
drivers/input/mouse/synaptics.h| 1 -
include/lin
Resending as plain text
On 08/18/2016 02:24 AM, Benjamin Tissoires wrote:
If a function needs to communicate with an other, it's better to have
a way to retrieve this other.
Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>
Reviewed-by: Andrew Duggan <adug...@syna
Resending as plain text
Hi Benjamin,
This patch causes standard clickpads without extended buttons to not
work. I'll explain some more below.
On 08/18/2016 02:24 AM, Benjamin Tissoires wrote:
From: Lyude Paul
On the latest series of ThinkPads, the button events for
Resending as plain text
On 08/18/2016 02:24 AM, Benjamin Tissoires wrote:
If a function needs to communicate with an other, it's better to have
a way to retrieve this other.
Signed-off-by: Benjamin Tissoires
Reviewed-by: Andrew Duggan
---
drivers/input/rmi4/rmi_driver.c | 13
Resending as plain text
Hi Benjamin,
This patch causes standard clickpads without extended buttons to not
work. I'll explain some more below.
On 08/18/2016 02:24 AM, Benjamin Tissoires wrote:
From: Lyude Paul
On the latest series of ThinkPads, the button events for the TrackPoint
are
From: Andrew Duggan <adug...@synaptics.com>
The map_offset variable is specific to the register and needs to be reset
in the loop. Otherwise, subsequent register's subpacket maps will have
their bits set at the wrong index.
Signed-off-by: Andrew Duggan <adug...@synaptics.com>
Test
From: Andrew Duggan
The map_offset variable is specific to the register and needs to be reset
in the loop. Otherwise, subsequent register's subpacket maps will have
their bits set at the wrong index.
Signed-off-by: Andrew Duggan
Tested-by: Nitin Chaudhary
Reviewed-by: Benjamin Tissoires
Cc
From: Andrew Duggan <adug...@synaptics.com>
The map_offset variable is specific to the register and needs to be reset
in the loop. Otherwise, subsequent register's subpacket maps will have
their bits set at the wrong index. This results in the max X and Y and
the resolution to not be set o
From: Andrew Duggan
The map_offset variable is specific to the register and needs to be reset
in the loop. Otherwise, subsequent register's subpacket maps will have
their bits set at the wrong index. This results in the max X and Y and
the resolution to not be set on some devices which use F12
.
However, if you don't think that issues has been resolved I would
recommend skipping that patch instead of holding up the others. Let me
know if there is anything else I need to address.
Thanks,
Andrew
On 07/13/2016 11:07 PM, Andrew Duggan wrote:
The v3 version of this patch series makes changes
.
However, if you don't think that issues has been resolved I would
recommend skipping that patch instead of holding up the others. Let me
know if there is anything else I need to address.
Thanks,
Andrew
On 07/13/2016 11:07 PM, Andrew Duggan wrote:
The v3 version of this patch series makes changes
On 08/10/2016 01:28 AM, Benjamin Tissoires wrote:
Hi Andrew,
On Jun 24 2016 or thereabouts, Andrew Duggan wrote:
The Synaptics RMI4 driver provides support for RMI4 devices. Instead of
duplicating the RMI4 processing code, make hid-rmi a transport driver
and register it with the Synaptics RMI4
1 - 100 of 547 matches
Mail list logo