from musb_rx_reinit before it was thrown away.
The data thrown away was a valid packet that had been correctly
ACKed which meant the host and device got out of sync.
Signed-off-by: Andrew Goodbody
Cc: sta...@vger.kernel.org
---
V3 removed the old comment, moved the new comment in place of the old one
a race condition caused by
not stopping the dedicated endpoint for bulk packets before
rotating its queue which allowed a packet to be recieved and then
thrown away.
V3 Updated the comment to better reference the manual
V2 added a comment and removed debugging code
Andrew Goodbody (2):
usb: musb
shared_fifo endpoints would only get a previous tx state cleared
out, the rx state was only cleared for non shared_fifo endpoints
Change this so that the rx state is cleared for all endpoints.
This addresses an issue that resulted in rx packets being dropped
silently.
Signed-off-by: Andrew
own away.
> >>>> The data thrown away was a valid packet that had been correctly
> >>>> ACKed which meant the host and device got out of sync.
> >>>>
> >>>> Signed-off-by: Andrew Goodbody
>
> >>>> Cc: sta...@vger.kernel.org
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
>
> Hello.
>
> On 5/23/2016 3:00 PM, Andrew Goodbody wrote:
>
> > Ensure that the endpoint is stopped by clearing REQPKT before clearing
> > DATAERR_NAKTIMEOUT before rotating the queue on t
shared_fifo endpoints would only get a previous tx state cleared
out, the rx state was only cleared for non shared_fifo endpoints
Change this so that the rx state is cleared for all endpoints.
This addresses an issue that resulted in rx packets being dropped
silently.
Signed-off-by: Andrew
a race condition caused by
not stopping the dedicated endpoint for bulk packets before
rotating its queue which allowed a packet to be recieved and then
thrown away.
V2 added a comment and removed debugging code
Andrew Goodbody (2):
usb: musb: Ensure rx reinit occurs for shared_fifo endpoints
from musb_rx_reinit before it was thrown away.
The data thrown away was a valid packet that had been correctly
ACKed which meant the host and device got out of sync.
Signed-off-by: Andrew Goodbody
Cc: sta...@vger.kernel.org
---
V2 added comment about clearing REQPKT before DATAERR_NAKTIMEOUT
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
> On 05/20/2016 08:06 PM, Andrew Goodbody wrote:
>
> >>> Ensure that the endpoint is stopped by clearing REQPKT before
> >>> clearing DATAERR_NAKTIMEOUT before rotating the queue on the
> >
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
> On 05/20/2016 05:51 PM, Andrew Goodbody wrote:
>
> > Ensure that the endpoint is stopped by clearing REQPKT before clearing
> > DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk
> > e
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
>
> Hello.
>
> On 05/20/2016 05:51 PM, Andrew Goodbody wrote:
>
> > shared_fifo endpoints would only get a previous tx state cleared out,
> > the rx state was only cleared for non shared_fifo end
from musb_rx_reinit before it was thrown away.
The data thrown away was a valid packet that had been correctly
ACKed which meant the host and device got out of sync.
Signed-off-by: Andrew Goodbody
Cc: sta...@vger.kernel.org
---
drivers/usb/musb/musb_host.c | 2 ++
1 file changed, 2 insertions
shared_fifo endpoints would only get a previous tx state cleared
out, the rx state was only cleared for non shared_fifo endpoints
Change this so that the rx state is cleared for all endpoints.
This addresses an issue that resulted in rx packets being dropped
silently.
Signed-off-by: Andrew
a race condition caused by
not stopping the dedicated endpoint for bulk packets before
rotating its queue which allowed a packet to be recieved and then
thrown away.
Andrew Goodbody (2):
usb: musb: Ensure rx reinit occurs for shared_fifo endpoints
usb: musb: Stop bulk endpoint while queue is
+++-
> drivers/net/ethernet/ti/cpsw.h | 1 +
> 3 files changed, 23 insertions(+), 23 deletions(-)
>
> --
> 2.5.5
Tested on hardware with 2 PHYs but not dual_emac mode, DT has phy-handle
entries.
Tested-by: Andrew Goodbody
Revert this patch as not only did it use an unitialised member of a struct
but there is also a pre-existing patch that does it better.
V2 add signoff
Andrew Goodbody (1):
Revert "Prevent NUll pointer dereference with two PHYs on cpsw"
drivers/net/ethernet/ti/c
This reverts commit cfe255600154f0072d4a8695590dbd194dfd1aeb
This can result in a "Unable to handle kernel paging request"
during boot. This was due to using an uninitialised struct member,
data->slaves.
Signed-off-by: Andrew Goodbody
Tested-by: Tony Lindgren
---
v2 No code
This reverts commit cfe255600154f0072d4a8695590dbd194dfd1aeb
This can result in a "Unable to handle kernel paging request"
during boot. This was due to using an uninitialised struct member,
data->slaves.
---
drivers/net/ethernet/ti/cpsw.c | 31 +++
1 file changed, 15 i
Revert this patch as not only did it use an unitialised member of a struct
but there is also a pre-existing patch that does it better.
Andrew Goodbody (1):
Revert "Prevent NUll pointer dereference with two PHYs on cpsw"
drivers/net/ethernet/ti/cpsw.c | 31 +++-
> -Original Message-
> From: Andrew Goodbody
> Date: Mon, 18 Apr 2016 14:53:25 +0100
>
> > This is a fix for a NULL pointer dereference from cpsw which is
> > triggered by having two slave PHYs attached to a cpsw network device.
> > The problem is du
r7:0036 r6:0002 r5:0011
r4:
[ 18.380960] Code: e92dd810 e24cb010 e24dd010 e59b4004 (e5902180)
[ 18.387580] ---[ end trace c80529466223f3f3 ]---
Signed-off-by: Andrew Goodbody
---
v2 - Move allocation of memory for priv->slaves to inside cpsw_probe_dt so it
has d
gets overwritten by the second PHY probe. So move the PHY node
reference to the individual slave data so that there is now one per slave.
v1 had a problem that data->slaves was used before it had been filled in
Andrew Goodbody (1):
Prevent NUll pointer dereference with two PHYs on cpsw
driv
reference to the individual slave data so that there is now one per slave.
v1 had a problem that data->slaves was used before it had been filled in
Andrew Goodbody (1):
Prevent NUll pointer dereference with two PHYs on cpsw
drivers/net/ethernet/ti/cpsw.c | 30 +++---
1 f
r7:0036 r6:0002 r5:0011
r4:
[ 18.380960] Code: e92dd810 e24cb010 e24dd010 e59b4004 (e5902180)
[ 18.387580] ---[ end trace c80529466223f3f3 ]---
Signed-off-by: Andrew Goodbody
---
v2 - Move allocation of memory for priv->slaves to inside cpsw_probe_dt so it
has d
r7:0036 r6:0002 r5:0011
r4:
[ 18.380960] Code: e92dd810 e24cb010 e24dd010 e59b4004 (e5902180)
[ 18.387580] ---[ end trace c80529466223f3f3 ]---
Signed-off-by: Andrew Goodbody
---
drivers/net/ethernet/ti/cpsw.c | 31 ---
1 file changed, 16
reference to the individual slave data so that there is now one per slave.
Andrew Goodbody (1):
Prevent NUll pointer dereference with two PHYs on cpsw
drivers/net/ethernet/ti/cpsw.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
--
2.5.0
26 matches
Mail list logo
