x27;fixed-link')
> - if that doesn't succeed, try to connect to an internal phy, even
> if the chip has a devnode
>
> Tested on a LAN7430 with internal PHY. I cannot test a device using
> fixed-link, as I do not have access to one.
>
> Fixes: 6f197fb63850 ("lan7
On Sat, Nov 07, 2020 at 09:39:42AM -0800, Joe Perches wrote:
> On Sat, 2020-11-07 at 20:54 +0800, Alex Shi wrote:
> > 在 2020/11/7 上午12:39, Florian Fainelli 写道:
> > > > It is good to remember that there are multiple readers of source
> > > > files. There is the compiler which generates code from it,
: macro "BRCM_EG_TC_SHIFT" is not used
> [-Wunused-macros]
> net/dsa/tag_brcm.c:52:0: warning: macro "BRCM_EG_RC_MAC_LEARN" is not
> used [-Wunused-macros]
> net/dsa/tag_brcm.c:48:0: warning: macro "BRCM_EG_RC_EXCEPTION" is not
> used [-Wunused-macros]
On Thu, Nov 05, 2020 at 12:33:55PM +, Lee Jones wrote:
> As per the vendor's request.
>
> Lee Jones (2):
> tty: Remove redundant synclink driver
> tty: Remove redundant synclinkmp driver
Hi Lee
What exactly do you mean by redundant? That some other driver can be
used? Or that nobody uses
> > Where is the TX confirm which uses this stored pointer. I don't see it
> > in this file.
> >
>
> The Tx confirm - dpaa2_switch_tx_conf() - is added in patch 5/9.
Not so obvious. Could it be moved here?
> > It can be expensive to store pointer like this in buffers used for
> > DMA.
>
> Yes,
> +static int dpaa2_switch_build_single_fd(struct ethsw_core *ethsw,
> + struct sk_buff *skb,
> + struct dpaa2_fd *fd)
> +{
> + struct device *dev = ethsw->dev;
> + struct sk_buff **skbh;
> + dma_addr_t addr;
> +
> +/* Manage all NAPI instances for the control interface.
> + *
> + * We only have one RX queue and one Tx Conf queue for all
> + * switch ports. Therefore, we only need to enable the NAPI instance once,
> the
> + * first time one of the switch ports runs .dev_open().
> + */
> +
> +static void dp
On Wed, Nov 04, 2020 at 11:39:47AM -0500, Sven Van Asbroeck wrote:
> Hi Andrew, many thanks for looking at this patch !
>
> On Wed, Nov 4, 2020 at 11:27 AM Andrew Lunn wrote:
> >
> > > Note that as a side-effect, the devicetree phy mode now no longer
> > > has
> Note that as a side-effect, the devicetree phy mode now no longer
> has a default, and always needs to be specified explicitly (via
> 'phy-connection-type').
That sounds like it could break systems. Why do you do this?
Andrew
> Our of interest, are you planning on working on any other areas?
Hi Lee.
No, not really. I'm a networking guy, so will look mostly at
drivers/net and the core net code.
Andrew
On Wed, Nov 04, 2020 at 02:31:40PM +, Lee Jones wrote:
> On Wed, 04 Nov 2020, Andrew Lunn wrote:
>
> > On Wed, Nov 04, 2020 at 09:06:00AM +, Lee Jones wrote:
> > > 'status' is used to interact with a hardware register. It might not
> > > be
On Wed, Nov 04, 2020 at 02:28:35PM +, Lee Jones wrote:
> On Wed, 04 Nov 2020, Andrew Lunn wrote:
>
> > On Wed, Nov 04, 2020 at 09:06:04AM +, Lee Jones wrote:
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/net/ethernet/ti
' description in 'spider_net_link_phy'
> drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Function parameter
> or member 'work' not described in 'spider_net_tx_timeout_task'
> drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Excess function
er"
> Cc: Jakub Kicinski
> Cc: Michael Ellerman
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: Utz Bacher
> Cc: Jens Osterkamp
> Cc: net...@vger.kernel.org
> Cc: linuxppc-...@lists.ozlabs.org
> Signed-off-by: Lee Jones
Reviewed-by: Andrew Lunn
Andrew
ter or
> member 'adapter' not described in 'do_reset'
> drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or
> member 'rwi' not described in 'do_reset'
> drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or
> member 'reset_state' not described in 'do_reset'
>
> Cc: Dany Madden
> Cc: Lijun Pan
> Cc: Sukadev Bhattiprolu
> Cc: Michael Ellerman
> Cc: Benjamin Herrenschmidt
> Cc: Paul Mackerras
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: Santiago Leon
> Cc: Thomas Falcon
> Cc: John Allen
> Cc: net...@vger.kernel.org
> Cc: linuxppc-...@lists.ozlabs.org
> Signed-off-by: Lee Jones
Reviewed-by: Andrew Lunn
Andrew
en-netfront.c:2313: warning: Function parameter or member
> 'backend_state' not described in 'netback_changed'
>
commit 8ed7ec1386b646130d80d017ecd4716f866ea570
Author: Andrew Lunn
Date: Sat Oct 31 19:04:35 2020 +0100
drivers: net: xen-netfront: Fixed W=1 set but unused warnings
Already in net-next.
Andrew
net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or
> member 'est_new' not described in 'am65_cpsw_timer_set'
>
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: Ivan Khoronzhuk
> Cc: "Gustavo A. R. Silva"
> Cc: net...@
Cc: Jesper Dangaard Brouer
> Cc: John Fastabend
> Cc: Rusty Russell
> Cc: xen-de...@lists.xenproject.org
> Cc: net...@vger.kernel.org
> Cc: b...@vger.kernel.org
> Signed-off-by: Lee Jones
Reviewed-by: Andrew Lunn
Andrew
On Wed, Nov 04, 2020 at 09:06:01AM +, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/xilinx/xilinx_emaclite.c:525: warning: Function
> parameter or member 'txqueue' not described in 'xemaclite_tx_timeout'
https://www.spinics.net/lists/netdev/msg
x.c: In function ‘lan78xx_set_suspend’:
> drivers/net/usb/lan78xx.c:3807:6: warning: variable ‘ret’ set but not used
> [-Wunused-but-set-variable]
>
> Cc: Woojung Huh
> Cc: Microchip Linux Driver Support
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: net...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Lee Jones
Reviewed-by: Andrew Lunn
Andrew
On Wed, Nov 04, 2020 at 09:06:00AM +, Lee Jones wrote:
> 'status' is used to interact with a hardware register. It might not
> be safe to remove it entirely. Mark it as __maybe_unused instead.
Hi Lee
https://www.mail-archive.com/netdev@vger.kernel.org/msg365875.html
I'm working on driver/n
> >> +static int
> >> +ax88796c_set_tunable(struct net_device *ndev, const struct
> >> ethtool_tunable *tuna,
> >> + const void *data)
> >> +{
> >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev);
> >> +
> >> + switch (tuna->id) {
> >> + case ETHTOOL_SPI_COMPRESSION:
> +config SPI_AX88796C_COMPRESSION
> + bool "SPI transfer compression"
> + default n
> + depends on SPI_AX88796C
> + help
> + Say Y here to enable SPI transfer compression. It saves up
> + to 24 dummy cycles during each transfer which may noticably
> + speed up sho
> > > > drivers/net/phy/dp83td510.c:70:11: warning: symbol
> > > > 'dp83td510_feature_array' was not declared. Should it be static?
> > > I did not see this warning. Did you use W=1?
> > I _think_ that one is W=1. All the PHY drivers are W=1 clean, and i
> > want to keep it that way. And i hope to
On Tue, Nov 03, 2020 at 11:09:44AM -0600, Dan Murphy wrote:
> Hello
>
> On 10/30/20 6:03 PM, Jakub Kicinski wrote:
> > On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote:
> > > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
> > > that supports 10M single pair cable.
> >
On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote:
> Andrew
>
> On 10/30/20 3:15 PM, Andrew Lunn wrote:
> > > +static int dp83td510_config_init(struct phy_device *phydev)
> > > +{
> > > + struct dp83td510_private *dp83td510 = phydev->priv;
> &g
> Do you have any issue with the property being in the ethernet-phy.yaml?
It seems generic enough. Increasing the voltage increases the power
requirements, and maybe not all boards are capable of that.
Andrew
ana
I did some quick testing with the Marvell PHY. This is one of the
drivers you have not changed. But it at least tests some of the core
changes.
Tested-by: Andrew Lunn
I will try to review the actual changes soon.
Andrew
On Tue, Nov 03, 2020 at 07:01:05PM +0530, Radhey Shyam Pandey wrote:
> From: Shravya Kumbham
>
> Add ret variable, conditions to check the return value and it's error
> path for of_address_to_resource() and phy_read() functions.
>
> Addresses-Coverity: Event check_return value.
Hi Radhey
This
On Mon, Nov 02, 2020 at 06:12:32PM -0800, Florian Fainelli wrote:
>
>
> On 11/2/2020 5:34 PM, Pavana Sharma wrote:
> >> How many times have i asked for you to add kerneldoc for this new
> >> value? How many times have you not done so?
> >
> > I have added kerneldoc comment for the new value adde
> I did some investigation and now I have some details.
> The term 'PHY' described in Ether Group Spec should be the PCS + PMA, a figure
> below for one configuration:
>
> ++ +-+
> | Host Side Ether Group | | XL710 |
> |
On Mon, Nov 02, 2020 at 04:43:09PM +1000, Pavana Sharma wrote:
> Returning 0 is no more an error case with MV88E6393 family
> which has serdes lane numbers 0, 9 or 10.
> So with this change .serdes_get_lane will return lane number
> or error (-ENODEV).
>
> Signed-off-by: Pavana Sharma
> ---
> dr
> @@ -985,12 +985,12 @@ int mv88e6390_serdes_get_regs_len(struct mv88e6xxx_chip
> *chip, int port)
> void mv88e6390_serdes_get_regs(struct mv88e6xxx_chip *chip, int port, void
> *_p)
> {
> u16 *p = _p;
> - int lane;
> + int lane = -ENODEV;
> u16 reg;
> int i;
The reve
On Mon, Nov 02, 2020 at 04:40:02PM +1000, Pavana Sharma wrote:
> Thanks for the review.
> Here's updated patchset.
Please include a short description of what you have changed since the
last version. It helps us as maintainers see if you have attempted to
make the changes we have requested, or not.
On Mon, Nov 02, 2020 at 04:42:06PM +1000, Pavana Sharma wrote:
> Add 5GBASE-R phy interface mode
>
> Signed-off-by: Pavana Sharma
How many times have i asked for you to add kerneldoc for this new
value? How many times have you not done so?
NACK.
If you don't understand a comment, please ask.
On Sun, Nov 01, 2020 at 10:54:38PM +0300, Sergej Bauer wrote:
> > > Signed-off-by: Sergej Bauer
> >
> > * I miss a change description here.
> The reason for the fix is when the device is down netdev->phydev will be NULL
> and there is no checking for this situation. So 'ethtool ethN' leads to
>
On Sat, Oct 31, 2020 at 11:10:53AM +0800, YueHaibing wrote:
> gpiod_to_irq() never return 0, but returns negative in
> case of error, check it and set gpio_irq to 0.
>
> Fixes: 73970055450e ("sfp: add SFP module support")
> Signed-off-by: YueHaibing
Reviewed-by: Andrew Lunn
Andrew
> So, then re-send for this or just this patch ping?
> Naturally, this is for net-next.
> I don't mind doing either way.
Please resend, with all the acked-by, reviewed-by added, now that
net-next is open.
Andrew
> Sure, I just wanted to add the comment before others simply copy and
> paste this (pseudo) code. And in patch 9 (aquantia) and 18 (realtek)
> it is used as is. And IIRC at least the Aquantia PHY doesn't mask
> the interrupt status.
And that is were we are going to have issues with this patch set
> > - Every PHY driver gains a .handle_interrupt() implementation that, for
> > the most part, would look like below:
> >
> > irq_status = phy_read(phydev, INTR_STATUS);
> > if (irq_status < 0) {
> > phy_error(phydev);
> > return IRQ_NONE;
> > }
> >
> > i
Signed-off-by: Ivan Mikhaylov
Reviewed-by: Andrew Lunn
Andrew
On Fri, Oct 30, 2020 at 04:37:07PM +0300, Ivan Mikhaylov wrote:
> Add the phy-handle and MDIO description and add the example with
> PHY and MDIO nodes.
>
> Signed-off-by: Ivan Mikhaylov
Reviewed-by: Andrew Lunn
Andrew
> +static int dp83td510_config_init(struct phy_device *phydev)
> +{
> + struct dp83td510_private *dp83td510 = phydev->priv;
> + int mst_slave_cfg;
> + int ret = 0;
> +
> + if (phy_interface_is_rgmii(phydev)) {
> + if (dp83td510->rgmii_delay) {
> + ret
On Fri, Oct 30, 2020 at 12:29:48PM -0500, Dan Murphy wrote:
> Per the 802.3cg spec the 10base T1L can operate at 2 different
> differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to
> drive that output is dependent on the PHY's on board power supply.
Hi Dan
So this property is abou
0:00:00:00:00:00
> Current message level: 0x (0)
>
> Link detected: yes
>
> Signed-off-by: Dan Murphy
Reviewed-by: Andrew Lunn
Andrew
ixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Jonathan McDowell
Reviewed-by: Andrew Lunn
Andrew
tion 2.5Gbps single port PHY
> RTL8221B-VM-CG: the 2.5Gbps single port PHY with MACsec feature
>
> This patch adds the minimal drivers to manage these transceivers.
>
> Signed-off-by: Willy Liu
Reviewed-by: Andrew Lunn
Andrew
> >> +static irqreturn_t ax88796c_interrupt(int irq, void *dev_instance)
> >> +{
> >> + struct net_device *ndev = dev_instance;
> >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev);
Do the assignment later.
Andrew
On Thu, Oct 29, 2020 at 08:07:57PM +0800, Willy Liu wrote:
> Realtek single-port 2.5Gbps Ethernet PHY ids as below:
> RTL8226-CG: 0x001cc800(ES)/0x001cc838(MP)
> RTL8226B-CG/RTL8221B-CG: 0x001cc840(ES)/0x001cc848(MP)
> ES: engineer sample
> MP: mass production
>
> Since above PHYs are already in m
On Thu, Oct 29, 2020 at 03:25:25PM +0530, Bhaskar Chowdhury wrote:
> Fixed spelling in comment like below:
>
> s/defalut/default/p
>
> This is in linux-next.
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Andrew Lunn
Andrew
On Thu, Oct 29, 2020 at 03:42:00PM +1000, Pavana Sharma wrote:
> Add new mode supported by MV88E6393 family.
Hi Pavana
I asked you to add kerneldoc for this new value, but you have not
added it. Please compile your code with W=1, and you should see the
warning.
Andrew
On Thu, Oct 29, 2020 at 10:33:52AM +0800, Zou Wei wrote:
> Fix the following coccinelle report:
>
> ./drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:233:6-8:
> WARNING: possible condition with no effect (if == else)
>
> Both branches are the same, so remove the else if/else altogether.
>
On Thu, Oct 29, 2020 at 10:30:14AM +0800, Zou Wei wrote:
> Fix the following coccinelle report:
>
> ./drivers/net/ethernet/nvidia/forcedeth.c:3479:8-10:
> WARNING: possible condition with no effect (if == else)
>
> Both branches are the same, so remove the else if/else altogether.
>
> Reported-b
> +static void
> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs, void
> *_p)
> +{
> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev);
> + u16 *p = _p;
> + int offset, i;
You missed a reverse christmass tree fix here.
> +static int comp;
> +static i
On Wed, Oct 28, 2020 at 10:08:27AM +1000, Pavana Sharma wrote:
> Add new mode supported by MV88E6393 family.
>
> Signed-off-by: Pavana Sharma
> ---
> include/linux/phy.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 3a09d2bf69ea..9
On Wed, Oct 28, 2020 at 10:09:12AM +1000, Pavana Sharma wrote:
> Add 5GBASE-R phy interface mode supported by mv88e6393
> family.
>
> Signed-off-by: Pavana Sharma
Reviewed-by: Andrew Lunn
Andrew
On Wed, Oct 28, 2020 at 10:09:50AM +1000, Pavana Sharma wrote:
> The Marvell 88E6393X device is a single-chip integration of a 11-port
> Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers
> and three 10-Gigabit interfaces.
>
> This patch adds functionalities specific to mv88
On Tue, Oct 27, 2020 at 08:56:09PM +, Chris Packham wrote:
>
> On 24/10/20 11:42 am, Andrew Lunn wrote:
> >> +int mv88e6123_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port)
> >> +{
> >> + if (mv88e6xxx_serdes_get_lane(chip, por
On Tue, Oct 27, 2020 at 05:49:23PM +0300, Ivan Mikhaylov wrote:
> Split MDIO registration and PHY connect into ftgmac100_setup_mdio and
> ftgmac100_mii_probe.
>
> Signed-off-by: Ivan Mikhaylov
Reviewed-by: Andrew Lunn
Andrew
On Tue, Oct 27, 2020 at 05:49:24PM +0300, Ivan Mikhaylov wrote:
> phy-handle can't be handled well for ast2400/2500 which has an embedded
> MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize
> PHYs from mdio child node with of_mdiobus_register.
>
> Signed-off-by: Ivan Mikhay
disabled.
>
> Suggested-by: Andrew Lunn
> Signed-off-by: Łukasz Stelmach
Reviewed-by: Andrew Lunn
Andrew
write_mmd (struct phy_device *phydev, int
> devad, u32 regnum, u16 val)'.
>
> It turns that both the C and the H files have the same
> kernel-doc markup for the same functions. Let's drop the
> at the header file, keeping the one closer to the code.
>
> Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Andrew Lunn
Andrew
x27;, with the same value '0'.
>
> Fixes: efca3878a5fb ("ch_ktls: Issue if connection offload fails")
> Signed-off-by: Arnd Bergmann
Hi Arnd
I have the same fix in my tree of W=1 fixes. I was just waiting for
net-next to open.
Reviewed-by: Andrew Lunn
Andrew
ann
Hi Arnd
It is nice to have the additional type checking.
Since you added a Fixes: tag, do you want this in stable?
netdev puts into the Subject line the tree it is intended for:
[PATCH net v1]
or
[PATCH net-next v1]
Anyway:
Reviewed-by: Andrew Lunn
Andrew
> > > > Do you really mean PHY? I actually expect it is PCS?
> > >
> > > For this implementation, yes.
> >
> > Yes, you have a PHY? Or Yes, it is PCS?
>
> Sorry, I mean I have a PHY.
>
> >
> > To me, the phylib maintainer, having a PHY means you have a base-T
> > interface, 25Gbase-T, 40Gbase
> +&mdio {
> + extphy: ethernet-phy@0 {
> + reg = <1>;
If reg = 1, then this should be ethernet-phy@1
Andrew
On Mon, Oct 26, 2020 at 03:58:11PM +1000, Pavana Sharma wrote:
> Signed-off-by: Pavana Sharma
Please swap the order of the patches so the build does not break.
Andrew
On Mon, Oct 26, 2020 at 10:47:36AM +0100, Mauro Carvalho Chehab wrote:
> Some functions have different names between their prototypes
> and the kernel-doc markup.
>
> Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Andrew Lunn
Andrew
> > > +The Intel(R) PAC N3000 is a FPGA based SmartNIC platform for
> > > multi-workload
> > > +networking application acceleration. A simple diagram below to for the
> > > board:
> > > +
> > > + ++
> > > + |
> > +u64 read_mac_stats(struct eth_com *ecom, unsigned int addr)
> > +{
> > + u32 data_l, data_h;
> > +
> > + if (eth_com_read_reg(ecom, addr, &data_l) ||
> > + eth_com_read_reg(ecom, addr + 1, &data_h))
> > + return 0xULL;
> return -1; ?
Since this is a u64 fu
On Sat, Oct 24, 2020 at 10:36:36AM -0700, Tom Rix wrote:
>
> On 10/24/20 9:39 AM, Andrew Lunn wrote:
> > On Sat, Oct 24, 2020 at 08:03:51AM -0700, Tom Rix wrote:
> >> On 10/23/20 1:45 AM, Xu Yilun wrote:
> >>> This driver supports the ethernet reti
On Sat, Oct 24, 2020 at 07:09:53PM +0100, Russell King - ARM Linux admin wrote:
> On Sat, Oct 24, 2020 at 07:17:05PM +0200, Andrew Lunn wrote:
> > > - Every PHY driver gains a .handle_interrupt() implementation that, for
> > > the most part, would look like below:
>
> - Every PHY driver gains a .handle_interrupt() implementation that, for
> the most part, would look like below:
>
> irq_status = phy_read(phydev, INTR_STATUS);
> if (irq_status < 0) {
> phy_error(phydev);
> return IRQ_NONE;
> }
>
> if (irq_s
On Sat, Oct 24, 2020 at 08:03:51AM -0700, Tom Rix wrote:
>
> On 10/23/20 1:45 AM, Xu Yilun wrote:
> > This driver supports the ethernet retimers (Parkvale) for the Intel PAC
> > (Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC.
>
> Parkvale is a code name, it would be bette
> +++ b/Documentation/ABI/testing/sysfs-class-net-dfl-eth-group
> @@ -0,0 +1,19 @@
> +What:/sys/class/net//tx_pause_frame_quanta
> +Date:Oct 2020
> +KernelVersion: 5.11
> +Contact: Xu Yilun
> +Description:
> + Read-Write. Value representing the
> fault distance registers, CDIAG_FLT_DIST_0, CDIAG_FLT_DIST_1,
> CDIAG_FLT_DIST_2, and CDIAG_FLT_DIST_3, Address 0xBA21 to Address 0xBA24).
>
> This change implements support for this using phylib's cable-test support.
>
> Signed-off-by: Alexandru Ardelean
Reviewed-by: Andr
he ADIN1300_DIAG_CLK_EN bit (13) is cleared, to disable the
> diagnostics clock.
>
> Signed-off-by: Alexandru Ardelean
Reviewed-by: Andrew Lunn
Andrew
> +int mv88e6123_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port)
> +{
> + if (mv88e6xxx_serdes_get_lane(chip, port) == 0)
> + return 0;
> +
> + return 26 * sizeof(u16);
> +}
Hi Chris
Where did 26 come from?
Andrew
the read was good. This will mean that failed values will
> return 0x.
>
> Signed-off-by: Chris Packham
Reviewed-by: Andrew Lunn
Andrew
ffs with lines of context instead of the usual three.
to increase the number of lines of context. Often three lines is not
enough to include the function declaration in the patch, so i need to
go look at the sources to do a review.
Reviewed-by: Andrew Lunn
Andrew
On Fri, Oct 23, 2020 at 12:56:21PM +0200, Oleksij Rempel wrote:
> Most of CAN PHYs (transceivers) are not attached to any data bus, so we
> are not able to communicate with them. For this case, we introduce a CAN
> specific virtual bus to make use of existing PHY framework.
I don't think you are m
On Fri, Oct 23, 2020 at 12:56:20PM +0200, Oleksij Rempel wrote:
> This patch set is introducing PHY support for CAN.
The device tree binding needs documenting.
It might also help me get my head around the virtual MDIO bus and how
PHYs are added to it.
Andrew
On Fri, Oct 23, 2020 at 12:56:23PM +0200, Oleksij Rempel wrote:
> Signed-off-by: Oleksij Rempel
> ---
> drivers/net/phy/phy.c | 2 ++
> include/linux/phy.h | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 35525a671400..4fb355df3
On Fri, Oct 23, 2020 at 12:56:21PM +0200, Oleksij Rempel wrote:
> Most of CAN PHYs (transceivers) are not attached to any data bus, so we
> are not able to communicate with them. For this case, we introduce a CAN
> specific virtual bus to make use of existing PHY framework.
>
> Signed-off-by: Olek
> Yes there is: have your Ethernet PHY compatible string be of the form
> "ethernet." and then there is no need for such hacking.
> of_get_phy_id() will parse that compatible and that will trigger
> of_mdiobus_register_phy() to take the phy_device_create() path.
Yep. That does seem like th
Hi Xu
Before i look at the other patches, i want to understand the
architecture properly.
> +===
> +DFL device driver for Ether Group private feature on Intel(R) PAC N3000
> +==
On Fri, Oct 23, 2020 at 12:00:30PM +0200, Oleksij Rempel wrote:
> This patch replaces the spaces in the indention of the 56G PHYs by
> proper tabs.
Hi Oleksij
The change itself is O.K.
However, please put in the subject line which tree it is for,
[PATCH net-next v2] ...
Also, net next is close
> For example, Turris MOX board which is also A3720 based has optional
> SDIO module which can be plugged / unplugged, standard variant is sold
> without it and in DTS file is this node always enabled:
I think the Turris has quite a sophisticated bootloader which
manipulates the DT to fit the hard
> i'll think about the frame-generator;
Here were the two main problems i can remember with my first version:
How do you discover what is can actually do? You probably need to
collect up all the open PHY datasheets and get an idea what the
different vendors provide, what is common, what could be
> Actually, I'd also be interested [for this PHY], to report a
> "significance impedance" detection, which is similar to the
> short-detection that is already done.
You can add that as just another element of the enum.
> At first, this report would sound like it could be interesting; but
> feel f
> The frame-generator is an interesting feature of the PHY, that's not
> useful for the current phylib; the PHY can send packages [like a
> signal generator], and then these can be looped back, or sent over the
> wire.
Many PHYs that that. I posted some patches to the list a few years ago
adding b
> Signed-off-by: Alexandru Ardelean
Hi Alexandru
Overall, this looks good.
> +static int adin_cable_test_report_trans(int result)
> +{
> + int mask;
> +
> + if (result & ADIN1300_CDIAG_RSLT_GOOD)
> + return ETHTOOL_A_CABLE_RESULT_CODE_OK;
> + if (result & ADIN1300_CDIAG_
On Wed, Oct 21, 2020 at 04:51:39PM +0300, Alexandru Ardelean wrote:
> The LINKING_EN bit is always cleared during reset. Initially it was set
> during the downshift setup, because it's in the same register as the
> downshift retry count (PHY_CTRL1).
Hi Alexandru
For those of us how have not read
Hi Chris
> So far I've not needed to use interrupts from the 6097. It's connected
> on my hardware but never been tested.
The mv88e6xxx driver will also poll the interrupt bits, if the
interrupt is not wired to a GPIO.
> There are a couple of SERDES LinkInt bits in the Global2 interrupt
> sourc
> Humm. Are 1v and 2.4v advertised so it can be auto negotiated? Maybe a
> PHY tunable is not correct? Is this voltage selection actually more
> like pause and EEE?
[Goes and looks at the datasheet]
Register 0x20E, bit 13:
1 = Advertise that the 10BASE-T1L PHY has increased transmit/
receive lev
> + ti,master-slave-mode:
> +$ref: /schemas/types.yaml#definitions/uint32
> +default: 0
> +description: |
> + Force the PHY to be configured to a specific mode.
> + Force Auto Negotiation - 0
> + Force Master mode at 1v p2p - 1
> + Force Master mode at 2.4v p2p - 2
> > It's still there. The speed/duplex etc are read from the serdes PHY
> > via mv88e6390_serdes_pcs_get_state(). When the link comes up, we
> > pass the negotiated link parameters read from there to the link_up()
> > functions. For ports where mv88e6xxx_port_ppu_updates() returns false
> > (no ext
and-status"' don't force
> > > the link up, the switch MAC will detect the link status correctly.
> > >
> > > Signed-off-by: Chris Packham
> > > Reviewed-by: Andrew Lunn
> >
> > I thought we had issues with the 88E6390 where the
> HW team says no to interoperability. So we can just add T1L and advertise
> that type.
>
> The DP83TD510L capability is limited to 10Base-T1L only.
Thanks for checking. We will avoid issues getting this correct from
the start, rather than adding it later, like we did for other T1 PHYs.
An
t; without a PHY.
>
> Signed-off-by: Chris Packham
Reviewed-by: Andrew Lunn
Just a nit pick below.
> +int mv88e6185_serdes_power(struct mv88e6xxx_chip *chip, int port, u8 lane,
> +bool up)
> +{
> + /* The serdes power can't be controlled on thi
501 - 600 of 1612 matches
Mail list logo
