Re: [PATCH -next] staging: most: fix error return code in audio_probe_channel()

y: Wei Yongjun <weiyongj...@huawei.com> Signed-off-by: Andrey Shvetsov <andrey.shvet...@k2l.de> > --- > drivers/staging/most/aim-sound/sound.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/most/aim-sound/sound.c > b/drivers/s

Re: [PATCH -next] staging: most: fix error return code in audio_probe_channel()

On Sun, Sep 25, 2016 at 03:41:11PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the audio_set_hw_params() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Signed-off-b

Re: staging: most: warning: ‘mbo’ may be used uninitialized in this function

On Fri, Mar 18, 2016 at 01:41:19PM +0100, Geert Uytterhoeven wrote: > On Fri, Mar 18, 2016 at 6:42 AM, Linux Kernel Mailing List > wrote: > > Web: > > https://git.kernel.org/torvalds/c/f45b0fba43f415f69982df743dfa9b5d1b57785e > > Commit:

Re: staging: most: warning: ‘mbo’ may be used uninitialized in this function

On Fri, Mar 18, 2016 at 01:41:19PM +0100, Geert Uytterhoeven wrote: > On Fri, Mar 18, 2016 at 6:42 AM, Linux Kernel Mailing List > wrote: > > Web: > > https://git.kernel.org/torvalds/c/f45b0fba43f415f69982df743dfa9b5d1b57785e > > Commit: f45b0fba43f415f69982df743dfa9b5d1b57785e > >

Re: [PATCH 3/5] staging: most: remove driver owner

On Mon, Sep 07, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote: > On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote: > > On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > > > The platform driver core will set the owner value, we

Re: [PATCH 3/5] staging: most: remove driver owner

On Mon, Sep 07, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote: > On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote: > > On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > > > The platform driver core will set the owner value, we

Re: [PATCH 3/5] staging: most: remove driver owner

On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > The platform driver core will set the owner value, we do not need to do > it in the module. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 - > 1 file changed, 1 deletion(-) > > diff

Re: [PATCH 3/5] staging: most: remove driver owner

On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote: > The platform driver core will set the owner value, we do not need to do > it in the module. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 - > 1 file changed, 1

Re: [PATCH 07/19] staging: most: Remove unnecessary externs

On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote: > Using 'extern' is not necessary for function prototypes. > We use them to mark dependency inversions (callbacks). I thought about comments instead of, but I'm not sure what is worse. -- Regards, Andrey -- To unsubscribe from this

Re: [PATCH] staging/most: fix return value for DIM_GetChannelState

On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote: > Return NULL instead of 0 for invalid input. > > Signed-off-by: Tomas Melin Signed-off-by: Andrey Shvetsov > --- > drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] staging/most: fix return value for DIM_GetChannelState

On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote: Return NULL instead of 0 for invalid input. Signed-off-by: Tomas Melin tomas.me...@iki.fi Signed-off-by: Andrey Shvetsov andrey.shvet...@k2l.de --- drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH 07/19] staging: most: Remove unnecessary externs

On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote: Using 'extern' is not necessary for function prototypes. We use them to mark dependency inversions (callbacks). I thought about comments instead of, but I'm not sure what is worse. -- Regards, Andrey -- To unsubscribe from this