Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

22.01.2015 3:40, Rusty Russell пишет: Andrey Tsyvarev writes: 21.01.2015 4:40, Rusty Russell пишет: Andrey Tsyvarev writes: 20.01.2015 9:37, Rusty Russell пишет: Andrey Tsyvarev writes: parse_args call module parameters' .set handlers, which may use locks defined in the modul

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

21.01.2015 4:40, Rusty Russell пишет: Andrey Tsyvarev writes: 20.01.2015 9:37, Rusty Russell пишет: Andrey Tsyvarev writes: parse_args call module parameters' .set handlers, which may use locks defined in the module. So, these classes should be freed in case parse_args returns erro

Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed

20.01.2015 9:37, Rusty Russell пишет: Andrey Tsyvarev writes: parse_args call module parameters' .set handlers, which may use locks defined in the module. So, these classes should be freed in case parse_args returns error(e.g. due to incorrect parameter passed). Thanks, this seems

[PATCH] kernel/module.c: Free lock-classes if parse_args failed

parse_args call module parameters' .set handlers, which may use locks defined in the module. So, these classes should be freed in case parse_args returns error(e.g. due to incorrect parameter passed). Signed-off-by: Andrey Tsyvarev --- kernel/module.c | 3 +++ 1 file changed, 3 inser

Re: [f2fs-dev] f2fs: Possible use-after-free when umount filesystem

Hi, With patch skipping invalidating pages for node_inode and meta_inode use-after-free error disappears too. 23.07.2014 7:39, Gu Zheng пишет: Hi, On 07/23/2014 10:12 AM, Chao Yu wrote: Hi Andrey Gu, -Original Message- From: Andrey Tsyvarev [mailto:tsyva...@ispras.ru] Sent

Re: f2fs: Possible use-after-free when umount filesystem

ternal modules */ destroy_node_manager(sbi); Thanks, Gu With reclaim order of node_inode and meta_inode swapped, use-after-free error disappears. But shouldn't initialization order of these inodes be swapped too? As meta_inode uses node_inode, it seems logical that it should be initi

f2fs: Possible use-after-free when umount filesystem

y change if, while 'meta_inode' is evicted in one f2fs filesystem, another (mounted) f2fs filesystem requests inode from cache, and formely 'node_inode' of the first filesystem is returned. Found by Linux File System Verification project (linuxtesting.org). -- Best regards,

Re: [PATCH] ext4: Do not destroy ext4_groupinfo_caches if ext4_mb_init() fails

12.05.2014 19:08, Lukáš Czerner пишет: On Mon, 12 May 2014, Andrey Tsyvarev wrote: Date: Mon, 12 May 2014 12:23:59 +0400 From: Andrey Tsyvarev To: Theodore Ts'o Cc: Andrey Tsyvarev, Andreas Dilger,linux-e...@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov Su

[PATCH] ext4: Do not destroy ext4_groupinfo_caches if ext4_mb_init() fails

Caches from 'ext4_groupinfo_caches' may be in use by other mounts, which have already existed. So, it is incorrect to destroy them when newly requested mount fails. Found by Linux File System Verification project (linuxtesting.org). Signed-off-by: Andrey Tsyvarev --- fs/ext4/mba

Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

orted-by: Andrey Tsyvarev Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 6 ++ fs/f2fs/f2fs.h | 1 + fs/f2fs/segment.c| 17 +++-- 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 4aa521a..890e23

f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

ted successfully. -- Best regards, Andrey Tsyvarev Linux Verification Center, ISPRAS web: http://linuxtesting.org -- Andrey Tsyvarev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

ata has been processed correctly. Thanks. -- Best regards, Andrey Tsyvarev Linux Verification Center, ISPRAS web:http://linuxtesting.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majord

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

that's why patch investigation took so long time. -- Best regards, Andrey Tsyvarev Linux Verification Center, ISPRAS web:http://linuxtesting.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

ter is incremented by mkdir()-> f2fs_add_link()-> init_inode_metadata()-> make_empty_dir()-> set_page_dirty(); but no one decrement it. May be, this should be done along with truncating directory inode in error-path of init_inode_metadata() ? -- Best regards, And

f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

f2fs_mkdir+0xbb/0x150 [f2fs] [ 117.863849] [] vfs_mkdir+0xb7/0x160 [ 117.863851] [] SyS_mkdir+0x5f/0xc0 [ 117.863854] [] system_call_fastpath+0x16/0x1b -- Best regards, Andrey Tsyvarev Linux Verification Center, ISPRAS web: http://linuxtesting.org --- Это сообщение свободно от вирусов и вред