Doc.../sound/soc/platform.rst: snd_soc_platform_driver out of sync

2017-11-30 Thread Andrey Utkin
Hi maintainers of Sound and/or Docs. Documentation/sound/soc/platform.rst quotes outdated definition of "struct snd_soc_platform_driver". I spotted this because it shows like there are suspend/resume function pointers while this is no longer true. I don't have a good idea how to update the doc, I

Re: [PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

2017-08-07 Thread Andrey Utkin
Hi Anton, Nothing serious, just some purist nitpicking below. On Wed, Aug 02, 2017 at 06:17:02PM +0400, Anton Sviridenko wrote: > 24 GPIO pins from 32 available on solo6x10 chips are exported > to gpiolib. First 8 GPIOs are reserved for internal use on capture card > boards, GPIOs in range 8:15 a

Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

2017-07-11 Thread Andrey Utkin
ta bss dec hex filename >9218 360 09578256a solo6x10-tw28.o > > After: >text data bss dec hex filename >8237 504 087412225 solo6x10-tw28.o > > Signed-off-by: Colin Ian King Acked-by: Andrey Utkin

Re: [PATCH] [media] solo6x10: fix detection of TW2864B chips

2017-07-01 Thread Andrey Utkin
on these cards with > > [276582.344942] solo6x10 :07:00.0: Probing Softlogic 6110 > [276582.402151] solo6x10 :07:00.0: Could not initialize any techwell chips > [276582.402781] solo6x10: probe of :07:00.0 failed with error -22 > > Signed-off-by: Anton Sviridenko Acked-by:

[PATCH 2/2] MAINTAINERS: solo6x10: update Andrey Utkin email

2017-06-11 Thread Andrey Utkin
Updating my personal email address in solo6x10. Signed-off-by: Andrey Utkin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 026af206660b..885badfa4fa7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11966,7 +11966,7 @@ SOFTLOGIC

[PATCH 1/2] MAINTAINERS: solo6x10, tw5864: add Anton Sviridenko

2017-06-11 Thread Andrey Utkin
Anton Sviridenko is now in charge of drivers in Bluecherry. Signed-off-by: Andrey Utkin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bdd1fe5..026af206660b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11964,6 +11964,7 @@ F

Re: [PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

2017-03-26 Thread Andrey Utkin
On Tue, Aug 23, 2016 at 07:18:53PM -0300, Lucas De Marchi wrote: > From: José Roberto de Souza > > If we aren't going to continue using the controller we can just disable > it instead of waiting for it to complete. The biggest improvement here > is when a I2C transaction is completed and it doesn

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-26 Thread Andrey Utkin
On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote: > 4.10-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Zhang Rui > > commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream. > > With commit 67bf5156edc4 ("gpio / ACPI

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-08 Thread Andrey Utkin
Signed-off-by: Andrey Utkin Signed-off-by: Andrey Utkin Please welcome Anton who is now in charge of solo6x10 and tw5864 support and development in Bluecherry company, I have sent out to him the hardware samples I possessed. (We will prepare the patch updating MAINTAINERS file soon.) If

Re: [PATCH] [media] tw5864: use dev_warn instead of WARN to shut up warning

2017-02-28 Thread Andrey Utkin
compiler see that the initialization is correct. > > Signed-off-by: Arnd Bergmann Thanks for the patch. Acked-by: Andrey Utkin See the note below. > --- > drivers/media/pci/tw5864/tw5864-video.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-28 Thread Andrey Utkin
On Tue, Feb 28, 2017 at 09:20:53AM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin > wrote: > > Retcode checking takes place everywhere, but currently it overwrites > > supplied structs with potentially-uninitialized values. To make it > > cl

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

2017-02-27 Thread Andrey Utkin
Hi Arnd, Thanks for sending this patch. On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: > tw5864_frameinterval_get() only initializes its output when it successfully > identifies the video standard in tw5864_input. We get a warning here because > gcc can't always track the state if

Re: [PATCH 3/6] [media] solo6x10: improve subscribe event handling

2017-02-23 Thread Andrey Utkin
Hi Gustavo, Thanks for the patches, and sorry for delay. Acked-by: Andrey Utkin

Re: [PATCH 4/6] [media] tw5864: improve subscribe event handling

2017-02-23 Thread Andrey Utkin
Hi Gustavo, Thanks for the patches, and sorry for delay. Acked-by: Andrey Utkin

Re: [PATCH] solo6x10: use designated initializers

2017-01-08 Thread Andrey Utkin
On Fri, Jan 06, 2017 at 01:21:10PM -0800, Kees Cook wrote: > > Since `ops` is static, what about this? > > For the variant given below, you have my signoff. > > > >> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c > >> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c > >> @@ -350,7 +350,7 @@ stati

Re: [PATCH RESEND v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2017-01-04 Thread Andrey Utkin
Manuel, Previous Greg KH reply implied that you should send it marked as v8 for it to gain visibility and avoid confusion. Just prepend your changes history with something like Changes in v8: - Added Reviewed-by, Tested-by statements

Re: [PATCH] solo6x10: use designated initializers

2016-12-19 Thread Andrey Utkin
On Fri, Dec 16, 2016 at 05:05:36PM -0800, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-12-01 Thread Andrey Utkin
On Thu, Dec 01, 2016 at 10:03:23PM +0100, Manuel Schölling wrote: > Hi Andrey, > > On Di, 2016-11-29 at 10:01 +0000, Andrey Utkin wrote: > > On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > > Regarding logout scrollback clearing not working for me. ncurse

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-29 Thread Andrey Utkin
On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > Hi Andrey, > > Adam already discussed some of your notes, but I want to catch up one > this one: > > On So, 2016-11-27 at 21:37 +, Andrey Utkin wrote: > > I see the user experience is subpar to what

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-27 Thread Andrey Utkin
On Mon, Nov 28, 2016 at 12:15:48AM +0100, Adam Borowski wrote: > On Sun, Nov 27, 2016 at 09:37:30PM +0000, Andrey Utkin wrote: > > I've just patched next-20161125 with this set and given it a run. > > > > Scrollback persistence works fine, just as in earlier versions. &

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-27 Thread Andrey Utkin
Hi Manuel, I've just patched next-20161125 with this set and given it a run. Scrollback persistence works fine, just as in earlier versions. This time I didn't forget to test clear operation. The only important concern is that after logout, the scrollback is not wiped by /bin/login or /sbin/age

Re: [PATCH v6 2/2] console: Add persistent scrollback buffers for all VGA consoles

2016-11-22 Thread Andrey Utkin
Well done Manuel. I'm not sure my emails with review of previous submission reached you, but in them I meant to mention that there are some style nits which are easy to eliminate. checkpatch --strict is happy on patch 1/2, but on 2/2 there are few points. If you ever have a reason to submit v7, p

Re: [PATCH v4.2 0/2] console: Add persistent scrollback buffers for all VGA console

2016-11-19 Thread Andrey Utkin
Got into trouble sending my replies to LKML from Mutt, getting delivery rejections related to encoding: https://gist.github.com/andrey-utkin/b204666c34613858a34844283571ce17 Sorry for people who got excessive resends from me. For now I'm sending this from web interface, hopefully it gets t

Re: [PATCH v3] console: Add persistent scrollback buffers for all VGA consoles

2016-11-10 Thread Andrey Utkin
On Mon, Sep 19, 2016 at 12:06:57AM +0200, Manuel Schölling wrote: > Add a scrollback buffers for each VGA console. The benefit is that > the scrollback history is not flushed when switching between consoles > but is persistent. > The buffers are allocated on demand when a new console is opened. Hi

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

2016-10-25 Thread Andrey Utkin
On Mon, Oct 24, 2016 at 10:11:15PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 23:28:44 +0100 > Andrey Utkin escreveu: > > > On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > > > From: Markus Elfring > > > Date

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

2016-10-24 Thread Andrey Utkin
On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 24 Oct 2016 22:08:47 +0200 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus use the corresponding fun

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

2016-10-24 Thread Andrey Utkin
On Mon, Oct 24, 2016 at 05:32:33PM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 28 Sep 2016 07:21:44 +0200 > khal...@piap.pl (Krzysztof Hałasa) escreveu: > > > Andrey Utkin writes: > > > > > Lockup happens only on 6010. In provided log you can see that 6110 >

Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

2016-10-24 Thread Andrey Utkin
On Mon, Oct 24, 2016 at 06:57:25AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin writes: > > > --- a/drivers/media/pci/solo6x10/solo6x10.h > > +++ b/drivers/media/pci/solo6x10/solo6x10.h > > @@ -284,7 +284,10 @@ static inline u32 solo_reg_read(struct solo_dev > > *

Re: [PATCH 1/1] [media] mb86a20s: always initialize a return value

2016-10-23 Thread Andrey Utkin
On Sun, Oct 23, 2016 at 07:09:10PM +0200, Nicolas Iooss wrote: > Hello, > > I sent the following patch (available on > https://patchwork.kernel.org/patch/9325035/) a few weeks ago and got no > feedback even though the bug it fixes seems to still exist in > linux-next. Did I do something wrong? Sho

[PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

2016-10-22 Thread Andrey Utkin
g and barriers") Cc: sta...@vger.kernel.org Signed-off-by: Andrey Utkin --- This is a second submission, the first one was "[PATCH] [media] solo6x10: avoid delayed register write" from 22 Sep 2016, with same content. Dear maintainers - please take this at last into v4.9 if possible.

Re: [PATCH] [media] tw5864: crop picture width to 704

2016-10-17 Thread Andrey Utkin
On Thu, Sep 22, 2016 at 03:04:20AM +0300, Andrey Utkin wrote: > Previously, width of 720 was used, but it gives 16-pixel wide black bar > at right side of encoded picture. > > Signed-off-by: Andrey Utkin > --- > drivers/media/pci/tw5864/tw5864-reg.h | 8 > dri

Re: [PATCH] [media] solo6x10: avoid delayed register write

2016-10-17 Thread Andrey Utkin
On Thu, Sep 22, 2016 at 03:03:31AM +0300, Andrey Utkin wrote: > This fixes a lockup at device probing which happens on some solo6010 > hardware samples. This is a regression introduced by commit e1ceb25a1569 > ("[media] SOLO6x10: remove unneeded register locking and barriers"

[PATCH v1] media: saa7146: Fix for "[BUG] process stuck when closing saa7146 [dvb_ttpci]"

2016-10-17 Thread Andrey Utkin
/0x8f Reported-by: Philipp Matthias Hahn Tested-by: Philipp Matthias Hahn Signed-off-by: Andrey Utkin --- Dear maintainers, Please check whether the used buffer status (DONE) is correct for this situation. I am in doubt, shouldn't it be VIDEOBUF_ERROR? However, ERROR wasn't tested b

Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

2016-10-03 Thread Andrey Utkin
On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote: > static int iss_video_queue_setup(struct vb2_queue *vq, > - unsigned int *count, unsigned int *num_planes, > - unsigned int sizes[], struct device > *alloc_devs[]) > +

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

2016-09-27 Thread Andrey Utkin
On Tue, Sep 27, 2016 at 01:33:49PM +0200, Krzysztof Hałasa wrote: > Thanks. I can see you have quite a set of video devices there. > I will see what I can do with this. Yeah, I have got also 4-chip tw5864 board here :) Bluecherry decided to switch to it because they are available for retail purcha

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

2016-09-27 Thread Andrey Utkin
On Tue, Sep 27, 2016 at 07:27:53AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin writes: > > >> Does (only) adding the > >> > >>pci_read_config_word(solo_dev->pdev, PCI_STATUS, &val); > >> > >> in solo_reg_write() help? > >

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

2016-09-26 Thread Andrey Utkin
On Mon, Sep 26, 2016 at 07:38:05AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin writes: > > > On Thu, Sep 22, 2016 at 10:51:37AM +0200, Krzysztof Hałasa wrote: > >> I wonder if the following fixes the problem (completely untested). > > > > I have given this a r

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

2016-09-22 Thread Andrey Utkin
On Thu, Sep 22, 2016 at 10:52:18PM +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > So you think I should make one "big" patch and resend it? >

Re: [PATCH] kernel/cpu_pm: replace rwlock with raw_spinlock

2016-09-22 Thread Andrey Utkin
On Thu, Sep 22, 2016 at 06:24:19PM +0200, dpervus...@gmail.com wrote: > From: dmitry pervushin > > Recently I faced the BUG in cpuidle driver, "scheduling while atomic" So please show BUG text. > The reason of this BUG is that rwlock behavior gets changed by > RT patches So add RT mailing list

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

2016-09-22 Thread Andrey Utkin
On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. > > Signed-off-by: Jannik Becher > --- > drivers/staging/wlan-ng/p80211req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

2016-09-22 Thread Andrey Utkin
On Thu, Sep 22, 2016 at 10:51:37AM +0200, Krzysztof Hałasa wrote: > I wonder if the following fixes the problem (completely untested). I have given this a run, and it still hangs.

[PATCH] [media] tw5864: crop picture width to 704

2016-09-21 Thread Andrey Utkin
Previously, width of 720 was used, but it gives 16-pixel wide black bar at right side of encoded picture. Signed-off-by: Andrey Utkin --- drivers/media/pci/tw5864/tw5864-reg.h | 8 drivers/media/pci/tw5864/tw5864-video.c | 13 +++-- 2 files changed, 19 insertions(+), 2

[PATCH] [media] solo6x10: avoid delayed register write

2016-09-21 Thread Andrey Utkin
alled from solo_motion_config(). This extra "flushing" is not fundamentally needed for every write, but apparently the code in driver assumes such behaviour at last in some places. Actual fix was proposed by Hans Verkuil. Signed-off-by: Andrey Utkin --- drivers/media/pci/solo6x10/solo6x10.h | 3 ++

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

2016-09-21 Thread Andrey Utkin
On Wed, Sep 21, 2016 at 03:16:57PM +0200, Krzysztof Hałasa wrote: > Hans Verkuil writes: > > > That was probably the reason for the pci_read_config_word in the reg_write > > code. Try putting that back (and just that). > > Yes. I guess a single pci_read_config_word() would suffice. > > Though i

tw5864 - call to hardware owners

2016-09-20 Thread Andrey Utkin
Hi all, I would love to hear from anybody who owns any sample of PCIE board with TW5864 chip. It is possible to buy from here http://www.provideo.com.tw/Products.htm?link=web/DVR%20Card_Hardward.htm I guess there are more companies selling boards with it. So there is a driver, "tw5864", submitte

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

2016-09-15 Thread Andrey Utkin
On Thu, Sep 15, 2016 at 03:15:53PM +0200, Hans Verkuil wrote: > It could be related to the fact that a PCI write may be delayed unless > it is followed by a read (see also the comments in > drivers/media/pci/ivtv/ivtv-driver.h). Thanks for explanation! > That was probably the reason for the pci_

solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

2016-09-15 Thread Andrey Utkin
Hi Krzysztof, Me and one more solo6010 board user experience machine lockup when solo6x10 module is loaded on kernel series starting with 4.3 (despite solo6110 board probes just fine on all kernels). That is, 3.16, 3.18, 4.1 and 4.2 are tested and fine, and 4.3, 4.4, and others up to current linux

Re: [PATCH 0/2] [media] tw5864 constify some structures

2016-09-12 Thread Andrey Utkin
On Tue, Sep 13, 2016 at 02:02:36AM +0300, Andrey Utkin wrote: > tw5864 is a recently submitted driver and it is currently present only > in media tree. Oops, have just fetched linux-next updates, tw5864 is already in next.

[PATCH 0/2] [media] tw5864 constify some structures

2016-09-12 Thread Andrey Utkin
tw5864 is a recently submitted driver and it is currently present only in media tree. Recent patches submitted by Julia Lawall urged me to make similar changes in this driver. Andrey Utkin (2): [media] tw5864: constify vb2_ops structure [media] tw5864: constify struct video_device template

[PATCH 1/2] [media] tw5864: constify vb2_ops structure

2016-09-12 Thread Andrey Utkin
Inspired by "[media] pci: constify vb2_ops structures" patch from Julia Lawall (dated 9 Sep 2016). Signed-off-by: Andrey Utkin --- drivers/media/pci/tw5864/tw5864-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/dri

[PATCH 2/2] [media] tw5864: constify struct video_device template

2016-09-12 Thread Andrey Utkin
tw5864_video_template is used for filling of actual video_device structures. It is copied by value, and is not used for anything else. Signed-off-by: Andrey Utkin --- drivers/media/pci/tw5864/tw5864-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci

Re: [PATCH] [media] pci: constify vb2_ops structures

2016-09-09 Thread Andrey Utkin
On Fri, Sep 09, 2016 at 10:31:30PM +0800, Julia Lawall wrote: > Will this soon reach linux-next? No idea. Indeed it's simpler if you leave your patch as is, and then later we patch this new driver separately.

Re: [PATCH] [media] pci: constify vb2_ops structures

2016-09-09 Thread Andrey Utkin
2 +- > 13 files changed, 13 insertions(+), 13 deletions(-) Applies and compiles cleanly on media tree. But please regenerate this patch on git://linuxtv.org/media_tree.git - it has a new driver by me, drivers/media/pci/tw5864 , which is affected. Otherwise Acked-by: Andrey Utkin (however this time I'm writing from another email.)

Re: [PATCH] [media] pci: constify snd_pcm_ops structures

2016-09-07 Thread Andrey Utkin
Thanks for looking into this. I have tested that it compiles and passes checks (C=2) cleanly after this patch. Acked-by: Andrey Utkin While we're at it, what about constification of *-core.c:static struct pci_driver *_pci_driver = { *-video.c:static struct vb2_ops *_video

Re: [PATCH] staging: dgnc: Fix multi line comment alignment

2016-09-06 Thread Andrey Utkin
On Tue, Sep 06, 2016 at 03:19:03PM +0200, Fernando Apesteguia wrote: > Sorry, but I fail to see how I can align all the lines by changing just the > first and last ones. Ah now I see that original version doesn't have spaces before asterisk. Sorry for noise.

Re: [PATCH] staging: dgnc: Fix multi line comment alignment

2016-09-05 Thread Andrey Utkin
On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote: > Fix alignment in multi line comment block. > > Remove extra '*' to use the preferred comment style as in > Documentation/CodingStyle > > Signed-off-by: Fernando Apesteguia > > --- > drivers/staging/dgnc/dgnc_driver.c | 50

Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning

2016-08-26 Thread Andrey Utkin
On Fri, Aug 26, 2016 at 06:35:51PM -0400, Anson Jacob wrote: > I only found one trailing whitespace issue in the patchset. Yes, there's just one. > Are my commits are too long. Am I supposed to submit shorter ones. In my opinion your commits are generally fine.

Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning

2016-08-26 Thread Andrey Utkin
On Fri, Aug 26, 2016 at 02:33:08PM -0400, Anson Jacob wrote: > > - /* Default_FS contains the full scale that is used if the user does */ > - /* not set a full scale. */ > + /* Applying: staging: comedi: jr3_pci.h: Fix checkpatch warning .git/rebase-apply/patch:226: trailing whitesp

[PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()

2016-08-26 Thread Andrey Utkin
] [] (load_module) from [] (SyS_finit_module+0x51/0x74) [8.843135] [] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18) Signed-off-by: Andrey Utkin --- drivers/gpu/drm/omapdrm/dss/dss-of.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c b

Re: [PATCH 6/6] staging: comedi: ni_at_a2150.c: Fix checkpatch warning

2016-08-25 Thread Andrey Utkin
On Thu, Aug 25, 2016 at 12:09:23PM -0400, Anson Jacob wrote: > On Thu, Aug 25, 2016 at 06:47:08PM +0300, Andrey Utkin wrote: > > > > > +#define CHANNEL_BITS(x) ((x) & 0x7) > > > +#define CHANNEL_MASK 0x7 > > > > No uniform alignm

Re: [PATCH 6/6] staging: comedi: ni_at_a2150.c: Fix checkpatch warning

2016-08-25 Thread Andrey Utkin
On Thu, Aug 25, 2016 at 11:16:13AM -0400, Anson Jacob wrote: > Fix checkpatch.pl warning 'line over 80 characters' > > Signed-off-by: Anson Jacob > --- > drivers/staging/comedi/drivers/ni_at_a2150.c | 82 > > 1 file changed, 46 insertions(+), 36 deletions(-) > > di

Re: [PATCH] staging: android: lowmemorykiller.c: Fix checkpatch warning

2016-08-25 Thread Andrey Utkin
On Thu, Aug 25, 2016 at 11:10:25AM -0400, Anson Jacob wrote: > Fix checkpatch.pl 'line over 80 characters' warning > > Signed-off-by: Anson Jacob > --- > drivers/staging/android/lowmemorykiller.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/androi

[PATCH] [media] tw5864-core: remove excessive irqsave

2016-08-24 Thread Andrey Utkin
having two calls is correct, but second irqsave is superfluous, and using same "flags" variable is just wrong. Reported-by: Mauro Carvalho Chehab Signed-off-by: Andrey Utkin --- drivers/media/pci/tw5864/tw5864-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

Re: [Letux-kernel] [BUG] 4.8-rc1: wlcore: NULL pointer dereference in wlcore_op_get_expected_throughput

2016-08-08 Thread Andrey Utkin
On Mon, Aug 08, 2016 at 11:26:38PM +0200, H. Nikolaus Schaller wrote: > Here is what I see in 4.8-rc1 on Pyra device after typing "poweroff". > I hope someone knows what it means. > > BR and thanks, > Nikolaus > > root@letux:~# poweroff > > Broadcast message from root@letux (pts/0) (Mon Aug 8 2

Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

2016-07-12 Thread Andrey Utkin
Found and fixed few very minor coding style nits, will resubmit in few days, now still waiting for comments to v4. https://github.com/bluecherrydvr/linux/commits/tw5864 commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390 Author: Andrey Utkin Date: Wed Jul 13 05:00:28 2016 +0300 Fix

Re: [PATCH v4] [media] pci: Add tw5864 driver

2016-07-12 Thread Andrey Utkin
On Mon, Jul 11, 2016 at 09:40:53AM -0700, Joe Perches wrote: > Each of these blocks will start with the dev_ prefix > and the subsequent lines will not have the same prefix Yes. I have checked how it looks before submitting, but I didn't see this as a problem. I don't mind changing that (anyway I

Re: [PATCH v3] Add tw5864 driver

2016-07-11 Thread Andrey Utkin
Thanks for review Hans! On Mon, Jul 11, 2016 at 07:58:38AM +0200, Hans Verkuil wrote: > > +" v4l2-ctl --device $dev --set-ctrl=video_gop_size=1; done\n" > > Replace $dev by /dev/videoX > > Wouldn't it make more sense to default to this? And show the warning only if > P-frames are enabled? I bel

[PATCH] media: solo6x10: increase FRAME_BUF_SIZE

2016-07-09 Thread Andrey Utkin
In practice, devices sometimes return frames larger than current buffer size, leading to failure in solo_send_desc(). It is not clear which minimal increase in buffer size would be enough, so this patch doubles it, this should be safely assumed as sufficient. Signed-off-by: Andrey Utkin

Re: [PATCH v2] Add tw5864 driver

2016-07-09 Thread Andrey Utkin
known video quality issues in a printed warning..."). On Fri, Jul 01, 2016 at 03:35:40PM +0200, Hans Verkuil wrote: > On 06/10/2016 12:11 AM, Andrey Utkin wrote: > > + cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS; > > This line can be dropped: the v4l2

Re: [PATCH v3 1/2] drivers: led: is31fl319x: 1/3/6/9-channel light effect led driver

2016-07-08 Thread Andrey Utkin
On Fri, Jul 08, 2016 at 09:49:37PM +0200, H. Nikolaus Schaller wrote: > +static int is31fl319x_microamp_to_cs(u32 microamp) > +{ > + switch (microamp) { > + default: > + WARN(1, "Invalid microamp setting"); > + case 2: return 0; > + case 15000: return 1; > + case

Re: [Kernel] Mainlining of Pyra nub joystick driver

2016-06-16 Thread Andrey Utkin
On Tue, Jun 14, 2016 at 07:09:50PM +0200, H. Nikolaus Schaller wrote: > > > Am 14.06.2016 um 19:02 schrieb Andrey Utkin : > > Update: found drivers/input/joystick/as5011.c in mainline kernel, > > will look how it works with as5013 hardware. > > Before you spend too muc

Re: [Kernel] Mainlining of Pyra nub joystick driver

2016-06-14 Thread Andrey Utkin
On Tue, Jun 14, 2016 at 02:45:23PM +0300, Andrey Utkin wrote: > There's a pair of "nub" devices on Pyra handheld PC > ... Update: found drivers/input/joystick/as5011.c in mainline kernel, will look how it works with as5013 hardware.

Mainlining of Pyra nub joystick driver

2016-06-14 Thread Andrey Utkin
There's a pair of "nub" devices on Pyra handheld PC (https://pyra-handheld.com/), and there's driver for nub, which is going to be reworked for upstreaming. While the device itself fits most to "joystick" category, the computer itself lacks touchpad and mouse buttons, and the existing driver is cap

Re: [PATCH v2] Add tw5864 driver

2016-06-12 Thread Andrey Utkin
Update: added local change - to require fewer DMA buffers; - to require fewer vb2_queue buffers; - don't require vb2_queue buffers to be DMA-capable. https://github.com/bluecherrydvr/linux/commit/410a86b08d230ff2a401ac9f5be3b30f8b29f30d

How should I use kernel-defined i2c structs in this driver

2016-05-26 Thread Andrey Utkin
Could anybody please give a hint - which kernel-defined i2c objects, and how many of them, I need to define and use to substitute these driver-defined functions i2c_read(), i2c_write() ? https://github.com/bluecherrydvr/linux/blob/release/tw5864/1.16/drivers/media/pci/tw5864/tw5864-config.c In a wo

Re: [PATCH v2] Enhance kvmconfig

2016-05-09 Thread Andrey Utkin
On Mon, May 09, 2016 at 02:16:55PM +0200, Paolo Bonzini wrote: > I think adding virtio storage is a good idea for "make kvmconfig". > > virtio-input is not _that_ useful on x86, but it's getting more useful > (recent QEMU can pass evdev events directly to a VM via virtio-input). > I'm ambivalent a

[PATCH v3] Enhance kvmconfig

2016-05-09 Thread Andrey Utkin
From: Andrey Utkin "make defconfig kvmconfig" is supposed to end up with usable kernel for KVM guest. In practice, it won't work for e.g. Hetzner VPS (KVM-based) unless you add these options. Signed-off-by: Andrey Utkin --- v3: dropped VIRTIO_MMIO stuff as suggested by Paolo

Re: [PATCH v2] Enhance kvmconfig

2016-04-24 Thread Andrey Utkin
On Sun, Apr 24, 2016 at 10:51:29PM +0200, Borislav Petkov wrote: > On Sun, Apr 24, 2016 at 11:35:53PM +0300, Andrey Utkin wrote: > > Could you please test "make defconfig kvmconfig" how it boots? > > The point of my patch is to enable user to end up with working kernel

Re: [PATCH v2] Enhance kvmconfig

2016-04-24 Thread Andrey Utkin
On Sun, Apr 24, 2016 at 10:18:35PM +0200, Borislav Petkov wrote: > On Sun, Apr 24, 2016 at 10:57:37PM +0300, Andrey Utkin wrote: > > So current "make defconfig kvmconfig" works for you? > > I don't do that - I do > > make oldconfig > make kvmconfig > &

Re: [PATCH v2] Enhance kvmconfig

2016-04-24 Thread Andrey Utkin
On Sun, Apr 24, 2016 at 06:30:46PM +0200, Borislav Petkov wrote: > Frankly, I'm still not sure we want to do this. Apparently, virtio is > the way to go on kvm but it is not absolutely necessary to get a booting > guest. So current "make defconfig kvmconfig" works for you?

[PATCH v2] Enhance kvmconfig

2016-04-23 Thread Andrey Utkin
at lot of sense as enabled by default, feel free to ask me to drop some and test how it works. Thanks. ---8<--- "make defconfig kvmconfig" is supposed to end up with usable kernel for KVM guest. In practice, it won't work for e.g. Hetzner VPS (KVM-based) unless you add these options.

[PATCH] Enhance kvmconfig

2016-04-23 Thread Andrey Utkin
and test how it works. Thanks. ---8<--- "make defconfig kvmconfig" is supposed to end up with usable kernel for KVM guest. In practice, it won't work for e.g. Hetzner VPS (KVM-based) unless you add these options. Signed-off-by: Andrey Utkin --- arch/x86/configs/kvm_guest.

[PATCH] Add tw5864 driver - cover letter

2016-03-13 Thread Andrey Utkin
From: Andrey Utkin This is a driver for multimedia devices based on Techwell/Intersil TW5864 chip. It is basically written from scratch. There was an awful reference driver for 2.6 kernel, which is nearly million lines of code and requires half a dozen special userspace libraries, and still

[PATCH] Add tw5864 driver - cover letter

2016-03-13 Thread Andrey Utkin
larly contacting manufacturer regarding such issues, but unfortunately they can do little to help us. Andrey Utkin (1): Add tw5864 driver MAINTAINERS |7 + drivers/staging/media/Kconfig|2 + drivers/staging/media/Makefile |

Re: [RFC PATCH v0] Add tw5864 driver

2016-03-11 Thread Andrey Utkin
On Fri, 11 Mar 2016 10:59:02 +0100 Hans Verkuil wrote: > While userspace may specify FIELD_ANY when setting a format, the > driver should always map that to a specific field setting and should > never return FIELD_ANY back to userspace. > > In this case, the 'field' field of the v4l2_buffer struc

Re: [RFC PATCH v0] Add tw5864 driver

2016-03-11 Thread Andrey Utkin
On Fri, 11 Mar 2016 09:00:18 +0100 Hans Verkuil wrote: > The reason is likely to be the tw5864_queue_setup function which has > not been updated to handle CREATE_BUFS support correctly. It should > look like this: > > static int tw5864_queue_setup(struct vb2_queue *q, >

Re: [RFC PATCH v0] Add tw5864 driver

2016-03-09 Thread Andrey Utkin
Hi Hans! Some improvements took place on the driver, including cleaner v4l2-compliance tests passing. But there's a single test failure I don't understand. In the code of v4l2-compliance, it seems like an API call CREATE_BUFS is supposed to fail with EINVAL. But in case of my driver, which simply

Re: [RFC PATCH v0] Add tw5864 driver

2016-02-08 Thread Andrey Utkin
On Mon, Feb 8, 2016 at 11:58 AM, Hans Verkuil wrote: > Hi Andrey, > > Hmm, it looks like I forgot to reply. Sorry about that. Thank you very much anyway. > I wouldn't change the memcpy: in my experience it is very useful to get a > well-formed compressed stream out of the hardware. And the overh

Email handling - please share what tools you use

2016-02-06 Thread Andrey Utkin
fline work with full copy of mailbox - OpenPGP support - Sieve integration (spam marking, easy folders management for maillists) END PERSONAL COMPLAINTS = [0] https://gist.github.com/andrey-utkin/df143baf1763330c0f45 [1] https://lkml.org/lkml/2016/1/3/148 [2] https://bugzilla.mozilla.org/sho

Re: "git send-email" thru Gmail incurs few minutes delay

2016-01-05 Thread Andrey Utkin
On Tue, Jan 5, 2016 at 1:27 PM, Geert Uytterhoeven wrote: > Does it work better if you store the (preferably app-specific) password in > smtppass in .gitconfig? No. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

"git send-email" thru Gmail incurs few minutes delay

2016-01-03 Thread Andrey Utkin
After "Send this email? ([y]es|[n]o|[q]uit|[a]ll): y" prompt and before "Password for 'smtp://x...@gmail.com@smtp.gmail.com:587':" prompt I always have a delay of 2-3 minutes. It is weird! "Unsafe clients" are allowed in Gmail settings. I experience this both with @gmail.com mailbox and with gmail-

Re: [RFC PATCH v0] Add tw5864 driver

2016-01-03 Thread Andrey Utkin
FIG_DYNAMIC_DEBUG) so I can wrap my stats variables into this statement instead. But such change is not equivalent - I guess CONFIG_DYNAMIC_DEBUG is common to be enabled, so debug stats will be always calculated, even when module is not under debug. Except if I use DEFINE_DYNAMIC_DEBUG_METADATA etc.

Re: On Lindent shortcomings and massive style fixing

2015-12-29 Thread Andrey Utkin
On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab wrote: > IMHO, there are two problems by letting indent breaking long > lines: > > 1) indent would break strings on printks. This is something that we don't > want to break strings on multiple lines in the Kernel; Yeah, GNU indent does its wo

On Lindent shortcomings and massive style fixing

2015-12-28 Thread Andrey Utkin
here it is: https://github.com/bluecherrydvr/linux.git , branch tw5864_stable, drivers/staging/media/tw5864 Current output of "checkpatch.pl -f" for all source files in the driver is here: https://gist.github.com/andrey-utkin/12295148475e34ef948b Thanks in advance. -- To unsubscribe from thi

[RFC] In-kernel fuzz testing for apps

2015-11-18 Thread Andrey Utkin
Me and my friend have once talked about careful application development, which includes awareness about all possible error conditions. So we have collected ideas about making kernel (or, in some cases, libc) "hostile" to careless application, and we present it so that the idea doesn't get lost, and

Req for mentor - [BUG]Busy luks disk not closable forever if medium is removed

2015-11-10 Thread Andrey Utkin
https://bugzilla.kernel.org/show_bug.cgi?id=107641 I believe it is an issue which should _better_ be fixed in kernel. My level of knowledge doesn't allow me to identify the location to work on, however, I am interested to work on this. Any help, ideas, thoughts, comments are appreciated. Thanks.

H264 headers generation for driver

2015-09-29 Thread Andrey Utkin
This is a new chapter of tw5864 video grabber & encoder driver development drama. Last state of code is here (tw5864 branch, drivers/staging/media/tw5864): https://github.com/bluecherrydvr/linux/tree/tw5864/drivers/staging/media/tw5864 Currently I use a third-side LGPL library for H.264 headers ge

Re: tw5864 driver development, help needed

2015-07-18 Thread Andrey Utkin
An update: see there: http://ffmpeg.org/pipermail/ffmpeg-devel/2015-July/175796.html -- Bluecherry developer. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: tw5864 driver development, help needed

2015-07-14 Thread Andrey Utkin
An update with a request for help. Asking for help with h264 headers generation. Both copying headers from similar videos and porting headers generation code from reference driver don't work for me (ref driver is weird and very complicated, so porting involved importing of lots of code, but still

Re: tw5864 driver development, help needed

2015-07-08 Thread Andrey Utkin
On Fri, Jul 3, 2015 at 5:23 PM, Andrey Utkin wrote: > Up... we are moving much slower than we expected, desperately needing help. > > Running reference driver with Ubuntu 9 (with kernel 2.6.28.10) with > 16-port card shows that the > reference driver fails to work with it corre

  1   2   3   >