Doc.../sound/soc/platform.rst: snd_soc_platform_driver out of sync

Hi maintainers of Sound and/or Docs. Documentation/sound/soc/platform.rst quotes outdated definition of "struct snd_soc_platform_driver". I spotted this because it shows like there are suspend/resume function pointers while this is no longer true. I don't have a good idea how to update the doc,

Doc.../sound/soc/platform.rst: snd_soc_platform_driver out of sync

Hi maintainers of Sound and/or Docs. Documentation/sound/soc/platform.rst quotes outdated definition of "struct snd_soc_platform_driver". I spotted this because it shows like there are suspend/resume function pointers while this is no longer true. I don't have a good idea how to update the doc,

Re: [PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

Hi Anton, Nothing serious, just some purist nitpicking below. On Wed, Aug 02, 2017 at 06:17:02PM +0400, Anton Sviridenko wrote: > 24 GPIO pins from 32 available on solo6x10 chips are exported > to gpiolib. First 8 GPIOs are reserved for internal use on capture card > boards, GPIOs in range 8:15

Re: [PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

Hi Anton, Nothing serious, just some purist nitpicking below. On Wed, Aug 02, 2017 at 06:17:02PM +0400, Anton Sviridenko wrote: > 24 GPIO pins from 32 available on solo6x10 chips are exported > to gpiolib. First 8 GPIOs are reserved for internal use on capture card > boards, GPIOs in range 8:15

Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

Colin Ian King <colin.k...@canonical.com> Acked-by: Andrey Utkin <andrey_ut...@fastmail.com>

Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

bss dec hex filename >9218 360 09578256a solo6x10-tw28.o > > After: >text data bss dec hex filename >8237 504 087412225 solo6x10-tw28.o > > Signed-off-by: Colin Ian King Acked-by: Andrey Utkin

Re: [PATCH] [media] solo6x10: fix detection of TW2864B chips

on these cards with > > [276582.344942] solo6x10 :07:00.0: Probing Softlogic 6110 > [276582.402151] solo6x10 :07:00.0: Could not initialize any techwell chips > [276582.402781] solo6x10: probe of :07:00.0 failed with error -22 > > Signed-off-by: Anton Sviridenko <

Re: [PATCH] [media] solo6x10: fix detection of TW2864B chips

on these cards with > > [276582.344942] solo6x10 :07:00.0: Probing Softlogic 6110 > [276582.402151] solo6x10 :07:00.0: Could not initialize any techwell chips > [276582.402781] solo6x10: probe of :07:00.0 failed with error -22 > > Signed-off-by: Anton Sviridenko Acked-by:

[PATCH 2/2] MAINTAINERS: solo6x10: update Andrey Utkin email

Updating my personal email address in solo6x10. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 026af206660b..885badfa4fa7 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH 2/2] MAINTAINERS: solo6x10: update Andrey Utkin email

Updating my personal email address in solo6x10. Signed-off-by: Andrey Utkin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 026af206660b..885badfa4fa7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11966,7 +11966,7 @@ SOFTLOGIC

[PATCH 1/2] MAINTAINERS: solo6x10, tw5864: add Anton Sviridenko

Anton Sviridenko is now in charge of drivers in Bluecherry. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bdd1fe5..026af206660b 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH 1/2] MAINTAINERS: solo6x10, tw5864: add Anton Sviridenko

Anton Sviridenko is now in charge of drivers in Bluecherry. Signed-off-by: Andrey Utkin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bdd1fe5..026af206660b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11964,6 +11964,7 @@ F

Re: [PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

On Tue, Aug 23, 2016 at 07:18:53PM -0300, Lucas De Marchi wrote: > From: José Roberto de Souza > > If we aren't going to continue using the controller we can just disable > it instead of waiting for it to complete. The biggest improvement here > is when a I2C transaction is

Re: [PATCH v4 1/4] i2c: designware: wait for disable/enable only if necessary

On Tue, Aug 23, 2016 at 07:18:53PM -0300, Lucas De Marchi wrote: > From: José Roberto de Souza > > If we aren't going to continue using the controller we can just disable > it instead of waiting for it to complete. The biggest improvement here > is when a I2C transaction is completed and it

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote: > 4.10-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Zhang Rui > > commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream. > > With commit

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote: > 4.10-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Zhang Rui > > commit e28d6f048799acb0014491e6b74e580d84bd7916 upstream. > > With commit 67bf5156edc4 ("gpio /

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> Signed-off-by: Andrey Utkin <andrey_ut...@fastmail.com> Please welcome Anton who is now in charge of solo6x10 and tw5864 support and development in Bluecherry company, I have sent out to him the hardware samples I po

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

Signed-off-by: Andrey Utkin Signed-off-by: Andrey Utkin Please welcome Anton who is now in charge of solo6x10 and tw5864 support and development in Bluecherry company, I have sent out to him the hardware samples I possessed. (We will prepare the patch updating MAINTAINERS file soon

Re: [PATCH] [media] tw5864: use dev_warn instead of WARN to shut up warning

on is correct. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks for the patch. Acked-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> See the note below. > --- > drivers/media/pci/tw5864/tw5864-video.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions

Re: [PATCH] [media] tw5864: use dev_warn instead of WARN to shut up warning

on is correct. > > Signed-off-by: Arnd Bergmann Thanks for the patch. Acked-by: Andrey Utkin See the note below. > --- > drivers/media/pci/tw5864/tw5864-video.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/pci/tw5864/tw5864-

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

On Tue, Feb 28, 2017 at 09:20:53AM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin > <andrey.ut...@corp.bluecherry.net> wrote: > > Retcode checking takes place everywhere, but currently it overwrites > > supplied structs with potentially-unini

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

On Tue, Feb 28, 2017 at 09:20:53AM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin > wrote: > > Retcode checking takes place everywhere, but currently it overwrites > > supplied structs with potentially-uninitialized values. To make it > > cl

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

Hi Arnd, Thanks for sending this patch. On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: > tw5864_frameinterval_get() only initializes its output when it successfully > identifies the video standard in tw5864_input. We get a warning here because > gcc can't always track the state

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

Hi Arnd, Thanks for sending this patch. On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: > tw5864_frameinterval_get() only initializes its output when it successfully > identifies the video standard in tw5864_input. We get a warning here because > gcc can't always track the state

Re: [PATCH 3/6] [media] solo6x10: improve subscribe event handling

Hi Gustavo, Thanks for the patches, and sorry for delay. Acked-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net>

Re: [PATCH 3/6] [media] solo6x10: improve subscribe event handling

Hi Gustavo, Thanks for the patches, and sorry for delay. Acked-by: Andrey Utkin

Re: [PATCH 4/6] [media] tw5864: improve subscribe event handling

Hi Gustavo, Thanks for the patches, and sorry for delay. Acked-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net>

Re: [PATCH 4/6] [media] tw5864: improve subscribe event handling

Hi Gustavo, Thanks for the patches, and sorry for delay. Acked-by: Andrey Utkin

Re: [PATCH] solo6x10: use designated initializers

On Fri, Jan 06, 2017 at 01:21:10PM -0800, Kees Cook wrote: > > Since `ops` is static, what about this? > > For the variant given below, you have my signoff. > > > >> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c > >> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c > >> @@ -350,7 +350,7 @@

Re: [PATCH] solo6x10: use designated initializers

On Fri, Jan 06, 2017 at 01:21:10PM -0800, Kees Cook wrote: > > Since `ops` is static, what about this? > > For the variant given below, you have my signoff. > > > >> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c > >> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c > >> @@ -350,7 +350,7 @@

Re: [PATCH RESEND v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Manuel, Previous Greg KH reply implied that you should send it marked as v8 for it to gain visibility and avoid confusion. Just prepend your changes history with something like Changes in v8: - Added Reviewed-by, Tested-by statements

Re: [PATCH RESEND v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Manuel, Previous Greg KH reply implied that you should send it marked as v8 for it to gain visibility and avoid confusion. Just prepend your changes history with something like Changes in v8: - Added Reviewed-by, Tested-by statements

Re: [PATCH] solo6x10: use designated initializers

On Fri, Dec 16, 2016 at 05:05:36PM -0800, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from

Re: [PATCH] solo6x10: use designated initializers

On Fri, Dec 16, 2016 at 05:05:36PM -0800, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Thu, Dec 01, 2016 at 10:03:23PM +0100, Manuel Schölling wrote: > Hi Andrey, > > On Di, 2016-11-29 at 10:01 +0000, Andrey Utkin wrote: > > On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > > Regarding logout scrollback clearing not working for me. ncurse

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Thu, Dec 01, 2016 at 10:03:23PM +0100, Manuel Schölling wrote: > Hi Andrey, > > On Di, 2016-11-29 at 10:01 +0000, Andrey Utkin wrote: > > On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > > Regarding logout scrollback clearing not working for me. ncurse

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > Hi Andrey, > > Adam already discussed some of your notes, but I want to catch up one > this one: > > On So, 2016-11-27 at 21:37 +, Andrey Utkin wrote: > > I see the user experience is subpar to what

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Nov 28, 2016 at 10:28:19PM +0100, Manuel Schölling wrote: > Hi Andrey, > > Adam already discussed some of your notes, but I want to catch up one > this one: > > On So, 2016-11-27 at 21:37 +, Andrey Utkin wrote: > > I see the user experience is subpar to what

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Nov 28, 2016 at 12:15:48AM +0100, Adam Borowski wrote: > On Sun, Nov 27, 2016 at 09:37:30PM +0000, Andrey Utkin wrote: > > I've just patched next-20161125 with this set and given it a run. > > > > Scrollback persistence works fine, just as in earlier versions. > &

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Nov 28, 2016 at 12:15:48AM +0100, Adam Borowski wrote: > On Sun, Nov 27, 2016 at 09:37:30PM +0000, Andrey Utkin wrote: > > I've just patched next-20161125 with this set and given it a run. > > > > Scrollback persistence works fine, just as in earlier versions. > &

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Manuel, I've just patched next-20161125 with this set and given it a run. Scrollback persistence works fine, just as in earlier versions. This time I didn't forget to test clear operation. The only important concern is that after logout, the scrollback is not wiped by /bin/login or

Re: [PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

Hi Manuel, I've just patched next-20161125 with this set and given it a run. Scrollback persistence works fine, just as in earlier versions. This time I didn't forget to test clear operation. The only important concern is that after logout, the scrollback is not wiped by /bin/login or

Re: [PATCH v6 2/2] console: Add persistent scrollback buffers for all VGA consoles

Well done Manuel. I'm not sure my emails with review of previous submission reached you, but in them I meant to mention that there are some style nits which are easy to eliminate. checkpatch --strict is happy on patch 1/2, but on 2/2 there are few points. If you ever have a reason to submit v7,

Re: [PATCH v6 2/2] console: Add persistent scrollback buffers for all VGA consoles

Well done Manuel. I'm not sure my emails with review of previous submission reached you, but in them I meant to mention that there are some style nits which are easy to eliminate. checkpatch --strict is happy on patch 1/2, but on 2/2 there are few points. If you ever have a reason to submit v7,

Re: [PATCH v4.2 0/2] console: Add persistent scrollback buffers for all VGA console

Got into trouble sending my replies to LKML from Mutt, getting delivery rejections related to encoding: https://gist.github.com/andrey-utkin/b204666c34613858a34844283571ce17 Sorry for people who got excessive resends from me. For now I'm sending this from web interface, hopefully it gets things

Re: [PATCH v4.2 0/2] console: Add persistent scrollback buffers for all VGA console

Got into trouble sending my replies to LKML from Mutt, getting delivery rejections related to encoding: https://gist.github.com/andrey-utkin/b204666c34613858a34844283571ce17 Sorry for people who got excessive resends from me. For now I'm sending this from web interface, hopefully it gets things

Re: [PATCH v3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Sep 19, 2016 at 12:06:57AM +0200, Manuel Schölling wrote: > Add a scrollback buffers for each VGA console. The benefit is that > the scrollback history is not flushed when switching between consoles > but is persistent. > The buffers are allocated on demand when a new console is opened.

Re: [PATCH v3] console: Add persistent scrollback buffers for all VGA consoles

On Mon, Sep 19, 2016 at 12:06:57AM +0200, Manuel Schölling wrote: > Add a scrollback buffers for each VGA console. The benefit is that > the scrollback history is not flushed when switching between consoles > but is persistent. > The buffers are allocated on demand when a new console is opened.

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, Oct 24, 2016 at 10:11:15PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 23:28:44 +0100 > Andrey Utkin <andrey_ut...@fastmail.com> escreveu: > > > On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > > > From: Markus Elfring

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, Oct 24, 2016 at 10:11:15PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 23:28:44 +0100 > Andrey Utkin escreveu: > > > On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > > > From: Markus Elfring > > > Date

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 24 Oct 2016 22:08:47 +0200 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. >

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 24 Oct 2016 22:08:47 +0200 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus use the corresponding

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Mon, Oct 24, 2016 at 05:32:33PM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 28 Sep 2016 07:21:44 +0200 > khal...@piap.pl (Krzysztof Hałasa) escreveu: > > > Andrey Utkin <andrey_ut...@fastmail.com> writes: > > > > > Lockup happens only on 6010. I

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Mon, Oct 24, 2016 at 05:32:33PM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 28 Sep 2016 07:21:44 +0200 > khal...@piap.pl (Krzysztof Hałasa) escreveu: > > > Andrey Utkin writes: > > > > > Lockup happens only on 6010. In provided log you can see that 6110 >

Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

On Mon, Oct 24, 2016 at 06:57:25AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin <andrey.ut...@corp.bluecherry.net> writes: > > > --- a/drivers/media/pci/solo6x10/solo6x10.h > > +++ b/drivers/media/pci/solo6x10/solo6x10.h > > @@ -284,7 +284,10 @@ static inline u32

Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

On Mon, Oct 24, 2016 at 06:57:25AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin writes: > > > --- a/drivers/media/pci/solo6x10/solo6x10.h > > +++ b/drivers/media/pci/solo6x10/solo6x10.h > > @@ -284,7 +284,10 @@ static inline u32 solo_reg_read(struct solo_dev > > *

Re: [PATCH 1/1] [media] mb86a20s: always initialize a return value

On Sun, Oct 23, 2016 at 07:09:10PM +0200, Nicolas Iooss wrote: > Hello, > > I sent the following patch (available on > https://patchwork.kernel.org/patch/9325035/) a few weeks ago and got no > feedback even though the bug it fixes seems to still exist in > linux-next. Did I do something wrong?

Re: [PATCH 1/1] [media] mb86a20s: always initialize a return value

On Sun, Oct 23, 2016 at 07:09:10PM +0200, Nicolas Iooss wrote: > Hello, > > I sent the following patch (available on > https://patchwork.kernel.org/patch/9325035/) a few weeks ago and got no > feedback even though the bug it fixes seems to still exist in > linux-next. Did I do something wrong?

[PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

g and barriers") Cc: sta...@vger.kernel.org Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- This is a second submission, the first one was "[PATCH] [media] solo6x10: avoid delayed register write" from 22 Sep 2016, with same content. Dear maintainers - please tak

[PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

g and barriers") Cc: sta...@vger.kernel.org Signed-off-by: Andrey Utkin --- This is a second submission, the first one was "[PATCH] [media] solo6x10: avoid delayed register write" from 22 Sep 2016, with same content. Dear maintainers - please take this at last into v4.9 if possibl

Re: [PATCH] [media] tw5864: crop picture width to 704

On Thu, Sep 22, 2016 at 03:04:20AM +0300, Andrey Utkin wrote: > Previously, width of 720 was used, but it gives 16-pixel wide black bar > at right side of encoded picture. > > Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> > --- > drivers/media/pci/tw

Re: [PATCH] [media] tw5864: crop picture width to 704

On Thu, Sep 22, 2016 at 03:04:20AM +0300, Andrey Utkin wrote: > Previously, width of 720 was used, but it gives 16-pixel wide black bar > at right side of encoded picture. > > Signed-off-by: Andrey Utkin > --- > drivers/media/pci/tw5864/tw5864-reg.h | 8 > dri

Re: [PATCH] [media] solo6x10: avoid delayed register write

On Thu, Sep 22, 2016 at 03:03:31AM +0300, Andrey Utkin wrote: > This fixes a lockup at device probing which happens on some solo6010 > hardware samples. This is a regression introduced by commit e1ceb25a1569 > ("[media] SOLO6x10: remove unneeded register locking and barriers"

Re: [PATCH] [media] solo6x10: avoid delayed register write

On Thu, Sep 22, 2016 at 03:03:31AM +0300, Andrey Utkin wrote: > This fixes a lockup at device probing which happens on some solo6010 > hardware samples. This is a regression introduced by commit e1ceb25a1569 > ("[media] SOLO6x10: remove unneeded register locking and barriers"

[PATCH v1] media: saa7146: Fix for "[BUG] process stuck when closing saa7146 [dvb_ttpci]"

x8f Reported-by: Philipp Matthias Hahn <pmhahn+vi...@pmhahn.de> Tested-by: Philipp Matthias Hahn <pmhahn+vi...@pmhahn.de> Signed-off-by: Andrey Utkin <andrey_ut...@fastmail.com> --- Dear maintainers, Please check whether the used buffer status (DONE) is correct for this situ

[PATCH v1] media: saa7146: Fix for "[BUG] process stuck when closing saa7146 [dvb_ttpci]"

x8f Reported-by: Philipp Matthias Hahn Tested-by: Philipp Matthias Hahn Signed-off-by: Andrey Utkin --- Dear maintainers, Please check whether the used buffer status (DONE) is correct for this situation. I am in doubt, shouldn't it be VIDEOBUF_ERROR? However, ERROR wasn't tested by Philipp and I

Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote: > static int iss_video_queue_setup(struct vb2_queue *vq, > - unsigned int *count, unsigned int *num_planes, > - unsigned int sizes[], struct device > *alloc_devs[]) > +

Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote: > static int iss_video_queue_setup(struct vb2_queue *vq, > - unsigned int *count, unsigned int *num_planes, > - unsigned int sizes[], struct device > *alloc_devs[]) > +

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Tue, Sep 27, 2016 at 01:33:49PM +0200, Krzysztof Hałasa wrote: > Thanks. I can see you have quite a set of video devices there. > I will see what I can do with this. Yeah, I have got also 4-chip tw5864 board here :) Bluecherry decided to switch to it because they are available for retail

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Tue, Sep 27, 2016 at 01:33:49PM +0200, Krzysztof Hałasa wrote: > Thanks. I can see you have quite a set of video devices there. > I will see what I can do with this. Yeah, I have got also 4-chip tw5864 board here :) Bluecherry decided to switch to it because they are available for retail

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Tue, Sep 27, 2016 at 07:27:53AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin <andrey_ut...@fastmail.com> writes: > > >> Does (only) adding the > >> > >>pci_read_config_word(solo_dev->pdev, PCI_STATUS, ); > >> > >> in s

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Tue, Sep 27, 2016 at 07:27:53AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin writes: > > >> Does (only) adding the > >> > >>pci_read_config_word(solo_dev->pdev, PCI_STATUS, ); > >> > >> in solo_reg_write() help? > > > &g

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Mon, Sep 26, 2016 at 07:38:05AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin <andrey_ut...@fastmail.com> writes: > > > On Thu, Sep 22, 2016 at 10:51:37AM +0200, Krzysztof Hałasa wrote: > >> I wonder if the following fixes the problem (completely untested). >

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Mon, Sep 26, 2016 at 07:38:05AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin writes: > > > On Thu, Sep 22, 2016 at 10:51:37AM +0200, Krzysztof Hałasa wrote: > >> I wonder if the following fixes the problem (completely untested). > > > > I have given this a r

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 10:52:18PM +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > So you think I should make one "big" patch and resend it?

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 10:52:18PM +0200, becher.jan...@gmail.com wrote: > I always wondered why I shouldn't make more than one change in a patch, > but in all talks I watched they said that it's easier for them to merge > small patches. > So you think I should make one "big" patch and resend it?

Re: [PATCH] kernel/cpu_pm: replace rwlock with raw_spinlock

On Thu, Sep 22, 2016 at 06:24:19PM +0200, dpervus...@gmail.com wrote: > From: dmitry pervushin > > Recently I faced the BUG in cpuidle driver, "scheduling while atomic" So please show BUG text. > The reason of this BUG is that rwlock behavior gets changed by > RT patches

Re: [PATCH] kernel/cpu_pm: replace rwlock with raw_spinlock

On Thu, Sep 22, 2016 at 06:24:19PM +0200, dpervus...@gmail.com wrote: > From: dmitry pervushin > > Recently I faced the BUG in cpuidle driver, "scheduling while atomic" So please show BUG text. > The reason of this BUG is that rwlock behavior gets changed by > RT patches So add RT mailing

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. > > Signed-off-by: Jannik Becher > --- > drivers/staging/wlan-ng/p80211req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote: > removed a space after a cast to obtain the coding style. > > Signed-off-by: Jannik Becher > --- > drivers/staging/wlan-ng/p80211req.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Thu, Sep 22, 2016 at 10:51:37AM +0200, Krzysztof Hałasa wrote: > I wonder if the following fixes the problem (completely untested). I have given this a run, and it still hangs.

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Thu, Sep 22, 2016 at 10:51:37AM +0200, Krzysztof Hałasa wrote: > I wonder if the following fixes the problem (completely untested). I have given this a run, and it still hangs.

[PATCH] [media] tw5864: crop picture width to 704

Previously, width of 720 was used, but it gives 16-pixel wide black bar at right side of encoded picture. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- drivers/media/pci/tw5864/tw5864-reg.h | 8 drivers/media/pci/tw5864/tw5864-video.c | 13 +++-- 2

[PATCH] [media] tw5864: crop picture width to 704

Previously, width of 720 was used, but it gives 16-pixel wide black bar at right side of encoded picture. Signed-off-by: Andrey Utkin --- drivers/media/pci/tw5864/tw5864-reg.h | 8 drivers/media/pci/tw5864/tw5864-video.c | 13 +++-- 2 files changed, 19 insertions(+), 2

[PATCH] [media] solo6x10: avoid delayed register write

alled from solo_motion_config(). This extra "flushing" is not fundamentally needed for every write, but apparently the code in driver assumes such behaviour at last in some places. Actual fix was proposed by Hans Verkuil. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> ---

[PATCH] [media] solo6x10: avoid delayed register write

alled from solo_motion_config(). This extra "flushing" is not fundamentally needed for every write, but apparently the code in driver assumes such behaviour at last in some places. Actual fix was proposed by Hans Verkuil. Signed-off-by: Andrey Utkin --- drivers/media/pci/solo6x10/solo6x10.h | 3 ++

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Wed, Sep 21, 2016 at 03:16:57PM +0200, Krzysztof Hałasa wrote: > Hans Verkuil writes: > > > That was probably the reason for the pci_read_config_word in the reg_write > > code. Try putting that back (and just that). > > Yes. I guess a single pci_read_config_word() would

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Wed, Sep 21, 2016 at 03:16:57PM +0200, Krzysztof Hałasa wrote: > Hans Verkuil writes: > > > That was probably the reason for the pci_read_config_word in the reg_write > > code. Try putting that back (and just that). > > Yes. I guess a single pci_read_config_word() would suffice. > > Though

tw5864 - call to hardware owners

Hi all, I would love to hear from anybody who owns any sample of PCIE board with TW5864 chip. It is possible to buy from here http://www.provideo.com.tw/Products.htm?link=web/DVR%20Card_Hardward.htm I guess there are more companies selling boards with it. So there is a driver, "tw5864",

tw5864 - call to hardware owners

Hi all, I would love to hear from anybody who owns any sample of PCIE board with TW5864 chip. It is possible to buy from here http://www.provideo.com.tw/Products.htm?link=web/DVR%20Card_Hardward.htm I guess there are more companies selling boards with it. So there is a driver, "tw5864",

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Thu, Sep 15, 2016 at 03:15:53PM +0200, Hans Verkuil wrote: > It could be related to the fact that a PCI write may be delayed unless > it is followed by a read (see also the comments in > drivers/media/pci/ivtv/ivtv-driver.h). Thanks for explanation! > That was probably the reason for the

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Thu, Sep 15, 2016 at 03:15:53PM +0200, Hans Verkuil wrote: > It could be related to the fact that a PCI write may be delayed unless > it is followed by a read (see also the comments in > drivers/media/pci/ivtv/ivtv-driver.h). Thanks for explanation! > That was probably the reason for the

solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

Hi Krzysztof, Me and one more solo6010 board user experience machine lockup when solo6x10 module is loaded on kernel series starting with 4.3 (despite solo6110 board probes just fine on all kernels). That is, 3.16, 3.18, 4.1 and 4.2 are tested and fine, and 4.3, 4.4, and others up to current

solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

Hi Krzysztof, Me and one more solo6010 board user experience machine lockup when solo6x10 module is loaded on kernel series starting with 4.3 (despite solo6110 board probes just fine on all kernels). That is, 3.16, 3.18, 4.1 and 4.2 are tested and fine, and 4.3, 4.4, and others up to current

Re: [PATCH 0/2] [media] tw5864 constify some structures

On Tue, Sep 13, 2016 at 02:02:36AM +0300, Andrey Utkin wrote: > tw5864 is a recently submitted driver and it is currently present only > in media tree. Oops, have just fetched linux-next updates, tw5864 is already in next.

Re: [PATCH 0/2] [media] tw5864 constify some structures

On Tue, Sep 13, 2016 at 02:02:36AM +0300, Andrey Utkin wrote: > tw5864 is a recently submitted driver and it is currently present only > in media tree. Oops, have just fetched linux-next updates, tw5864 is already in next.

[PATCH 0/2] [media] tw5864 constify some structures

tw5864 is a recently submitted driver and it is currently present only in media tree. Recent patches submitted by Julia Lawall urged me to make similar changes in this driver. Andrey Utkin (2): [media] tw5864: constify vb2_ops structure [media] tw5864: constify struct video_device template

[PATCH 1/2] [media] tw5864: constify vb2_ops structure

Inspired by "[media] pci: constify vb2_ops structures" patch from Julia Lawall (dated 9 Sep 2016). Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- drivers/media/pci/tw5864/tw5864-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 0/2] [media] tw5864 constify some structures

tw5864 is a recently submitted driver and it is currently present only in media tree. Recent patches submitted by Julia Lawall urged me to make similar changes in this driver. Andrey Utkin (2): [media] tw5864: constify vb2_ops structure [media] tw5864: constify struct video_device template

[PATCH 1/2] [media] tw5864: constify vb2_ops structure

Inspired by "[media] pci: constify vb2_ops structures" patch from Julia Lawall (dated 9 Sep 2016). Signed-off-by: Andrey Utkin --- drivers/media/pci/tw5864/tw5864-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/dri

  1   2   3   4   5   >