Re: [PATCH v6 5/7] can: kvaser_usb: Update interface state before exiting on OOM

2015-01-26 Thread Andri Yngvason
Quoting Marc Kleine-Budde (2015-01-26 10:50:12) > On 01/26/2015 11:28 AM, Andri Yngvason wrote: > > Quoting Ahmed S. Darwish (2015-01-26 05:27:19) > >> From: Ahmed S. Darwish > >> > >> Update all of the can interface's state and error counters befor

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-26 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-25 02:43:00) > On Fri, Jan 23, 2015 at 10:32:13AM +0000, Andri Yngvason wrote: > > Quoting Ahmed S. Darwish (2015-01-23 06:07:34) > > > On Wed, Jan 21, 2015 at 05:13:45PM +0100, Wolfgang Grandegger wrote: > > > > On Wed, 21 Jan

Re: [PATCH v6 7/7] can: kvaser_usb: Add support for the USBcan-II family

2015-01-26 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-26 05:33:10) > From: Ahmed S. Darwish > > CAN to USB interfaces sold by the Swedish manufacturer Kvaser are > divided into two major families: 'Leaf', and 'USBcanII'. From an > Operating System perspective, the firmware of both families behave > in a not too dra

Re: [PATCH v6 5/7] can: kvaser_usb: Update interface state before exiting on OOM

2015-01-26 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-26 05:27:19) > From: Ahmed S. Darwish > > Update all of the can interface's state and error counters before > trying any skb allocation that can actually fail with -ENOMEM. > > Suggested-by: Marc Kleine-Budde > Signed-off-by: Ahmed S. Darwish > --- > drivers/

Re: [PATCH v6 6/7] can: kvaser_usb: Consolidate and unify state change handling

2015-01-26 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-26 05:29:15) > From: Ahmed S. Darwish > > Replace most of the can interface's state and error counters > handling with the new can-dev can_change_state() mechanism. > > Suggested-by: Andri Yngvason > Signed-off-by: Ahmed S. Darwish

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-23 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-23 06:07:34) > On Wed, Jan 21, 2015 at 05:13:45PM +0100, Wolfgang Grandegger wrote: > > On Wed, 21 Jan 2015 10:36:47 -0500, "Ahmed S. Darwish" > > wrote: > > > On Wed, Jan 21, 2015 at 03:00:15PM +, Andri Yngvason wrote: >

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-22 Thread Andri Yngvason
Quoting Marc Kleine-Budde (2015-01-21 22:59:23) > On 01/21/2015 05:20 PM, Andri Yngvason wrote: > > Marc, could you merge the "move bus_off++" patch before you merge this so > > that I > > won't have to incorporate this patch-set into it? > > ...included

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-21 15:36:47) > On Wed, Jan 21, 2015 at 03:00:15PM +0000, Andri Yngvason wrote: > > Quoting Ahmed S. Darwish (2015-01-21 14:43:23) > > > Hi! > > ... > > > > <-- Unplug the cable --> > > > > > >

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > From: Ahmed S. Darwish > > Replace most of the can interface's state and error counters > handling with the new can-dev can_change_state() mechanism. > > Suggested-by: Andri Yngvason > Signed-off-by: Ahmed S. Darwish

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-21 14:43:23) > Hi! > > On Wed, Jan 21, 2015 at 12:53:58PM +0100, Wolfgang Grandegger wrote: > > On Wed, 21 Jan 2015 10:33:19 +, Andri Yngvason > > wrote: > > > Quoting Ahmed S. Darwish (2015-01-20 21:45:37)

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Marc Kleine-Budde (2015-01-21 10:44:54) > On 01/21/2015 11:33 AM, Andri Yngvason wrote: > > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > >> From: Ahmed S. Darwish > >> > >> Replace most of the can interface's state and error counters > >&

Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling

2015-01-21 Thread Andri Yngvason
Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > From: Ahmed S. Darwish > > Replace most of the can interface's state and error counters > handling with the new can-dev can_change_state() mechanism. > > Suggested-by: Andri Yngvason > Signed-off-by: Ahmed S. Darwish