Re: linux-next: Signed-off-by missing for commits in the net-next tree

On 8/16/19 3:06 PM, Gerd Rausch wrote: > Hi, > > Just added the e-mail addresses I found using a simple "google search", > in order to reach out to the original authors of these commits: > Chris Mason and Andy Grover. > > I'm hoping they still remember their work

how to unmap pages in an anonymous mmap?

On 02/26/2017 09:59 PM, Xiubo Li wrote: >> But, We likely don't want to release memory from the data area anyways >> while active, in any case. How about if we set a timer when active >> commands go to zero, and then reduce data area to some minimum if no new >> cmds come in before timer expires?

how to unmap pages in an anonymous mmap?

On 02/26/2017 09:59 PM, Xiubo Li wrote: >> But, We likely don't want to release memory from the data area anyways >> while active, in any case. How about if we set a timer when active >> commands go to zero, and then reduce data area to some minimum if no new >> cmds come in before timer expires?

Re: [PATCH] target/user: Add daynmic growing data area featuresupport

On 02/23/2017 06:07 PM, Xiubo Li wrote: >> Cool. This is a good approach for an initial patch but this raises >> concerns about efficiently managing kernel memory usage -- the data area >> grows but never shrinks, and total possible usage increases per >> backstore. (What if there are 1000?) Any

Re: [PATCH] target/user: Add daynmic growing data area featuresupport

On 02/23/2017 06:07 PM, Xiubo Li wrote: >> Cool. This is a good approach for an initial patch but this raises >> concerns about efficiently managing kernel memory usage -- the data area >> grows but never shrinks, and total possible usage increases per >> backstore. (What if there are 1000?) Any

Re: [PATCH] target/user: Add daynmic growing data area feature support

On 02/17/2017 01:24 AM, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > Currently for the TCMU, the ring buffer size is fixed to 64K cmd > area + 1M data area, and this will be bottlenecks for high iops. Hi Xiubo, thanks for your work. daynmic -> dynamic

Re: [PATCH] target/user: Add daynmic growing data area feature support

On 02/17/2017 01:24 AM, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > Currently for the TCMU, the ring buffer size is fixed to 64K cmd > area + 1M data area, and this will be bottlenecks for high iops. Hi Xiubo, thanks for your work. daynmic -> dynamic Have you benchmarked this

Re: [PATCH] uio: add UIO_MEM_CUSTOM support

On 02/15/2017 05:34 PM, Xiubo Li wrote: >>> --- a/drivers/uio/uio.c >>> +++ b/drivers/uio/uio.c >>> @@ -708,6 +708,8 @@ static int uio_mmap(struct file *filep, struct >>> vm_area_struct *vma) >>> case UIO_MEM_LOGICAL: >>> case UIO_MEM_VIRTUAL: >>> return

Re: [PATCH] uio: add UIO_MEM_CUSTOM support

On 02/15/2017 05:34 PM, Xiubo Li wrote: >>> --- a/drivers/uio/uio.c >>> +++ b/drivers/uio/uio.c >>> @@ -708,6 +708,8 @@ static int uio_mmap(struct file *filep, struct >>> vm_area_struct *vma) >>> case UIO_MEM_LOGICAL: >>> case UIO_MEM_VIRTUAL: >>> return

Re: [dm-devel] [PATCH 0/9] Generate uevents for all DM events

On 10/05/2016 10:43 AM, Alasdair G Kergon wrote: On Wed, Oct 05, 2016 at 10:06:41AM -0700, Andy Grover wrote: My project *would* like this added sooner, so I'll work on a revised patchset that uses netlink instead of uevents, and will also work on a revision to uevents.txt that talks about

Re: [dm-devel] [PATCH 0/9] Generate uevents for all DM events

On 10/05/2016 10:43 AM, Alasdair G Kergon wrote: On Wed, Oct 05, 2016 at 10:06:41AM -0700, Andy Grover wrote: My project *would* like this added sooner, so I'll work on a revised patchset that uses netlink instead of uevents, and will also work on a revision to uevents.txt that talks about

Re: [dm-devel] [PATCH 0/9] Generate uevents for all DM events

On 10/04/2016 11:51 PM, Greg KH wrote: On Wed, Oct 05, 2016 at 01:40:05AM +0100, Alasdair G Kergon wrote: We see these as two different categories of notifications, and prefer the greater flexibility a mechanism independent of uevents would provide. The team has discussed several

Re: [dm-devel] [PATCH 0/9] Generate uevents for all DM events

On 10/04/2016 11:51 PM, Greg KH wrote: On Wed, Oct 05, 2016 at 01:40:05AM +0100, Alasdair G Kergon wrote: We see these as two different categories of notifications, and prefer the greater flexibility a mechanism independent of uevents would provide. The team has discussed several

Re: [PATCH 0/9] Generate uevents for all DM events

On 10/04/2016 12:20 AM, Greg KH wrote: On Mon, Oct 03, 2016 at 12:22:51PM -0700, Andy Grover wrote: Hi Mike and GregKH, I want a way to get devicemapper events without using the DM ioctl, because that requires creating a thread to sleep in the ioctl for each dm device I want events from

Re: [PATCH 0/9] Generate uevents for all DM events

On 10/04/2016 12:20 AM, Greg KH wrote: On Mon, Oct 03, 2016 at 12:22:51PM -0700, Andy Grover wrote: Hi Mike and GregKH, I want a way to get devicemapper events without using the DM ioctl, because that requires creating a thread to sleep in the ioctl for each dm device I want events from

[PATCH 2/9] dm: Move multipath-specific stuff out of dm-uevent.c

of these to dm-mpath.c and expose a few lower-level functions, dm_build_uevent, dm_uevent_add and dm_uevent_free, for other dm targets to build their own uevents. Signed-off-by: Andy Grover <agro...@redhat.com> --- drivers/md/dm-mpath.c | 71 +++ drivers

[PATCH 4/9] dm: Update dm-uevent.txt

Document the current dm uevent API, as modified by this patchset. Signed-off-by: Andy Grover <agro...@redhat.com> --- Documentation/device-mapper/dm-uevent.txt | 49 ++- 1 file changed, 42 insertions(+), 7 deletions(-) diff --git a/Documentation/device-map

[PATCH 2/9] dm: Move multipath-specific stuff out of dm-uevent.c

of these to dm-mpath.c and expose a few lower-level functions, dm_build_uevent, dm_uevent_add and dm_uevent_free, for other dm targets to build their own uevents. Signed-off-by: Andy Grover --- drivers/md/dm-mpath.c | 71 +++ drivers/md/dm-uevent.c | 75

[PATCH 4/9] dm: Update dm-uevent.txt

Document the current dm uevent API, as modified by this patchset. Signed-off-by: Andy Grover --- Documentation/device-mapper/dm-uevent.txt | 49 ++- 1 file changed, 42 insertions(+), 7 deletions(-) diff --git a/Documentation/device-mapper/dm-uevent.txt b

[PATCH 5/9] dm: Rename dm_build_uevent to dm_uevent_build

For consistency with other function names that start with 'dm_uevent'. Signed-off-by: Andy Grover <agro...@redhat.com> --- Documentation/device-mapper/dm-uevent.txt | 2 +- drivers/md/dm-mpath.c | 4 ++-- drivers/md/dm-uevent.c| 4 ++-- drivers

[PATCH 9/9] dm: Generate uevents for other targets

Generate uevents for other targets: cache, log, raid1, and snap. Signed-off-by: Andy Grover <agro...@redhat.com> --- drivers/md/dm-cache-target.c | 5 - drivers/md/dm-log-userspace-base.c | 8 ++-- drivers/md/dm-log.c| 1 + drivers/md/dm-raid1.c

[PATCH 7/9] dm: Implement dm_uevent_add()

This helper function builds and enqueues the uevent. Targets can use this when they do not need to customize the uevent beyond its name. Signed-off-by: Andy Grover <agro...@redhat.com> --- Documentation/device-mapper/dm-uevent.txt | 5 + drivers/md/dm-uevent.c

[PATCH 9/9] dm: Generate uevents for other targets

Generate uevents for other targets: cache, log, raid1, and snap. Signed-off-by: Andy Grover --- drivers/md/dm-cache-target.c | 5 - drivers/md/dm-log-userspace-base.c | 8 ++-- drivers/md/dm-log.c| 1 + drivers/md/dm-raid1.c | 1 + drivers/md/dm-snap.c

[PATCH 7/9] dm: Implement dm_uevent_add()

This helper function builds and enqueues the uevent. Targets can use this when they do not need to customize the uevent beyond its name. Signed-off-by: Andy Grover --- Documentation/device-mapper/dm-uevent.txt | 5 + drivers/md/dm-uevent.c| 26

[PATCH 5/9] dm: Rename dm_build_uevent to dm_uevent_build

For consistency with other function names that start with 'dm_uevent'. Signed-off-by: Andy Grover --- Documentation/device-mapper/dm-uevent.txt | 2 +- drivers/md/dm-mpath.c | 4 ++-- drivers/md/dm-uevent.c| 4 ++-- drivers/md/dm-uevent.h

[PATCH 8/9] dm: Generate uevents for thin targets

Generate uevents when thin pool devices hit data or metadata low water marks, and when pool mode changes. Signed-off-by: Andy Grover <agro...@redhat.com> --- drivers/md/dm-thin.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index d

[PATCH 6/9] dm: Rename dm_event_add to dm_event_queue

For clarity. This function queues an event to be sent, which is not totally clear from the previous name. And, we want to reuse the name for something else. Signed-off-by: Andy Grover <agro...@redhat.com> --- Documentation/device-mapper/dm-uevent.txt | 2 +- drivers/md/dm-m

[PATCH 8/9] dm: Generate uevents for thin targets

Generate uevents when thin pool devices hit data or metadata low water marks, and when pool mode changes. Signed-off-by: Andy Grover --- drivers/md/dm-thin.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index d1c05c1..0778a2a 100644

[PATCH 6/9] dm: Rename dm_event_add to dm_event_queue

For clarity. This function queues an event to be sent, which is not totally clear from the previous name. And, we want to reuse the name for something else. Signed-off-by: Andy Grover --- Documentation/device-mapper/dm-uevent.txt | 2 +- drivers/md/dm-mpath.c | 2 +- drivers

[PATCH 3/9] dm: Inline dm_build_path_uevent into dm_path_uevent

Since it's no longer an API boundary we can consolidate these two functions. Signed-off-by: Andy Grover <agro...@redhat.com> --- drivers/md/dm-mpath.c | 59 +++ 1 file changed, 22 insertions(+), 37 deletions(-) diff --git a/drivers/md/dm-mpa

[PATCH 3/9] dm: Inline dm_build_path_uevent into dm_path_uevent

Since it's no longer an API boundary we can consolidate these two functions. Signed-off-by: Andy Grover --- drivers/md/dm-mpath.c | 59 +++ 1 file changed, 22 insertions(+), 37 deletions(-) diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm

[PATCH 0/9] Generate uevents for all DM events

patchset may be appliable if you're actually ok with using KOBJ_CHANGE for dm events, or if not, then I'll look to rework it to use a dm-specific genetlink approach. Thanks -- Regards -- Andy Andy Grover (9): dm: Do not export dm_send_uevents dm: Move multipath-specific stuff out of dm-uevent.c

[PATCH 0/9] Generate uevents for all DM events

patchset may be appliable if you're actually ok with using KOBJ_CHANGE for dm events, or if not, then I'll look to rework it to use a dm-specific genetlink approach. Thanks -- Regards -- Andy Andy Grover (9): dm: Do not export dm_send_uevents dm: Move multipath-specific stuff out of dm-uevent.c

[PATCH 1/9] dm: Do not export dm_send_uevents

Since dm-uevent.c (if CONFIG_DM_UEVENT) is part of the same module as where dm_sent_uevents is called, it does not need to be exported. Signed-off-by: Andy Grover <agro...@redhat.com> --- drivers/md/dm-uevent.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/md/dm-uevent.c b/d

[PATCH 1/9] dm: Do not export dm_send_uevents

Since dm-uevent.c (if CONFIG_DM_UEVENT) is part of the same module as where dm_sent_uevents is called, it does not need to be exported. Signed-off-by: Andy Grover --- drivers/md/dm-uevent.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/md/dm-uevent.c b/drivers/md/dm-uevent.c index

Re: NVMe over Fabrics target implementation

On 06/06/2016 11:23 PM, Nicholas A. Bellinger wrote: Hi HCH & Co, On Mon, 2016-06-06 at 23:22 +0200, Christoph Hellwig wrote: This patch set adds a generic NVMe over Fabrics target. The implementation conforms to the NVMe 1.2b specification (which includes Fabrics) and provides the NVMe over

Re: NVMe over Fabrics target implementation

On 06/06/2016 11:23 PM, Nicholas A. Bellinger wrote: Hi HCH & Co, On Mon, 2016-06-06 at 23:22 +0200, Christoph Hellwig wrote: This patch set adds a generic NVMe over Fabrics target. The implementation conforms to the NVMe 1.2b specification (which includes Fabrics) and provides the NVMe over

Re: __might_sleep in uio_read()?

On 09/03/2015 12:12 PM, Greg KH wrote: On Thu, Sep 03, 2015 at 11:47:34AM -0700, Andy Grover wrote: On 09/03/2015 05:26 AM, Michal Hocko wrote: On Wed 02-09-15 15:45:10, Andy Grover wrote: Hi Hans and Greg, Is this an issue with uio? I swear it didn't used to throw this warning... Thanks

Re: __might_sleep in uio_read()?

On 09/03/2015 05:26 AM, Michal Hocko wrote: On Wed 02-09-15 15:45:10, Andy Grover wrote: Hi Hans and Greg, Is this an issue with uio? I swear it didn't used to throw this warning... Thanks -- Andy [ 5174.883261] [ cut here ] [ 5174.883617] WARNING: CPU: 0 PID: 1532

Re: __might_sleep in uio_read()?

On 09/03/2015 05:26 AM, Michal Hocko wrote: On Wed 02-09-15 15:45:10, Andy Grover wrote: Hi Hans and Greg, Is this an issue with uio? I swear it didn't used to throw this warning... Thanks -- Andy [ 5174.883261] [ cut here ] [ 5174.883617] WARNING: CPU: 0 PID: 1532

Re: __might_sleep in uio_read()?

On 09/03/2015 12:12 PM, Greg KH wrote: On Thu, Sep 03, 2015 at 11:47:34AM -0700, Andy Grover wrote: On 09/03/2015 05:26 AM, Michal Hocko wrote: On Wed 02-09-15 15:45:10, Andy Grover wrote: Hi Hans and Greg, Is this an issue with uio? I swear it didn't used to throw this warning... Thanks

__might_sleep in uio_read()?

Hi Hans and Greg, Is this an issue with uio? I swear it didn't used to throw this warning... Thanks -- Andy [ 5174.883261] [ cut here ] [ 5174.883617] WARNING: CPU: 0 PID: 1532 at /home/agrover/git/kernel/kernel/sched/core.c:7389 __might_sleep+0x7d/0x90() [

__might_sleep in uio_read()?

Hi Hans and Greg, Is this an issue with uio? I swear it didn't used to throw this warning... Thanks -- Andy [ 5174.883261] [ cut here ] [ 5174.883617] WARNING: CPU: 0 PID: 1532 at /home/agrover/git/kernel/kernel/sched/core.c:7389 __might_sleep+0x7d/0x90() [

Re: [PATCH 03/12] target/configfs: Convert mappedlun + SCSI MIBs to RCU reader

On 05/12/2015 02:25 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch converts fabric independent configfs link/unlink to use RCU read path macros for se_node_acl->lun_entry_hlist access. It also converts SCSI MIB configfs show attribute code to use RCU read path macros for

Re: [PATCH 01/12] target: Convert se_node_acl->device_list[] to RCU hlist

On 05/12/2015 02:25 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch converts se_node_acl->device_list[] table for mappedluns to modern RCU hlist_head usage in order to support an arbitrary number of node_acl lun mappings. This includes changes to

Re: [PATCH 01/12] target: Convert se_node_acl-device_list[] to RCU hlist

On 05/12/2015 02:25 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch converts se_node_acl-device_list[] table for mappedluns to modern RCU hlist_head usage in order to support an arbitrary number of node_acl lun mappings. This includes changes to

Re: [PATCH 03/12] target/configfs: Convert mappedlun + SCSI MIBs to RCU reader

On 05/12/2015 02:25 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch converts fabric independent configfs link/unlink to use RCU read path macros for se_node_acl-lun_entry_hlist access. It also converts SCSI MIB configfs show attribute code to use RCU

[PATCH/RFC] configfs: Update docs to indicate sysfs & configfs usage is ok

The docs state that sysfs and configfs are peers that meet different needs, but doesn't explicitly make it clear that if a subsystem needs functionality that spans both, it is preferable to use both instead of trying to cram everything into one or the other. Signed-off-by: Andy Grover

[PATCH/RFC] configfs: Update docs to indicate sysfs configfs usage is ok

The docs state that sysfs and configfs are peers that meet different needs, but doesn't explicitly make it clear that if a subsystem needs functionality that spans both, it is preferable to use both instead of trying to cram everything into one or the other. Signed-off-by: Andy Grover agro

Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

... and so forth.) Cc: sta...@vger.kernel.org # 3.18 Signed-off-by: Kyle McMartin --- cc-ing stable@ so this headers fix gets picked up by distros. Acked-by: Andy Grover -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness

... and so forth.) Cc: sta...@vger.kernel.org # 3.18 Signed-off-by: Kyle McMartin k...@redhat.com --- cc-ing stable@ so this headers fix gets picked up by distros. Acked-by: Andy Grover agro...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v4 10/25] virtio: add API to enable VQs early

On 10/13/2014 12:50 AM, Michael S. Tsirkin wrote: virtio spec 0.9.X requires DRIVER_OK to be set before VQs are used, but some drivers use VQs before probe function returns. Since DRIVER_OK is set after probe, this violates the spec. Even though under virtio 1.0 transitional devices support

Re: [PATCH v4 10/25] virtio: add API to enable VQs early

On 10/13/2014 12:50 AM, Michael S. Tsirkin wrote: virtio spec 0.9.X requires DRIVER_OK to be set before VQs are used, but some drivers use VQs before probe function returns. Since DRIVER_OK is set after probe, this violates the spec. Even though under virtio 1.0 transitional devices support

[PATCHv2 1/4] target: Remove unneeded check in sbc_parse_cdb

The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's refactoring of this function. There are no places where that flag is set that cmd->execute_cmd isn't also set. Signed-off-by: Andy Grover --- drivers/target/target_core_sbc.c | 2 +- 1 file changed, 1 insertion(+)

[PATCHv2 0/4] Userspace Passthrough backstore for LIO

is unconfigured in tcmu_free_device Thanks -- Andy Andy Grover (4): target: Remove unneeded check in sbc_parse_cdb uio: Export definition of struct uio_device target: Add documentation on the target userspace pass-through driver target: Add a user-passthrough backstore Documentation/target

[PATCHv2 4/4] target: Add a user-passthrough backstore

f idrs may be overkill -- we maybe can replace them with a simple counter to generate cmd_ids, and a hash table to get a cmd_id's associated pointer. * Use of a free-running counter for cmd ring instead of explicit modulo math. This would require power-of-2 cmd ring size. Signed-off-by: A

[PATCHv2 3/4] target: Add documentation on the target userspace pass-through driver

Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Thanks to Richard W. M. Jones for review, and supplementing this doc with the first two paragraphs. Signed-off-by: Andy Grover --- Documentation/target/tcmu-design.txt | 378

[PATCHv2 2/4] uio: Export definition of struct uio_device

In order to prevent a O(n) search of the filesystem to link up its uio node with its target configuration, TCMU needs to know the minor number that UIO assigned. Expose the definition of this struct so TCMU can access this field. Signed-off-by: Andy Grover --- drivers/uio/uio.c | 12

[PATCHv2 2/4] uio: Export definition of struct uio_device

In order to prevent a O(n) search of the filesystem to link up its uio node with its target configuration, TCMU needs to know the minor number that UIO assigned. Expose the definition of this struct so TCMU can access this field. Signed-off-by: Andy Grover agro...@redhat.com --- drivers/uio

[PATCHv2 3/4] target: Add documentation on the target userspace pass-through driver

Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Thanks to Richard W. M. Jones for review, and supplementing this doc with the first two paragraphs. Signed-off-by: Andy Grover agro...@redhat.com --- Documentation/target/tcmu-design.txt

[PATCHv2 0/4] Userspace Passthrough backstore for LIO

is unconfigured in tcmu_free_device Thanks -- Andy Andy Grover (4): target: Remove unneeded check in sbc_parse_cdb uio: Export definition of struct uio_device target: Add documentation on the target userspace pass-through driver target: Add a user-passthrough backstore Documentation/target

[PATCHv2 4/4] target: Add a user-passthrough backstore

be overkill -- we maybe can replace them with a simple counter to generate cmd_ids, and a hash table to get a cmd_id's associated pointer. * Use of a free-running counter for cmd ring instead of explicit modulo math. This would require power-of-2 cmd ring size. Signed-off-by: Andy Grover agro

[PATCHv2 1/4] target: Remove unneeded check in sbc_parse_cdb

The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's refactoring of this function. There are no places where that flag is set that cmd-execute_cmd isn't also set. Signed-off-by: Andy Grover agro...@redhat.com --- drivers/target/target_core_sbc.c | 2 +- 1 file changed, 1

Re: [PATCHv3 0/8] target: Save memory on unused se_dev_entrys and se_luns

On 09/18/2014 04:17 PM, Nicholas A. Bellinger wrote: I'm currently reviewing #2, #4, #5 and #7 and will consider merging these. These cleanups account for most of the LOC reduction, and avoid most of the larger concerns. Also for patches like this, they really need testing on your end before

Re: [PATCHv3 0/8] target: Save memory on unused se_dev_entrys and se_luns

On 09/18/2014 04:17 PM, Nicholas A. Bellinger wrote: I'm currently reviewing #2, #4, #5 and #7 and will consider merging these. These cleanups account for most of the LOC reduction, and avoid most of the larger concerns. Also for patches like this, they really need testing on your end before

Re: [PATCH 4/4] target: Add a user-passthrough backstore

On 09/22/2014 01:58 PM, Nicholas A. Bellinger wrote: So I'd still like to start for an initial merge with the two different modes mentioned earlier. The pure-passthrough mode where everything is handled by user-space, and an I/O passthrough mode where only SCF_SCSI_DATA_CDB is passed along to

Re: [PATCH 4/4] target: Add a user-passthrough backstore

On 09/22/2014 01:58 PM, Nicholas A. Bellinger wrote: So I'd still like to start for an initial merge with the two different modes mentioned earlier. The pure-passthrough mode where everything is handled by user-space, and an I/O passthrough mode where only SCF_SCSI_DATA_CDB is passed along to

Re: [PATCH 4/4] target: Add a user-passthrough backstore

On 09/19/2014 04:51 PM, Alex Elsayed wrote: Not sure I follow.. How does the proposed passthrough mode prevent someone from emulating OSDs, media changers, optical disks or anything else in userspace with TCMU..? The main thing that the above comments highlight is why attempting to combine

Re: [PATCH 4/4] target: Add a user-passthrough backstore

On 09/19/2014 04:51 PM, Alex Elsayed wrote: Not sure I follow.. How does the proposed passthrough mode prevent someone from emulating OSDs, media changers, optical disks or anything else in userspace with TCMU..? The main thing that the above comments highlight is why attempting to combine

Re: [PATCHv3 0/8] target: Save memory on unused se_dev_entrys and se_luns

On 09/18/2014 12:38 AM, Nicholas A. Bellinger wrote: On Sat, 2014-09-13 at 21:55 +0200, Christoph Hellwig wrote: ping again. We're getting closer to the end of the 3.18 merge window and there still hasn't been a response. Should Andy just send the patches directly to Linus once 3.18 opens

Re: [PATCHv3 0/8] target: Save memory on unused se_dev_entrys and se_luns

On 09/18/2014 12:38 AM, Nicholas A. Bellinger wrote: On Sat, 2014-09-13 at 21:55 +0200, Christoph Hellwig wrote: ping again. We're getting closer to the end of the 3.18 merge window and there still hasn't been a response. Should Andy just send the patches directly to Linus once 3.18 opens

[PATCH 0/4] Userspace Passthrough backstore for LIO

until the kernel code is accepted :) Changes since version 2: * Incorporate doc improvements from Richard W. M. Jones * Correct off-by-1 error in tcmu_get_blocks * execute_rw must be set in the sbc_ops passed to sbc_parse_cdb Thanks -- Andy Andy Grover (4): target: Remove unneeded check

[PATCH 3/4] target: Add documentation on the target userspace pass-through driver

Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Thanks to Richard W. M. Jones for review, and supplementing this doc with the first two paragraphs. Signed-off-by: Andy Grover --- Documentation/target/tcmu-design.txt | 239

[PATCH 2/4] uio: Export definition of struct uio_device

In order to prevent a O(n) search of the filesystem to link up its uio node with its target configuration, TCMU needs to know the minor number that UIO assigned. Expose the definition of this struct so TCMU can access this field. Signed-off-by: Andy Grover --- drivers/uio/uio.c | 12

[PATCH 4/4] target: Add a user-passthrough backstore

f idrs may be overkill -- we maybe can replace them with a simple counter to generate cmd_ids, and a hash table to get a cmd_id's associated pointer. * Use of a free-running counter for cmd ring instead of explicit modulo math. This would require power-of-2 cmd ring size. Signed-off-by: A

[PATCH 1/4] target: Remove unneeded check in sbc_parse_cdb

The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's refactoring of this function. There are no places where that flag is set that cmd->execute_cmd isn't also set. Signed-off-by: Andy Grover --- drivers/target/target_core_sbc.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH 1/4] target: Remove unneeded check in sbc_parse_cdb

The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's refactoring of this function. There are no places where that flag is set that cmd-execute_cmd isn't also set. Signed-off-by: Andy Grover agro...@redhat.com --- drivers/target/target_core_sbc.c | 2 +- 1 file changed, 1

[PATCH 2/4] uio: Export definition of struct uio_device

In order to prevent a O(n) search of the filesystem to link up its uio node with its target configuration, TCMU needs to know the minor number that UIO assigned. Expose the definition of this struct so TCMU can access this field. Signed-off-by: Andy Grover agro...@redhat.com --- drivers/uio

[PATCH 4/4] target: Add a user-passthrough backstore

be overkill -- we maybe can replace them with a simple counter to generate cmd_ids, and a hash table to get a cmd_id's associated pointer. * Use of a free-running counter for cmd ring instead of explicit modulo math. This would require power-of-2 cmd ring size. Signed-off-by: Andy Grover agro

[PATCH 3/4] target: Add documentation on the target userspace pass-through driver

Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Thanks to Richard W. M. Jones for review, and supplementing this doc with the first two paragraphs. Signed-off-by: Andy Grover agro...@redhat.com --- Documentation/target/tcmu-design.txt

[PATCH 0/4] Userspace Passthrough backstore for LIO

until the kernel code is accepted :) Changes since version 2: * Incorporate doc improvements from Richard W. M. Jones * Correct off-by-1 error in tcmu_get_blocks * execute_rw must be set in the sbc_ops passed to sbc_parse_cdb Thanks -- Andy Andy Grover (4): target: Remove unneeded check

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

On 08/31/2014 02:22 PM, Richard W.M. Jones wrote: Reading this several times, I now think I get what it's trying to say, but I think it needs to introduces the terms (as the Economist style does). Something like this: "TCM is the new name for LIO, an in-kernel iSCSI target (server).

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

On 08/31/2014 02:22 PM, Richard W.M. Jones wrote: Reading this several times, I now think I get what it's trying to say, but I think it needs to introduces the terms (as the Economist style does). Something like this: TCM is the new name for LIO, an in-kernel iSCSI target (server).

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

On 08/30/2014 10:35 AM, Richard W.M. Jones wrote: On Tue, Jul 01, 2014 at 12:11:14PM -0700, Andy Grover wrote: Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Signed-off-by: Andy Grover --- Documentation/target/tcmu-design.txt | 210

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

On 08/30/2014 10:35 AM, Richard W.M. Jones wrote: On Tue, Jul 01, 2014 at 12:11:14PM -0700, Andy Grover wrote: Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Signed-off-by: Andy Grover agro...@redhat.com --- Documentation/target/tcmu

[RFCv2 3/4] target: Add a user-passthrough backstore

l. Signed-off-by: Andy Grover --- drivers/target/Kconfig |5 + drivers/target/Makefile|1 + drivers/target/target_core_transport.c |4 + drivers/target/target_core_user.c | 1158 include/uapi/linux/Kbuild

[RFCv2 4/4] target: Add documentation on the target userspace pass-through driver

Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Signed-off-by: Andy Grover --- Documentation/target/tcmu-design.txt | 229 +++ 1 file changed, 229 insertions(+) create mode 100644 Documentation/target/tcmu

[RFCv2 0/4] Userspace pass-through storage engine (backend)

a user storage object and give it a size, and 'file/foo.img' as config parameter * Start tcmu-runner (manually for now) * Create a loopback fabric and link the above storage object to it Andy Grover (4): target: Remove unneeded check in sbc_parse_cdb uio: Export definition of struct uio_device

[RFCv2 1/4] target: Remove unneeded check in sbc_parse_cdb

The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's refactoring of this function. There are no places where that flag is set that cmd->execute_cmd isn't also set. Signed-off-by: Andy Grover --- drivers/target/target_core_sbc.c | 2 +- 1 file changed, 1 insertion(+)

[RFCv2 2/4] uio: Export definition of struct uio_device

In order to prevent a O(n) search of the filesystem to link up its uio node with its target configuration, TCMU needs to know the minor number that UIO assigned. Expose the definition of this struct so TCMU can access this field. Signed-off-by: Andy Grover --- drivers/uio/uio.c | 12

[RFCv2 1/4] target: Remove unneeded check in sbc_parse_cdb

The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's refactoring of this function. There are no places where that flag is set that cmd-execute_cmd isn't also set. Signed-off-by: Andy Grover agro...@redhat.com --- drivers/target/target_core_sbc.c | 2 +- 1 file changed, 1

[RFCv2 0/4] Userspace pass-through storage engine (backend)

a user storage object and give it a size, and 'file/foo.img' as config parameter * Start tcmu-runner (manually for now) * Create a loopback fabric and link the above storage object to it Andy Grover (4): target: Remove unneeded check in sbc_parse_cdb uio: Export definition of struct uio_device

[RFCv2 2/4] uio: Export definition of struct uio_device

In order to prevent a O(n) search of the filesystem to link up its uio node with its target configuration, TCMU needs to know the minor number that UIO assigned. Expose the definition of this struct so TCMU can access this field. Signed-off-by: Andy Grover agro...@redhat.com --- drivers/uio

[RFCv2 4/4] target: Add documentation on the target userspace pass-through driver

Describes the driver and its interface to make it possible for user programs to back a LIO-exported LUN. Signed-off-by: Andy Grover agro...@redhat.com --- Documentation/target/tcmu-design.txt | 229 +++ 1 file changed, 229 insertions(+) create mode 100644

[RFCv2 3/4] target: Add a user-passthrough backstore

-by: Andy Grover agro...@redhat.com --- drivers/target/Kconfig |5 + drivers/target/Makefile|1 + drivers/target/target_core_transport.c |4 + drivers/target/target_core_user.c | 1158 include/uapi/linux/Kbuild

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

[re-adding individual CCs that were dropped] On 07/05/2014 04:29 AM, Alex Elsayed wrote: +Device Discovery: + +Other devices may be using UIO besides TCMU. Unrelated user processes +may also be handling different sets of TCMU devices. TCMU userspace +processes must find their devices by

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

[re-adding individual CCs that were dropped] On 07/05/2014 04:29 AM, Alex Elsayed wrote: +Device Discovery: + +Other devices may be using UIO besides TCMU. Unrelated user processes +may also be handling different sets of TCMU devices. TCMU userspace +processes must find their devices by

Re: [RFC 0/2] target: userspace pass-through backend

Hi, here's some additional beginning bits for the configuration and use of this code: Changes to targetcli-fb and rtslib-fb: https://github.com/agrover/targetcli-fb/tree/userback https://github.com/agrover/rtslib-fb/tree/userback An incredibly-crappy stand-in for the user process that will

Re: [RFC 0/2] target: userspace pass-through backend

Hi, here's some additional beginning bits for the configuration and use of this code: Changes to targetcli-fb and rtslib-fb: https://github.com/agrover/targetcli-fb/tree/userback https://github.com/agrover/rtslib-fb/tree/userback An incredibly-crappy stand-in for the user process that will

[RFC 2/2] target: Add a user-passthrough backstore

l. Signed-off-by: Andy Grover --- drivers/target/Kconfig |5 + drivers/target/Makefile|1 + drivers/target/target_core_transport.c |4 + drivers/target/target_core_user.c | 1078 drivers/target/target_core_user.h

  1   2   >