Re: [...] an apology, and a maintainership note

2018-09-16 Thread Andy Isaacson
On Sun, Sep 16, 2018 at 12:22:43PM -0700, Linus Torvalds wrote: This is where the "look yourself in the mirror" moment comes in. So here we are, me finally on the one hand realizing that it wasn't actually funny or a good sign that I was hoping to just skip the yearly kernel summit entirely,

Re: [...] an apology, and a maintainership note

2018-09-16 Thread Andy Isaacson
On Sun, Sep 16, 2018 at 12:22:43PM -0700, Linus Torvalds wrote: This is where the "look yourself in the mirror" moment comes in. So here we are, me finally on the one hand realizing that it wasn't actually funny or a good sign that I was hoping to just skip the yearly kernel summit entirely,

Re: [PATCH take #2] MAINTAINTERS: use our mail list as Blackfin arch maintainters.

2007-08-24 Thread Andy Isaacson
On Fri, Aug 24, 2007 at 10:09:43AM +0100, Alan Cox wrote: > > > As Mike said, "it is moderated which means you do not need to subscribe, > > > we will > > > forward any relevant messages" > > > > And as I said, "does your list generate a complaint message back to > > the sender?" It's the

Re: [PATCH take #2] MAINTAINTERS: use our mail list as Blackfin arch maintainters.

2007-08-24 Thread Andy Isaacson
On Fri, Aug 24, 2007 at 10:09:43AM +0100, Alan Cox wrote: As Mike said, it is moderated which means you do not need to subscribe, we will forward any relevant messages And as I said, does your list generate a complaint message back to the sender? It's the moderation message that's

Re: [Tech-board-discuss] Re: [Ksummit-2007-discuss] Re: Linux Foundation Technical Advisory Board Elections

2007-08-23 Thread Andy Isaacson
On Wed, Aug 22, 2007 at 08:35:07PM -0500, James Bottomley wrote: > > While I think that's laudable, we definitely don't have the resources > > for that, as everyone on the TAB already has a full workload. And it > > hardly seems worth the trouble for a once-a-year election. > > Exactly ... we

Re: [Patch 2.6.22.2 ,2nd try] : ./drivers/net/via-rhine.c: Offload checksum handling to VT6105M

2007-08-23 Thread Andy Isaacson
On Mon, Aug 20, 2007 at 12:54:17PM -0700, K Naru wrote: > --- ./drivers/net/via-rhine.c.orig 2007-08-09 > 14:28:15.0 -0700 > +++ ./drivers/net/via-rhine.c 2007-08-20 > 04:29:43.0 -0700 [snip] > +#define TDES1_TCPCK0x0010 /* Bit 20, > Transmit Desc 1 */ > +#define

Re: [Patch 2.6.22.2 ,2nd try] : ./drivers/net/via-rhine.c: Offload checksum handling to VT6105M

2007-08-23 Thread Andy Isaacson
On Mon, Aug 20, 2007 at 12:54:17PM -0700, K Naru wrote: --- ./drivers/net/via-rhine.c.orig 2007-08-09 14:28:15.0 -0700 +++ ./drivers/net/via-rhine.c 2007-08-20 04:29:43.0 -0700 [snip] +#define TDES1_TCPCK0x0010 /* Bit 20, Transmit Desc 1 */ +#define

Re: [Tech-board-discuss] Re: [Ksummit-2007-discuss] Re: Linux Foundation Technical Advisory Board Elections

2007-08-23 Thread Andy Isaacson
On Wed, Aug 22, 2007 at 08:35:07PM -0500, James Bottomley wrote: While I think that's laudable, we definitely don't have the resources for that, as everyone on the TAB already has a full workload. And it hardly seems worth the trouble for a once-a-year election. Exactly ... we want a

Re: [PATCH]: proc: export a processes resource limits via proc/

2007-08-21 Thread Andy Isaacson
On Fri, Aug 17, 2007 at 12:45:47PM -0700, Andrew Morton wrote: > On Fri, 17 Aug 2007 06:59:18 -0400 > Neil Horman <[EMAIL PROTECTED]> wrote: > > Currently, there exists no method for a process to query the resource > > limits of another process. They can be inferred via some mechanisms > > but

Re: [PATCH]: proc: export a processes resource limits via proc/pid

2007-08-21 Thread Andy Isaacson
On Fri, Aug 17, 2007 at 12:45:47PM -0700, Andrew Morton wrote: On Fri, 17 Aug 2007 06:59:18 -0400 Neil Horman [EMAIL PROTECTED] wrote: Currently, there exists no method for a process to query the resource limits of another process. They can be inferred via some mechanisms but they cannot

Re: do_coredump and O_NOFOLLOW

2007-08-15 Thread Andy Isaacson
On Wed, Aug 15, 2007 at 01:36:54PM +0800, gshan wrote: > I found that O_NOFOLLOW is used for opened core file in Linux 2.6.10. > This means the core file couldn't be a symbolic link. However, I want to > use symbolic link for core file I would recommend that you use # sysctl -w

Re: do_coredump and O_NOFOLLOW

2007-08-15 Thread Andy Isaacson
On Wed, Aug 15, 2007 at 01:36:54PM +0800, gshan wrote: I found that O_NOFOLLOW is used for opened core file in Linux 2.6.10. This means the core file couldn't be a symbolic link. However, I want to use symbolic link for core file I would recommend that you use # sysctl -w

Re: [PATCH 3/4] Embed zone_id information within the zonelist->zones pointer

2007-08-14 Thread Andy Isaacson
On Tue, Aug 14, 2007 at 10:23:51PM +0200, Andi Kleen wrote: > > bcm43xx hardware does show up on low-end MIPS boxes (wrt54g anybody?) > > that would be sorely hurt by excess copies. > > Lowend boxes don't have more than 1GB of RAM. With <= 1GB you don't > need to copy on bcm43xx. OK, that makes

Re: [PATCH 3/4] Embed zone_id information within the zonelist->zones pointer

2007-08-14 Thread Andy Isaacson
On Tue, Aug 14, 2007 at 02:14:41AM +0200, Andi Kleen wrote: > On Tue, Aug 14, 2007 at 12:22:23AM +0100, Alan Cox wrote: > > > The only tricky part were skbs in a few drivers, but luckily they are only > > > needed for bouncing which can be done without a skb too. For RX it adds > > > one copy, but

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-14 Thread Andy Isaacson
On Sun, Aug 12, 2007 at 08:27:46PM +0800, WU Fengguang wrote: > On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: > > For some reason my mailer keeps removing you from the cc. > > Or maybe it's my SMTP server's problem. Email systems are complex. It's the Mail-Followup-To header you

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-14 Thread Andy Isaacson
On Sun, Aug 12, 2007 at 08:27:46PM +0800, WU Fengguang wrote: On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: For some reason my mailer keeps removing you from the cc. Or maybe it's my SMTP server's problem. Email systems are complex. It's the Mail-Followup-To header you

Re: [PATCH 3/4] Embed zone_id information within the zonelist-zones pointer

2007-08-14 Thread Andy Isaacson
On Tue, Aug 14, 2007 at 02:14:41AM +0200, Andi Kleen wrote: On Tue, Aug 14, 2007 at 12:22:23AM +0100, Alan Cox wrote: The only tricky part were skbs in a few drivers, but luckily they are only needed for bouncing which can be done without a skb too. For RX it adds one copy, but we can

Re: [PATCH 3/4] Embed zone_id information within the zonelist-zones pointer

2007-08-14 Thread Andy Isaacson
On Tue, Aug 14, 2007 at 10:23:51PM +0200, Andi Kleen wrote: bcm43xx hardware does show up on low-end MIPS boxes (wrt54g anybody?) that would be sorely hurt by excess copies. Lowend boxes don't have more than 1GB of RAM. With = 1GB you don't need to copy on bcm43xx. OK, that makes sense

Re: [patch 0/4] MAP_NOZERO v2 - VM_NOZERO/MAP_NOZERO early summer madness

2007-07-04 Thread Andy Isaacson
On Mon, Jul 02, 2007 at 06:55:40PM -0400, Rik van Riel wrote: > You could easily replace the cookie with a pointer to a free > page pool. It just occurred to me that something like this is *required* to get the performance benefit from MAP_NOZERO on a busy system. With Davide's current proposal,

Re: [patch 0/4] MAP_NOZERO v2 - VM_NOZERO/MAP_NOZERO early summer madness

2007-07-04 Thread Andy Isaacson
On Mon, Jul 02, 2007 at 06:55:40PM -0400, Rik van Riel wrote: You could easily replace the cookie with a pointer to a free page pool. It just occurred to me that something like this is *required* to get the performance benefit from MAP_NOZERO on a busy system. With Davide's current proposal,

Re: [patch 0/4] MAP_NOZERO v2 - VM_NOZERO/MAP_NOZERO early summer madness

2007-07-02 Thread Andy Isaacson
On Sat, Jun 30, 2007 at 08:21:52PM -0400, Kyle Moffett wrote: > That's why you'd need to call an LSM hook to get a unique identifier, > as the LSM would actually need to allocate identifiers for > equivalence classes. Secondly, processes may change labels as they > run, so you couldn't just

Re: [patch 0/4] MAP_NOZERO v2 - VM_NOZERO/MAP_NOZERO early summer madness

2007-07-02 Thread Andy Isaacson
On Sat, Jun 30, 2007 at 12:03:07PM -0700, Davide Libenzi wrote: > I think the focus should be to find a case where under the currently > implemented policy for MAP_NOZERO, MAP_NOZERO represent a loss of security > WRT no MAP_NOZERO. I have not been able to find one yet, although Andy > found

Re: [patch 0/4] MAP_NOZERO v2 - VM_NOZERO/MAP_NOZERO early summer madness

2007-07-02 Thread Andy Isaacson
On Sat, Jun 30, 2007 at 12:03:07PM -0700, Davide Libenzi wrote: I think the focus should be to find a case where under the currently implemented policy for MAP_NOZERO, MAP_NOZERO represent a loss of security WRT no MAP_NOZERO. I have not been able to find one yet, although Andy found a

Re: [patch 0/4] MAP_NOZERO v2 - VM_NOZERO/MAP_NOZERO early summer madness

2007-07-02 Thread Andy Isaacson
On Sat, Jun 30, 2007 at 08:21:52PM -0400, Kyle Moffett wrote: That's why you'd need to call an LSM hook to get a unique identifier, as the LSM would actually need to allocate identifiers for equivalence classes. Secondly, processes may change labels as they run, so you couldn't just

Re: [patch 0/4] MAP_NOZERO v2 - VM_NOZERO/MAP_NOZERO early summer madness

2007-06-29 Thread Andy Isaacson
On Thu, Jun 28, 2007 at 10:57:00PM -0400, Kyle Moffett wrote: > On Jun 28, 2007, at 14:49:24, Davide Libenzi wrote: > >So I implemented a rather quick hack that introduces a new mmap() > >flag MAP_NOZERO (only valid for anonymous mappings) and the vma > >counter-part VM_NOZERO. Also, a new

Re: [PATCH] PXA27x UDC driver.

2007-06-29 Thread Andy Isaacson
Thanks for taking the lead on this! I can't wait to have a sane PXA27x gadget driver in mainline. On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote: > +config USB_GADGET_PXA27X > + boolean "PXA 27x" > + depends on ARCH_PXA && PXA27x > + help > +Intel's PXA 27x

Re: [PATCH] PXA27x UDC driver.

2007-06-29 Thread Andy Isaacson
Thanks for taking the lead on this! I can't wait to have a sane PXA27x gadget driver in mainline. On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote: +config USB_GADGET_PXA27X + boolean PXA 27x + depends on ARCH_PXA PXA27x + help +Intel's PXA 27x series

Re: [patch 0/4] MAP_NOZERO v2 - VM_NOZERO/MAP_NOZERO early summer madness

2007-06-29 Thread Andy Isaacson
On Thu, Jun 28, 2007 at 10:57:00PM -0400, Kyle Moffett wrote: On Jun 28, 2007, at 14:49:24, Davide Libenzi wrote: So I implemented a rather quick hack that introduces a new mmap() flag MAP_NOZERO (only valid for anonymous mappings) and the vma counter-part VM_NOZERO. Also, a new

Re: [PATCH] CodingStyle: Add information about trailing whitespace.

2007-06-28 Thread Andy Isaacson
On Wed, Jun 27, 2007 at 11:58:30PM -0700, Josh Triplett wrote: > Jan Engelhardt wrote: > > On Jun 28 2007 06:29, dave young wrote: > >> IMHO, another cause of trailing whitespace is human error, for > >> example long lines breaking will easy to cause the first line with one > >> traling

Re: [patch 1/3] MAP_NOZERO - implement a new VM_NOZERO/MAP_NOZERO page retirement policy

2007-06-28 Thread Andy Isaacson
On Tue, Jun 26, 2007 at 09:32:44PM -0700, Davide Libenzi wrote: > > Because an SUID program can change its UID back. > > > > At least, one that was SUID root. OTOH, any > > program running as root can change UID, so we > > should probably not allow root to get nonzeroed > > pages. > > Well,

Re: [patch 1/3] MAP_NOZERO - implement a new VM_NOZERO/MAP_NOZERO page retirement policy

2007-06-28 Thread Andy Isaacson
On Tue, Jun 26, 2007 at 09:32:44PM -0700, Davide Libenzi wrote: Because an SUID program can change its UID back. At least, one that was SUID root. OTOH, any program running as root can change UID, so we should probably not allow root to get nonzeroed pages. Well, root can in

Re: [PATCH] CodingStyle: Add information about trailing whitespace.

2007-06-28 Thread Andy Isaacson
On Wed, Jun 27, 2007 at 11:58:30PM -0700, Josh Triplett wrote: Jan Engelhardt wrote: On Jun 28 2007 06:29, dave young wrote: IMHO, another cause of trailing whitespace is human error, for example long lines breaking will easy to cause the first line with one traling whitespace (original

Re: [PATCH] proc: maps protection

2007-03-09 Thread Andy Isaacson
On Tue, Mar 06, 2007 at 08:22:11PM -0800, Arjan van de Ven wrote: > > How about using a reduced check, as is done for fd and environ? This > > would allow root-running system monitors to still do their job. > > Effectively, this changes the test from "is ptracing" to just "can > > ptrace". >

Re: [PATCH] proc: maps protection

2007-03-09 Thread Andy Isaacson
On Tue, Mar 06, 2007 at 08:22:11PM -0800, Arjan van de Ven wrote: How about using a reduced check, as is done for fd and environ? This would allow root-running system monitors to still do their job. Effectively, this changes the test from is ptracing to just can ptrace. If this

Re: [PATCH] fix read past end of array in md/linear.c

2007-03-08 Thread Andy Isaacson
On Thu, Mar 08, 2007 at 09:37:46PM -0500, Bill Davidsen wrote: > Andy Isaacson wrote: > >% dd bs=1 seek=840716287 if=/dev/zero of=d1 count=1 > >% for i in 2 3 4; do dd if=/dev/zero of=d$i bs=1k count=$(($i+150)); done [snip] > >-for (j=i; i >

Re: [PATCH] fix read past end of array in md/linear.c

2007-03-08 Thread Andy Isaacson
On Thu, Mar 08, 2007 at 12:52:04PM -0800, Andy Isaacson wrote: > When iterating through an array, one must be careful to test one's index > variable rather than another similarly-named variable. > > The loop will read off the end of conf->disks[] in the following > (

[PATCH] fix read past end of array in md/linear.c

2007-03-08 Thread Andy Isaacson
When iterating through an array, one must be careful to test one's index variable rather than another similarly-named variable. The loop will read off the end of conf->disks[] in the following (pathological) case: % dd bs=1 seek=840716287 if=/dev/zero of=d1 count=1 % for i in 2 3 4; do dd

Re: [PATCH] fix read past end of array in md/linear.c

2007-03-08 Thread Andy Isaacson
On Thu, Mar 08, 2007 at 12:52:04PM -0800, Andy Isaacson wrote: When iterating through an array, one must be careful to test one's index variable rather than another similarly-named variable. The loop will read off the end of conf-disks[] in the following (pathological) case: % dd bs=1

[PATCH] fix read past end of array in md/linear.c

2007-03-08 Thread Andy Isaacson
When iterating through an array, one must be careful to test one's index variable rather than another similarly-named variable. The loop will read off the end of conf-disks[] in the following (pathological) case: % dd bs=1 seek=840716287 if=/dev/zero of=d1 count=1 % for i in 2 3 4; do dd

Re: [PATCH] fix read past end of array in md/linear.c

2007-03-08 Thread Andy Isaacson
On Thu, Mar 08, 2007 at 09:37:46PM -0500, Bill Davidsen wrote: Andy Isaacson wrote: % dd bs=1 seek=840716287 if=/dev/zero of=d1 count=1 % for i in 2 3 4; do dd if=/dev/zero of=d$i bs=1k count=$(($i+150)); done [snip] -for (j=i; icnt-1 sz min_spacing ; j++) +for (j=i

Re: [RFC][PATCH 2.6.19 2/6] support multiple logging agents

2006-12-13 Thread Andy Isaacson
On Tue, Dec 12, 2006 at 12:42:50PM -0600, Matt Mackall wrote: > > + new_dev = (struct netconsole_device*)kmalloc( > > + sizeof(struct netconsole_device), GFP_ATOMIC); > > Cast of void * is unnecessary. Also, 1. use kzalloc rather than kmalloc+memset 2. use p = kzalloc(sizeof(*p)

Re: [RFC][PATCH 2.6.19 2/6] support multiple logging agents

2006-12-13 Thread Andy Isaacson
On Tue, Dec 12, 2006 at 12:42:50PM -0600, Matt Mackall wrote: + new_dev = (struct netconsole_device*)kmalloc( + sizeof(struct netconsole_device), GFP_ATOMIC); Cast of void * is unnecessary. Also, 1. use kzalloc rather than kmalloc+memset 2. use p = kzalloc(sizeof(*p) rather

Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

2006-11-30 Thread Andy Isaacson
On Sat, Nov 25, 2006 at 08:15:41PM +0100, Adrian Bunk wrote: > This patch makes the needlessly global mtdpart_setup() static. > > @@ -346,7 +346,7 @@ > * > * This function needs to be visible for bootloaders. > */ > -int mtdpart_setup(char *s) > +static int mtdpart_setup(char *s) > { >

Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

2006-11-30 Thread Andy Isaacson
On Sat, Nov 25, 2006 at 08:15:41PM +0100, Adrian Bunk wrote: This patch makes the needlessly global mtdpart_setup() static. @@ -346,7 +346,7 @@ * * This function needs to be visible for bootloaders. */ -int mtdpart_setup(char *s) +static int mtdpart_setup(char *s) { cmdline

Re: question on memory barrier

2005-08-25 Thread Andy Isaacson
On Thu, Aug 25, 2005 at 11:14:03AM +0200, moreau francis wrote: > --- Andy Isaacson <[EMAIL PROTECTED]> a écrit : > > The first register write will be completed before the second register > > write because you use writel, which is defined to have the semantics you > >

Re: question on memory barrier

2005-08-25 Thread Andy Isaacson
On Thu, Aug 25, 2005 at 11:14:03AM +0200, moreau francis wrote: --- Andy Isaacson [EMAIL PROTECTED] a écrit : The first register write will be completed before the second register write because you use writel, which is defined to have the semantics you want. (It uses a platform-specific

Re: question on memory barrier

2005-08-24 Thread Andy Isaacson
On Wed, Aug 24, 2005 at 07:31:31PM +0200, moreau francis wrote: > --- "linux-os (Dick Johnson)" <[EMAIL PROTECTED]> a écrit : > > On Wed, 24 Aug 2005, moreau francis wrote: > > > I'm currently trying to write a USB driver for Linux. The device must be > > > configured by writing some values into

Re: question on memory barrier

2005-08-24 Thread Andy Isaacson
On Wed, Aug 24, 2005 at 07:31:31PM +0200, moreau francis wrote: --- linux-os (Dick Johnson) [EMAIL PROTECTED] a écrit : On Wed, 24 Aug 2005, moreau francis wrote: I'm currently trying to write a USB driver for Linux. The device must be configured by writing some values into the same

Re: [PATCH] spi

2005-08-09 Thread Andy Isaacson
The code in question is On Tue, Aug 09, 2005 at 12:05:00PM -0700, Marc Singer wrote: > > > On Mon, Aug 08, 2005 at 07:35:36PM +0200, Marcel Holtmann wrote: > > > > > > + if (NULL == dev || NULL == driver) { > > > > if (!dev || !driver) { > > > You said: > > > That's not a guaranteed

Re: [PATCH] spi

2005-08-09 Thread Andy Isaacson
On Mon, Aug 08, 2005 at 10:47:21AM -0700, Marc Singer wrote: > On Mon, Aug 08, 2005 at 07:35:36PM +0200, Marcel Holtmann wrote: > > > > + if (NULL == dev || NULL == driver) { > > > > > > Put the variable on the left side, gcc will complain if you incorrectly > > > put a "=" instead of a

Re: [PATCH] spi

2005-08-09 Thread Andy Isaacson
The code in question is On Tue, Aug 09, 2005 at 12:05:00PM -0700, Marc Singer wrote: On Mon, Aug 08, 2005 at 07:35:36PM +0200, Marcel Holtmann wrote: + if (NULL == dev || NULL == driver) { if (!dev || !driver) { You said: That's not a guaranteed equivalence in the

Re: [PATCH] spi

2005-08-09 Thread Andy Isaacson
On Mon, Aug 08, 2005 at 10:47:21AM -0700, Marc Singer wrote: On Mon, Aug 08, 2005 at 07:35:36PM +0200, Marcel Holtmann wrote: + if (NULL == dev || NULL == driver) { Put the variable on the left side, gcc will complain if you incorrectly put a = instead of a == here, which is

Re: 2.6.13rc3: crypto horribly broken on all 64bit archs

2005-07-19 Thread Andy Isaacson
e necessary casting, and use it in the places where ALIGN was used on pointers. Signed-Off-By: Andy Isaacson <[EMAIL PROTECTED]> diff -r 2b0b2208676a -r ff4d8285dcb5 crypto/cipher.c --- a/crypto/cipher.c Sun Jul 17 03:06:51 2005 +++ b/crypto/cipher.c Tue Jul 19 18:51:11 2005 @@ -43,

Re: 2.6.13rc3: crypto horribly broken on all 64bit archs

2005-07-19 Thread Andy Isaacson
it in the places where ALIGN was used on pointers. Signed-Off-By: Andy Isaacson [EMAIL PROTECTED] diff -r 2b0b2208676a -r ff4d8285dcb5 crypto/cipher.c --- a/crypto/cipher.c Sun Jul 17 03:06:51 2005 +++ b/crypto/cipher.c Tue Jul 19 18:51:11 2005 @@ -43,7 +43,7 @@ { unsigned int alignmask

Re: resuming swsusp twice

2005-07-14 Thread Andy Isaacson
On Thu, Jul 14, 2005 at 08:36:15PM +0200, Stefan Seyfried wrote: > But the failure you have seen now - failure to invalidate the resume > header - could also happen as long as we do not fix the reason for your > failure. If we fix it, we don't need additional security nets ;-) So if the header is

Re: resuming swsusp twice

2005-07-14 Thread Andy Isaacson
On Thu, Jul 14, 2005 at 04:58:12PM +0200, Stefan Seyfried wrote: > Andy Isaacson wrote: > > Yesterday I booted my laptop to 2.6.13-rc2-mm1, suspended to swsusp, > > and [snip] > > and got a panic along the lines of "Unable to find swap space, try > > a panic? it

Re: resuming swsusp twice

2005-07-14 Thread Andy Isaacson
On Thu, Jul 14, 2005 at 04:58:12PM +0200, Stefan Seyfried wrote: Andy Isaacson wrote: Yesterday I booted my laptop to 2.6.13-rc2-mm1, suspended to swsusp, and [snip] and got a panic along the lines of Unable to find swap space, try a panic? it should only be an error message

Re: resuming swsusp twice

2005-07-14 Thread Andy Isaacson
On Thu, Jul 14, 2005 at 08:36:15PM +0200, Stefan Seyfried wrote: But the failure you have seen now - failure to invalidate the resume header - could also happen as long as we do not fix the reason for your failure. If we fix it, we don't need additional security nets ;-) So if the header is

resuming swsusp twice

2005-07-13 Thread Andy Isaacson
Yesterday I booted my laptop to 2.6.13-rc2-mm1, suspended to swsusp, and then resumed. It ran fine overnight, including a fair amount of IO (running firefox, rsyncing ~/Mail/archive from my mail server, hg pull, etc). This morning I did a swsusp: echo shutdown > /sys/power/disk

resuming swsusp twice

2005-07-13 Thread Andy Isaacson
Yesterday I booted my laptop to 2.6.13-rc2-mm1, suspended to swsusp, and then resumed. It ran fine overnight, including a fair amount of IO (running firefox, rsyncing ~/Mail/archive from my mail server, hg pull, etc). This morning I did a swsusp: echo shutdown /sys/power/disk

Re: [openib-general] Re: [PATCH][RFC][0/4] InfiniBand userspace verbs implementation

2005-04-21 Thread Andy Isaacson
On Thu, Apr 21, 2005 at 01:39:35PM -0500, Timur Tabi wrote: > Andy Isaacson wrote: > >If you take the hardline position that "the app is the only thing that > >matters", your code is unlikely to get merged. Linux is a > >general-purpose OS. > > The p

Re: [openib-general] Re: [PATCH][RFC][0/4] InfiniBand userspace verbs implementation

2005-04-21 Thread Andy Isaacson
On Wed, Apr 20, 2005 at 10:07:45PM -0500, Timur Tabi wrote: > Troy Benjegerdes wrote: > >Someone (aka Tospin, infinicon, and Amasso) should probably post a patch > >adding '#define VM_REGISTERD 0x0100', and some extensions to > >something like 'madvise' to set pages to be registered. > > > >My

Re: [openib-general] Re: [PATCH][RFC][0/4] InfiniBand userspace verbs implementation

2005-04-21 Thread Andy Isaacson
On Wed, Apr 20, 2005 at 10:07:45PM -0500, Timur Tabi wrote: Troy Benjegerdes wrote: Someone (aka Tospin, infinicon, and Amasso) should probably post a patch adding '#define VM_REGISTERD 0x0100', and some extensions to something like 'madvise' to set pages to be registered. My preference

Re: [openib-general] Re: [PATCH][RFC][0/4] InfiniBand userspace verbs implementation

2005-04-21 Thread Andy Isaacson
On Thu, Apr 21, 2005 at 01:39:35PM -0500, Timur Tabi wrote: Andy Isaacson wrote: If you take the hardline position that the app is the only thing that matters, your code is unlikely to get merged. Linux is a general-purpose OS. The problem is that our driver and library implement an API

Re: [PATCH encrypted swsusp 1/3] core functionality

2005-04-14 Thread Andy Isaacson
On Thu, Apr 14, 2005 at 12:53:52PM -0700, Matt Mackall wrote: > On Thu, Apr 14, 2005 at 09:27:22PM +0200, Stefan Seyfried wrote: > > Matt Mackall wrote: > > > Any sensible solution here is going to require remembering passwords. > > > And arguably anywhere the user needs encrypted suspend, they'll

encrypted swap (was Re: [PATCH encrypted swsusp 1/3] core functionality)

2005-04-14 Thread Andy Isaacson
On Thu, Apr 14, 2005 at 09:39:04AM +1000, Herbert Xu wrote: > > Andreas is right. They are encrypted in swap, but they should not be > > there at all. And they are encrypted by key that is still available > > after resume. Bad. > > The dmcrypt swap can only be unlocked by the user with a

Re: Call to atention about using hash functions as content indexers (SCM saga)

2005-04-14 Thread Andy Isaacson
On Tue, Apr 12, 2005 at 06:35:49PM +0200, Eric Rannaud wrote: > Simply put, the best known attack of SHA-1 takes 2^69 hash operations. > ( http://www.schneier.com/blog/archives/2005/02/sha1_broken.html ) > The attack is still only an unpublished paper and has not yet been > implemented. An attack

Re: Call to atention about using hash functions as content indexers (SCM saga)

2005-04-14 Thread Andy Isaacson
On Tue, Apr 12, 2005 at 06:35:49PM +0200, Eric Rannaud wrote: Simply put, the best known attack of SHA-1 takes 2^69 hash operations. ( http://www.schneier.com/blog/archives/2005/02/sha1_broken.html ) The attack is still only an unpublished paper and has not yet been implemented. An attack is:

encrypted swap (was Re: [PATCH encrypted swsusp 1/3] core functionality)

2005-04-14 Thread Andy Isaacson
On Thu, Apr 14, 2005 at 09:39:04AM +1000, Herbert Xu wrote: Andreas is right. They are encrypted in swap, but they should not be there at all. And they are encrypted by key that is still available after resume. Bad. The dmcrypt swap can only be unlocked by the user with a passphrase,

Re: [PATCH encrypted swsusp 1/3] core functionality

2005-04-14 Thread Andy Isaacson
On Thu, Apr 14, 2005 at 12:53:52PM -0700, Matt Mackall wrote: On Thu, Apr 14, 2005 at 09:27:22PM +0200, Stefan Seyfried wrote: Matt Mackall wrote: Any sensible solution here is going to require remembering passwords. And arguably anywhere the user needs encrypted suspend, they'll want

2.6.12-rc1-mm1: e100 fails to resume from swsusp

2005-04-07 Thread Andy Isaacson
Sorry for this poor bugreport, but I haven't had time to track it down more carefully. Hardware: Vaio r505te, i815, onboard e100 Kernel: 2.6.12-rc1-mm1 plus patch to fix GlidePoint resume hang After a swsusp resume, the onboard e100 does not pass traffic. When I was running 2.6.11-rc2 (IIRC)

2.6.12-rc1-mm1: e100 fails to resume from swsusp

2005-04-07 Thread Andy Isaacson
Sorry for this poor bugreport, but I haven't had time to track it down more carefully. Hardware: Vaio r505te, i815, onboard e100 Kernel: 2.6.12-rc1-mm1 plus patch to fix GlidePoint resume hang After a swsusp resume, the onboard e100 does not pass traffic. When I was running 2.6.11-rc2 (IIRC)

Re: problem with suspending linux-2.6.12-rc1

2005-03-30 Thread Andy Isaacson
On Tue, Mar 29, 2005 at 12:20:49AM +0200, Pavel Machek wrote: > On Po 28-03-05 10:03:06, Ulrich Lauther wrote: > > > > since upgrading from 2.6.11 to 2.6.12-rc1 software suspend doesn't work > > > > anymore for me: > > > > The last I see when suspending (echo 4 > /proc/acpi/sleep) is a > > > >

Re: problem with suspending linux-2.6.12-rc1

2005-03-30 Thread Andy Isaacson
On Tue, Mar 29, 2005 at 12:20:49AM +0200, Pavel Machek wrote: On Po 28-03-05 10:03:06, Ulrich Lauther wrote: since upgrading from 2.6.11 to 2.6.12-rc1 software suspend doesn't work anymore for me: The last I see when suspending (echo 4 /proc/acpi/sleep) is a message refering to

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Andy Isaacson
On Fri, Mar 25, 2005 at 09:58:40AM -0500, Dmitry Torokhov wrote: > I wonder why ALPS reconnect failed. You don't have a serial console > set up, do you? If not then maybe you could make a huge framebuffer to > capture as much info as you can... I hope you have a digital camera ;) No serial ports

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Andy Isaacson
On Tue, Mar 29, 2005 at 01:42:26PM -0500, Dmitry Torokhov wrote: > Could you please try the patch below - it should fix the issues you are [snip] > --- dtor.orig/drivers/input/serio/serio.c > +++ dtor/drivers/input/serio/serio.c > if (!serio->drv || !serio->drv->reconnect || >

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Andy Isaacson
On Tue, Mar 29, 2005 at 01:42:26PM -0500, Dmitry Torokhov wrote: Could you please try the patch below - it should fix the issues you are [snip] --- dtor.orig/drivers/input/serio/serio.c +++ dtor/drivers/input/serio/serio.c if (!serio-drv || !serio-drv-reconnect ||

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Andy Isaacson
On Fri, Mar 25, 2005 at 09:58:40AM -0500, Dmitry Torokhov wrote: I wonder why ALPS reconnect failed. You don't have a serial console set up, do you? If not then maybe you could make a huge framebuffer to capture as much info as you can... I hope you have a digital camera ;) No serial ports

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-25 Thread Andy Isaacson
On Fri, Mar 25, 2005 at 11:13:44AM +0100, Pavel Machek wrote: > Hi! > > > > OK, anything else I should try? > > > > not really, i just wait for Vojtech and Pavel :-) > > Try commenting out "call_usermodehelper". If that helps, Stefan's > theory is confirmed, and this waits for Vojtech to fix

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-25 Thread Andy Isaacson
On Fri, Mar 25, 2005 at 11:13:44AM +0100, Pavel Machek wrote: Hi! OK, anything else I should try? not really, i just wait for Vojtech and Pavel :-) Try commenting out call_usermodehelper. If that helps, Stefan's theory is confirmed, and this waits for Vojtech to fix it.

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-24 Thread Andy Isaacson
On Thu, Mar 24, 2005 at 04:10:39PM -0500, Dmitry Torokhov wrote: > If you do "ls /sys/bus/serio/devices" and see more than 3 ports you > have MUX mode active. Just serio0 and serio1. On Thu, Mar 24, 2005 at 04:14:52PM -0500, Dmitry Torokhov wrote: > On Thu, 24 Mar 2005 1

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-24 Thread Andy Isaacson
On Thu, Mar 24, 2005 at 02:18:40PM -0500, Dmitry Torokhov wrote: > On Thu, 24 Mar 2005 10:10:59 -0800, Andy Isaacson <[EMAIL PROTECTED]> wrote: > > So I added i8042.noaux to my kernel command line, rebooted, insmodded > > intel_agp, started X, and verified no touchpad action.

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-24 Thread Andy Isaacson
On Thu, Mar 24, 2005 at 03:27:15PM +0100, Stefan Seyfried wrote: > Andy Isaacson wrote: > > Dmesg is attached; hardware is a Vaio r505te. > > > > Unfortunately, the deadlock (?) is nondeterministic; it *sometimes* > > suspends successfully, maybe one time out o

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-24 Thread Andy Isaacson
On Thu, Mar 24, 2005 at 03:27:15PM +0100, Stefan Seyfried wrote: Andy Isaacson wrote: Dmesg is attached; hardware is a Vaio r505te. Unfortunately, the deadlock (?) is nondeterministic; it *sometimes* suspends successfully, maybe one time out of 10. And thinking back, I *sometimes* saw

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-24 Thread Andy Isaacson
On Thu, Mar 24, 2005 at 02:18:40PM -0500, Dmitry Torokhov wrote: On Thu, 24 Mar 2005 10:10:59 -0800, Andy Isaacson [EMAIL PROTECTED] wrote: So I added i8042.noaux to my kernel command line, rebooted, insmodded intel_agp, started X, and verified no touchpad action. Then I suspended

Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-24 Thread Andy Isaacson
On Thu, Mar 24, 2005 at 04:10:39PM -0500, Dmitry Torokhov wrote: If you do ls /sys/bus/serio/devices and see more than 3 ports you have MUX mode active. Just serio0 and serio1. On Thu, Mar 24, 2005 at 04:14:52PM -0500, Dmitry Torokhov wrote: On Thu, 24 Mar 2005 12:20:40 -0800, Andy Isaacson

swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-23 Thread Andy Isaacson
I was previously running 2.6.11-rc3 and swsusp was working quite nicely: echo shutdown > /sys/power/disk echo disk > /sys/power/state Now I've upgraded to 2.6.12-rc1, 423b66b6oJOGN68OhmSrBFxxLOtIEA, and it no longer works reliably. Almost every time I do the above it blocks in device_resume() (I

swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-23 Thread Andy Isaacson
I was previously running 2.6.11-rc3 and swsusp was working quite nicely: echo shutdown /sys/power/disk echo disk /sys/power/state Now I've upgraded to 2.6.12-rc1, 423b66b6oJOGN68OhmSrBFxxLOtIEA, and it no longer works reliably. Almost every time I do the above it blocks in device_resume() (I

Re: 2.6.11-rc4: Alps touchpad too slow

2005-03-21 Thread Andy Isaacson
On Mon, Mar 21, 2005 at 02:44:12PM -0800, Andrew Morton wrote: > Andy Isaacson <[EMAIL PROTECTED]> wrote: > > My Vaio r505te comes up with an unusably slow touchpad if I allow the > > ALPS driver to drive it. It says > > > > > ALPS Touchpad (Glidepoint)

Re: 2.6.11-rc4: Alps touchpad too slow

2005-03-21 Thread Andy Isaacson
On Mon, Mar 21, 2005 at 02:44:12PM -0800, Andrew Morton wrote: Andy Isaacson [EMAIL PROTECTED] wrote: My Vaio r505te comes up with an unusably slow touchpad if I allow the ALPS driver to drive it. It says ALPS Touchpad (Glidepoint) detected Disabling hardware tapping input

2.6.11-rc4: Alps touchpad too slow

2005-03-04 Thread Andy Isaacson
My Vaio r505te comes up with an unusably slow touchpad if I allow the ALPS driver to drive it. It says > ALPS Touchpad (Glidepoint) detected > Disabling hardware tapping > input: AlpsPS/2 ALPS TouchPad on isa0060/serio1 and then the trackpad operates at about 1/8 the speed I've gotten used

2.6.11-rc4: Alps touchpad too slow

2005-03-04 Thread Andy Isaacson
My Vaio r505te comes up with an unusably slow touchpad if I allow the ALPS driver to drive it. It says ALPS Touchpad (Glidepoint) detected Disabling hardware tapping input: AlpsPS/2 ALPS TouchPad on isa0060/serio1 and then the trackpad operates at about 1/8 the speed I've gotten used to.

Re: VM disk cache behavior.

2005-02-08 Thread Andy Isaacson
On Tue, Feb 08, 2005 at 12:06:14PM -0500, jon ross wrote: > I have an app with a small fixed memory footprint that does a lot of > random reads from a large file. I thought if I added more memory to > the machine the VM would do more caching of the disk, but added memory > does not seem to make

Re: VM disk cache behavior.

2005-02-08 Thread Andy Isaacson
On Tue, Feb 08, 2005 at 12:06:14PM -0500, jon ross wrote: I have an app with a small fixed memory footprint that does a lot of random reads from a large file. I thought if I added more memory to the machine the VM would do more caching of the disk, but added memory does not seem to make any

Re: Drive performance bottleneck

2005-02-04 Thread Andy Isaacson
On Thu, Feb 03, 2005 at 07:03:48PM +, Paulo Marques wrote: > FYI there was a patch running around last April that made a new option > for "dd" to make it use O_DIRECT. You can get it here: > > http://marc.theaimsgroup.com/?l=linux-kernel=108135935629589=2 > > Unfortunately this hasn't made

Re: Drive performance bottleneck

2005-02-04 Thread Andy Isaacson
On Thu, Feb 03, 2005 at 07:03:48PM +, Paulo Marques wrote: FYI there was a patch running around last April that made a new option for dd to make it use O_DIRECT. You can get it here: http://marc.theaimsgroup.com/?l=linux-kernelm=108135935629589w=2 Unfortunately this hasn't made it

Re: Why does the kernel need a gig of VM?

2005-01-28 Thread Andy Isaacson
On Fri, Jan 28, 2005 at 03:06:15PM -0500, John Richard Moser wrote: > Can someone give me a layout of what exactly is up there? I got the > basic idea > > K 4G > A 3G > A 2G > A 1G > > App has 3G, kernel has 1G at the top of VM on x86 (dunno about x86_64). > > So what's the layout of that top

Re: Why does the kernel need a gig of VM?

2005-01-28 Thread Andy Isaacson
On Fri, Jan 28, 2005 at 03:06:15PM -0500, John Richard Moser wrote: Can someone give me a layout of what exactly is up there? I got the basic idea K 4G A 3G A 2G A 1G App has 3G, kernel has 1G at the top of VM on x86 (dunno about x86_64). So what's the layout of that top 1G? What's

Re: netdev-2.6 queue updated

2005-01-27 Thread Andy Isaacson
On Thu, Jan 27, 2005 at 07:00:32PM -0500, Jeff Garzik wrote: > The attached changelog describes what I just pushed out to BitKeeper > (and what should be appearing in the next -mm release from Andrew). > > Note to BK users: please re-clone netdev-2.6, don't just 'bk pull'. It's much more

Re: netdev-2.6 queue updated

2005-01-27 Thread Andy Isaacson
On Thu, Jan 27, 2005 at 07:00:32PM -0500, Jeff Garzik wrote: The attached changelog describes what I just pushed out to BitKeeper (and what should be appearing in the next -mm release from Andrew). Note to BK users: please re-clone netdev-2.6, don't just 'bk pull'. It's much more efficient

  1   2   >