On Sun, Mar 28, 2021 at 9:47 AM Greg Kroah-Hartman
wrote:
>
> On Sun, Mar 28, 2021 at 12:20:07AM +0200, Andy Shevchenko wrote:
> > It's very convenient to see what properties and their values
> > are currently being assigned in the registered software nodes.
>
On Sun, Mar 28, 2021 at 11:47 AM Greg Kroah-Hartman
wrote:
>
> On Sun, Mar 28, 2021 at 12:20:09AM +0200, Andy Shevchenko wrote:
> > Since we don't use structure field layout randomization
> > the manual shuffling can affect some macros, in particular
> > kobj_to_swnode(
On Sun, Mar 28, 2021 at 11:48 AM Greg Kroah-Hartman
wrote:
>
> On Sun, Mar 28, 2021 at 12:20:10AM +0200, Andy Shevchenko wrote:
> > By introducing two temporary variables simplify swnode_register() a bit.
> > No functional change intended.
> >
> >
On Sun, Mar 28, 2021 at 12:23 AM Al Viro wrote:
>
> On Fri, Mar 26, 2021 at 07:03:47PM +0200, Andy Shevchenko wrote:
> > The bitmap.h header is used in a lot of code around the kernel.
> > Besides that it includes kernel.h which sometimes makes a loop.
>
> How much of the
This is useful to assign software node reference with arguments
in a common way. Moreover, we have already couple of users that
may be converted. And by the fact, one of them is moved right here
to use the helper.
Signed-off-by: Andy Shevchenko
---
drivers/base/test/property-entry-test.c | 11
)
Total: Before=7217, After=7126, chg -1.26%
Signed-off-by: Andy Shevchenko
---
drivers/base/swnode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index 22f81688af2c..ae53c48f84b1 100644
--- a/drivers/base/swnode.c
+++ b/drivers
It's very convenient to see what properties and their values
are currently being assigned in the registered software nodes.
Show properties and their values in sysfs.
Signed-off-by: Andy Shevchenko
---
drivers/base/swnode.c | 137 --
1 file changed, 132
By introducing two temporary variables simplify swnode_register() a bit.
No functional change intended.
Signed-off-by: Andy Shevchenko
---
drivers/base/swnode.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index
This is useful to assign software node reference with arguments
in a common way. Switch to use SOFTWARE_NODE_REFERENCE() here.
Signed-off-by: Andy Shevchenko
---
drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/pci
nly in fwnode_create_software_node().
Signed-off-by: Andy Shevchenko
---
drivers/base/swnode.c | 29 +
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index fa3719ef80e4..456f5fe58b58 100644
--- a/drivers/b
Deduplicate conditional and assignment in fwnode_create_software_node(),
i.e. parent is checked in two out of three cases and parent software node
is assigned by to_swnode() call.
Signed-off-by: Andy Shevchenko
---
drivers/base/swnode.c | 17 -
1 file changed, 8 insertions(+), 9
Introduce software_node_alloc() and software_node_free() helpers.
This will help with code readability and maintenance.
Signed-off-by: Andy Shevchenko
---
drivers/base/swnode.c | 47 ++-
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git
On Sat, Mar 27, 2021 at 8:18 PM Daniel Gomez wrote:
> On Fri, 26 Mar 2021 at 13:28, Andy Shevchenko
> wrote:
> > On Fri, Mar 26, 2021 at 11:35:08AM +0100, Daniel Gomez wrote:
...
> > It's a good question. On one hand we know that resource_size_t is a simple
> > red
On Sat, Mar 27, 2021 at 3:39 PM Joe Perches wrote:
>
> On Sat, 2021-03-27 at 10:19 +0200, Andy Shevchenko wrote:
> > On Saturday, March 27, 2021, Xiaofei Tan wrote:
> >
> > > Fix some coding style issues reported by checkpatch.pl, including
> > >
On Sat, Mar 27, 2021 at 2:02 PM William Breathitt Gray
wrote:
> On Sat, Mar 27, 2021 at 09:29:26AM +0200, Andy Shevchenko wrote:
> > On Saturday, March 27, 2021, Syed Nayyar Waris wrote:
> > > On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko
> > > wrote:
> > &
do on broken devices that do change their state based on that
bit while violating specification).
In any case
Acked-by: Andy Shevchenko
for DesignWare DMA case. I have added that and I never saw that IP connected
to the old PCI.
--
With Best Regards,
Andy Shevchenko
gt; +
Extra blank line.
> +MODULE_DEVICE_TABLE(of, realtek_gpio_of_match);
...
> + iowrite32(GENMASK(31, 0), ctrl->base + REALTEK_GPIO_REG_ISR);
This one perhaps needs a comment like "cleaning all IRQ states".
Note, we have a proper callback for this, i.e. hw_init. Consider to use it.
...
> +};
> +
Extra blank line.
> +builtin_platform_driver(realtek_gpio_driver);
...
So, looking into the code, I think you may easily get rid of 30-50 LOCs.
So, expecting <= 300 LOCs in v5.
--
With Best Regards,
Andy Shevchenko
et_value(new, 64, state[1], 32, 32);
Ditto.
--
With Best Regards,
Andy Shevchenko
k(>gpio_lock[1]);
> + spin_unlock_irqrestore(>gpio_lock[0], flags);
--
With Best Regards,
Andy Shevchenko
On Fri, Mar 26, 2021 at 3:33 PM Matti Vaittinen
wrote:
> On Fri, 2021-03-26 at 13:26 +0200, Andy Shevchenko wrote:
> > On Wed, Mar 24, 2021 at 12:20 PM Matti Vaittinen
> > wrote:
...
> > > + return (val >> offset) & 1;
> >
> > !!(val &a
Module doesn't use OF APIs anyhow, make it OF independent by replacing
headers and dropping useless of_match_ptr() call.
Signed-off-by: Andy Shevchenko
---
drivers/mux/gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
index
Use already prepared dev_err_probe() introduced by the commit
a787e5400a1c ("driver core: add device probe log helper").
It simplifies EPROBE_DEFER handling.
Signed-off-by: Andy Shevchenko
---
drivers/mux/gpio.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git
Assigning bitmaps like it's done in the driver might be error prone.
Fix this by using bitmap API.
Signed-off-by: Andy Shevchenko
---
drivers/mux/gpio.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c
index 02c1f2c014e8
The bitmap.h header is used in a lot of code around the kernel.
Besides that it includes kernel.h which sometimes makes a loop.
Break the loop by introducing align.h, including it in kernel.h
and bitmap.h followed by replacing kernel.h with limits.h.
Signed-off-by: Andy Shevchenko
---
include
-const place holders in the intel_quark_i2c_setup() and
intel_quark_gpio_setup().
Reported-by: Linus Torvalds
Signed-off-by: Andy Shevchenko
---
v2: eliminated bar parameter (Lee)
drivers/mfd/intel_quark_i2c_gpio.c | 26 --
1 file changed, 12 insertions(+), 14 deletions
On Fri, Mar 26, 2021 at 11:35:08AM +0100, Daniel Gomez wrote:
> On Thu, 25 Mar 2021 at 16:43, Andy Shevchenko
> wrote:
> > On Thu, Mar 25, 2021 at 04:12:48PM +0100, Daniel Gomez wrote:
...
> > > Add i2c hw base address in the adapter name and when the device is
> > &g
On Fri, Mar 26, 2021 at 1:26 PM Andy Shevchenko
wrote:
> On Wed, Mar 24, 2021 at 12:20 PM Matti Vaittinen
> wrote:
> > +#include
>
> You may do better than be OF-centric. See below.
Ah, yep, when you switch to unified device property API, you would
need property.h and
river);
> +/* Note: this hardware lives inside an I2C-based multi-function device. */
> +MODULE_ALIAS("platform:bd71815-gpo");
> +
Ditto.
> +MODULE_AUTHOR("Peter Yang ");
And I don't see a match with a committer/submitter/co-developer/etc.
Please, make corresponding fields and this macro (or macros, you may
have as many MODULE_AUTHOR() entries as developers of the code)
aligned to each other.
> +MODULE_DESCRIPTION("GPO interface for BD71815");
> +MODULE_LICENSE("GPL");
--
With Best Regards,
Andy Shevchenko
s *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
Joe, seems you missed this part of Rob's message when resending.
--
With Best Regards,
Andy Shevchenko
ents
[1]. Have you seen them?
[1]:
https://lore.kernel.org/linux-iio/cahp75vcsw2xxdh--rxan7xt0ju+qfw9c_va0ggrgpgpbua0...@mail.gmail.com/
Please. address and come again.
NAK for this version, sorry.
--
With Best Regards,
Andy Shevchenko
On Fri, Mar 26, 2021 at 03:53:34PM +0530, Goswami, Sanket wrote:
> On 25-Mar-21 22:35, Andy Shevchenko wrote:
> > On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote:
> >> On 09-Mar-21 19:56, Andy Shevchenko wrote:
> >>> On Tue, Mar 09, 2021 at 07:01:47
On Thu, Mar 25, 2021 at 9:31 PM Linus Torvalds
wrote:
>
> On Thu, Mar 25, 2021 at 12:23 PM Andy Shevchenko
> wrote:
> >
> > Replace cell parameter by bar and assign local pointer res to the
> > respective non-const place holder in the intel_quark_i2c_setup()
>
to the
respective non-const place holder in the intel_quark_i2c_setup()
and intel_quark_gpio_setup().
Reported-by: Linus Torvalds
Signed-off-by: Andy Shevchenko
---
drivers/mfd/intel_quark_i2c_gpio.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers
use that intel_quark_mfd_cells[]
> directly like suggested above).
Thanks for pointing this out! I'll take it in my TODO list.
Hmm... I missed the above b/c I have seen the pattern of supplying non-const
data structures via .driver_data field and thought that here is something
similar without looking into the actual approach.
--
With Best Regards,
Andy Shevchenko
(different
base types)
.../pch_gbe_main.c:158:56:expected unsigned short [usertype] seqid
.../pch_gbe_main.c:158:56:got restricted __be16 [usertype]
Fix that by switching to use proper accessors to BE data.
Signed-off-by: Andy Shevchenko
---
.../ethernet/oki-semi/pch_gbe
Use readx_poll_timeout_atomic() instead of open coded variants.
While at it, add __iomem attribute to the parameter of pch_gbe_wait_clr_bit().
Signed-off-by: Andy Shevchenko
---
.../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 27 ++-
1 file changed, 8 insertions(+), 19
anymore.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 2 --
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 2 ++
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c| 4
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git
This switches the PCH GBE driver to use GPIO descriptors.
Signed-off-by: Andy Shevchenko
---
.../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 45 +--
1 file changed, 32 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
b/drivers
If GPIO controller is not available yet we need to defer
the probe of GBE until provider will become available.
While here, drop GPIOF_EXPORT because it's deprecated and
may not be available.
Fixes: f1a26fdf5944 ("pch_gbe: Add MinnowBoard support")
Signed-off-by: Andy Shevchenko
--
. Patch 5 is MODULE_VERSION() clean up.
Tested on Intel Minnowboard (v1).
Since v2:
- added a few cleanups on top of the fix
Andy Shevchenko (5):
net: pch_gbe: Propagate error from devm_gpio_request_one()
net: pch_gbe: Convert to use GPIO descriptors
net: pch_gbe: use readx_poll_timeout_atomic
On Mon, Mar 22, 2021 at 10:26:55PM +0530, Goswami, Sanket wrote:
> On 09-Mar-21 19:56, Andy Shevchenko wrote:
> > On Tue, Mar 09, 2021 at 07:01:47PM +0530, Sanket Goswami wrote:
...
> >> +static int amd_i2c_dw_master_xfer(struct i2c_adapter *adap, struct
> >>
On Wed, Mar 24, 2021 at 11:23:10PM +0200, Andy Shevchenko wrote:
> If GPIO controller is not available yet we need to defer
> the probe of GBE until provider will become available.
>
> While here, drop GPIOF_EXPORT because it's deprecated and
> may not be available.
I'll send
On Thu, Mar 25, 2021 at 11:20:28PM +0800, Wan Jiabing wrote:
> struct task_struct has been declared.
"...declared twice."
In the subject line the "include: linux: " part is not needed.
FWIW, after addressing above,
Reviewed-by: Andy Shevchenko
> Remove the duplicat
to
print it. Moreover, we have %pR (and %pr) specifiers for struct resource.
...
> + dev_info(>dev, "%s\n", adap->name);
Unneeded noise.
--
With Best Regards,
Andy Shevchenko
We don't need DMI to identify Intel Minnowboard (v1) since it has
properly set PCI sub IDs. So, drop unneeded DMI level of identification.
Signed-off-by: Andy Shevchenko
---
drivers/usb/gadget/udc/pch_udc.c | 91 +++-
1 file changed, 44 insertions(+), 47 deletions
Unify quirks, in particular one for Intel Quark, to use driver data
and accompanying infrastructure.
Signed-off-by: Andy Shevchenko
---
drivers/usb/gadget/udc/pch_udc.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/udc/pch_udc.c
We have generic implementations for a reason, let's use them.
Signed-off-by: Andy Shevchenko
---
drivers/usb/gadget/udc/pch_udc.c | 78 +++-
1 file changed, 6 insertions(+), 72 deletions(-)
diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc
Use __maybe_unused for the suspend()/resume() hooks and get rid of
the CONFIG_PM_SLEEP ifdefery to improve the code.
Signed-off-by: Andy Shevchenko
---
drivers/usb/gadget/udc/pch_udc.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/gadget/udc
On Thu, Mar 25, 2021 at 03:22:22PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote:
> > struct task_struct is declared at 9th line. Remove the duplicate.
>
> It seems the duplicate is the other one and you removed wrong one.
Okay, they
locking_selftest() do { } while (0)
> #endif
>
> -struct task_struct;
>
> #ifdef CONFIG_LOCKDEP
> extern void debug_show_all_locks(void);
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
a PCI device BAR or marked as reserved in
> the host memory map.
Applied for fixes, thanks!
> 91d898e51e60 ('pinctrl: intel: Convert capability list to features')
> Suggested-by: Andy Shevchenko
> Signed-off-by: Roger Pau Monné
> ---
> Changes since v2:
> - Return ENODEV.
> - A
On Thu, Mar 25, 2021 at 09:46:46AM +0100, Roger Pau Monné wrote:
> On Wed, Mar 24, 2021 at 06:57:12PM +0200, Andy Shevchenko wrote:
> > On Wed, Mar 24, 2021 at 04:13:59PM +0100, Roger Pau Monné wrote:
> > > On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote:
>
On Thu, Mar 25, 2021 at 09:13:51AM +0100, Linus Walleij wrote:
> On Wed, Mar 17, 2021 at 4:19 PM Andy Shevchenko
> wrote:
>
> > From: Jan Kiszka
> >
> > Add the required infrastructure to enable and report edge events
> > of the pins to the GPIO core. The actu
If GPIO controller is not available yet we need to defer
the probe of GBE until provider will become available.
While here, drop GPIOF_EXPORT because it's deprecated and
may not be available.
Fixes: f1a26fdf5944 ("pch_gbe: Add MinnowBoard support")
Signed-off-by: Andy Shevchenko
--
2 vamax_size;
> + u32 rsvd_size;
> + u32 pd_size;
> +};
Missed types.h.
> +struct gna_desc_info {
> + u32 rsvd_size;
> + u32 cfg_size;
> + u32 desc_size;
> + struct gna_mmu_info mmu_info;
> +};
> +
> +struct gna_private;
> +struct gna_compute_cfg;
> +
> +void gna_abort_hw(struct gna_private *gna_priv);
> +bool gna_hw_perf_enabled(struct gna_private *gna_priv);
> +int gna_parse_hw_status(struct gna_private *gna_priv, u32 hw_status);
> +void gna_print_error_status(struct gna_private *gna_priv, u32 hw_status);
> +void gna_start_scoring(struct gna_private *gna_priv, void __iomem *addr,
Missed header for __iomem (but I guess it's guaranteed to be included
by types.h, double check this).
> + struct gna_compute_cfg *compute_cfg);
> +
> +#define gna_reg_read(addr, offset) readl((addr) + (offset))
> +#define gna_reg_write(addr, offset, value) writel((value), (addr) +
> (offset))
No point And make them functions, not macros.
> +
> +#endif // __GNA_HW_H__
> --
> 2.28.0
>
--
With Best Regards,
Andy Shevchenko
0-5F drivers/scsi/dpt/dtpi_ioctl.h
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bfc1b86e3e73..da926aa4523c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8928,6 +8928,13 @@ S: Maintained
> F: Documentation/fb/intelfb.rst
> F: drivers/video/fbdev/intelfb/
>
isc/intel/gna/gna_hw.c
> create mode 100644 drivers/misc/intel/gna/gna_hw.h
> create mode 100644 drivers/misc/intel/gna/gna_ioctl.c
> create mode 100644 drivers/misc/intel/gna/gna_ioctl.h
> create mode 100644 drivers/misc/intel/gna/gna_mem.c
> create mode 100644 drivers/misc/i
Allow interrupts to be MSI if supported by hardware.
Signed-off-by: Andy Shevchenko
---
v4: rebased on clean for-mfd-next branch (Lee)
drivers/mfd/intel_quark_i2c_gpio.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd
; from crashing the kernel if the capability linked list is somehow
> broken.
I don't think we need a dead code in the kernel. If you have a hardware to show
this issue, I eagerly want to know this!
--
With Best Regards,
Andy Shevchenko
; region(s) are not exposed on a PCI device BAR or marked as reserved in
> the host memory map.
Any particular point that we can use in the Fixes tag?
...
> Suggested-by: Andy Shevchenko
Hmm... was it that address I have used? In any case I think my @linux.intel.com
is better.
...
>
On Wed, Mar 24, 2021 at 04:13:59PM +0100, Roger Pau Monné wrote:
> On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote:
> > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote:
> > > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote:
>
On Wed, Mar 24, 2021 at 03:25:02PM +, Lee Jones wrote:
> On Wed, 24 Mar 2021, Andy Shevchenko wrote:
>
> > Allow interrupts to be MSI if supported by hardware.
> >
> > Signed-off-by: Andy Shevchenko
> > ---
> > v3: added a comment about
On Wed, Mar 24, 2021 at 03:10:35PM +, Lee Jones wrote:
> On Wed, 24 Mar 2021, Andy Shevchenko wrote:
> > On Wed, Mar 24, 2021 at 01:07:23PM +, Lee Jones wrote:
> > > On Wed, 24 Mar 2021, Andy Shevchenko wrote:
> > > > On Wed, Mar 24, 2021 at 11:
Allow interrupts to be MSI if supported by hardware.
Signed-off-by: Andy Shevchenko
---
v3: added a comment about magic 1s (Lee)
drivers/mfd/intel_quark_i2c_gpio.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/intel_quark_i2c_gpio.c
b
On Tue, Mar 23, 2021 at 11:53 PM Wesley Cheng wrote:
>
>
>
> On 3/23/2021 10:27 AM, Andy Shevchenko wrote:
> > On Tue, Mar 23, 2021 at 1:19 AM Wesley Cheng wrote:
> >>
> >> Hi Andy,
> >>
> >> On 3/22/2021 2:14 PM, Andy Shevchenko wrot
On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote:
> On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote:
> > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote:
...
> What could be done is check whether reading REVID returns ~0 and exit
>
On Wed, Mar 24, 2021 at 01:07:23PM +, Lee Jones wrote:
> On Wed, 24 Mar 2021, Andy Shevchenko wrote:
>
> > On Wed, Mar 24, 2021 at 11:50:33AM +, Lee Jones wrote:
> > > On Wed, 24 Mar 2021, Andy Shevchenko wrote:
> > >
> > > > On Wed, Mar 24,
Some architectures do not provide devm_*() APIs. Hence make the driver
dependent on HAVE_IOMEM.
Fixes: dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
Reported-by: kernel test robot
Signed-off-by: Andy Shevchenko
---
v2: used proper option (Serge)
drivers/dma/dw/K
On Wed, Mar 24, 2021 at 04:51:16PM +0300, Serge Semin wrote:
> Hi Andy
>
> On Wed, Mar 24, 2021 at 02:18:22PM +0200, Andy Shevchenko wrote:
> > Some architectures do not provide devm_*() APIs. Hence make the driver
> > dependent on HAVE_IOMEM.
>
> You must have mean
hese drivers or
check with something like pci_device_is_present() approach.
> Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features')
> Signed-off-by: Roger Pau Monné
> ---
> Cc: Mika Westerberg
> Cc: Andy Shevchenko
> Cc: Linus Walleij
> Cc: linux-g...@
On Wed, Mar 24, 2021 at 11:50:33AM +, Lee Jones wrote:
> On Wed, 24 Mar 2021, Andy Shevchenko wrote:
>
> > On Wed, Mar 24, 2021 at 10:47:29AM +, Lee Jones wrote:
> > > On Wed, 24 Mar 2021, Andy Shevchenko wrote:
> > > > On Wed, Mar 24, 2021 at
Some architectures do not provide devm_*() APIs. Hence make the driver
dependent on HAVE_IOMEM.
Fixes: dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
Reported-by: kernel test robot
Signed-off-by: Andy Shevchenko
---
drivers/dma/dw/Kconfig | 2 ++
1 file changed, 2
h as possible,
please.
--
With Best Regards,
Andy Shevchenko
el0_svc_compat+0x10/0x1c
> el0_sync_compat_handler+0xa8/0xcc
> el0_sync_compat+0x178/0x180
> ---[ end trace 3d95032303e59e68 ]---
>
> The hex string aa23f7a1231c229de205662d5a9e0d4c580f19a1 is the build ID,
> following the kernel version number.
--
With Best Regards,
Andy Shevchenko
On Wed, Mar 24, 2021 at 10:47:29AM +, Lee Jones wrote:
> On Wed, 24 Mar 2021, Andy Shevchenko wrote:
> > On Wed, Mar 24, 2021 at 10:29:31AM +, Lee Jones wrote:
> > > On Tue, 23 Mar 2021, Andy Shevchenko wrote:
...
> Also, past acceptance does not guarante
s not have IOMEM (IIRC). I forgot how it's usually fixed.
Again IIRC it should be done somewhere in the generic files, otherwise we have
to have add 'depends on HAVE_IOMEM' everywhere.
Okay, seems it's not. Fine, I'll send a patch soon.
--
With Best Regards,
Andy Shevchenko
On Wed, Mar 24, 2021 at 10:29:31AM +, Lee Jones wrote:
> On Tue, 23 Mar 2021, Andy Shevchenko wrote:
>
> > Allow interrupts to be MSI if supported by hardware.
> >
> > Signed-off-by: Andy Shevchenko
> > ---
> > v2: new patch
> >
On Tue, Mar 23, 2021 at 1:19 AM Wesley Cheng wrote:
>
> Hi Andy,
>
> On 3/22/2021 2:14 PM, Andy Shevchenko wrote:
> > On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote:
> >>
> >> Hi Andy,
> >>
> >> On 3/22/2021 12:34 PM, Andy Shevchenko wro
the GPIO part) and have been re-sent
> several times. You have neither acked or opposed these changes. I
> don't want to delay the new testing driver anymore so I intend to
> apply the entire series and take it upstream through the GPIO tree by
> the end of this week.
Fine with me, feel free to add
Acked-by: Andy Shevchenko
where it's appropriate.
--
With Best Regards,
Andy Shevchenko
udc: reorder spin_[un]lock to avoid
deadlock")
Cc: Iago Abal
Signed-off-by: Andy Shevchenko
---
v2: no changes
drivers/usb/gadget/udc/pch_udc.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pc
Intel Minnowboard (v1) uses SCH GPIO line SUS7 (i.e. 12)
for VBUS sense. Provide a DMI based quirk to have it's being used.
Fixes: e20849a8c883 ("usb: gadget: pch_udc: Convert to use GPIO descriptors")
Signed-off-by: Andy Shevchenko
---
v2: no changes
drivers/usb/gadget/udc/pch_
843]
[ 55.245843] ? pch_udc_svc_data_out+0x160/0x160
Check if driver is present before calling ->setup().
Fixes: f646cf94520e ("USB device driver of Topcliff PCH")
Signed-off-by: Andy Shevchenko
---
v2: fixed typo in the Subject
drivers/usb/gadget/udc/pch_udc.c | 28 +++
issue which does not work with
g_serial")
Signed-off-by: Andy Shevchenko
---
v2: new patch
drivers/usb/gadget/udc/pch_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c
index 2e3510dd026c..455fd9cde
During conversion to use GPIO descriptors the device pointer,
which is applied to devm_gpiod_get(), is not yet initialized.
Move initialization in the ->probe() in order to have it set before use.
Fixes: e20849a8c883 ("usb: gadget: pch_udc: Convert to use GPIO descriptors")
Signed
] dataptr
.../pch_udc.c:1813:27:got restricted __le32 [usertype]
Fixes: f646cf94520e ("USB device driver of Topcliff PCH")
Signed-off-by: Andy Shevchenko
---
v2: fixed 64-bit build (Greg)
drivers/usb/gadget/udc/pch_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ether
gadget connect/disconnect issue")
Signed-off-by: Andy Shevchenko
---
v2: Fixed typo in the commit message (Sergei)
drivers/usb/gadget/udc/pch_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_u
Allow interrupts to be MSI if supported by hardware.
Signed-off-by: Andy Shevchenko
---
v2: new patch
drivers/mfd/intel_quark_i2c_gpio.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/intel_quark_i2c_gpio.c
b/drivers/mfd
It's convenient and less error prone to use definitions to address
different cells in an array. For this purpose we may reuse existing
BAR definitions.
Signed-off-by: Andy Shevchenko
---
v2: used explicit indices for MFD cells in the array (Lee)
drivers/mfd/intel_quark_i2c_gpio.c | 22
On Tue, Mar 23, 2021 at 12:58:44PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Mar 22, 2021 at 11:11:44PM +0200, Andy Shevchenko wrote:
> > Either way ~0 will be in the correct byte order,
> > hence drop unneeded cpu_to_le32() call. Moreover,
> > it makes sparse happy, o
On Wed, Mar 03, 2021 at 06:49:44PM +0200, Andy Shevchenko wrote:
> The IRQ support for SCH GPIO is not specific to the Intel Quark SoC.
> Moreover the IRQ routing is quite interesting there, so while it's
> needs a special support, the driver haven't it anyway yet.
>
> Due
the whole tree, so remove documentation
> that indicates that some functions behave differently.
Like this clean up!
Reviewed-by: Andy Shevchenko
Although a few nit-picks below.
> Cc: Andrew Morton
> Cc: Greg Kroah-Hartman
> Cc: Dan Williams
> Cc: Daniel Vetter
> Cc: Andy
RAM" in __ioremap_caller().
Here I dunno, but consider to add Fixes tag if it fixes known bad behaviour.
> Let's find all busy IORESOURCE_MEM resources, making the function
> behave similar to walk_system_ram_res().
>
> Cc: Andrew Morton
> Cc: Greg Kroah-Hartman
> Cc: Dan
in the crashdump on x86-64. Note
> > that e.g,, arm64 relies on memblock data and, therefore, always considers
> > all added System RAM already.
> >
> > Let's find all busy IORESOURCE_SYSTEM_RAM resources, making the function
> > behave like walk_system_ram_range().
> &g
n memblock data and, therefore, always considers
> all added System RAM already.
>
> Let's find all busy IORESOURCE_SYSTEM_RAM resources, making the function
> behave like walk_system_ram_range().
>
> Cc: Andrew Morton
> Cc: Greg Kroah-Hartman
> Cc: Dan Williams
> Cc:
urce.c | 45 -
> 1 file changed, 12 insertions(+), 33 deletions(-)
>
> --
> 2.29.2
>
--
With Best Regards,
Andy Shevchenko
On Tue, Mar 23, 2021 at 11:46 AM Sergei Shtylyov
wrote:
> On 23.03.2021 0:11, Andy Shevchenko wrote:
>
> > Kernel doc and the content described by it shouldn't be teared apart.
>
> s/teared/torn/?
Thanks!
I will change if the maintainer asks to resend or if it will
On Tue, Mar 23, 2021 at 09:14:53AM +, Lee Jones wrote:
> On Tue, 02 Mar 2021, Andy Shevchenko wrote:
>
> > The structures are used as place holders, so they are modified at run-time.
> > Obviously they may not be constants.
> >
> > BUG: unable to handle pa
On Tue, Mar 23, 2021 at 09:20:57AM +, Lee Jones wrote:
> On Tue, 02 Mar 2021, Andy Shevchenko wrote:
>
> > It's convenient and less error prone to use definitions to address
> > different cells in an array. For this purpose we may reuse existing
&
On Mon, Mar 22, 2021 at 10:06 PM Wesley Cheng wrote:
>
> Hi Andy,
>
> On 3/22/2021 12:34 PM, Andy Shevchenko wrote:
> > On Mon, Mar 22, 2021 at 8:49 PM Wesley Cheng wrote:
> >>
> >> Hi Andy,
> >>
> >> On 3/22/2021 5:48 AM, Andy Shevchenko wro
Intel Minnowboard (v1) uses SCH GPIO line SUS7 (i.e. 12)
for VBUS sense. Provide a DMI based quirk to have it's being used.
Fixes: e20849a8c883 ("usb: gadget: pch_udc: Convert to use GPIO descriptors")
Signed-off-by: Andy Shevchenko
---
drivers/usb/gadget/udc/pch_
401 - 500 of 17509 matches
Mail list logo
