Re: Re: Re: [PATCH] Input: evdev: fix queueing of SYN_DROPPED event for EVIOCG[type] IOCTL case

2017-04-10 Thread Aniroop Mathur
On Fri, Feb 24, 2017 at 5:06 PM, Aniroop Mathur wrote: >> Hi >> >> On Tue, Jan 31, 2017 at 5:09 PM, Aniroop Mathur wrote: >>> On Sun, Jan 22, 2017 at 6:45 PM, David Herrmann >>> wrote: >>>> On Thu, Nov 24, 2016 at 9:11 PM, Aniroop Mathur &g

RE: Re: Re: [PATCH] Input: evdev: fix queueing of SYN_DROPPED event for EVIOCG[type] IOCTL case

2017-02-24 Thread Aniroop Mathur
> Hi > > On Tue, Jan 31, 2017 at 5:09 PM, Aniroop Mathur wrote: >> On Sun, Jan 22, 2017 at 6:45 PM, David Herrmann >> wrote: >>> On Thu, Nov 24, 2016 at 9:11 PM, Aniroop Mathur >>> wrote: >>>>

RE: Re: [PATCH] Input: evdev: fix queueing of SYN_DROPPED event for EVIOCG[type] IOCTL case

2017-02-01 Thread Aniroop Mathur
On Sun, Jan 22, 2017 at 6:45 PM, David Herrmann wrote: > Hi > > On Thu, Nov 24, 2016 at 9:11 PM, Aniroop Mathur wrote: >> Currently, when EVIOCG[type] ioctl call is issued and bits_to_user fails, >> then SYN_DROPPED event is inserted in the event queue always. >> >&

Re: Re: [PATCH] [v9]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2017-01-31 Thread Aniroop Mathur
On Tue, Nov 22, 2016 at 12:17 AM, Aniroop Mathur wrote: > Hello Mr. Torokhov, > > >>> static void __evdev_queue_syn_dropped(struct evdev_client *client) >>> { >>> struct input_event ev; >>> +struct input_event *last_ev; >>>

RE: Re: [PATCH] Input: evdev: fix queueing of SYN_DROPPED event for EVIOCG[type] IOCTL case

2017-01-31 Thread Aniroop Mathur
On Sun, Jan 22, 2017 at 6:45 PM, David Herrmann wrote: > Hi > > On Thu, Nov 24, 2016 at 9:11 PM, Aniroop Mathur wrote: >> Currently, when EVIOCG[type] ioctl call is issued and bits_to_user fails, >> then SYN_DROPPED event is inserted in the event queue always. >

Re: Re: [PATCH] Input: joystick: adi - change msleep to usleep_range for small msecs

2017-01-19 Thread Aniroop Mathur
to you as well. Thank you. -- Aniroop Mathur On Sat, Dec 3, 2016 at 11:20 PM, Aniroop Mathur wrote: > On Tue, Nov 29, 2016 at 12:29 PM, vojt...@ucw.cz wrote: >> On Mon, Nov 28, 2016 at 01:49:31PM +, Aniroop Mathur wrote: >>> Hello Mr. Vojtech Pavlik, >>> >

Re: [PATCH] Input: evdev: fix queueing of SYN_DROPPED event for EVIOCG[type] IOCTL case

2017-01-18 Thread Aniroop Mathur
Dear Mr. Dmitry Torokhov, Could you please update about this patch? Thank you. -- Aniroop Mathur On Wed, Dec 14, 2016 at 11:54 PM, Aniroop Mathur wrote: > Hello Mr. Torokhov, > > Would you kindly update about this patch? > Thanks! > > Best Regards, > Aniroop Mathur >

Re: [PATCH] Input: evdev: fix queueing of SYN_DROPPED event for EVIOCG[type] IOCTL case

2016-12-14 Thread Aniroop Mathur
Hello Mr. Torokhov, Would you kindly update about this patch? Thanks! Best Regards, Aniroop Mathur On Fri, Nov 25, 2016 at 1:41 AM, Aniroop Mathur wrote: > Currently, when EVIOCG[type] ioctl call is issued and bits_to_user fails, > then SYN_DROPPED event is inserted in the event queue

Re: [PATCH] Input: mouse: synaptics - change msleep to usleep_range for small msecs

2016-12-04 Thread Aniroop Mathur
Hello Mr. Igor Grinberg On Sun, Dec 4, 2016 at 1:32 PM, Igor Grinberg wrote: > Hi Aniroop Mathur, > > On 11/29/16 23:02, Aniroop Mathur wrote: >> Dear Mike Rapoport, Igor Grinberg, >> Greetings! >> >> I am Aniroop Mathur from Samsung R&D Institute, India

Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep_range for small msecs

2016-12-03 Thread Aniroop Mathur
Hello Mr. Simon, On Sat, Dec 3, 2016 at 10:58 PM, Simon Budig wrote: > Hello Mr, Mathur. > > On 29/11/16 21:54, Aniroop Mathur wrote: >> I have submitted one patch as below for review to Linux Open Source. >> The problem is that we do not have the hardware available with us

Re: Re: [PATCH] Input: joystick: adi - change msleep to usleep_range for small msecs

2016-12-03 Thread Aniroop Mathur
On Tue, Nov 29, 2016 at 12:29 PM, vojt...@ucw.cz wrote: > On Mon, Nov 28, 2016 at 01:49:31PM +0000, Aniroop Mathur wrote: >> Hello Mr. Vojtech Pavlik, >> >> On 28 Nov 2016 17:23, "vojt...@ucw.cz" wrote: >> > >> > Hi. >> > >>

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

2016-12-03 Thread Aniroop Mathur
On Sat, Dec 3, 2016 at 2:30 PM, Jonathan Cameron wrote: > On 02/12/16 19:07, Aniroop Mathur wrote: >> On Wed, Nov 30, 2016 at 8:13 PM, Aniroop Mathur wrote: >>> On 30 Nov 2016 19:05, "Lars-Peter Clausen" wrote: >>> > >>> > On 11/27/2016 11

Re: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

2016-12-02 Thread Aniroop Mathur
On Wed, Nov 30, 2016 at 8:13 PM, Aniroop Mathur wrote: > On 30 Nov 2016 19:05, "Lars-Peter Clausen" wrote: > > > > On 11/27/2016 11:51 AM, Jonathan Cameron wrote: > > > On 26/11/16 03:47, Aniroop Mathur wrote: > > >> msleep(1~20) may not do

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

2016-12-02 Thread Aniroop Mathur
On Wed, Nov 30, 2016 at 5:49 PM, Linus Walleij wrote: > On Sun, Nov 27, 2016 at 11:51 AM, Jonathan Cameron wrote: >> On 26/11/16 03:47, Aniroop Mathur wrote: > > [bmp280.c] > >>> /* Wait to make sure we started up properly */ >>> - mdelay(data->

RE: RE: RE: [Please Apply][PATCH] Input: misc: bma150: Change msleep to usleep_range for small msecs

2016-12-01 Thread Aniroop Mathur
Dear Mr. Torokhov, As this patch is now verified, would you please apply it? Thank you! -- Best Regards, Aniroop Mathur Lead Engineer | System 1 - Sensor R&D Samsung Research Institute India - Noida Tel: 0120-671Ext: 4018 Mob: +91 9971865523 Email: a.mat...@samsung

RE: RE: [PATCH] Input: Change msleep to usleep_range for small msecs

2016-12-01 Thread Aniroop Mathur
would be beneficial from power saving point of view. -- Best Regards, Aniroop Mathur     - Original Message - Sender : ZHANG Xu (BST/ESA3.1)  Date : 2016-12-01 11:19 (GMT+5:30) Title : RE: [PATCH] Input: Change msleep to usleep_range for small msecs   Hello Aniroop Mathur

RE: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

2016-11-30 Thread Aniroop Mathur
On 30 Nov 2016 19:05, "Lars-Peter Clausen" wrote: > > On 11/27/2016 11:51 AM, Jonathan Cameron wrote: > > On 26/11/16 03:47, Aniroop Mathur wrote: > >> msleep(1~20) may not do what the caller intends, and will often sleep > >> longer. > >>

Re: [PATCH] Input: mouse: synaptics - change msleep to usleep_range for small msecs

2016-11-29 Thread Aniroop Mathur
Dear Mike Rapoport, Igor Grinberg, Greetings! I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to test it before actu

Re: [PATCH] Input: touchscreen: zylonite_wm97xx - change msleep to usleep_range for small msecs

2016-11-29 Thread Aniroop Mathur
Dear Mark Brown / Ian Molton / Andrew Zabolotny, Greetings! I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to tes

Re: [PATCH] Input: touchscreen: w90p910 - change msleep to usleep_range for small msecs

2016-11-29 Thread Aniroop Mathur
Dear Wan ZongShun, Greetings! I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to test it before actually applying it. As

Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep_range for small msecs

2016-11-29 Thread Aniroop Mathur
Dear Simon Budig / Daniel Wagener / Lothar Waßmann, Greetings! I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to tes

Re: [PATCH] Input: mouse: pxa930_trkball - change msleep to usleep_range for small msecs

2016-11-29 Thread Aniroop Mathur
Dear Yong Yao, Greetings! I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to test it before actually applying it. As you

Re: [PATCH] Input: mouse: navpoint - Change msleep to usleep_range for small msecs

2016-11-29 Thread Aniroop Mathur
Dear Mr. Paul Parsons, I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to test it before actually applying it. If you

[PATCH] Input: mouse: synaptics - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/mouse/synaptics_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c index aa7c5da..4d688a6 100644 --- a/drivers

[PATCH] Input: joystick: gf2k - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
sleep for a minimum period of 10 ms whereas usleep_range(4000, 4100) will make sure that the process does not sleep for more than 4100 us or 4.1ms Signed-off-by: Aniroop Mathur --- drivers/input/joystick/gf2k.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH] Input: joystick: analog - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
sleep for a minimum period of 10 ms whereas usleep_range(3000, 3100) will make sure that the process does not sleep for more than 3100 us or 3.1ms Signed-off-by: Aniroop Mathur --- drivers/input/joystick/analog.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH] Input: joystick: sidewinder - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
sleep for a minimum period of 10 ms whereas usleep_range(6000, 6100) will make sure that the process does not sleep for more than 6100 us or 6.1ms Signed-off-by: Aniroop Mathur --- drivers/input/joystick/sidewinder.c | 24 1 file changed, 12 insertions(+), 12 deletions

[PATCH] Input: touchscreen: zylonite_wm97xx - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/touchscreen/zylonite-wm97xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/zylonite-wm97xx.c b/drivers/input/touchscreen/zylonite-wm97xx.c index e2ccd68..cebd3a8

[PATCH] Input: touchscreen: w90p910 - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/touchscreen/w90p910_ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/w90p910_ts.c b/drivers/input/touchscreen/w90p910_ts.c index da6004e..3f14b5a 100644 --- a

[PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/touchscreen/edt-ft5x06.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 703e295..379dd31 100644 --- a

[PATCH] Input: touchscreen: ads7846 - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/touchscreen/ads7846.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index 1ce3ecb..b1a5a6c 100644 --- a/drivers

[PATCH] Input: mouse: synaptics - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/mouse/synaptics_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c index aa7c5da..4d688a6 100644 --- a/drivers

[PATCH] Input: mouse: pxa930_trkball - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/mouse/pxa930_trkball.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/pxa930_trkball.c b/drivers/input/mouse/pxa930_trkball.c index 9b4d9a5..d8ac9f9 100644 --- a/drivers/input

[PATCH] Input: mouse: navpoint - Change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/mouse/navpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/navpoint.c b/drivers/input/mouse/navpoint.c index d6e8f58..2ede00b 100644 --- a/drivers/input/mouse/navpoint.c

[PATCH] Input: keyboard: lm8323 - Change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/keyboard/lm8323.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c index 21bea52..14679e9 100644 --- a/drivers/input/keyboard/lm8323

Re: [PATCH] Input: Change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
Hello Mr. Albert Zhang, I am Aniroop Mathur from Samsung R&D Institute, India. I have submitted one patch as below for review to Linux Open Source. The problem is that we do not have the hardware available with us to test it and we would like to test it before actually applying it. As you

RE: Re: [PATCH] Input: joystick: adi - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
s and request to person who could support to test this patch I have also applied the same patch in our driver whose hardware is available with me and I found that wake up time became precise indeed and so I decided to apply the same fix in other input subsystem drivers as well. Thank you!

[PATCH] Input: joystick: adi - change msleep to usleep_range for small msecs

2016-11-28 Thread Aniroop Mathur
to usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- joystick/adi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/joystick/adi.c b/joystick/adi.c index d09cefa..6799bd9 100644 --- a/joystick/adi.c +++ b/joystick/adi.c @@ -47,8 +47,8

[PATCH] IIO: Change msleep to usleep_range for small msecs

2016-11-25 Thread Aniroop Mathur
to usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/iio/adc/exynos_adc.c | 2 +- drivers/iio/pressure/bmp280-core.c | 14 +++--- drivers/staging/iio/meter/ade7753.c | 2 +- drivers/staging/iio/meter/ade7753.h | 2 +- drivers

[PATCH] Input: evdev: fix queueing of SYN_DROPPED event for EVIOCG[type] IOCTL case

2016-11-24 Thread Aniroop Mathur
] ioctl is issued for say A type of events but event queue does not have any A type of events but some other type of events. Therefore, insert SYN_DROPPED event only when some events have been flushed out from event queue plus bits_to_user fails. Signed-off-by: Aniroop Mathur --- drivers/input

[PATCH] Input: Change msleep to usleep_range for small msecs

2016-11-24 Thread Aniroop Mathur
to usleep_range for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/gameport/ns558.c | 4 ++-- drivers/input/joystick/adi.c| 4 ++-- drivers/input/joystick/analog.c | 12 ++-- drivers/input/joystick/gf2k.c | 8

[PATCH] Input: Change msleep to usleep_range for small msecs

2016-11-24 Thread Aniroop Mathur
for precise wakeups. Signed-off-by: Aniroop Mathur --- drivers/input/misc/bma150.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c index 2124390..1fa8537 100644 --- a/drivers/input/misc/bma150.c +++ b/drivers/input

RE: Re: [PATCH] [v9]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-11-21 Thread Aniroop Mathur
t right after SYN_DROPPED event using that last consumed event. And I think that it is for sure that this last event is actually SYN_REPORT event since input core always send events in packets so SYN_REPORT is always the last event forwarded by input core to evdev. Does the above mentioned point

Re: [PATCH] [v9]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-11-04 Thread Aniroop Mathur
Hello Mr. Torokhov, As you can see that this patch is pending for a long time, I request you to please review it at the earliest possible. Thanks, Aniroop Mathur On Thu, Oct 13, 2016 at 12:05 AM, Aniroop Mathur wrote: > Hello Mr. Torokhov, > > Hope you are doing great! > > C

Re: [PATCH] [v9]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-10-12 Thread Aniroop Mathur
ve a good day! Best Regards, Aniroop Mathur > On Wed, Oct 5, 2016 at 12:42 AM, Aniroop Mathur wrote: >> If last event dropped in the old queue was EV_SYN/SYN_REPORT, then lets >> generate EV_SYN/SYN_REPORT immediately after queing EV_SYN/SYN_DROPPED >> so that clients wo

[PATCH] [v9]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-10-04 Thread Aniroop Mathur
If last event dropped in the old queue was EV_SYN/SYN_REPORT, then lets generate EV_SYN/SYN_REPORT immediately after queing EV_SYN/SYN_DROPPED so that clients would not ignore next valid full packet events. Signed-off-by: Aniroop Mathur Difference from v8: Added check for handling EVIOCG[type

Re: [PATCH] [v8]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-10-04 Thread Aniroop Mathur
ood to go. Do you have any more comments? Best Regards, Aniroop Mathur On Sun, Jan 24, 2016 at 1:35 AM, Aniroop Mathur wrote: > On Sun, Jan 24, 2016 at 12:09 AM, Dmitry Torokhov > wrote: >> On Sat, Jan 23, 2016 at 11:29:29PM +0530, Aniroop Mathur wrote: >>> Hi Mr. Torokhov

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-04-27 Thread Aniroop Mathur
On Thu, Apr 7, 2016 at 2:13 AM, Aniroop Mathur wrote: > Hello Mr. Henrik, > > On Thu, Apr 7, 2016 at 1:21 AM, Henrik Rydberg wrote: >> Hi Aniroop, >> >>>> I am not sure what the urgency is. It is more of a theoretical problem >>>> ans so far the prop

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-04-06 Thread Aniroop Mathur
Hello Mr. Henrik, On Thu, Apr 7, 2016 at 1:21 AM, Henrik Rydberg wrote: > Hi Aniroop, > >>> I am not sure what the urgency is. It is more of a theoretical problem >>> ans so far the proposed solutions were actually introducing more >>> problems than they were solving. >>> >>> I am sorry, bit this

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-04-06 Thread Aniroop Mathur
On Wed, Apr 6, 2016 at 11:08 PM, Dmitry Torokhov wrote: > On Wed, Apr 06, 2016 at 08:26:39PM +0530, Aniroop Mathur wrote: >> On Sat, Apr 2, 2016 at 10:31 PM, Aniroop Mathur >> wrote: >> > Hello Mr. Torokhov, >> > >> > First of all, Thank you for your re

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-04-06 Thread Aniroop Mathur
On Sat, Apr 2, 2016 at 10:31 PM, Aniroop Mathur wrote: > Hello Mr. Torokhov, > > First of all, Thank you for your reply. > > On Sat, Apr 2, 2016 at 3:21 AM, Dmitry Torokhov > wrote: >> On Fri, Mar 11, 2016 at 12:26:57AM +0530, Aniroop Mathur wrote: >>> Hi Henrik

[PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-04-04 Thread Aniroop Mathur
another SYN_REPORT. Signed-off-by: Aniroop Mathur --- drivers/input/input.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index 8806059..799941c 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -401,12

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-04-02 Thread Aniroop Mathur
Hello Mr. Torokhov, First of all, Thank you for your reply. On Sat, Apr 2, 2016 at 3:21 AM, Dmitry Torokhov wrote: > On Fri, Mar 11, 2016 at 12:26:57AM +0530, Aniroop Mathur wrote: >> Hi Henrik, >> >> On Thu, Mar 10, 2016 at 7:15 PM, Henrik Rydberg wrote: >> > Hi

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-03-30 Thread Aniroop Mathur
Hello Mr. Henrik, So do you have any further comments on this patch please? It is pending for more than 20 days. It would be really appreciating if you could help out to conclude it as soon as possible. Regards, Aniroop Mathur On Thu, Mar 24, 2016 at 1:05 AM, Aniroop Mathur wrote: > Hello

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-03-23 Thread Aniroop Mathur
Hello Mr. Torokhov / Mr. Henry, On Wed, Mar 16, 2016 at 11:54 PM, Aniroop Mathur wrote: > Hello Mr. Torokhov, > > Could you kindly help to update about this patch? > So is this patch concluded? Are you applying it? Thanks, Aniroop Mathur > Thank you, > Aniroop Mathur &g

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-03-19 Thread Aniroop Mathur
Hello Mr. Torokhov, Could you kindly help to update about this patch? Thank you, Aniroop Mathur On Fri, Mar 11, 2016 at 12:26 AM, Aniroop Mathur wrote: > Hi Henrik, > > On Thu, Mar 10, 2016 at 7:15 PM, Henrik Rydberg wrote: >> Hi Dmitry, >> >>>> diff --git

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-03-10 Thread Aniroop Mathur
nd the real packet size is z i.e. driver wants to send same event codes again in the same packet, so input event reader would be expecting SYN_REPORT after z events but due to current code SYN_REPORT will get inserted automatically after y events, which is a wrong behaviour. Thanks, Aniroop Mathur > Henrik >

Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-03-09 Thread Aniroop Mathur
Hello Mr. Torokhov, Could you kindly help to update about below patch? Thanks, Aniroop Mathur On Mon, Mar 7, 2016 at 11:14 PM, Aniroop Mathur wrote: > As mentioned in documentation, SYN_REPORT should be used to separate two > packets > and should not be inserted in between a sing

[PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-03-07 Thread Aniroop Mathur
another SYN_REPORT. Signed-off-by: Aniroop Mathur --- drivers/input/input.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index 8806059..262ef77 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -401,8 +401,7

Re: [PATCH] [v8]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-02-11 Thread Aniroop Mathur
Hello Mr. Torokhov, On 1/25/16, Aniroop Mathur wrote: > On Sun, Jan 24, 2016 at 1:35 AM, Aniroop Mathur > wrote: >> On Sun, Jan 24, 2016 at 12:09 AM, Dmitry Torokhov >> wrote: >>> On Sat, Jan 23, 2016 at 11:29:29PM +0530, Aniroop Mathur wrote: >>>> Hi

Re: [PATCH] [v8]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-01-25 Thread Aniroop Mathur
On Sun, Jan 24, 2016 at 1:35 AM, Aniroop Mathur wrote: > On Sun, Jan 24, 2016 at 12:09 AM, Dmitry Torokhov > wrote: >> On Sat, Jan 23, 2016 at 11:29:29PM +0530, Aniroop Mathur wrote: >>> Hi Mr. Torokhov, >>> >>> On Fri, Jan 22, 2016 at 12:47 AM, Dmitr

[PATCH] Input: evdev: correct handling of memory allocation failure of evdev_client

2016-01-25 Thread Aniroop Mathur
Lets fix twice checking of memory allocation failure of evdev_client structure when allocated successfully. Signed-off-by: Aniroop Mathur --- drivers/input/evdev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index

Re: [PATCH] [v8]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-01-23 Thread Aniroop Mathur
On Sun, Jan 24, 2016 at 12:09 AM, Dmitry Torokhov wrote: > On Sat, Jan 23, 2016 at 11:29:29PM +0530, Aniroop Mathur wrote: >> Hi Mr. Torokhov, >> >> On Fri, Jan 22, 2016 at 12:47 AM, Dmitry Torokhov >> wrote: >> > Hi Anoroop, >> > >> > On

Re: [PATCH] [v8]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-01-23 Thread Aniroop Mathur
Hi Mr. Torokhov, On Fri, Jan 22, 2016 at 12:47 AM, Dmitry Torokhov wrote: > Hi Anoroop, > > On Thu, Jan 21, 2016 at 11:07:19PM +0530, Aniroop Mathur wrote: >> If last event dropped in the old queue was EVi_SYN/SYN_REPORT, then lets >> generate EV_SYN/SYN_REPORT immediatel

[PATCH] [v8]Input: evdev: fix bug of dropping valid packet after syn_dropped event

2016-01-21 Thread Aniroop Mathur
If last event dropped in the old queue was EVi_SYN/SYN_REPORT, then lets generate EV_SYN/SYN_REPORT immediately after queing EV_SYN/SYN_DROPPED so that clients would not ignore next valid full packet events. Signed-off-by: Aniroop Mathur --- drivers/input/evdev.c | 46

Re: [PATCH] [v4]Input: evdev - drop partial events after emptying the buffer

2016-01-06 Thread Aniroop Mathur
Hello Mr. Torokhov, Could you please help to update about below patch ? Thanks, Aniroop Mathur On Tue, Jan 5, 2016 at 3:26 AM, Aniroop Mathur wrote: > This patch introduces concept to drop partial events in evdev handler > itself after emptying the buffer which are dropped by all

Re: [PATCH] [v3]Input: evdev - drop partial events after emptying the buffer

2016-01-04 Thread Aniroop Mathur
gt; help improving the system] > > url: > https://github.com/0day-ci/linux/commits/Aniroop-Mathur/Input-evdev-drop-partial-events-after-emptying-the-buffer/20160105-053003 > base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next > config: avr32-atstk10

[PATCH] [v4]Input: evdev - drop partial events after emptying the buffer

2016-01-04 Thread Aniroop Mathur
handler buffer. Also, this patch prevents dropping of full packet by evdev client after SYN_DROPPED occurs in case last stored event was SYN_REPORT. (like after clock change request) -- Please ignore v3. Signed-off-by: Aniroop Mathur --- drivers/input/evdev.c | 53

[PATCH] [v3]Input: evdev - drop partial events after emptying the buffer

2016-01-04 Thread Aniroop Mathur
handler buffer. Also, this patch prevents dropping of full packet by evdev client after SYN_DROPPED occurs in case last stored event was SYN_REPORT. (like after clock change request) Signed-off-by: Aniroop Mathur --- drivers/input/evdev.c | 53 ++- 1

Re: [PATCH] Input: evdev - drop partial events after emptying the buffer

2016-01-04 Thread Aniroop Mathur
On Mon, Jan 4, 2016 at 2:22 PM, Benjamin Tissoires wrote: > On Mon, Jan 4, 2016 at 8:50 AM, Aniroop Mathur wrote: >> On Jan 4, 2016 5:08 AM, "Peter Hutterer" wrote: >>> >>> On Sat, Jan 02, 2016 at 08:39:21PM -0800, Dmitry Torokhov wrote: >>> >

[PATCH] [v2]Input: evdev - drop partial events after emptying the buffer

2016-01-04 Thread Aniroop Mathur
-off-by: Aniroop Mathur --- drivers/input/evdev.c | 56 ++- 1 file changed, 47 insertions(+), 9 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index e9ae3d5..0a5ead8 100644 --- a/drivers/input/evdev.c +++ b/drivers/input

Re: Re: [PATCH] Input: evdev - drop partial events after emptying the buffer

2016-01-03 Thread Aniroop Mathur
On Jan 4, 2016 5:08 AM, "Peter Hutterer" wrote: > > On Sat, Jan 02, 2016 at 08:39:21PM -0800, Dmitry Torokhov wrote: > > On Thu, Dec 31, 2015 at 03:36:47AM +0530, Aniroop Mathur wrote: > > > This patch introduces concept to drop partial events in evdev handler

[PATCH] Input: evdev - Avoid duplicate checking of empty SYN_REPORT

2015-12-30 Thread Aniroop Mathur
Input core already drops empty syn_report event so there is no need to check again for dropping empty syn_report event in evdev handler for all clients on every new event. Signed-off-by: Aniroop Mathur --- drivers/input/evdev.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

[PATCH] Input: evdev - drop partial events after emptying the buffer

2015-12-30 Thread Aniroop Mathur
-off-by: Aniroop Mathur --- drivers/input/evdev.c | 49 + 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index e9ae3d5..e7b612e 100644 --- a/drivers/input/evdev.c +++ b/drivers/input

Re: [PATCH] Input: evdev: avoid storing newest SYN_REPORT when dropping all events

2015-12-29 Thread Aniroop Mathur
Hello Mr. Torokhov, On Tue, Dec 29, 2015 at 5:11 AM, Dmitry Torokhov wrote: > Hi Aniroop, > > On Thu, Dec 24, 2015 at 11:25 AM, Aniroop Mathur wrote: >> The newest event can be SYN_REPORT in case of dropping all old events when >> buffer is full, but as now there is no dev

[PATCH] Input: evdev: avoid storing newest SYN_REPORT when dropping all events

2015-12-24 Thread Aniroop Mathur
The newest event can be SYN_REPORT in case of dropping all old events when buffer is full, but as now there is no device data available to read so lets drop SYN_REPORT as well and store only SYN_DROPPED. Signed-off-by: Aniroop Mathur --- drivers/input/evdev.c | 17 +++-- 1 file

Re: Ques: [kernel/time/*] Is there any disadvantage in using sleep_range for more than 20ms delay ?

2015-12-21 Thread Aniroop Mathur
On Tue, Dec 15, 2015 at 1:23 AM, Thomas Gleixner wrote: > On Tue, 15 Dec 2015, Aniroop Mathur wrote: >> On Sun, Dec 13, 2015 at 3:17 PM, Clemens Ladisch wrote: >> > Aniroop Mathur wrote: >> >>> 2. If we use msleep(40), is it possible that process could wake up a

Re: Ques: [kernel/time/*] Is there any disadvantage in using sleep_range for more than 20ms delay ?

2015-12-14 Thread Aniroop Mathur
On Sun, Dec 13, 2015 at 3:17 PM, Clemens Ladisch wrote: > Aniroop Mathur wrote: >>> 1. If we choose usleep_range to acheive accuracy, are cpu and power usage >>> of any concern in real sense ? > > That depends. The effects are worse if the CPU is sleeping, and slow t

Re: Ques: [kernel/time/*] Is there any disadvantage in using sleep_range for more than 20ms delay ?

2015-12-09 Thread Aniroop Mathur
Sorry for multiple emails as those were not in plain text so ignored by linux-kernel@vger.kernel.org Please consider this email for reply. On Wed, Dec 9, 2015 at 2:17 AM, Thomas Gleixner wrote: > On Tue, 8 Dec 2015, Aniroop Mathur wrote: >> On Tue, Dec 8, 2015 at 4:18 PM, Thomas Gleixn

Re: Ques: [kernel/time/*] Is there any disadvantage in using sleep_range for more than 20ms delay ?

2015-12-09 Thread Aniroop Mathur
On Dec 9, 2015 2:18 AM, "Thomas Gleixner" wrote: > > On Tue, 8 Dec 2015, Aniroop Mathur wrote: > > On Tue, Dec 8, 2015 at 4:18 PM, Thomas Gleixner wrote: > > > The initialization process is hardly something critical, so why would > > > the delay need t

Re: Ques: [kernel/time/*] Is there any disadvantage in using usleep_range for more than 20ms delay ?

2015-12-08 Thread Aniroop Mathur
On Tue, Dec 8, 2015 at 2:33 PM, Clemens Ladisch wrote: > Aniroop Mathur wrote: >> As in the kernel documentation, it is mentioned to use msleep for >> 10ms+ delay, I am confused whether there would be any disadvantage in >> using usleep_range for higher delays values bec

Re: Ques: [kernel/time/*] Is there any disadvantage in using sleep_range for more than 20ms delay ?

2015-12-08 Thread Aniroop Mathur
On Tue, Dec 8, 2015 at 4:18 PM, Thomas Gleixner wrote: > On Tue, 8 Dec 2015, Aniroop Mathur wrote: >> On Tue, Dec 8, 2015 at 12:07 AM, Thomas Gleixner wrote: >> > The real question is how precise must your delay be? If the delay >> > needs to be precise within the min/

Re: Ques: [kernel/time/*] Is there any disadvantage in using sleep_range for more than 20ms delay ?

2015-12-07 Thread Aniroop Mathur
On Tue, Dec 8, 2015 at 12:07 AM, Thomas Gleixner wrote: > On Mon, 7 Dec 2015, Aniroop Mathur wrote: >> As in the kernel documentation, it is mentioned to use msleep for >> 10ms+ delay, I am confused whether there would be any disadvantage in >> using usleep_range for higher

Ques: [kernel/time/*] Is there any disadvantage in using usleep_range for more than 20ms delay ?

2015-12-07 Thread Aniroop Mathur
Dear Mr. John and Mr. Thomas, Greetings of the day !! This is Aniroop Mathur working on sensor kernel drivers for last 3 years. Recently, In my driver code, I have been changing msleep to usleep_range. But I got stuck at one point and could not find proper answer on internet. Could you please

Ques: [kernel/time/*] Is there any disadvantage in using sleep_range for more than 20ms delay ?

2015-12-07 Thread Aniroop Mathur
Dear Mr. John and Mr. Thomas, Greetings of the day !! This is Aniroop Mathur working on sensor kernel drivers for last 3 years. Recently, In my driver code, I have been changing msleep to usleep_range. But I got stuck at one point and could not find proper answer on internet. Could you please

Re: [PATCH] Evdev: Fix bug in checking duplicate clock change request

2015-10-30 Thread Aniroop Mathur
On Fri, Oct 30, 2015 at 6:34 PM, Aniroop Mathur wrote: > > Hello Mr. Torokhov, > > On Fri, Oct 30, 2015 at 4:45 PM, Dmitry Torokhov > wrote: > > Hi Aniroop, > > > > On Thu, Oct 29, 2015 at 01:38:32AM +0530, Aniroop Mathur wrote: > >> From: Aniroop M

Re: [PATCH] Evdev: Fix bug in checking duplicate clock change request

2015-10-30 Thread Aniroop Mathur
Hello Mr. Torokhov, On Fri, Oct 30, 2015 at 4:45 PM, Dmitry Torokhov wrote: > Hi Aniroop, > > On Thu, Oct 29, 2015 at 01:38:32AM +0530, Aniroop Mathur wrote: >> From: Aniroop Mathur >> >> clk_type and clkid stores different predefined clock identification >>

[PATCH] Evdev: Fix bug in checking duplicate clock change request

2015-10-28 Thread Aniroop Mathur
From: Aniroop Mathur clk_type and clkid stores different predefined clock identification values so they cannot be compared for checking duplicate clock change request. Therefore, lets fix it to avoid unexpected results. Signed-off-by: Aniroop Mathur Signed-off-by: Aniroop Mathur --- drivers

[PATCH] Evdev: Fix bug of comparing clk_type with clkid

2015-10-28 Thread Aniroop Mathur
From: Aniroop Mathur clk_type and clkid stores different predefined clock identification values so they cannot be compared. Therefore, lets fix it to avoid unexpected results. Signed-off-by: Aniroop Mathur Signed-off-by: Aniroop Mathur --- drivers/input/evdev.c | 10 ++ 1 file

Re: [PATCH] hid: Initialize battery_no to -1 & correct its format string

2015-01-09 Thread Aniroop Mathur
fix format specifier of "n" variable. "n" is declared as unsigned long so %ld should be changed to %lu. Thanks !! >> >> Thanks, >> >> Ping >> >> On Tue, Jan 6, 2015 at 6:32 AM, Aniroop Mathur >> wrote: >>> Dear Mr. Jason an

Re: [PATCH] hid: Initialize battery_no to -1 & correct its format string

2015-01-06 Thread Aniroop Mathur
oop Mathur wrote: > >> From: Aniroop Mathur >> >> This patch initializes battery_no to -1 to avoid extra subtraction >> operation performed everytime wacom battery is initialized > > This is so femto-optimization, that I don't really care deeply. Adding > J

Re: [PATCH] regulator: core: Fix format specifier warning

2014-12-29 Thread Aniroop Mathur
On Mon, Dec 29, 2014 at 10:40 PM, Mark Brown wrote: > On Mon, Dec 29, 2014 at 10:36:48PM +0530, Aniroop Mathur wrote: >> Signed-off-by: Aniroop Mathur > > Applied, thanks. Please check what you're generating your patches > against - they aren't applying cleanly,

[PATCH] regulator: core: Fix format specifier warning

2014-12-29 Thread Aniroop Mathur
Signed-off-by: Aniroop Mathur --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index b0729ef..f380f04 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -3551,7 +3551,7

[PATCH] regulator: core: Avoid negative regulator no & initialize it to -1

2014-12-28 Thread Aniroop Mathur
This patch initializes regulator_no to -1 to avoid extra subtraction operation performed every time we register a regulator and avoid negative regulator no in its name. Signed-off-by: Aniroop Mathur --- drivers/regulator/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH] s390: Initialize nr_devices count variable to -1

2014-12-28 Thread Aniroop Mathur
From: Aniroop Mathur This patch initializes nr_device count variable to -1 to avoid extra subtraction operation performed everytime scm block device is set up. Signed-off-by: Aniroop Mathur --- drivers/s390/block/scm_blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] hid: Initialize battery_no to -1 & correct its format string

2014-12-28 Thread Aniroop Mathur
From: Aniroop Mathur This patch initializes battery_no to -1 to avoid extra subtraction operation performed everytime wacom battery is initialized and correct format string of unsigned long from %ld to %lu. Signed-off-by: Aniroop Mathur --- drivers/hid/wacom_sys.c | 8 1 file changed

[PATCH] regulator: core: Initialize regulator_no to -1

2014-12-28 Thread Aniroop Mathur
From: Aniroop Mathur This patch initializes regulator_no to -1 to avoid extra subtraction operation performed every time we register a regulator. Signed-off-by: Aniroop Mathur --- drivers/regulator/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH 1/1] IIO: Added write function in iio_buffer_fileops

2014-08-23 Thread Aniroop Mathur
On Fri, Aug 22, 2014 at 11:58 PM, Jonathan Cameron wrote: > On 16/08/14 15:44, Aniroop Mathur wrote: >> >> >> >> On Thu, Aug 14, 2014 at 8:08 PM, Jonathan Cameron > <mailto:ji...@kernel.org>> wrote: >> >> On 14/08/14 10:41, Lars-Peter Clau

Re: [PATCH 1/1] IIO: Added write function in iio_buffer_fileops

2014-08-18 Thread Aniroop Mathur
Dear Mr. Jonathan, Mr. Lars, Greetings ! Kindly provide feedback upon the comments below. On Thu, Aug 14, 2014 at 8:08 PM, Jonathan Cameron wrote: > On 14/08/14 10:41, Lars-Peter Clausen wrote: >> On 08/13/2014 06:33 PM, Aniroop Mathur wrote: >>> On Wed, Aug 13, 2014 at 8

Re: [PATCH 1/1] IIO: Added write function in iio_buffer_fileops

2014-08-14 Thread Aniroop Mathur
On Thu, Aug 14, 2014 at 8:08 PM, Jonathan Cameron wrote: > On 14/08/14 10:41, Lars-Peter Clausen wrote: >> On 08/13/2014 06:33 PM, Aniroop Mathur wrote: >>> On Wed, Aug 13, 2014 at 8:18 PM, Lars-Peter Clausen wrote: >>>> On 08/13/2014 03:42 PM, Aniroop Mathur wro

  1   2   >