Re: [PATCH 2/2] Save current timestamp part of dmesg while writing oops message to pstore

2017-08-06 Thread Ankit Kumar
Hi Kees, On Tuesday 23 May 2017 02:19 PM, Ankit Kumar wrote: Hi Kees, On Tuesday 23 May 2017 05:21 AM, Kees Cook wrote: On Mon, May 22, 2017 at 3:20 AM, Ankit Kumar <an...@linux.vnet.ibm.com> wrote: Currently on panic or Oops, kernel saves the last few bytes from dmesg buffer to

Re: [PATCH 2/2] Save current timestamp part of dmesg while writing oops message to pstore

2017-08-06 Thread Ankit Kumar
Hi Kees, On Tuesday 23 May 2017 02:19 PM, Ankit Kumar wrote: Hi Kees, On Tuesday 23 May 2017 05:21 AM, Kees Cook wrote: On Mon, May 22, 2017 at 3:20 AM, Ankit Kumar wrote: Currently on panic or Oops, kernel saves the last few bytes from dmesg buffer to nvram. Usually kdump does capture

Re: [PATCH 2/2] Save current timestamp part of dmesg while writing oops message to pstore

2017-05-23 Thread Ankit Kumar
Hi Kees, On Tuesday 23 May 2017 05:21 AM, Kees Cook wrote: On Mon, May 22, 2017 at 3:20 AM, Ankit Kumar <an...@linux.vnet.ibm.com> wrote: Currently on panic or Oops, kernel saves the last few bytes from dmesg buffer to nvram. Usually kdump does capture kernel memory and provide dmes

Re: [PATCH 2/2] Save current timestamp part of dmesg while writing oops message to pstore

2017-05-23 Thread Ankit Kumar
Hi Kees, On Tuesday 23 May 2017 05:21 AM, Kees Cook wrote: On Mon, May 22, 2017 at 3:20 AM, Ankit Kumar wrote: Currently on panic or Oops, kernel saves the last few bytes from dmesg buffer to nvram. Usually kdump does capture kernel memory and provide dmesg logs as well. But in some cases

Re: [PATCH 1/2]pstore: Move timestamp collection code to common pstore place

2017-05-23 Thread Ankit Kumar
Hi Kees, Thank you so much for your response. On Tuesday 23 May 2017 05:07 AM, Kees Cook wrote: On Mon, May 22, 2017 at 3:20 AM, Ankit Kumar <an...@linux.vnet.ibm.com> wrote: Current pstore code(ram.c) gets dump timestamp and make it part of header. Different diffent architectur

Re: [PATCH 1/2]pstore: Move timestamp collection code to common pstore place

2017-05-23 Thread Ankit Kumar
Hi Kees, Thank you so much for your response. On Tuesday 23 May 2017 05:07 AM, Kees Cook wrote: On Mon, May 22, 2017 at 3:20 AM, Ankit Kumar wrote: Current pstore code(ram.c) gets dump timestamp and make it part of header. Different diffent architecture uses different header format

[PATCH]pstore: Don't warn if data is uncompressed and type is not PSTORE_TYPE_DMESG

2017-05-22 Thread Ankit Kumar
above type and it is valid condition. This patch returns if data is not compressed and print warning only if data is compressed and type is not PSTORE_TYPE_DMESG. Reported-by: Anton Blanchard <an...@au1.ibm.com> Signed-off-by: Ankit Kumar <an...@linux.vnet.ibm.com> Reviewed-by:

[PATCH]pstore: Don't warn if data is uncompressed and type is not PSTORE_TYPE_DMESG

2017-05-22 Thread Ankit Kumar
above type and it is valid condition. This patch returns if data is not compressed and print warning only if data is compressed and type is not PSTORE_TYPE_DMESG. Reported-by: Anton Blanchard Signed-off-by: Ankit Kumar Reviewed-by: Mahesh Salgaonkar --- fs/pstore/platform.c | 5 - 1 file

[PATCH 2/2] Save current timestamp part of dmesg while writing oops message to pstore

2017-05-22 Thread Ankit Kumar
:(/sys/fs/pstore/dmesg-***) Oops#1 Part1 [timestamp:1494939359.590463] Above timestamp can be converted to current zone using date command. #date -d @1494939359.590463 # Tue May 16 18:25:59 IST 2017 Signed-off-by: Ankit Kumar <an...@linux.vnet.ibm.com> --- fs/pstore/platform.c | 7 +--

[PATCH 2/2] Save current timestamp part of dmesg while writing oops message to pstore

2017-05-22 Thread Ankit Kumar
:(/sys/fs/pstore/dmesg-***) Oops#1 Part1 [timestamp:1494939359.590463] Above timestamp can be converted to current zone using date command. #date -d @1494939359.590463 # Tue May 16 18:25:59 IST 2017 Signed-off-by: Ankit Kumar --- fs/pstore/platform.c | 7 +-- 1 file changed, 5 insertions

[PATCH 1/2]pstore: Move timestamp collection code to common pstore place

2017-05-22 Thread Ankit Kumar
to get timestamp and also takes care of condition if timekeeping has not resumed. This patch moves code for retrieving timestamp to common place and hence can be used by other functions as well. Signed-off-by: Ankit Kumar <an...@linux.vnet.ibm.com> --- fs/pstore/internal.h | 1 + fs/

[PATCH 1/2]pstore: Move timestamp collection code to common pstore place

2017-05-22 Thread Ankit Kumar
to get timestamp and also takes care of condition if timekeeping has not resumed. This patch moves code for retrieving timestamp to common place and hence can be used by other functions as well. Signed-off-by: Ankit Kumar --- fs/pstore/internal.h | 1 + fs/pstore/platform.c | 13 + fs

[PATCH] Enabled pstore write for powerpc

2017-04-27 Thread Ankit Kumar
write for powerpc architecture by setting PSTORE_FLAGS_DMESG flag. Fixes:c950fd6f201a pstore: Split pstore fragile flags Signed-off-by: Ankit Kumar <an...@linux.vnet.ibm.com> --- arch/powerpc/kernel/nvram_64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/nvram_

[PATCH] Enabled pstore write for powerpc

2017-04-27 Thread Ankit Kumar
write for powerpc architecture by setting PSTORE_FLAGS_DMESG flag. Fixes:c950fd6f201a pstore: Split pstore fragile flags Signed-off-by: Ankit Kumar --- arch/powerpc/kernel/nvram_64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel

[PATCH] Save current timestamp while moving oops message to nvram

2017-04-12 Thread Ankit Kumar
date -d command to print time according to local time zone. Partial pstore dump after applying this patch: Oops#1 Part1 [2017-04-12T14:14:56Z] Above time can be printed in current time zone using date -d command. #date -d 2017-04-12T14:14:56Z Wed Apr 12 19:44:56 IST 2017 Signed-off-by: Ankit

[PATCH] Save current timestamp while moving oops message to nvram

2017-04-12 Thread Ankit Kumar
date -d command to print time according to local time zone. Partial pstore dump after applying this patch: Oops#1 Part1 [2017-04-12T14:14:56Z] Above time can be printed in current time zone using date -d command. #date -d 2017-04-12T14:14:56Z Wed Apr 12 19:44:56 IST 2017 Signed-off-by: Ankit