Re: [PATCH] ntfs: check for valid standard information attribute

Hi Andrew, Sorry for the delay in replying. > On 19 Feb 2021, at 18:49, Andrew Morton wrote: > > On Fri, 19 Feb 2021 01:54:30 +0000 Anton Altaparmakov > wrote: > >> Hi Andrew, >> >> Can you please push this one upstream? Thanks a lot in advance! > &g

Re: [PATCH] ntfs: check for valid standard information attribute

eported-and-tested-by: syzbot+c584225dabdea2f71...@syzkaller.appspotmail.com > Signed-off-by: Rustam Kovhaev > Acked-by: Anton Altaparmakov > Link: https://syzkaller.appspot.com/bug?extid=c584225dabdea2f71969 > --- > fs/ntfs/inode.c | 6 ++ > 1 file changed, 6 insertions(+) > &

Re: [PATCH] ntfs: move check for valid resident attribute offset and length

ibute list attribute needs to remain, i.e. your second delta needs to be deleted. Please could you address both of the above comments and then resend? Please then also add: "Acked-by: Anton Altaparmakov " to the patch. Thanks a lot in advance! Best regards, Anton > On 14 Feb

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

:36, Andrew Morton wrote: > > On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov wrote: > >> Can you please apply this? >> >> ... >> >>> --- a/fs/ntfs/logfile.c >>> +++ b/fs/ntfs/logfile.c >>> @@ -507,7 +507,7 @@ bool ntfs_ch

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

k_logfile: > fs/ntfs/logfile.c:481:21: > warning: variable log_page_mask set but not used [-Wunused-but-set-variable] > > Actually log_page_mask can be used to replace 'log_page_size - 1' as it is > set. > > Signed-off-by: Zheng Zengkai > Acked-by: Anton Altaparmakov &g

Re: [PATCH] fs/ntfs: remove unused varibles

ng: variable ‘base_ni’ set but not used > [-Wunused-but-set-variable] > fs/ntfs/logfile.c:481:21: warning: variable ‘log_page_mask’ set but not > used [-Wunused-but-set-variable] > > Signed-off-by: Alex Shi > Acked-by: Anton Altaparmakov > Cc: linux-ntfs-...@lists.so

Re: [PATCH] fs/ntfs: remove unused varible attr_len

used varible attr_len > > This varible isn't used anymore, remove it to skip W=1 warning: > fs/ntfs/inode.c:2350:6: warning: variable ‘attr_len’ set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Alex Shi > Acked-by: Anton Altaparmakov > --- > fs/ntfs/inode

Re: [PATCH RESEND] ntfs: drop unneeded semi-colons

Hi Randy, Sorry, I don't know how I missed those originally. Andrew, please could you add this to your tree for merging with Linus as well? And again, please feel free to add: Acked-by: Anton Altaparmakov Thanks a lot! Best regards, Anton > On 18 Sep 2020, at 02:20, Randy Dun

Re: [PATCH RESEND] ntfs: layout.h: delete duplicated words

Hi Randy, Sorry, I don't know how I missed those originally. Andrew, please could you add this to your tree for merging with Linus? Please feel free to add: Acked-by: Anton Altaparmakov Thanks a lot! Best regards, Anton > On 18 Sep 2020, at 02:20, Randy Dunlap wrote: >

Re: [PATCH] ntfs: add check for mft record size in superblock

06913f36eff9b544e > Signed-off-by: Rustam Kovhaev > Acked-by: Anton Altaparmakov > --- > fs/ntfs/inode.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c > index 9bb9f0952b18..caf563981532 100644 > --- a/fs/ntfs/ino

Re: [PATCH] ntfs: add check for mft record size in superblock

und the numbers and it would be better to have this consistent throughout. Can you please resend with the above issues addressed? You can then also add to the commit message: Acked-by: Anton Altaparmakov Thanks! Best regards, Anton > On 23 Aug 2020, at 16:21, Rustam K

Re: [PATCH v2] ntfs: Fix ntfs_test_inode and ntfs_init_locked_inode function type

0x18/0x24 > mount_fs+0x1b0/0x380 > vfs_kern_mount+0x90/0x398 > do_mount+0x5d8/0x1a10 > SyS_mount+0x108/0x144 > el0_svc_naked+0x34/0x38 > > Signed-off-by: Luca Stefani > Tested-by: freak07 > Acked-by: Anton Altaparmakov > --- > fs/ntfs/dir.c | 2 +- > fs/

Re: [PATCH] ntfs: Fix ntfs_test_inode and ntfs_init_locked_inode function type

Hi Luca, Apologies for taking this long to respond. I have to admit I was not familiar with CFI... Your patch looks good but please could you update the commit message as suggested by Nick to include explanation of CFI? You can then add: Acked-by: Anton Altaparmakov When resending please

Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]

is that for long names (i.e. not the 8.3 style/DOS/short names), it actually stores on-disk little-endian UTF-16 (since Windows 2000, before that it used little endian UCS-2 - the change was needed to support things like Emojis and some languages that go outside the UCS-2 range of fixed 16-bit unicode).

Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]

is that for long names (i.e. not the 8.3 style/DOS/short names), it actually stores on-disk little-endian UTF-16 (since Windows 2000, before that it used little endian UCS-2 - the change was needed to support things like Emojis and some languages that go outside the UCS-2 range of fixed 16-bit unicode).

Re: Race condition between iget_locked() and evict_inodes()

Hi Al, > On 29 Sep 2016, at 13:17, Al Viro <v...@zeniv.linux.org.uk> wrote: > > On Thu, Sep 29, 2016 at 11:53:21AM +, Anton Altaparmakov wrote: >> Thus if the events happen in this order: >> >> evict_inodes() iget_locked() in

Re: Race condition between iget_locked() and evict_inodes()

Hi Al, > On 29 Sep 2016, at 13:17, Al Viro wrote: > > On Thu, Sep 29, 2016 at 11:53:21AM +0000, Anton Altaparmakov wrote: >> Thus if the events happen in this order: >> >> evict_inodes() iget_locked() in >> find_inode_fast() &

Race condition between iget_locked() and evict_inodes()

it should at least re-check it. Please tell me what I am missing here. I assume there must be something providing exclusion and I am just too blind to see it but I thought it worth bringing to your attention in case it really is simply broken. Best regards, Anton -- Anton Altaparmakov

Race condition between iget_locked() and evict_inodes()

it should at least re-check it. Please tell me what I am missing here. I assume there must be something providing exclusion and I am just too blind to see it but I thought it worth bringing to your attention in case it really is simply broken. Best regards, Anton -- Anton Altaparmakov

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

> On 24 Sep 2015, at 10:20, Anton Altaparmakov wrote: > > Hi Andrzej, > >> On 24 Sep 2015, at 09:34, Andrzej Hajda wrote: >> >> On 09/23/2015 12:21 PM, Anton Altaparmakov wrote: >>> Hi Andrzej, >>> >>> Thanks for your

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

Hi Andrzej, > On 24 Sep 2015, at 09:34, Andrzej Hajda wrote: > > On 09/23/2015 12:21 PM, Anton Altaparmakov wrote: >> Hi Andrzej, >> >> Thanks for your patch. It looks fine though I don't quite see the point of >> it to be honest. >> >> It actua

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

> On 24 Sep 2015, at 10:20, Anton Altaparmakov <an...@tuxera.com> wrote: > > Hi Andrzej, > >> On 24 Sep 2015, at 09:34, Andrzej Hajda <a.ha...@samsung.com> wrote: >> >> On 09/23/2015 12:21 PM, Anton Altaparmakov wrote: >>> Hi Andrzej, >

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

Hi Andrzej, > On 24 Sep 2015, at 09:34, Andrzej Hajda <a.ha...@samsung.com> wrote: > > On 09/23/2015 12:21 PM, Anton Altaparmakov wrote: >> Hi Andrzej, >> >> Thanks for your patch. It looks fine though I don't quite see the point of >> it to be honest

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

/* Copy the index root value (it has been verified in read_inode). */ > - memcpy(ir, (u8*)ctx->attr + > - le16_to_cpu(ctx->attr->data.resident.value_offset), rc); > ntfs_attr_put_search_ctx(ctx); > unmap_mft_record(ndir);

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

r = -ENOMEM; > goto err_out; > } > - /* Copy the index root value (it has been verified in read_inode). */ > - memcpy(ir, (u8*)ctx->attr + > - le16_to_cpu(ctx->attr->data.resident.value_offset), rc); > ntfs_attr_put_search_ct

Re: [PATCH] ntfs: Deletion of unnecessary checks before the function call "iput"

Hi Andrew, Can you please take up this trivial patch and merge it upstream? Reviewed-by: Anton Altaparmakov Thanks a lot in advance! Best regards, Anton > On 4 Jul 2015, at 11:32, SF Markus Elfring > wrote: > >> From: Markus Elfring >> Date: Sat, 15 No

Re: [PATCH] ntfs: Deletion of unnecessary checks before the function call iput

Hi Andrew, Can you please take up this trivial patch and merge it upstream? Reviewed-by: Anton Altaparmakov an...@tuxera.com Thanks a lot in advance! Best regards, Anton On 4 Jul 2015, at 11:32, SF Markus Elfring elfr...@users.sourceforge.net wrote: From: Markus Elfring elfr

i_uid_read()/i_uid_write() and friends

d_read() and i_uid_write() are static inline it causes them to be unusable from non-gpl kernel modules... Same thing applies to i_gid_read() and i_gid_write(). These seem pretty fundamental calls that a non-gpl file system should be able to call, no? Best regards, Anton -- Anton Altapa

i_uid_read()/i_uid_write() and friends

() and i_uid_write() are static inline it causes them to be unusable from non-gpl kernel modules... Same thing applies to i_gid_read() and i_gid_write(). These seem pretty fundamental calls that a non-gpl file system should be able to call, no? Best regards, Anton -- Anton Altaparmakov

Re: [fuse-devel] [PATCH v5 7/7] add a flag for per-operation O_DSYNC semantics

Hi, > On 7 Nov 2014, at 07:52, Anand Avati wrote: > On Thu, Nov 6, 2014 at 8:22 PM, Anton Altaparmakov wrote: > > On 7 Nov 2014, at 01:46, Jeff Moyer wrote: > > Minor nit, but I'd rather read something that looks like this: > > > > if (type ==

Re: [PATCH v5 7/7] add a flag for per-operation O_DSYNC semantics

here "type == READ" is true and "flags & RWF_NONBLOCK" is false because your version then has to do the "if (type == WRITE" check before discovering it does not need to take that branch either, whilst the original version does not have to do such a test at all. B

Re: [Linux-NTFS-Dev] [PATCH v5 6/7] fs: pass iocb to generic_write_sync

inline int generic_write_sync(struct file *file, loff_t pos, loff_t > count) > -{ > - if (!(file->f_flags & O_DSYNC) && !IS_SYNC(file->f_mapping->host)) > - return 0; > - return vfs_fsync_range(file, pos, pos + count - 1, > -

Re: [PATCH v5 7/7] add a flag for per-operation O_DSYNC semantics

it does not need to take that branch either, whilst the original version does not have to do such a test at all. Best regards, Anton I won't lose sleep over it, though. Reviewed-by: Jeff Moyer jmo...@redhat.com -- Anton Altaparmakov aia21 at cam.ac.uk (replace

Re: [fuse-devel] [PATCH v5 7/7] add a flag for per-operation O_DSYNC semantics

Hi, On 7 Nov 2014, at 07:52, Anand Avati av...@gluster.org wrote: On Thu, Nov 6, 2014 at 8:22 PM, Anton Altaparmakov ai...@cam.ac.uk wrote: On 7 Nov 2014, at 01:46, Jeff Moyer jmo...@redhat.com wrote: Minor nit, but I'd rather read something that looks like this: if (type == READ

Re: [Linux-NTFS-Dev] [PATCH v5 6/7] fs: pass iocb to generic_write_sync

that the NTFS bits are: Acked-by: Anton Altaparmakov an...@tuxera.com Best regards, Anton + + ret = vfs_fsync_range(file, iocb-ki_pos - count, + iocb-ki_pos - 1, fdatasync); + if (ret 0) + return ret

[git pull] Small NTFS update

(+), 293 deletions(-) Shortlog: Anton Altaparmakov (4): NTFS: Split ntfs_aops into ntfs_normal_aops and ntfs_compressed_aop in preparation for them diverging. NTFS: Remove changelog from Documentation/filesystems/ntfs.txt. NTFS: Add bmap address space operation needed

[git pull] Small NTFS update

(+), 293 deletions(-) Shortlog: Anton Altaparmakov (4): NTFS: Split ntfs_aops into ntfs_normal_aops and ntfs_compressed_aop in preparation for them diverging. NTFS: Remove changelog from Documentation/filesystems/ntfs.txt. NTFS: Add bmap address space operation needed

Re: WTF is d_add_ci() doing with negative dentries?

Hi Al, On 13 Oct 2014, at 03:14, Al Viro wrote: > On Mon, Oct 13, 2014 at 12:56:11AM +0100, Anton Altaparmakov wrote: >> I am just wondering whether there might be error conditions in which we >> might end up with a (perhaps invalid) negative dentry in memory which could &

Re: WTF is d_add_ci() doing with negative dentries?

Hi Al, On 13 Oct 2014, at 03:14, Al Viro v...@zeniv.linux.org.uk wrote: On Mon, Oct 13, 2014 at 12:56:11AM +0100, Anton Altaparmakov wrote: I am just wondering whether there might be error conditions in which we might end up with a (perhaps invalid) negative dentry in memory which could

Re: WTF is d_add_ci() doing with negative dentries?

better to pass dentry->d_parent instead > of dentry... Objections? Yes, that bit makes perfect sense given we only ever use dentry->d_parent. Best regards, Anton -- Anton Altaparmakov (replace at with @) University of Cambridge Information Services, Roger Needham Building 7

Re: WTF is d_add_ci() doing with negative dentries?

, that bit makes perfect sense given we only ever use dentry-d_parent. Best regards, Anton -- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) University of Cambridge Information Services, Roger Needham Building 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK -- To unsubscribe from

Re: [PATCH] NTFS: Remove bogus space.

Hi Andrew, Forgot to say that this patch is from Andrea Gilmini originally (I had to re-do it as it is an old patch and the line numbers had changed)... Best regards, Anton On 3 Oct 2014, at 00:44, Anton Altaparmakov wrote: > fs/ntfs/debug.c:124: WARNING: space prohibited betw

[PATCH] NTFS: Remove bogus space.

fs/ntfs/debug.c:124: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Andrea Gelmini Signed-off-by: Anton Altaparmakov --- Hi Andrew, Can you please take this simple patch and push it to Linus at some point? Thanks a lot in advance! Best regards

[PATCH] NTFS: Remove bogus space.

fs/ntfs/debug.c:124: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Andrea Gelmini andrea.gelm...@gelma.net Signed-off-by: Anton Altaparmakov an...@tuxera.com --- Hi Andrew, Can you please take this simple patch and push it to Linus at some point

Re: [PATCH] NTFS: Remove bogus space.

Hi Andrew, Forgot to say that this patch is from Andrea Gilmini originally (I had to re-do it as it is an old patch and the line numbers had changed)... Best regards, Anton On 3 Oct 2014, at 00:44, Anton Altaparmakov ai...@cam.ac.uk wrote: fs/ntfs/debug.c:124: WARNING: space

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

Hi Linus, On 22 Sep 2014, at 16:33, Linus Torvalds wrote: > On Mon, Sep 22, 2014 at 8:29 AM, Anton Altaparmakov wrote: >> >> You could do "block & ~(sector_t)(size - 1)" instead of "(sector_t)index << >> sizebits" if you prefer but not sur

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

Hi Linus, On 22 Sep 2014, at 16:18, Linus Torvalds wrote: > On Sun, Sep 21, 2014 at 5:53 PM, Anton Altaparmakov wrote: >> >> This patch fixes this issue by type casting "index" to sector_t before >> doing the left shift. > > Ugh. Does the simpler patch

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

Hi, On 22 Sep 2014, at 11:36, Hugh Dickins wrote: > On Mon, 22 Sep 2014, Anton Altaparmakov wrote: >> On 22 Sep 2014, at 05:43, Hugh Dickins wrote: >>> On Mon, 22 Sep 2014, Anton Altaparmakov wrote: >>>> Any code that uses __getblk() and thus b

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

Hi Hugh, On 22 Sep 2014, at 05:43, Hugh Dickins wrote: > On Mon, 22 Sep 2014, Anton Altaparmakov wrote: >> Any code that uses __getblk() and thus bread(), breadahead(), sb_bread(), >> sb_breadahead(), sb_getblk(), and calls it using a 64-bit block on a >> 32-bit arch (w

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

Hi Hugh, On 22 Sep 2014, at 05:43, Hugh Dickins hu...@google.com wrote: On Mon, 22 Sep 2014, Anton Altaparmakov wrote: Any code that uses __getblk() and thus bread(), breadahead(), sb_bread(), sb_breadahead(), sb_getblk(), and calls it using a 64-bit block on a 32-bit arch (where long is 32

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

Hi, On 22 Sep 2014, at 11:36, Hugh Dickins hu...@google.com wrote: On Mon, 22 Sep 2014, Anton Altaparmakov wrote: On 22 Sep 2014, at 05:43, Hugh Dickins hu...@google.com wrote: On Mon, 22 Sep 2014, Anton Altaparmakov wrote: Any code that uses __getblk() and thus bread(), breadahead

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

Hi Linus, On 22 Sep 2014, at 16:18, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Sep 21, 2014 at 5:53 PM, Anton Altaparmakov ai...@cam.ac.uk wrote: This patch fixes this issue by type casting index to sector_t before doing the left shift. Ugh. Does the simpler patch to just

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

Hi Linus, On 22 Sep 2014, at 16:33, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Sep 22, 2014 at 8:29 AM, Anton Altaparmakov ai...@cam.ac.uk wrote: You could do block ~(sector_t)(size - 1) instead of (sector_t)index sizebits if you prefer but not sure that is an improvement

[PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

t is an NTFS volume causes the inifinite loop 100% reproducibly whilst with the patch it works fine as expected. Signed-off-by: Anton Altaparmakov Cc: sta...@vger.kernel.org # 3.6 3.8 3.10 3.12 3.14 3.16 --- Linus, can you please apply this? Alternatively, Andrew, can you please pick this up

[PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

% reproducibly whilst with the patch it works fine as expected. Signed-off-by: Anton Altaparmakov ai...@cantab.net Cc: sta...@vger.kernel.org # 3.6 3.8 3.10 3.12 3.14 3.16 --- Linus, can you please apply this? Alternatively, Andrew, can you please pick this up and send it to Linus? It would be good

[PATCH] Use find_get_page_flags() to mark page accessed as it is no longer marked later on

to never be marked accessed. This patch fixes that. Signed-off-by: Anton Altaparmakov --- Hi Andrew, Can you please take the below patch and forward it for inclusion to Linus? Thanks a lot in advance! Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computi

[PATCH] Use find_get_page_flags() to mark page accessed as it is no longer marked later on

be marked accessed. This patch fixes that. Signed-off-by: Anton Altaparmakov an...@tuxera.com --- Hi Andrew, Can you please take the below patch and forward it for inclusion to Linus? Thanks a lot in advance! Best regards, Anton -- Anton Altaparmakov aia21 at cam.ac.uk (replace

Re: [PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.

Hi Linus, No-one has objected to the below patch I sent you over two weeks ago. Would you please apply it? If you would like it to go through for example Al or Andrew please let me know... Thanks a lot in advance! Best regards, Anton On 21 Aug 2014, at 11:09, Anton Altaparmakov

Re: [PATCH] mm: clear __GFP_FS when PF_MEMALLOC_NOIO is set

a lock could return with -EDEADLOCK and the VM can then skip over those entries and reclaim others. Though I think it would be more efficient for the VFS/VM to simply not call into the file system that is doing the allocation as above... Best regards, Anton -- Anton Altaparmak

Re: [PATCH] Now that sync_filesystem() must be called from -remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.

Hi Linus, No-one has objected to the below patch I sent you over two weeks ago. Would you please apply it? If you would like it to go through for example Al or Andrew please let me know... Thanks a lot in advance! Best regards, Anton On 21 Aug 2014, at 11:09, Anton Altaparmakov ai

Re: [PATCH] mm: clear __GFP_FS when PF_MEMALLOC_NOIO is set

and the VM can then skip over those entries and reclaim others. Though I think it would be more efficient for the VFS/VM to simply not call into the file system that is doing the allocation as above... Best regards, Anton -- Anton Altaparmakov aia21 at cam.ac.uk (replace

[PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.

off-by: Anton Altaparmakov --- Hi Linus, Can you please apply this patch for inclusion into 3.17? Explanation is above. Thanks a lot in advance! PS. I hope Pine does not mess up the whitespace of the patch! Best regards, Anton -- Anton Altaparmakov (replace at with @) University

[PATCH] Now that sync_filesystem() must be called from -remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.

Altaparmakov ai...@cantab.net --- Hi Linus, Can you please apply this patch for inclusion into 3.17? Explanation is above. Thanks a lot in advance! PS. I hope Pine does not mess up the whitespace of the patch! Best regards, Anton -- Anton Altaparmakov aia21 at cam.ac.uk (replace

Re: Revert "platform/x86/toshiba-apci.c possible bad if test?"

/toshiba_acpi.c > @@ -1258,7 +1258,7 @@ static ssize_t toshiba_kbd_bl_mode_store(struct device > *dev, > int mode = -1; > int time = -1; > > - if (sscanf(buf, "%i", ) != 1 || (mode != 2 || mode != 1)) > + if (sscanf(buf, "%i", ) != 1 &

Re: Revert platform/x86/toshiba-apci.c possible bad if test?

toshiba_kbd_bl_mode_store(struct device *dev, int mode = -1; int time = -1; - if (sscanf(buf, %i, mode) != 1 || (mode != 2 || mode != 1)) + if (sscanf(buf, %i, mode) != 1 (mode != 2 || mode != 1)) return -EINVAL; /* Set the Keyboard Backlight Mode where: -- Anton

Re: Bug introduced in 3b93f911d5

Hi Al, On 8 Aug 2014, at 16:54, Al Viro wrote: > On Fri, Aug 08, 2014 at 12:11:39AM +0100, Anton Altaparmakov wrote: >> Hi Al, >> >> Was just looking at __generic_file_write_iter() and found a bug in the code >> that you added in 3b93f911d5. >

Re: Bug introduced in 3b93f911d5

Hi Al, On 8 Aug 2014, at 16:54, Al Viro v...@zeniv.linux.org.uk wrote: On Fri, Aug 08, 2014 at 12:11:39AM +0100, Anton Altaparmakov wrote: Hi Al, Was just looking at __generic_file_write_iter() and found a bug in the code that you added in 3b93f911d5. Consider the case where

Bug introduced in 3b93f911d5

uot; being set to "pos - random value - 1", etc. Doesn't seem like that is what you intended? Best regards, Anton -- Anton Altaparmakov (replace at with @) University of Cambridge Information Services, Roger Needham Building 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK -- To

Bug introduced in 3b93f911d5

that is what you intended? Best regards, Anton -- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) University of Cambridge Information Services, Roger Needham Building 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] ntfs: avoid incorrectly release for root inode in fill_super

iput(vol->root_ino); > + > + /* > + * Just set NULL value here because we have already iput root_ino > + * in d_make_root. > + */ > vol->root_ino = NULL; > iput(vol->lcnbmp_ino); > vol->lcnbmp_ino = NULL; -- Anton Altaparmako

Re: linux fsync behaviour

? We are using >> linux XFS. > > Yes. But beware of the common mistake of using fwrite + fsync which does not actually do what you intend at all and you must instead use fwrite + fflush + fsync... If you are using write(2) then just fsync is obviously fine. Best regards,

Re: linux fsync behaviour

XFS. Yes. But beware of the common mistake of using fwrite + fsync which does not actually do what you intend at all and you must instead use fwrite + fflush + fsync... If you are using write(2) then just fsync is obviously fine. Best regards, Anton -- Anton Altaparmakov aia21

Re: [PATCH] ntfs: avoid incorrectly release for root inode in fill_super

); + + /* + * Just set NULL value here because we have already iput root_ino + * in d_make_root. + */ vol-root_ino = NULL; iput(vol-lcnbmp_ino); vol-lcnbmp_ino = NULL; -- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) University of Cambridge Information Services

Re: [PATCH 1/1] ntfs: kernel-doc warning fixes

Hi, Looks good, thanks. Feel free to add: Acked-by: Anton Altaparmakov Andrew, could you please take it in your tree for merging? Thanks a lot in advance! Best regards, Anton On 4 Jul 2014, at 20:53, Fabian Frederick wrote: > cached_page and lru_pvec were removed f

Re: [PATCH 1/1] ntfs: kernel-doc warning fixes

Hi, Looks good, thanks. Feel free to add: Acked-by: Anton Altaparmakov an...@tuxera.com Andrew, could you please take it in your tree for merging? Thanks a lot in advance! Best regards, Anton On 4 Jul 2014, at 20:53, Fabian Frederick f...@skynet.be wrote: cached_page and lru_pvec

Re: [PATCH] ntfs: Drop cast

ntfs/inode.c > @@ -1817,7 +1817,7 @@ int ntfs_read_inode_mount(struct inode *vi) > i = vol->mft_record_size; > if (i < sb->s_blocksize) > i = sb->s_blocksize; > - m = (MFT_RECORD*)ntfs_malloc_nofs(i); > + m = ntfs_malloc_nofs(i); > i

Re: [PATCH] ntfs: Drop cast

; -- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) University of Cambridge Information Services, Roger Needham Building 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] ntfs: Cleanup string initializations (char[] instead of char *)

; { > - const char *read_err_str = "Unable to read %s boot sector."; > + const char read_err_str[] = "Unable to read %s boot sector."; > struct buffer_head *bh_primary, *bh_backup; > sector_t nr_blocks = NTFS_SB(sb)->nr_blocks; > &

Re: [PATCH] ntfs: Cleanup string initializations (char[] instead of char *)

-- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) University of Cambridge Information Services, Roger Needham Building 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/1] fs/ntfs/mft.c: fix 2 sparse warnings

ble length array is used. > > This is untested. > > Cc: Anton Altaparmakov > Cc: Andrew Morton > Signed-off-by: Fabian Frederick > --- > fs/ntfs/mft.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/fs/ntfs/mft.c b/fs/ntfs

Re: [PATCH 1/1] fs/ntfs/mft.c: fix 2 sparse warnings

array is used. This is untested. Cc: Anton Altaparmakov an...@tuxera.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ntfs/mft.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/fs/ntfs/mft.c b/fs

Re: [PATCH v2] NTFS: Remove NULL value assignments

Hi Andrew, Please could you merge this via your patch series? Thanks a lot in advance! Best regards, Anton On 9 Apr 2014, at 18:01, Fabian Frederick wrote: > Static values are automatically initialized to NULL. > > Acked-by: Anton Altaparmakov > Cc: Andrew Morton

Re: [PATCH 1/1] NTFS: Remove NULL value assignments

> Static values are automatically initialized to NULL. > > Cc: Andrew Morton > Cc: Anton Altaparmakov > Signed-off-by: Fabian Frederick > --- > fs/ntfs/compress.c | 2 +- > fs/ntfs/super.c| 2 +- > fs/ntfs/sysctl.c | 2 +- > 3 files changed, 3 insertions(+),

Re: [PATCH 1/1] NTFS: Remove NULL value assignments

wrote: Static values are automatically initialized to NULL. Cc: Andrew Morton a...@linux-foundation.org Cc: Anton Altaparmakov an...@tuxera.com Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ntfs/compress.c | 2 +- fs/ntfs/super.c| 2 +- fs/ntfs/sysctl.c | 2 +- 3 files changed, 3

Re: [PATCH v2] NTFS: Remove NULL value assignments

Hi Andrew, Please could you merge this via your patch series? Thanks a lot in advance! Best regards, Anton On 9 Apr 2014, at 18:01, Fabian Frederick f...@skynet.be wrote: Static values are automatically initialized to NULL. Acked-by: Anton Altaparmakov an...@tuxera.com Cc

Re: [PATCH 1/1] NTFS: Logging clean-up

Hi, On 16 Mar 2014, at 16:12, Joe Perches wrote: > On Sun, 2014-03-16 at 15:53 +0000, Anton Altaparmakov wrote: >> Hi, >> >> Looks good, thanks. You can add my Acked-by if you like. Can I assume you >> have test it builds? >> >> Andrew, can you

Re: [PATCH 1/1] NTFS: Logging clean-up

he) { > - printk(KERN_CRIT "NTFS: Failed to create %s!\n", > - ntfs_big_inode_cache_name); > + pr_crit("Failed to create %s!\n", ntfs_big_inode_cache_name); > goto big_inode_err_out; > } > > /* Regist

Re: [PATCH 1/1] NTFS: Logging clean-up

= -ENOMEM; } return err; -- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) Unix Support, Computing Service, University of Cambridge J.J. Thomson Avenue, Cambridge, CB3 0RB, UK -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 1/1] NTFS: Logging clean-up

Hi, On 16 Mar 2014, at 16:12, Joe Perches j...@perches.com wrote: On Sun, 2014-03-16 at 15:53 +, Anton Altaparmakov wrote: Hi, Looks good, thanks. You can add my Acked-by if you like. Can I assume you have test it builds? Andrew, can you please merge this via your patch series

Re: [PATCH 1/1] Documentation/filesystems/ntfs.txt: Remove changelog reference

ChangeLog. > - > 2.1.30: > - Fix writev() (it kept writing the first segment over and over again > instead of moving onto subsequent segments). > -- > 1.8.1.4 -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge J.J. Thoms

Re: [PATCH 1/1] Documentation/filesystems/ntfs.txt: Remove changelog reference

the first segment over and over again instead of moving onto subsequent segments). -- 1.8.1.4 -- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) Unix Support, Computing Service, University of Cambridge J.J. Thomson Avenue, Cambridge, CB3 0RB, UK -- To unsubscribe from

Re: [PATCH] hfsplus: Remove hfsplus_file_lookup

hem via the xattr interface (ok it has the 64k limitation but most forks are quite small so not much of an issue). That's how I implemented access to named streams in Tuxera NTFS and it works a treat (and allows Linux apps and various security modules that require xattr support to wor

Re: [PATCH] hfsplus: Remove hfsplus_file_lookup

are quite small so not much of an issue). That's how I implemented access to named streams in Tuxera NTFS and it works a treat (and allows Linux apps and various security modules that require xattr support to work properly which is also great). Best regards, Anton -- Anton

Re: [PATCH] add exFAT driver

ense from Microsoft. For licensing information, please contact iplic...@microsoft.com. Above is from bottom of: http://www.microsoft.com/en-us/legal/intellectualproperty/IPLicensing/Programs/exFATFileSystem.aspx Best regards, Anton -- Anton Altaparmakov (replace at with @)

Re: [PATCH] add exFAT driver

Hi, On 25 Sep 2013, at 23:10, Greg Kroah-Hartman wrote: > On Wed, Sep 25, 2013 at 10:44:15PM +0100, Anton Altaparmakov wrote: >> On 25 Sep 2013, at 21:21, Greg Kroah-Hartman >> wrote: >>> On Wed, Sep 25, 2013 at 09:28:56PM +0200, Alexander Holler wrote: >>&

Re: [PATCH] add exFAT driver

Hi, On 25 Sep 2013, at 23:10, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Sep 25, 2013 at 10:44:15PM +0100, Anton Altaparmakov wrote: On 25 Sep 2013, at 21:21, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Sep 25, 2013 at 09:28:56PM +0200, Alexander Holler

Re: [PATCH] add exFAT driver

...@microsoft.com. /quote Above is from bottom of: http://www.microsoft.com/en-us/legal/intellectualproperty/IPLicensing/Programs/exFATFileSystem.aspx Best regards, Anton -- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) Unix Support, Computing Service, University

Re: [PATCH] add exFAT driver

above in a hurry... Sorry I cannot say more but I strongly suggest NOT to use this "GPL-ed exFAT driver" under any circumstances unless you get a patent license from Microsoft first. Best regards, Anton > thanks, > > greg k-h -- Anton Altaparmakov (replace at with @)

Re: [PATCH] add exFAT driver

but I strongly suggest NOT to use this GPL-ed exFAT driver under any circumstances unless you get a patent license from Microsoft first. Best regards, Anton thanks, greg k-h -- Anton Altaparmakov aia21 at cam.ac.uk (replace at with @) Unix Support, Computing Service, University

Re: cifs: bugfix for unreclaimed writeback pages in cifs_writev_requeue()

> + end_page_writeback(wdata->pages[i]); > + page_cache_release(wdata->pages[i]); > + } > unlock_page(wdata->pages[i]); > } > -- Anton Altaparmakov (replace at with @) Unix Support, Computing S

  1   2   3   4   5   6   7   >