Re: [PATCH v2 4/4] ARM: OMAP2+: Provide alias to USB PHY clock

2013-07-16 Thread Arend van Spriel
On 07/15/2013 04:05 PM, Roger Quadros wrote: Hi Tony, On 06/18/2013 07:04 PM, Roger Quadros wrote: Till the OMAP clocks are correctly defined in device tree, use this temporary hack to provide clock alias to the USB PHY clocks. Without this, USB Host Ethernet will not be functional with

Re: [PATCH v2 4/4] ARM: OMAP2+: Provide alias to USB PHY clock

2013-07-16 Thread Arend van Spriel
On 07/16/2013 03:12 PM, Arend van Spriel wrote: On 07/15/2013 04:05 PM, Roger Quadros wrote: Hi Tony, On 06/18/2013 07:04 PM, Roger Quadros wrote: Till the OMAP clocks are correctly defined in device tree, use this temporary hack to provide clock alias to the USB PHY clocks. Without

Re: [PATCH net-next v2 1/3] net: rename include/net/ll_poll.h to include/net/busy_poll.h

2013-07-10 Thread Arend van Spriel
On 07/10/2013 02:13 PM, Eliezer Tamir wrote: Rename the file and correct all the places where it is included. Signed-off-by: Eliezer Tamir --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c |2 drivers/net/ethernet/intel/ixgbe/ixgbe.h|2

Re: [PATCH net-next v2 1/3] net: rename include/net/ll_poll.h to include/net/busy_poll.h

2013-07-10 Thread Arend van Spriel
On 07/10/2013 02:13 PM, Eliezer Tamir wrote: Rename the file and correct all the places where it is included. Signed-off-by: Eliezer Tamir eliezer.ta...@linux.intel.com --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c |2 drivers/net/ethernet/intel/ixgbe/ixgbe.h|2

Re: [for-next][PATCH 08/12] tracing: Add binary & filter for events

2013-06-20 Thread Arend van Spriel
On 06/20/13 20:38, Steven Rostedt wrote: On Thu, 2013-06-20 at 14:34 -0400, Steven Rostedt wrote: On Thu, 2013-06-20 at 20:28 +0200, Arend van Spriel wrote: Reading the whole text with your remark in mind, I guess it does indicate there are no guarantees depending on the kernel and the list

Re: [for-next][PATCH 08/12] tracing: Add binary & filter for events

2013-06-20 Thread Arend van Spriel
On 06/20/13 14:14, Steven Rostedt wrote: On Thu, 2013-06-20 at 10:09 +0200, Arend van Spriel wrote: On 06/20/2013 05:35 AM, Steven Rostedt wrote: By allowing a binary '&' operation, this gives the user the ability to test a bit. Note, a binary '|' is not added, as it doesn't make s

Re: [for-next][PATCH 08/12] tracing: Add binary & filter for events

2013-06-20 Thread Arend van Spriel
http://lkml.kernel.org/r/1371057385.9844.261.ca...@gandalf.local.home Suggested-by: Arend van Spriel Actually, my attempt was triggered by the trace-cmd manual page: "-f filter Specify a filter for the previous event. This must come after a -e. This will filter what events get recor

Re: [for-next][PATCH 08/12] tracing: Add binary filter for events

2013-06-20 Thread Arend van Spriel
On 06/20/2013 05:35 AM, Steven Rostedt wrote: By allowing a binary '' operation, this gives the user the ability to test a bit. Note, a binary '|' is not added, as it doesn't make sense as fields must be compared to constants (for now), and ORing a constant will always return true.

Re: [for-next][PATCH 08/12] tracing: Add binary filter for events

2013-06-20 Thread Arend van Spriel
On 06/20/13 14:14, Steven Rostedt wrote: On Thu, 2013-06-20 at 10:09 +0200, Arend van Spriel wrote: On 06/20/2013 05:35 AM, Steven Rostedt wrote: By allowing a binary '' operation, this gives the user the ability to test a bit. Note, a binary '|' is not added, as it doesn't make sense

Re: [for-next][PATCH 08/12] tracing: Add binary filter for events

2013-06-20 Thread Arend van Spriel
On 06/20/13 20:38, Steven Rostedt wrote: On Thu, 2013-06-20 at 14:34 -0400, Steven Rostedt wrote: On Thu, 2013-06-20 at 20:28 +0200, Arend van Spriel wrote: Reading the whole text with your remark in mind, I guess it does indicate there are no guarantees depending on the kernel and the list

Re: event filtering with trace-cmd

2013-06-14 Thread Arend van Spriel
On 06/12/2013 07:16 PM, Steven Rostedt wrote: On Wed, 2013-06-12 at 12:22 -0400, Steven Rostedt wrote: # sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level & 0x4' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level & 0x4) ^

Re: event filtering with trace-cmd

2013-06-14 Thread Arend van Spriel
On 06/12/2013 07:16 PM, Steven Rostedt wrote: On Wed, 2013-06-12 at 12:22 -0400, Steven Rostedt wrote: # sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level 0x4' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level 0x4) ^

Re: event filtering with trace-cmd

2013-06-12 Thread Arend van Spriel
On 06/12/2013 07:16 PM, Steven Rostedt wrote: On Wed, 2013-06-12 at 12:22 -0400, Steven Rostedt wrote: # sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level & 0x4' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level & 0x4) ^

event filtering with trace-cmd

2013-06-12 Thread Arend van Spriel
Hi Steven I wanted to filter my debug events getting only one specific level. So I followed the instruction found online, but I get a parse error. Running on 3.10-rc1 using trace-cmd 1.0.3. Should I upgrade? Regards, Arend

event filtering with trace-cmd

2013-06-12 Thread Arend van Spriel
Hi Steven I wanted to filter my debug events getting only one specific level. So I followed the instruction found online, but I get a parse error. Running on 3.10-rc1 using trace-cmd 1.0.3. Should I upgrade? Regards, Arend

Re: event filtering with trace-cmd

2013-06-12 Thread Arend van Spriel
On 06/12/2013 07:16 PM, Steven Rostedt wrote: On Wed, 2013-06-12 at 12:22 -0400, Steven Rostedt wrote: # sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level 0x4' disable all enable brcmfmac:brcmf_dbg path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable (level 0x4) ^

Re: REGRESSION: 3.10-rc1: Dell Latitude e6410 hangs within 3 seconds

2013-05-18 Thread Arend van Spriel
On 05/18/13 03:47, Paul E. McKenney wrote: On Fri, May 17, 2013 at 10:49:16PM +0200, Arend van Spriel wrote: On 05/14/2013 10:38 PM, Arend van Spriel wrote: On 05/14/2013 10:34 PM, Rafael J. Wysocki wrote: On Tuesday, May 14, 2013 03:03:58 PM Arend van Spriel wrote: Laptop hangs pretty soon

Re: REGRESSION: 3.10-rc1: Dell Latitude e6410 hangs within 3 seconds

2013-05-18 Thread Arend van Spriel
On 05/18/13 03:47, Paul E. McKenney wrote: On Fri, May 17, 2013 at 10:49:16PM +0200, Arend van Spriel wrote: On 05/14/2013 10:38 PM, Arend van Spriel wrote: On 05/14/2013 10:34 PM, Rafael J. Wysocki wrote: On Tuesday, May 14, 2013 03:03:58 PM Arend van Spriel wrote: Laptop hangs pretty soon

Re: REGRESSION: 3.10-rc1: Dell Latitude e6410 hangs within 3 seconds

2013-05-14 Thread Arend van Spriel
On 05/14/2013 10:34 PM, Rafael J. Wysocki wrote: On Tuesday, May 14, 2013 03:03:58 PM Arend van Spriel wrote: Laptop hangs pretty soon after booting. Workaround for me was to turn off ACPI on kernel command line, ie. acpi=off Attached is my kernel configuration. Well, I have no idea what may

Re: REGRESSION: 3.10-rc1: Dell Latitude e6410 hangs within 3 seconds

2013-05-14 Thread Arend van Spriel
On 05/14/2013 10:34 PM, Rafael J. Wysocki wrote: On Tuesday, May 14, 2013 03:03:58 PM Arend van Spriel wrote: Laptop hangs pretty soon after booting. Workaround for me was to turn off ACPI on kernel command line, ie. acpi=off Attached is my kernel configuration. Well, I have no idea what may

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-18 Thread Arend van Spriel
On 04/18/2013 09:10 PM, Marcel Holtmann wrote: Hi Bing, Add a "wireless/nl80211_iftype" entry in the net device sysfs file structure to indicate the mode of the wireless device so it can be discovered easily from userspace. I do question a little bit the usefulness for this one. It would

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-18 Thread Arend van Spriel
On 04/18/2013 09:10 PM, Marcel Holtmann wrote: Hi Bing, Add a wireless/nl80211_iftype entry in the net device sysfs file structure to indicate the mode of the wireless device so it can be discovered easily from userspace. I do question a little bit the usefulness for this one. It would only

Re: [PATCH] lib80211: make lib80211 can be enabled independently

2013-04-05 Thread Arend van Spriel
On 04/05/2013 06:01 AM, Randy Dunlap wrote: On 04/04/13 16:51, Julian Calaby wrote: Hi Wang, On Fri, Apr 5, 2013 at 3:01 AM, Wang YanQing wrote: Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it

Re: [PATCH] lib80211: make lib80211 can be enabled independently

2013-04-05 Thread Arend van Spriel
On 04/05/2013 01:51 AM, Julian Calaby wrote: Hi Wang, On Fri, Apr 5, 2013 at 3:01 AM, Wang YanQing wrote: Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it has sense to make lib80211 can be

Re: [PATCH] lib80211: make lib80211 can be enabled independently

2013-04-05 Thread Arend van Spriel
On 04/05/2013 01:51 AM, Julian Calaby wrote: Hi Wang, On Fri, Apr 5, 2013 at 3:01 AM, Wang YanQing udkni...@gmail.com wrote: Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it has sense to make

Re: [PATCH] lib80211: make lib80211 can be enabled independently

2013-04-05 Thread Arend van Spriel
On 04/05/2013 06:01 AM, Randy Dunlap wrote: On 04/04/13 16:51, Julian Calaby wrote: Hi Wang, On Fri, Apr 5, 2013 at 3:01 AM, Wang YanQing udkni...@gmail.com wrote: Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use

Re: brcmsmac: firmware

2013-04-02 Thread Arend van Spriel
On 03/31/2013 10:38 AM, John Talbut wrote: > On 29/03/13 11:06, Arend van Spriel wrote: >> On 03/29/2013 07:14 AM, John Talbut wrote: >>> >>> As a matter of curiosity, why is the code currently in the firmware not >>> included in the kernel driver? >> >

Re: brcmsmac: firmware

2013-04-02 Thread Arend van Spriel
On 03/31/2013 10:38 AM, John Talbut wrote: On 29/03/13 11:06, Arend van Spriel wrote: On 03/29/2013 07:14 AM, John Talbut wrote: As a matter of curiosity, why is the code currently in the firmware not included in the kernel driver? Well. the kernel driver is what is running on the host

Re: [PATCH -mmotm resend] brcm80211: fix the misaligned indentation

2013-03-29 Thread Arend van Spriel
On 03/29/2013 01:33 PM, Akinobu Mita wrote: > This fixes the misaligned indentation introduced by > drivers-net-rename-random32-to-prandom_u32.patch in the -mm tree. > > This also remove unneeded parentheses in order not to cause line over > 80 characters. > Acked-by: Arend va

Re: [PATCH -mmotm resend] brcm80211: fix the misaligned indentation

2013-03-29 Thread Arend van Spriel
On 03/29/2013 01:33 PM, Akinobu Mita wrote: This fixes the misaligned indentation introduced by drivers-net-rename-random32-to-prandom_u32.patch in the -mm tree. This also remove unneeded parentheses in order not to cause line over 80 characters. Acked-by: Arend van Spriel ar

Re: [PATCH] brcmsmac: Remove unused macro SI_MSG

2013-03-23 Thread Arend van Spriel
On 03/22/2013 09:00 PM, Joe Perches wrote: > commit 6236dc2e2 ("brcmsmac: remove some redundant chip common workarounds") > removed the last uses. Good riddance. Acked-by: Arend van Spriel > Signed-off-by: Joe Perches > --- > drivers/net/wireless/brcm80211/brcmsmac/

Re: [PATCH] brcmsmac: Remove unused macro SI_MSG

2013-03-23 Thread Arend van Spriel
On 03/22/2013 09:00 PM, Joe Perches wrote: commit 6236dc2e2 (brcmsmac: remove some redundant chip common workarounds) removed the last uses. Good riddance. Acked-by: Arend van Spriel ar...@broadcom.com Signed-off-by: Joe Perches j...@perches.com --- drivers/net/wireless/brcm80211/brcmsmac

Re: [PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-22 Thread Arend van Spriel
On 03/22/2013 01:55 PM, Lubomir Rintel wrote: > Signed-off-by: Lubomir Rintel > Cc: Stephen Warren > Cc: Wim Van Sebroeck > Cc: linux-rpi-ker...@lists.infradead.org > Cc: linux-watch...@vger.kernel.org > --- > arch/arm/configs/bcm2835_defconfig |4 + > drivers/watchdog/Kconfig |

Re: [PATCH] watchdog: Add Broadcom BCM2708 watchdog timer driver

2013-03-22 Thread Arend van Spriel
On 03/22/2013 01:55 PM, Lubomir Rintel wrote: Signed-off-by: Lubomir Rintel lkund...@v3.sk Cc: Stephen Warren swar...@wwwdotorg.org Cc: Wim Van Sebroeck w...@iguana.be Cc: linux-rpi-ker...@lists.infradead.org Cc: linux-watch...@vger.kernel.org --- arch/arm/configs/bcm2835_defconfig |4

need info: softirq warning upon free skb

2013-03-14 Thread Arend van Spriel
Hi Dave, Sorry to bother. Today during testing I ran into two warnings, which given their occurrence are fired in the same code path: kernel/softirq.c:99:__local_bh_disable(): WARN_ON_ONCE(in_irq()); kernel/softirq.c:160:_local_bh_enable_ip(): WARN_ON_ONCE(in_irq() ||

need info: softirq warning upon free skb

2013-03-14 Thread Arend van Spriel
Hi Dave, Sorry to bother. Today during testing I ran into two warnings, which given their occurrence are fired in the same code path: kernel/softirq.c:99:__local_bh_disable(): WARN_ON_ONCE(in_irq()); kernel/softirq.c:160:_local_bh_enable_ip(): WARN_ON_ONCE(in_irq() ||

Re: Unable to activate WiFi p2p / WiFi Direct

2013-03-07 Thread Arend van Spriel
On 03/07/13 14:32, Kévin THIERRY wrote: Hi, I've been unable to activate the p2p feature on my WiFi dongle (which otherwise works fine). iwpriv command returns "wlan1 no private ioctls." I'm running Ubuntu 12.04 with kernel 3.5.0-25 and the WiFi dongle is a Netgear model wna1000m (driver

Re: Unable to activate WiFi p2p / WiFi Direct

2013-03-07 Thread Arend van Spriel
On 03/07/13 14:32, Kévin THIERRY wrote: Hi, I've been unable to activate the p2p feature on my WiFi dongle (which otherwise works fine). iwpriv command returns wlan1 no private ioctls. I'm running Ubuntu 12.04 with kernel 3.5.0-25 and the WiFi dongle is a Netgear model wna1000m (driver

Re: [PATCH -v3 16/23] drivers/net: rename random32() to prandom_u32()

2013-03-04 Thread Arend van Spriel
oubelat Cc: Bing Zhao Cc: Brett Rudley Cc: Arend van Spriel Cc: "Franky (Zhenhui) Lin" Cc: Hante Meuleman Cc: brcm80211-dev-l...@broadcom.com Cc: net...@vger.kernel.org Cc: linux-h...@vger.kernel.org Cc: linux-wirel...@vger.kernel.org --- * Changes from v2 - add Acked-by: line - add

Re: [PATCH -v3 16/23] drivers/net: rename random32() to prandom_u32()

2013-03-04 Thread Arend van Spriel
On 03/04/13 13:58, Akinobu Mita wrote: Use more preferable function name which implies using a pseudo-random number generator. Signed-off-by: Akinobu Mitaakinobu.m...@gmail.com Acked-by: Thomas Sailert.sai...@alumni.ethz.ch Acked-by: Bing Zhaobz...@marvell.com [mwifiex] Cc: David S.

Re: [git.k.o] gitweb->cgit: Re-add Git snapshot tarball feature

2013-03-03 Thread Arend van Spriel
On 03/03/13 12:34, Sedat Dilek wrote: Hi, unfortunately, the Git snapshot tarball feature was dropped when switching from gitweb->cgit interface. Just curious. I am looking at gitweb and cgit for our internal repositories and still deciding so I would like to know what "your" main

Re: [git.k.o] gitweb-cgit: Re-add Git snapshot tarball feature

2013-03-03 Thread Arend van Spriel
On 03/03/13 12:34, Sedat Dilek wrote: Hi, unfortunately, the Git snapshot tarball feature was dropped when switching from gitweb-cgit interface. Just curious. I am looking at gitweb and cgit for our internal repositories and still deciding so I would like to know what your main motivation

Re: checkpatch bailing out

2013-03-02 Thread Arend van Spriel
On 03/02/13 14:07, Joe Perches wrote: On Sat, 2013-03-02 at 13:02 +0100, Arend van Spriel wrote: With my laptop being broken I have to work on a server provided by my employer and I am preparing some patches for submission. So I intended to run checkpatch, but I get the following message after

checkpatch bailing out

2013-03-02 Thread Arend van Spriel
With my laptop being broken I have to work on a server provided by my employer and I am preparing some patches for submission. So I intended to run checkpatch, but I get the following message after which the script bails out: $ git format-patch -1 --stdout | scripts/checkpatch.pl - Nested

checkpatch bailing out

2013-03-02 Thread Arend van Spriel
With my laptop being broken I have to work on a server provided by my employer and I am preparing some patches for submission. So I intended to run checkpatch, but I get the following message after which the script bails out: $ git format-patch -1 --stdout | scripts/checkpatch.pl - Nested

Re: checkpatch bailing out

2013-03-02 Thread Arend van Spriel
On 03/02/13 14:07, Joe Perches wrote: On Sat, 2013-03-02 at 13:02 +0100, Arend van Spriel wrote: With my laptop being broken I have to work on a server provided by my employer and I am preparing some patches for submission. So I intended to run checkpatch, but I get the following message after

Re: linux-next: Tree for Feb 15

2013-02-15 Thread Arend van Spriel
On 02/15/2013 08:42 AM, Stephen Rothwell wrote: > Hi all, > > News: Yesterday was the 5th anniversary of linux-next! I can't > believe I am still doing this :-) Was it a big celebration? ;-) Keep up the good work. Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe

Re: linux-next: Tree for Feb 15

2013-02-15 Thread Arend van Spriel
On 02/15/2013 08:42 AM, Stephen Rothwell wrote: Hi all, News: Yesterday was the 5th anniversary of linux-next! I can't believe I am still doing this :-) Was it a big celebration? ;-) Keep up the good work. Gr. AvS -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [ 61/61] drm/nouveau: add lockdep annotations

2013-02-13 Thread Arend van Spriel
On 02/13/2013 10:43 AM, Ben Skeggs wrote: > On Wed, 2013-02-13 at 10:33 +0100, Arend van Spriel wrote: >> On 02/13/2013 04:35 AM, Peter Hurley wrote: >>> On Tue, 2013-02-12 at 12:35 -0800, Greg Kroah-Hartman wrote: >>>> 3.7-stable review patch. If anyone has any

Re: [ 61/61] drm/nouveau: add lockdep annotations

2013-02-13 Thread Arend van Spriel
On 02/13/2013 04:35 AM, Peter Hurley wrote: > On Tue, 2013-02-12 at 12:35 -0800, Greg Kroah-Hartman wrote: >> 3.7-stable review patch. If anyone has any objections, please let me know. > > FWIW, I never saw this on 3.7 but it happened 1st time on 3.8-rcX > I haven't tested this fix either.

Re: [ 61/61] drm/nouveau: add lockdep annotations

2013-02-13 Thread Arend van Spriel
On 02/13/2013 04:35 AM, Peter Hurley wrote: On Tue, 2013-02-12 at 12:35 -0800, Greg Kroah-Hartman wrote: 3.7-stable review patch. If anyone has any objections, please let me know. FWIW, I never saw this on 3.7 but it happened 1st time on 3.8-rcX I haven't tested this fix either. Dito. Gr.

Re: [ 61/61] drm/nouveau: add lockdep annotations

2013-02-13 Thread Arend van Spriel
On 02/13/2013 10:43 AM, Ben Skeggs wrote: On Wed, 2013-02-13 at 10:33 +0100, Arend van Spriel wrote: On 02/13/2013 04:35 AM, Peter Hurley wrote: On Tue, 2013-02-12 at 12:35 -0800, Greg Kroah-Hartman wrote: 3.7-stable review patch. If anyone has any objections, please let me know. FWIW, I

Re: Wifi basics documents

2013-02-08 Thread Arend van Spriel
On 02/08/2013 10:53 AM, sl reddy wrote: > any successions will be helpful for me My *suggestion* would be: http://wireless.kernel.org/en/developers/Documentation For what it is worth, below is some terrible ascii art. Gr. AvS Fullmac model: user-space (libnl)

Re: Wifi basics documents

2013-02-08 Thread Arend van Spriel
On 02/08/2013 07:55 AM, Onteddu Slreddy wrote: > Hello All, > > > I recently joined this group the group. > > Can anybody suggest me places where I can get Documents which will explain > wifi Architecture in brief i would like to know details like > > In Linux for embedded systems: >

Re: Wifi basics documents

2013-02-08 Thread Arend van Spriel
On 02/08/2013 07:55 AM, Onteddu Slreddy wrote: Hello All, I recently joined this group the group. Can anybody suggest me places where I can get Documents which will explain wifi Architecture in brief i would like to know details like In Linux for embedded systems: What is

Re: Wifi basics documents

2013-02-08 Thread Arend van Spriel
On 02/08/2013 10:53 AM, sl reddy wrote: any successions will be helpful for me My *suggestion* would be: http://wireless.kernel.org/en/developers/Documentation For what it is worth, below is some terrible ascii art. Gr. AvS Fullmac model: user-space (libnl)

Re: [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-07 Thread Arend van Spriel
> Removed now unused stack variables. > Removed unnecessary parentheses. > Neatened alignment. for brcm80211 driver files listed below: Acked-by: Arend van Spriel > Signed-off-by: Joe Perches > --- > Let me know if you want multiple small patches instead. > > drivers/ne

Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable

2013-02-07 Thread Arend van Spriel
512 bytes on stack > > Cc: Brett Rudley > Cc: Arend van Spriel > Cc: "Franky (Zhenhui) Lin" > Cc: Hante Meuleman > Cc: "John W. Linville" > Cc: Seth Forshee > Cc: Pieter-Paul Giesberts > Cc: Hauke Mehrtens > Cc: linux-wirel...@vger.kernel.or

Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable

2013-02-07 Thread Arend van Spriel
On 02/07/2013 09:19 PM, Joe Perches wrote: > On Thu, 2013-02-07 at 13:13 -0700, Tim Gardner wrote: >> Dynamically allocate the probe response template which >> avoids potential stack corruption. Observed with smatch: > > trivial: > >> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c

Re: [PATCH wireless-next] brcmsmac: fix u16 overflow warning

2013-02-07 Thread Arend van Spriel
Cc: Pieter-Paul Giesberts > Cc: Seth Forshee > Cc: Hauke Mehrtens > Cc: linux-wirel...@vger.kernel.org > Cc: brcm80211-dev-l...@broadcom.com > Cc: net...@vger.kernel.org Acked-by: Arend van Spriel > Signed-off-by: Tim Gardner > --- > drivers/net/wireless/brcm80211/brcmsm

Re: [PATCH wireless-next] brcmsmac: fix u16 overflow warning

2013-02-07 Thread Arend van Spriel
Giesberts piete...@broadcom.com Cc: Seth Forshee seth.fors...@canonical.com Cc: Hauke Mehrtens ha...@hauke-m.de Cc: linux-wirel...@vger.kernel.org Cc: brcm80211-dev-l...@broadcom.com Cc: net...@vger.kernel.org Acked-by: Arend van Spriel ar...@broadcom.com Signed-off-by: Tim Gardner tim.gard

Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable

2013-02-07 Thread Arend van Spriel
On 02/07/2013 09:19 PM, Joe Perches wrote: On Thu, 2013-02-07 at 13:13 -0700, Tim Gardner wrote: Dynamically allocate the probe response template which avoids potential stack corruption. Observed with smatch: trivial: diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c

Re: [PATCH wireless-next] brcmsmac: avoid 512 byte stack variable

2013-02-07 Thread Arend van Spriel
: Brett Rudley brud...@broadcom.com Cc: Arend van Spriel ar...@broadcom.com Cc: Franky (Zhenhui) Lin fran...@broadcom.com Cc: Hante Meuleman meule...@broadcom.com Cc: John W. Linville linvi...@tuxdriver.com Cc: Seth Forshee seth.fors...@canonical.com Cc: Pieter-Paul Giesberts piete...@broadcom.com

Re: [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-07 Thread Arend van Spriel
variables. Removed unnecessary parentheses. Neatened alignment. for brcm80211 driver files listed below: Acked-by: Arend van Spriel ar...@broadcom.com Signed-off-by: Joe Perches j...@perches.com --- Let me know if you want multiple small patches instead. drivers/net/wireless/brcm80211/brcmfmac

Re: listing drivers

2013-01-23 Thread Arend van Spriel
On 01/23/2013 04:30 PM, Thiago Farina wrote: > Hi, > > On Tue, Jan 22, 2013 at 12:27 PM, Arend van Spriel wrote: >> On 01/22/2013 02:46 PM, Thiago Farina wrote: >>> Hi folks, >>> >>> Is there a way to list the drivers installed/used in my desktop and &g

Re: listing drivers

2013-01-23 Thread Arend van Spriel
On 01/23/2013 04:30 PM, Thiago Farina wrote: Hi, On Tue, Jan 22, 2013 at 12:27 PM, Arend van Spriel ar...@broadcom.com wrote: On 01/22/2013 02:46 PM, Thiago Farina wrote: Hi folks, Is there a way to list the drivers installed/used in my desktop and map them (the path) to their source code

Re: listing drivers

2013-01-22 Thread Arend van Spriel
On 01/22/2013 02:46 PM, Thiago Farina wrote: > Hi folks, > > Is there a way to list the drivers installed/used in my desktop and > map them (the path) to their source code in the linux kernel tree? This might work for you (if using bash): for m in $(cat /proc/modules | gawk '{ print $1; }');do

Re: listing drivers

2013-01-22 Thread Arend van Spriel
On 01/22/2013 02:46 PM, Thiago Farina wrote: Hi folks, Is there a way to list the drivers installed/used in my desktop and map them (the path) to their source code in the linux kernel tree? This might work for you (if using bash): for m in $(cat /proc/modules | gawk '{ print $1; }');do

3.8-rc2: lockdep warning in nouveau driver

2013-01-09 Thread Arend van Spriel
Maybe this one is already known, but I did not find a post about it. So here it is. Regards, Arend == [9.422018] usb 1-1.2: new high-speed USB device number 4 using ehci-pci [9.436177] [TTM] Zone kernel: Available

3.8-rc2: lockdep warning in nouveau driver

2013-01-09 Thread Arend van Spriel
Maybe this one is already known, but I did not find a post about it. So here it is. Regards, Arend == [9.422018] usb 1-1.2: new high-speed USB device number 4 using ehci-pci [9.436177] [TTM] Zone kernel: Available

3.8-rc1: nouveau: X window session not starting

2013-01-05 Thread Arend van Spriel
Not sure if it is a kernel issue or user-space. Truth is probably somewhere in the middle. It popped up moving to 3.8-rc1 using nouveau. Using nvidia's driver works fine. With nouveau, after entering login credentials in lightDM the user session does not start and I am back at the lightDM login

3.8-rc1: nouveau: X window session not starting

2013-01-05 Thread Arend van Spriel
Not sure if it is a kernel issue or user-space. Truth is probably somewhere in the middle. It popped up moving to 3.8-rc1 using nouveau. Using nvidia's driver works fine. With nouveau, after entering login credentials in lightDM the user session does not start and I am back at the lightDM login

Re: [PATCH] brcmsmac: initialize morepending in brcms_b_recv()

2012-12-23 Thread Arend van Spriel
arning seems to be invalid except when RXBND is defined as zero, which would make the whole function totally bogus. Would be good to have a WARN_ON(!RXBND) in brcms_b_attach(). I don't like pleasing a compiler with unnecessary initializers but I am also for builds with zero warnings. So... Acked-by: Aren

Re: [PATCH] brcmsmac: initialize morepending in brcms_b_recv()

2012-12-23 Thread Arend van Spriel
to be invalid except when RXBND is defined as zero, which would make the whole function totally bogus. Would be good to have a WARN_ON(!RXBND) in brcms_b_attach(). I don't like pleasing a compiler with unnecessary initializers but I am also for builds with zero warnings. So... Acked-by: Arend van Spriel ar

Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Arend van Spriel
On 11/30/2012 09:25 PM, Luis R. Rodriguez wrote: > On Fri, Nov 30, 2012 at 11:18 AM, Luis R. Rodriguez > wrote: >> On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel >> wrote: >>> So what is the rationale here. During mainlining our drivers we had to >>> re

Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Arend van Spriel
On 11/29/2012 09:45 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Turns out a few drivers have strayed away from using the > spinlock_t typedef and decided to use struct spinlock > directly. This series converts these drivers to use > spinlock_t. Each change has been compile

Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Arend van Spriel
On 11/29/2012 09:45 PM, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@do-not-panic.com Turns out a few drivers have strayed away from using the spinlock_t typedef and decided to use struct spinlock directly. This series converts these drivers to use spinlock_t. Each change has

Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Arend van Spriel
On 11/30/2012 09:25 PM, Luis R. Rodriguez wrote: On Fri, Nov 30, 2012 at 11:18 AM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel ar...@broadcom.com wrote: So what is the rationale here. During mainlining our drivers we had to remove all

Re: Streamlining Developer's Certificate of Origin, Signed-off-by tag

2012-11-20 Thread Arend van Spriel
On 11/20/2012 10:16 PM, Alan Cox wrote: On Tue, 20 Nov 2012 12:59:40 -0800 "Luis R. Rodriguez" wrote: Thoughts? Nobody is stopping you putting a copy on a web site. Correct me if I am wrong, but I think what Luis is referring to, is the fact that the 'Developer's Certificate of Origin'

Re: Streamlining Developer's Certificate of Origin, Signed-off-by tag

2012-11-20 Thread Arend van Spriel
On 11/20/2012 10:16 PM, Alan Cox wrote: On Tue, 20 Nov 2012 12:59:40 -0800 Luis R. Rodriguez mcg...@do-not-panic.com wrote: Thoughts? Nobody is stopping you putting a copy on a web site. Correct me if I am wrong, but I think what Luis is referring to, is the fact that the 'Developer's

Re: PROBLEM: REGRESSION in drivers/platform/x86/dell-laptop.c

2012-11-18 Thread Arend van Spriel
switch is engaged, leading to hang due to partial initialization of hardware. Tested-by: Reviewed-by: Arend van Spriel Reviewed-by: Hante Meuleman Signed-off-by: Piotr Haber Signed-off-by: Arend van Spriel Signed-off-by: John W. Linville Maybe I should resubmit

Re: PROBLEM: REGRESSION in drivers/platform/x86/dell-laptop.c

2012-11-18 Thread Arend van Spriel
a bug when device is being started while RfKill switch is engaged, leading to hang due to partial initialization of hardware. Tested-by: drag...@op.pl Reviewed-by: Arend van Spriel ar...@broadcom.com Reviewed-by: Hante Meuleman meule...@broadcom.com Signed-off-by: Piotr Haber

Re: linux-next: manual merge of the wireless-next tree with the wireless tree

2012-11-15 Thread Arend van Spriel
On 11/15/2012 03:17 AM, Stephen Rothwell wrote: Hi John, Today's linux-next merge of the wireless-next tree got a conflict in drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c between commit d61f978b8f26 ("brcmfmac: fix typo in CONFIG_BRCMISCAN") from the tree and commit f07998959d57

Re: linux-next: manual merge of the wireless-next tree with the wireless tree

2012-11-15 Thread Arend van Spriel
On 11/15/2012 03:17 AM, Stephen Rothwell wrote: Hi John, Today's linux-next merge of the wireless-next tree got a conflict in drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c between commit d61f978b8f26 (brcmfmac: fix typo in CONFIG_BRCMISCAN) from the tree and commit f07998959d57

Re: [PATCH -next] wireless: brcmfmac: fix printk format warning

2012-11-13 Thread Arend van Spriel
On 11/13/2012 04:55 PM, Randy Dunlap wrote: On 11/01/2012 12:31 PM, Johannes Berg wrote: On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: On 11/01/2012 06:43 PM, Randy Dunlap wrote: From: Randy Dunlap Fix printk format warning for ssid_len, which is a size_t: drivers/net

Re: [PATCH -next] wireless: brcmfmac: fix printk format warning

2012-11-13 Thread Arend van Spriel
On 11/13/2012 04:55 PM, Randy Dunlap wrote: On 11/01/2012 12:31 PM, Johannes Berg wrote: On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: On 11/01/2012 06:43 PM, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix printk format warning for ssid_len, which is a size_t

Re: [PATCH -next] wireless: brcmfmac: fix printk format warning

2012-11-01 Thread Arend van Spriel
On 11/01/2012 08:31 PM, Johannes Berg wrote: > On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> Fix printk format warning for ssid_len, which is a size_t: >>>

Re: [PATCH -next] wireless: brcmfmac: fix printk format warning

2012-11-01 Thread Arend van Spriel
On 11/01/2012 06:43 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix printk format warning for ssid_len, which is a size_t: > > drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format > '%d' expects type 'int', but argument 4 has type 'size_t' > > Signed-off-by:

Re: [PATCH -next] wireless: brcmfmac: fix printk format warning

2012-11-01 Thread Arend van Spriel
On 11/01/2012 06:43 PM, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix printk format warning for ssid_len, which is a size_t: drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'

Re: [PATCH -next] wireless: brcmfmac: fix printk format warning

2012-11-01 Thread Arend van Spriel
On 11/01/2012 08:31 PM, Johannes Berg wrote: On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: On 11/01/2012 06:43 PM, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix printk format warning for ssid_len, which is a size_t: drivers/net/wireless/brcm80211/brcmfmac

Re: x86_64: undefined symbol 'mcount' in 3.7-rc1

2012-10-31 Thread Arend van Spriel
On 10/31/2012 07:44 PM, Steven Rostedt wrote: On Wed, 2012-10-17 at 22:23 +0200, Arend van Spriel wrote: Hi Steven, I have nightly test machines upgraded to 3.7-rc1 and on the 64-bit platform I get MODPOST warning on 'mcount'. It is conditionally exported in x8664_ksyms_64.c: #ifdef

Re: x86_64: undefined symbol 'mcount' in 3.7-rc1

2012-10-31 Thread Arend van Spriel
On 10/31/2012 07:44 PM, Steven Rostedt wrote: On Wed, 2012-10-17 at 22:23 +0200, Arend van Spriel wrote: Hi Steven, I have nightly test machines upgraded to 3.7-rc1 and on the 64-bit platform I get MODPOST warning on 'mcount'. It is conditionally exported in x8664_ksyms_64.c: #ifdef

Re: Linux 3.7-rc3

2012-10-30 Thread Arend van Spriel
On 10/30/2012 01:10 AM, Rafael J. Wysocki wrote: On Sunday, October 28, 2012 12:59:49 PM Linus Torvalds wrote: It's been a week, time for -rc3! Nothing particularly stands out here. Lots of small fixes, exemplified by the series of memory leak fixes in usb serial drivers. Just a lot of random

Re: Linux 3.7-rc3

2012-10-30 Thread Arend van Spriel
On 10/30/2012 01:10 AM, Rafael J. Wysocki wrote: On Sunday, October 28, 2012 12:59:49 PM Linus Torvalds wrote: It's been a week, time for -rc3! Nothing particularly stands out here. Lots of small fixes, exemplified by the series of memory leak fixes in usb serial drivers. Just a lot of random

Re: lockdep info message

2012-10-26 Thread Arend van Spriel
On 10/26/2012 01:25 PM, Peter Zijlstra wrote: On Fri, 2012-10-26 at 12:15 +0200, Arend van Spriel wrote: Hi Peter and/or Ingo, I am working on a driver (brcmfmac) and when unloading it or unplugging the device I get this info message (see below) upon calling cancel_work_sync(). Just wondering

lockdep info message

2012-10-26 Thread Arend van Spriel
Hi Peter and/or Ingo, I am working on a driver (brcmfmac) and when unloading it or unplugging the device I get this info message (see below) upon calling cancel_work_sync(). Just wondering if there is something I need to do in the driver or should it be done in workqueue code. Regards,

lockdep info message

2012-10-26 Thread Arend van Spriel
Hi Peter and/or Ingo, I am working on a driver (brcmfmac) and when unloading it or unplugging the device I get this info message (see below) upon calling cancel_work_sync(). Just wondering if there is something I need to do in the driver or should it be done in workqueue code. Regards,

Re: lockdep info message

2012-10-26 Thread Arend van Spriel
On 10/26/2012 01:25 PM, Peter Zijlstra wrote: On Fri, 2012-10-26 at 12:15 +0200, Arend van Spriel wrote: Hi Peter and/or Ingo, I am working on a driver (brcmfmac) and when unloading it or unplugging the device I get this info message (see below) upon calling cancel_work_sync(). Just wondering

Re: [BUG 3.7-rc1] nouveau cli->mutex possible recursive locking detected

2012-10-25 Thread Arend van Spriel
On 10/24/2012 02:45 PM, Arend van Spriel wrote: On 10/24/2012 01:14 PM, Arend van Spriel wrote: On 10/16/2012 02:43 PM, Stanislaw Gruszka wrote: I have this lockdep warning on wireless-testing tree based on 3.7-rc1 (no other patches except wireless bits

Re: [BUG 3.7-rc1] nouveau cli->mutex possible recursive locking detected

2012-10-25 Thread Arend van Spriel
On 10/24/2012 02:45 PM, Arend van Spriel wrote: On 10/24/2012 01:14 PM, Arend van Spriel wrote: On 10/16/2012 02:43 PM, Stanislaw Gruszka wrote: I have this lockdep warning on wireless-testing tree based on 3.7-rc1 (no other patches except wireless bits

<    5   6   7   8   9   10   11   >