al chip data pointer.
>
> Signed-off-by: Olliver Schinagl <oli...@schinagl.nl>
Reviewed-by: Ariel D'Alessandro <ar...@vanguardiasur.com.ar>
> ---
> Hi,
>
> This is a resend of a patch-series I sent last year. There was no technical
> related feedback and so
al chip data pointer.
>
> Signed-off-by: Olliver Schinagl
Reviewed-by: Ariel D'Alessandro
> ---
> Hi,
>
> This is a resend of a patch-series I sent last year. There was no technical
> related feedback and so I am re-sending the patch as is. I did rebase it to
> Linus's c
quot;, ret);
> + return ret;
I think you're missing some cleanup routine here. You have a previous
call to clk_prepare_enable(), so you may have a call to
clk_disable_unprepare() here in order to exit cleanly, don't you think?
> + }
> +
> + platform_set_drvdata(pdev,
dev);
> +
> + clk_disable_unprepare(p->clk);
> +
> + return pwmchip_remove(>chip);
AFAIK, pwmchip_remove() may return busy if the PWM chip provides a PWM
device that is still requested, so you shouldn't disable the clock
before you ensure the PWM chip has been successfuly remove
ret = pwmchip_add(>chip);
> + if (ret < 0) {
> + dev_err(>dev, "Failed to add PWM chip: %d\n", ret);
> + return ret;
I think you're missing some cleanup routine here. You have a previous
call to clk_prepare_enable(), so you may have a call to
clk_disable_
*p = platform_get_drvdata(pdev);
> +
> + clk_disable_unprepare(p->clk);
> +
> + return pwmchip_remove(>chip);
AFAIK, pwmchip_remove() may return busy if the PWM chip provides a PWM
device that is still requested, so you shouldn't disable the clock
before you ensure the PWM chip has
6 matches
Mail list logo
