From: Arseny Solokha
When DMA-API debugging is enabled in the kernel, it spews the following
upon upping the link:
WARNING: at lib/dma-debug.c:1135
Modules linked in:
CPU: 0 PID: 0 Comm: swapper/0 Tainted: GW O 3.18.0-rc7 #1
task: c0720340 ti: effe2000 task.ti: c075
NIP: c01d7c1c
From: Arseny Solokha
When DMA-API debugging is enabled in the kernel, it spews the following
upon upping the link:
fsl-gianfar ffe25000.ethernet: DMA-API: device driver failed to check map
error[device address=0x05f41012] [size=90 bytes] [map-
WARNING: at lib/dma-debug.c:1135
Modules
versions. And while I personally doesn't have
any strong evidence of this, there's no reason to let these possible
failures live any longer.
Arseny Solokha (2):
gianfar: handle map error in gfar_new_rxbdp()
gianfar: handle map error in gfar_start_xmit()
drivers/net/ethernet/freescale
From: Arseny Solokha
Commit 8dccddbc2368 ("OHCI: final fix for NVIDIA problems (I hope)")
introduced into 3.1.9 broke boot on e.g. Freescale P2020DS development
board. The code path that was previously specific to NVIDIA controllers
had then become taken for all chips.
However,
From: Arseny Solokha
Commit 8dccddbc2368 ("OHCI: final fix for NVIDIA problems (I hope)")
introduced into 3.1.9 broke boot on e.g. Freescale P2020DS development
board. The code path that was previously specific to NVIDIA controllers
had then become taken for all chips.
However,
85xx: workaround for chips with MSI hardware errata") makes
use of it.
v2: Added a brief explanation to each patch description of why removed
functions are unused, as suggested by Michael Ellerman.
Arseny Solokha (4):
powerpc/boot: drop planetcore_set_serial_speed
kvm/ppc/mpic
Drop planetcore_set_serial_speed() which had no users since its
inception in commit fec6047047fd ("[POWERPC] bootwrapper: Add PlanetCore
firmware support") in 2007.
Signed-off-by: Arseny Solokha
---
arch/powerpc/boot/planetcore.c | 33 -
arch/po
-June/023867.html
Signed-off-by: Arseny Solokha
Cc: Jia Hongtao
---
arch/powerpc/include/asm/mpic.h | 11 ---
arch/powerpc/sysdev/mpic.c | 25 -
2 files changed, 36 deletions(-)
diff --git a/arch/powerpc/include/asm/mpic.h b/arch/powerpc/include/asm/mpic.h
Drop unused static procedure which doesn't have callers within its
translation unit. It had been already removed independently in QEMU[1]
from the OpenPIC implementation borrowed from the kernel.
[1] https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01812.html
Signed-off-by: A
Drop ucc_slow_poll_transmitter_now() which has no users since its
inception in 2007 in commit 986585385131 ("[POWERPC] Add QUICC
Engine (QE) infrastructure").
Signed-off-by: Arseny Solokha
---
arch/powerpc/include/asm/ucc_slow.h | 13 -
arch/powerpc/sysdev/qe_lib/ucc_s
> On Fri, 2015-03-20 at 10:56 +0700, Arseny Solokha wrote:
>> This series removes unused functions from powerpc tree that I've been able
>> to discover.
>>
>> Two machines at hands, e300 and e500 based, boot and run without regressions
>> on my workload with
th MSI hardware errata") makes
use of it.
v2: Added a brief explanation to each patch description of why removed
functions are unused, as suggested by Michael Ellerman.
Signed-off-by: Arseny Solokha
---
arch/powerpc/kvm/mpic.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/arch/
> On Fri, 2015-03-20 at 11:55 +0700, Arseny Solokha wrote:
>>
>> And by the way, while revisiting the series I've noticed that though the
>> patch
>> 4/4 basically reverts [1], it leaves
>>
>> #define MPIC_GREG_GLOBAL_CONF_10x000
> @@ -1676,31 +1666,6 @@ void __init mpic_init(struct mpic *mpic)
> mpic_err_int_init(mpic, MPIC_FSL_ERR_INT);
> }
>
> -void __init mpic_set_clk_ratio(struct mpic *mpic, u32 clock_ratio)
> -{
> - u32 v;
> -
> - v = mpic_read(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1);
> - v
> On Fri, 2015-01-30 at 19:08 +0700, Arseny Solokha wrote:
>> MMU_NO_CONTEXT is conditionally defined as 0 or (unsigned int)-1. However,
>> in __flush_tlb_page() a corresponding variable is only tested for open
>> coded 0, which can cause NULL pointer dereference
Function __flush_tlb_page() must only be called for user contexts, so
put in extra hardening to warn on calling it for kernel context.
Signed-off-by: Arseny Solokha
---
arch/powerpc/mm/tlb_nohash.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/mm
NULL, thus eliminate confusion
between different values of MMU_NO_CONTEXT and avoid disabling and then
re-enabling preemption unnecessarily.
Signed-off-by: Arseny Solokha
---
arch/powerpc/mm/tlb_nohash.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/power
> On Fri, 2015-01-30 at 19:08 +0700, Arseny Solokha wrote:
>> MMU_NO_CONTEXT is conditionally defined as 0 or (unsigned int)-1.
>
> For nohash it is specifically -1.
>> However, in __flush_tlb_page() a corresponding variable is only tested
>> for open coded 0, w
> On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote:
>> Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
>> mpic_set_serial_int().
>
> I'm always happy to remove unused code, but the interesting question is why
> are
> they unused? Please tel
> If I just get a patch saying "removed unused foo()", I have to go and dig and
> find out:
> - was it recently added and will be used soon?
> - is it ancient and never used, if so can we work out why, ie. feature X
> never landed so this code is no longer needed.
> - is it old code that
> On Sat, 6 Dec 2014, Arseny Solokha wrote:
>
>> From: Arseny Solokha
>>
>> Commit 8dccddbc2368 ("OHCI: final fix for NVIDIA problems (I hope)")
>> introduced into 3.1.9 broke boot on e.g. Freescale P2020DS development
>> board. The code path that
st
in general. But I can't obviously express any strong point in support of
the series, so it's completely OK to leave things as is.
Arseny Solokha (4):
powerpc/boot: drop planetcore_set_serial_speed
kvm/ppc/mpic: drop unused IRQ_testbit
powrepc/qe: drop unused ucc_slow_poll_
Drop planetcore_set_serial_speed() which had no users since its
inception in commit fec6047047fd ("[POWERPC] bootwrapper: Add PlanetCore
firmware support") in 2007.
Signed-off-by: Arseny Solokha
---
arch/powerpc/boot/planetcore.c | 33 -
arch/po
Drop unused static procedure which doesn't have callers within its
translation unit. It had been already removed independently in QEMU[1]
from the OpenPIC implementation borrowed from the kernel.
[1] https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01812.html
Signed-off-by: A
ren't
exported.
[1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2006-June/023867.html
Signed-off-by: Arseny Solokha
Cc: hongtao@freescale.com
---
arch/powerpc/include/asm/mpic.h | 20
arch/powerpc/sysdev/mpic.c | 35 ---
2 fil
Drop ucc_slow_poll_transmitter_now() which has no users since its
inception in 2007 in commit 986585385131 ("[POWERPC] Add QUICC
Engine (QE) infrastructure").
Signed-off-by: Arseny Solokha
---
arch/powerpc/include/asm/ucc_slow.h | 13 -
arch/powerpc/sysdev/qe_lib/ucc_s
This series removes unused functions from powerpc tree that I've been
able to discover.
Arseny Solokha (4):
powerpc/boot: drop planetcore_set_serial_speed
kvm/ppc/mpic: drop unused IRQ_testbit
powrepc/qe: drop unused ucc_slow_poll_transmitter_now
powerpc/mpic: remove unused func
Drop ucc_slow_poll_transmitter_now() which has no users.
Signed-off-by: Arseny Solokha
---
arch/powerpc/include/asm/ucc_slow.h | 13 -
arch/powerpc/sysdev/qe_lib/ucc_slow.c | 5 -
2 files changed, 18 deletions(-)
diff --git a/arch/powerpc/include/asm/ucc_slow.h
b/arch
Drop unused static procedure which doesn't have callers within its
translation unit.
Signed-off-by: Arseny Solokha
Cc: Alexander Graf
Cc: Gleb Natapov
Cc: Paolo Bonzini
---
arch/powerpc/kvm/mpic.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/arch/powerpc/kvm/mpic.c b/arch/po
Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
mpic_set_serial_int().
Signed-off-by: Arseny Solokha
---
arch/powerpc/include/asm/mpic.h | 16
arch/powerpc/sysdev/mpic.c | 35 ---
2 files changed, 51 deletions(-)
diff
Drop planetcore_set_serial_speed() which had no users since its inception.
Signed-off-by: Arseny Solokha
---
arch/powerpc/boot/planetcore.c | 33 -
arch/powerpc/boot/planetcore.h | 3 ---
2 files changed, 36 deletions(-)
diff --git a/arch/powerpc/boot
load again:
at24 0-0050: 32768 byte 24c256 EEPROM, writable, 64 bytes/write
Cc: Adrian Bunk
Cc: Bartosz Golaszewski
Cc: Srinivas Kandagatla
Cc: sta...@vger.kernel.org # v5.2+
Signed-off-by: Arseny Solokha
---
drivers/misc/eeprom/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dr
>> /*
>> * Map and check POR Device Status Register 2
>> - * (PORDEVSR2) at 0xE0014
>> + * (PORDEVSR2) at 0xE0014. Note than while MPC8533
>> + * and MPC8544 indicate SEC frequency ratio
>> +
.
Changes from v2:
- left Device Tree compatibles in place
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c-mpc.c | 37 +++--
1 file changed, 15 insertions(+), 22 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index
caller, resulting in a division by zero
for the majority of processors supported by the module.
Avoid division by zero by obtaining the actual I2C clock prescaler
in mpc_i2c_setup_8xxx() unconditionally regardless of the passed clock
value.
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c
44 in this regard, according to AN2919 "Determining the I2C
Frequency Divider Ratio for SCL".
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c-mpc.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/bu
.
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c-mpc.c | 52 +---
1 file changed, 15 insertions(+), 37 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index 8d60db0080f6..e0f059687c2d 100644
--- a/drivers/i2c
urrently covers more SoCs. Hardcoding it
is also wrong for some SoCs as it can be configured on board during POR.
Arseny Solokha (4):
i2c: mpc: get MPC8xxx I2C clock prescaler before using it in
calculations
i2c: mpc: unify obtaining the MPC8533/44 I2C clock prescaler w/
MPC8xxx
those SoCs.
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c-mpc.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index f47916466b82..8d60db0080f6 100644
--- a/drivers/i2c/busses/i2c-mpc.c
+++ b
urrently covers more SoCs. Hardcoding it
is also wrong for some SoCs as it can be configured on board during POR.
This series is an exact copy of [1] which has received no feedback so far.
[1] https://marc.info/?l=linux-i2c&m=151030076114573&w=2
Arseny Solokha (4):
i2c: mpc: get MPC8
44 in this regard, according to AN2919 "Determining the I2C
Frequency Divider Ratio for SCL".
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c-mpc.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/bu
caller, resulting in a division by zero
for the majority of processors supported by the module.
Avoid division by zero by obtaining the actual I2C clock prescaler
in mpc_i2c_setup_8xxx() unconditionally regardless of the passed clock
value.
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c
those SoCs.
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c-mpc.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index 648a5afded64..aac0ec6dc5fc 100644
--- a/drivers/i2c/busses/i2c-mpc.c
+++ b
.
Signed-off-by: Arseny Solokha
---
drivers/i2c/busses/i2c-mpc.c | 52 +---
1 file changed, 15 insertions(+), 37 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index aac0ec6dc5fc..ad9af3ca35aa 100644
--- a/drivers/i2c
From: Arseny Solokha
In spite of switching to paged allocation of Rx buffers, the driver still
called dma_unmap_single() in the Rx queues tear-down path.
The DMA region unmapping code in free_skb_rx_queue() basically predates
the introduction of paged allocation to the driver. While being
h CONFIG_RANDOMIZE_BASE
set.
Fixes: 2b0e86cc5de6 ("powerpc/fsl_booke/32: implement KASLR infrastructure")
Cc: sta...@vger.kernel.org
Signed-off-by: Arseny Solokha
---
arch/powerpc/mm/nohash/kaslr_booke.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/nohash/kaslr_bo
> Le 13/06/2020 à 18:28, Arseny Solokha a écrit :
>> Building the current 5.8 kernel for a e500 machine with
>> CONFIG_RANDOMIZE_BASE set yields the following failure:
>>
>>arch/powerpc/mm/nohash/kaslr_booke.c: In function 'kaslr_early_init':
>>
Hi,
may I also ask to provide ppc_clone3 symbol also for 32-bit powerpc? Otherwise
Michael's patch breaks build for me:
powerpc-e500v2-linux-gnuspe-ld: arch/powerpc/kernel/systbl.o: in function
`sys_call_table':
(.rodata+0x6cc): undefined reference to `ppc_clone3'
make: *** [Makefile:1060:
48 matches
Mail list logo
